From patchwork Fri Nov 17 16:35:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 419 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 670B843355; Fri, 17 Nov 2023 17:37:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3924427D9; Fri, 17 Nov 2023 17:37:43 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id A8B40402EA for ; Fri, 17 Nov 2023 17:37:40 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6b77ab73c6fso1661551b3a.1 for ; Fri, 17 Nov 2023 08:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700239059; x=1700843859; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xbv96xpg3pb9qZabDnbRdE4efcjTu+yTZMl5BgQfCp0=; b=wS/A4Xs4EvUKObThlZFWQICI047GaIDK1cnUDQuJBd482YoGsHQETxEor3mSx1CAeW DAEU0tm7p1aJkAY7srhskMgnPfhRIruIWoe1D58TtDSwr24Naoo+PeTNTACu2K9mefV0 5EO9KzTyXjl3BR5vdDshT5jGjEXt3qWLxgK60Wt5pzxeLWtKXz907T7L7ynRhSDi73xy P/j+Wc1VdqKEOiKdZRWEuN0aARa9TcmCaVYNrIOiJzA0RgWXBX8Gb93OEOpyfQjeSB7G jnNPfamOdK3/6hfVF3GeX1MMF5Y3m+rvIWeEHkjEL/nw2Rwl+CD2JVCNfzD4qLIGsLIO +owQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700239059; x=1700843859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xbv96xpg3pb9qZabDnbRdE4efcjTu+yTZMl5BgQfCp0=; b=BoohjoXvwRDhfQbMWYUhwpv29YRWqwGdjmcixJyGL+hyDYlqyAAlBY74JX9KOknLPN 5bjEEPwnciNu895wbYdrjl7ZT1fCS5VqXnM4D69+zUUknMg4P/XFSG7KGGikDT33dhIG eKICaBDTRPEYPBXRpIdyZ0cviElZLxklbk8keUxvjhk3mAb5hvjuqIkvVWCLSZiVLhGb jN8T1g9LkyInbsohFBidZztdqaLjtFsr8OXryarllUR7DEC/l8Yd+NM8NL+Hxo3cllCM xP3rNEpbXSVSW+SB2fNLfjt07UbSp+uEL3iaMB7pp6ImiMgq+D/UcRe8QTuGMn5r07DE xbJg== X-Gm-Message-State: AOJu0YyRRIojcqcS/CsK1Sr6kdE7qbj2Sol+vw3DRPPzn/0E8RMZLXe2 GsC5pAqD77OsHNZDm5Gv9szmvT7QPlw7b2lsojkMtA== X-Google-Smtp-Source: AGHT+IEj+q7TCRSBB95cPnH1C5WNGNdpVp2mP2KJFzH7oyhMYjF3+lCpKVX4XgOki6OghcBlFGjTkQ== X-Received: by 2002:a05:6a00:8b0e:b0:68f:cbd3:5b01 with SMTP id if14-20020a056a008b0e00b0068fcbd35b01mr7218241pfb.13.1700239059510; Fri, 17 Nov 2023 08:37:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id f22-20020a631016000000b005bd3f34b10dsm1595541pgl.24.2023.11.17.08.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:37:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v7 0/5] dumpcap and pcapng fixes Date: Fri, 17 Nov 2023 08:35:54 -0800 Message-ID: <20231117163729.243188-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230921042349.104150-1-stephen@networkplumber.org> References: <20230921042349.104150-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It fixes issues related to timestamping. The design choices are to maximize performance in the primary process; and do all the time adjustment in the secondary (dumpcap) since the dumpcap needs to system calls anyway to write the result. This patches set changes where the adjustment is calculated into the pcapng portion that opens the output file. All details of the format of timestamp are contained inside pcapng (data hiding). v7 - no change, rebase there were some apply failures by CI v6 - make sure all steps compile v5 - fix format of getpid in capture name v4 - incorporate review feedback v3 - don't use alloca() since can have VLA type issues Stephen Hemminger (5): pdump: fix setting rte_errno on mp error dumpcap: allow multiple invocations pcapng: modify timestamp calculation pcapng: avoid using alloca() test: cleanups to pcapng test app/dumpcap/main.c | 53 ++--- app/test/meson.build | 2 +- app/test/test_pcapng.c | 417 +++++++++++++++++++++++++++------------- lib/graph/graph_pcap.c | 2 +- lib/pcapng/rte_pcapng.c | 156 ++++++--------- lib/pcapng/rte_pcapng.h | 19 +- lib/pdump/rte_pdump.c | 9 +- 7 files changed, 373 insertions(+), 285 deletions(-)