mbox series

[v3,00/11] Unify the PMD coding style

Message ID 20231013060653.1006410-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series Unify the PMD coding style |

Message

Chaoyong He Oct. 13, 2023, 6:06 a.m. UTC 
  This patch series aims to unify the coding style of NFP PMD, make the
logics following the same rules, to make it easier to understand and
extend.
Also prepare for the upcoming vDPA PMD patch series.

---
v2:
* Add some missing modification.
v3:
* Remove the '\t' character in the log statement as the advice of
  reviewer.
---

Chaoyong He (11):
  net/nfp: explicitly compare to null and 0
  net/nfp: unify the indent coding style
  net/nfp: unify the type of integer variable
  net/nfp: standard the local variable coding style
  net/nfp: adjust the log statement
  net/nfp: standard the comment style
  net/nfp: standard the blank character
  net/nfp: unify the guide line of header file
  net/nfp: rename some parameter and variable
  net/nfp: adjust logic to make it more readable
  net/nfp: refact the meson build file

 drivers/net/nfp/flower/nfp_conntrack.c        |   4 +-
 drivers/net/nfp/flower/nfp_flower.c           |  27 +-
 drivers/net/nfp/flower/nfp_flower.h           |  34 +-
 drivers/net/nfp/flower/nfp_flower_cmsg.c      |  18 +-
 drivers/net/nfp/flower/nfp_flower_cmsg.h      |  62 +-
 drivers/net/nfp/flower/nfp_flower_ctrl.c      |  39 +-
 drivers/net/nfp/flower/nfp_flower_ctrl.h      |   6 +-
 .../net/nfp/flower/nfp_flower_representor.c   |  46 +-
 .../net/nfp/flower/nfp_flower_representor.h   |   8 +-
 drivers/net/nfp/meson.build                   |  23 +-
 drivers/net/nfp/nfd3/nfp_nfd3.h               |  39 +-
 drivers/net/nfp/nfd3/nfp_nfd3_dp.c            |  34 +-
 drivers/net/nfp/nfdk/nfp_nfdk.h               |  49 +-
 drivers/net/nfp/nfdk/nfp_nfdk_dp.c            |  14 +-
 drivers/net/nfp/nfp_common.c                  | 775 +++++++++---------
 drivers/net/nfp/nfp_common.h                  | 169 ++--
 drivers/net/nfp/nfp_cpp_bridge.c              | 139 ++--
 drivers/net/nfp/nfp_cpp_bridge.h              |   8 +-
 drivers/net/nfp/nfp_ctrl.h                    |  46 +-
 drivers/net/nfp/nfp_ethdev.c                  | 325 ++++----
 drivers/net/nfp/nfp_ethdev_vf.c               | 195 ++---
 drivers/net/nfp/nfp_flow.c                    | 251 +++---
 drivers/net/nfp/nfp_flow.h                    |  23 +-
 drivers/net/nfp/nfp_ipsec.h                   |  12 +-
 drivers/net/nfp/nfp_logs.h                    |   7 +-
 drivers/net/nfp/nfp_rxtx.c                    | 296 +++----
 drivers/net/nfp/nfp_rxtx.h                    |  36 +-
 drivers/net/nfp/nfpcore/nfp_resource.h        |   2 +-
 28 files changed, 1299 insertions(+), 1388 deletions(-)

Comments

Ferruh Yigit Oct. 16, 2023, 4:50 p.m. UTC | #1 
On 10/13/2023 7:06 AM, Chaoyong He wrote:
> This patch series aims to unify the coding style of NFP PMD, make the
> logics following the same rules, to make it easier to understand and
> extend.
> Also prepare for the upcoming vDPA PMD patch series.
> 
> ---
> v2:
> * Add some missing modification.
> v3:
> * Remove the '\t' character in the log statement as the advice of
>   reviewer.
> ---
> 
> Chaoyong He (11):
>   net/nfp: explicitly compare to null and 0
>   net/nfp: unify the indent coding style
>   net/nfp: unify the type of integer variable
>   net/nfp: standard the local variable coding style
>   net/nfp: adjust the log statement
>   net/nfp: standard the comment style
>   net/nfp: standard the blank character
>   net/nfp: unify the guide line of header file
>   net/nfp: rename some parameter and variable
>   net/nfp: adjust logic to make it more readable
>   net/nfp: refact the meson build file
> 

It is good to take care of the code and update syntax, coding convention
etc, but it also creates noise in the git history and makes backporting
fixes/patches harder.

For a while the driver got lots of refactoring changes, I hope they are
completed with the patches in this release.


Series applied to dpdk-next-net/main, thanks.