From patchwork Fri Oct 13 06:06:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 257 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5F1942354; Fri, 13 Oct 2023 08:07:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5887C402D3; Fri, 13 Oct 2023 08:07:26 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2124.outbound.protection.outlook.com [40.107.93.124]) by mails.dpdk.org (Postfix) with ESMTP id B4832402CB for ; Fri, 13 Oct 2023 08:07:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DALtxeaV5daHWXe6ucDBuabzuKJL8AQ9NwU4FOI4IZeXUJd3MfnS2jKF2pD6waMqNTSs8YO/7DnM9cdVcMb+rGC5N3jbPRnjXIrWZztAnhUGYLJhDXk5vvmFS98BtuaVLLjSAu2TPtr0w7SCjurrEDgF1Y+Qc9Y9sW57nQodp9bfKbrq4wm22xFjM0+9gy3SO+vfyX/Yg6cL/mo5VBmKzGMVRzQTpBv2E4/UWnK/Uv6oba+OGQ8c3M1AOiZceW+gJWlA+t8oRgkCnpiL3N82Xlziw/JIGwyxjx9KhkZhcvGRnli2cTesMrqK5ci5NwAgn+vPDj0J5Z2lr5Sh/oLnHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6bNIK02OkxSuxQgwDJ8VEYHV4ByTal709S0+vgqfQhk=; b=foU/mKeAkaHh42f6AOHjhYhecl9+IOueFYMF/6a21FoOaTGGK3Z4onyUiBX324AryCYcKWvT2PGdPlPg+DeKlwozTXpyXLPyvG02moru922Nq0bCiyRVkAA8DU8Iv+/Q2lc5Pz9hdJ2yHvzQ/8mYV62YZJwY6jMy871tbl3mBbi5Ia2LKpl7Nmhb0y+tJeSU9xJnFbcr5lo51jsgy+n63c8N3LEkVTmEPXf0gIgVTSMQjl35D8vrChfrUCCcu5jMq1Aoxe66GUJFiplkypwU0php9IladncYqszs/rozcb/33jbuBniftxb00aCs1+ThGXNvDGPMSmjoW/UdI8Ar1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bNIK02OkxSuxQgwDJ8VEYHV4ByTal709S0+vgqfQhk=; b=dAlsyqc4GyuPj9gTsBtYCi9SSaearVUfTFYaTKLZUPQoBxCCvw+6sm6YNnhT1IdmGqw4TDpOfSnt3YTpqXMlgRbjvZDnqu6FV97fynMjU9+Yc0OSYwnhnyu4y+H6utxC+J244+s1e+PoNDVId2cDhBCQ7tTaEPCrXjNPgEhxYEU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB6296.namprd13.prod.outlook.com (2603:10b6:510:237::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct 2023 06:07:22 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023 06:07:22 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH v3 00/11] Unify the PMD coding style Date: Fri, 13 Oct 2023 14:06:42 +0800 Message-Id: <20231013060653.1006410-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231012012704.483828-1-chaoyong.he@corigine.com> References: <20231012012704.483828-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR06CA0008.apcprd06.prod.outlook.com (2603:1096:4:186::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB6296:EE_ X-MS-Office365-Filtering-Correlation-Id: c9e2db98-df3e-456d-a6e7-08dbcbb2a9ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFyM7W5K5pKoqiM+gmdoVRu6NGYg0hEvNog2dvVXuZn6wBa7zrGGB5+rL9ZeYuU+DNLjzQdCt7DttquXO6UqAsW+edPo+i+Z2IW3yEFvW2IUuzxXgsYnLHefjvUl9vsDz0q8q4lTWx8iu7cuDla2RrqcP0TiSN4Mzs7gbobpnZ/YxMtsjSb5jqXj4RAh4slfYn1XjicxP4Ye1cMy3DDWKQ97nJvqN46qv54DmQVOFvJe9EvvLRq8oAd2/7OD3o+K5jTelKBEfMjlHLTMTTD5ZE+8rticsHJMu/o+Isf02KYG8S0MNkiP2d3/x/ff7pQbCdTo58DkEXi8e7fhbQG8H52KPjan9NgovLp7eoh3w6ec1M2L/233gH6b4ZAFC1CVSktgPU9TcnDyYUhDZRNV8Gj85yKsaLaJFjdvphYs8sksuyIIIOCcRkePJL23tUMiHQH57rsIlqWtnOp9jSTYWSE83201bt4idBN1z2GqK53q1wFM1D3WKLnoJmrYKv4ZTYLJDYXX+/g7tPJe4Dw3AZ1OvLxVe5puWmTtfXtyr6IuQPb3bY0Ym87uqbw18V8O3AhhwNT+pJEiBJJrFeOvy3OCxGJhopQ5OP4n+iZg2KPx0IoUpis4FGk7kzdge/UtytN3j4EVSctjM3apNgdLUdap+2RIQqiT1ShGpjQXlFw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(346002)(39830400003)(376002)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(86362001)(36756003)(83380400001)(2906002)(38350700002)(38100700002)(44832011)(5660300002)(8676002)(8936002)(4326008)(6666004)(316002)(66556008)(66946007)(66476007)(52116002)(6512007)(6916009)(6506007)(41300700001)(6486002)(107886003)(1076003)(26005)(478600001)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: M94/CF0+toEiGAs4uciGmOmWiNBN4RGxLFiIzKEzx9Y5V0VvTFEiwSE+3fj5pMY1o9imkm8ZMStnMiVck2PULtx2E5mR+g3WeT1uIFE4LwaqRds5qTYEX3lYEpobgbecyBIXn6LMq14O8SEHnZ9oIO+02i+TCR4qRuNBYB32WfiBGsSk2h+/8xXzhu0BC/uv+ztxWjZNJV2o8sqGuIYi1U0wTQIYeWPlGQ+E98fNG5wfISukwr03yPsJWIIvMZMpZfEdmSlJENO/k6+w62bXQwiYb+Tw33ft7WHBP/+199jsU1Mu0TxVM/2j7fSakC4qQwvSyXw4PArVDuCx30FWvUHSP5LK4l5i86g25svPrkg+6i3tArTerpQdEkKY4F7r8RI0XKIg/yQQs2dmJ+FlFeybe/o6DV5zyTPzJlzg3/+CpVUXnMAsZzUx09x1GjCsGNt5XX5du+uIWTVAFITfoOvM7njmdV9LXyizykiflfa8F5YA27Tfn7iKsjr89uKqeVwunFrjrpGsH0PYLzG1kv1R+kA/IDexueli3i5ekcYw/dmqf0UD1Eu7sj/VszVplZjfEv3yBN5CBuF9Csvc15n3+9uwDy8s3p9H+xbmHCBmYPnA3o4kF6NgoakEWkJPB+YiPL7sywHj5Dn27SCM4ngL7yvk8+MKFa8jn8exACLTP4J9jnlucPHE3+tHmKdICI0NWsqiBLFULVv0RQcJHeujgJzD9LWAk06KLUuTMlRWB/WHcf/+LPK+nFenw5+wDL9KnkLf/FsZOZIOFoH/LHS0OOrJmZLiWtvpYjvTADVBnDXcySvTfXZ81t8HY/E/77/ivJraXYiu/NWi4yRmOd2vv/KtU8of85VC9KzHmzH1Eg/xAwaPHqDDQqaUfxtBWTgArb+ItBiUTxVIbBtZEFqlInR5isY1IYxCHkNfwGgz5XBJz+FXcLOFykFWIawJv/eGidt5h4XjMk1pjMUquBKDvrYFFwBmVAERXG/HSIkDEHakyUKtVtD4ikYRJ4QFYcjJm0Msp1BPqWEK5EPpo7EMVRZhi+hrP8kPKDcl6AlZTOW8t/x2OB3ukd4mmC6h41ZLLTaAn4UBofnQCT0pK3shfzObn/avEIEzCSqnvBVuBJW9s07DwimrLnmoSn+XhBFH9XakIHWMGQhe48GzNvMkrfq81bvHFiQKMHM81oV6ZU1qJ9fhpKApS4I92nIzjD885qbP87sk5F7v4vvGyR1WOAXnvKWf9e2rvW3KVs+9G2PfYr2tjjpUlNp9VSRzZ57APryRiTzUAB68HD2uzgHljKCXPMV1W8sPaL9yLDRP3LtkATFpxl2KnpBlWNRZ0X7B4WqwQw58fFC0VF6Fq7jpwjEQau3PCW0H551KBWXYPQIsA9UcaHln/aUBiv4ZCG5BwO166MqTIEIkGN0AfMRWpevfavGcBOTUosvHosj8igkGKQAwvf9Xjvfa9zBsMy4auSJKp4UoDrQHOg5g9nd1fr+P6wH9ZkcsGwhWmEhB8cCnF2ShJmlx3pyWEURGyVfWQSRTlaBRcv2Py565SMGJbwv1IZR6mGnKxy2XPGzr/x8TCl3kQhoWXSHTAg2oLrKfd3nTTrcJBIWywMesGg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9e2db98-df3e-456d-a6e7-08dbcbb2a9ae X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 06:07:21.6771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y9BZBp4aaVfaP6Utk7ngTSmzr5hl0pNq+vUruK+iozAhiP87xQny4PxqUe2dqqpO03dUSKsYT4yQ12fR/QFRClgv1LrXS9aKARjv+MSUVaQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6296 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch series aims to unify the coding style of NFP PMD, make the logics following the same rules, to make it easier to understand and extend. Also prepare for the upcoming vDPA PMD patch series. --- v2: * Add some missing modification. v3: * Remove the '\t' character in the log statement as the advice of reviewer. --- Chaoyong He (11): net/nfp: explicitly compare to null and 0 net/nfp: unify the indent coding style net/nfp: unify the type of integer variable net/nfp: standard the local variable coding style net/nfp: adjust the log statement net/nfp: standard the comment style net/nfp: standard the blank character net/nfp: unify the guide line of header file net/nfp: rename some parameter and variable net/nfp: adjust logic to make it more readable net/nfp: refact the meson build file drivers/net/nfp/flower/nfp_conntrack.c | 4 +- drivers/net/nfp/flower/nfp_flower.c | 27 +- drivers/net/nfp/flower/nfp_flower.h | 34 +- drivers/net/nfp/flower/nfp_flower_cmsg.c | 18 +- drivers/net/nfp/flower/nfp_flower_cmsg.h | 62 +- drivers/net/nfp/flower/nfp_flower_ctrl.c | 39 +- drivers/net/nfp/flower/nfp_flower_ctrl.h | 6 +- .../net/nfp/flower/nfp_flower_representor.c | 46 +- .../net/nfp/flower/nfp_flower_representor.h | 8 +- drivers/net/nfp/meson.build | 23 +- drivers/net/nfp/nfd3/nfp_nfd3.h | 39 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 34 +- drivers/net/nfp/nfdk/nfp_nfdk.h | 49 +- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 14 +- drivers/net/nfp/nfp_common.c | 775 +++++++++--------- drivers/net/nfp/nfp_common.h | 169 ++-- drivers/net/nfp/nfp_cpp_bridge.c | 139 ++-- drivers/net/nfp/nfp_cpp_bridge.h | 8 +- drivers/net/nfp/nfp_ctrl.h | 46 +- drivers/net/nfp/nfp_ethdev.c | 325 ++++---- drivers/net/nfp/nfp_ethdev_vf.c | 195 ++--- drivers/net/nfp/nfp_flow.c | 251 +++--- drivers/net/nfp/nfp_flow.h | 23 +- drivers/net/nfp/nfp_ipsec.h | 12 +- drivers/net/nfp/nfp_logs.h | 7 +- drivers/net/nfp/nfp_rxtx.c | 296 +++---- drivers/net/nfp/nfp_rxtx.h | 36 +- drivers/net/nfp/nfpcore/nfp_resource.h | 2 +- 28 files changed, 1299 insertions(+), 1388 deletions(-)