[v9,0/9] add rte flow support for cpfl

Message ID 20230928084458.2333663-1-yuying.zhang@intel.com (mailing list archive)
Headers
Series add rte flow support for cpfl |

Message

Zhang, Yuying Sept. 28, 2023, 8:44 a.m. UTC
  From: Yuying Zhang <yuying.zhang@intel.com>

This patchset add rte flow support for cpfl driver.
It depends on the following patch set:
http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-beilei.xing@intel.com/

Wenjing Qiao (2):
  net/cpfl: add json parser for rte flow pattern rules
  net/cpfl: build action mapping rules from JSON

Yuying Zhang (7):
  net/cpfl: set up rte flow skeleton
  net/cpfl: set up control path
  net/cpfl: add FXP low level implementation
  net/cpfl: add fxp rule module
  net/cpfl: add fxp flow engine
  net/cpfl: add flow support for representor
  net/cpfl: add support of to represented port action
---
v9:
* refine rx queue message process function

v8:
* fix compile issues
* refine document and separate patch with different features

v7:
* refine commit log
* fix compile issues

v6:
* use existed jansson instead of json-c library.
* refine "add FXP low level implementation"

V5:
* Add input validation for some functions.

 doc/guides/nics/cpfl.rst                |   52 +
 doc/guides/rel_notes/release_23_11.rst  |    1 +
 drivers/net/cpfl/cpfl_actions.h         |  858 +++++++++++
 drivers/net/cpfl/cpfl_controlq.c        |  801 ++++++++++
 drivers/net/cpfl/cpfl_controlq.h        |   75 +
 drivers/net/cpfl/cpfl_ethdev.c          |  392 ++++-
 drivers/net/cpfl/cpfl_ethdev.h          |  128 ++
 drivers/net/cpfl/cpfl_flow.c            |  339 +++++
 drivers/net/cpfl/cpfl_flow.h            |   85 ++
 drivers/net/cpfl/cpfl_flow_engine_fxp.c |  667 ++++++++
 drivers/net/cpfl/cpfl_flow_parser.c     | 1839 +++++++++++++++++++++++
 drivers/net/cpfl/cpfl_flow_parser.h     |  267 ++++
 drivers/net/cpfl/cpfl_fxp_rule.c        |  263 ++++
 drivers/net/cpfl/cpfl_fxp_rule.h        |   68 +
 drivers/net/cpfl/cpfl_representor.c     |   29 +
 drivers/net/cpfl/cpfl_rules.c           |  127 ++
 drivers/net/cpfl/cpfl_rules.h           |  306 ++++
 drivers/net/cpfl/cpfl_vchnl.c           |  144 ++
 drivers/net/cpfl/meson.build            |   12 +
 19 files changed, 6452 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/cpfl/cpfl_actions.h
 create mode 100644 drivers/net/cpfl/cpfl_controlq.c
 create mode 100644 drivers/net/cpfl/cpfl_controlq.h
 create mode 100644 drivers/net/cpfl/cpfl_flow.c
 create mode 100644 drivers/net/cpfl/cpfl_flow.h
 create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.h
 create mode 100644 drivers/net/cpfl/cpfl_rules.c
 create mode 100644 drivers/net/cpfl/cpfl_rules.h
  

Comments

Qi Zhang Sept. 28, 2023, 12:45 p.m. UTC | #1
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Thursday, September 28, 2023 4:45 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH v9 0/9] add rte flow support for cpfl
> 
> From: Yuying Zhang <yuying.zhang@intel.com>
> 
> This patchset add rte flow support for cpfl driver.
> It depends on the following patch set:
> http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-
> beilei.xing@intel.com/
> 
> Wenjing Qiao (2):
>   net/cpfl: add json parser for rte flow pattern rules
>   net/cpfl: build action mapping rules from JSON
> 
> Yuying Zhang (7):
>   net/cpfl: set up rte flow skeleton
>   net/cpfl: set up control path
>   net/cpfl: add FXP low level implementation
>   net/cpfl: add fxp rule module
>   net/cpfl: add fxp flow engine
>   net/cpfl: add flow support for representor
>   net/cpfl: add support of to represented port action
> ---
> v9:
> * refine rx queue message process function
> 
> v8:
> * fix compile issues
> * refine document and separate patch with different features
> 
> v7:
> * refine commit log
> * fix compile issues
> 
> v6:
> * use existed jansson instead of json-c library.
> * refine "add FXP low level implementation"
> 
> V5:
> * Add input validation for some functions.
> 
>  doc/guides/nics/cpfl.rst                |   52 +
>  doc/guides/rel_notes/release_23_11.rst  |    1 +
>  drivers/net/cpfl/cpfl_actions.h         |  858 +++++++++++
>  drivers/net/cpfl/cpfl_controlq.c        |  801 ++++++++++
>  drivers/net/cpfl/cpfl_controlq.h        |   75 +
>  drivers/net/cpfl/cpfl_ethdev.c          |  392 ++++-
>  drivers/net/cpfl/cpfl_ethdev.h          |  128 ++
>  drivers/net/cpfl/cpfl_flow.c            |  339 +++++
>  drivers/net/cpfl/cpfl_flow.h            |   85 ++
>  drivers/net/cpfl/cpfl_flow_engine_fxp.c |  667 ++++++++
>  drivers/net/cpfl/cpfl_flow_parser.c     | 1839 +++++++++++++++++++++++
>  drivers/net/cpfl/cpfl_flow_parser.h     |  267 ++++
>  drivers/net/cpfl/cpfl_fxp_rule.c        |  263 ++++
>  drivers/net/cpfl/cpfl_fxp_rule.h        |   68 +
>  drivers/net/cpfl/cpfl_representor.c     |   29 +
>  drivers/net/cpfl/cpfl_rules.c           |  127 ++
>  drivers/net/cpfl/cpfl_rules.h           |  306 ++++
>  drivers/net/cpfl/cpfl_vchnl.c           |  144 ++
>  drivers/net/cpfl/meson.build            |   12 +
>  19 files changed, 6452 insertions(+), 1 deletion(-)  create mode 100644
> drivers/net/cpfl/cpfl_actions.h  create mode 100644
> drivers/net/cpfl/cpfl_controlq.c  create mode 100644
> drivers/net/cpfl/cpfl_controlq.h  create mode 100644
> drivers/net/cpfl/cpfl_flow.c  create mode 100644 drivers/net/cpfl/cpfl_flow.h
> create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c
>  create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
>  create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h
>  create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c  create mode 100644
> drivers/net/cpfl/cpfl_fxp_rule.h  create mode 100644
> drivers/net/cpfl/cpfl_rules.c  create mode 100644 drivers/net/cpfl/cpfl_rules.h
> 
> --
> 2.34.1

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel after refined some commit logs.

Thanks
Qi
  
Stephen Hemminger Sept. 28, 2023, 4:04 p.m. UTC | #2
On Thu, 28 Sep 2023 08:44:49 +0000
yuying.zhang@intel.com wrote:

> From: Yuying Zhang <yuying.zhang@intel.com>
> 
> This patchset add rte flow support for cpfl driver.
> It depends on the following patch set:
> http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-beilei.xing@intel.com/
> 
> Wenjing Qiao (2):
>   net/cpfl: add json parser for rte flow pattern rules
>   net/cpfl: build action mapping rules from JSON
> 
> Yuying Zhang (7):
>   net/cpfl: set up rte flow skeleton
>   net/cpfl: set up control path
>   net/cpfl: add FXP low level implementation
>   net/cpfl: add fxp rule module
>   net/cpfl: add fxp flow engine
>   net/cpfl: add flow support for representor
>   net/cpfl: add support of to represented port action

Are there new test cases needed for this or would it get covered
by regular rte_flow tests. 
We really need more of a test suite for rte_flow, but it is difficult because
there is so much variation between NIC's.
  
Zhang, Yuying Oct. 9, 2023, 4 a.m. UTC | #3
From: Yuying Zhang <yuying.zhang@intel.com>

This patchset add rte flow support for cpfl driver.
It depends on the following patch set:
http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-beilei.xing@intel.com/

Wenjing Qiao (2):
  net/cpfl: parse flow offloading hint from JSON
  net/cpfl: build action mapping rules from JSON

Yuying Zhang (7):
  net/cpfl: set up flow offloading skeleton
  net/cpfl: set up control path
  net/cpfl: add FXP low level implementation
  net/cpfl: implement FXP rule creation and destroying
  net/cpfl: adapt FXP to flow engine
  net/cpfl: support flow ops on representor
  net/cpfl: support represented port action
---
v10:
* fix ci build issue

v9:
* refine rx queue message process function

v8:
* fix compile issues
* refine document and separate patch with different features

v7:
* refine commit log
* fix compile issues

v6:
* use existed jansson instead of json-c library
* refine "add FXP low level implementation"

V5:
* Add input validation for some functions

 doc/guides/nics/cpfl.rst                |   52 +
 doc/guides/rel_notes/release_23_11.rst  |    1 +
 drivers/net/cpfl/cpfl_actions.h         |  858 +++++++++++
 drivers/net/cpfl/cpfl_controlq.c        |  801 ++++++++++
 drivers/net/cpfl/cpfl_controlq.h        |   75 +
 drivers/net/cpfl/cpfl_ethdev.c          |  392 ++++-
 drivers/net/cpfl/cpfl_ethdev.h          |  128 ++
 drivers/net/cpfl/cpfl_flow.c            |  339 +++++
 drivers/net/cpfl/cpfl_flow.h            |   85 ++
 drivers/net/cpfl/cpfl_flow_engine_fxp.c |  666 ++++++++
 drivers/net/cpfl/cpfl_flow_parser.c     | 1835 +++++++++++++++++++++++
 drivers/net/cpfl/cpfl_flow_parser.h     |  268 ++++
 drivers/net/cpfl/cpfl_fxp_rule.c        |  263 ++++
 drivers/net/cpfl/cpfl_fxp_rule.h        |   68 +
 drivers/net/cpfl/cpfl_representor.c     |   29 +
 drivers/net/cpfl/cpfl_rules.c           |  127 ++
 drivers/net/cpfl/cpfl_rules.h           |  306 ++++
 drivers/net/cpfl/cpfl_vchnl.c           |  144 ++
 drivers/net/cpfl/meson.build            |   12 +
 19 files changed, 6448 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/cpfl/cpfl_actions.h
 create mode 100644 drivers/net/cpfl/cpfl_controlq.c
 create mode 100644 drivers/net/cpfl/cpfl_controlq.h
 create mode 100644 drivers/net/cpfl/cpfl_flow.c
 create mode 100644 drivers/net/cpfl/cpfl_flow.h
 create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.h
 create mode 100644 drivers/net/cpfl/cpfl_rules.c
 create mode 100644 drivers/net/cpfl/cpfl_rules.h
  
Qi Zhang Oct. 10, 2023, 1:31 a.m. UTC | #4
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Monday, October 9, 2023 12:00 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH v10 0/9] add rte flow support for cpfl
> 
> From: Yuying Zhang <yuying.zhang@intel.com>
> 
> This patchset add rte flow support for cpfl driver.
> It depends on the following patch set:
> http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-
> beilei.xing@intel.com/
> 
> Wenjing Qiao (2):
>   net/cpfl: parse flow offloading hint from JSON
>   net/cpfl: build action mapping rules from JSON
> 
> Yuying Zhang (7):
>   net/cpfl: set up flow offloading skeleton
>   net/cpfl: set up control path
>   net/cpfl: add FXP low level implementation
>   net/cpfl: implement FXP rule creation and destroying
>   net/cpfl: adapt FXP to flow engine
>   net/cpfl: support flow ops on representor
>   net/cpfl: support represented port action
> ---
> v10:
> * fix ci build issue
> 
> v9:
> * refine rx queue message process function
> 
> v8:
> * fix compile issues
> * refine document and separate patch with different features
> 
> v7:
> * refine commit log
> * fix compile issues
> 
> v6:
> * use existed jansson instead of json-c library
> * refine "add FXP low level implementation"
> 
> V5:
> * Add input validation for some functions
> 
>  doc/guides/nics/cpfl.rst                |   52 +
>  doc/guides/rel_notes/release_23_11.rst  |    1 +
>  drivers/net/cpfl/cpfl_actions.h         |  858 +++++++++++
>  drivers/net/cpfl/cpfl_controlq.c        |  801 ++++++++++
>  drivers/net/cpfl/cpfl_controlq.h        |   75 +
>  drivers/net/cpfl/cpfl_ethdev.c          |  392 ++++-
>  drivers/net/cpfl/cpfl_ethdev.h          |  128 ++
>  drivers/net/cpfl/cpfl_flow.c            |  339 +++++
>  drivers/net/cpfl/cpfl_flow.h            |   85 ++
>  drivers/net/cpfl/cpfl_flow_engine_fxp.c |  666 ++++++++
>  drivers/net/cpfl/cpfl_flow_parser.c     | 1835 +++++++++++++++++++++++
>  drivers/net/cpfl/cpfl_flow_parser.h     |  268 ++++
>  drivers/net/cpfl/cpfl_fxp_rule.c        |  263 ++++
>  drivers/net/cpfl/cpfl_fxp_rule.h        |   68 +
>  drivers/net/cpfl/cpfl_representor.c     |   29 +
>  drivers/net/cpfl/cpfl_rules.c           |  127 ++
>  drivers/net/cpfl/cpfl_rules.h           |  306 ++++
>  drivers/net/cpfl/cpfl_vchnl.c           |  144 ++
>  drivers/net/cpfl/meson.build            |   12 +
>  19 files changed, 6448 insertions(+), 1 deletion(-)  create mode 100644
> drivers/net/cpfl/cpfl_actions.h  create mode 100644
> drivers/net/cpfl/cpfl_controlq.c  create mode 100644
> drivers/net/cpfl/cpfl_controlq.h  create mode 100644
> drivers/net/cpfl/cpfl_flow.c  create mode 100644 drivers/net/cpfl/cpfl_flow.h
> create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c
>  create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
>  create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h
>  create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c  create mode 100644
> drivers/net/cpfl/cpfl_fxp_rule.h  create mode 100644
> drivers/net/cpfl/cpfl_rules.c  create mode 100644 drivers/net/cpfl/cpfl_rules.h
> 
> --
> 2.34.1

Applied to dpdk-next-net-intel after reverted the old version.

Thanks
Qi
  
Thomas Monjalon Oct. 15, 2023, 11:21 a.m. UTC | #5
28/09/2023 10:44, yuying.zhang@intel.com:
> From: Yuying Zhang <yuying.zhang@intel.com>
> 
> This patchset add rte flow support for cpfl driver.
> It depends on the following patch set:
> http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-beilei.xing@intel.com/
> 
> Wenjing Qiao (2):
>   net/cpfl: add json parser for rte flow pattern rules
>   net/cpfl: build action mapping rules from JSON
> 
> Yuying Zhang (7):
>   net/cpfl: set up rte flow skeleton
>   net/cpfl: set up control path
>   net/cpfl: add FXP low level implementation
>   net/cpfl: add fxp rule module
>   net/cpfl: add fxp flow engine
>   net/cpfl: add flow support for representor
>   net/cpfl: add support of to represented port action

You did not update the feature list in doc/guides/nics/features/cpfl.ini

You could have generated it with this command:
devtools/parse-flow-support.sh drivers/net/cpfl

This miss is caught by the script devtools/check-doc-vs-code.sh
Please run it.