mbox series

[V8,0/8] telemetry: fix data truncation and conversion error and add hex integer API

Message ID 20221219070648.33817-1-lihuisong@huawei.com (mailing list archive)
Headers
Series telemetry: fix data truncation and conversion error and add hex integer API |

Message

lihuisong (C) Dec. 19, 2022, 7:06 a.m. UTC
  Some lib telemetry interfaces add the 'u32' and 'u64' data by the
rte_tel_data_add_dict/array_int API. This may cause data conversion
error or data truncation. This patch series uses 'u64' functions to
do this.

In addition, this patch series introduces two APIs to store unsigned
integer values as hexadecimal encoded strings in telemetry library. 

---
 -v8: fix the coding style in patch 7/8
 -v7: replace sprintf with snprintf in patch 6/8
 -v6: fix code alignment to keep in line with codes in the file
 -v5:
    - drop a refactor patch.
    - no limit the bit width for xxx_uint_hex API.
 -v4:
    - remove 'u32' value type.
    - add padding zero for hexadecimal value
 -v3: fix a misspelling mistake in commit log.
 -v2:
    - fix ABI break warning.
    - introduce two APIs to store u32 and u64 values as hexadecimal
      encoded strings. 

Huisong Li (8):
  telemetry: move to header to controllable range
  ethdev: fix possible data truncation and conversion error
  mempool: fix possible data truncation and conversion error
  cryptodev: fix possible data conversion error
  mem: possible data truncation and conversion error
  telemetry: support adding integer value as hexadecimal
  test: add test cases for adding hex integer value API
  ethdev: display capability values in hexadecimal format

 app/test/test_telemetry_data.c     | 150 +++++++++++++++++++++++++++++
 lib/cryptodev/rte_cryptodev.c      |   2 +-
 lib/eal/common/eal_common_memory.c |  10 +-
 lib/ethdev/rte_ethdev.c            |  19 ++--
 lib/mempool/rte_mempool.c          |  24 ++---
 lib/telemetry/rte_telemetry.h      |  52 +++++++++-
 lib/telemetry/telemetry_data.c     |  73 ++++++++++++++
 lib/telemetry/version.map          |   9 ++
 8 files changed, 309 insertions(+), 30 deletions(-)
  

Comments

lihuisong (C) Jan. 16, 2023, 12:06 p.m. UTC | #1
Hi Ferruh and Andrew,

This patch series optimizes some codes and bug.
Can you take a look at this patch series?
If there are no other questions, can it be merged?

Best,
Huisong

在 2022/12/19 15:06, Huisong Li 写道:
> Some lib telemetry interfaces add the 'u32' and 'u64' data by the
> rte_tel_data_add_dict/array_int API. This may cause data conversion
> error or data truncation. This patch series uses 'u64' functions to
> do this.
>
> In addition, this patch series introduces two APIs to store unsigned
> integer values as hexadecimal encoded strings in telemetry library.
>
> ---
>   -v8: fix the coding style in patch 7/8
>   -v7: replace sprintf with snprintf in patch 6/8
>   -v6: fix code alignment to keep in line with codes in the file
>   -v5:
>      - drop a refactor patch.
>      - no limit the bit width for xxx_uint_hex API.
>   -v4:
>      - remove 'u32' value type.merg
>      - add padding zero for hexadecimal value
>   -v3: fix a misspelling mistake in commit log.
>   -v2:
>      - fix ABI break warning.
>      - introduce two APIs to store u32 and u64 values as hexadecimal
>        encoded strings.
>
> Huisong Li (8):
>    telemetry: move to header to controllable range
>    ethdev: fix possible data truncation and conversion error
>    mempool: fix possible data truncation and conversion error
>    cryptodev: fix possible data conversion error
>    mem: possible data truncation and conversion error
>    telemetry: support adding integer value as hexadecimal
>    test: add test cases for adding hex integer value API
>    ethdev: display capability values in hexadecimal format
>
>   app/test/test_telemetry_data.c     | 150 +++++++++++++++++++++++++++++
>   lib/cryptodev/rte_cryptodev.c      |   2 +-
>   lib/eal/common/eal_common_memory.c |  10 +-
>   lib/ethdev/rte_ethdev.c            |  19 ++--
>   lib/mempool/rte_mempool.c          |  24 ++---
>   lib/telemetry/rte_telemetry.h      |  52 +++++++++-
>   lib/telemetry/telemetry_data.c     |  73 ++++++++++++++
>   lib/telemetry/version.map          |   9 ++
>   8 files changed, 309 insertions(+), 30 deletions(-)
>
  
lihuisong (C) Jan. 30, 2023, 10:39 a.m. UTC | #2
Kindly ping.

在 2023/1/16 20:06, lihuisong (C) 写道:
> Hi Ferruh and Andrew,
>
> This patch series optimizes some codes and bug.
> Can you take a look at this patch series?
> If there are no other questions, can it be merged?
>
> Best,
> Huisong
>
> 在 2022/12/19 15:06, Huisong Li 写道:
>> Some lib telemetry interfaces add the 'u32' and 'u64' data by the
>> rte_tel_data_add_dict/array_int API. This may cause data conversion
>> error or data truncation. This patch series uses 'u64' functions to
>> do this.
>>
>> In addition, this patch series introduces two APIs to store unsigned
>> integer values as hexadecimal encoded strings in telemetry library.
>>
>> ---
>>   -v8: fix the coding style in patch 7/8
>>   -v7: replace sprintf with snprintf in patch 6/8
>>   -v6: fix code alignment to keep in line with codes in the file
>>   -v5:
>>      - drop a refactor patch.
>>      - no limit the bit width for xxx_uint_hex API.
>>   -v4:
>>      - remove 'u32' value type.merg
>>      - add padding zero for hexadecimal value
>>   -v3: fix a misspelling mistake in commit log.
>>   -v2:
>>      - fix ABI break warning.
>>      - introduce two APIs to store u32 and u64 values as hexadecimal
>>        encoded strings.
>>
>> Huisong Li (8):
>>    telemetry: move to header to controllable range
>>    ethdev: fix possible data truncation and conversion error
>>    mempool: fix possible data truncation and conversion error
>>    cryptodev: fix possible data conversion error
>>    mem: possible data truncation and conversion error
>>    telemetry: support adding integer value as hexadecimal
>>    test: add test cases for adding hex integer value API
>>    ethdev: display capability values in hexadecimal format
>>
>>   app/test/test_telemetry_data.c     | 150 +++++++++++++++++++++++++++++
>>   lib/cryptodev/rte_cryptodev.c      |   2 +-
>>   lib/eal/common/eal_common_memory.c |  10 +-
>>   lib/ethdev/rte_ethdev.c            |  19 ++--
>>   lib/mempool/rte_mempool.c          |  24 ++---
>>   lib/telemetry/rte_telemetry.h      |  52 +++++++++-
>>   lib/telemetry/telemetry_data.c     |  73 ++++++++++++++
>>   lib/telemetry/version.map          |   9 ++
>>   8 files changed, 309 insertions(+), 30 deletions(-)
>>
>
> .
  
Thomas Monjalon Feb. 5, 2023, 8:43 p.m. UTC | #3
> Huisong Li (8):
>   telemetry: move to header to controllable range
>   ethdev: fix possible data truncation and conversion error
>   mempool: fix possible data truncation and conversion error
>   cryptodev: fix possible data conversion error
>   mem: possible data truncation and conversion error
>   telemetry: support adding integer value as hexadecimal
>   test: add test cases for adding hex integer value API
>   ethdev: display capability values in hexadecimal format

Applied, thanks.