diff mbox series

[V8,5/8] mem: possible data truncation and conversion error

Message ID	20221219070648.33817-6-lihuisong@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Huisong Li <lihuisong@huawei.com> To: <dev@dpdk.org> CC: <bruce.richardson@intel.com>, <mb@smartsharesystems.com>, <andrew.rybchenko@oktetlabs.ru>, <huangdaode@huawei.com>, <liudongdong3@huawei.com>, <fengchengwen@huawei.com>, <lihuisong@huawei.com> Subject: [PATCH V8 5/8] mem: possible data truncation and conversion error Date: Mon, 19 Dec 2022 15:06:45 +0800 Message-ID: <20221219070648.33817-6-lihuisong@huawei.com> In-Reply-To: <20221219070648.33817-1-lihuisong@huawei.com> References: <20221208080540.62913-1-lihuisong@huawei.com> <20221219070648.33817-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	telemetry: fix data truncation and conversion error and add hex integer API \| [V8,0/8] telemetry: fix data truncation and conversion error and add hex integer API [V8,1/8] telemetry: move to header to controllable range [V8,2/8] ethdev: fix possible data truncation and conversion error [V8,3/8] mempool: fix possible data truncation and conversion error [V8,4/8] cryptodev: fix possible data conversion error [V8,5/8] mem: possible data truncation and conversion error [V8,6/8] telemetry: support adding integer value as hexadecimal [V8,7/8] test: add test cases for adding hex integer value API [V8,8/8] ethdev: display capability values in hexadecimal format

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

lihuisong (C) Dec. 19, 2022, 7:06 a.m. UTC

  The 'u32' and 'u64' data can not assigned to 'int' type variable.
They need to use the 'u64' APIs to add.

Fixes: e6732d0d6e26 ("mem: add telemetry infos")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
 lib/eal/common/eal_common_memory.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index 688dc615d7..8e427bf4b4 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -1139,7 +1139,7 @@  handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params,
 	malloc_heap_get_stats(heap, &sock_stats);
 
 	rte_tel_data_start_dict(d);
-	rte_tel_data_add_dict_int(d, "Head id", heap_id);
+	rte_tel_data_add_dict_u64(d, "Head id", heap_id);
 	rte_tel_data_add_dict_string(d, "Name", heap->name);
 	rte_tel_data_add_dict_u64(d, "Heap_size",
 				  sock_stats.heap_totalsz_bytes);
@@ -1201,13 +1201,13 @@  handle_eal_memzone_info_request(const char *cmd __rte_unused,
 	mz = rte_fbarray_get(&mcfg->memzones, mz_idx);
 
 	rte_tel_data_start_dict(d);
-	rte_tel_data_add_dict_int(d, "Zone", mz_idx);
+	rte_tel_data_add_dict_u64(d, "Zone", mz_idx);
 	rte_tel_data_add_dict_string(d, "Name", mz->name);
-	rte_tel_data_add_dict_int(d, "Length", mz->len);
+	rte_tel_data_add_dict_u64(d, "Length", mz->len);
 	snprintf(addr, ADDR_STR, "%p", mz->addr);
 	rte_tel_data_add_dict_string(d, "Address", addr);
 	rte_tel_data_add_dict_int(d, "Socket", mz->socket_id);
-	rte_tel_data_add_dict_int(d, "Flags", mz->flags);
+	rte_tel_data_add_dict_u64(d, "Flags", mz->flags);
 
 	/* go through each page occupied by this memzone */
 	msl = rte_mem_virt2memseg_list(mz->addr);
@@ -1222,7 +1222,7 @@  handle_eal_memzone_info_request(const char *cmd __rte_unused,
 	ms_idx = RTE_PTR_DIFF(mz->addr, msl->base_va) / page_sz;
 	ms = rte_fbarray_get(&msl->memseg_arr, ms_idx);
 
-	rte_tel_data_add_dict_int(d, "Hugepage_size", page_sz);
+	rte_tel_data_add_dict_u64(d, "Hugepage_size", page_sz);
 	snprintf(addr, ADDR_STR, "%p", ms->addr);
 	rte_tel_data_add_dict_string(d, "Hugepage_base", addr);