[0/4] fix missing Tx multi segs capabilities
mbox series

Message ID 20180919150409.22880-1-didier.pallard@6wind.com
Headers show
Series
  • fix missing Tx multi segs capabilities
Related show

Message

Didier Pallard Sept. 19, 2018, 3:04 p.m. UTC
In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating
that application will never send multisegmented packets, allowing
pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability
that is advertised by pmds, some of them do not advertise it and
expect to never receive fragmented packets (octeontx, axgbe)
So an ethdev that supports multisegmented packets should properly
advertise it.

Didier Pallard (4):
  net/e1000: fix missing Tx multi segs capability
  net/fm10k: fix missing Tx multi segs capability
  net/i40e: fix missing Tx multi segs capability
  net/ixgbe: fix missing Tx multi segs capability

 drivers/net/e1000/em_rxtx.c              | 1 +
 drivers/net/fm10k/fm10k_ethdev.c         | 1 +
 drivers/net/i40e/i40e_vf_representor.c   | 1 +
 drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +-
 4 files changed, 4 insertions(+), 1 deletion(-)

Comments

Konstantin Ananyev Sept. 19, 2018, 11:29 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
> Sent: Wednesday, September 19, 2018 4:04 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities
> 
> In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating
> that application will never send multisegmented packets, allowing
> pmd to choose different tx methods accordingly.
> In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability
> that is advertised by pmds, some of them do not advertise it and
> expect to never receive fragmented packets (octeontx, axgbe)
> So an ethdev that supports multisegmented packets should properly
> advertise it.
> 
> Didier Pallard (4):
>   net/e1000: fix missing Tx multi segs capability
>   net/fm10k: fix missing Tx multi segs capability
>   net/i40e: fix missing Tx multi segs capability
>   net/ixgbe: fix missing Tx multi segs capability
> 
>  drivers/net/e1000/em_rxtx.c              | 1 +
>  drivers/net/fm10k/fm10k_ethdev.c         | 1 +
>  drivers/net/i40e/i40e_vf_representor.c   | 1 +
>  drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +-
>  4 files changed, 4 insertions(+), 1 deletion(-)
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.11.0
Qi Zhang Sept. 21, 2018, 2:20 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Thursday, September 20, 2018 7:30 AM
> To: Didier Pallard <didier.pallard@6wind.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
> > Sent: Wednesday, September 19, 2018 4:04 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities
> >
> > In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating
> > that application will never send multisegmented packets, allowing pmd
> > to choose different tx methods accordingly.
> > In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability
> > that is advertised by pmds, some of them do not advertise it and
> > expect to never receive fragmented packets (octeontx, axgbe) So an
> > ethdev that supports multisegmented packets should properly advertise
> > it.
> >
> > Didier Pallard (4):
> >   net/e1000: fix missing Tx multi segs capability
> >   net/fm10k: fix missing Tx multi segs capability
> >   net/i40e: fix missing Tx multi segs capability
> >   net/ixgbe: fix missing Tx multi segs capability
> >
> >  drivers/net/e1000/em_rxtx.c              | 1 +
> >  drivers/net/fm10k/fm10k_ethdev.c         | 1 +
> >  drivers/net/i40e/i40e_vf_representor.c   | 1 +
> >  drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +-
> >  4 files changed, 4 insertions(+), 1 deletion(-)
> >
> > --
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> > 2.11.0