From patchwork Wed Sep 19 15:04:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44952 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74CD14F98; Wed, 19 Sep 2018 17:04:53 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 9E4A54CA6 for ; Wed, 19 Sep 2018 17:04:51 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id q8-v6so7391252wmq.4 for ; Wed, 19 Sep 2018 08:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=++gUUWGZ9jmHHtmsGPA93Ez1c+sgVSFgHgOnbAzbNB8=; b=XRg5R+xGQiVNzZdItLBmDSvywXuLnOVdtsrs6BBBLyOwn4kBBX+iBAwx704nKjaT8o 7+6DWal7yuB0/Fe/+urKXSnTgzhF1fxPQRWTa2WOU6V+u7rtTi986htUr40UqWSZrd3+ sqGezwwJxHnXGm/R3dK4VauBqSZocjahUjU0zYA+0wJzLfWkm9OP7V0BQe0K7s2qxd6n fSjJiBrZDP7im1nK+NifoHv2kSmNqnnLIGiMa2+ig67a1XbK1dKY4J0DSRFE/8+G/JoP Oq0oL+5ygeqFfC3cYT5NuGoBSbhs6LD23h1KD5oSvC26DRSFuENlG6b98FdZC3WEOPj8 UPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=++gUUWGZ9jmHHtmsGPA93Ez1c+sgVSFgHgOnbAzbNB8=; b=fqEEGiAEZvUI+ghovWnL3phFugT0e41jfPK2QuhGGEWf9+m6vCiLDIXq5TTfqOWrXS W7JJlGZkIBhr/WNVFqoeKOdMB7AiKtmBKNEvnlkvdy6jzBPPotaU27+tzV8Oa3RKEmDT xrwGUsKAb/OeWYKLm6LEHWNlhtTqAVDSSM876kvsQWqXzTP5MT8bKNDJGBpmtElvEYCP AcDYiDLW0KqVHQ+aP3LxIsj6lZ9DTTUUqFg9kOambtNu7apVK2kCQdShMc0nJP5JrMdb RE7BNWp5b7+hG0gn4qxdGW+uHoXb/uVA+x73fDnI8qPolHBroya9krxHHF066oIOVHU+ Ur8g== X-Gm-Message-State: APzg51ApBGUk6SFfiEFLS2Qag4ss55/2rY/lgFACkJKYAJIicVGF1A4U sI8Vil4jKI04T6/R33XgI23MfoJR0iMZLA== X-Google-Smtp-Source: ANB0VdbKD91OrPM26n5/g98dQuqkfajyEVpvSdGuH5fJz1tYIcvIudZi/n4PBVHoSBF4jxGRW2Mubg== X-Received: by 2002:a7b:c18a:: with SMTP id y10-v6mr21902939wmi.87.1537369491121; Wed, 19 Sep 2018 08:04:51 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:50 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:06 +0200 Message-Id: <20180919150409.22880-2-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 1/4] net/e1000: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Fixes: e5c05e6590ea ("net/e1000: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/e1000/em_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 1103a1839058..087e68304cc8 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -1160,6 +1160,7 @@ em_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | From patchwork Wed Sep 19 15:04:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44953 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 704E35689; Wed, 19 Sep 2018 17:04:55 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5FB234F90 for ; Wed, 19 Sep 2018 17:04:53 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id s12-v6so6669649wmc.0 for ; Wed, 19 Sep 2018 08:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=; b=XMtcTnXaFeBlLF4nZNrmD3cVCO+6tOdl8cCCN2mxld5QgkbeTBD2cMaTFSJm5SkVIC FgPCQpBgjxAwadwWiAXm0hvKiEPsSW7s+LCS7efuCjmFpJaXnpxqpynjQSPxONWHI4Nb jJAyVj/okRzo3FkY6kmmwQl7woARIPDiZFm7VjRkjblhZmTiuw791lpgjvrDaDVQ7GxZ lI8i+Cl9OpbPfRnwShHUiwLMmqdPDCxQ46WiWxzVcThzuq2H7DD66XkkkI2X+Id6XR9+ 2611dN6sobnHpUCjBB+Rn5x5o9PQjOVpJSU92ExI2qh2f/AVbxNvT9LygGokxp07iUxU 1tUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hcDqZK8Fc0rYXRWol9IIU+9WaAPz8RioncAIygvBu6Y=; b=sduzHBNgUONblibJoSLXKzYTyVfExS9aV72AV7OXgy9zOhdIVghN/SWH82t3R0As9W SWIeQw4zC9cMslg9AOWzx7lMARJRwF/fBv2pG6GK8A6JAiX1PpOX6XdU8nb3XQ2zFBmb b9PosmffJzYSLXrh+IQ54bkzClk+AneqJteS9G430dGbko7KTOCWmRaJGKrszSuEAZXk W4TZrNnAtljxNp1eJj+yj2lGfE0n/93IKeI2gs1mgsbQt8eNreDn/8edlhUk92L8SDDW QviQ/HGKHD7iHVQDwSpn16Cdrpw+as5HKtQFMKDuEoan9XnmBBYQioUAPmly6Bg2LAqQ 2lVg== X-Gm-Message-State: APzg51B1pbOVuhrXzyX+LWAEDh9RCGfIH4rIeG+rrqgYMHUAxTI27ElT BQBBeAt5UYy58jmX4zOdeKUpckbjxBTHrg== X-Google-Smtp-Source: ANB0VdZ6jR9B2RGYQojbjf9roJgi0XKdA0QmvmDKA9SJqfRTqcoMAEEvBbBel0H0sB/ys887iTFL5w== X-Received: by 2002:a1c:a614:: with SMTP id p20-v6mr21311284wme.68.1537369492867; Wed, 19 Sep 2018 08:04:52 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:52 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:07 +0200 Message-Id: <20180919150409.22880-3-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 2/4] net/fm10k: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in fm10k. Fixes: 30f3ce999e6a ("net/fm10k: convert to new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 3359df3c8b9c..7cf5b0314c75 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1975,6 +1975,7 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) RTE_SET_USED(dev); return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | From patchwork Wed Sep 19 15:04:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44954 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 723DC5911; Wed, 19 Sep 2018 17:04:57 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 32F82532C for ; Wed, 19 Sep 2018 17:04:55 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id o18-v6so7404569wmc.0 for ; Wed, 19 Sep 2018 08:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o2ktDB/lkZv4sSowzcIf5JMxmbSHHQBzW0rDIfcwYGY=; b=0KCVsipAkAH9t8OUIlS4TSV81SVZXRQN5EC8V/pBVTkKad+03jHcRNgwB4RB2Zchka IjfPD5qS0G269JqAXHUig9Pog+Yp+++NBVa1JjsTLL50vS60XWWRmnwto4tI9gaBomDt /pTjRmF2rzrjOyY/qRdGF0mtZkacFuQ1PB56Ee/XKUOcczYzP0IFLv4qey4QvDNFdQms R3Gsh44sziWnUVbZ057G+UlYXcrZ829rLGsWk72vfBGVX7viLGbanbJuCTwruYstdJ4G nSP8H+i7m2SyOhx36ZSSJDscVM4UQtJNKFXXASwLtUzwjWLXMWm62B/4HRS53lR9ZanA bmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o2ktDB/lkZv4sSowzcIf5JMxmbSHHQBzW0rDIfcwYGY=; b=iGyTuvRPxQwUGkSeyIEKeobU8+ols66j2QVEZ9VRbOUmLNDfyvpLf9NPXOYNew+PBY LrJ7lz5H04rDUcdrZe0GNcC+DGhunBPossVcOf/U7+B2PAU3OyQgm8b2EQfTPrLN1H24 L3CJcjgD4+KS04icfGeU85svI5K8fDKNh8sAe8JevuTIaEFtqhQc14dUk2xCUa+76UlX AhXs1+Uu4Q5YE9XrlekcVnu8L5hq9YB37Mp7Jy+RqM+6mR/cPZEBC2qb+peiHDoYU+BM QdQDEi8zeBPLEjeFnLYIBqehn0WHixURJzVAt+kxcbOqhNnrfY6sszPcsYyIC0IsDNZu JGlg== X-Gm-Message-State: APzg51A0i6Q8sKdyB+gX/hxOFjw+8lBzHxjfpidi1wvtc9QXvgWlMbT6 qbQGBd8Ej25/TysWWj7AFI2QXvb9nMlydA== X-Google-Smtp-Source: ANB0Vdbbx45FfCwHwm2tMDvn4MoDAQFmqu/HvKQOk7JfF6SguxozCHFuftLoggK2Th38e+j9zGqRwQ== X-Received: by 2002:a1c:e0d7:: with SMTP id x206-v6mr21345761wmg.74.1537369494709; Wed, 19 Sep 2018 08:04:54 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:53 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:08 +0200 Message-Id: <20180919150409.22880-4-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 3/4] net/i40e: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in i40e_vf representor. Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/i40e/i40e_vf_representor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c index f9f131611016..0bfbb4f6011f 100644 --- a/drivers/net/i40e/i40e_vf_representor.c +++ b/drivers/net/i40e/i40e_vf_representor.c @@ -48,6 +48,7 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM; dev_info->tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_QINQ_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | From patchwork Wed Sep 19 15:04:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Didier Pallard X-Patchwork-Id: 44955 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B1EF5B16; Wed, 19 Sep 2018 17:04:59 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id AADF058CB for ; Wed, 19 Sep 2018 17:04:56 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id v90-v6so6194031wrc.0 for ; Wed, 19 Sep 2018 08:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=krp8cN+azK/Gl8HzMkdW39i9WC4ID5P84vDwzoRDGB0=; b=l5JEg87alTj0dMDBuFtq/TDF0NmOxbpR9EqUOhrluuTm4qTvuP8gNCR4lVn4Hq0K5O +FKrfVjTgljlNkpeZ5nK3DRi0mUK+v5Xkk93kT3BkSaMhbhXyvLF2oc6lBNGGJEterpo 1ZNNyDfITjjqjODxathuMVX0SidT/Gm+qLKv/B7E9Kqc6LVryJSQL/3GUcn6uQ+E97a6 69gKk1B9Rx0Cr563VLySqPgkytp7/18CTUqBqfS9KoWCoRhAjNFCZkyIvXbjJR6/dPYb 6dp9ATdIbzMmzjwQ9pvyYWGjJOjuwQqk+xzhaKQwpwcpjMt42sr16f4u206M32nvj7n6 FzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=krp8cN+azK/Gl8HzMkdW39i9WC4ID5P84vDwzoRDGB0=; b=Mh/LysfHX8P3icidd2/TP1SYNufDjLb2nbAycTwZI7c1IWzwGChhiwSYsV7b0axT5v DAtc/WdmCseGqUaQOQBwhTsuLVBy5fmBWVEvr0QxFtPFQ3iwVKLO7Iu/AXFjmWV2IOAT RgtlWK7o6h0koTm+9yrMA7sDWnpXHSDocRQGkIFb6giUtOr9BhRZumwMQgbdEZgmxoFd kQlRAGXB8XjTO79pkBjkzQwiBZ3Q2Fsu6g955qdRiDqlInHv3gyLs8CqrnM/JnSP5RdZ 0p+r6vFxBh4DqkPVVCGT3TAT1bgwcP/QY5WDhqvQoCd9K7eKUvUt9BeR9a55OWhsz8xh t1XA== X-Gm-Message-State: APzg51B8ySXAdK3GtSS8e77/IVm5+GUHPXenzXHiaFPiKyX/wDFo9liM +9dqrVhdSsw8TvWx5Fdn+6OckbhDDkKRkA== X-Google-Smtp-Source: ANB0VdbHnvxKfKlMvPskr4hMIXbwMRS0Luax0dasGOSsouW3x3ySOojzs9twM2rieVhtjUMnN0O4hw== X-Received: by 2002:adf:f112:: with SMTP id r18-v6mr11548999wro.29.1537369496129; Wed, 19 Sep 2018 08:04:56 -0700 (PDT) Received: from pala.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z21-v6sm3572751wmi.29.2018.09.19.08.04.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 08:04:55 -0700 (PDT) From: Didier Pallard To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 19 Sep 2018 17:04:09 +0200 Message-Id: <20180919150409.22880-5-didier.pallard@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180919150409.22880-1-didier.pallard@6wind.com> References: <20180919150409.22880-1-didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: fix missing Tx multi segs capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in ixgbe_vf representor. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Cc: stable@dpdk.org Signed-off-by: Didier Pallard --- drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_vf_representor.c b/drivers/net/ixgbe/ixgbe_vf_representor.c index db516d9910b8..b0fbbc49f6ed 100644 --- a/drivers/net/ixgbe/ixgbe_vf_representor.c +++ b/drivers/net/ixgbe/ixgbe_vf_representor.c @@ -65,7 +65,7 @@ ixgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev, dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_SCTP_CKSUM | - DEV_TX_OFFLOAD_TCP_TSO; + DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_MULTI_SEGS; /**< Device TX offload capabilities. */ dev_info->speed_capa =