Message
Qi Zhang
March 25, 2019, 5:44 a.m. UTC
Sync to latest kernel driver, main changes: 1. add DCB/FDIR support. 2. add more APIs in switch module. 3. code clean and bug fix. v4: - revert the fix for UDP PTYPE setup (PATCH 38/38 on v3) since its invalid. - move bit ops to dedicate file and remove the 64 bit limitation of bitmap. - improved commit log. v3: - fix software queue handle parsing in ice_ena_vsi_txq and ice_dis_vsi_txq (PATCH 19/38) which will cause Tx queue setup fail during device reconfigure. - Add new fix for UDP PTYPE setup. (PATCH 38/38), which will cause IPv4 TCP RSS does not work at some situation. v2: - Enhanced the commit log - Add missing fixed line. Qi Zhang (38): net/ice/base: add switch resource allocation and free net/ice/base: improve comments net/ice/base: add two helper functions net/ice/base: add helper macros net/ice/base: allow package copy to be used after resets net/ice/base: clean code net/ice/base: declare functions as external net/ice/base: add more APIs in switch module net/ice/base: add VSI queue context framework net/ice/base: add APIs to add remove ethertype filter net/ice/base: add APIs to get allocated resources net/ice/base: add APIs to alloc/free resource counter net/ice/base: add APIs to get VSI promiscuous mode net/ice/base: add MAC filter with marker and counter net/ice/base: add two helper functions for flow management net/ice/base: fix minor issues net/ice/base: update macros net/ice/base: clean code net/ice/base: enable VSI queue context net/ice/base: ensure only valid bits are set net/ice/base: enhance get link status command net/ice/base: add RSS key related macro and structures net/ice/base: do not write TCAM entries back net/ice/base: remove local VSIG allocations net/ice/base: fix minor issues net/ice/base: update copyright time net/ice/base: fix Klockwork analysis reported issues net/ice/base: return config error without queue to disable net/ice/base: add function to check FW recovery mode net/ice/base: change profile id reference counting net/ice/base: add DCB support net/ice/base: add FDIR support net/ice/base: change profile priority for RSS reply net/ice/base: fix duplicate resource allocations net/ice/base: fix minor issues net/ice/base: increase prototol offset size net/ice/base: revert the workaround for resource allocation net/ice/base: rework on bit ops drivers/net/ice/Makefile | 2 + drivers/net/ice/base/ice_adminq_cmd.h | 515 +++++- drivers/net/ice/base/ice_alloc.h | 2 +- drivers/net/ice/base/ice_bitops.h | 361 +++++ drivers/net/ice/base/ice_common.c | 650 ++++++-- drivers/net/ice/base/ice_common.h | 36 +- drivers/net/ice/base/ice_controlq.c | 10 +- drivers/net/ice/base/ice_controlq.h | 2 +- drivers/net/ice/base/ice_dcb.c | 1393 ++++++++++++++++ drivers/net/ice/base/ice_dcb.h | 223 +++ drivers/net/ice/base/ice_devids.h | 2 +- drivers/net/ice/base/ice_fdir.c | 742 +++++++++ drivers/net/ice/base/ice_fdir.h | 202 +++ drivers/net/ice/base/ice_flex_pipe.c | 1075 +++++++------ drivers/net/ice/base/ice_flex_pipe.h | 4 +- drivers/net/ice/base/ice_flex_type.h | 19 +- drivers/net/ice/base/ice_flow.c | 224 +-- drivers/net/ice/base/ice_flow.h | 22 +- drivers/net/ice/base/ice_hw_autogen.h | 2 +- drivers/net/ice/base/ice_lan_tx_rx.h | 149 +- drivers/net/ice/base/ice_nvm.c | 17 +- drivers/net/ice/base/ice_osdep.h | 184 +-- drivers/net/ice/base/ice_protocol_type.h | 8 +- drivers/net/ice/base/ice_sbq_cmd.h | 2 +- drivers/net/ice/base/ice_sched.c | 2563 +++++++++++++++--------------- drivers/net/ice/base/ice_sched.h | 34 +- drivers/net/ice/base/ice_status.h | 3 +- drivers/net/ice/base/ice_switch.c | 1315 ++++++++++++++- drivers/net/ice/base/ice_switch.h | 109 +- drivers/net/ice/base/ice_type.h | 120 +- drivers/net/ice/base/meson.build | 2 + drivers/net/ice/ice_rxtx.c | 13 +- 32 files changed, 7474 insertions(+), 2531 deletions(-) create mode 100644 drivers/net/ice/base/ice_bitops.h create mode 100644 drivers/net/ice/base/ice_dcb.c create mode 100644 drivers/net/ice/base/ice_dcb.h create mode 100644 drivers/net/ice/base/ice_fdir.c create mode 100644 drivers/net/ice/base/ice_fdir.h
Comments
> -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, March 25, 2019 1:44 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming > <qiming.yang@intel.com> > Cc: dev@dpdk.org; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Yigit, > Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: [PATCH v4 00/38] ice share code update. > > Sync to latest kernel driver, main changes: > 1. add DCB/FDIR support. > 2. add more APIs in switch module. > 3. code clean and bug fix. > > v4: > - revert the fix for UDP PTYPE setup (PATCH 38/38 on v3) since its invalid. > - move bit ops to dedicate file and remove the 64 bit limitation of bitmap. > - improved commit log. > > v3: > - fix software queue handle parsing in ice_ena_vsi_txq and > ice_dis_vsi_txq (PATCH 19/38) which will cause Tx queue setup > fail during device reconfigure. > - Add new fix for UDP PTYPE setup. (PATCH 38/38), which will > cause IPv4 TCP RSS does not work at some situation. > > v2: > - Enhanced the commit log > - Add missing fixed line. > > Qi Zhang (38): > net/ice/base: add switch resource allocation and free > net/ice/base: improve comments > net/ice/base: add two helper functions > net/ice/base: add helper macros > net/ice/base: allow package copy to be used after resets > net/ice/base: clean code > net/ice/base: declare functions as external > net/ice/base: add more APIs in switch module > net/ice/base: add VSI queue context framework > net/ice/base: add APIs to add remove ethertype filter > net/ice/base: add APIs to get allocated resources > net/ice/base: add APIs to alloc/free resource counter > net/ice/base: add APIs to get VSI promiscuous mode > net/ice/base: add MAC filter with marker and counter > net/ice/base: add two helper functions for flow management > net/ice/base: fix minor issues > net/ice/base: update macros > net/ice/base: clean code > net/ice/base: enable VSI queue context > net/ice/base: ensure only valid bits are set > net/ice/base: enhance get link status command > net/ice/base: add RSS key related macro and structures > net/ice/base: do not write TCAM entries back > net/ice/base: remove local VSIG allocations > net/ice/base: fix minor issues > net/ice/base: update copyright time > net/ice/base: fix Klockwork analysis reported issues > net/ice/base: return config error without queue to disable > net/ice/base: add function to check FW recovery mode > net/ice/base: change profile id reference counting > net/ice/base: add DCB support > net/ice/base: add FDIR support > net/ice/base: change profile priority for RSS reply > net/ice/base: fix duplicate resource allocations > net/ice/base: fix minor issues > net/ice/base: increase prototol offset size > net/ice/base: revert the workaround for resource allocation > net/ice/base: rework on bit ops > > drivers/net/ice/Makefile | 2 + > drivers/net/ice/base/ice_adminq_cmd.h | 515 +++++- > drivers/net/ice/base/ice_alloc.h | 2 +- > drivers/net/ice/base/ice_bitops.h | 361 +++++ > drivers/net/ice/base/ice_common.c | 650 ++++++-- > drivers/net/ice/base/ice_common.h | 36 +- > drivers/net/ice/base/ice_controlq.c | 10 +- > drivers/net/ice/base/ice_controlq.h | 2 +- > drivers/net/ice/base/ice_dcb.c | 1393 ++++++++++++++++ > drivers/net/ice/base/ice_dcb.h | 223 +++ > drivers/net/ice/base/ice_devids.h | 2 +- > drivers/net/ice/base/ice_fdir.c | 742 +++++++++ > drivers/net/ice/base/ice_fdir.h | 202 +++ > drivers/net/ice/base/ice_flex_pipe.c | 1075 +++++++------ > drivers/net/ice/base/ice_flex_pipe.h | 4 +- > drivers/net/ice/base/ice_flex_type.h | 19 +- > drivers/net/ice/base/ice_flow.c | 224 +-- > drivers/net/ice/base/ice_flow.h | 22 +- > drivers/net/ice/base/ice_hw_autogen.h | 2 +- > drivers/net/ice/base/ice_lan_tx_rx.h | 149 +- > drivers/net/ice/base/ice_nvm.c | 17 +- > drivers/net/ice/base/ice_osdep.h | 184 +-- > drivers/net/ice/base/ice_protocol_type.h | 8 +- > drivers/net/ice/base/ice_sbq_cmd.h | 2 +- > drivers/net/ice/base/ice_sched.c | 2563 > +++++++++++++++--------------- > drivers/net/ice/base/ice_sched.h | 34 +- > drivers/net/ice/base/ice_status.h | 3 +- > drivers/net/ice/base/ice_switch.c | 1315 ++++++++++++++- > drivers/net/ice/base/ice_switch.h | 109 +- > drivers/net/ice/base/ice_type.h | 120 +- > drivers/net/ice/base/meson.build | 2 + > drivers/net/ice/ice_rxtx.c | 13 +- > 32 files changed, 7474 insertions(+), 2531 deletions(-) create mode 100644 > drivers/net/ice/base/ice_bitops.h create mode 100644 > drivers/net/ice/base/ice_dcb.c create mode 100644 > drivers/net/ice/base/ice_dcb.h create mode 100644 > drivers/net/ice/base/ice_fdir.c create mode 100644 > drivers/net/ice/base/ice_fdir.h > > -- > 2.13.6 Applied to dpdk-next-net-intel. Thanks Qi
25/03/2019 08:07, Zhang, Qi Z: > > Sync to latest kernel driver, main changes: > > 1. add DCB/FDIR support. > > 2. add more APIs in switch module. > > 3. code clean and bug fix. > > > > Qi Zhang (38): > > net/ice/base: add switch resource allocation and free > > net/ice/base: improve comments > > net/ice/base: add two helper functions > > net/ice/base: add helper macros > > net/ice/base: allow package copy to be used after resets > > net/ice/base: clean code > > net/ice/base: declare functions as external > > net/ice/base: add more APIs in switch module > > net/ice/base: add VSI queue context framework > > net/ice/base: add APIs to add remove ethertype filter > > net/ice/base: add APIs to get allocated resources > > net/ice/base: add APIs to alloc/free resource counter > > net/ice/base: add APIs to get VSI promiscuous mode > > net/ice/base: add MAC filter with marker and counter > > net/ice/base: add two helper functions for flow management > > net/ice/base: fix minor issues > > net/ice/base: update macros > > net/ice/base: clean code > > net/ice/base: enable VSI queue context > > net/ice/base: ensure only valid bits are set > > net/ice/base: enhance get link status command > > net/ice/base: add RSS key related macro and structures > > net/ice/base: do not write TCAM entries back > > net/ice/base: remove local VSIG allocations > > net/ice/base: fix minor issues > > net/ice/base: update copyright time > > net/ice/base: fix Klockwork analysis reported issues > > net/ice/base: return config error without queue to disable > > net/ice/base: add function to check FW recovery mode > > net/ice/base: change profile id reference counting > > net/ice/base: add DCB support > > net/ice/base: add FDIR support > > net/ice/base: change profile priority for RSS reply > > net/ice/base: fix duplicate resource allocations > > net/ice/base: fix minor issues > > net/ice/base: increase prototol offset size > > net/ice/base: revert the workaround for resource allocation > > net/ice/base: rework on bit ops > > Applied to dpdk-next-net-intel. > > Thanks > Qi 3 commits have the title "fix minor issues", that's a funny performance. When the ice PMD will enter in a serious phase, you should write some real commit titles and explain what are the fixed issues. For DPDK 19.05, I guess it's fine because ice PMD is not going to be really used soon, right?
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 1, 2019 1:06 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming > <qiming.yang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; > Yigit, Ferruh <ferruh.yigit@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; > Mcnamara, John <john.mcnamara@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update. > > 25/03/2019 08:07, Zhang, Qi Z: > > > Sync to latest kernel driver, main changes: > > > 1. add DCB/FDIR support. > > > 2. add more APIs in switch module. > > > 3. code clean and bug fix. > > > > > > Qi Zhang (38): > > > net/ice/base: add switch resource allocation and free > > > net/ice/base: improve comments > > > net/ice/base: add two helper functions > > > net/ice/base: add helper macros > > > net/ice/base: allow package copy to be used after resets > > > net/ice/base: clean code > > > net/ice/base: declare functions as external > > > net/ice/base: add more APIs in switch module > > > net/ice/base: add VSI queue context framework > > > net/ice/base: add APIs to add remove ethertype filter > > > net/ice/base: add APIs to get allocated resources > > > net/ice/base: add APIs to alloc/free resource counter > > > net/ice/base: add APIs to get VSI promiscuous mode > > > net/ice/base: add MAC filter with marker and counter > > > net/ice/base: add two helper functions for flow management > > > net/ice/base: fix minor issues > > > net/ice/base: update macros > > > net/ice/base: clean code > > > net/ice/base: enable VSI queue context > > > net/ice/base: ensure only valid bits are set > > > net/ice/base: enhance get link status command > > > net/ice/base: add RSS key related macro and structures > > > net/ice/base: do not write TCAM entries back > > > net/ice/base: remove local VSIG allocations > > > net/ice/base: fix minor issues > > > net/ice/base: update copyright time > > > net/ice/base: fix Klockwork analysis reported issues > > > net/ice/base: return config error without queue to disable > > > net/ice/base: add function to check FW recovery mode > > > net/ice/base: change profile id reference counting > > > net/ice/base: add DCB support > > > net/ice/base: add FDIR support > > > net/ice/base: change profile priority for RSS reply > > > net/ice/base: fix duplicate resource allocations > > > net/ice/base: fix minor issues > > > net/ice/base: increase prototol offset size > > > net/ice/base: revert the workaround for resource allocation > > > net/ice/base: rework on bit ops > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi > > 3 commits have the title "fix minor issues", that's a funny performance. > When the ice PMD will enter in a serious phase, you should write some real > commit titles and explain what are the fixed issues. > For DPDK 19.05, I guess it's fine because ice PMD is not going to be really used > soon, right? Yes, the share code in 19.05 can be regarded as an initial version, the commit log is not quite sensitive for developers. Thanks to forgive this rough, this will not happen in our following share code update :) >