Message ID | 1551888011-27692-1-git-send-email-bernard.iremonger@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDA2D1B119; Wed, 6 Mar 2019 17:00:21 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 374475F20 for <dev@dpdk.org>; Wed, 6 Mar 2019 17:00:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 08:00:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,448,1544515200"; d="scan'208";a="325973448" Received: from sivswdev08.ir.intel.com (HELO localhost.localdomain) ([10.237.217.47]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2019 08:00:15 -0800 From: Bernard Iremonger <bernard.iremonger@intel.com> To: dev@dpdk.org, konstantin.ananyev@intel.com, akhil.goyal@nxp.com Cc: Bernard Iremonger <bernard.iremonger@intel.com> Date: Wed, 6 Mar 2019 16:00:05 +0000 Message-Id: <1551888011-27692-1-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
examples/ipsec-secgw: fix 1st pkt dropped
|
|
Message
Iremonger, Bernard
March 6, 2019, 4 p.m. UTC
This patchset fixes the issue of the first inbound packet being dropped for inline crypto. It also improves the debug output in esp.c, sa.c and ipsec-secgw.c Bernard Iremonger (6): examples/ipsec-secgw: fix 1st pkt dropped for inline crypto examples/ipsec-secgw: fix 1st packet dropped patch two examples/ipsec-secgw: fix 1st packet dropped patch three examples/ipsec-secgw: fix debug in esp.c examples/ipsec-secgw: fix debug in sa.c examples/ipsec-secgw: fix debug in ipsec-secgw.c examples/ipsec-secgw/esp.c | 5 +- examples/ipsec-secgw/ipsec-secgw.c | 252 ++++++++++++++++++----------------- examples/ipsec-secgw/ipsec.c | 123 +++++++++++------ examples/ipsec-secgw/ipsec.h | 5 +- examples/ipsec-secgw/ipsec_process.c | 9 +- examples/ipsec-secgw/sa.c | 67 ++++++++-- 6 files changed, 274 insertions(+), 187 deletions(-)
Comments
Hi Bernard, On 3/6/2019 9:30 PM, Bernard Iremonger wrote: > This patchset fixes the issue of the first inbound packet > being dropped for inline crypto. It also improves the debug > output in esp.c, sa.c and ipsec-secgw.c > > Bernard Iremonger (6): > examples/ipsec-secgw: fix 1st pkt dropped for inline crypto > examples/ipsec-secgw: fix 1st packet dropped patch two > examples/ipsec-secgw: fix 1st packet dropped patch three patch titles are not good. You can probably add some logical comments in the description. you may also consider squashing the patches if no logical bifurcation can be made. > examples/ipsec-secgw: fix debug in esp.c > examples/ipsec-secgw: fix debug in sa.c > examples/ipsec-secgw: fix debug in ipsec-secgw.c Above 3 patches can be squashed and can be separated from this series. > examples/ipsec-secgw/esp.c | 5 +- > examples/ipsec-secgw/ipsec-secgw.c | 252 ++++++++++++++++++----------------- > examples/ipsec-secgw/ipsec.c | 123 +++++++++++------ > examples/ipsec-secgw/ipsec.h | 5 +- > examples/ipsec-secgw/ipsec_process.c | 9 +- > examples/ipsec-secgw/sa.c | 67 ++++++++-- > 6 files changed, 274 insertions(+), 187 deletions(-) >
Hi Akhil, <snip> > Subject: Re: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped > > Hi Bernard, > > On 3/6/2019 9:30 PM, Bernard Iremonger wrote: > > This patchset fixes the issue of the first inbound packet being > > dropped for inline crypto. It also improves the debug output in esp.c, > > sa.c and ipsec-secgw.c > > > > Bernard Iremonger (6): > > examples/ipsec-secgw: fix 1st pkt dropped for inline crypto > > examples/ipsec-secgw: fix 1st packet dropped patch two > > examples/ipsec-secgw: fix 1st packet dropped patch three > patch titles are not good. You can probably add some logical comments in the > description. I will update the patch titles and descriptions. > you may also consider squashing the patches if no logical bifurcation can be > made. I thought it might be easier to review the changes as separate patches. If you prefer one patch I can squash them. > > examples/ipsec-secgw: fix debug in esp.c > > examples/ipsec-secgw: fix debug in sa.c > > examples/ipsec-secgw: fix debug in ipsec-secgw.c > Above 3 patches can be squashed and can be separated from this series. I will remove from this patch set, squash and send as an independent patch. > > examples/ipsec-secgw/esp.c | 5 +- > > examples/ipsec-secgw/ipsec-secgw.c | 252 ++++++++++++++++++------------ > ----- > > examples/ipsec-secgw/ipsec.c | 123 +++++++++++------ > > examples/ipsec-secgw/ipsec.h | 5 +- > > examples/ipsec-secgw/ipsec_process.c | 9 +- > > examples/ipsec-secgw/sa.c | 67 ++++++++-- > > 6 files changed, 274 insertions(+), 187 deletions(-) > > Regards, Bernard.