Message ID | 1423416981-5168-2-git-send-email-stephen@networkplumber.org (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 6BD5258FA; Sun, 8 Feb 2015 18:36:39 +0100 (CET) Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id CEC3258E8 for <dev@dpdk.org>; Sun, 8 Feb 2015 18:36:37 +0100 (CET) Received: by pdjy10 with SMTP id y10so3385513pdj.6 for <dev@dpdk.org>; Sun, 08 Feb 2015 09:36:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nKNQ7kEzAxIXjcXDqHzxWe7NQo+xi0FWnNw+FLQgsVw=; b=WnhtFMRDCmcmPeYCyKKnUtMnli3d8dV5CyOj7HD0F0mMdcm55XHljrUOiCFqMiYqpU dg+3tdSL68WV5XFBZ6ptnr28BVgH5C+LKh7pXW7MAFZnk1OlrRAZmcfiDMPKFp8hzBJO Hb2H2XkmydTnl6fBQta7XAxJCoQsWd/qXTTIWsWwFrJ/uQdqNkE6SEA4m7X8uqL72Rg/ L5TKCBfTXRqp6t5anFRXrPbQLwcv/jseEcDB85weKl3LoieLGOLcZrWyJg/Psp3m/0DL LK7f/6NCSIEzHw2t/0WhLzJhdPrglnxP0FEfraynBRvQXyzY0jDeQdsnGPIhtUY+ilEo k/Ow== X-Gm-Message-State: ALoCoQnr/kytShExEv5IoPWpbE2OLJtFxPGAN1cFX7doajBXUguoKTfpC1yFQ/KtYOCyxpo1XlHT X-Received: by 10.70.90.39 with SMTP id bt7mr21764315pdb.52.1423416997206; Sun, 08 Feb 2015 09:36:37 -0800 (PST) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ib3sm13905614pbc.41.2015.02.08.09.36.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Feb 2015 09:36:36 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Date: Sun, 8 Feb 2015 09:36:21 -0800 Message-Id: <1423416981-5168-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1423416981-5168-1-git-send-email-stephen@networkplumber.org> References: <1423416981-5168-1-git-send-email-stephen@networkplumber.org> Cc: Stephen Hemminger <shemming@brocade.com> Subject: [dpdk-dev] [PATCH] enic: silence log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Stephen Hemminger
Feb. 8, 2015, 5:36 p.m. UTC
From: Stephen Hemminger <shemming@brocade.com> Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-)
Comments
On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > From: Stephen Hemminger <shemming@brocade.com> > > Silence is normal. drivers should speak only when spoken to and not > be chatty. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > lib/librte_pmd_enic/enic_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_pmd_enic/enic_main.c > b/lib/librte_pmd_enic/enic_main.c > index 48fdca2..dad8922 100644 > --- a/lib/librte_pmd_enic/enic_main.c > +++ b/lib/librte_pmd_enic/enic_main.c > @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic) > struct rte_pci_device *pdev = enic->pdev; > int err = -1; > > - dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); > - > enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; > enic->bar0.len = pdev->mem_resource[0].len; > NAK. The main problem is that enic pmd is using printf to write logs. So the pmd should be fixed so that dev_* macros use RTE_LOG. Silence is good when it is the default behaviour. But I prefer we can change this at runtime, rather than strip the log messages, especially for init.
Agree it should not use printf. If you insist on keeping the useless message then it should be log level debug
Hi Stephen, David, I agree with you and shall submit this change. Thanks, -Sujith On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen@networkplumber.org> wrote: >Agree it should not use printf. >If you insist on keeping the useless message then it should be log level >debug
Stephen, Saw your patch. Will take a look. Thanks, -Sujith On 15/02/15 11:43 am, "Sujith Sankar (ssujith)" <ssujith@cisco.com> wrote: >Hi Stephen, David, > >I agree with you and shall submit this change. > >Thanks, >-Sujith > >On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen@networkplumber.org> >wrote: > >>Agree it should not use printf. >>If you insist on keeping the useless message then it should be log level >>debug >
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c index 48fdca2..dad8922 100644 --- a/lib/librte_pmd_enic/enic_main.c +++ b/lib/librte_pmd_enic/enic_main.c @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic) struct rte_pci_device *pdev = enic->pdev; int err = -1; - dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION); - enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; enic->bar0.len = pdev->mem_resource[0].len;