| Message ID | 1468271491-28510-1-git-send-email-3chas3@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Bruce Richardson |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8DB9C2BA1; Mon, 11 Jul 2016 23:11:43 +0200 (CEST) Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by dpdk.org (Postfix) with ESMTP id 3AFD2FE5 for <dev@dpdk.org>; Mon, 11 Jul 2016 23:11:42 +0200 (CEST) Received: by mail-qt0-f194.google.com with SMTP id q11so2313141qtb.2 for <dev@dpdk.org>; Mon, 11 Jul 2016 14:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=QW5c6OYUsTX9Ci3sw1rc8EaQnnpOIldokKOB0qowwEs=; b=xv34fmvfDPjEOuqj6BAD5Xq3gNGU2ZYq6YHt1qZJmb+RFUhyN6Yro1Zx9c0N62XdV5 Qj46HpeHHa0ioUw4/srNIaQBpC4CTIIMycY2i9CpxgyzoXHdPskM04j7pX8SVYx38YdH 0KLD2tqv0wntEiBPbYYiaITM/I1i15dDFSTWbBmFdNJkWOOvZb78gzXPng31GOHmCQCK OGIIBNqwFxeuilN6+TbyC8lnzi1fjR5k1Mhlvx4yhan+h6/ktRXzd1UNjkLcfzDkhvjn cMqjM+sYOvNUAMwD2pW9DL+7yqhH3U6YJFI1/z+I3fkuymN2kSPlHa7Ai3AHUjTy/xc7 ai3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QW5c6OYUsTX9Ci3sw1rc8EaQnnpOIldokKOB0qowwEs=; b=V1ti5IPDLDej/DuN5hTJt4Aq86iLT+w/NhZlJFbLfolMDZht/+cIj+Xk2ZAId3Mlav CMJ1eOUWGbdaRHTlS05vVtZVDaMdGMW4S7DiDhlcoifRTFKiFlpjZAKw6slSWY+oTI62 3YWcx7n+WF7OGqbaQdl1oGKzNeyKO4Zzmy70q5LI2exOFvXCVh7FC5BL/KaAL2vUvqil KGrH8hqPb9A/VRPeqrbuzELzhj0bRA1q3No564G4IMf/jq2QVrRPZR9XPZxL9byn68go vVGMs+kKcZjrJ7ulXL2HZNIOF4NRrm826Y8v4mVDaavlWbPP9yK/YDei70BSWF3SMs69 rjsA== X-Gm-Message-State: ALyK8tIO+0xw8Gg5xSWz1VFPe6n2Td631Mq+H1DGuU+LM11cxxdUiyRoePF6jLoMFqXYvg== X-Received: by 10.200.46.216 with SMTP id i24mr22720541qta.79.1468271501486; Mon, 11 Jul 2016 14:11:41 -0700 (PDT) Received: from monolith.home (pool-173-79-169-182.washdc.fios.verizon.net. [173.79.169.182]) by smtp.gmail.com with ESMTPSA id w16sm3137546qta.10.2016.07.11.14.11.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 14:11:41 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: harish.patil@qlogic.com, Chas Williams <3chas3@gmail.com> Date: Mon, 11 Jul 2016 17:11:22 -0400 Message-Id: <1468271491-28510-1-git-send-email-3chas3@gmail.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH 01/10] bnx2x: Set cache line based on build configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Chas Williams
July 11, 2016, 9:11 p.m. UTC
Correctly hint the cache line size. Remove unused macros associated
with the cache line size.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3@gmail.com>
---
drivers/net/bnx2x/bnx2x.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Comments
> >Correctly hint the cache line size. Remove unused macros associated >with the cache line size. > >Fixes: 540a211084a7 ("bnx2x: driver core") > >Signed-off-by: Chas Williams <3chas3@gmail.com> >--- > drivers/net/bnx2x/bnx2x.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h >index 135a6eb..852ec94 100644 >--- a/drivers/net/bnx2x/bnx2x.h >+++ b/drivers/net/bnx2x/bnx2x.h >@@ -302,10 +302,7 @@ struct bnx2x_device_type { > /* TCP with Timestamp Option (32) + IPv6 (40) */ > > /* max supported alignment is 256 (8 shift) */ >-#define BNX2X_RX_ALIGN_SHIFT 8 >-/* FW uses 2 cache lines alignment for start packet and size */ >-#define BNX2X_FW_RX_ALIGN_START (1 << BNX2X_RX_ALIGN_SHIFT) >-#define BNX2X_FW_RX_ALIGN_END (1 << BNX2X_RX_ALIGN_SHIFT) >+#define BNX2X_RX_ALIGN_SHIFT RTE_MAX(6, min(8, RTE_CACHE_LINE_SIZE_LOG2)) > > #define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5) > >-- >2.5.5 > > Acked-by: Harish Patil <harish.patil@qlogic.com>
Hi Harish, On 7/12/2016 6:39 AM, Harish Patil wrote: >> >> Correctly hint the cache line size. Remove unused macros associated >> with the cache line size. >> >> Fixes: 540a211084a7 ("bnx2x: driver core") >> >> Signed-off-by: Chas Williams <3chas3@gmail.com> >> --- >> drivers/net/bnx2x/bnx2x.h | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h >> index 135a6eb..852ec94 100644 >> --- a/drivers/net/bnx2x/bnx2x.h >> +++ b/drivers/net/bnx2x/bnx2x.h >> @@ -302,10 +302,7 @@ struct bnx2x_device_type { >> /* TCP with Timestamp Option (32) + IPv6 (40) */ >> >> /* max supported alignment is 256 (8 shift) */ >> -#define BNX2X_RX_ALIGN_SHIFT 8 >> -/* FW uses 2 cache lines alignment for start packet and size */ >> -#define BNX2X_FW_RX_ALIGN_START (1 << BNX2X_RX_ALIGN_SHIFT) >> -#define BNX2X_FW_RX_ALIGN_END (1 << BNX2X_RX_ALIGN_SHIFT) >> +#define BNX2X_RX_ALIGN_SHIFT RTE_MAX(6, min(8, RTE_CACHE_LINE_SIZE_LOG2)) >> >> #define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5) >> >> -- >> 2.5.5 >> >> > > Acked-by: Harish Patil <harish.patil@qlogic.com> > Is the Ack for this patch (01/10) or for the series? Thanks, ferruh
> >Hi Harish, > >On 7/12/2016 6:39 AM, Harish Patil wrote: >>> >>> Correctly hint the cache line size. Remove unused macros associated >>> with the cache line size. >>> >>> Fixes: 540a211084a7 ("bnx2x: driver core") >>> >>> Signed-off-by: Chas Williams <3chas3@gmail.com> >>> --- >>> drivers/net/bnx2x/bnx2x.h | 5 +---- >>> 1 file changed, 1 insertion(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h >>> index 135a6eb..852ec94 100644 >>> --- a/drivers/net/bnx2x/bnx2x.h >>> +++ b/drivers/net/bnx2x/bnx2x.h >>> @@ -302,10 +302,7 @@ struct bnx2x_device_type { >>> /* TCP with Timestamp Option (32) + IPv6 (40) */ >>> >>> /* max supported alignment is 256 (8 shift) */ >>> -#define BNX2X_RX_ALIGN_SHIFT 8 >>> -/* FW uses 2 cache lines alignment for start packet and size */ >>> -#define BNX2X_FW_RX_ALIGN_START (1 << BNX2X_RX_ALIGN_SHIFT) >>> -#define BNX2X_FW_RX_ALIGN_END (1 << BNX2X_RX_ALIGN_SHIFT) >>> +#define BNX2X_RX_ALIGN_SHIFT RTE_MAX(6, min(8, >>>RTE_CACHE_LINE_SIZE_LOG2)) >>> >>> #define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5) >>> >>> -- >>> 2.5.5 >>> >>> >> >> Acked-by: Harish Patil <harish.patil@qlogic.com> >> > >Is the Ack for this patch (01/10) or for the series? > >Thanks, >ferruh > > Hi Ferruh, I meant it for only this patch. Let me scan thru’ for the series and ack. Thanks, Harish
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 135a6eb..852ec94 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers/net/bnx2x/bnx2x.h @@ -302,10 +302,7 @@ struct bnx2x_device_type { /* TCP with Timestamp Option (32) + IPv6 (40) */ /* max supported alignment is 256 (8 shift) */ -#define BNX2X_RX_ALIGN_SHIFT 8 -/* FW uses 2 cache lines alignment for start packet and size */ -#define BNX2X_FW_RX_ALIGN_START (1 << BNX2X_RX_ALIGN_SHIFT) -#define BNX2X_FW_RX_ALIGN_END (1 << BNX2X_RX_ALIGN_SHIFT) +#define BNX2X_RX_ALIGN_SHIFT RTE_MAX(6, min(8, RTE_CACHE_LINE_SIZE_LOG2)) #define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5)