[3/3] rcu: use rte macro instead of GCC attribute
Checks
Commit Message
Use existing __rte_pure macro from rte_common.h instead of directly
using __attribute__((__may_alias__)).
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/rcu/rcu_qsbr_pvt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Wednesday, 28 February 2024 00.08
>
> Use existing __rte_pure macro from rte_common.h instead of directly
Typo: __rte_pure -> __rte_may_alias
The code is correct, only the description has the typo.
> using __attribute__((__may_alias__)).
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
With the typo corrected,
For the series,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
On Wed, Feb 28, 2024 at 10:29:11AM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Wednesday, 28 February 2024 00.08
> >
> > Use existing __rte_pure macro from rte_common.h instead of directly
>
> Typo: __rte_pure -> __rte_may_alias
>
> The code is correct, only the description has the typo.
>
> > using __attribute__((__may_alias__)).
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
>
> With the typo corrected,
bah, i get tired :)
thanks.
> For the series,
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
@@ -53,6 +53,6 @@ struct rte_rcu_qsbr_dq {
typedef struct {
uint64_t token; /**< Token */
uint8_t elem[0]; /**< Pointer to user element */
-} __attribute__((__may_alias__)) __rte_rcu_qsbr_dq_elem_t;
+} __rte_may_alias __rte_rcu_qsbr_dq_elem_t;
#endif /* _RTE_RCU_QSBR_PVT_H_ */