[v2,1/1] doc: announce addition of new ipsec event subtypes
Checks
Commit Message
New event subtypes need to be added for notifying expiry events
upon reaching IPsec SA soft packet expiry and hard packet/byte
expiry limits. This would be added in DPDK 22.11.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
More details on new event subtype proposal discussion are in below email thread.
https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
v2: rephrase title and git log.
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
Comments
> -----Original Message-----
> From: Vamsi Attunuru <vattunuru@marvell.com>
> Sent: Monday, June 27, 2022 6:30 AM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> mdr@ashroe.eu
> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
>
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email
> thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> gakhil@marvell.com/
>
> v2: rephrase title and git log.
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> > Sent: Monday, June 27, 2022 6:30 AM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> > ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> > mdr@ashroe.eu
> > Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
> >
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> > thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> > gakhil@marvell.com/
> >
> > v2: rephrase title and git log.
> > ---
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
On 7/11/22 17:53, Jerin Jacob wrote:
> On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>>
>>> -----Original Message-----
>>> From: Vamsi Attunuru <vattunuru@marvell.com>
>>> Sent: Monday, June 27, 2022 6:30 AM
>>> To: dev@dpdk.org
>>> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
>>> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
>>> mdr@ashroe.eu
>>> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
>>>
>>> New event subtypes need to be added for notifying expiry events
>>> upon reaching IPsec SA soft packet expiry and hard packet/byte
>>> expiry limits. This would be added in DPDK 22.11.
>>>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>>> Acked-by: Akhil Goyal <gakhil@marvell.com>
>>> ---
>>> More details on new event subtype proposal discussion are in below email
>>> thread.
>>> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
>>> gakhil@marvell.com/
>>>
>>> v2: rephrase title and git log.
>>> ---
>> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
27/06/2022 07:29, Vamsi Attunuru:
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
>
> v2: rephrase title and git log.
> ---
> +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
> + new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> + ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> + ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
While at it, would you consider avoiding future ABI breakage
with RTE_ETH_EVENT_IPSEC_MAX?
> 27/06/2022 07:29, Vamsi Attunuru:
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > v2: rephrase title and git log.
> > ---
> > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> add
> > + new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > + ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > + ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
>
> While at it, would you consider avoiding future ABI breakage
> with RTE_ETH_EVENT_IPSEC_MAX?
For MAX values there is already a generic notice. Do you want to mention this here as well?
IMO, it is not required. We can work on it, but do not need explicit mention here.
Regards,
Akhil
12/07/2022 17:30, Akhil Goyal:
> > 27/06/2022 07:29, Vamsi Attunuru:
> > > New event subtypes need to be added for notifying expiry events
> > > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > > expiry limits. This would be added in DPDK 22.11.
> > >
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > More details on new event subtype proposal discussion are in below email
> > thread.
> > > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > > v2: rephrase title and git log.
> > > ---
> > > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> > add
> > > + new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > > + ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > > + ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
> >
> > While at it, would you consider avoiding future ABI breakage
> > with RTE_ETH_EVENT_IPSEC_MAX?
>
> For MAX values there is already a generic notice. Do you want to mention this here as well?
> IMO, it is not required. We can work on it, but do not need explicit mention here.
OK I forgot we had already a generic notice.
> >>> New event subtypes need to be added for notifying expiry events
> >>> upon reaching IPsec SA soft packet expiry and hard packet/byte
> >>> expiry limits. This would be added in DPDK 22.11.
> >>>
> >>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> >>> Acked-by: Akhil Goyal <gakhil@marvell.com>
> >> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Applied, thanks.
@@ -107,6 +107,11 @@ Deprecation Notices
alternative is implemented.
The legacy actions should be removed in DPDK 22.11.
+* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
+ new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
+ ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
+ ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
+
* cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
``rte_cryptodev_asym_session`` to remove unnecessary indirection between
session and the private data of session. An opaque pointer can be exposed