cryptodev: fix cryptodev parameter parsing
Checks
Commit Message
The rte_cryptodev_pmd_parse_input_args function crashes with a
segmentation fault when passing a non-empty argument string.
The function passes cryptodev_pmd_valid_params to rte_kvargs_parse,
which accepts a NULL-terminated list of valid keys, yet
cryptodev_pmd_valid_params does not end with NULL. The patch adds the
missing NULL pointer.
Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
Cc: stable@dpdk.org
Signed-off-by: Haggai Eran <haggaie@nvidia.com>
---
lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
> The rte_cryptodev_pmd_parse_input_args function crashes with a
> segmentation fault when passing a non-empty argument string.
>
> The function passes cryptodev_pmd_valid_params to rte_kvargs_parse,
> which accepts a NULL-terminated list of valid keys, yet
> cryptodev_pmd_valid_params does not end with NULL. The patch adds the
> missing NULL pointer.
>
> Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Haggai Eran <haggaie@nvidia.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks.
@@ -41,7 +41,8 @@
static const char * const cryptodev_pmd_valid_params[] = {
RTE_CRYPTODEV_PMD_NAME_ARG,
RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG,
- RTE_CRYPTODEV_PMD_SOCKET_ID_ARG
+ RTE_CRYPTODEV_PMD_SOCKET_ID_ARG,
+ NULL
};
/**