[v4,3/5] app/procinfo: add Rx buffer size to --show-port
Checks
Commit Message
Add Rx buffer size to show_port function to display it in the port PMD
information so that the user can get the buffer length used by HW queue
of receiving packets.
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
---
app/proc-info/main.c | 2 ++
1 file changed, 2 insertions(+)
--
2.7.4
Comments
On Sat, 5 Sep 2020 17:07:32 +0800
Chengchang Tang <tangchengchang@huawei.com> wrote:
> printf("\t -- queue %d rx scatter %d"
> " descriptors %d"
> + " rx buffer size %d"
> " offloads 0x%"PRIx64
> " mempool socket %d\n",
> j,
> queue_info.scattered_rx,
> queue_info.nb_desc,
> + queue_info.rx_buf_size,
> queue_info.conf.offloads,
> queue_info.mp->socket_id);
> }
These should be using %u and need space after " for PRIx64
Why not:
printf("\t -- queue %u rx scatter %u"
" descriptors %u"
" rx buffer size %u"
" offloads %#" PRIx64
" mempool socket %d\n",
On 2020/9/6 0:59, Stephen Hemminger wrote:
> On Sat, 5 Sep 2020 17:07:32 +0800
> Chengchang Tang <tangchengchang@huawei.com> wrote:
>
>> printf("\t -- queue %d rx scatter %d"
>> " descriptors %d"
>> + " rx buffer size %d"
>> " offloads 0x%"PRIx64
>> " mempool socket %d\n",
>> j,
>> queue_info.scattered_rx,
>> queue_info.nb_desc,
>> + queue_info.rx_buf_size,
>> queue_info.conf.offloads,
>> queue_info.mp->socket_id);
>> }
>
> These should be using %u and need space after " for PRIx64
> Why not:
> printf("\t -- queue %u rx scatter %u"
> " descriptors %u"
> " rx buffer size %u"
> " offloads %#" PRIx64
> " mempool socket %d\n",
>
OK, I will fix these in next version.
Thanks
On Mon, 7 Sep 2020 17:14:48 +0800
Chengchang Tang <tangchengchang@huawei.com> wrote:
> On 2020/9/6 0:59, Stephen Hemminger wrote:
> > On Sat, 5 Sep 2020 17:07:32 +0800
> > Chengchang Tang <tangchengchang@huawei.com> wrote:
> >
> >> printf("\t -- queue %d rx scatter %d"
> >> " descriptors %d"
> >> + " rx buffer size %d"
> >> " offloads 0x%"PRIx64
> >> " mempool socket %d\n",
> >> j,
> >> queue_info.scattered_rx,
> >> queue_info.nb_desc,
> >> + queue_info.rx_buf_size,
> >> queue_info.conf.offloads,
> >> queue_info.mp->socket_id);
> >> }
> >
> > These should be using %u and need space after " for PRIx64
> > Why not:
> > printf("\t -- queue %u rx scatter %u"
> > " descriptors %u"
> > " rx buffer size %u"
> > " offloads %#" PRIx64
> > " mempool socket %d\n",
> >
>
> OK, I will fix these in next version.
>
> Thanks
NAK, these is superseded by.
Please look at the new improved procinfo still stuck in patchwork
https://patchwork.dpdk.org/patch/74960/
Let's put the buffer size there.
Hi, All
These Patches improved procinfo was stuck in patchwork:
https://patchwork.dpdk.org/patch/74960/
These patches look good for me. Will these be applied?
I'm not sure what to do next. If these will be applied, I need modified
the code.
On 2020/9/19 6:11, Stephen Hemminger wrote:
> On Mon, 7 Sep 2020 17:14:48 +0800
> Chengchang Tang <tangchengchang@huawei.com> wrote:
>
>> On 2020/9/6 0:59, Stephen Hemminger wrote:
>>> On Sat, 5 Sep 2020 17:07:32 +0800
>>> Chengchang Tang <tangchengchang@huawei.com> wrote:
>>>
>>>> printf("\t -- queue %d rx scatter %d"
>>>> " descriptors %d"
>>>> + " rx buffer size %d"
>>>> " offloads 0x%"PRIx64
>>>> " mempool socket %d\n",
>>>> j,
>>>> queue_info.scattered_rx,
>>>> queue_info.nb_desc,
>>>> + queue_info.rx_buf_size,
>>>> queue_info.conf.offloads,
>>>> queue_info.mp->socket_id);
>>>> }
>>>
>>> These should be using %u and need space after " for PRIx64
>>> Why not:
>>> printf("\t -- queue %u rx scatter %u"
>>> " descriptors %u"
>>> " rx buffer size %u"
>>> " offloads %#" PRIx64
>>> " mempool socket %d\n",
>>>
>>
>> OK, I will fix these in next version.
>>
>> Thanks
>
> NAK, these is superseded by.
>
> Please look at the new improved procinfo still stuck in patchwork
> https://patchwork.dpdk.org/patch/74960/
>
> Let's put the buffer size there.
>
> .
>
On 9/21/2020 3:06 AM, Chengchang Tang wrote:
> Hi, All
> These Patches improved procinfo was stuck in patchwork:
> https://patchwork.dpdk.org/patch/74960/
>
> These patches look good for me. Will these be applied?
>
> I'm not sure what to do next. If these will be applied, I need modified
> the code.
Hi Chengchang,
I suggest don't hold your patches and send your next version on top of
latest head of git repo, based on which patch applied first we can
resolve the conflict accordingly.
@@ -711,11 +711,13 @@ show_port(void)
if (ret == 0) {
printf("\t -- queue %d rx scatter %d"
" descriptors %d"
+ " rx buffer size %d"
" offloads 0x%"PRIx64
" mempool socket %d\n",
j,
queue_info.scattered_rx,
queue_info.nb_desc,
+ queue_info.rx_buf_size,
queue_info.conf.offloads,
queue_info.mp->socket_id);
}