[v2] eal/vfio: reduce severity of startup messages
Checks
Commit Message
The startup of VFIO is too noisy. Logging is expensive on some
systems, and distracting to the user.
It should not be logging at NOTICE level, reduce it to INFO level.
It really should be DEBUG here but that would hide it by default.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - add one more place
lib/librte_eal/linux/eal_vfio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On 12-Jun-20 1:10 AM, Stephen Hemminger wrote:
> The startup of VFIO is too noisy. Logging is expensive on some
> systems, and distracting to the user.
>
> It should not be logging at NOTICE level, reduce it to INFO level.
> It really should be DEBUG here but that would hide it by default.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
No objections. They're important for trouble-shooting, but we can always
use --log-level in that case.
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
On Fri, Jun 12, 2020 at 11:07 AM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 12-Jun-20 1:10 AM, Stephen Hemminger wrote:
> > The startup of VFIO is too noisy. Logging is expensive on some
> > systems, and distracting to the user.
> >
> > It should not be logging at NOTICE level, reduce it to INFO level.
> > It really should be DEBUG here but that would hide it by default.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks.
@@ -891,7 +891,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
/* we have successfully initialized VFIO, notify user */
const struct vfio_iommu_type *t =
default_vfio_cfg->vfio_iommu_type;
- RTE_LOG(NOTICE, EAL, " using IOMMU type %d (%s)\n",
+ RTE_LOG(INFO, EAL, " using IOMMU type %d (%s)\n",
t->type_id, t->name);
}
@@ -1069,7 +1069,7 @@ rte_vfio_enable(const char *modname)
/* check if we have VFIO driver enabled */
if (default_vfio_cfg->vfio_container_fd != -1) {
- RTE_LOG(NOTICE, EAL, "VFIO support initialized\n");
+ RTE_LOG(INFO, EAL, "VFIO support initialized\n");
default_vfio_cfg->vfio_enabled = 1;
} else {
RTE_LOG(NOTICE, EAL, "VFIO support could not be initialized\n");
@@ -1145,7 +1145,7 @@ vfio_set_iommu_type(int vfio_container_fd)
int ret = ioctl(vfio_container_fd, VFIO_SET_IOMMU,
t->type_id);
if (!ret) {
- RTE_LOG(NOTICE, EAL, " using IOMMU type %d (%s)\n",
+ RTE_LOG(INFO, EAL, " using IOMMU type %d (%s)\n",
t->type_id, t->name);
return t;
}