diff mbox series

mempool/octeontx: fix error handling in initialization

Message ID 20191219104434.32578-1-kkanas@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series mempool/octeontx: fix error handling in initialization |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK

Commit Message

Krzysztof Kanas Dec. 19, 2019, 10:44 a.m. UTC 
  From: Krzysztof Kanas <kkanas@marvell.com>

When octeontx_get_fpavf fails fpa pointer is used to get
pool_stack_base, which is then freed.

Coverity issue: 351263

Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation")
Cc: pbhagavatula@marvell.com

Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
---
 drivers/mempool/octeontx/octeontx_fpavf.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Jerin Jacob Jan. 14, 2020, 7:02 a.m. UTC | #1 
On Thu, Dec 19, 2019 at 4:14 PM <kkanas@marvell.com> wrote:
>
> From: Krzysztof Kanas <kkanas@marvell.com>
>
> When octeontx_get_fpavf fails fpa pointer is used to get
> pool_stack_base, which is then freed.
>
> Coverity issue: 351263
>
> Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation")
> Cc: pbhagavatula@marvell.com

Cc: stable@dpdk.org

> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index c97267db3cc3..63f8fb3b500a 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -305,10 +305,8 @@ octeontx_fpapf_pool_destroy(unsigned int gpool_index)
>         int ret = -1;
>
>         fpa = octeontx_get_fpavf(gpool_index);
> -       if (fpa == NULL) {
> -               ret = -EINVAL;
> -               goto err;
> -       }
> +       if (fpa == NULL)
> +               return -EINVAL;
>
>         hdr.coproc = FPA_COPROC;
>         hdr.msg = FPA_CONFIGSET;
> --
> 2.21.0
>
diff mbox series

Patch

diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index c97267db3cc3..63f8fb3b500a 100644
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -305,10 +305,8 @@  octeontx_fpapf_pool_destroy(unsigned int gpool_index)
 	int ret = -1;
 
 	fpa = octeontx_get_fpavf(gpool_index);
-	if (fpa == NULL) {
-		ret = -EINVAL;
-		goto err;
-	}
+	if (fpa == NULL)
+		return -EINVAL;
 
 	hdr.coproc = FPA_COPROC;
 	hdr.msg = FPA_CONFIGSET;