Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93566/?format=api
{ "id": 93566, "url": "http://patches.dpdk.org/api/patches/93566/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210530085929.29695-18-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210530085929.29695-18-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210530085929.29695-18-venkatkumar.duvvuru@broadcom.com", "date": "2021-05-30T08:58:48", "name": "[17/58] net/bnxt: modify resource reservation strategy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "881bd399a24054905dbc8a5fbb91d03d8a33cfed", "submitter": { "id": 1635, "url": "http://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210530085929.29695-18-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 17161, "url": "http://patches.dpdk.org/api/series/17161/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17161", "date": "2021-05-30T08:58:31", "name": "enhancements to host based flow table management", "version": 1, "mbox": "http://patches.dpdk.org/series/17161/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93566/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F5CCA0524;\n\tSun, 30 May 2021 11:03:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 09C084114C;\n\tSun, 30 May 2021 11:00:58 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.11.229]) by mails.dpdk.org (Postfix) with ESMTP id 9BB7B41173\n for <dev@dpdk.org>; Sun, 30 May 2021 11:00:55 +0200 (CEST)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 071DB7DC2;\n Sun, 30 May 2021 02:00:53 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 071DB7DC2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1622365255;\n bh=uA2O/P0U+PSYH8+GGRx1EjFi2LVS9aT5spICAk4FVfs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=u0Awy55ZD7THGQ7xh3fGSyzWe4Jw4cvWEQAYvQfuDiNrBo7z5MWdqIQFj9oeKniMr\n 4/igqFBLKSQoWEid9V+i7xWkbYZfmnTm3lJn1teWK8S7bAgx2i7nRGySX2lAoyMlmt\n ahblXZ847T2V2Gor9qraBy1rdkTZHoBGj3qC68yM=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Jay Ding <jay.ding@broadcom.com>,\n Randy Schacher <stuart.schacher@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Sun, 30 May 2021 14:28:48 +0530", "Message-Id": "<20210530085929.29695-18-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210530085929.29695-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20210530085929.29695-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 17/58] net/bnxt: modify resource reservation\n strategy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jay Ding <jay.ding@broadcom.com>\n\nAllow an application to only reserve resources for one direction.\n\nSigned-off-by: Jay Ding <jay.ding@broadcom.com>\nSigned-off-by: Randy Schacher <stuart.schacher@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\n---\n drivers/net/bnxt/tf_core/tf_core.c | 4 --\n drivers/net/bnxt/tf_core/tf_em_common.c | 61 +++++++++++------------\n drivers/net/bnxt/tf_core/tf_em_internal.c | 13 +++--\n drivers/net/bnxt/tf_core/tf_identifier.c | 15 +++---\n drivers/net/bnxt/tf_core/tf_tbl.c | 12 +++--\n drivers/net/bnxt/tf_core/tf_tcam.c | 14 ++++--\n 6 files changed, 65 insertions(+), 54 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/tf_core.c b/drivers/net/bnxt/tf_core/tf_core.c\nindex 945e54bfdd..de2a93646f 100644\n--- a/drivers/net/bnxt/tf_core/tf_core.c\n+++ b/drivers/net/bnxt/tf_core/tf_core.c\n@@ -1636,7 +1636,6 @@ int tf_get_session_info(struct tf *tfp,\n \t\tTFP_DRV_LOG(ERR,\n \t\t\t \"Ident get resc info failed, rc:%s\\n\",\n \t\t\t strerror(-rc));\n-\t\treturn rc;\n \t}\n \n \tif (dev->ops->tf_dev_get_tbl_resc_info == NULL) {\n@@ -1652,7 +1651,6 @@ int tf_get_session_info(struct tf *tfp,\n \t\tTFP_DRV_LOG(ERR,\n \t\t\t \"Tbl get resc info failed, rc:%s\\n\",\n \t\t\t strerror(-rc));\n-\t\treturn rc;\n \t}\n \n \tif (dev->ops->tf_dev_get_tcam_resc_info == NULL) {\n@@ -1668,7 +1666,6 @@ int tf_get_session_info(struct tf *tfp,\n \t\tTFP_DRV_LOG(ERR,\n \t\t\t \"TCAM get resc info failed, rc:%s\\n\",\n \t\t\t strerror(-rc));\n-\t\treturn rc;\n \t}\n \n \tif (dev->ops->tf_dev_get_em_resc_info == NULL) {\n@@ -1684,7 +1681,6 @@ int tf_get_session_info(struct tf *tfp,\n \t\tTFP_DRV_LOG(ERR,\n \t\t\t \"EM get resc info failed, rc:%s\\n\",\n \t\t\t strerror(-rc));\n-\t\treturn rc;\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c\nindex ed8f6db58c..812ccb0d29 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_common.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_common.c\n@@ -301,6 +301,7 @@ tf_em_page_tbl_pgcnt(uint32_t num_pages,\n {\n \treturn roundup(num_pages, MAX_PAGE_PTRS(page_size)) /\n \t\t MAX_PAGE_PTRS(page_size);\n+\treturn 0;\n }\n \n /**\n@@ -722,10 +723,6 @@ tf_insert_eem_entry(struct tf_dev_info *dev,\n \tif (!mask)\n \t\treturn -EINVAL;\n \n-#ifdef TF_EEM_DEBUG\n-\tdump_raw((uint8_t *)parms->key, TF_P4_HW_EM_KEY_MAX_SIZE + 4, \"In Key\");\n-#endif\n-\n \tif (dev->ops->tf_dev_cfa_key_hash == NULL)\n \t\treturn -EINVAL;\n \n@@ -737,10 +734,6 @@ tf_insert_eem_entry(struct tf_dev_info *dev,\n \tkey0_index = key0_hash & mask;\n \tkey1_index = key1_hash & mask;\n \n-#ifdef TF_EEM_DEBUG\n-\tTFP_DRV_LOG(DEBUG, \"Key0 hash:0x%08x\\n\", key0_hash);\n-\tTFP_DRV_LOG(DEBUG, \"Key1 hash:0x%08x\\n\", key1_hash);\n-#endif\n \t/*\n \t * Use the \"result\" arg to populate all of the key entry then\n \t * store the byte swapped \"raw\" entry in a local copy ready\n@@ -1010,35 +1003,41 @@ tf_em_ext_common_unbind(struct tf *tfp)\n \t}\n \text_db = (struct em_ext_db *)ext_ptr;\n \n-\tentry = ext_db->tbl_scope_ll.head;\n-\twhile (entry != NULL) {\n-\t\ttbl_scope_cb = (struct tf_tbl_scope_cb *)entry;\n-\t\tentry = entry->next;\n-\t\ttparms.tbl_scope_id = tbl_scope_cb->tbl_scope_id;\n-\n-\t\tif (dev->ops->tf_dev_free_tbl_scope) {\n-\t\t\tdev->ops->tf_dev_free_tbl_scope(tfp, &tparms);\n-\t\t} else {\n-\t\t\t/* should not reach here */\n-\t\t\tll_delete(&ext_db->tbl_scope_ll, &tbl_scope_cb->ll_entry);\n-\t\t\ttfp_free(tbl_scope_cb);\n+\tif (ext_db != NULL) {\n+\t\tentry = ext_db->tbl_scope_ll.head;\n+\t\twhile (entry != NULL) {\n+\t\t\ttbl_scope_cb = (struct tf_tbl_scope_cb *)entry;\n+\t\t\tentry = entry->next;\n+\t\t\ttparms.tbl_scope_id =\n+\t\t\t\ttbl_scope_cb->tbl_scope_id;\n+\n+\t\t\tif (dev->ops->tf_dev_free_tbl_scope) {\n+\t\t\t\tdev->ops->tf_dev_free_tbl_scope(tfp,\n+\t\t\t\t\t\t\t\t&tparms);\n+\t\t\t} else {\n+\t\t\t\t/* should not reach here */\n+\t\t\t\tll_delete(&ext_db->tbl_scope_ll,\n+\t\t\t\t\t &tbl_scope_cb->ll_entry);\n+\t\t\t\ttfp_free(tbl_scope_cb);\n+\t\t\t}\n \t\t}\n-\t}\n \n-\tfor (i = 0; i < TF_DIR_MAX; i++) {\n-\t\tif (ext_db->eem_db[i] == NULL)\n-\t\t\tcontinue;\n+\t\tfor (i = 0; i < TF_DIR_MAX; i++) {\n+\t\t\tif (ext_db->eem_db[i] == NULL)\n+\t\t\t\tcontinue;\n \n-\t\tfparms.dir = i;\n-\t\tfparms.rm_db = ext_db->eem_db[i];\n-\t\trc = tf_rm_free_db(tfp, &fparms);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\t\t\tfparms.dir = i;\n+\t\t\tfparms.rm_db = ext_db->eem_db[i];\n+\t\t\trc = tf_rm_free_db(tfp, &fparms);\n+\t\t\tif (rc)\n+\t\t\t\treturn rc;\n \n-\t\text_db->eem_db[i] = NULL;\n+\t\t\text_db->eem_db[i] = NULL;\n+\t\t}\n+\n+\t\ttfp_free(ext_db);\n \t}\n \n-\ttfp_free(ext_db);\n \ttf_session_set_em_ext_db(tfp, NULL);\n \n \treturn 0;\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_internal.c b/drivers/net/bnxt/tf_core/tf_em_internal.c\nindex 3b1e4e385d..93de513989 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_internal.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_internal.c\n@@ -349,6 +349,7 @@ tf_em_int_bind(struct tf *tfp,\n \t struct tf_em_cfg_parms *parms)\n {\n \tint rc;\n+\tint db_rc[TF_DIR_MAX] = { 0 };\n \tint i;\n \tstruct tf_rm_create_db_parms db_cfg = { 0 };\n \tstruct tf_rm_get_alloc_info_parms iparms;\n@@ -408,18 +409,22 @@ tf_em_int_bind(struct tf *tfp,\n \t\tdb_cfg.rm_db = (void *)&em_db->em_db[i];\n \t\tif (tf_session_is_shared_session(tfs) &&\n \t\t\t(!tf_session_is_shared_session_creator(tfs)))\n-\t\t\trc = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n+\t\t\tdb_rc[i] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n-\t\t\trc = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (rc) {\n+\t\t\tdb_rc[i] = tf_rm_create_db(tfp, &db_cfg);\n+\t\tif (db_rc[i]) {\n \t\t\tTFP_DRV_LOG(ERR,\n \t\t\t\t \"%s: EM Int DB creation failed\\n\",\n \t\t\t\t tf_dir_2_str(i));\n \n-\t\t\treturn rc;\n \t\t}\n \t}\n \n+\t/* No db created */\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\t\treturn db_rc[TF_DIR_RX];\n+\n+\n \tif (!tf_session_is_shared_session(tfs)) {\n \t\tfor (i = 0; i < TF_DIR_MAX; i++) {\n \t\t\tiparms.rm_db = em_db->em_db[i];\ndiff --git a/drivers/net/bnxt/tf_core/tf_identifier.c b/drivers/net/bnxt/tf_core/tf_identifier.c\nindex ebb975562d..3cc87de4ef 100644\n--- a/drivers/net/bnxt/tf_core/tf_identifier.c\n+++ b/drivers/net/bnxt/tf_core/tf_identifier.c\n@@ -30,6 +30,7 @@ tf_ident_bind(struct tf *tfp,\n \t struct tf_ident_cfg_parms *parms)\n {\n \tint rc;\n+\tint db_rc[TF_DIR_MAX] = { 0 };\n \tint i;\n \tstruct tf_rm_create_db_parms db_cfg = { 0 };\n \tstruct tf_shadow_ident_cfg_parms shadow_cfg = { 0 };\n@@ -70,15 +71,13 @@ tf_ident_bind(struct tf *tfp,\n \t\tdb_cfg.alloc_cnt = parms->resources->ident_cnt[i].cnt;\n \t\tif (tf_session_is_shared_session(tfs) &&\n \t\t\t(!tf_session_is_shared_session_creator(tfs)))\n-\t\t\trc = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n+\t\t\tdb_rc[i] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n-\t\t\trc = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (rc) {\n-\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\tdb_rc[i] = tf_rm_create_db(tfp, &db_cfg);\n+\t\tif (db_rc[i]) {\n+\t\t\tTFP_DRV_LOG(INFO,\n \t\t\t\t \"%s: Identifier DB creation failed\\n\",\n \t\t\t\t tf_dir_2_str(i));\n-\n-\t\t\treturn rc;\n \t\t}\n \n \t\tif (parms->shadow_copy) {\n@@ -99,6 +98,10 @@ tf_ident_bind(struct tf *tfp,\n \t\t}\n \t}\n \n+\t/* No db created */\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\t\treturn db_rc[TF_DIR_RX];\n+\n \tTFP_DRV_LOG(INFO,\n \t\t \"Identifier - initialized\\n\");\n \ndiff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c\nindex ca1aef8ebf..192115183b 100644\n--- a/drivers/net/bnxt/tf_core/tf_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_tbl.c\n@@ -41,6 +41,7 @@ tf_tbl_bind(struct tf *tfp,\n \t struct tf_tbl_cfg_parms *parms)\n {\n \tint rc, d, i;\n+\tint db_rc[TF_DIR_MAX] = { 0 };\n \tstruct tf_rm_create_db_parms db_cfg = { 0 };\n \tstruct tbl_rm_db *tbl_db;\n \tstruct tfp_calloc_parms cparms;\n@@ -79,18 +80,21 @@ tf_tbl_bind(struct tf *tfp,\n \t\tdb_cfg.rm_db = (void *)&tbl_db->tbl_db[d];\n \t\tif (tf_session_is_shared_session(tfs) &&\n \t\t\t(!tf_session_is_shared_session_creator(tfs)))\n-\t\t\trc = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n+\t\t\tdb_rc[d] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n-\t\t\trc = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (rc) {\n+\t\t\tdb_rc[d] = tf_rm_create_db(tfp, &db_cfg);\n+\t\tif (db_rc[d]) {\n \t\t\tTFP_DRV_LOG(ERR,\n \t\t\t\t \"%s: Table DB creation failed\\n\",\n \t\t\t\t tf_dir_2_str(d));\n \n-\t\t\treturn rc;\n \t\t}\n \t}\n \n+\t/* No db created */\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\t\treturn db_rc[TF_DIR_RX];\n+\n \tTFP_DRV_LOG(INFO,\n \t\t \"Table Type - initialized\\n\");\n \ndiff --git a/drivers/net/bnxt/tf_core/tf_tcam.c b/drivers/net/bnxt/tf_core/tf_tcam.c\nindex 0f05af87f1..ce959e3923 100644\n--- a/drivers/net/bnxt/tf_core/tf_tcam.c\n+++ b/drivers/net/bnxt/tf_core/tf_tcam.c\n@@ -33,6 +33,7 @@ tf_tcam_bind(struct tf *tfp,\n \t struct tf_tcam_cfg_parms *parms)\n {\n \tint rc;\n+\tint db_rc[TF_DIR_MAX] = { 0 };\n \tint i, d;\n \tstruct tf_rm_alloc_info info;\n \tstruct tf_rm_free_db_parms fparms;\n@@ -109,17 +110,20 @@ tf_tcam_bind(struct tf *tfp,\n \t\tdb_cfg.rm_db = (void *)&tcam_db->tcam_db[d];\n \t\tif (tf_session_is_shared_session(tfs) &&\n \t\t\t(!tf_session_is_shared_session_creator(tfs)))\n-\t\t\trc = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n+\t\t\tdb_rc[d] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n-\t\t\trc = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (rc) {\n-\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\tdb_rc[d] = tf_rm_create_db(tfp, &db_cfg);\n+\t\tif (db_rc[d]) {\n+\t\t\tTFP_DRV_LOG(INFO,\n \t\t\t\t \"%s: TCAM DB creation failed\\n\",\n \t\t\t\t tf_dir_2_str(d));\n-\t\t\treturn rc;\n \t\t}\n \t}\n \n+\t/* No db created */\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\t\treturn db_rc[TF_DIR_RX];\n+\n \t/* check if reserved resource for WC is multiple of num_slices */\n \tfor (d = 0; d < TF_DIR_MAX; d++) {\n \t\tmemset(&info, 0, sizeof(info));\n", "prefixes": [ "17/58" ] }