Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92148/?format=api
{ "id": 92148, "url": "http://patches.dpdk.org/api/patches/92148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210426060755.12821-2-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210426060755.12821-2-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210426060755.12821-2-somnath.kotur@broadcom.com", "date": "2021-04-26T06:07:55", "name": "[2/2] net/bnxt: fix Rx FIFO pending bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e35311047c622b892435f43d3adb0f7067e7a2dc", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210426060755.12821-2-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 16665, "url": "http://patches.dpdk.org/api/series/16665/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16665", "date": "2021-04-26T06:07:54", "name": "[1/2] net/bnxt: refactor multi queue Rx configuration", "version": 1, "mbox": "http://patches.dpdk.org/series/16665/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92148/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92148/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49ED4A0548;\n\tMon, 26 Apr 2021 08:09:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21ED641186;\n\tMon, 26 Apr 2021 08:09:47 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.11.229])\n by mails.dpdk.org (Postfix) with ESMTP id 6713B41185;\n Mon, 26 Apr 2021 08:09:45 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 8786E53D35;\n Sun, 25 Apr 2021 23:09:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 8786E53D35", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1619417384;\n bh=rP7v1E/gNXH95veneuH/oTChdRRe4FuMwig6vVnmq00=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ehfthp9Q7nuxtwxDHR5QfbsnMfk/QEdoKEyyXCLqWglPc2pS03liUX7e1PgDE+fSe\n Q1ZXFZFNlm5MKP+g2hb6+Yb+A4+GiWTFtq7t8sSUOEm+u7MAGkczAsbOi2CzaSPBiz\n xaPNiMsrN/yvNmSriZeH3FlnWqYNMh6vb9pHT5Eo=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n stable@dpdk.org, Ajit Khaparde <ajit.khaparde@broadcom.com>", "Date": "Mon, 26 Apr 2021 11:37:55 +0530", "Message-Id": "<20210426060755.12821-2-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "In-Reply-To": "<20210426060755.12821-1-somnath.kotur@broadcom.com>", "References": "<20210426060755.12821-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/bnxt: fix Rx FIFO pending bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix to clear the Rx FIFO while reading the timestamp.\nIf the Rx FIFO has pending bit set, keep reading to clear it\nand return the last valid timestamp instead of unconditionally\nreturning an error.\n\nFixes: b11cceb83a34 (\"net/bnxt: support timesync\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 38 ++++++++++++++++++++++++++++++----\n 2 files changed, 35 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex dfdfa9f7a0..8f3ae41911 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -306,6 +306,7 @@ struct rte_flow {\n \tstruct bnxt_vnic_info\t*vnic;\n };\n \n+#define BNXT_PTP_RX_PND_CNT\t\t10\n #define BNXT_PTP_FLAGS_PATH_TX\t\t0x0\n #define BNXT_PTP_FLAGS_PATH_RX\t\t0x1\n #define BNXT_PTP_FLAGS_CURRENT_TIME\t0x2\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex f5d2dc8590..eb81bf3991 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3388,6 +3388,38 @@ static int bnxt_get_tx_ts(struct bnxt *bp, uint64_t *ts)\n \treturn 0;\n }\n \n+static int bnxt_clr_rx_ts(struct bnxt *bp, uint64_t *last_ts)\n+{\n+\tstruct bnxt_ptp_cfg *ptp = bp->ptp_cfg;\n+\tstruct bnxt_pf_info *pf = bp->pf;\n+\tuint16_t port_id;\n+\tint i = 0;\n+\tuint32_t fifo;\n+\n+\tif (!ptp || (bp->flags & BNXT_FLAG_CHIP_P5))\n+\t\treturn -EINVAL;\n+\n+\tport_id = pf->port_id;\n+\tfifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n+\t\t\t\tptp->rx_mapped_regs[BNXT_PTP_RX_FIFO]));\n+\twhile ((fifo & BNXT_PTP_RX_FIFO_PENDING) && (i < BNXT_PTP_RX_PND_CNT)) {\n+\t\trte_write32(1 << port_id, (uint8_t *)bp->bar0 +\n+\t\t\t ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO_ADV]);\n+\t\tfifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n+\t\t\t\t\tptp->rx_mapped_regs[BNXT_PTP_RX_FIFO]));\n+\t\t*last_ts = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n+\t\t\t\t\tptp->rx_mapped_regs[BNXT_PTP_RX_TS_L]));\n+\t\t*last_ts |= (uint64_t)rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n+\t\t\t\t\tptp->rx_mapped_regs[BNXT_PTP_RX_TS_H])) << 32;\n+\t\ti++;\n+\t}\n+\n+\tif (i >= BNXT_PTP_RX_PND_CNT)\n+\t\treturn -EBUSY;\n+\n+\treturn 0;\n+}\n+\n static int bnxt_get_rx_ts(struct bnxt *bp, uint64_t *ts)\n {\n \tstruct bnxt_ptp_cfg *ptp = bp->ptp_cfg;\n@@ -3406,10 +3438,8 @@ static int bnxt_get_rx_ts(struct bnxt *bp, uint64_t *ts)\n \n \tfifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n \t\t\t\t ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO]));\n-\tif (fifo & BNXT_PTP_RX_FIFO_PENDING) {\n-/*\t\tbnxt_clr_rx_ts(bp);\t TBD */\n-\t\treturn -EBUSY;\n-\t}\n+\tif (fifo & BNXT_PTP_RX_FIFO_PENDING)\n+\t\treturn bnxt_clr_rx_ts(bp, ts);\n \n \t*ts = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 +\n \t\t\t\tptp->rx_mapped_regs[BNXT_PTP_RX_TS_L]));\n", "prefixes": [ "2/2" ] }