Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92124/?format=api
{ "id": 92124, "url": "http://patches.dpdk.org/api/patches/92124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210425092639.1428-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210425092639.1428-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210425092639.1428-1-alvinx.zhang@intel.com", "date": "2021-04-25T09:26:39", "name": "net/ice: fix txq mbuf release mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c773a48a13b046fb049d000f03ea64b5ffdd497a", "submitter": { "id": 1398, "url": "http://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210425092639.1428-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 16653, "url": "http://patches.dpdk.org/api/series/16653/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16653", "date": "2021-04-25T09:26:39", "name": "net/ice: fix txq mbuf release mode", "version": 1, "mbox": "http://patches.dpdk.org/series/16653/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92124/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92124/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3AB04A0548;\n\tSun, 25 Apr 2021 11:26:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1DEA04115E;\n\tSun, 25 Apr 2021 11:26:50 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 4252241143;\n Sun, 25 Apr 2021 11:26:48 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Apr 2021 02:26:47 -0700", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Apr 2021 02:26:44 -0700" ], "IronPort-SDR": [ "\n VAqEbG0Ctoh++Ikq7Aula1fheUHVZENAK9ZMNq3n7GPgrzLPPrPR3fkJ7Rp4VDnYqeNiHhqKoN\n 4hHMWzn+Pu3A==", "\n 9D/I+6Q31R1jBBNcaVVcbHc2oEIracU0/GP8X3XXC5Qw0k0UyPLkpoXLWnyom98TV53LOhoasE\n E/3MZUXjukVA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9964\"; a=\"193037906\"", "E=Sophos;i=\"5.82,250,1613462400\"; d=\"scan'208\";a=\"193037906\"", "E=Sophos;i=\"5.82,250,1613462400\"; d=\"scan'208\";a=\"464781638\"" ], "From": "Alvin Zhang <alvinx.zhang@intel.com>", "To": "qi.z.zhang@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Sun, 25 Apr 2021 17:26:39 +0800", "Message-Id": "<20210425092639.1428-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In some cases, it seems that the txq mbuf vector release mode\nis enabled first, and then it is confirmed that the conditions\nfor using the vector mode are not met.\n\nThis patch puts the txq vector mode startup process after the\ncondition detection.\n\nFixes: 28f9002ab67f (\"net/ice: add Tx AVX512 offload path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 92fbbc1..49abcb2 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -3303,13 +3303,6 @@\n \t\tif (tx_check_ret >= 0 &&\n \t\t rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {\n \t\t\tad->tx_vec_allowed = true;\n-\t\t\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\t\t\ttxq = dev->data->tx_queues[i];\n-\t\t\t\tif (txq && ice_txq_vec_setup(txq)) {\n-\t\t\t\t\tad->tx_vec_allowed = false;\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t}\n \n \t\t\tif (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512 &&\n \t\t\trte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&\n@@ -3329,6 +3322,15 @@\n \t\t\tif (!use_avx512 && tx_check_ret == ICE_VECTOR_OFFLOAD_PATH)\n \t\t\t\tad->tx_vec_allowed = false;\n \n+\t\t\tif (ad->tx_vec_allowed) {\n+\t\t\t\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\t\t\t\ttxq = dev->data->tx_queues[i];\n+\t\t\t\t\tif (txq && ice_txq_vec_setup(txq)) {\n+\t\t\t\t\t\tad->tx_vec_allowed = false;\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t}\n \t\t} else {\n \t\t\tad->tx_vec_allowed = false;\n \t\t}\n", "prefixes": [] }