Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77222/?format=api
{ "id": 77222, "url": "http://patches.dpdk.org/api/patches/77222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910193400.15326-3-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910193400.15326-3-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910193400.15326-3-i.dyukov@samsung.com", "date": "2020-09-10T19:33:35", "name": "[v10,02/24] ethdev: format a link status text", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "845af0fd3c3af6ca0b209e1492686a96a5ebacdc", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910193400.15326-3-i.dyukov@samsung.com/mbox/", "series": [ { "id": 12111, "url": "http://patches.dpdk.org/api/series/12111/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12111", "date": "2020-09-10T19:33:33", "name": "ethdev: allow unknown link speed", "version": 10, "mbox": "http://patches.dpdk.org/series/12111/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77222/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3482A04B5;\n\tThu, 10 Sep 2020 21:34:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AD501C0D0;\n\tThu, 10 Sep 2020 21:34:20 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3B2171C0CF\n for <dev@dpdk.org>; Thu, 10 Sep 2020 21:34:19 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200910193418euoutp02978d330f90fdbe080b8b56ac198021fe~zgx5Xg0SF0501005010euoutp02Q;\n Thu, 10 Sep 2020 19:34:18 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200910193418eucas1p2dc420133c9867ea1dc64373e306eac1d~zgx5DKPO72490124901eucas1p2k;\n Thu, 10 Sep 2020 19:34:18 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 76.0D.06456.ABF7A5F5; Thu, 10\n Sep 2020 20:34:18 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b~zgx4T0rAU2394823948eucas1p2j;\n Thu, 10 Sep 2020 19:34:17 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200910193417eusmtrp19eb0b4a7209d8e81ca6b55e1bebb86c5~zgx4S5GJ13165331653eusmtrp1t;\n Thu, 10 Sep 2020 19:34:17 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id F3.8A.06017.9BF7A5F5; Thu, 10\n Sep 2020 20:34:17 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200910193415eusmtip247250d85f75a8a1df35765d2b8f84d1e~zgx2gG2sT1532615326eusmtip2M;\n Thu, 10 Sep 2020 19:34:15 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200910193418euoutp02978d330f90fdbe080b8b56ac198021fe~zgx5Xg0SF0501005010euoutp02Q", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1599766459;\n bh=iZ2rhieyH+SHo++rrlWrL6I7iDEjuhhlRYa1cnWCSW8=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=WPVr4GJP2SY22da9XIpObTbjpqbfnyEphlnRh4K5mjmXTIwOf4Yt/ovBlAoTMHulw\n V9EUfNo1sUX63FDBPtVZP+2wqMf8IKzOnb3mcFb60IxF5kpEHpEmGk21qjY0Fen3e0\n LdGPmCWlBJSzV2uzTASSWd1BmucCLi2Z4l76D804=", "X-AuditID": "cbfec7f2-809ff70000001938-7d-5f5a7fbaf71d", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Thu, 10 Sep 2020 22:33:35 +0300", "Message-Id": "<20200910193400.15326-3-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200910193400.15326-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSe0wUVxTGe2ZmZ4YNa8aVhKMlqJsaq4kotUlPjVFpm3YSTVqN2oYEcZQJ\n YFmgO0CxSdvVVrQrpbxCK5gVJRbFB6DIIrKKtIK4rlu2GiVFRNLEQuUhsAkg2LoMTf8753e/\n 7zvn3lyRNRfyC8Tk1AzVlqqkWHgjV9864VvR+HVs/KqnxYuo+rYTqLe7gqWe4oc8HR7+lqEH\n VeupyXXUQIWP7AzlFT5jyHXKwdPTnv0cDY64GOpyewQq9e8XaKTliUDf+8qAnkz1s3SkfBTI\n 57xkoInrjTwNTZ3gKG/yHtAPdTeB2nKfcVR8uQEoxyHR8OlKgSq6Immk5yZHns6LAp0NdLB0\n 6fY0UEFbNZA35x/DhsXyZPlJg1zR1MfIRcc7WLm1s0SQc9udjFw72MDIQ1fv8XJeXRXIt3oP\n s/KZP8f5j4yxxrUJakpylmpbuW6nManoLy+T7t+Z/Vt3K2OHpg8dECKi9Ca6fj3OOMAomqVT\n gP72EtCbMcB9+ec4vRkFvGKvNDhAnLFce5il80rAUmcxBKPMUgDwxsSXwZqXXkfPIedMbJhU\n y6Nr6j4TNM+T1uLgH58ENZy0BDv6/VywNklv43iNy6CvtBDP1DSzQXmItAYfd8Xp8ZF4/9jY\n TCRKd0X0/F4m6Pr3sKvCPeudh/1tdbM8Aj1FuZxuOAhYUH9R0Jt8wG/KBmZV67Hu7ztCcBor\n LcPqxpU6jsGDY+2cfuE5+GBgbhCzL8vC+h9ZHZvwUI5ZV1uwud0/ixGnn4fqWMZfBsZZ/anc\n gC/2lTD5sLD0/1nlAFUQrmZq1kRVi05VP4/SFKuWmZoYtTvNegFe/lTPi7aRBgj4d7WAJIIl\n 1NS8JjbebFCytL3WFkCRtYSZ3vF6dphNCcreL1RbWrwtM0XVWuBVkbOEm1af6IszS4lKhvqp\n qqartv9OGTFkgR0ObNaS528RPx4tr3Vnx8W81ektmBuqdZrCX7E6hk0n3+3OiLm2ZOn8xyVR\n e+ThR+et208bHbuOPL/z/k+BvqM5dyMMX5ltkxsPeLe9tj2/1u5flMvNmV7uPhb+XU1Stit6\n KD0kkO5LWObfGhGRtiklbOMOxrfhZ2XVG0rBZ0u7P+hdF2nhtCQlejlr05R/AcJDkL6lAwAA", "\n H4sIAAAAAAAAAzWSa0hTcRjG+59zdjbFxWEZ/vGD1bLoOtvUfJWl1Yc6FXShopozXXpy0uZk\n Z7MMwQtSudJaRaDmskY3NbTUNLGL++ClKaVhVvOy1DArvFZU2GVD+vbwPL/n5YX3FZGSGSpQ\n lJJq4oypGp2U9qWcf1oH1j7KUsWve1e0Bqo6bAiGBuwkuC/303B2Mo+AN+Ux0FR/VQAXB7MJ\n KLw4RUD9HQsNX9y5FIxP1xPQ99gphOLuXCFMO0aFUPCiBMHo7CcSispmELyw1QngZ3MjDROz\n Nygo/NWD4HxtG4LWc1MUXH7UgOCUhYHJu7eFYO8Lgml3GwXOtzVCqPzWRUJdx28E1tYqBJ2n\n /go2LmF/ld0UsPamMYK9dL2LZFveXhGy59ptBHt/vIFgJ5700GxhbTlinw+dJdmKkR/0bl+V\n TGk0mE3cYq2BN22QxspBIZNHgkwRFimTh0bERSnCpSHRyiROl5LOGUOiE2TaSx87ibTuhBMv\n B1qIbNS0y4JEIsyE4af96RbkK5IwNxEezGsQzPkYfx4hLcjHIxfg2dcWeo6ZQbjCWiX0BjSz\n AjvP2Ahv4M+4aPzqdA7lLS9glHjcddDLUMwy3PWpm/JqMROJf1TXC+aGLsIV1c9IL+7DROH3\n fXFeW8KkYFvHd8GcDsK9174SF9D8MjSvHPlzZl6frOcVMl6j582pybJEg/4B8hz8YcvP2gZk\n Gd/rQIwISf3Ez6JU8RKBJp3P0DsQFpFSf/HmTudhiThJk3GSMxrijWYdxztQuGc/Kxm4MNHg\n eZ9UU7w8XB4BkfKI0IjQ9SANEJ9hmtUSJllj4o5xXBpn/N8jRD6B2UitOKi0uTJ3Jh7NVC68\n P3I8UWf/sLVsZVp+RmWlOSfp9lJdofZIrN+WvILSmMzP7SUv7wUHde6f5PuKrDWaTTvUKWP5\n qhhbsCtreJv6UHGd1Q3qxTpJiF8jUbO9tKfOnqBaXZ0V4L71ZtgXO5YfeNzk3remfE/g6tAr\n 2kaT406vlOK1Gvkq0shr/gGP1Ph2BgMAAA==" ], "X-CMS-MailID": "20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200910193400.15326-1-i.dyukov@samsung.com>\n <CGME20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v10 02/24] ethdev: format a link status text", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is new link_speed value introduced. It's INT_MAX value which\nmeans that speed is unknown. To simplify processing of the value\nin application, new function is added which convert link_speed to\nstring. Also dpdk examples have many duplicated code which format\nentire link status structure to text.\n\nThis commit adds two functions:\n * rte_eth_link_speed_to_str - format link_speed to string\n * rte_eth_link_to_str - convert link status structure to string\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n MAINTAINERS | 1 +\n app/test/Makefile | 3 +\n app/test/meson.build | 2 +\n app/test/test_ethdev_link.c | 169 +++++++++++++++++++++++\n lib/librte_ethdev/rte_ethdev.c | 53 +++++++\n lib/librte_ethdev/rte_ethdev.h | 32 +++++\n lib/librte_ethdev/rte_ethdev_version.map | 4 +\n 7 files changed, 264 insertions(+)\n create mode 100644 app/test/test_ethdev_link.c", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 5e706cd7e..f4fb31ea2 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net\n F: lib/librte_ethdev/\n F: devtools/test-null.sh\n F: doc/guides/prog_guide/switch_representation.rst\n+F: app/test/test_ethdev*\n \n Flow API\n M: Ori Kam <orika@mellanox.com>\ndiff --git a/app/test/Makefile b/app/test/Makefile\nindex e5440774b..9f43b8c3c 100644\n--- a/app/test/Makefile\n+++ b/app/test/Makefile\n@@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c\n \n SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c\n SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c\n+\n+SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c\n+\n ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)\n LDLIBS += -lrte_ipsec\n endif\ndiff --git a/app/test/meson.build b/app/test/meson.build\nindex 56591db4e..1e6acf701 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -39,6 +39,7 @@ test_sources = files('commands.c',\n \t'test_efd.c',\n \t'test_efd_perf.c',\n \t'test_errno.c',\n+\t'test_ethdev_link.c',\n \t'test_event_crypto_adapter.c',\n \t'test_event_eth_rx_adapter.c',\n \t'test_event_ring.c',\n@@ -199,6 +200,7 @@ fast_tests = [\n ['eal_flags_misc_autotest', false],\n ['eal_fs_autotest', true],\n ['errno_autotest', true],\n+ ['ethdev_link_status', true],\n ['event_ring_autotest', true],\n ['fib_autotest', true],\n ['fib6_autotest', true],\ndiff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c\nnew file mode 100644\nindex 000000000..1c6b0c9ed\n--- /dev/null\n+++ b/app/test/test_ethdev_link.c\n@@ -0,0 +1,169 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved\n+ */\n+\n+#include <rte_log.h>\n+#include <rte_ethdev.h>\n+\n+#include <rte_test.h>\n+#include \"test.h\"\n+\n+\n+static int32_t\n+test_link_status_up_default(void)\n+{\n+\tint ret = 0;\n+\tstruct rte_eth_link link_status = {\n+\t\t.link_speed = ETH_SPEED_NUM_2_5G,\n+\t\t.link_status = ETH_LINK_UP,\n+\t\t.link_autoneg = ETH_LINK_AUTONEG,\n+\t\t.link_duplex = ETH_LINK_FULL_DUPLEX\n+\t};\n+\tchar text[RTE_ETH_LINK_MAX_STR_LEN];\n+\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n+\tprintf(\"Default link up #1: %s\\n\", text);\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link up at 2.5 Gbps FDX Autoneg\",\n+\t\ttext, strlen(text), \"Invalid default link status string\");\n+\n+\tlink_status.link_duplex = ETH_LINK_HALF_DUPLEX;\n+\tlink_status.link_autoneg = ETH_LINK_FIXED;\n+\tlink_status.link_speed = ETH_SPEED_NUM_10M,\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tprintf(\"Default link up #2: %s\\n\", text);\n+\tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link up at 10 Mbps HDX Fixed\",\n+\t\ttext, strlen(text), \"Invalid default link status \"\n+\t\t\"string with HDX\");\n+\n+\tlink_status.link_speed = ETH_SPEED_NUM_UNKNOWN;\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tprintf(\"Default link up #3: %s\\n\", text);\n+\tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link up at Unknown HDX Fixed\",\n+\t\ttext, strlen(text), \"Invalid default link status \"\n+\t\t\"string with HDX\");\n+\n+\tlink_status.link_speed = ETH_SPEED_NUM_NONE;\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tprintf(\"Default link up #3: %s\\n\", text);\n+\tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link up at 0 Mbps HDX Fixed\",\n+\t\ttext, strlen(text), \"Invalid default link status \"\n+\t\t\"string with HDX\");\n+\n+\t/* test max str len */\n+\tlink_status.link_speed = ETH_SPEED_NUM_200G;\n+\tlink_status.link_duplex = ETH_LINK_HALF_DUPLEX;\n+\tlink_status.link_autoneg = ETH_LINK_AUTONEG;\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tprintf(\"Default link up #4:len = %d, %s\\n\", ret, text);\n+\tRTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN,\n+\t\t\"String length exceeds max allowed value\\n\");\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int32_t\n+test_link_status_down_default(void)\n+{\n+\tint ret = 0;\n+\tstruct rte_eth_link link_status = {\n+\t\t.link_speed = ETH_SPEED_NUM_2_5G,\n+\t\t.link_status = ETH_LINK_DOWN,\n+\t\t.link_autoneg = ETH_LINK_AUTONEG,\n+\t\t.link_duplex = ETH_LINK_FULL_DUPLEX\n+\t};\n+\tchar text[RTE_ETH_LINK_MAX_STR_LEN];\n+\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link down\",\n+\t\ttext, strlen(text), \"Invalid default link status string\");\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int32_t\n+test_link_status_invalid(void)\n+{\n+\tint ret = 0;\n+\tstruct rte_eth_link link_status = {\n+\t\t.link_speed = 55555,\n+\t\t.link_status = ETH_LINK_UP,\n+\t\t.link_autoneg = ETH_LINK_AUTONEG,\n+\t\t.link_duplex = ETH_LINK_FULL_DUPLEX\n+\t};\n+\tchar text[RTE_ETH_LINK_MAX_STR_LEN];\n+\n+\tret = rte_eth_link_to_str(text, sizeof(text), &link_status);\n+\tRTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN,\n+\t\t\"Failed to format invalid string\\n\");\n+\tprintf(\"invalid link up #1: len=%d %s\\n\", ret, text);\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\"Link up at Invalid speed FDX Autoneg\",\n+\t\ttext, strlen(text), \"Incorrect invalid link status string\");\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n+static int32_t\n+test_link_speed_all_values(void)\n+{\n+\tconst char *speed;\n+\tuint32_t i;\n+\tstruct link_speed_t {\n+\t\tconst char *value;\n+\t\tuint32_t link_speed;\n+\t} speed_str_map[] = {\n+\t\t{ \"0 Mbps\", ETH_SPEED_NUM_NONE },\n+\t\t{ \"10 Mbps\", ETH_SPEED_NUM_10M },\n+\t\t{ \"100 Mbps\", ETH_SPEED_NUM_100M },\n+\t\t{ \"1 Gbps\", ETH_SPEED_NUM_1G },\n+\t\t{ \"2.5 Gbps\", ETH_SPEED_NUM_2_5G },\n+\t\t{ \"5 Gbps\", ETH_SPEED_NUM_5G },\n+\t\t{ \"10 Gbps\", ETH_SPEED_NUM_10G },\n+\t\t{ \"20 Gbps\", ETH_SPEED_NUM_20G },\n+\t\t{ \"25 Gbps\", ETH_SPEED_NUM_25G },\n+\t\t{ \"40 Gbps\", ETH_SPEED_NUM_40G },\n+\t\t{ \"50 Gbps\", ETH_SPEED_NUM_50G },\n+\t\t{ \"56 Gbps\", ETH_SPEED_NUM_56G },\n+\t\t{ \"100 Gbps\", ETH_SPEED_NUM_100G },\n+\t\t{ \"200 Gbps\", ETH_SPEED_NUM_200G },\n+\t\t{ \"Unknown\", ETH_SPEED_NUM_UNKNOWN },\n+\t\t{ \"Invalid speed\", 50505 }\n+\t};\n+\n+\tfor (i = 0; i < sizeof(speed_str_map) / sizeof(struct link_speed_t);\n+\t\t\ti++) {\n+\t\tspeed = rte_eth_link_speed_to_str(speed_str_map[i].link_speed);\n+\t\tTEST_ASSERT_BUFFERS_ARE_EQUAL(speed_str_map[i].value,\n+\t\t\tspeed, strlen(speed_str_map[i].value),\n+\t\t\t\"Invalid link speed string\");\n+\t}\n+\treturn TEST_SUCCESS;\n+}\n+\n+static struct unit_test_suite link_status_testsuite = {\n+\t.suite_name = \"link status formatting\",\n+\t.setup = NULL,\n+\t.teardown = NULL,\n+\t.unit_test_cases = {\n+\t\tTEST_CASE(test_link_status_up_default),\n+\t\tTEST_CASE(test_link_status_down_default),\n+\t\tTEST_CASE(test_link_speed_all_values),\n+\t\tTEST_CASE(test_link_status_invalid),\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n+static int\n+test_link_status(void)\n+{\n+\trte_log_set_global_level(RTE_LOG_DEBUG);\n+\trte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG);\n+\n+\treturn unit_test_suite_runner(&link_status_testsuite);\n+}\n+\n+REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status);\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex d06b7f9b1..cb624b7b4 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -2383,6 +2383,59 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)\n \treturn 0;\n }\n \n+const char *\n+rte_eth_link_speed_to_str(uint32_t link_speed)\n+{\n+\tswitch (link_speed) {\n+\tcase ETH_SPEED_NUM_UNKNOWN:\n+\t\treturn \"Unknown\";\n+\tcase ETH_SPEED_NUM_NONE:\n+\t\treturn \"0 Mbps\";\n+\tcase ETH_SPEED_NUM_10M:\n+\t\treturn \"10 Mbps\";\n+\tcase ETH_SPEED_NUM_100M:\n+\t\treturn \"100 Mbps\";\n+\tcase ETH_SPEED_NUM_1G:\n+\t\treturn \"1 Gbps\";\n+\tcase ETH_SPEED_NUM_2_5G:\n+\t\treturn \"2.5 Gbps\";\n+\tcase ETH_SPEED_NUM_5G:\n+\t\treturn \"5 Gbps\";\n+\tcase ETH_SPEED_NUM_10G:\n+\t\treturn \"10 Gbps\";\n+\tcase ETH_SPEED_NUM_20G:\n+\t\treturn \"20 Gbps\";\n+\tcase ETH_SPEED_NUM_25G:\n+\t\treturn \"25 Gbps\";\n+\tcase ETH_SPEED_NUM_40G:\n+\t\treturn \"40 Gbps\";\n+\tcase ETH_SPEED_NUM_50G:\n+\t\treturn \"50 Gbps\";\n+\tcase ETH_SPEED_NUM_56G:\n+\t\treturn \"56 Gbps\";\n+\tcase ETH_SPEED_NUM_100G:\n+\t\treturn \"100 Gbps\";\n+\tcase ETH_SPEED_NUM_200G:\n+\t\treturn \"200 Gbps\";\n+\tdefault:\n+\t\treturn \"Invalid speed\";\n+\t}\n+}\n+\n+int\n+rte_eth_link_to_str(char *str, size_t len, const struct rte_eth_link *eth_link)\n+{\n+\tif (eth_link->link_status == ETH_LINK_DOWN)\n+\t\treturn snprintf(str, len, \"Link down\");\n+\telse\n+\t\treturn snprintf(str, len, \"Link up at %s %s %s\",\n+\t\t\trte_eth_link_speed_to_str(eth_link->link_speed),\n+\t\t\t(eth_link->link_duplex == ETH_LINK_FULL_DUPLEX) ?\n+\t\t\t\"FDX\" : \"HDX\",\n+\t\t\t(eth_link->link_autoneg == ETH_LINK_AUTONEG) ?\n+\t\t\t\"Autoneg\" : \"Fixed\");\n+}\n+\n int\n rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats)\n {\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 2090af501..a86f8f916 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -323,6 +323,7 @@ struct rte_eth_link {\n #define ETH_LINK_UP 1 /**< Link is up (see link_status). */\n #define ETH_LINK_FIXED 0 /**< No autonegotiation (see link_autoneg). */\n #define ETH_LINK_AUTONEG 1 /**< Autonegotiated (see link_autoneg). */\n+#define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */\n \n /**\n * A structure used to configure the ring threshold registers of an RX/TX\n@@ -2295,6 +2296,37 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link);\n */\n int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link);\n \n+/**\n+ * The function converts a link_speed to a string. It handles all special\n+ * values like unknown or none speed.\n+ * @param link_speed\n+ * link_speed of rte_eth_link struct\n+ * @return\n+ * Link speed in textual format. It's pointer to immutable memory.\n+ * No free is required.\n+ */\n+__rte_experimental\n+const char *rte_eth_link_speed_to_str(uint32_t speed_link);\n+\n+/**\n+ * The function converts a rte_eth_link struct representing a link status to\n+ * a string.\n+ * @param str\n+ * A pointer to a string to be filled with textual representation of\n+ * device status. At least ETH_LINK_MAX_STR_LEN bytes should be allocated to\n+ * store default link status text.\n+ * @param len\n+ * Length of available memory at 'str' string.\n+ * @param eth_link\n+ * Link status returned by rte_eth_link_get function\n+ * @return\n+ * - Number of bytes written to str array.\n+ *\n+ */\n+__rte_experimental\n+int rte_eth_link_to_str(char *str, size_t len,\n+\t\t\tconst struct rte_eth_link *eth_link);\n+\n /**\n * Retrieve the general I/O statistics of an Ethernet device.\n *\ndiff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map\nindex 715505604..69a763d4b 100644\n--- a/lib/librte_ethdev/rte_ethdev_version.map\n+++ b/lib/librte_ethdev/rte_ethdev_version.map\n@@ -241,4 +241,8 @@ EXPERIMENTAL {\n \t__rte_ethdev_trace_rx_burst;\n \t__rte_ethdev_trace_tx_burst;\n \trte_flow_get_aged_flows;\n+\n+\t# added in 20.11\n+\trte_eth_link_to_str;\n+\trte_eth_link_speed_to_str;\n };\n", "prefixes": [ "v10", "02/24" ] }