From patchwork Thu Sep 10 19:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77221 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07231A04B5; Thu, 10 Sep 2020 21:34:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFF421C0B9; Thu, 10 Sep 2020 21:34:17 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 33FC31BFC3 for ; Thu, 10 Sep 2020 21:34:16 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193415euoutp02b02b4863a8fb0cde566f1b530a5f09c9~zgx2Q09xa0500705007euoutp02S; Thu, 10 Sep 2020 19:34:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193415euoutp02b02b4863a8fb0cde566f1b530a5f09c9~zgx2Q09xa0500705007euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766455; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Bz/k5gy1I3m6J3Oj//9P2wvVH5pnpuGtmaMo7MlGTKOcdYG9uld0DymOiJaFk+7/p NOK6X8YFPn8MstfxI9x1eHP8vlFnXDtFKzXIX3dDs5SjqQbSJJOQF0DwEv8Hmk9Qbr udTeIVOO1JyHYf5CzpOecRuPsROTT3ol8Fk2cbLY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193414eucas1p10358368e5370bf22ea15df579c52ad1d~zgx1mwy872936129361eucas1p1Q; Thu, 10 Sep 2020 19:34:14 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id CE.32.06318.6BF7A5F5; Thu, 10 Sep 2020 20:34:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193414eucas1p1e8a7fcd9e119b1d68f1dec32338f4f12~zgx09Bj_q2935729357eucas1p1w; Thu, 10 Sep 2020 19:34:14 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193414eusmtrp1588eabde5f55183e81393d11ca3965dd~zgx08J-5H3165331653eusmtrp1s; Thu, 10 Sep 2020 19:34:14 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-16-5f5a7fb64074 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D1.8A.06017.6BF7A5F5; Thu, 10 Sep 2020 20:34:14 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193412eusmtip25df87e32c16a103c97b3767aa4630f23~zgxzOuwJ71532615326eusmtip2L; Thu, 10 Sep 2020 19:34:12 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:34 +0300 Message-Id: <20200910193400.15326-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0wUZxTtNzM7M2xcHVeMF0okbmKsNaLGR29pU60hZn7YRP1hCCmlo45g hQV3QYpJU2CbrS4PEcTHoriyNcpDEWEXfBFE64LrSsCgGLGsFoPQqoDQIA+pw9DUf/eec+49 5375eFrvYoP5XcZk2WSU4g2slnHfftuy1P1zVMzy649XYOXdYoLP/nDS6D/8hMWs/l8o7Chb i9dqT2gwvyudwtz8AQprz9lY/NufyeCrwVoKO697ObS3ZXI42NjDYU5LEcGe8T4ajzveEGwp dmnw7Y0rLL4eL2Ewd7Sd4MGaJoKe7AEGD1+uI2i1CdhfepZDZ+d8HPQ3Meh9VM1hxXArja67 EwQPeSoJ+qyTmnULxFHHGY3ovNZLiQWnW2nx9qMjnJjdXEyJVa/qKPF1fTsr5taUEfHOsyxa LO8eYTdpo7Rf7pDjd+2VTcu++l4bd96fzyXZg37syvVx6eS3QBsJ4EFYBU33M4iNaHm9cI5A 4Xk/pzZDBLyZhYzavCHgLH2hsRF+amTCE6lM64WzBDy+JFUzTODU2ElKIVjhE/DuL6YUIlCo YqF2/OEUMUf4AjwDGRqlZoSFcGCkgFWW6oTP4UL7XDVSKJRfbKAVOEAIh6ed0arXfHh4amhq i06YDc3Huxmlpt/LLa4iWrECYZKHE1X9nLonAhwlv7NqPQf6PDXTeAh4C7IZdeBXAofc1Zza 5BGwFL2cVq2Fmr/ucUoKWlgMlVeWqfDXcDGncPohZkLHy9lqiJmQ7z5Kq7AO9lv1qtoADc1t 0zDAxNgMFRbhzmgWl0cW2D+4xv7BNfb/bR2ELiPz5BRzQqxsXmmUU8PMUoI5xRgbtj0x4RJ5 /5m97zzDdaR+fFsjEXhimKFrCI+K0Wukvea0hEYCPG0I1K33eb/T63ZIaftkU2KMKSVeNjeS j3nGME+3sqQ3Wi/ESsnybllOkk3/sRQfEJxOWGf7no2Wn6xV1jWJ5fXbjJNBoRGfhb5bMubO nuUako4duPrD5ojoNaEP1tWHB9tynpZVpG2KdOW1dg8d7Wqy7GyT7jviGpIib3xz6fE/YVdb OkpvvujVLKdWl/SHVKRYepLrZkmLMpxnRrakBvlCIivb+lI/qvg2fSt9S+Kq/3y+fYOBMcdJ Kz6lTWbpX7LWVozIAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02Sf0yMcRzHfZ/nuee50m1PV/jqj+gxtMzlrnKfC/k12/OXmcyoyDMe1XR3 ds9lMqOwcBIqxsW5hPRD+VGKpXF/uMuVH1nURMfaGlEqLJYf92jGf++936/Pe/tsbyWpvq0I U2aYrKLFJGRydCDl/el+PffW3qTUeU5PENS2OhC8fV1Ggq/4FQ1HPh0goLNyMTQ1nFVAYU8O AQWFQwQ0XLHR8MG3j4KB4QYCuu96GbC372Ng2NXHwNHHJQj6xt6TcMY5guCxo14B3+7foWFw 7AIFBd87EByr8yBw5w9RUHy7EUGejYVPFeUMlHWHw7DPQ4G36yYD1V+eklDf+gPBCXctgra8 X4olEfx35yUFX9b0juCLSp+S/IOuUwyf3+Ig+OsDjQQ/2NxB8wV1lYh/+PYIyVf1jtKrApM0 Cy3mLKs4Pd0sWRdxyVrQabQG0OhiDRptjH5DvC6Oi05YuEXMzNghWqITNmnSr/oKme32qTt7 CtqYHHQx1IaUSszG4h/udTYUqFSzlxA+77Qz4z7G/b2kDQX4ZQgee26jx5kRhMscrZQc0Gwk 9h5yEHIQyr6k8bODuX+CEHYBdg/lKmRNsTPx4dEiWi5VsQZc0zFpvHQarrp2j5TtADYev+ne INtqNgM7Wr8qxnU4fnH+MyFrFRuMW870UjJOsrNxrUMt26S/ZX99CXkcBdv/o+z/KPt/lBOR lShUzJKMaUZJp5EEo5RlStNsNhtvIP9sbj34VteIbAOJLsQqERekuheflKpWCDukbKMLYSXJ haqWtXk3qlVbhOxdosWcasnKFCUXivM/eYIMm7TZ7B+hyZqqjdPqwaDVx+hj5gM3RXWIvZ+i ZtMEq7hNFLeLlr93hDIgLAd5wum1g6sb1688HPKxVwgKCOyiij7U9PU3o/CJgjC6Z3fkMdKT nZ9erxlYt3wCW1Nqm5Pb3jl5TelBkws3c9UzIvK2pUU8WrvJ7ct/kljefrOipqnl4jx1xtnO rYbi/pUnFw2djvq58+S5nlmS7uXI0ei4lNq7l2O5Sn3CCv3S5IkcJaUL2ijSIgm/AWeF0YdM AwAA X-CMS-MailID: 20200910193414eucas1p1e8a7fcd9e119b1d68f1dec32338f4f12 X-Msg-Generator: CA X-RootMTR: 20200910193414eucas1p1e8a7fcd9e119b1d68f1dec32338f4f12 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193414eucas1p1e8a7fcd9e119b1d68f1dec32338f4f12 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 01/24] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Thu Sep 10 19:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77222 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3482A04B5; Thu, 10 Sep 2020 21:34:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AD501C0D0; Thu, 10 Sep 2020 21:34:20 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3B2171C0CF for ; Thu, 10 Sep 2020 21:34:19 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193418euoutp02978d330f90fdbe080b8b56ac198021fe~zgx5Xg0SF0501005010euoutp02Q; Thu, 10 Sep 2020 19:34:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193418euoutp02978d330f90fdbe080b8b56ac198021fe~zgx5Xg0SF0501005010euoutp02Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766459; bh=iZ2rhieyH+SHo++rrlWrL6I7iDEjuhhlRYa1cnWCSW8=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=WPVr4GJP2SY22da9XIpObTbjpqbfnyEphlnRh4K5mjmXTIwOf4Yt/ovBlAoTMHulw V9EUfNo1sUX63FDBPtVZP+2wqMf8IKzOnb3mcFb60IxF5kpEHpEmGk21qjY0Fen3e0 LdGPmCWlBJSzV2uzTASSWd1BmucCLi2Z4l76D804= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193418eucas1p2dc420133c9867ea1dc64373e306eac1d~zgx5DKPO72490124901eucas1p2k; Thu, 10 Sep 2020 19:34:18 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 76.0D.06456.ABF7A5F5; Thu, 10 Sep 2020 20:34:18 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b~zgx4T0rAU2394823948eucas1p2j; Thu, 10 Sep 2020 19:34:17 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193417eusmtrp19eb0b4a7209d8e81ca6b55e1bebb86c5~zgx4S5GJ13165331653eusmtrp1t; Thu, 10 Sep 2020 19:34:17 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-7d-5f5a7fbaf71d Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F3.8A.06017.9BF7A5F5; Thu, 10 Sep 2020 20:34:17 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193415eusmtip247250d85f75a8a1df35765d2b8f84d1e~zgx2gG2sT1532615326eusmtip2M; Thu, 10 Sep 2020 19:34:15 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:35 +0300 Message-Id: <20200910193400.15326-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wUVxTGe2ZmZ4YNa8aVhKMlqJsaq4kotUlPjVFpm3YSTVqN2oYEcZQJ YFmgO0CxSdvVVrQrpbxCK5gVJRbFB6DIIrKKtIK4rlu2GiVFRNLEQuUhsAkg2LoMTf8753e/ 7zvn3lyRNRfyC8Tk1AzVlqqkWHgjV9864VvR+HVs/KqnxYuo+rYTqLe7gqWe4oc8HR7+lqEH VeupyXXUQIWP7AzlFT5jyHXKwdPTnv0cDY64GOpyewQq9e8XaKTliUDf+8qAnkz1s3SkfBTI 57xkoInrjTwNTZ3gKG/yHtAPdTeB2nKfcVR8uQEoxyHR8OlKgSq6Immk5yZHns6LAp0NdLB0 6fY0UEFbNZA35x/DhsXyZPlJg1zR1MfIRcc7WLm1s0SQc9udjFw72MDIQ1fv8XJeXRXIt3oP s/KZP8f5j4yxxrUJakpylmpbuW6nManoLy+T7t+Z/Vt3K2OHpg8dECKi9Ca6fj3OOMAomqVT gP72EtCbMcB9+ec4vRkFvGKvNDhAnLFce5il80rAUmcxBKPMUgDwxsSXwZqXXkfPIedMbJhU y6Nr6j4TNM+T1uLgH58ENZy0BDv6/VywNklv43iNy6CvtBDP1DSzQXmItAYfd8Xp8ZF4/9jY TCRKd0X0/F4m6Pr3sKvCPeudh/1tdbM8Aj1FuZxuOAhYUH9R0Jt8wG/KBmZV67Hu7ztCcBor LcPqxpU6jsGDY+2cfuE5+GBgbhCzL8vC+h9ZHZvwUI5ZV1uwud0/ixGnn4fqWMZfBsZZ/anc gC/2lTD5sLD0/1nlAFUQrmZq1kRVi05VP4/SFKuWmZoYtTvNegFe/lTPi7aRBgj4d7WAJIIl 1NS8JjbebFCytL3WFkCRtYSZ3vF6dphNCcreL1RbWrwtM0XVWuBVkbOEm1af6IszS4lKhvqp qqartv9OGTFkgR0ObNaS528RPx4tr3Vnx8W81ektmBuqdZrCX7E6hk0n3+3OiLm2ZOn8xyVR e+ThR+et208bHbuOPL/z/k+BvqM5dyMMX5ltkxsPeLe9tj2/1u5flMvNmV7uPhb+XU1Stit6 KD0kkO5LWObfGhGRtiklbOMOxrfhZ2XVG0rBZ0u7P+hdF2nhtCQlejlr05R/AcJDkL6lAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdjbFxWEZ/vGD1bLoOtvUfJWl1Yc6FXShopozXXpy0uZk Z7MMwQtSudJaRaDmskY3NbTUNLGL++ClKaVhVvOy1DArvFZU2GVD+vbwPL/n5YX3FZGSGSpQ lJJq4oypGp2U9qWcf1oH1j7KUsWve1e0Bqo6bAiGBuwkuC/303B2Mo+AN+Ux0FR/VQAXB7MJ KLw4RUD9HQsNX9y5FIxP1xPQ99gphOLuXCFMO0aFUPCiBMHo7CcSispmELyw1QngZ3MjDROz Nygo/NWD4HxtG4LWc1MUXH7UgOCUhYHJu7eFYO8Lgml3GwXOtzVCqPzWRUJdx28E1tYqBJ2n /go2LmF/ld0UsPamMYK9dL2LZFveXhGy59ptBHt/vIFgJ5700GxhbTlinw+dJdmKkR/0bl+V TGk0mE3cYq2BN22QxspBIZNHgkwRFimTh0bERSnCpSHRyiROl5LOGUOiE2TaSx87ibTuhBMv B1qIbNS0y4JEIsyE4af96RbkK5IwNxEezGsQzPkYfx4hLcjHIxfg2dcWeo6ZQbjCWiX0BjSz AjvP2Ahv4M+4aPzqdA7lLS9glHjcddDLUMwy3PWpm/JqMROJf1TXC+aGLsIV1c9IL+7DROH3 fXFeW8KkYFvHd8GcDsK9174SF9D8MjSvHPlzZl6frOcVMl6j582pybJEg/4B8hz8YcvP2gZk Gd/rQIwISf3Ez6JU8RKBJp3P0DsQFpFSf/HmTudhiThJk3GSMxrijWYdxztQuGc/Kxm4MNHg eZ9UU7w8XB4BkfKI0IjQ9SANEJ9hmtUSJllj4o5xXBpn/N8jRD6B2UitOKi0uTJ3Jh7NVC68 P3I8UWf/sLVsZVp+RmWlOSfp9lJdofZIrN+WvILSmMzP7SUv7wUHde6f5PuKrDWaTTvUKWP5 qhhbsCtreJv6UHGd1Q3qxTpJiF8jUbO9tKfOnqBaXZ0V4L71ZtgXO5YfeNzk3remfE/g6tAr 2kaT406vlOK1Gvkq0shr/gGP1Ph2BgMAAA== X-CMS-MailID: 20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b X-Msg-Generator: CA X-RootMTR: 20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193417eucas1p22204d717d003dba6eb7cb52d60e6571b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 02/24] ethdev: format a link status text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is new link_speed value introduced. It's INT_MAX value which means that speed is unknown. To simplify processing of the value in application, new function is added which convert link_speed to string. Also dpdk examples have many duplicated code which format entire link status structure to text. This commit adds two functions: * rte_eth_link_speed_to_str - format link_speed to string * rte_eth_link_to_str - convert link status structure to string Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 169 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 53 +++++++ lib/librte_ethdev/rte_ethdev.h | 32 +++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 264 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..1e6acf701 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status', true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..1c6b0c9ed --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,169 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbps FDX Autoneg", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbps HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_NONE; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 0 Mbps HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + /* test max str len */ + link_status.link_speed = ETH_SPEED_NUM_200G; + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_AUTONEG; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #4:len = %d, %s\n", ret, text); + RTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN, + "String length exceeds max allowed value\n"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_invalid(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = 55555, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN, + "Failed to format invalid string\n"); + printf("invalid link up #1: len=%d %s\n", ret, text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Invalid speed FDX Autoneg", + text, strlen(text), "Incorrect invalid link status string"); + + return TEST_SUCCESS; +} + + +static int32_t +test_link_speed_all_values(void) +{ + const char *speed; + uint32_t i; + struct link_speed_t { + const char *value; + uint32_t link_speed; + } speed_str_map[] = { + { "0 Mbps", ETH_SPEED_NUM_NONE }, + { "10 Mbps", ETH_SPEED_NUM_10M }, + { "100 Mbps", ETH_SPEED_NUM_100M }, + { "1 Gbps", ETH_SPEED_NUM_1G }, + { "2.5 Gbps", ETH_SPEED_NUM_2_5G }, + { "5 Gbps", ETH_SPEED_NUM_5G }, + { "10 Gbps", ETH_SPEED_NUM_10G }, + { "20 Gbps", ETH_SPEED_NUM_20G }, + { "25 Gbps", ETH_SPEED_NUM_25G }, + { "40 Gbps", ETH_SPEED_NUM_40G }, + { "50 Gbps", ETH_SPEED_NUM_50G }, + { "56 Gbps", ETH_SPEED_NUM_56G }, + { "100 Gbps", ETH_SPEED_NUM_100G }, + { "200 Gbps", ETH_SPEED_NUM_200G }, + { "Unknown", ETH_SPEED_NUM_UNKNOWN }, + { "Invalid speed", 50505 } + }; + + for (i = 0; i < sizeof(speed_str_map) / sizeof(struct link_speed_t); + i++) { + speed = rte_eth_link_speed_to_str(speed_str_map[i].link_speed); + TEST_ASSERT_BUFFERS_ARE_EQUAL(speed_str_map[i].value, + speed, strlen(speed_str_map[i].value), + "Invalid link speed string"); + } + return TEST_SUCCESS; +} + +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_speed_all_values), + TEST_CASE(test_link_status_invalid), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..cb624b7b4 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,59 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ + switch (link_speed) { + case ETH_SPEED_NUM_UNKNOWN: + return "Unknown"; + case ETH_SPEED_NUM_NONE: + return "0 Mbps"; + case ETH_SPEED_NUM_10M: + return "10 Mbps"; + case ETH_SPEED_NUM_100M: + return "100 Mbps"; + case ETH_SPEED_NUM_1G: + return "1 Gbps"; + case ETH_SPEED_NUM_2_5G: + return "2.5 Gbps"; + case ETH_SPEED_NUM_5G: + return "5 Gbps"; + case ETH_SPEED_NUM_10G: + return "10 Gbps"; + case ETH_SPEED_NUM_20G: + return "20 Gbps"; + case ETH_SPEED_NUM_25G: + return "25 Gbps"; + case ETH_SPEED_NUM_40G: + return "40 Gbps"; + case ETH_SPEED_NUM_50G: + return "50 Gbps"; + case ETH_SPEED_NUM_56G: + return "56 Gbps"; + case ETH_SPEED_NUM_100G: + return "100 Gbps"; + case ETH_SPEED_NUM_200G: + return "200 Gbps"; + default: + return "Invalid speed"; + } +} + +int +rte_eth_link_to_str(char *str, size_t len, const struct rte_eth_link *eth_link) +{ + if (eth_link->link_status == ETH_LINK_DOWN) + return snprintf(str, len, "Link down"); + else + return snprintf(str, len, "Link up at %s %s %s", + rte_eth_link_speed_to_str(eth_link->link_speed), + (eth_link->link_duplex == ETH_LINK_FULL_DUPLEX) ? + "FDX" : "HDX", + (eth_link->link_autoneg == ETH_LINK_AUTONEG) ? + "Autoneg" : "Fixed"); +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..a86f8f916 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -323,6 +323,7 @@ struct rte_eth_link { #define ETH_LINK_UP 1 /**< Link is up (see link_status). */ #define ETH_LINK_FIXED 0 /**< No autonegotiation (see link_autoneg). */ #define ETH_LINK_AUTONEG 1 /**< Autonegotiated (see link_autoneg). */ +#define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */ /** * A structure used to configure the ring threshold registers of an RX/TX @@ -2295,6 +2296,37 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); +/** + * The function converts a link_speed to a string. It handles all special + * values like unknown or none speed. + * @param link_speed + * link_speed of rte_eth_link struct + * @return + * Link speed in textual format. It's pointer to immutable memory. + * No free is required. + */ +__rte_experimental +const char *rte_eth_link_speed_to_str(uint32_t speed_link); + +/** + * The function converts a rte_eth_link struct representing a link status to + * a string. + * @param str + * A pointer to a string to be filled with textual representation of + * device status. At least ETH_LINK_MAX_STR_LEN bytes should be allocated to + * store default link status text. + * @param len + * Length of available memory at 'str' string. + * @param eth_link + * Link status returned by rte_eth_link_get function + * @return + * - Number of bytes written to str array. + * + */ +__rte_experimental +int rte_eth_link_to_str(char *str, size_t len, + const struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..69a763d4b 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.11 + rte_eth_link_to_str; + rte_eth_link_speed_to_str; }; From patchwork Thu Sep 10 19:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77223 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C73A5A04B5; Thu, 10 Sep 2020 21:34:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5B811C0D8; Thu, 10 Sep 2020 21:34:24 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 8197D1C10B for ; Thu, 10 Sep 2020 21:34:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193422euoutp018b1698b895ed20d44695a4ea7b03b048~zgx9DyhzH0325703257euoutp01E; Thu, 10 Sep 2020 19:34:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193422euoutp018b1698b895ed20d44695a4ea7b03b048~zgx9DyhzH0325703257euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766463; bh=A2PTzi/6QAPdj31SukY6WaSzyjFhYitbEDWVAQoenkE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Braw16v7rzUhLCmncofKKN7JrWSWfQ5y+3iRhiqOFosKEcHUb2uvXdzmjpCdrTKqM EsbkqmWeP/wKEU88tXHWrL6kigKaRNLm2Qc9WlFY/buCpjFYGgHsU+VYKkDo0Jlmak qpHoIvMDC7RdYuAkuJ+aPtVlRiPL2Sb6seUoNjdE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193421eucas1p12453e58dece4bdfcb70ac43f978817d0~zgx8CAKrp0435804358eucas1p1C; Thu, 10 Sep 2020 19:34:21 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 98.0D.06456.DBF7A5F5; Thu, 10 Sep 2020 20:34:21 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193420eucas1p1c7ed662be24a6fbc8e272dadefbbb22f~zgx64WU4D0308403084eucas1p1n; Thu, 10 Sep 2020 19:34:20 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193420eusmtrp14c07ffaa1ffaad08c872d8188a6086ae~zgx63gWya3165331653eusmtrp1u; Thu, 10 Sep 2020 19:34:20 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-80-5f5a7fbd9d91 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 16.8A.06017.CBF7A5F5; Thu, 10 Sep 2020 20:34:20 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193418eusmtip2378bf4cf96e38dacd375a04475582bf0~zgx5GNrOU1654016540eusmtip27; Thu, 10 Sep 2020 19:34:18 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:36 +0300 Message-Id: <20200910193400.15326-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGd+69vffS2O1aNJ44h7OJizP8kWCWM1nEsS25S/ywD/tEAqzO m2qkxfQCk2XZCDPIKjKsxE1wlYkTLCiiLa0EXC2ZRQtjgERYoKLBEdhArZBNh9soF7Nvz/md 55znfd+8Imt08mvFvbYCxW4z55l4Pdd2/UlfUucXWblbmr1J1NLjAroXqWdpvHqMp8MPDzI0 7M6gDt9JHTnvlDBU6XzEkK/RwdMf46UczUZ9DI12hgWqGSgVKBqcFOhIXy3Q5MI0SyfqHgP1 ubw6enKtnacHC6c5qnw6BPS1pxsoVPGIo+orfqAyh0QPzzUIVD+aQNHxbo7CI5cFap7vZ8nb 8wzoaKgFqLfsX92ODfLTuh90cn3HFCMf+76fla+PHBfkihsuRm6d9TPyg6tDvFzpcYN8895h Vm6a+Iv/QJ+lf2u3kre3SLGnbP9Iv+fgwHnd/ur0Axc6AmwJeJIdIIoobcWfzmQ6IE40So2A g79+7gD9op4D9EYWOK14DOjsivDPB0K1L2m8AbDr1LegFfOAwze/YmKreGkThstdTKyxSmrl 0bdwe6kRL+3EyPQFIaY5aSP2TjSyMW2Q3sTwxOySB6X12HQxwMbS4qRteHc0WzteAt4+Nbe0 E6VbIpb3BAXN/y66e47wmo7H6ZBnma/D8LEKThs4BHi07bKgFVWAX9bOLLsy0PP7z0IsjZVe x5b2FA2/jd39tzjtyi/i8MzKGGYXpbPtG1bDBiwvM2puEwZuDCxjxGd/r9CwjGOuNp32Pp2A 1WNNUAXra/7PqgNwwxqlULVaFDXVpnySrJqtaqHNkvxxvvUSLP7U8D+hqB/mB3YFQRLBtMIQ 2JaVa9SZi9RiaxBQZE2rDJm94RyjYbe5+FPFnp9rL8xT1CC8LHKmNYa001PZRsliLlD2Kcp+ xf68y4hxa0ugZl/O9p2rN4K7PW31Bl/loM7S8ELgvV+EEyuzpj4TLbVq1Y7B/L5rOV7rprP8 0Pxvg3z2q5ku61WxueuN+OOJRZ7h7+571TtTacXr4i022/l3dt1vZf0pc6WtSTkzBeU8Jk4e 8L//p/G1VyLR9IzE3pPclg+3dqaO/MjFHbpbkpBu4tQ95tTNrF01/weLqbuIpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t/xe7p76qPiDS7MUbRYf2Yeo8Wje4uZ LR5Muctm0f2hhcnixip7iz3b57BaTLrfwGTRN+kjk8X2FV1sFm8eNLFYvPu0ncnizt7T7Baz LjWxW3w69Jzdovf8bEaL539eMVvMXPCZ0eL8vK2sFj8P7mKzeP9nEYtF36+rjBb9W04wWhzv +chiMWXnDkaLti4Biw8rl7NbLL4jZ/HpwQkWi9M3N7NbrPl6kdli65m/jBYTj69ntDjb9p/V QdHj14KlrB6L97xk8pi88CKzx7Gb09g9ek7OY/LY+G4Hk8f7fVfZPPq2rGL0OPWom9lj9ZMf bAFcUXo2RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZ LZfWshZMsa5Yt+cAcwPjFr0uRg4OCQETieOz+bsYuTiEBJYySkz7Op0FIi4h8foJcxcjJ5Ap LPHnWhcbRM1nRonfr66zgCTYBDQkTnfMYwJJiAjcZpO43N4IlhAW8JG492odO4jNIqAqcfbJ CrBJvAKWEqefvGOCmCovsXrDAWaQZZwCVhIP78SChIUEMiXmnfnGCmHLSVyf/4VpAiPfAkaG VYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmbGIExvu3Yzy07GLveBR9iFOBgVOLhPWAVFS/EmlhW XJl7iFGCg1lJhNfp7Ok4Id6UxMqq1KL8+KLSnNTiQ4ymQPdNZJYSTc4Hpp+8knhDU0NzC0tD c2NzYzMLJXHeDoGDMUIC6YklqdmpqQWpRTB9TBycUg2MScVnnJ5aZod3VqU1Vq7bWvm7Wctg qsCyovq6u4Kxxik2clfdDj86698oONX8hYyRc3fM1HW9/74++C/t+/nKz531zLtlmH4V3u7w Xidustz6D7/V5628nHUikw76l9190iYbUKS+NGJD9auksqfTEjW2qlx+udUup82wZI+K8rJU yy01DR5KLMUZiYZazEXFiQD1egDYBwMAAA== X-CMS-MailID: 20200910193420eucas1p1c7ed662be24a6fbc8e272dadefbbb22f X-Msg-Generator: CA X-RootMTR: 20200910193420eucas1p1c7ed662be24a6fbc8e272dadefbbb22f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193420eucas1p1c7ed662be24a6fbc8e272dadefbbb22f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 03/24] app: update apps&docs with new UNKNOWN link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 11 +++++------ app/test-pipeline/init.c | 11 +++++------ app/test-pmd/config.c | 9 +++++---- app/test-pmd/testpmd.c | 12 ++++-------- app/test/test_pmd_perf.c | 17 +++++++---------- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 6 files changed, 31 insertions(+), 39 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..0b030d326 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -672,6 +672,7 @@ show_port(void) struct rte_eth_dev_info dev_info; struct rte_eth_rxq_info queue_info; struct rte_eth_rss_conf rss_conf; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; memset(&rss_conf, 0, sizeof(rss_conf)); @@ -685,12 +686,10 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + &link); + printf("\t%s\n", link_status_text); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..fe37d6373 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..f814de29c 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -605,7 +605,7 @@ port_infos_display(portid_t port_id) printf("\nmemory allocation on the socket: %u",port->socket_id); printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); + printf("Link speed: %s\n", rte_eth_link_speed_to_str(link.link_speed)); printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); @@ -750,12 +750,12 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %s\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + rte_eth_link_speed_to_str(link.link_speed)); } void @@ -3899,7 +3899,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..e996e2b75 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2991,6 +2991,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -3010,14 +3011,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status, + sizeof(link_status), &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..d1240b76f 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_to_str(link_status, + sizeof(link_status), &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..1057c7584 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_to_str(link_status, sizeof(link_status), &link); + printf("Port %d %s\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Thu Sep 10 19:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77224 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2B29A04B5; Thu, 10 Sep 2020 21:34:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC5801C0CF; Thu, 10 Sep 2020 21:34:27 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 2599E1BFC3 for ; Thu, 10 Sep 2020 21:34:26 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193425euoutp02f8aa37fef11b184789cce93f0fe9d5b1~zgx-1hTe40500705007euoutp02U; Thu, 10 Sep 2020 19:34:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193425euoutp02f8aa37fef11b184789cce93f0fe9d5b1~zgx-1hTe40500705007euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766465; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ttYNEUJ+qTMNbavlN1oPB8HdtQUHriEfPsGhw30nip/sySCZwr3wTm+CENcuCWMSP 0IHKkYlbFj32WifpMsRecqri+sdm61jCQtUUh4z4xl0QkHom4kEvaSxRhJiVpf9imU b0/R3G8KfqyICWJTM9etULtSDwZFh3AG5//ObUBE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193424eucas1p1f963bb4e8482c8c74981582ae251b964~zgx_1DYCw2934729347eucas1p1K; Thu, 10 Sep 2020 19:34:24 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id EA.0D.06456.0CF7A5F5; Thu, 10 Sep 2020 20:34:24 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193424eucas1p15de706cc359e51f1ef449e5dbf1872e1~zgx_Fbvc92936529365eucas1p1P; Thu, 10 Sep 2020 19:34:24 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193424eusmtrp15d7d1ddf61d50058b2e96bdad2b96fad~zgx_EjXXh3165331653eusmtrp1v; Thu, 10 Sep 2020 19:34:24 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-86-5f5a7fc05eee Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 38.8A.06017.FBF7A5F5; Thu, 10 Sep 2020 20:34:23 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193422eusmtip2a39e9c9c91cd6d36f6378a780a85b8ec~zgx8SFTxQ1532615326eusmtip2N; Thu, 10 Sep 2020 19:34:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:37 +0300 Message-Id: <20200910193400.15326-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wUVxTGc2dmZ4YN24wjCSfYYNxIoqaKiCZHrdoaUieaGB/9i1RxW6b4 gJXsACqJkW4boCulsKDiCyirQRFZeS5SobCmgCyPQgpCRMUHEVBcWCQVi1rWWdP/vvP7vu+e m5vL02IuG8QfMCbIJqMhVs9qmZrmma7ljScio1Y2t3+G9vZ8go8f2Ggcyr3P4smJnyjsL9mE txwXNGh9mEJhpnWSQscVC4svhswMvvQ4KBysd3F4rsfMocf5jMNfus4TfDY7RuPZwimCXfnV GpxpqmPRPVvEYOabXoK/VrUSbMmYZDD3Zi3BVIuAE1eLObQNBqNnqJVB10Alh6XT3TRWt78l mN1iJ9iR+l7zxSLpTeFljWS7NUpJOb9101LzwGlOyriTT0nlL2spyd3Qy0qZVSVEant8kpau PX3N7tBGaj+PlmMPJMmm0I37tPtby47Et3FHn1xqYlNIDWshfjwIq6HY7NZYiJYXhSsEZvoc RB1eEbj4VyetDlMEXpT20h8rty25jGoUE+isS/VVpgn8Pjyp8aZYYQm40vMprxEglLPgmL1L eY35QgR0XB5jvJoRQqDBev1DQSesBcsfab5bLYRrNxrn1vG8n7AOHg3u8WJRCIa7Ba8+nAlC Kw+2h2mMmo+AvvoCn54PYy1VnKo/BVdOBqMW0ghk11Ry6pBF4Mfz477UJqh63sl5t9HCUrDX har4S6jsdVBeDMIn0D8+z4vpOWmtOUOrWAfpqaKa1kPjnR4fBnj7r7+KJbD3uX2PVU/gTFsl l0UWnvt/VyEhJSRQTlTiYmQlzCgfWaEY4pREY8yK7w7HVZC5v+p61+KpJdM93zqJwBO9v65x XWSUqDEkKcfinAR4Wh+g29zh2ivqog3HkmXT4ShTYqysOMkCntEH6sKLRveIQowhQT4ky/Gy 6aNL8X5BKSQ6b9mGgK3j9qYQ/9elA3kpw/eE+6u2H0wa+XlqnzFeXz68LWu33+2I4bXu0eQ1 tm+SNde3RzWY/76UtuqH7NMjZRtm0qsXh+46PhL4Z1+Q2H/wUbWzcOfmgMldCeFlOWHWIc/X i5X1FWb9P993H1UqwrcEBT//6v3EqYYnIUUucXVes0nPKPsNYctok2L4D+ayhGWnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0iTcRTG+7+3TWn1Mo3+GFgNgghazUueSdqFoDfoQyAUTG0NfVPLbbF3 K43yEmW2TPNSaMrSpmXrntfELI10OUVMtCLTZUplpTZTM+yyZX17OL/n8Bx4jpiUfqP8xAk6 I2/QaRJljDfl+NU2sPZRqkq9ftYOcKfDgmBowEqCs+ANA2cnThLw0rYJGutKaMgbTCMgO+8r AXWVZgY+O09QMOaqI6D/oUMEl56fEIGr5b0IznUVI3g/N0pCUekkgi5LDQ2zzQ0MjM9doSD7 Ry+CnGo7grasrxQUPKhHkGFmYeL6NRFY+/3B5bRT4HhVJYKbU90k1HT8RJDbdgdBZ8ZvevNK 7kdpBc1ZGz8SXH5ZN8m1vroo4rKeWQju3lg9wY039TJcdrUNce1DZ0nuxvB3Zpe3Sr7RoDcZ +RXxesEYJotUQIBcoQR5QJBSrggMiQ4NCJatC98YyycmHOYN68L3yePtt48cahclvStvZtJQ LWNGXmLMBuEn5gLKjLzFUrYC4armLjcQuwHGn4bJeY8PnuszM/OeSYSnqgr/AoZdjR2ZFsID fNnXDO45nU55gA+7DXdWjP7VFLsKN+Xdoj1awiqx+dHpf8nL8Y27j0lPmBcbit/2R3vGUjYB Wzqm6Xntj19c/kacR4tK0QIb8uVNgjZOKwTIBY1WMOni5DF67X3kbry2dba6HpnHIloQK0ay hZLHoSq1lNYcFpK1LQiLSZmvZGunY69UEqtJPsob9GqDKZEXWlCw+75c0m9JjN79PzqjWhGs CAGlIiQwJHADyJZKMtnmKCkbpzHyB3n+EG/4v0eIvfzSUMOX9Kye0Znk8QMj8Yz/CqmgLp9Q hUV/sDq26y78PvbEsvhjWYpqYqj7RVRHpU9+z1Nb5LkoW+7xTv9lzoGr0rlpe8nT1E2DR6wx 924Fzewf2Fv0XdHnoiO6iLKdlkKXU5N7xm8PPVm827SjeGjyeVCSsjKzr+pUSm9OypaRYJqV UUK8RrGGNAiaP3VxJFAHAwAA X-CMS-MailID: 20200910193424eucas1p15de706cc359e51f1ef449e5dbf1872e1 X-Msg-Generator: CA X-RootMTR: 20200910193424eucas1p15de706cc359e51f1ef449e5dbf1872e1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193424eucas1p15de706cc359e51f1ef449e5dbf1872e1 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 04/24] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Thu Sep 10 19:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77225 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1500FA04B5; Thu, 10 Sep 2020 21:34:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 278481C113; Thu, 10 Sep 2020 21:34:30 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 827021C10F for ; Thu, 10 Sep 2020 21:34:28 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193428euoutp014513a1f3951feac11234e75ab8a10fdc~zgyCBqE4C3152731527euoutp01o; Thu, 10 Sep 2020 19:34:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193428euoutp014513a1f3951feac11234e75ab8a10fdc~zgyCBqE4C3152731527euoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766468; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=MpVBW6vlCKCaBIS3OpFZA4pbWPHWSR5NmYmxcCu7YbCIUgZHs6hHduFOon7Szyrps uiNyLweIPK0HMn5uUNK/0hzKExRxyGOfRFshcrFYqdJ6bVFkrt0+3H5Iy8grpTWYiG NGo27bPUFLKBgNeQOqBw4IReH/QzBAy6fFX8/cMg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193428eucas1p12b79e8a411f54ac114ddc0a2cd7ffd30~zgyB0IpbF0307203072eucas1p1v; Thu, 10 Sep 2020 19:34:28 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 91.42.06318.3CF7A5F5; Thu, 10 Sep 2020 20:34:27 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193426eucas1p2b48cdd5bb0a0956bd88d18991bc0f647~zgyAyWjGW2392123921eucas1p2p; Thu, 10 Sep 2020 19:34:26 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193426eusmtrp15f0c128640f742019c48972cdc218682~zgyAxgm1W3165331653eusmtrp1w; Thu, 10 Sep 2020 19:34:26 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-24-5f5a7fc33ff9 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5A.8A.06017.2CF7A5F5; Thu, 10 Sep 2020 20:34:26 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193425eusmtip2235cb6fb445c676776c23c55b11ac4a2~zgx__tMYY1532615326eusmtip2O; Thu, 10 Sep 2020 19:34:24 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:38 +0300 Message-Id: <20200910193400.15326-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTdxTHd+69vffSUHKtZp6wxUfRZS9g6rYcDc7Hlnj/wESz6ZYGZd28 wQegacFXTNaAA1Y7htQ4fAAdRGE4xhilBaYG6wZCiwiOABs6qGZMHII8sqGwjXpr9t/3+z2f c84vJz+R1Tv4SHFXappiTjUlG3gt526auh599RNj4mt3M1dTlb8IKHC7lKX+E7d4OjZ6lKGe ijV00XNWQ/m/WRnKzX/IkKfcxtOf/RkcPRjzMNR3ySfQ6c4Mgca8gwJ93n4GaHB6iKVTznGg 9qJaDU1daeBpZLqEo9xHXUBfuK4BNdsfcnSivg4oyybR6NdlApX2LaCx/msc+XprBPpmsoOl Wv8M0PHmKqC2rH81axfLj5znNHLpxXuM7Piqg5Wbek8Ksr2liJGrH9Qx8sjlLl7OdVWA3Bo4 xsoX7v7Nb9IatXE7lORd+xVz7FsfanfmdPwi7LsRcdDd4GSsUBhugzARpdfRPnGHtYFW1Evl gN0/+DWqmQD8tscPqhkHLHbls09bCjOuhFrKAAesthA1CdhWkwlBipdeRF9OERMszJOqefRM d88aUZwrvY3ZM08YTlqK56cqNUGtk1Zi14/1jLphIV74rpEN4mHSKhzo2xaM9dIC7C6eeDIS pZ9FbL8zwQUZlN7B8Z9Cj5uLQ80uQdXPo89h51Q+G/C4u0ZQTR5g5pnhELUGXfevC8FBrPQS VjXEqvE6vHVuUFDnR2DP8JxgzM7KfPeXrBrrMCdLr9IGbGzpDMWIM49D15XxL4+VV69zCbDM 6WfzYOHp/3c5ASpgvpJuSUlSLCtSlQMxFlOKJT01KebjvSnfw+xX9f3TPFkHl6c/8oIkgiFc 17jKmKjXmPZbDqV4AUXWME+3vs23Xa/bYTp0WDHvTTSnJysWLzwncob5uhUl97bppSRTmrJH UfYp5qdVRgyLtELjq7WBJTHh2e99tmXU6AgUtBo+iBp74/eo3hdq+NvPjnwaybfG1r7564bi 9+1HNlcePFsyfCDPG2dK6OqMy44oeGZtQ1pBy9Ldq7fsLtQtinKUV64/3Hskpx4SFi8fGB06 Gr9uuKpk+1avMVBdEN30uH9Rxc2Nf+yJuZqwMV6KTne/8i5v4Cw7TcteZs0W03/HWrHGpgMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdna0Fodp9EfFailIl9Vm5jvRivrQ6UZiRKHZGnZQyW2x M8UukImkTbMyiS66tKWmVlbOW9nFUXmZUlZWlppZJF3wNousaW1I3x7e5/e8PPC+DCl1UD5M os7IG3SaJBntSdmnmvuW2o5Eq5d3Fyihqt2MYKDPQkJ/fi8N2SMZBLypWA2NdQUiyHufRkBu 3igBdVdNNHzvT6dgaKyOgJ57djFceJ4uhjHboBhOPL2IYND5lYTzRQ4ET801IphoukPDsPMy Bbm/uxCctLYgaM4ZpSC/oR7BMRMLI+VlYrD0+MNYfwsF9u5qMVz70UlCTfskgtPNVQg6jv0V rVnA/S4qEXGWxi8Ed6a4k+SedJ8VczmtZoK7NVRPcMP3u2gu11qBuLaBbJKr/PSLjvSMlocb 9MlGfn6CXjBGyGIUoJQrVCBXrlDJFcGhsWHKENmyVeF7+aTEFN6wbNUeeUJW51vx/mezU2vv FBFpqHCWCXkwmF2BC9ObSLeWsiUIj/ZKTYhxzTH+9omcRryw85WJNiFPF+JAePDdMO02aDYI 27PMhNvwZt/R+EXmUcod9mLX4cxJ5GYoNhCXTlwXubWEVeGuRw3E9NJ5uPLmQ9KNe7Bh+ENP 7HSFRGxu/yma1v749aVx4hSaXYRmVCBvPlnQxmsFpVzQaIVkXbw8Tq+9jVwHr30yYa1HpqFt NsQySDZL8jAsWi0VaVKEA1obwgwp85as7bDvlkr2ag4c5A16tSE5iRdsKMTV7zTpMydO73of nVGtCFGEgkoRGhwavBJkcyVZbNMuKRuvMfL7eH4/b/ifIxgPnzTkUb51x+HjOV4x49a1hwIq I+XMBuuDKd2WzZZNqtoALT2ZNqOsatyvLX+jX0V468aX0SkZi9cX2N/EBH185vBdcqp0tW/U 52+FnXcnzt3NvnXjSvW8qIuBThzhpz7buyOztmeqLZMplrQmHf4T5/hjyntcd5BrHEi11CeQ aPtO58KZMkpI0CgWkQZB8w+OM0SlBgMAAA== X-CMS-MailID: 20200910193426eucas1p2b48cdd5bb0a0956bd88d18991bc0f647 X-Msg-Generator: CA X-RootMTR: 20200910193426eucas1p2b48cdd5bb0a0956bd88d18991bc0f647 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193426eucas1p2b48cdd5bb0a0956bd88d18991bc0f647 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 05/24] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Thu Sep 10 19:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77226 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D35D5A04B5; Thu, 10 Sep 2020 21:35:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 670BF1C117; Thu, 10 Sep 2020 21:34:32 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 90BB71C117 for ; Thu, 10 Sep 2020 21:34:31 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193431euoutp017e9c561d652e5a24d8ecb35484a2d183~zgyE4Ne050119101191euoutp01Z; Thu, 10 Sep 2020 19:34:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193431euoutp017e9c561d652e5a24d8ecb35484a2d183~zgyE4Ne050119101191euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766471; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=T6q/5tAUD+z6xb+/7yBI6HrP/OKi2KAIZpW9+kj7u2ldgd2OqXX7Tu1LpOzJVfUPD 1iOek3xzUDzkGEd/vFyC/M4LGmHZUDnWZ1WlhA+kijbUqV81qr+uUhZG/mYwf55j+S 3r7eeSWoCEUJR9xwUc+zzLYU2tj1rTu4DAvptp0M= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193430eucas1p1793e0cc8acbc06d138cafa9043f854fc~zgyD24FfK2936129361eucas1p1S; Thu, 10 Sep 2020 19:34:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 0D.0D.06456.6CF7A5F5; Thu, 10 Sep 2020 20:34:30 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193429eucas1p2d686171aa6500af8d5b014d7472d7112~zgyDZUX7i2619226192eucas1p2d; Thu, 10 Sep 2020 19:34:29 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193429eusmtrp182e7a1772ea87072cbda9e315ef01708~zgyDYgSos3165331653eusmtrp1x; Thu, 10 Sep 2020 19:34:29 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-8c-5f5a7fc665b6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 7C.8A.06017.5CF7A5F5; Thu, 10 Sep 2020 20:34:29 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193427eusmtip2e76b38fe94679f0555ebbf8d266217b9~zgyBll-dz1532615326eusmtip2P; Thu, 10 Sep 2020 19:34:27 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:39 +0300 Message-Id: <20200910193400.15326-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGPffe3ntpqHlXSThTh1uX/SMZjsxkZ8wMJftwPyzZvixREsFO 77Bbi6Ytbm66FbeBgQ6hkjlkKwwyRTRjaG3RIOnI0uKKdYBEyRgyokFgKPIn/BG2cXcx+/Y8 v/Oc93nz5pV5s09cK9vy3aoz32q3iEYhGJmPvxj5LDv3pY6BBGrq9AMNDdTzNFj5h0ilE19w dLMxk1pD3xrId8vDUZnvAUehhhKR/ho8LNC9yRBH/ZdjEp3oPizRZPuwRF9dqwYaXhzlqap2 Cuia/4KB5n++JNL9xTqByhZ6gY4GOoCi3gcCVV5sASoqYTRx+pRE9f0pNDnYIVCs77xEZ2e6 eLrQuQRUEW0Culr0j2HLU8pC7Q8Gpb51hFOOfd/FK5G+ryXFe8XPKc33WjjlfluvqJQFGkH5 daiUV87cnhPfNmYbN+9W7bb9qnPj6zuNe1oHbgv74tJHs13XwQM/iiWQICPbhEt3OvgSMMpm 1gA4f7xc0s00YPhWFHQzBThUWMU/WmnuCxr0wSnAwuIKQRuY2QzgdwOKpkX2PMaO+DktlMSa RQwt3lg2sryGZeF4Z46WEdgzGJyN/LdrYq/iSNTH6QUb8MxPYV6LJ7AM/LN/h358Ct6omV6J /CZjTY9N129gp3cMdL0GR6MBSdfrMXbMK2hXQFYMWBE8L+mmHPDz6vGVVCYGxuKSVsazF7Dp 0kYdb8XAlz2gYWSr8eb4Yxrml6UveJzXsQmPFJn1tAXDV7pXMOLSw0QdKxif8Iv6S10GrDob MZTDhhP/d9UCNEKyWuBy5Kmu9Hz1wzSX1eEqyM9L27XXcQ6Wf2rs7+hkC8x0v9sOTAZLoimc kZ1rNlj3uw442gFl3pJkyroayzGbdlsPfKw69+Y6C+yqqx3WyYIl2fRy3cgOM8uzutUPVHWf 6nw05eSEtR54cyop1cZ+efah7fSmt47ObnMnbtmp3C1dF2+2FVcbn6vMOjTck9m4uP61sbm2 YQ+bXbg48XSqvbQt61xOZdtQetpJeKU3tz/d3T24KjQ9Fr7+ifvuqu2PT89Hn6w76El2xN67 U3iyZvRgyrZg39w3n3q3NpRHn/j90Op3MuzvF20Wd/VaBNcea3oq73RZ/wVo1JyZpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzdHi8s0+uEfZpMigqbztaOVhQXdgqCHGGi1Rl42yTnb nZKFtSQsVmn5SMtY1rDSTLN8VVoquVmbiT211CwlMR/ZtIdlD5f035fz/XzPOXCOiJROUt6i +EQjZ0hUJ8hoMeX4be9d3nI4RhUwYVkCFU4Lgve9VhL6cntoODF+lIDO0tVQX3tBANlvTQRk Zn8moPaamYaRvnQKxly1BHQ3OIRw/mm6EFzNg0I41V6IYHD6IwnniiYQtFuqBTDVdJeGT9OX Kcj88QJBVlUrAvvJzxTk3qlDkGFmYLzkqhCs3T7g6mulwNF1WwhlXzpIqHb+QnDGXoGgLeOP YM0i9kdRsYC11g8RbM6lDpK1dZ0VsicfWQi2cqyOYD/df0GzmVWliH38/gTJXh/4Tm8Wx8hX GvTJRs5Xq+eNq2SxCgiUK8JAHhgcJlcEKXeGB4bI/CNWxnEJ8SmcwT9it1xb3ztAJT0R7v/W 8RyZUDltRh4izATjyq4agRmJRVKmGOH+n/mkGYlmDIyHB8hZxhNPvzTTs8wEwq97XITboJml 2HHcQrgNL+YNjZ8dO0K5w55MJB517nIzFLMY13yzUW4tYcLwkD2bmG26EF+/2fhvlgcTjt91 73SXpUw8tji/Cma1D351cZI4jeYVoTmlyItL5nUaHR8o59U6PjlRI9+j191CMxevsU1V1SHz 2LZmxIiQbK6kMTxGJRWoU/hUXTPCIlLmJYlsc+ySSuLUqQc4g15lSE7g+GYUMrPfGdJ7/h79 zP8kGlWKEIUSwhTKIGVQKMgWSI4zTTukjEZt5PZyXBJn+J8jRB7eJsRs8QuourI+1trgudFj cpOyULN7n4ROS4oq+zB6aGtq/7ryMa0dhttSfYOdVhNni45W9UdGd85Vl2XEtRwrURU/Va5g D2ZFBeQduJymmgyl2u85C8UlD/xsa7ffgHxXUWN3a854yvDZDVlrLQXSTm0BF741aMRpaqX1 U8vyHsooXqtWLCMNvPovcAVjaQcDAAA= X-CMS-MailID: 20200910193429eucas1p2d686171aa6500af8d5b014d7472d7112 X-Msg-Generator: CA X-RootMTR: 20200910193429eucas1p2d686171aa6500af8d5b014d7472d7112 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193429eucas1p2d686171aa6500af8d5b014d7472d7112 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 06/24] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Thu Sep 10 19:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77227 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C65CA04B5; Thu, 10 Sep 2020 21:35:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 029D41C11D; Thu, 10 Sep 2020 21:34:37 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id B32881C123 for ; Thu, 10 Sep 2020 21:34:35 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193435euoutp02726a186659be4a7faf90973817058f72~zgyIuYlFB0500705007euoutp02V; Thu, 10 Sep 2020 19:34:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193435euoutp02726a186659be4a7faf90973817058f72~zgyIuYlFB0500705007euoutp02V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766475; bh=70Bc5Qf+Pjp25n3sxWMGseS0dIRRQUC1Jc8dQTJLpmQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=FYf0SPMrLTi7C7sCF9E5Kcb70/k0l8UN4l+MuqCBWsBxxOlp9ywidSxC3Yjnsu+2w oabEVhC6XHmJnNfjeJ2BWa3MB7P9Wqjz5caizJFgDTxHij7bjJTB9/q3nf6lSiqpyJ Vol3ypbuXUplyqxmGpTJXqDCKIBAOfpQ4CFGfgU8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193434eucas1p2f5adc0b3d6057585d8fee1213ab5fb3d~zgyHqXOUA1147811478eucas1p2j; Thu, 10 Sep 2020 19:34:34 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 39.D5.05997.ACF7A5F5; Thu, 10 Sep 2020 20:34:34 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193433eucas1p1e00176d14e73334d7b293b0aae8b7e4a~zgyGhZeKZ0322703227eucas1p1n; Thu, 10 Sep 2020 19:34:33 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193433eusmtrp269604593d7b1c0a3d3361f5a2348c2f9~zgyGgTjA71027210272eusmtrp2x; Thu, 10 Sep 2020 19:34:33 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-9e-5f5a7fcaf6f4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8B.09.06314.8CF7A5F5; Thu, 10 Sep 2020 20:34:33 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193431eusmtip2070dc56d612b9c06fecbd7e9e58b4683~zgyEvQ06x1654016540eusmtip2_; Thu, 10 Sep 2020 19:34:31 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:40 +0300 Message-Id: <20200910193400.15326-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSX0xTdxTHc+5t7700VH8WomdqNHYzcyYD59w8Q51/spj7YuJ82AMJw05v wAjVtcKmWRwDpab8URAwg6VF0aHVDMFSoIGF1WDBFghuBLswZcTMyEQqYqZYRcqt2ds5n/P9 nu95OBJvqBAWS/vMhxSL2ZRlFHQaz43nfe/f/D41fc2d3+dTQ9ABNHqnjqeRir8EKgof4+i2 azO1t/ykpfK7eRyVlj/mqOWiXaCHI/kaejTZwtFwR0Ck6lv5Ik367otU0l8DdD8yxtOPtU+A +h3NWnr+m1egicg5DZVODwKddHcD+Ysfa6iirRWo0M4ofKlepLrhZTQ50q2hQOiaSFeeDvDU HHwJVOZvAOotnNFuWSFP117QynXtDzj59NkBXr4RqhLl4h4HJzc+auXkiV8HBbnU7QL55mgR L1++90zYqUvVbdyrZO3LVSzJn+7WZTa9mOIO5m/6tj1ihzwoWWOHOAnZOqzq+pO3g04ysIuA oarTWrWZAmxssnFq8wRwsK9S+8bybKAb1EE9YOSX8ZjlKWDB9TNCVCWwVRg44ZizJ7JGAVsi Q1x0kMC24vF+lxitNWwlXvWVzK3Vs0+wzeuKRSzHy1c7Z6+SpDiWgn8Pp0WxgS3DIefU3E5k QQlHAz5Q9Z9h5d1wzJuAY363qNZLcabNGTPYAMs810S1OTV7as14TLUZ3f/2idE0nr2HDd5k FW/Fmo7jcxjZPLw9viCK+dmy3HOGV7EeTxQaVLURO3tuxTDiyxfxKpYxHGjm1fM7AG2D807B 8ur/o2oBXLBIybFmZyjWtWblmySrKduaY85I2nMguwlmfzXwyj/VCt7IVz5gEhjj9Z0pqekG rSnXejjbByjxxkT9tt7Alwb9XtPhI4rlQLolJ0ux+mCJpDEu0n947kGagWWYDin7FeWgYnkz 5aS4xXlwMm7jdzZL8T/bK/VHlZSHH8VfT1j1x8TH937uGO7d4axKqb0wtHBtXXH618HcbUaz EF/WXW4Ih/5zsE0zwXfz0mxdrnpMrA6x0bFLTk/S+el3Jq5sl3sKvJ8fcb8lZxbWry8I7hbX 7ZxfWbQhuWmm9Ie39xR4elY7x/1d7h1G7Re7jBprpumD1bzFanoNrBRkb6cDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+93XrtLiMpV+Ss8LlRYupy6P0vuvC0EohYJlNuym0uZid2ZF D5N8sJqpSZHFtMRcszJT00IjF6k1TbQsRSszQbJhPstKsw3pv8/he77fc+AcllRMUn5scopR NKRotDzjSTn+tnwMfHk2Nj6oKAoq2ywIBj+WkjBQ+IGBC2PnCeixbYOGuhs0FHxKJyC3YJyA OquJAedABgWjE3UE9Dc6ZFDUlSGDCfuwDMwd1xEMz46QcK1kEkGHpZaGX01PGPg+e4uC3N/d CC7VtCJouThOQeHjegRZJg7G7pTLoLR/BUwMtFLg6K2Wwd3pThJq2+YQ5LdUImjPmqe3rxZ+ l5TRQmnDV0K4fLOTFJp7r8iEiy8thFA1Wk8I3592M0JujQ0JrwYvkELF0AwT6Rmr3GzQpxrF VUl6ybiF36eCYKUqHJTBoeFKVUhYXESwmt+4dfMhUZt8TDRs3HpQmfTwzxRxNGPL8YZZE0pH 5iAT8mAxF4pnOluRCXmyCq4M4apMq6tgXQLG34bIhR4vPPvOxLhZwU0i3Dfi7WaG88eOHAvh 9npzfQx+k32Ocgte3A6c2WGTuZni1uAHdjPtZjkXjh8/sdELoStxxYNnpHuWBxeBP/fHLeQn Y0vbD3qBV+D3xVNEHlpSghbZkLeYKukSdZJKKWl0UmpKojJBr3uIXAd/1Pyruh51Ve2xI45F /GL5s4jYeAWtOSad0NkRZkneW76z3XFAIT+kOXFSNOjjDalaUbIjtWu/fNLPJ0Hvep8UY7xK rQqDcFVYSFjIJuCXynO4pv0KLlFjFI+I4lHR8N9HsB5+6ehUQPOXucKAxq4evX3nrnmfb+nO /kzffeq4dWkbQsv91NHW3O5pfFvdcHpb6NXzUSfX1vLvCkbPtL1NLi6qN/fRy5wxZv+Yri9W 2597R6IrQsoztYf3v9amDbFNHXvvBTgL7r8IjBH5Qefy6ciE0p/3K33zBj3Ssuceya3PfXdf beQpKUmjWk8aJM0/hjaw7QYDAAA= X-CMS-MailID: 20200910193433eucas1p1e00176d14e73334d7b293b0aae8b7e4a X-Msg-Generator: CA X-RootMTR: 20200910193433eucas1p1e00176d14e73334d7b293b0aae8b7e4a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193433eucas1p1e00176d14e73334d7b293b0aae8b7e4a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 07/24] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 14 ++++++------- examples/l2fwd-jobstats/main.c | 13 +++++------- examples/l2fwd-keepalive/main.c | 13 +++++------- examples/l3fwd/main.c | 13 +++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 33 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..a51b58412 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,11 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..6e01b2e66 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..e2236a87b 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..0aeae216a 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..a06398eff 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -133,7 +133,7 @@ print_stats(void) link_get_err = rte_eth_link_get_nowait(portid, &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +141,8 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : + rte_eth_link_speed_to_str(link.link_speed), link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +445,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +458,9 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + NULL, &link); + printf("Port %d %s\n\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77228 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C481A04B5; Thu, 10 Sep 2020 21:35:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4060D1C127; Thu, 10 Sep 2020 21:34:40 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 58D8F1C126 for ; Thu, 10 Sep 2020 21:34:38 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193438euoutp02b9dc0bb998ac182ca7f47b672f59de53~zgyLMhM4Z0499204992euoutp02Z; Thu, 10 Sep 2020 19:34:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193438euoutp02b9dc0bb998ac182ca7f47b672f59de53~zgyLMhM4Z0499204992euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766478; bh=rtlr8T5Fy0EDTqnsAnewtW3pEkKYnBnvexBXMUYSoLI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=VGkxeOaZKl+AT8LcccJxfMEe+wNtp1mzdbf3YK9bSbfptUq1unecH4rqjOt1WZv0q 9RhvUTjaDQIjKcBsSmxCE6zIfVXf8nLCE0rbQghZBjnk0wL27xm+c4Wb5HWur4BhBv OvXVRfAZRLRyFqdrVTeeJErDp2x7NfEdjSvX5/rc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193437eucas1p16fe06c906b8366578656ef07052cd790~zgyKeKe-X0487904879eucas1p1q; Thu, 10 Sep 2020 19:34:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 6F.0D.06456.DCF7A5F5; Thu, 10 Sep 2020 20:34:37 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193436eucas1p13dd91d9668b6bd61dd3fd734dc51fae3~zgyJr23rL2936129361eucas1p1U; Thu, 10 Sep 2020 19:34:36 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193436eusmtrp26b24309f2cc886ff0556d227e87054c8~zgyJrDpra1027210272eusmtrp2z; Thu, 10 Sep 2020 19:34:36 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-96-5f5a7fcda863 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CD.09.06314.CCF7A5F5; Thu, 10 Sep 2020 20:34:36 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193434eusmtip20157f5465c4673d422c05c0945976c83~zgyH9Thek1654016540eusmtip2-; Thu, 10 Sep 2020 19:34:34 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:41 +0300 Message-Id: <20200910193400.15326-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTZxjG8557K2XHovKqRLcmGmcCzkyTb4bIZlw42bJsi5dEEsVOTtAI aHoEhX8kahBbBLmMxQsFygwKmoKUFg0qNkq1BRlEhhcUNF6QCcotQQQZx9Nl/z3P8/6+7/ny 5hNoYz63QNiVsk+2pJiTTJyecTe/vxvZejAu/qvWvlDibLEDefakgia9RY85Ynt3hCL3q2JI o+cMSwp6MimSWzBEEc85K0fe9B5iyOCwhyLdVwM8OdVxiCfD3lc8Od52GsiryX6anCwbAdJm r2fJ+xtXOPJ20sGQ3IlOIHmu20B8OUMMKbrcACTLKpJ35yt5UtG9iAz33mZI4EEdTy6MtdOk vmUKSL7PCaQ1a5r99gtpouwsK1U0vqakwvJ2Wmp+UMxLOXfslFQ72EBJb691clKuqwok/zMb LVU/H+d+0cfpoxPkpF1psmXF2u36nYXP+9m9t7gDRY8wE8pZKwgCiquwuzLWCnrBKJ4DvOHI ZjUzCuj+2AZW0M2YEUD/8UhVqwfGr08wGlQJ6H3cFzRjgBenB3iV4sRlGMi2U+pgjljLoWey i1L7wsQfsf96usow4hK0Oc98ajCI3+DALT+tNSzG6pomWsV14hp82r1Ve8Qi7Cod/XQlii0C /vW0kdL49TjUV8JqOgz7fS5e0xE4fbk0eOAoYL67jtfMCcDDpweCVAy6/rnLq220+CU6r6zQ 4u/wxe/ZjLajULw/MFuN6RlZ4P6D1mIDZmcZNdqETXc6gjHi1IcQLZaw8FpPcKFXAWtyrNwJ WHzq/64ygCoIl1OV5ERZWZki749SzMlKakpi1I49yZdg5qMGPvqGG2Cs4zcviAKYQgxNa+Li jaw5TUlP9gIKtGmOYV1rYJvRkGBOz5Ate+ItqUmy4oWFAmMKN3zteL3VKCaa98m7ZXmvbPlv Sgm6BZlgvbjh805fdd66pXO3+PybdW/uJdTER4+y7vCFl1jdrz+UG57Yb3JZI4P2+XW2+pOS sL/k4IaXxTZHRezDjryIn4wtYcWzpiJnr9547O8DGz29Yo+S/+JmTK20Zd6mHX9Wp33WNT0v uvTI905jaOwklPzsTgpxREXUjrdnNGe4Auv9JkbZaV65nLYo5n8BVPLQP6QDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdjalxWEa/R1lNSgq6dS8vopllw+dKKIIgsyaQw8quks7 m2UFzoiKaVYmhRlrJpLTyMy8hZXOynKaaFgubZksTLtYamG2Lg7r28P7/J6XF55XQsomKLkk TWvkDVp1hoL2p5y/29yrO7LjVWuHyhZCVYcVwZC7lITBwtc05H45QUBfRRw01V8RQcEbMwH5 BV8JqC+30PBx8DgFn8frCRi45xTD5Z7jYhh3DIvhTFcxgmHvKAlFtgkEXdZaEfxouUvDmPca BfnTvQjO3nmCoC3vKwWFjQ0ITloY+GK/LobSgWAYH3xCgdNVI4Yb37pJqO34heB8WxWCzpN/ RBuWctO2MhFX2jRCcBdKuknuseuimMt7aiW46s8NBDd2v5fm8u9UIK59KJfkKj1T9E7/eDbW oDMZ+SWpOsG4TrFPCaGsMhrY0PBoVhkWtT8mNEKxZn1sMp+Rlskb1qxPZFMveEZF+kf04cJ+ bEYlIgvyk2AmHE89mKYsyF8iY8oQLssbQRYkmTEw/uAhZ5kA7H1hoWeZCYSrfxYRPoNmVmDn aSvhMwKZfho/P5VD+cIBzDY8+iDLx1DMMpxbdQX5tJSJxp8etf9buhhX3momfbgfE4PfDuz3 jWVMGrZ2fBfN6mD88uokcQ7Ns6E5FSiQNwmaFI2gZAW1RjBpU9gkneY2mim87vGPmgbUU73b gRgJUsyVNsfEq2QidaaQpXEgLCEVgdJNnc4DMmmyOusIb9CpDKYMXnCgiJn7zpPy+Um6mffR GlXKCGUURCujwqLCIkGxQHqaaUmQMSlqI5/O83re8D9HSPzkZlQ8aVt50Hu2feMx17ke4rfn 6KVaSs96W7Wah82jr4LS4vr7srU5jhTZZMHgXlmNbs6WdNhql8bvadwesOqZLdKtYm+2bnEn /Fw3rG7VyxPjVDnB8qFild1vUUj7+3uX7ObNt8oT3y075NJ4KjR1da4cU9C8Y0HSHSFFdOGu 5S0KSkhVK1eRBkH9FxHzKkoGAwAA X-CMS-MailID: 20200910193436eucas1p13dd91d9668b6bd61dd3fd734dc51fae3 X-Msg-Generator: CA X-RootMTR: 20200910193436eucas1p13dd91d9668b6bd61dd3fd734dc51fae3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193436eucas1p13dd91d9668b6bd61dd3fd734dc51fae3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 08/24] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..fe9d8e0a5 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -326,8 +326,10 @@ check_port_link_status(uint16_t port_id) const char *dp = (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + printf("\nPort %u Link Up - speed %s Mbps - %s\n", + port_id, + rte_eth_link_speed_to_str(link.link_speed), + dp); return 0; } printf("."); From patchwork Thu Sep 10 19:33:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77229 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D82A04B5; Thu, 10 Sep 2020 21:35:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F8361C12C; Thu, 10 Sep 2020 21:34:41 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 885931C129 for ; Thu, 10 Sep 2020 21:34:40 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193440euoutp0168c5393a98529cf2285c0cccab88bd5f~zgyNASWOc0325703257euoutp01I; Thu, 10 Sep 2020 19:34:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193440euoutp0168c5393a98529cf2285c0cccab88bd5f~zgyNASWOc0325703257euoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766480; bh=zr14D0fDL7SjhFN+jVIm/DVAQiqOuCvoeH8ErtcPSmA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=k5OCEvcemQs2vgE8OW7K2CltRfVmqRul4FLOrWLRTB79bsVJwLkx7/axUeG8215B5 WMFFFm/v+UWq1i8pNFxyGswIlFsUJ3MXjDHwco0k7fMb+4KVCvl28UVII4lyk4X1rC bgznKhtgitrsLkSFTML2riyX/R0MqtnHa1cM6/88= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193439eucas1p2db61e764fb95a4e8b484f241ecd884d9~zgyMzUIc81147811478eucas1p2l; Thu, 10 Sep 2020 19:34:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 81.1D.06456.FCF7A5F5; Thu, 10 Sep 2020 20:34:39 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193439eucas1p18263bdec6cef7f5790fef06338888528~zgyMVwmjU2934729347eucas1p1M; Thu, 10 Sep 2020 19:34:39 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193439eusmtrp1ab8e30714200fd52460daa4a9c3915c2~zgyMU6Adc3165331653eusmtrp10; Thu, 10 Sep 2020 19:34:39 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-99-5f5a7fcf0e24 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BF.8A.06017.FCF7A5F5; Thu, 10 Sep 2020 20:34:39 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193437eusmtip2499c9744b5c392e3a7e557b7839326bb~zgyKhy6LP1654016540eusmtip2A; Thu, 10 Sep 2020 19:34:37 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:42 +0300 Message-Id: <20200910193400.15326-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTdxTHc+69vffS2O1ajR510dgE4xM1mniCU5xZtjtdsv1hYoIgVrmi ESq24mNZMgZaXOmYPJwOtooCgmBEobwUDJbJq7hqfUGogsTF4CYCUiMC2ygXs/++38/5nt/J OfmJrD6Tny3uNR1UzCZjrIHXcpWNw55lnu/Co1acSV9BpW0OoJ4neSx1Zz3mKbX/GEPtxWFU W/WrhjK6EhlKyxhgqKrIxtPf3Ukc9Q1WMeSrcwuU7U0SaND1XKAfPTlAz0dfsPRL7msgj6NC Q8M3r/H0avQ8R2nvHgD95GwGarIPcJRVUw1ktUnUf7FQoDzfXBrsbubI3VEu0CX/XZYq2saA 0ptKgW5b/9VsmC+/yy3QyHm1vYycee4uKzd2/CzI9hYHI1/tq2bkVzce8HKasxjk1p5UVi55 9pb/Whuu/Thaid17SDEvX79Du8fX0MXEdwUdcV4vEBLBL9hAFFFajUX5c2ygFfVSEeDAqRug miHAtnIvq5rXgP3ljez7jje/b1V5IWCKx86oxg84nHpqPBQk8tJCdJ9wTBSmS1d5rBp9xAQK 06TP8J53RAhoTgrGhrLrfEDrpFC0d9ZCQKM0D0uu1E9MCxrnT32RAayX5uKjs0MTb6J0R8TO 5GaNmv8Ub9X4BFVPwxdNzkn9Eboz7ZzakAKYXlkuqOYkYHLOy8lUGDr/+mPiGqy0CEuvLVfx J1j4pIZXV/4A219ODWB2XGZUnp68hA5PWPVq2oD1Ld5JjDg2MkXFMtY9vKVR71MH2HrMxZyE edn/z8oFKIaZSoIlLkaxrDQph0MsxjhLgikmZNf+uDIY/6ruf5oGq8Hv3ekCSQTDFF19aHiU XmM8ZDka5wIUWcN03cbb7u16XbTx6DeKeX+UOSFWsbhgjsgZZupWne+N1EsxxoPKPkWJV8zv q4wYNDsRImBs1uUfSPREZF7IH5UPb+rlvuRrt8DILuvjnpDNNqk9uGFHXvb3Gz8XfqM7w/O3 Pa1I4mLu/1m6Nt5sXftt3+7uJZ3+RR9umrX9wEIDk7w02nwl4otVWWH3zy6YsdPRGiwd32fS 34vefTxyXUnLuZKWjtXrZiRnrflqc1nopZShhzcNnGWPceVi1mwx/gfMAAQfpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zds4mTk7T6CRltW4SOt28vZqZVMShT0EfCrvY0MO0nJOd GdaHNLGUeWtq0o1pySovVNbykjOmhlozJM1SXLpMkqwsL1maXbZG3348z3t54H2FuGSO8BUm p+o4baoyRUp6ELbfXSOBvZlx8cGlF73gbo8RwdhIFQ6Osjck5H/NwWCwZgdYGq8JoGQ0C4Oi kmkMGm/rSfjkyCZgaqYRA3urjYIrfdkUzLRPUFDYexXBxNIkDpcrZxH0Gh8KYKHtEQlflm4Q ULQ4gKDY3I2gq2CagLLmJgTn9TR8rb5FQZXdD2Yc3QTYhh5QUPftBQ4Pe34hMHTdRfD8/B9B 7Hp2sdIkYKssHzC29PoLnO0cKqfYgqdGjK2fasLYL48HSLbIXIPYZ2P5OFs7/oPc5xEni9Zq 0nXcuiQNr9suPSQHhUweCTJFaKRMHhJxJEoRJg2KiU7kUpJPctqgmGOyJHvHKJY2Ksowt5io LPSN0iOhkKFDmfknB/TIQyihTYipv/aMcOsM83Ec1yORE72ZpVd60l0zi5ic3s5/Bkn7M7Y8 I+YyfOhhkunPPUu4DG96D9Pf95NyMUFvYjrut5AuFtNRTMGwBbmnrmVq71lx1zKRU39rP+KS JXQyY+yZF7jZj3ldMYddQF6VaFkN8uHSebVKzStkvFLNp6eqZAka9X3kvHhD54K5Cemn9rcj WoiknmJrVFy8RKA8yZ9StyNGiEt9xDuf245KxInKU6c5rSZem57C8e0ozJnPgPuuSNA4/ydV Fy8Pk0dApDwiJCIkHKQrxXl022EJrVLquBMcl8Zp//dhQpFvFjrwedBsPb3FvKlDX201LW9p upRbL/L3ZIc3vF6tm292HK+bWWHNVwW/DP8orR/IjHY01OVOW76nFRe8c1gMh7y3tb6/M6Z4 sMqqs7beUC2MbFkzKd8YYNG9OnHmZ1DbdcXZgP69uOjg8fGK2JurrEElm6MzfHYbssJ3BRae W15+2E9K8ElK+VZcyyv/AmfnASkHAwAA X-CMS-MailID: 20200910193439eucas1p18263bdec6cef7f5790fef06338888528 X-Msg-Generator: CA X-RootMTR: 20200910193439eucas1p18263bdec6cef7f5790fef06338888528 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193439eucas1p18263bdec6cef7f5790fef06338888528 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 09/24] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..f77012eb9 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,12 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Thu Sep 10 19:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77230 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5556CA04B5; Thu, 10 Sep 2020 21:35:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAE621C134; Thu, 10 Sep 2020 21:34:44 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1801A1C133 for ; Thu, 10 Sep 2020 21:34:44 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193443euoutp025a58f4f6d2b47a0b2cb4f43fb2f6cbba~zgyQjPBo20499204992euoutp02b; Thu, 10 Sep 2020 19:34:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193443euoutp025a58f4f6d2b47a0b2cb4f43fb2f6cbba~zgyQjPBo20499204992euoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766483; bh=0UwttxWlMNSO6zvpNf9yvDxpqBtUhn2OurscN38uKVo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=tR8BhaHOje74KyD7bdYWXOqOqXEGbDch44BdYsYzRL8B+a+E7ZZXvAQuvH+wmY4jA RvIVu+yz8zzmTGMJu4GMchxOyXBxFbTZSmCBVXDRdWQK3gkxUXXB2ITrgU6s9tIAe5 LF2umKdTA9Pu0bruPfEdgg+uvE82jiHQ51bWTLEU= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193442eucas1p1ad8c160525e8de590a248a00960ec884~zgyPjKKWy2933229332eucas1p1H; Thu, 10 Sep 2020 19:34:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8C.D5.05997.2DF7A5F5; Thu, 10 Sep 2020 20:34:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193442eucas1p14b936dcafe61c23d23cb6e99aa934768~zgyPCuP0r2935729357eucas1p1y; Thu, 10 Sep 2020 19:34:42 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193442eusmtrp11cedea6751416af7b100a6d427fd015d~zgyPB46eS3165331653eusmtrp11; Thu, 10 Sep 2020 19:34:42 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-a9-5f5a7fd25939 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D1.9A.06017.2DF7A5F5; Thu, 10 Sep 2020 20:34:42 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193440eusmtip2f1d6c0781cc485ca50881adcf24462d5~zgyNQ0ZBt1654016540eusmtip2C; Thu, 10 Sep 2020 19:34:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:43 +0300 Message-Id: <20200910193400.15326-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wUZxTFvTOzM8PqNtORhCtFqJOaWKNiK6ZfTINIsE5iGhuNbUKidJUR jCzqDuAjMRKkPJYVEWhRMFtk0yLQlIcLC0QNEgXsglSaDRCRoqEQX6AILSCPsswa/zvnd8/9 zv3j42kxj/XnD8cnKOZ4Y5zE6pm6lqnO9V1nI6M2ZhasJ5XtNiBP+u00Gch/xJKsV6kU6Snf Sm44r+hI7t/JFMnOfU0R5zULS14MpDBkZMxJkb6bLo4UdqVwZKx5mCPnO4uADM88o8nl4jdA Om21OjJ1u5ElozMlDMmedgO54GgD0mp9zZD8hnogaRaBvCor5Yi9L5CMDbQxxNV7nSO/TTyg SW37LJCLrZVAOtLmdWGr5OniX3Sy/cZTSs67+oCWW3p/4mTrPRslV4/UU/LoLTcrZzvKQf7j SRYtVwxOst/oI/VfRitxh5MUc3Do9/rYEns/e8yy8uS/U3eYZLD6WcCHRyEE53ofUhbQ86Jw DbAqvdprxgH/etTiNW8Ahxr+Yd6tzJYNegelgGWDmYxmJgDz346DJ8UKa9CVYVtM+QrVLDpn uinPYLnwFQ7X1Os8mhFW48MrlkVtELZg1lC1TqsIwoqqJtoCPO+zwB/37fNgUQjE7p/HF99E oZ3HAusIpeUjsDS3jdb0cnzW6uA0HYCuPCujLaQDXqy7zmkmB/Bc0Utvais6nt/nPG208ClW NgZreBv2j2YtHoHCB9jz8kMPphdkbl2BFxswI03U0hI23evyYsTZt8s0KePQ5Nfa9TcB3T1H ciCo8H1TMUA5+CmJqilGUT+PV05sUI0mNTE+ZsPBo6YaWPiqrrnW8XponDnQDAIP0jJD05bI KFFnTFJPmZoBeVryNYR3uPaLhmjjqdOK+WiUOTFOUZvhI56R/AybSp7uE4UYY4JyRFGOKeZ3 U4r38U8Gxxp2qfr70j04verc8+PBL3bkXdrsji6c/9MmhaXP50x0r6tYcelWx8CZ75ZE7AwK yPA/tDd2bqgjND/kh+jUkBM1SfunxL2m+/J/vuErf53fHfPFrk8GHfa24R97S3ascEqrDS3u jcdrUzZtF5d8LBWtC0rY1hA4uuvbPZPhEXcyI6ruSowaa/xsLW1Wjf8DJRTyV6YDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSeUhTcRzv965t4uq1Vj6ErkUUUrNNza9idpD16J+CIMqyNfKhonP23tbh P007jKdZWkSX09QuC6amqaExD9SadhiW4pHaTDrwNlPMmo7++/A5vt8PfL9SXDFBeEtj4k0c H6+PU1EehGO2oXtjy9lw3aYHozKwNVkR9HXn4dBzvYuC1OHzGLQVbIXKsrskZH62YJCeOYJB 2SORgp89yQQMjpZh0FnlkMDtlmQJjNYMSODy2zsIBma+43ArZwzBW2spCVPVLygYmsklIH26 FcGVkkYEDWkjBFyvKEdwUaRh+PFDCeR1roDRnkYCHO3PJPB04j0OpU1/EGQ02BA0X/xLblvN TufcJ9m8ym8Ye+3ee5ytb78hYdNeWTG2aLAcY4detlJsekkBYl/3peLsE+dvap9HuDqEN5pN 3Kpoo2DaojqsAa1aEwRqrX+QWuMXGBGsDVD5hoZEcnExJzneN/SYOjo3r5tKEJef/jVVR1hQ mpeIZFKG9mf+PHZiIvKQKuj7iKmquE2KSOoSGOaHE3d7ljAzH0XK7RlDzM3BCWJOoOj1jOOS dT6spDso5kNK0rywhN7FDBSXk3OYoNcyHXfFeSyng5nUr0Wke+pK5kmhHZ9bJnPxvZ0Rc7SC jmGsTb9IN17BfMoex66ihTloQQFScmbBEGUQtGpBbxDM8VHq40ZDMXKd/Hn9VEk5Egf31yBa ilSecntwuE5B6k8KZww1iJHiKqV8R7PjqEIeqT+TyPFGHW+O44QaFODql4F7Lz1udD1QvEmn CdAEQpAm0C/QbzOovOSX6OojCjpKb+JiOS6B4//nMKnM24JW7e211822XMjccsCSeNB8ri0p tMmQ77dLeSLm2fZu5fZE0TY56cxYyn/pD1v0d8+b2A8l1lR7f6FPStEyoaU+7N2tDsj1rEvJ yT9SK3sadW44eUCVbbAsbnYeOugz3rVhJ7+79JTFc3aNNmxda36WpSNrfVmtV9vCvsm0G3G2 MUxFCNF6jQ/OC/p/TU6QiQgDAAA= X-CMS-MailID: 20200910193442eucas1p14b936dcafe61c23d23cb6e99aa934768 X-Msg-Generator: CA X-RootMTR: 20200910193442eucas1p14b936dcafe61c23d23cb6e99aa934768 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193442eucas1p14b936dcafe61c23d23cb6e99aa934768 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 10/24] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 13 +++++-------- examples/l3fwd-acl/main.c | 13 +++++-------- 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..c7348bee5 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..6241c9824 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..e773d3586 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77231 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDFE1A04B5; Thu, 10 Sep 2020 21:35:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80EE31C190; Thu, 10 Sep 2020 21:34:49 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A32871C190 for ; Thu, 10 Sep 2020 21:34:47 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193447euoutp02d0b5db8cc1f5e3ec37186b1809f88c8d~zgyT25v350501005010euoutp02W; Thu, 10 Sep 2020 19:34:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193447euoutp02d0b5db8cc1f5e3ec37186b1809f88c8d~zgyT25v350501005010euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766487; bh=FVrECeLodo2mEpIyUJqIc0xB0igSGcYvhVqWSW4kZ3c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=oa4Wyi4OA2fsM4CFAx3e5FWtdgUUX5xCp8/p2TUiIvrCFKEpB8+Fl2E0h4ZHcbPu0 JkDQvSvM48QZp5Mc+G8k4We55z1omKXicRgtURwO78q8i6DgQZ4WyXMOLFKTAx2eVT W5Et4okcdn4fkCxUFs10yQw+aSobZrPeMCcfUlfo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193446eucas1p2074223af8dcf7bbc002935aea6f5556b~zgyS5qGe02619226192eucas1p2e; Thu, 10 Sep 2020 19:34:46 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CE.D5.05997.6DF7A5F5; Thu, 10 Sep 2020 20:34:46 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193445eucas1p2f16b04c5940d3141916b69ab97392a41~zgyRy4gG22618526185eucas1p2e; Thu, 10 Sep 2020 19:34:45 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193445eusmtrp1103fdf91c4243bad2dd7ca0eba18024d~zgyRu4FSD3165331653eusmtrp12; Thu, 10 Sep 2020 19:34:45 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-ae-5f5a7fd632fa Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F3.9A.06017.4DF7A5F5; Thu, 10 Sep 2020 20:34:45 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193443eusmtip264f2f99b283f6ee9801f62cf7709cf04~zgyP8cAG01654016540eusmtip2D; Thu, 10 Sep 2020 19:34:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:44 +0300 Message-Id: <20200910193400.15326-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSWUwTURTNm5nODJWScTD64sLSaKIYcY/XJYLGj/FDJXxIRAGrTKARirbg 9iNxQTZBwB1TWSRgMQEEyiIaxChgUQIChVgVFURQQBAMaFFbpsS/c8859557Xx5L8un0fFat iRa1GlWEkpZTxueTzSs6zgSGrCoonQtFTXoEH9/lktB95S0NSd/PE9Bp8IGaitsySH8fS0BK +ggBFQWJNHzrPkvB0GgFAZZHJgZutZ5lYLSuj4FLzZkI+qwDJNzM+oGgWV8ug8kn1TQMW3Mo SPnVjiC1rAFBffIIBVeqKhHEJXLw/V4+A7kWNxjtbqDA1FXKwP3xFhLKm6YQpNUXIXgZ91fm 6yn8ysqTCbk1/YSQkd1CCs+7rjFCcqOeEEqGKglh+HE7LaSUGZDw4mMSKRT2TNB+8kD5llAx Qn1c1K7celAe3vfG/Wgne/JqQoYsFqUyiciJxdw6nD3VhRKRnOW5AoTPZVtpu8BzYwgnPfSW hB8IF4xYiJmO0swOWhLyEc63thJSMY6wOW2ctLtobik2xeunhTlcCY0rrObpdlduDzZcyJPZ McUtwQl51ulFFNwmfMFwXyZFuOPC4lrbIJZ1svEfLEHSSm7YfGdseibmmlic87uYlvw7cFNV seMgVzxQX+bAC7EpI5mSGi4inGYsZaTisu3SzEGHyweXfX3F2NNIbhkuql5ph5jbht9/kUvQ BXcOzrabSRtMN14nJVqB4+N4aYYS1za2OmiMp347S7SADYOvHK/7COEnvSbmMnK/9T8qCyED mifG6CLDRN0ajXjCW6eK1MVowrwPR0U+QLafavpTP1aJqq2H6hDHIqWzonZTYAgvUx3XnYqs Q5gllXMU21+agnlFqOrUaVEbFaKNiRB1dWgBSynnKdbm9AfxXJgqWjwiikdF7YxKsE7zYxGz YdHX7BaF+enQzvAbi9dsXPHNo3+jh7ZtYCLUpeaTxt+Fv2RqHmrzWC30FLb0pnp66n394uXL /HuiLEc+ue1W+3nsOzGq3CUUxUZ/Duxt8zKj/eog//W7bu7ITfvZ6xu03MVZfdXr9QLDsYBn Acbg8vV7N/sI56uHeeMscvsB1V0lpQtXrfYitTrVP4nVm1elAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+93XrtLiMg1vklqrIIqubmYeLS2iP+4fBVZEYdoadlNpc7Y7 zWWRRr5m2UMrsliW2Ewle2haaekCH83oIZbzlVlgllkui5T12LT+O3w/3+85B86hcdkE4Usn JhkEfZJaI6c8Cdvv1oEVXUeiVUGPyjGo7jAjGBooxWGwqJ+C/K/HMOiuWAsNdZdIOPMmA4OC M+MY1JWbKBgdPErAmKMOg75GmwSKXx6VgMM6LIETzy4iGHZ+xOFCyTcEz8y1JEw236fgi/Mq AQVTXQhO1rQhaD0+TkDRvXoE2SYGvl63SKC0zx8cg20E2Ox3JFD1/QUOtR2/EJxurUbwNPsP uW4hP1VSRvKlDSMYX3jlBc632M9J+OPtZoy/NVaP8V8edlF8QU0F4p8M5eN85fufVJRnNLdG r0sxCAsSdKIhQr5TAUpOEQaccmUYpwgOjQ1XhsgDI9fsETSJqYI+MHI3lzDcG5DcTaedzSsk M9BJiQl50Cyzkr1z8RVlQp60jClDbGb/RxegXYBlP73HZzxerPOV6Z/nG2IbqjKnwxSzlLXl mjE38GZ6KbYzJ5NwAy9mE/u8+jzprglmCZtX5pwOSJlwNquiipzpGsBW3mzC3cM8XPrbvli3 LGMSWXPHD3Km9mdfX57ATqE5JWhWBfIWUkRtvFZUcqJaK6YkxXNxOu1t5Lr43ZbJmnpkGttq RQyN5LOlTeHRKhmpThWNWitiaVzuLV3/1LZLJt2jNh4U9DqVPkUjiFYU4trvNO47N07n+p8k g0oRogiFMEVocGjwKpD7SHOZ5hgZE682CPsEIVnQ/89htIdvBsqKrKEtiz8fqnbcWN7Ox27Y zm3M8UpfrRJ2ODobo9SZnb7dxZVbxBHjO6I793Hh5Q+phjrRvtee5TPvhvWED4zErR0NnCIm auMT/K5tfiDrSbcdLlAcSJbt+v5aG9Pg73dek7HImWXsseTnbb45prJbIuLEFo7fv/HUtrSg +Q/khJigVizD9aL6Lx8hcMMHAwAA X-CMS-MailID: 20200910193445eucas1p2f16b04c5940d3141916b69ab97392a41 X-Msg-Generator: CA X-RootMTR: 20200910193445eucas1p2f16b04c5940d3141916b69ab97392a41 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193445eucas1p2f16b04c5940d3141916b69ab97392a41 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 11/24] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_speed_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..cf3d7d462 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -273,7 +273,7 @@ print_link_info(struct link *link, char *out, size_t out_size) "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" @@ -287,7 +287,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + rte_eth_link_speed_to_str(eth_link.link_speed), stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Thu Sep 10 19:33:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77232 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0A5CA04B5; Thu, 10 Sep 2020 21:36:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B84411C191; Thu, 10 Sep 2020 21:34:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0B8A11C190 for ; Thu, 10 Sep 2020 21:34:49 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193448euoutp01de71426e5b76f0752331150a62258184~zgyVJb2L23152731527euoutp01s; Thu, 10 Sep 2020 19:34:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193448euoutp01de71426e5b76f0752331150a62258184~zgyVJb2L23152731527euoutp01s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766488; bh=2wNIFYHcmh4yCYEREX5OuVKRLboLxAKCyymFOQAhjOI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=OxUjp50ZjcjBb9u6+M5P5EL7GiTvuJckPwxFkLH/4mEc5rHtw6Fh0xpwYeSIT626W rgmB5kQg91pPbnK2JywCGJ1G1wYAWyKOKC8ec10VcZJJadKrsPsVVvHszboaEEPo3H 5klHpHZteTsn2kfHQfUsZ/y5d9cX3RTuvOQPDEcI= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193448eucas1p25a6d770323d5ba1de9a6f3c2e5b8fcc3~zgyU0LURX2394423944eucas1p2t; Thu, 10 Sep 2020 19:34:48 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id F4.1D.06456.8DF7A5F5; Thu, 10 Sep 2020 20:34:48 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193447eucas1p1bd00314c0c7f7d8554c9207038017bd8~zgyUQvGws2936529365eucas1p1T; Thu, 10 Sep 2020 19:34:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193447eusmtrp1b8235781cd28a3060d61a04908ab4752~zgyUP8fb13165331653eusmtrp13; Thu, 10 Sep 2020 19:34:47 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-a2-5f5a7fd84ade Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 16.9A.06017.7DF7A5F5; Thu, 10 Sep 2020 20:34:47 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193445eusmtip25e27aa38f9c60717a362657a27f79b90~zgyShdpj41532615326eusmtip2T; Thu, 10 Sep 2020 19:34:45 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:45 +0300 Message-Id: <20200910193400.15326-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+69vffS2eWu1HnmjGx1MxMjzrgPJ2SZzOzDzbJEk2UmEhTL vAG1IOkVN/dhdrgwLAWloGTAuirbwGKGjBZYI4ZhBFwtL1UmLmWr7qXDDRGUTR3iKLdm357n d57zkn/+Ims8xi8VdxXsU2wFFquZ13PtvfcH1owezMx++XJgMbVccgPd+KmBpWj1GE9ltz9m aNS7gc521OvI9bOdoQrXFEMdTQ6e/ooWc3RruoOhSFdQoNpwsUDTPTGBygfrgGKzN1n61HMH aNDt19H97wI8Tc6e5KjiwQjQEV8/UJ9ziqPqbzuBShwS3T7VKFBDZDlNR/s5Cl5rE+j0zDBL /ksPgSr7WoBCJY90Gc/LDzxf6uSGs+OMXHVimJV7rx0XZOdFNyO33upk5MlzI7xc4fOC/P2N MlZu/vUev1mfqX91p2LdtV+xrX1thz6vtDoiFF7Xv38o1s7aYUh0QJKI0isY87QxDtCLRqkJ MFZVK2jmLuCAZxI0cwcw5O0UHreccAV0WqERsOmfSk4zM4DRqQkunuKllzBY6l4YbJJaeeyY vcrEC8nSJvzttJONa056Ef8YrFloMEjp2F9/HLQVKdh8pns+I4pJ8/x6ZFscG6XlePXzuwsz Uboi4ojPmTjpDXQ3zSR0Mt7s8yX0MgxWOTmt4RPAyvY2QTNHAQ/VTSRSG9D354AQ38ZKq7Al sFbDr+PceRcTxyg9iaMTT8UxOy9d7TWshg1YWmLU0mbsvhhOYMSH/y7SsIyRXy4n3rcL8ELI yx6FlNr/d3kAvLBEKVLzcxV1XYHyXppqyVeLCnLT3t2b/w3Mf9bgXN90J8yEc3pAEsG8yNCd nplt1Fn2qwfyewBF1mwybAwFtxsNOy0HPlBse7NtRVZF7YFnRc68xLD+5Pg2o5Rr2afsUZRC xfa4yohJS+2wJbl4Trqg27z4BX9a6saM1q9X/r3KWh/7sZRLLxzP6P4hMmb1N4dySqbKfs86 vGziiafPOd78sKo4+txhP2vJ6Y2aso457XmrV6eY1HBF10fO1K82rYDI0NAze46Ur3jrnawt dV8YTFcejfmVQE357iR79dbG8s/aVs4eXH9vzdvD2WEzp+ZZ1qWyNtXyH3s6bWKoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d3cdzS7L6CL0GkURNZuPPC57G93+KKKsPzSdSy+b5Dbb 3TSDylaoTbPyMctsWiKV5iPzGSU5yFlT7KUlmU4R7IWZZbSwx5b03/d8P+cF51C4ZJoIoJJ0 Rs6gUyVLSRHh/O0YWvPqZLRybWetHOq6bQhGhypwcBW+JSFn8gwGr6s2wf2WUgHkD2dgkJf/ BYOWmxYSPrnMBExMtWAw+MAphJLnZiFM2ceFcK73CoLxmQ84XC7/iqDX1iQAd8c9Ej7PXCcg 72cfgvONXQgcuV8IKGxrRZBpoWHy1g0hVAwugilXFwHOgbtCuD39DIem7l8ILjrqEPRk/hFs Xsr+LK8UsBX332NswbVnONs5YBWyuY9tGHtnohVjP7f3kWxeYxVin4zm4Gz12A9yjyhaFmHQ m4zcEo2eN26QxsghSCYPB1lQSLhMHhwWqwgKlQZujEjkkpNSOUPgxniZJrtwUJgyIjp6erwZ z0BPKQvypRg6hLmWf09gQSJKQlciJst9yRNQHsAwH8fw2Zx5zEy/hZzN+YoYR00j5gUkvZJx ZtswL/Cn35DMi6xThBfMo3cxde35Qq8m6OXMu97if76YVjBdpVY023UxU13/EPcO8/X4I4Ox XltCJzG27u+CWb2IeVX2DbuA/MqRTxXy50y8Vq3lg2S8SsubdGpZgl7bgDwnb+50N7Yiy8Q+ O6IpJJ0jfqiIVkoEqlQ+XWtHDIVL/cVbe5xxEnGiKv0YZ9ArDaZkjrejUM9+F/GA+Ql6zwPp jEp5qDwMwuVhwWHB60C6QJxNdxyU0GqVkTvMcSmc4X8dRvkGZCCzZPqXuKenzGjFqfC9hw23 cs4q43fMVL/PLDENF71Qt5WUxMW7llnX+2yJGu5sME+2xRwp6Msat+5vuTNanfio3//C4mWK 7WWpK3KvPk5/uWF/v3t1x9WCCL/Ipj8L64/XFGmHdT6bZHPtRR/th05EnQ2p3b05Zue2A5Ga raVpabnFUoLXqOSrcAOv+gsMuM1JCAMAAA== X-CMS-MailID: 20200910193447eucas1p1bd00314c0c7f7d8554c9207038017bd8 X-Msg-Generator: CA X-RootMTR: 20200910193447eucas1p1bd00314c0c7f7d8554c9207038017bd8 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193447eucas1p1bd00314c0c7f7d8554c9207038017bd8 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 12/24] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..e478fe359 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77233 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65165A04B5; Thu, 10 Sep 2020 21:36:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DCA01C198; Thu, 10 Sep 2020 21:34:53 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D54E31C198 for ; Thu, 10 Sep 2020 21:34:51 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193451euoutp020939410a1c0323d870120fe32e3aa63a~zgyXzt90T0500705007euoutp02Y; Thu, 10 Sep 2020 19:34:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193451euoutp020939410a1c0323d870120fe32e3aa63a~zgyXzt90T0500705007euoutp02Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766491; bh=V+UhUmI0wX9EPRjnOZ4RF5aTByD1DePKpjF9zRdOzyY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=YXJTt42wX6NGUZaw4DhoGOz8vBwAe0rFSk83KxQcc1GED4o8H0t3risT8TvjzgDxo 3FNGPTI/tAuMyK2PnFe7m8UCy1DQU3d+UpEYxrDcRwg1mhEfMcgaFFNFrI/ecGzpoK LugusfzkOUVsr+3RHl3/1A0g+O2Eqgk5Mwlqw5Tg= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193451eucas1p166d28d4d1a506774a7e50b4e61e58a5b~zgyXVSqq60510805108eucas1p1r; Thu, 10 Sep 2020 19:34:51 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 17.1D.06456.BDF7A5F5; Thu, 10 Sep 2020 20:34:51 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193450eucas1p18f1f4f7ff450392368409b7e1fb236cf~zgyXAmNqM0308403084eucas1p1q; Thu, 10 Sep 2020 19:34:50 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193450eusmtrp1622afaddea1c40eb51a90e36de7f223d~zgyW-n7GU3165331653eusmtrp15; Thu, 10 Sep 2020 19:34:50 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-a6-5f5a7fdb9638 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 41.19.06314.ADF7A5F5; Thu, 10 Sep 2020 20:34:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193448eusmtip24bef514e9456b83245e9b20d34bdd681~zgyVKFlIN1532615326eusmtip2U; Thu, 10 Sep 2020 19:34:48 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:46 +0300 Message-Id: <20200910193400.15326-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwbdRjHfe6ud0dDza1bxuNmWGwylSVsEo15si3bNM5cjCGLfygSGNZx drO8pTc2mTEiGphQ6kaJC0NLB1l4M3SDQoEAY1XHxo0hJMhQUMSXZeDeCkRgMKXrLf73fD/f 7/N9kl9+Imt28xvEQ1mHFUeWNcPCG7m2S4uD8T9/nJz23EQVS76rHqCpX2pYmiyf4Knk7mcM XW/YTV2BrwxU9ms+Q66yewwF6op5+nuygKPboQBD492aQKeHCwQKBW8IVDpYCXRjeZqlCu8s 0KCn1UCLFzt5urNczZFraQToC/9loD7nPY7KO9qBCoslultfK1DNeCyFJi9zpI21CPTN/BBL rVdXgE72+YAGCv817HlKXvKeNcg1XTcZ2X1miJUvjX0pyM4rHkY+f7udke/0jPCyy98Acv9U CSs3/rHA7zMmG3emKxmHjiiObbveMR5cadmR84/0wWRTK58PQVMxRIkovYB/fl3OFoNRNEt1 gEWVdYaImAN0f9ehi1lAraxZeLQyGpqFiFELWFjl0sU8oGeh1hBO8dKzqB33MGFjnXSex8Dy KBM21kp7ccY5y4VnTtqM3ooaNjybpO3Y3eLVT2zCxnO9q1wUo1b5b+OpYWyWYnG0au5hJ0o/ iDhzv+BhBqVX8POOo5HVtTjd59drnkTN7eQi+SLAk20tQkScAPy08pae2o3+mWtCuIiV4tDX uS2CX8Lmn/r1/sfx+q01YcyujmVtp3RswuOF5kjagr1XhnWMuHI/OoJl/P2sX3/EbsDFhYBw Ajad/v+WF6ABYpRcNdOmqAlZytGtqjVTzc2ybT2QndkMq19Ve9AXaof54XeDIIlgiTb1bk9O MxusR9S8zCCgyFrWmV4e0PabTenWvGOKIzvNkZuhqEHYKHKWGNPz1TdTzZLNelixK0qO4njk MmLUhnxoTOja0hNVPsE6o+vj1++Tpb32uKfrvx1w73o/780d3Suv7UmKfW96JOdMySfXXl/v 3PzWWGlSf47W5P6x+tWlpAuPPePj/XNzU+yptytS04diUlxLmnfRVzQ2/ETiheW4TjtstD+w 23x/lX6Ukp3Y88aaA4kvfqg2ZeTZdn5/MeVYcryFUw9aE7awDtX6H+78QeWmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSfUyMcRz3e57nnruay9NV81usclvexnG96FuI2djjD9OQP6Jy41HR3eWe u6Y2pLXkJL15t3NpFnlJby4SdabSZaFdlFTSNBLVHapF7jT/ffb5fL6f72f7fkWkxEZ5ixJU Wk6jUiRKaVfK8qepZ3nXsajYldmDS6Cs1YCgv6eYhL7C9zScGskg4G3pOnhkuiKA/N40AnLy Rwkw3dDT8LUvnYJvYyYCuussQrj0Ol0IY+ZBIZxuu4xgcOoLCReNNgRthmoBTDQ8pOH71DUK ciatCM5UNSNoyh6loPBBDYJMPQMjN0uEUNztA2N9zRRYOiuFcPvHKxKqW38jyGsqQ/Aic1qw fgE7abwuYIsffSbYgqJXJNvYeU7IZj83EGz5txqC/f7YSrM5VaWIbek/RbK3BsbpCNco2RqN Wqfl/OLVvHatdJccAmTyUJAFBIXK5IEh0WEBwdIV4Wv2cYkJyZxmRfgeWfzvytVJv5jDfXer 6TRkFuuRiwgzQfjNmA05sYS5jnDtxGI9Ejl4jIcGyBmLB57q0NN65Oqw2BD++DSTcAo0sxhb sgyEU/Bk3tG4/cRxyil4MBvxULbtH6YYf2y8WPwvScyE4bpKo3Am1RffuldPOpe5OPgP3dEz HRKwofWnYAb74DdX7UQucjOiWaXIk9PxyjglL5fxCiWvU8XJ9qqVFchx8PuNE5U16HX5djNi REg6W1wfFhUrESiS+RSlGWERKfUUb3hhiZGI9ylSUjmNOlajS+R4Mwp29Msjvb32qh3vo9LG yoPlIRAqDwkMCVwF0rniLKZht4SJU2i5gxyXxGn+zxEiF+805Bbjl1v75KaXfVHtyW671UPS VrA8viPQ3iDq97jgpj5q3PKp8Kwtwx/Pkd4/JyQGDlg3J84v8Zlj9L8daTTtUOkEGlPEVvdD XXe0E+2S8Q7f47ntqXX750HGomdXrEW9l+3uW1+eN1lLtg0Ob2oJXTjN0T/3PNYeGY7MXabd WVEvpfh4hXwpqeEVfwG9UkgbBgMAAA== X-CMS-MailID: 20200910193450eucas1p18f1f4f7ff450392368409b7e1fb236cf X-Msg-Generator: CA X-RootMTR: 20200910193450eucas1p18f1f4f7ff450392368409b7e1fb236cf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193450eucas1p18f1f4f7ff450392368409b7e1fb236cf References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 13/24] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..49d888064 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +714,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_to_str(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Thu Sep 10 19:33:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77234 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3A0AA04B5; Thu, 10 Sep 2020 21:36:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF9B31C0CD; Thu, 10 Sep 2020 21:34:55 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 71DC21DB8 for ; Thu, 10 Sep 2020 21:34:54 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193454euoutp01034630a2f15b24c7d0e1deb157047aa7~zgyaOZksX0325703257euoutp01J; Thu, 10 Sep 2020 19:34:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193454euoutp01034630a2f15b24c7d0e1deb157047aa7~zgyaOZksX0325703257euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766494; bh=O0RMdSfG+AOCpq5MldeMzJL75/V6GLjvklL2HbHCXdQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XmeMvuO4PtCIdpg6/ilnXJCjcORL6MPEsCHGODfGWt6xoyDE8uECkHCofY0EjLCwf Un8kci1Vdt4dE5yirkgHDZo8WTCTxrlUWtKiHcSDFBqJs/4+r+h33WQUXGbtlMQ3Rf nMERjj/ws0SgGbMTu13K9ydwWXl7gyC4BR7LWytE= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193453eucas1p2be15c36f4f7a247dfabee57b5d03dd6f~zgyZ5X7Da2392123921eucas1p2w; Thu, 10 Sep 2020 19:34:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 81.E5.05997.DDF7A5F5; Thu, 10 Sep 2020 20:34:53 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193453eucas1p1cccb329ab81bbe3c6c0d5ec5f6bf1ec9~zgyZhdfmp2933229332eucas1p1N; Thu, 10 Sep 2020 19:34:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193453eusmtrp1c043aa7d139aeeff56990d28a1de6f08~zgyZgph2m3165331653eusmtrp17; Thu, 10 Sep 2020 19:34:53 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-b9-5f5a7fdd26d6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 63.19.06314.DDF7A5F5; Thu, 10 Sep 2020 20:34:53 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193451eusmtip2da5219477dc4099671ddba523f441487~zgyXvtUOr1532615326eusmtip2V; Thu, 10 Sep 2020 19:34:51 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:47 +0300 Message-Id: <20200910193400.15326-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHd+69vffS0O1SWDxDprPZFpxRN+aHM7dMt+zD9cMyPxjiCA6q 3CAZRdICm4uJTISZCkyBaKSmFomD4jJ8KS/rhDCiBSwv06zBbiDMDTp0itSaCNYyyu2yb+f/ +5//Oc/z5BFZfR2fLOYVFCnmAmO+gddy7Z75kfXjBzOy3myoSqPWQTvQnduNLE3WjfN09OFh hm61bKErHac1VDNRylB1zRxDHc1Wnv6ZPMTRg2AHQ2NdXoHqbx4SKNgbEKhqxAYUCN9l6ZTj EdCIvU1D8z+7eZoNn+WoesEH9K2rH6ivco6juh87gSqsEj10NgnUOLaKgpP9HHn9lwX6/vEN ltoGnwEd72sFGqpY1GxdIy84zmnkxiszjFzbcIOVPf4Tglw5YGfkiw86GXm228fL1a4WkK/f OcrK5/96wm/XZmjfy1Hy80oU88b3s7V7vyu7yhZ2ab8cOTHIl8Il0QpxIkqbcPHen6wVtKJe agacODcoqCIE6Jg6HXMeATr7/YwVxOVIsGGnypsAT4bcnCoeAx7+7RpE5/JSKnqP2JmokSRd 5LEjPMpEjUTpExx3BoRozUmv4YL7p2WukzZjxdc+Vj3Uajx/oYeNbotb4n+M7YpivbQKR8+E lmei9IuIP/imBLX/I4xUeWLZRLzb54rxFPTWVnJq4BvA4+2XBVUcAyyz3Y91bUHXvWEhuo2V 1mKre6OKP8B5f4BTr/w83rqfEMXsUlnTfpJVsQ6PVOjVbgP2DNyMYcRnT+NVLOPAXFvsEbsA py40ccdgdf3/uxwALbBCKbaYchVLWoHyxQaL0WQpLsjdsGef6RIs/VVvpC/UCe7w7l6QRDDE 63o2Z2TpNcYSy35TL6DIGpJ0Hw55P9Prcoz7v1LM+7LMxfmKpRdWipxhhe7tszO79FKusUj5 XFEKFfN/LiPGJZfCgVcWZ1NWfno7pzh+9vXpUINvbfeBVzNrPV1t0383r0svTx8uWxMMTbyc HF5fUn1tYFPi79s9T17wt9TZ6rPLE56e2vlr+czBFxOG2+2mHanTO9KGip4bPZP2kvPjlK2F me+kb0t2otYW6c6MjGqSXN2RPM22bJcjI37MFuisvV6e+q6Bs+w1vvUGa7YY/wWFxoZUpwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSeUgUcRTH/c3Mzo7WxrAajRt0TAQmNTmr5tPKooMmSIgOMMu2RQeVXNd2 dksLyrQ228pyO6iMzaPTijItrbxLrVYRDS80tbKky2stSuzYxfrvw/f7ji+8R+HKUUJFxSUY RUOCNp4lPQj777ruBa8PRGj8hiq84W69DcHb7jwces+8JuHY0CEM2vOXQWnxJRlYe1IwyLAO Y1B8w0LCl95UAgZGijHoKrPL4WJzqhxGqvvlcKIxC0H/+CccLmQ7EDTaHsjgZ9VjEgbHcwnI GGtBcLLoOYK648MEnHlUgsBsoWHo5nU55HXNgJHe5wTYOwrlcPtbEw4P6n8hyKy7i6DB/Ee2 fLYwln1VJuSVfsSE0zlNuFDbcU4uHH9hw4SCgRJMGCxvIYWMonwkvHx7DBdu9f0g13tEcEsM epNRnBWrl4xL2a08qDk+GDh1QDDH+wdFhqgD2YWhS6LF+LjdomFh6A4u9lraMzyxzCOp8Vw9 mYLuUxZEUQwdwIzkhFuQB6WkryKm/ZdVNqEzzOc+3ILcnejJjLdayIkaB2LsXzLlLoOkfRh7 ug1zGV50J8m8OnKQcBmedBjTcPipzMUEPZcZe/wEc7GCDmHMB1v+TZ3J3LpXibuWuTv1N12R LllJxzG2+u+yCZ7BtF0exU6hKdnILR95iSZJF6OTeE7S6iRTQgwXpdfdR86LP6z9WViCmgs2 ViOaQuxkRWVIhEYp0+6WknXViKFw1kuxosG+XamI1ibvFQ16jcEUL0rVKNCZLxNXTY3SO/8n wajhA/kgCOaD/IP8FwE7TZFOV21T0jFao7hTFBNFw/8+jHJXpaA0vqBIbW6Oomu+zfPlAjfP KmldmxbeU/gmO9LBvsubVNEWr1FV3tk0bWXk6iy30ume7H5f88CcpDt++3eqrHsUR8KLQrec jaUdPg3BO4YXj6d2lrsNhaVcmX/A2rHOd43hUW7WmgWmXR+sh2rEig3n072/vlcfbXVw4aMP 9xU/XeXHElKslvfFDZL2LwWsFssHAwAA X-CMS-MailID: 20200910193453eucas1p1cccb329ab81bbe3c6c0d5ec5f6bf1ec9 X-Msg-Generator: CA X-RootMTR: 20200910193453eucas1p1cccb329ab81bbe3c6c0d5ec5f6bf1ec9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193453eucas1p1cccb329ab81bbe3c6c0d5ec5f6bf1ec9 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 14/24] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..820470db5 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77235 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CDA8A04B5; Thu, 10 Sep 2020 21:36:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07DF31C1A8; Thu, 10 Sep 2020 21:34:58 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 48B0B1C1A7 for ; Thu, 10 Sep 2020 21:34:57 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193457euoutp02a36860a6c0e9d322c743b51e9e733ccf~zgyc0kgaK0499204992euoutp02c; Thu, 10 Sep 2020 19:34:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193457euoutp02a36860a6c0e9d322c743b51e9e733ccf~zgyc0kgaK0499204992euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766497; bh=PBAyJH+AMK1xxIDr0X+5LdKR/8t0CIeYr6u1GtWAoJE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=nP2lhHio7pM27EbD9lslkTz8IC8YgjYyubdjDj9kWlo8dAo24wzzQCbyEckZfHHQU BFxeOrJBHfe/+xPwZZVYg5gK4WCuXndW2Td3g/H5Cyu0hujDhZiaX0dE9rifiSIWW4 Th57PyBhLvydwN5GKuCVBc4+aeXhDaXXTIiurcfY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193456eucas1p2aad10d35dd2a848a88ea3426226d77c6~zgycfQ_yb2535025350eucas1p2i; Thu, 10 Sep 2020 19:34:56 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 59.1D.06456.0EF7A5F5; Thu, 10 Sep 2020 20:34:56 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193456eucas1p25839dc5b17a0eebece4c7c0ab1e4dbbf~zgycF-hvW2616126161eucas1p2x; Thu, 10 Sep 2020 19:34:56 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193456eusmtrp1d67761e3b90c7adf241e6513ff300b65~zgycE4SkR3165331653eusmtrp18; Thu, 10 Sep 2020 19:34:56 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-ad-5f5a7fe00ccc Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 58.9A.06017.0EF7A5F5; Thu, 10 Sep 2020 20:34:56 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193454eusmtip25620693accc44896e02643293c6d13ab~zgyaR6ZxL1532615326eusmtip2W; Thu, 10 Sep 2020 19:34:54 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:48 +0300 Message-Id: <20200910193400.15326-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0wTdxjG895d747GzvM080UX3DoX0WQ657K9MQR1Meb+cNn23yTRWuGG BiimFdAt2Yhz0JSKUMkW24UxGgMDM2QiIAOtLLPqIQqK6MZccTJA/FGLNYIwR7ma/fe8n+d5 v0/y5iuycgW/SNxl26PabdZsM2/kms9NdL8Z+jLN8pbvt2XU0FUJdPuWn6VQxZ88lYQPMHSj bh21t3xnIM9fhQyVeh4x1FLr4uleaD9HDyItDA10aAJ5e/cLFOkcFujgZR/Q8NRdlo5UjQNd rjxpoImzbTw9nKrmqHSyD+hQ03mgoPsRRxWnWoGKXBKFf6wRyD+QRJHQeY60mycEOhbtYelk 1zRQebAB6FLRc8P615TJqqMGxd8+yiiHf+hhlXM3vxEU94VKRml80MooD0/38UppUx0oF2+X sEr9naf8R8Y0Y0qGmr0rX7WvSt1u3On8tRF2XzPu/XosvxDOii5IEFF6B28NNTIuMIqyVAt4 5XkJrw+PAc+MXI0744DunrDhxUptg8ugGzWA/V2/xFNRwOjkKSGW4qVk1JyVs8YCqZHHlql+ JmbMlz7Eo54zsyFOegOH/DWz2iStRd+BQV6vWIL1xwOsC0QxYYYPDmyNYVlKwv7vH8++idIV Eb3Xxxk9vxGfdJQLup6Pd4NNcf0KaofdnL5QDFjefELQhzLAr3z346l12DTWLcTaWGk5NrSt 0vEGvBou52MYpZfwxv15MczOSE/zt6yOTegskvW0GQMXeuMYcfrZHB0rWP/UFz9WB+BQzTMo gyXe/7uqAOpgoZrnyMlUHattasFKhzXHkWfLXJmem/MzzPxV7d9gpBWivTs6QRLBPMcUWJtm kQ3WfMe+nE5AkTUvML1/SdsmmzKs+z5T7bkWe1626uiExSJnXmhaUz26VZYyrXvULFXdrdpf uIyYsKgQcn9PjIQ+jdiEI8l9Y3/ssIYKU2rTh39KnZv9crr7E1nzlJbUf2BJ7662bFrjO/7u hrJD66ObfUlF9qWBV6m/gCrec77+9sfbtH/uZH0eLUidGxwd/KI4K2VT1ciId8sxvzNR807c K95oCbT3yRfbphPn/Z1xsGvF9mZ7XfKyzeHIXjPn2GldvYK1O6z/AcLlfySnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cnri7L8CJkOYpCaDXn2tHMIigu0YsiCnvMpRcV3Wa7 m2YQmZitWdrDrDSnJeabZWpaWegCtaaIVqakNc2QXtM0Q80eG9J/n3O+53vOgXMoXDJJ+FFx OiNn0GkSpKQX4fjT9m6N83SEel3vYwpsHVYEw++KcXDmDJKQOZ6OQV/FJmhquCWAK+9TMci6 8h2DhjILCV+daQS4JhowGHjiEEJeT5oQJuyjQrjYlY9gdO4zDjeLJhF0WesFMNPyiISxuTsE ZM2+RpBd146g7cJ3AnIeNiLIsNAwXl4qhOIBf5hwthPg6K8VQtVUNw71Hb8RXG6zIejM+CvY HMDOFpUI2OKmTxh79XY3zrb25wrZC8+tGFvjasTYsaevSTarrgKxL4YzcbZyZJrc4xUhCzPo TUZueayeN26UHpJDkEweArKg4BCZXKE6EhqklK4ND4vmEuKSOMPa8EhZrPlZDUp85XXi7Jek VNRCWZCIYuhgpsxmEViQFyWhSxCTUdDnDii3wDBfRvD5msXMXK+F9LCEnkSMy+brYZJezTjM Vszj9aHfkszLc2cIj7CY3smMtd7FPEzQK5mPxaVCD4vpUCY/fYicb7qMqbzXjHtmidz5oYEj 8/3jGGvHT8E8+zNvCn9gl9DCIrSgAvlwJl4bo+WDZLxGy5t0MbIovfY+ch/8QetMXSOyuPbZ EU0hqbe4OTRCLRFokvgUrR0xFC71EW/pdByViKM1KSc5g15tMCVwvB0p3ftdxv2WROnd76Mz quVKuQpC5CqFSrEepL5iM91yWELHaIxcPMclcob/PowS+aUiVft+whqavetW9u1XmYqCyBW6 wZiaU66AqxviyfLc8froa38Cp6tP5Rw0L0vIjzpnVdfOmhcpbyTnYZcC0gMdyd1V7dxUwQ6V 9/14mXIVHz5oyy3pmproSVaLqgOzWw9sPV+ytDBu2/EN3btPpohML/2/bf/wy6/5/bFwU2GL ce91KcHHauSBuIHX/APiIoNrBgMAAA== X-CMS-MailID: 20200910193456eucas1p25839dc5b17a0eebece4c7c0ab1e4dbbf X-Msg-Generator: CA X-RootMTR: 20200910193456eucas1p25839dc5b17a0eebece4c7c0ab1e4dbbf X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193456eucas1p25839dc5b17a0eebece4c7c0ab1e4dbbf References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 15/24] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..d90c71698 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,10 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", port_id, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77236 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2313A04B5; Thu, 10 Sep 2020 21:36:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 045FC1C1A3; Thu, 10 Sep 2020 21:35:01 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 008F61C1AE for ; Thu, 10 Sep 2020 21:34:59 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193459euoutp012ab6f6845c3481dee24b04db8c32700e~zgyfYSaLB0119101191euoutp01d; Thu, 10 Sep 2020 19:34:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193459euoutp012ab6f6845c3481dee24b04db8c32700e~zgyfYSaLB0119101191euoutp01d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766499; bh=zmZz7YLNZwsZfzlBrodbxoobMXy1KSIqos1a6ezRVA4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=bcEm9JEvE9wzrBDSnJYew4fQ2JB1PZzzSWNnCvOPUOnXYfg+kUzHi9kF7UnJMfPuL N/f6h5VKDl3RG9xsz26nx2l0qW3tPQaqiTnW5CjP7xg0spB1zzIe2TLq1TI0CuAuyi 3Ykz2UWS5m09i7fAoP7G371ropIgOBkId4ViKAoo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193459eucas1p1e4746377597b9a1c31e14480f021f234~zgyfD3guj0307203072eucas1p10; Thu, 10 Sep 2020 19:34:59 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 16.42.06318.3EF7A5F5; Thu, 10 Sep 2020 20:34:59 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193458eucas1p1ae0f16b4519b299d2edf3378458e5113~zgyegAtt22934729347eucas1p1S; Thu, 10 Sep 2020 19:34:58 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193458eusmtrp256ce58a7ec75128d54c114cb12c232e7~zgyee-nJp1027210272eusmtrp23; Thu, 10 Sep 2020 19:34:58 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-4c-5f5a7fe3b1ab Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 85.19.06314.2EF7A5F5; Thu, 10 Sep 2020 20:34:58 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193456eusmtip229b29384cceb758112cd0799eb765a0f~zgycuSV571532615326eusmtip2X; Thu, 10 Sep 2020 19:34:56 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:49 +0300 Message-Id: <20200910193400.15326-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSXUwTeRTFc2emM0Ol7lhRbpRorNG4m6y4wWRvjNFdMXGMPuyD4YGobFcm YJYCaUVlQ5QUQdMiCOI38iEalGoQqRQIGORBYAtFiKgkgFWrqCggSlQsy1IG49s5v3Pu/96H v8jqT/KLxL2J+xRzojHBwGu5mntfPD8/Pxwds+ZhdyhVthcBPRsoY8lb0M+TffQIQ48rNlKD q1BD+U/SGcrJf8+Q66qNp7deK0fDYy6G+hrdAp3vtgo01jwo0PHOC0CD/jcsnSv5ANRZdFtD X+7W8zTiv8RRzkQPUK6zFagl+z1HBXW1QFk2iUavlQtU1reExrytHLl7qwW6Pt7F0u32SaC8 lkqgjqwpzW/L5ImSKxq5rOE1I58s7WLle72nBTm7rYiRq4ZrGXnkTg8v5zgrQP73mZ2VHb7P /B/aaO36WCVh737FHL7hT218Zl4lJBdqD1qv2Zl0sIs2CBJRWovXPQ7WBlpRL10FfJHeKqjm I2DfqE+jmg+Al9++4L+N2MYdoAblgP1NVbNmHPDsxd6ZFi+tQvexIiYQhEhVPLr8j5hAMF/a gqemXs1oTlqBvgfH2YDWSesw0zsB6oql6LjZNM1FMWiaP+3bFcB6aQk+Kv448yZK90V01V3h 1P5mzPQ91Kh6Pr5pcQqqDsOpuuLZgaOAeTXVgmpOAGZceDfb2ojOIY8Q2MZKP2JlfbiKf8eC gnYmgFGai4/fzQtgdlrm15xhVazDY1l6tW3AprbuWYw4+TVYlTJahyX1+kbALEfSCVh6/vum EoAKCFVSLKY4xRKRqBxYbTGaLCmJcav3JJluwfRXdf/XMl4Ld/x/NYMkgiFY17QuOkavMe63 pJqaAUXWEKLb1OHerdfFGlP/UcxJMeaUBMXSDItFzhCqi7j0epdeijPuU/5WlGTF/C1lxKBF 6RDrj654mZw9cHFyYbw95PK5kR+G7m/rCtu5ydNAPb3z2tpOxfityRvYlZryyKmk/jT/58js iJLUXMjbUR7uOTz3aVirFDLoK16Y2313x6fdA3XegQUZW9NWOutvBg91mNioZaXVxbc6S399 FRVvfNCZsaaxcPuNQ3OC0yYiR6KWO4IMnCXe+MtPrNli/B+EbD9hpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUwTcRDF/e9ut0u1ZlMgbjAiVDRI4mI5ZMAzHnHjJyMmRgSxwkoJtCXd YpSgcohHKygKRhErikQOCSCnBg2QyGEhiIKKctSGBA/CKYgExVbit8n7vXkzyQyFy6YJFypa o+d1GmWsnJQQ5j8tAxus50LCN1bWs1DWbkJgHcjHwZLVT4Jx/DwGH4q3Q31trgiuDyZhkHF9 AoPaQgMJI5YUAkYnazHoe24WQ86bFDFMNg2LIb3zDoLh+W843M6bQtBpqhbBr8ZnJIzNPyAg Y64HwdWqVgQtVyYIyHpah+CCgYbxokdiyO9zhUlLKwHm3koxPJ7uwqG6/TeCzJYyBB0XFkQ7 3Lm5vAIRl1//FeNu3O/Cuebem2LuSpsJ4ypG6zBu7EUPyWVUFSPuldWIcyVDs+R+SQi7RaeN 1/NuKq2g3yo/ogAfVhEIrI9fIKvwDQgL8vGXe2/bEsnHRp/kdd7bjrGqtMwyFJcrOZVSZMSS kJEyIAeKof0Yw3QJMiAJJaMLEJOUVkoYEGUDDPN9CF/0ODLz7wzkomcKMdOlt8R2QNKejPmS CbMDJ/oTyby9mEzYgSO9l8le+ILZa4Jeywx1p/9LktJBTJplDi2mrmZKyhtw+zAHm/65L8wu y+hoxtQ+I1qsXZn3935g19DyPLSkGDnx8YI6Si0oWEGpFuI1UWyEVv0E2U5e0/yrsg69qQhu QjSF5MukDUEh4TKR8qRwWt2EGAqXO0l3dpiPyqSRytMJvE4brouP5YUm5G/bLxN3cY7Q2h5I ow9X+CsCIFAR4BvguwnkK6SX6MZQGR2l1PMxPB/H6/73YZSDSxI6dHh08OvPRPeohLvubut3 GNMTSdcYj36CE9V7Xyylk1NDh8/EhTa+lnxsjgjrztD4OVmynb2Pk9AQ3LfnUKjVU3t5smPZ qpXr1pzAslKvdoxbvVRr93TvK6i59nBk8wzrNx4z1u21+0OyqtXjbM7Bpdke6OXsgZFd5dBW uFLc4yYnBJVS4YXrBOVfez26tggDAAA= X-CMS-MailID: 20200910193458eucas1p1ae0f16b4519b299d2edf3378458e5113 X-Msg-Generator: CA X-RootMTR: 20200910193458eucas1p1ae0f16b4519b299d2edf3378458e5113 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193458eucas1p1ae0f16b4519b299d2edf3378458e5113 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 16/24] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..28bede684 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77237 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2088A04B5; Thu, 10 Sep 2020 21:36:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2CAB1C1A4; Thu, 10 Sep 2020 21:35:04 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 34A2F1C1A4 for ; Thu, 10 Sep 2020 21:35:03 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193502euoutp0292d60b833d5886ef3b74603a5ad88142~zgyiWzcet0501005010euoutp02X; Thu, 10 Sep 2020 19:35:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193502euoutp0292d60b833d5886ef3b74603a5ad88142~zgyiWzcet0501005010euoutp02X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766503; bh=hWLcmMyVuKFoVFPzJm+8zZ/bn73NfLWC3PPR6DROxJc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=miNFqC/phhmO7JBz9ypS4pDC2IXbAqnyUn32sV46MwuiWdp7CNODc59iYAccC4eQd nGT3PHtT3+xjxMqLbdCo3JbZDSxcEQbTv5KkgML8c45wnR+le0y4/F7ehtWomacz2d AmVprarWan8kU0fQRz1wTlxmm+zSfuUafMowkKpI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193502eucas1p14fd0c6817659a7e65261a4e4421596c7~zgyhe6OjM2935329353eucas1p1T; Thu, 10 Sep 2020 19:35:02 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 38.42.06318.5EF7A5F5; Thu, 10 Sep 2020 20:35:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193501eucas1p118effa649709ad3c377df1922e7786a1~zgyhHuq3P2933229332eucas1p1Q; Thu, 10 Sep 2020 19:35:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193501eusmtrp14630052d247cace462aa14fccc42587b~zgyhG2XQo3165331653eusmtrp19; Thu, 10 Sep 2020 19:35:01 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-50-5f5a7fe5d817 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 9A.9A.06017.5EF7A5F5; Thu, 10 Sep 2020 20:35:01 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193459eusmtip2dc0052b179dcb2633f6cb9616a5aaf01~zgyfUrelC1654016540eusmtip2G; Thu, 10 Sep 2020 19:34:59 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:50 +0300 Message-Id: <20200910193400.15326-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0wTaRTNnZnODNXiWDR88YFrjc9EYYOJN/jAXTfZ+ecaE6MYrVUnSKTF tIKvRBFNJRVZCj4WNIhUBakRH4UWBIKgPLYgj8ACEdZC3CWKD0AwgvXBOGz237nnnO87JzeX p7V2dhYfYzoomU2GWB2rZoprxpqW/3MiSh9WMrYaCxuyAfv+dtDoO9/D4tnB0xR2FkRimfuK CtOfJ1KYmj5EoTvfxuJrXxKDb4fdFHaXeznMak3icLiqn8NzTZcB+/2vaMzMeQ/YlF2kwrFH pSy+8+cymDreDvi7qw6wNmWIwfMlHkCrTcDBW3kcOrpDcNhXx6C36wGHt0dbaCxq+Axory0E bLR+Va2fL47n3FCJjrKXlJhxrYUWa7oucmJKfTYl3nvrocR3Fe2smOoqAPHPvrO06Hzxkf1N HaVes1eKjUmQzKHrdqn35T2zsQc61YefZxRRiZDF24DnibCStF7T20DNa4V8IC7/ENggYGIY AXL9cZQivAeS6e1RyYL8IKOhhlaEPCCOC6mgDKNAkm6NU7KLFZYQb3I2JQszhHsscfs7vgtB wkbivHPh+1eMsJBcqihlZKwRIsjV/F5KiZhHnHcrablfwATf271DqRRCOq6OTFqaeZLWHajg X8gz+wCr4CDyqtbFKXgO8WakMHIHIpwBYi9+wClDGpBTl99MuiKJa+ApJ4fRwlJSWBqq0D8R 68lWVtlRIOl8M12m6QmYXnyJVmgNSbZqFbeOVNa3TtKEfP40VaFF4vA1Ty60HEhH85Y0mJf1 f1QOQAEES/EWY7RkCTdJh1ZYDEZLvCl6xZ44432YOFTvl9pRD1T4d1eBwINuqqYyIkqvVRkS LEeMVUB4WjdD83Ojd6dWs9dw5KhkjtOb42MlSxXM5hldsCY89+UOrRBtOCjtl6QDkvk/leID ZiXCog0jcbDJeqxx8YbgrJmeK/q6Ez+EfvzXc70skLWr76imRWzbXOIu0Kxtcy77I0xfPTfn frjQZryoC0u4Ob06xPUEp6zuSzY93JNU3eb7dfAvcWWLuKV/u2uBqT23/tCq4q7XT/t6BprX Rm6MCQos322cudVZt72s57gmpnf9h5SATB1j2Wf4cRltthi+AUR+2tGkAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3c3Wt2W0kWidBBI1K35aEezB4Jw/xGCqMAec+hNpT1k d9Psj3wUVtMsH5U9WKb4SAPLR1qk6aipTZNSy+EjDcMy8zFLytZjS/rvw/ec7/ccOIfC5V8J PypJb+KNeo1WQUoJx++O0a0f0mPU2yuWAqC224rg/WgZDmNFIyTkzJ3FYLB6DzxpuiWCgncZ GOQVzGPQVGUhYXosi4AZVxMGwy0OMdx4nSUGl21SDBd7byKYdE/hcL1kAUGvtVEEP9ofkzDr LiUgb2kAwaWGTgQdufMEFD1qRpBtoWHubqUYyoY3gGuskwCHs14M9769wqGx+xeC/I5aBD3Z f0R7A7ilknIRV/bkE8YV3nmFc3bnVTGX22XFuAczzRg32zpAcnkN1Yh78T4H52omvpP7pDFs hNFgNvH+iQbBtEtxWAlBrDIM2KCQMFYZrDoaHhSq2LY7Ip7XJqXwxm27Y9nEyiELmTwoPfmu sBHLQDcoC5JQDB3CFHbbcQuSUnK6HDGFZwZFFkR5CgzzeQJf7lnLuN9YSC/L6QXETOakeJmk AxnHeSvm9frQQyTTdy6T8BbW0tFM//OPmJcJehNzrfXxP11GhzO3q8ax5dCNTM39Ntw7S+LR x4ePLucnMdbuRdEyb2De3v6KXUarStCKauTDmwVdgk4IYgWNTjDrE9g4g64OeS7+0P6joRlZ ZvbbEE0hxUpZW3iMWi7SpAhpOhtiKFzhI4vscRyTy+I1aad4o0FtNGt5wYZCPfvl436+cQbP /+hNamWoUgVhSlWwKngHKNbJztPtR+R0gsbEn+D5ZN7434dREr8MFGgO/p2BdR1KXu2sO/uz JaLledFxd+68xL6Frajn+lcWPDWOmmrZKK2zKbth58TLaf/0gTNE3/q2xfzxrPjZL+oJyXR0 6bPT5tdfsorT1kSlhmVeGOmSVsWayqia3hbM9UgnpOYdLD/Qsb7YVb3K4XtT36sqvfJNmFLd m12MlCsIIVGj3IwbBc1fIBCI+wcDAAA= X-CMS-MailID: 20200910193501eucas1p118effa649709ad3c377df1922e7786a1 X-Msg-Generator: CA X-RootMTR: 20200910193501eucas1p118effa649709ad3c377df1922e7786a1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193501eucas1p118effa649709ad3c377df1922e7786a1 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 17/24] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..0f3f4088c 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77238 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1A05A04B5; Thu, 10 Sep 2020 21:36:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C0131C18E; Thu, 10 Sep 2020 21:35:08 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 883831C0DA for ; Thu, 10 Sep 2020 21:35:06 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193506euoutp022b645938f0313eb58fa9b862d0e8b22a~zgyler1eD0500705007euoutp02Z; Thu, 10 Sep 2020 19:35:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193506euoutp022b645938f0313eb58fa9b862d0e8b22a~zgyler1eD0500705007euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766506; bh=kjiDZOgx4RVk31QgFA7JiC93FXZ7jB4R8xwyUSv77Cc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=N2OiNsT1FpPC7y2ibD1B5HR53AexRmdZt3uJGtoY8JDFBoST45zuWYXSkiWUmsvgu da7C7WJWHRowA3DnV9p0hxADw7StJXPiO2WMYxfP5DEE6iGFD5ikRk3bNByYzhRhRQ hTLo+lZSZYgo9VoxKEuGQYxoityssRINANM0ndNQ= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193505eucas1p119680800b9b1473a505010f5c2b8fc5b~zgylGs5xd2933229332eucas1p1R; Thu, 10 Sep 2020 19:35:05 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 5A.42.06318.9EF7A5F5; Thu, 10 Sep 2020 20:35:05 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193505eucas1p1c72b003752070200f63b999e6ffb7c5f~zgykpLQrB0308403084eucas1p1w; Thu, 10 Sep 2020 19:35:05 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193505eusmtrp29b88e7dafbb3cf794b8ab9bd2bfe452e~zgykoWKta1027210272eusmtrp26; Thu, 10 Sep 2020 19:35:05 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-55-5f5a7fe9d089 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E7.19.06314.9EF7A5F5; Thu, 10 Sep 2020 20:35:05 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193503eusmtip23b988a52d1326bd7be774022a2ec32b0~zgyi0ylO91654016540eusmtip2H; Thu, 10 Sep 2020 19:35:03 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:51 +0300 Message-Id: <20200910193400.15326-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yUdRzH93me557n4ea1p0cbn5lCXbNZlma09hlzUY2155+C9WMNltCR T+ACzt0jpK3NS9jlDiVBsQl1XjASwQbowR1ODWh5wqEIxoDCAnbLIXLIcbQgiDgeXP99Pq/P +/3+fPbdV2TlMn6juDd/v2rLt+SaeSPXem3+5vMTh9IzXzjnTKDGHhfQ+O81LI2evMNTyYNi hobqk+iy9xsDlf9hZ6i0fIYhb52Tp/ujhzkKhb0MjVwJCFTZf1igcOddgY71VgHdXbzH0mn3 LFCvq8VA8x2XeJperOaodGEA6CvPdSD/0RmOTrb5gBxOiR6cOytQzUgchUevcxQYvijQ+bk+ llp6loDK/I1ANxzLhlefVBbctQal5vIEo5z4ro9Vrg2fEpSjXS5GaQ75GGX66gCvlHrqQeke L2GVhuDffKox3bhrj5q7t1C17XjlQ2POX64mbl+P8UBxR1CwQ4vohBgRpZfw26kw6wSjKEt1 gI6i+0x0IEsRwIW2DL2eBeyuf/Oh4ee6Ck43nAUMVX5v0Js5QN/gLxBV8dJWDBxxMdHBBqmZ R+/i4GrseikF3V0XBCeIIidtwcEfuCg2SYnYW17C6BvisaGpnY1KYlb42Mhu/Yg4HDwTWY1E 6ZaIv45UMVENSslYF07Srevxnt8j6PUmXG47s6b/ErCs9aKgN8cBi6qm1lRJ6Jm8uXoPKz2D jZd26Pg1DAeCnJ7/CA5NPRrF7EpZ3vo1q2MTHnHIutqM7V39axhx6Z91OlZwyFfB669zBdC+ 3M0fh/jK/3e5AeohVi3Q8rJVLSFf/XS7ZsnTCvKzt39kzbsAKx818K9/zgdXF7M6QRLBvM7U npieKRsshdrBvE5AkTVvML1+I5Ahm/ZYDn6m2qyZtoJcVeuEx0XOHGtKqJ7YLUvZlv3qJ6q6 T7U9nDJizEY7pBZUb/6xw2pNfntM7t+c9py05cUJ97uTp47Jb2jxsaW5QvPTY+95D/30Qai2 OC3ndknx+0W3KVD71nBichzOpH48/ljjNkdo1xfu6dm4DDa4VDY/cLrhlv1lf/oJJSU4/1Sa 9YltkQr+TuqBrJ2b+poi73hM05N/bk357Xzy55Gswlgzp+VYdj7L2jTLfwkslWqkAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3e1VrepdBmoNQhCcDof7TjNpMJuUGRE/5iPVl7Ucpvs TkkhMhGz+SgfCb2WOcw0Q03NBxpqD63NRkWZaWoqiJXPmaTYY1P67/D9fM+XA99D4eJFQkIl avScTqNKkpLOhPlPz7D31MXIWN+2YReotRgRjA2bcBgt+UJC7lwWBp+q90J7820BFI1kYFBQ NI9B8wMDCT9GMwmYWWjGYKjDLISb7zKFsNA9KYR86y0Ek6vfcLhRZkNgNTYJYLmrjYTZ1XIC ClY+ILja2IugJ2+egJLWFgTZBhrmqiqFYBrygIXRXgLMAw1CqPn5Focmy28EhT21CPqy/wrC drArZRUC1tQ+hbHF997i7MuBUiGb98qIsfUzLRg7+/QDyRY0ViP29Vguzj6c+EVGOEfKQnTa FD23PUHL6/dIT8rBTyYPAplfQJBM7q+IVvoFSn1CQ+K4pMRUTucTekqWsGSsI5ItzuezuiaE GaiJMiAniqEDmBcPrhMG5EyJ6QrE1C51IQOi7IBhvk/g6x4XZvWjgVz32BDTYDURDkDSuxhz jhFzAFd6kGTeX760BlzoI0x2aQfhCCLonUz/ozVZRCsZa1Euth7qyTys68QdFie7/nUo2iGL 6UTGaFkSrM8eTP/dRewa2lyGNlQjVy6FV8erebmMV6n5FE287IxW/RjZG3/ycrmhBb2rP96N aApJN4k6lZGxYoEqlU9TdyOGwqWuon195hixKE6Vls7ptLG6lCSO70aB9vMKcYnbGa39fzT6 WHmgXAFBcoW/wn83SLeJcuiuKDEdr9Jz5zgumdP938MoJ0kG2hJVLB3PkUyXj2RuvBJpO3i/ df/t/Kz0Z1UNB4IvHLYNovDJnDva5mSlNqzCxzbk5Y27dXoVP125J4rYUVk1mpT/mfDMyogY P300zaQM3Pp8oP/NVFxMPNc53RpRE3I2uN14bqe7r7urpnfuk2VQknDi+RtP4libYrqkajzc eqhWSvAJKrkXruNV/wAdPD10BwMAAA== X-CMS-MailID: 20200910193505eucas1p1c72b003752070200f63b999e6ffb7c5f X-Msg-Generator: CA X-RootMTR: 20200910193505eucas1p1c72b003752070200f63b999e6ffb7c5f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193505eucas1p1c72b003752070200f63b999e6ffb7c5f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 18/24] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..bcd737994 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77239 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05840A04B5; Thu, 10 Sep 2020 21:37:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 738EA1C1BD; Thu, 10 Sep 2020 21:35:12 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id AF71A1C1BB for ; Thu, 10 Sep 2020 21:35:09 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193509euoutp0194ae581a226240dc36b2bcfae2e5dbfe~zgyoaE6L-0119101191euoutp01e; Thu, 10 Sep 2020 19:35:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193509euoutp0194ae581a226240dc36b2bcfae2e5dbfe~zgyoaE6L-0119101191euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766509; bh=6p7H3O/p30P7+DqRWD5odx/9ARdFqIE8TJnlYcrXyzc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=XHAQ77jXhvpQIEUaUcw5jiRaq3h0CyxLg6LXV/XbCQPSMpFUJi9jDuGK4QB7MdMFb jFQs1JkjHCDgpmqABF930HLobDS0z19MMCWQr64CE+jjxn1Msk5j+nRcZG3cPpFABA VmxnTnh2QDcAsGO/H2s5gb9pKy4h5aTfKwO/A7IA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193509eucas1p2661e70d6c4428cc701ccfc721163af87~zgyoA-sZd1798017980eucas1p2R; Thu, 10 Sep 2020 19:35:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id D4.E5.05997.CEF7A5F5; Thu, 10 Sep 2020 20:35:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193508eucas1p154962900717e9e5a57a6dc6643f80b3d~zgyndFCLp0325103251eucas1p16; Thu, 10 Sep 2020 19:35:08 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193508eusmtrp1fea6ba7b4eb8f0769c8382256ad16f80~zgyncQ6oJ3165331653eusmtrp1C; Thu, 10 Sep 2020 19:35:08 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-cb-5f5a7fec076c Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 0E.9A.06017.CEF7A5F5; Thu, 10 Sep 2020 20:35:08 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193506eusmtip24ded06f3b707cfa19062914095e37552~zgyltUzLN1532615326eusmtip2Z; Thu, 10 Sep 2020 19:35:06 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:52 +0300 Message-Id: <20200910193400.15326-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUhTYRTHee69u/c6unWbvTzYG42kksrKoINGWgTdbxV9CcV05UUlNdnN siBaGmpzaU7JrFiWlU4LM6cz01hCvrSlzJCyLKdFpmWp015svTiv0bfz//3/55yHw8OSKiPt x8YnHRG1SZoENa2kapt/dKz9dCo8av2ZxyFQ6TAh6H9TQoKr4DUN2SNnCHhRHgoN1isKMPbq CMgxjhJgLdPT8MmVRsHnMSsBPY12Bi51pjEw1jTAwLmOywgGPEMkFBW7EXSYahTw41E9DV88 1ynImexCkGtpRdBiGKWg4H4dggw9DyPmUgZKepbCmKuVAnt3NQO3J5wk1Dh+IchrqUTwNOOP Imy5MFl8UyGUNAwSQv41Jyk0d19gBEObiRCqPtcRwpeHXbSQYylHwpP+bFKoePed3q0MV26J ERPij4rawK3Ryrhs3YJk64LU9NwCSofOqvSIZTG/Cec59+mRklXxZQjf+X6NkcU4wm/adaQs 3AhPVj2h9MhnusNt8FCyUYqwoX1CIYsJhAttGYQ3RfOrsD3LRHiNeXwVja2e59OGL78LZ1na GG9N8f64xzpMeR/C8cH4YgUjb1iGK+7aSC/2mcJ9PZFerOKX4udXx6dHYt7B4g7nT4Wc34Gd ZuNM7YuHWiwzcxZje76BkhsyEc6rrWZkcR7h9MvDM6lQbPnYzni3kfxqXFkfKONtuLf1IiEf aTZ+MTzXi8mp0lhbSMqYw1kZKjmtxra2zhmM8a+fs2Qs4CsvnYR8nkaES925xHm07NL/XcUI laOFYoqUGCtKG5PEY+skTaKUkhS77uDhxHto6qfaf7eM16F6z4EmxLNIPYuzBYdHqRSao9Lx xCaEWVI9j9v+1L5fxcVojp8QtYejtCkJotSEFrGUeiEXdH0wUsXHao6Ih0QxWdT+cwnWx0+H 8l+O/L7l11C6+cbpNc3dmQnEnKJFNUF7yAtXX3UNpLseB6/s/PY11JE6+vbZ5NDOk7dND459 dK+4k/41atOHEM4FKQ8D0sy9g6l9yfEBfRGvtGXzHXulOAiMvllIDeo0/qdvkFv6zUFh7yXO Vh4BSzLNy1dVxkREHJTC+BCyiFNTUpxmQwCplTR/Ac06C22lAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdjal1eFo9W9pl5EkorN5aa9mFlJxiCIhorLMhp1U3EV2 plQfyu42TbusULOpiVhqaKWblYUaeGmKaGhFqyyM7t5WYbKsLenbw/N73ocX3ldCsk5KJknT GXmDTq2R096UfbrjdcjXowlJK3vqFkJdtwXBu9cVJAyZX9GQO3aSgOfVa6HZViKCi2+yCci/ OE6A7YaJhq9DxykYmbAR4HhoF0Nx/3ExTLR9EMO53qsIPrg+k1BU5kTQa2kUwa/W+zSMuq5T kD81gKCgoRNBR944BeZ7TQhOmxgYu1klhgrHYpgY6qTA/uKuGGp/9JHQ2P0bwYWOOgQ9p/+I 1i3jpsoqRVxF8yeCu1TeR3LtL66IubwuC8HdHmkiuNFHAzSX31CNuCfvckmuZniSjvdOUMQY 9JlGfmmqXjCuke9WQphCGQWKsIgohTJclRgdFikPjY3Zz2vSsnhDaOw+RWpu9vwM2/yDJwrM VDY6y5qQlwQzEdiZ56JMyFvCMpUI/xjpIkxI4gYYfxkmZzI+2DVoomcyToSHa5+JPIBmArE9 x0J4gC/zksZPzxyjPMCH2YJPWd/+0xQTgB22b5SnVMpE48Ia8UzpElxT30J6bC+3/daR6LFZ Jg1bun+KZvRi/Kz0O3EezSlDs6qRL58paFO0QphCUGuFTF2KIlmvvYPcB7e2/2poQqaRbW2I kSD5bGlLdEISK1JnCYe0bQhLSLmvNK7HvpeV7lcfOswb9EmGTA0vtKFI93oXSNm8ZL37fXTG JGWkUgVRSlW4KnwVyBdIc5jWPSyTojby6TyfwRv+zxESL1k26sd8Kp+rSedvXV7deaBQt8l/ x/ioiq2y6x9bR6tk8cHrr5lDXIXPta92Ef6yzTHFC4Jqt0dqDgR9mXvzveWx3wOWX7txhzV6 4+QEnVHnHcANBqp9lwa/qW/v3bnBEWHdGr+ifPrI+UUf8wKN5m6/0pipFL02fDrLWaJZHjdW FCSnhFS1Mog0COq//VNMPAYDAAA= X-CMS-MailID: 20200910193508eucas1p154962900717e9e5a57a6dc6643f80b3d X-Msg-Generator: CA X-RootMTR: 20200910193508eucas1p154962900717e9e5a57a6dc6643f80b3d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193508eucas1p154962900717e9e5a57a6dc6643f80b3d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 19/24] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++++++--------- examples/multi_process/symmetric_mp/main.c | 13 +++++-------- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..a7f5207c3 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", + (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..33643d354 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77240 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB620A04B5; Thu, 10 Sep 2020 21:37:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D22781C1C4; Thu, 10 Sep 2020 21:35:14 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id F36921C1BA for ; Thu, 10 Sep 2020 21:35:11 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193511euoutp02d40930cbed655b835d771b64dc0b6eba~zgyqjN9Fh0501005010euoutp02Z; Thu, 10 Sep 2020 19:35:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193511euoutp02d40930cbed655b835d771b64dc0b6eba~zgyqjN9Fh0501005010euoutp02Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766511; bh=2gXLZvWQss8NYG1Gu+w8A/KveRxMhRUfcMEnas9Mi8U=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Y3Q6a/tixzqo/c+imhjaaQVTJd1u5spb/OLmy6BitJ2fbndZRHDbaI51lkI8uEE8v 1ZsqteRARRozbFD9BZ7m42t/5X1kmb5aep0H2buMas9aeCjNqCJfX5uGUBkMK7rXez Q8ohPisfmWbVHoI3D2YRgO903hkEOJ9+TvRFXf3E= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193511eucas1p2b351985ac601f814a20e609c58d21ea3~zgyqWJRb-2535025350eucas1p2l; Thu, 10 Sep 2020 19:35:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 17.E5.05997.FEF7A5F5; Thu, 10 Sep 2020 20:35:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193511eucas1p17bb96c3bc79b54d1e567eeba1c13a293~zgyp_A0MP2936129361eucas1p1f; Thu, 10 Sep 2020 19:35:11 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193511eusmtrp2be659774284f6cfd32d895d5e44b67e9~zgyp9LKAc1027210272eusmtrp2_; Thu, 10 Sep 2020 19:35:11 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-d0-5f5a7fefec8b Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8A.19.06314.FEF7A5F5; Thu, 10 Sep 2020 20:35:11 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193509eusmtip2a4309dfd5830e94086e63d0603407504~zgyoNfaWr1654016540eusmtip2K; Thu, 10 Sep 2020 19:35:09 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:53 +0300 Message-Id: <20200910193400.15326-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0xTZxjH85zTnnPaWHNWjD5DI1s3jZcoY9PsCVtw7mKOiTN+8BMJYjeO eGnRtILDxcF0FgTGABUzKgVBBaoZOJCbt9pELpZKJCF4QUFlAVGs3ByXKqMct337v7//78nz 5s0rsPosLljYEbdXtsQZTQZOq6puGL+1wpcUGf3R360hVN7iAHr8sJil7mMPOEp/+QtDd5xr 6HLNSTXldCUzlJkzyFBNaRpHz7sPqujFUA1DnVc8POW1HeRpyN3L06+tdqBefz9LvxcOA7U6 Lqpp/Ho9Rz5/kYoyJ9qBfqtqAmrMGFTRsbpaIFuaSC/LSngq7lxIQ91NKvLcreTp/Ohtli62 vAbKbiwH8tqm1F+8L00UnlFLxZefMtLRU7dZqeFuLi9lNDsY6cKLWkbyXW3npMwqJ0g3H6ez 0rmeMW6TNlL7eYxs2pEgW0Ijtmq3H+mww56bwg+X8lYnQxeXBhoBxVX4yH4N0kAr6MVSQG+O XR0o9OIIYKkvUSmGAZMnmv+b6OnLYBSpBDD1VZQijQLe8AzPSJy4BD2pDiZQzBEvcFjj75iZ CBK/wYFXY9OSIKjERdhWMYN1YjgOue+xyoIQPFfhYgOKZpo/6oxSdi3EjoIRRlFaBDzpX6fk r3HKXqZWchD2N1bxSl6AU3UFM1dAMQUwu7qSVw5ZgIfsA2+tNVj17BYfWMaKS7G8PlTBa/GP 8nwmgFGcjXcG3glgdjrmVJ9gFazDVJtesQ3oam57ixFfT85SsIRHB8/yyutcAawYs3FZEJL3 /65CACfMk+Ot5ljZ+nGcvG+l1Wi2xsfFrvx+t/lPmP6nnjeNI7VQ7//ODaIAhlk6V3hktF5t TLAmmt2AAmuYo/vS69mi18UYE/fLlt3RlniTbHXDfEFlmKf7pOhplF6MNe6Vd8nyHtnyb8sI muBkePf0px+Y5kZVlrgilgeZn8Rv7l+n7XnSZ3Pl72xPfE/SFIXumvjrwGhB7kNnydLMBdGx vT86kkz3fYsPH/G09W3Q6ILTu4LWO7+KCfss/Kf0hDo3eybp+Kbghp+XfWhLOb91EvK/XbWR 857wjq8/5Mg4Ha6dDHtQFtGU7UlJyN1/fNsGg8q63Ri2jLVYjf8AdiWHX6MDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa1BMcRjG+5/bnhprTlv4a0zYYdCMzanWvjW5D3MMMxi+SMkOR0Xb1p7d pC+WccmqKLfCrNI0UkylKNdhmYotRuhC92kmQpctKXLZFd/eeX7P88w7874sqRiifNiYOKNo iNPGKhkPyv6rum1h/4GwyEV1ZxkorrUi6GrLI6HjTCsDJwYOE9BUuAzuV1yiIbPdTEB65iAB FQUWBj53HKKgz1FBQMsDuwwu1B+SgcPWI4O0lxcR9Iz3kpCdM4TgpfUWDWOP7zLQP36FgvTv bxGcLK9BUJ06SMGZO5UIjlo4GLh2VQZ5Lb7g6KihwN5cJoPrX1+RcKv2J4KM6mIEdUd/08tn C99z8mkh7/5HQjid+4oUqprPyYTUZ1ZCKO2rJIT+h28ZIb28EAnPu06QQlH3KLPRI0wVatCb jOKsaL1kXKLcxkOAig8GVUBQsIoP1ESEBKiV/ktDd4mxMYmiwX/pDlX08caLKP45m3TvgtqM 2hkLcmcxF4S7P6QSFuTBKrh8hM11DpkFsU6A8aducsLjhccbLMyEZwjh3OYC2gUYbj62p1j/ hr259wx+fewg5QJe3Gr8ZWSUcRVR3FxcX0K4ZDkXgh22d/9KZ+Kikkeky+Lu1DtbIlyygovB 1toRemL2xY2Xh4lTaHIOcitE3qJJ0kXpJF4laXWSKS5KtVOvu4mcB79dNVZWiepLN9sQxyLl JPmjkLBIBa1NlPbrbAizpNJbvrLOvl0h36Xdnywa9JEGU6wo2ZDauV4G6TNlp975PnHGSF7N ayCY1wRqAheDcpo8hXscruCitEZxryjGi4b/OYJ19zEj3ZFvuM88Z2vz3MTcWN9eT1jFerv5 0VOzNKZ1foqkK2kv5iWvTfNPenJ5je5OflnQen4guTUhhQ7Jmj57T9eP7AJb1iWDV7h5y76Z 6yzjCeeuNbSt9qSV/bPOZ7V/vutv3v0secOMdMv8ns5h9em2FE920429HZtXhDVlhHsteJr3 RklJ0VrejzRI2j9GE3H/BgMAAA== X-CMS-MailID: 20200910193511eucas1p17bb96c3bc79b54d1e567eeba1c13a293 X-Msg-Generator: CA X-RootMTR: 20200910193511eucas1p17bb96c3bc79b54d1e567eeba1c13a293 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193511eucas1p17bb96c3bc79b54d1e567eeba1c13a293 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 20/24] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..6d9b3b45c 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,11 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + ð_link); + printf("Eth%u %s\n", eth_port_id, + link_status_text); break; } } From patchwork Thu Sep 10 19:33:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77241 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABBDFA04B5; Thu, 10 Sep 2020 21:37:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E15E1C1CC; Thu, 10 Sep 2020 21:35:17 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 50BAA1C0D7 for ; Thu, 10 Sep 2020 21:35:15 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193515euoutp02babe214974faf41def44e0365d96e050~zgytppBSV0499204992euoutp02e; Thu, 10 Sep 2020 19:35:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193515euoutp02babe214974faf41def44e0365d96e050~zgytppBSV0499204992euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766515; bh=6qXnbzIjmvFRgAFmouzzB/qKJMLERwKTl8zUKg8Pv5k=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=MTDtdLoYhx4POzje1GiCEml60+97Y+KN9V1OPu6ukLjFe5kjpXHD7kjXiFQSQ163X PSDtijcjO3lVL6X+3koGsulCkgDYgAPM8oN96F57x+7hDm3A5PhCduGsFpLRwuVaja KU6wM0KFOHNDZvy6hGif0YdA5z9gVR0cWehyTRkM= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193514eucas1p27bf6910ff198693d2ef858aed2d33b1d~zgytI8FsC2625226252eucas1p2g; Thu, 10 Sep 2020 19:35:14 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 39.E5.05997.2FF7A5F5; Thu, 10 Sep 2020 20:35:14 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193513eucas1p18b7abcd3b05c1b9c7ad68c99e573b5c7~zgysl1DLW2933129331eucas1p1l; Thu, 10 Sep 2020 19:35:13 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193513eusmtrp231facabd0908d9e663319ad97c4616c3~zgyskY0o-1027210272eusmtrp2-; Thu, 10 Sep 2020 19:35:13 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-d4-5f5a7ff2fafe Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AC.19.06314.1FF7A5F5; Thu, 10 Sep 2020 20:35:13 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193512eusmtip202fc64d40fd682f03293185a8ad332e0~zgyqx-1iV1654016540eusmtip2L; Thu, 10 Sep 2020 19:35:11 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:54 +0300 Message-Id: <20200910193400.15326-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGd+69vfdS7XJXzThxilmTGWb83FxyQlDnptmNf+hispiQKKtw AyitpgU3F+OITIZVGEXiFEipEoeigsxSCn4EqlKwIIHIxAwUzTZFZy2lynAgo9ya/XfO7znP +5ycvCKrP8LPETPMWYrFbMw08FrO3TrWtTj0fVLyskv34qi2wwH08F4lS4MlAzwdCv7AUF/1 arrcUK6h4vs5DBUWDzPUcNrG09+D+zkKhBoY6r/iF6i0Z79AIe8jgQq6yoAejT9h6bhzBKjL Ua+hsZYmnp6Pn+So8FUv0E+uNiDf4WGOSho9QHk2iYJnqgSq7I+j0GAbR/67FwU696KbpfqO CSC7rxaoM29S8+n78ivnKY1ceXmIkY+c6Gbl1rtHBflwu4OR6wIeRn5+tZeXC13VIN98eIiV z/7xD/+lNkmbmKpkZuxWLEtXfa1NL6/asKt8xrcX8tfmgD3GBjEiSiuwqPE6awOtqJdOA94P /MKpTRgwb8wFajMC6Mi9JryxBGsmeFWoAhwd6Y5aXgC23XZMT/FSPPrzHUxEmC3V8dgwfoeJ CLOkjdg7elMTqTnpA7x6u2ua66QEHPizkFMj5uPZC81TW4lizBR/0L8lgvVSHN6pCE+/iVKH iDUvc6MrrcXQAYdGrWfhE58ryufiZGNF1PAjoN19UVCbIsDcsmfRqdXoenpLiKSx0odY27RU xWvwge3MNEbpbex79k4Es1NlsftnVsU6zM/Tq9MGbG7viWLEiX9nqljGumPHNOp9rgC6D04I RTC/9P8sJ0A1xCrZVlOaYv3IrHyzxGo0WbPNaUtSdpp+hamv6n/tC3ugaXybFyQRDDN1zQlJ yXqNcbd1j8kLKLKG2brPOv1b9bpU457vFMvOZEt2pmL1wnsiZ4jVfXxyaIteSjNmKTsUZZdi eaMyYsycHDi+48byFfPOp9Z85TS3z73ElhYktPUEC4aEijWd5wKedb749He/WKfN6vUePTgS Dr7eeiCFq43d1Col5sT/fqreM7nx/PBek72lpCS8wL190ycb/Cu3c/bHJ+JHr9U731os9q1P rGgJcPtMrYsG1q+q+3zzX7C34Km97Ld5t1b2Z6VkGDhrunH5QtZiNf4H78SshaYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbTBUcRTG+9979+5dtc1tkZsPqp1M76v1ksMg0/ThNpMyNfVBae3khrKW vcukPrSZkpYUqinMJsYIKUJk5GWnQS2jN4UQxo4psl7KxKxqd9S3Z57n95w5M+dQuGSWcKVi 4rScJk4ZKyUdCNPv9qGdMxfDFLsmjd7wpNOAYHSoCIfhW4MkpE9fxqC3bA801uULIPuLDoPM 7BkM6h7qSZgcTiFgarYOg4EXJiHkvksRwqxxXAjXu/MQjFu/4XCvYA5Bt6FWAAutDSRYrIUE ZC72ILhR04GgPWOGgFvP6xGk6mmYLi0RQtGAG8wOdxBg6qsWwqOfb3Go7VxCkNX+BEFX6h9B 8EZ2saBYwBY1fsXYnAdvcbat746QzXhlwNiqqXqMtTT1kGxmTRliX4+m42z52C8y1CFMFqBR J2q5DdFqXhsoPS4HT5ncD2Se3n4yuZdvuL+nj9QjKCCSi41J4jQeQRGy6PySg/H5K89Vpu3T oSyRHokohvZmph8vkXrkQEnoYsQ0mVOQHlG2gGEmxvBlxpGxftT/Y+YQU/29XWgPSHoLY0oz YPbAif5MMu+vXiLsZUc6hKmwHLIzBO3ONH3oxuxaTPszg+ZMYnnoeqa8sgW34yKbPzIQbrcl dAxj6JwXLGs35tP9H9hNtLoArShDTlwir4pS8XIZr1TxiXFRslNq1VNku/eztoXqevSu6ogR 0RSSrhK3+IcpJAJlEp+sMiKGwqVO4r1dppMScaQy+TynUSs0ibEcb0Q+tv2ycFfnU2rb98Rp FXIfuS/4yX29fL12g9RFnEa3npDQUUotd5bj4jnN/x5GiVx1iH/TP/4mWGTcqr17tGJ6s3mi aHtl74X4gUov7Y5x6+J8wv549mUrm+BRaD0QYq4PtAxfcbGc0W4aPSy6Bj2CO8dEiu1569ZQ uo7m025dyUtua5/P5TS8GMkyB+ZIuVLU3PE+YkzpsRewM4rHzpDsfrva+bUur1fjl5Eb2q/L lhJ8tFK+Ddfwyr/5tEVsBQMAAA== X-CMS-MailID: 20200910193513eucas1p18b7abcd3b05c1b9c7ad68c99e573b5c7 X-Msg-Generator: CA X-RootMTR: 20200910193513eucas1p18b7abcd3b05c1b9c7ad68c99e573b5c7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193513eucas1p18b7abcd3b05c1b9c7ad68c99e573b5c7 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 21/24] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..956a1f48d 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77242 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B91F1A04B5; Thu, 10 Sep 2020 21:37:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FE261C1C0; Thu, 10 Sep 2020 21:35:20 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 31E2A1C0D1 for ; Thu, 10 Sep 2020 21:35:18 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193517euoutp02ab7296b144697dd24c5c08a88f4cc92a~zgywSnMR60501005010euoutp02a; Thu, 10 Sep 2020 19:35:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193517euoutp02ab7296b144697dd24c5c08a88f4cc92a~zgywSnMR60501005010euoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766518; bh=qVSmYkun2k36EKGsPQLrlSwrALp4hWMj7WN7omI+2SA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=llT6cxWrLtKFJlwHqTfZa3JNb+FVXgoIa5i3BCB0/vDJsfNgWjBbhJ19FLwqFsICq sAjMk7CFI5mNrcS7d2ljIq6y2SCOJMDEsYA+ON3b/EabJ2+4Q2ayxa2XY66lu4zhuC QYqM3RmgsOOAvCM4GRtcXoTPjXN1BNPv/C2Cv4Zo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200910193517eucas1p2a72e5eed27e0da0f938ca11a95728456~zgywHKIU_1147811478eucas1p2u; Thu, 10 Sep 2020 19:35:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 2D.42.06318.5FF7A5F5; Thu, 10 Sep 2020 20:35:17 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200910193516eucas1p2daa9595821a02db7dd85df1e6c57eda3~zgyvF-FiP2616126161eucas1p20; Thu, 10 Sep 2020 19:35:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200910193516eusmtrp12e3de895e928a8f3ca9175146054fbe2~zgyvFL-YG3165331653eusmtrp1I; Thu, 10 Sep 2020 19:35:16 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-65-5f5a7ff5425f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C0.AA.06017.4FF7A5F5; Thu, 10 Sep 2020 20:35:16 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193514eusmtip28093e286e034c80af1224205c7817357~zgytWj5y-2570425704eusmtip2H; Thu, 10 Sep 2020 19:35:14 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:55 +0300 Message-Id: <20200910193400.15326-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+69vfdSrbsWjAdlkjWZ82PqjErOyDJ1anLjnHH/kiBWuUEj oGuF6ZJlDA3TgnwJKrrUIllAMGFIKahAsIkUVhRFibAhVONsYAql2DihnVIuZv895/c85zzJ m1dk9aX8IvFA+hHFlG5MNfBaztH+5u6qwE8JSZ9NXfqUarusQE8HK1jylDzmKdd3gqG+6o3U 3PirhoqHshjKLx5nqLHKwtMLTzZHo/5GhgZa3AJd6MkWyO/0CnS6+yKQNzjCUpltAqjb2qCh N7du8DQWvMxR/mQvUIG9A8iVN85RyfUmoByLRL4rlQJVDCwhv6eDI3d/vUBXA/dZaugKARW5 aoHu5LzVbPpInrT9ppErmocZ+Uz5fVZu7z8ryHmdVkauG21i5LHWXl7Ot1eD/MfTXFauefYv v0uboP0iWUk9kKmY1ny5R7u/MtAAhx9oj9rbnzNZ4BMtECGitB495ZOsBbSiXqoCnHC9BnV4 Bfi346xGHSYAz3UE4P2KN6uPU41KwKGO0tlUANBaNawJp3hpGbpPWpmwESXV8dgYfMSEjUjp a+wp/3PmFCd9jCHLXzNaJ8XjiYpBVq2IxZrf26a1KEZM8ycDiWGsl5bgo0uvZm6i1CViy7NS Ts1vxeCLkEbVkTjisguqjkH3mTxOXfgFsMhRL6hDIeDxiy9nUxvR/s9dIdzGSsux9sYaFW/G 83UWLoxRmod9L+eHMTstix3nWBXr8GSOXk0bsK2zZxYjhqbmqljGkanx2fdtAay/18sXQuyF /7tsANWwUMkwp6Uo5nXpyverzcY0c0Z6yup9h9KuwfRndf/nCjRBa3CvEyQRDHN1bfEJSXqN MdN8LM0JKLKGKN1Xd9y79bpk47EfFNOhJFNGqmJ2wmKRMyzUrbs8nKiXUoxHlIOKclgxvXcZ MWJRFmyP+vC77bZiz7b6h87ouNC9Hd84fIXX/Ni9ITaX061sPeUvutI5vrVgQUz2rbInQ80j 0Ym340r7D9q2dO3COfb+yRrvg5sbsGhwN40+Th7zLy5I8vjKfo65vrQ9fsG3n9eFIrMzn5fs tLzdvM/ofb1c7On+YM6PLTt30Ce+uOPRa8nAmfcb165gTWbjOzTjmjKoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUgTcRzH+9/dbudocUyrwxeWS0nMlts0f5pZ9OrKFy2CivVgqy6VnJPd JrmgTMrqKkutyJSlmZgWVD40jYq2F9OaYSWm5mM21B6w5TRKtNq03n35fr6/B/j9KFw2RQRT 6Zkmzpipy5CTEsL1u2Vg9eQJbUq0YyQc7rdZEQwPVOIwdKWfhPOeUxh0126AJ7YyERQN5mJQ UPQdA9sdgYSvQ3kEjE/YMOh76hLDjbd5YphwjIrhYnspgtGZzziUlHsRtFsbRfDL/piEbzO3 CCiY7kRwqaEVQcuF7wRcaW5CkC/Q4KmpFkNlXwhMDLUS4OqpF8O9qTc4NLbNIihsuY/gVf4f 0cZQdrq8SsRWPvmEscUVb3DW2XNNzF54YcXYh+NNGPvtWSfJFjTUIvbl8Hmcvev+SWokWkWi 0WA2ccvTDLxpvXy3ElQKZTwoVDHxCqU6bm+CKla+JinxEJeRns0Z1yTtV6RVTzWirA7J0Qbn CJaLPJSAAiiGjmFGc7sJAUkoGV2FGG/xbVxAlA8wzBc3Pp8JZGbeCeR8xouYydJWwg9IOoJx nbVifhBE95JMx5mTcyCQTmbeVrxHfk3Q4cys0DunpXQCc6py4F/XZczdB8/nhgX4/A99e/22 jE5nrG0/RPM6hOm6OYldRovK0YJaFMSZeX2qnlcpeJ2eN2emKg4a9HXId/JHzl8NTUgY3+5A NIXkC6XPE7QpMpEum8/ROxBD4fIg6aZXrn0y6SFdjoUzGlKM5gyOd6BY336FePDigwbfA2Wa UpSxyjiIV8ap49RrQb5Uepa275HRqToTd4Tjsjjj/zqMCgjORcfFicciD4dufek8vLL5ZP0i 72xT1XSdZVuZRrJKfSDae6Md+kvcH7vdSxbY84kdv7dkNbctdAxHh/UVW9ZlhPYExWtVDnOE R6RIiDl9VVO/cyxi8Wa3ZTDvj22XoFn12mkqNRdFaWeT6S71kg3ZK8K2TuZEqdzX7YFdNedc YwNygk/TKSNxI6/7C4saggEIAwAA X-CMS-MailID: 20200910193516eucas1p2daa9595821a02db7dd85df1e6c57eda3 X-Msg-Generator: CA X-RootMTR: 20200910193516eucas1p2daa9595821a02db7dd85df1e6c57eda3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193516eucas1p2daa9595821a02db7dd85df1e6c57eda3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 22/24] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..06328ddb2 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -76,6 +76,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) uint16_t rx_size; uint16_t tx_size; struct rte_eth_conf local_port_conf = port_conf; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; /* check if port already initialized (multistream configuration) */ if (app_inited_port_mask & (1u << portid)) @@ -160,14 +161,9 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), &link); + printf("%s\n", link_status_text); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Thu Sep 10 19:33:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77243 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0380DA04B5; Thu, 10 Sep 2020 21:37:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C64ED1C1D7; Thu, 10 Sep 2020 21:35:22 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 295B21C19B for ; Thu, 10 Sep 2020 21:35:21 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193520euoutp010ebb452407cf38dd161fe190ade6deed~zgyzFkgmf0119101191euoutp01g; Thu, 10 Sep 2020 19:35:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200910193520euoutp010ebb452407cf38dd161fe190ade6deed~zgyzFkgmf0119101191euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766521; bh=j+whVyosWgx3tIoE9UeDWIlBQDtqfd9P5No4AWJHtMw=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=YuOjogYvanVmmGMhy3eIaQClHFg3eJ/odC5afxqfinz1i1RuCEJbaHzycGtlR+P9E nIBp+JBPbZI6+JOkW8/i+GQj0xaQwcRxScRCTytuXsR2ST0/2ApQuDTX9O30RX28R0 wtT9Ath9iE3jKGqlzRU1ABas322o6k4984DFV88Y= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193519eucas1p11eaf030c28b88c2bc78dd6a48448e7e5~zgyyEaNx90487904879eucas1p1w; Thu, 10 Sep 2020 19:35:19 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7F.42.06318.7FF7A5F5; Thu, 10 Sep 2020 20:35:19 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193519eucas1p10e3d3b0496590dfc30e41259f068c62f~zgyxtkr570322703227eucas1p1z; Thu, 10 Sep 2020 19:35:19 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193519eusmtrp20f250d53e330878249d3824e2a46defd~zgyxsg16w1027210272eusmtrp2A; Thu, 10 Sep 2020 19:35:19 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-69-5f5a7ff7d7c0 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CE.19.06314.7FF7A5F5; Thu, 10 Sep 2020 20:35:19 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193517eusmtip29796d40e83728a03518708f3b2e13ec7~zgyv8czFo1654016540eusmtip2M; Thu, 10 Sep 2020 19:35:17 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:56 +0300 Message-Id: <20200910193400.15326-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTaRSG/WamM0OlZqwmnFWDsXGD60bxsiYnuFEhmswP422jUTZSuzoB FSppxVV/7LKotdZaAesNSUGJIsUEUaBgWgIoIhZFiFrMAotkEwIKFQSlWlTqYPx3zvO+3zlv Tj6eVmexM/jd+v2SQa9L1rBKpuJ+4PGC93/Haxd1ti3AkiYHwe7OAhq77B0snnxzlMI250p0 u3IVmP1fOoW27EEKXdctLL7uymBwYMhFYbvHy2FOawaHQ3U9HJ5qvkSwJ9hH48X8twSbHeUK DNTeYdEfvMKg7cMzgqfLHhBssA4yaK+qJGiyCPimqJDDgvZIHOp6wKD3xW0Ob4y00FjeNEYw q6GE4CPTZ8WqOeKH/KsKscDdS4lnLrfQ4v0X5zjR2uigxNKBSkr0Vz9jRVuZk4gPu0/SYvH/ o+wGZbzy111S8u4DkiF6xQ5lktORkHpj8sFmT5BLJ6fCLCSMB+EXeH7sJmchSl4tXCfg7/AR uRkmUNXom1DeErBnWblvT+x362lZKCRgCgwzcjNCoDivhQ65WGEeeM0OKiRMF0pZcAV9VEiY JqyHJvdrRahmhB/hQubA+FieVwkxcO8TL2+YDcU3a+gQDhvHL9u3h7BaiARf3jAlW57wcOGp FLKAsBo6urfKeBr0NZRN5JwFn6vyviYA4TiBrIrbnNxkEjhyqX/CtRLKXj3+GoEWfoKSO9Ey jgVr5QlWnj8F2vqnhjA9XmZXnKdlrAKzSS27NVDT2DqBAcY+hstYBNeRHEo+joeA09qsyCSz c77vyifESSKkNGNKomRcqpf+XGjUpRjT9IkLd+5LuUXGP6r3U8NIJakO/lFHBJ5owlU1MfFa tUJ3wHgopY4AT2umq+IeeRPUql26Q4clwz6tIS1ZMtaRmTyjiVAtvdK7XS0k6vZLeyUpVTJ8 Uyk+bEY6+XnZ8s5UM2v+OGmebW2/O3ow5mBUX21Eyb/r7OdXebbFmQPWbf6e91GqqPXv1nhi 6TE1k7Ei0l9YO2dz256Ni7YssSTGLVuTe+venqJrP5zta5m75OiUpNHf/3rVOjPwT2yCdlZv ZvnLXnfRb7bjply91ze/vHp4NKZedKSX1ocnazdpGGOSbvF82mDUfQErx4C+pAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH+93dbqe1PKbhtcJsFUTU7NTlo5hFRFxCUBS9rNRGHXPlXNzd JOuPlkTFLDOTqKz5MsyagZov07KYpmlNsRcyJTMTwcrwtVcza0v67+H7+T5fHvg+FK6cIFSU MVXihVR9ipr0JzzTLb2rvp/QJa1uy5gPZW12BP29Dhz6ct+SkDl6CoMu5zqod12XQc47KwZZ OWMYuG7ZSPjcl0HA8LgLg54HHjlce5Ehh/HGQTmc78hDMDj1CYerBRMIOuzVMvjZcI+Ekaki ArImXyG4UNWKoOXcGAG5dbUITttoGL1dIgdHTwiM97US4OmulMOdr89xqG77jeBiSxmC9tN/ ZOsXc5MFxTLOUf8R4y4VPse5x92X5dy5J3aMqxiuxbiRh69ILqvKibin/Zk4Vzrwg9zqr9PE CmaLxIcmm0VprXovC+EaNho04ZHRGjYiKiEmXKsOi4s9yKcY03ghLG6/JtlpTzxyZ/bRjgdT cis672dDfhRDRzK5j5pxG/KnlHQxYkomfiEboryAYYYG8BlPIDPVaSNnPBOI6X9bgnyApJcz nrN2zAeC6Dck8/LMScIHAuktzGRmxj8TQS9jrmQPy32hCjqGaZqmZkIXMaXlbtwn+3nl9z0J PllJGxl72zfZzBzCvM7/gmWjuQVolhMF8RbRZDCJrEbUm0RLqkFzwGy6i7yF1zz+WVmLXlRs b0Q0hdRzFO4YXZJSpk8T002NiKFwdZBiQ7snUak4qE8/xgvmJMGSwouNSOs97yKumnfA7H2f VCmJ1bJREM1GRURFrAF1sOIs3bBPSRv0En+Y54/wwv89jPJTWVFkWJ3jWcP+ojj/p833d4pL lzTtMdxAkyNS3rv3wRvL8+ta3WXdUjeR/+Ne5UnW+HK0Wjuwe1obmbAjsVOK7x013VwYvyBl 0/F+w5ChSxX0oSm0WXBvW+VM0NXviCgspQKOG1W7atLrXNYl962qzcGBuYf6Cm/ltcc/SQ74 JYtdqSbEZD27AhdE/V/czTLLBgMAAA== X-CMS-MailID: 20200910193519eucas1p10e3d3b0496590dfc30e41259f068c62f X-Msg-Generator: CA X-RootMTR: 20200910193519eucas1p10e3d3b0496590dfc30e41259f068c62f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193519eucas1p10e3d3b0496590dfc30e41259f068c62f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 23/24] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..347737cb9 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Thu Sep 10 19:33:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77244 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5017A04B5; Thu, 10 Sep 2020 21:37:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAEA61C1DD; Thu, 10 Sep 2020 21:35:24 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id CB2B91C1DC for ; Thu, 10 Sep 2020 21:35:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200910193523euoutp02afc74f4c115199d440583873a007d08d~zgy1k0PFn0500705007euoutp02c; Thu, 10 Sep 2020 19:35:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200910193523euoutp02afc74f4c115199d440583873a007d08d~zgy1k0PFn0500705007euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599766523; bh=jaolOMwppEWttOA38f35lGVL8aPkv9Cah3B7/iAVP9g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ZIxwWicJmqFm9gy9bALJC5U1QREzo6T0ITAj9ZLxnteFZbuiYm+pfiyDy4UIlq05L mMp9qKfjwVzMGlGceqxA1mcYcneMVS5gu3AQzYoaixab3c9zes83W9J10Z1dfK0c0h zER+ZXdnBZnH8NNkyf3oOpEbj+Pc3pfygbCJW7ok= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200910193523eucas1p10f223fb02b01561ad6b1e3a014b1cbf3~zgy1YnaVN2933129331eucas1p1m; Thu, 10 Sep 2020 19:35:23 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 3D.1D.06456.BFF7A5F5; Thu, 10 Sep 2020 20:35:23 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200910193522eucas1p102187e623e0e9649bd7b3e93a15a680a~zgy0gNKql0307203072eucas1p13; Thu, 10 Sep 2020 19:35:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200910193522eusmtrp28a2212d8add66ddcfb68a9fb48b165c7~zgy0fW5l-1027210272eusmtrp2C; Thu, 10 Sep 2020 19:35:22 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-ce-5f5a7ffb7cf5 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 41.29.06314.AFF7A5F5; Thu, 10 Sep 2020 20:35:22 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200910193520eusmtip2250855d0d168912a255b7b564e78a10d~zgyyxqXex1654016540eusmtip2N; Thu, 10 Sep 2020 19:35:20 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Thu, 10 Sep 2020 22:33:57 +0300 Message-Id: <20200910193400.15326-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200910193400.15326-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0wTZxjH99xd745izVl0PjIis4mJzqhrZpYnuOk0JLtFl2j8w0hU1o0L Eim4FnBumiFulVXXQYUxRQuCBi1qx6CUOp0IGxWLQ0iMNWEbOhInDpEKblCco1yX/ff9fp6f 75NXZPVlfKKYlZOnWHJM2QZeyzV3jHcvjXyalv7qiR/nkKfLBXTv11qW+st+4enQ488YCrlX 0yXfcQ05fytkyOEcYch3xs7Tn/1FHD0K+xjquxwU6FhvkUDhtvsCfdldCXR/cpClo9VPgLpd Xg2NX73I0/BkDUeOiVtAXzVdAwocHuGozN8CZLNL9PhsnUC1ffMp3H+No+CdRoHOjfWw5O16 BlQa8ADdsD3XvLVAnqg+rZFrLz1g5CMne1i5487Xgny408XIDY9aGHn4h1u87Ghyg3z93iFW rh/4m9+gTdO+kaFkZxUoluWr3tPu8JRUcLuc8R85RhrYQhgW7RAnorQCC8trODtoRb10BtDR Phgzo4C25oigmieA1yOTrB3E6ZIj9mSV1wH+tT/Eq2YM8PT5YSbal5cWYbDYxUQDs6UGHn2T t6cDCdJ6bH/oYqOakxais8bJRbVOSsGBUAerLpWM9d+2Tk+Lm+J3+7ZFsV6aj7erRqd7otQl 4qmKC5yan4rl4VJQdQIOBpoEVSfhc39VrOAgYGlzo6CaEsADlUOxrNXY9PBnITqNlRaj5+Jy Fa/BQL1Xoz55JoaGZkUxOyWdzRWxS+iw2KZXsw3Y2tkbw4jPIjNULKPr96exI14GHAi7+BJI Pvb/rGoAN8xV8q3mTMVqzFF2L7OazNb8nMxlH+Sav4Opvxr8JxBugbHe99tAEsEwQ9eakpau 15gKrHvMbYAia5itW3sjuF2vyzDt+Vix5KZb8rMVaxu8JHKGubrXah5s00uZpjxlp6LsUiz/ RRkxLrEQstcOvfPTvtrGXl6bymyXlHf3HWR6/C9vQXfu63sZZeE845Kt+k/ik4qTtrR3Rk6G FuSlZK0rCG4YHcdq44TX+GGVD/0bK793/1EUPyfP+zbWfREy2zJv7lzp9q+5a3wxsSDf9c3R 3V2NxVfWe0rWdW7+XJg1s7yOZ3WbXshKnfemgbPuMBlfYS1W078J9zVSpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3fVFpepdBvhY1BE0M35PDPT6EH3D6Gk/6ycQy9Tcpvs bpISZS+LaUtnZS+WTaKagVmaFj3MyFXTzIWapWYiVCrpfGSKZZvWf18+3/M958A5FC6dImRU ts7IG3TqHDnpT7j+OPs3zB1JVUWcn5ZBTasNwWB/FQ4D5/pIKB4/gcEHRxI8brgqAuvnQgws Vg8GDbfMJIwOHCPgx0QDBr1PXGK47D4mhonmr2I4034Fwdf5YRwuVU4iaLfVi2D2+SMSxubt BFjmOhGcrXuFwFniIeDcw0YERWYaxm/fFENVbwhMDLwiwNVzXwx3pjtwqG/9jaDMWYOgrWhB tCWcm6u8IeKqHn/HuPLrHTjX0nNBzJW8tmFc7Y9GjBt72klyljoH4t4MFuNc9dAvcrd/Kptg 0JuMfFiWXjBulu9VQCSrUAIbGa1kFVFx++MjY+QbExMy+ZzsPN6wMTGdzaoprSByrQEHLZ5a vBCNUWZEUQwdzZSbQ83In5LSNxBzqcsjXuIMMzKEm5GfVwYy811mcqlmEjG97gGRzyDpdYzr tA3zGUH0J5J5f+oo4TMC6WTmxYhtMU3Qaxir3brIJXQ8M/Sh5V/XUKb6bhPuG+bn5V969/uw lM5mbK0/RUs6hOm+NoWVohWVaJkDBfEmQavRCgpWUGsFk07DZui195D34g9aZu83InftnmZE U0i+XNIUn6qSitR5Qr62GTEULg+SbG1zpUklmer8At6gVxlMObzQjGK8+5XhsuAMvfd/dEaV IkYRB0pFXFRcVCzIV0pO08/3SWmN2sgf4Plc3vA/h1F+skJEHXINb66xm9apw5Jv64bTXAs2 zfGGl/n92g7724KIA8nhQbHwbEfSxW+HLcBr2HdrQnflbktcK5KRoyUjxRPbm0w7T97sSOub wadWiovig51fqgP6UmZeR11gv6867E5oW53eoyxZn/kxYu24LKEiRXnw1rfiTXawTNZ1j+5x yAkhS61YjxsE9V/ZearrBwMAAA== X-CMS-MailID: 20200910193522eucas1p102187e623e0e9649bd7b3e93a15a680a X-Msg-Generator: CA X-RootMTR: 20200910193522eucas1p102187e623e0e9649bd7b3e93a15a680a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200910193522eucas1p102187e623e0e9649bd7b3e93a15a680a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200910193400.15326-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v10 24/24] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..37c4a9c50 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */