Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64320/?format=api
{ "id": 64320, "url": "http://patches.dpdk.org/api/patches/64320/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200109031559.63194-10-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200109031559.63194-10-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200109031559.63194-10-huwei013@chinasoftinc.com", "date": "2020-01-09T03:15:57", "name": "[09/11] net/hns3: fix dumping VF register information", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f0111189bd634f1ae0c10049b5543fa602d8127", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200109031559.63194-10-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 8023, "url": "http://patches.dpdk.org/api/series/8023/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8023", "date": "2020-01-09T03:15:48", "name": "misc updates and fixes for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/8023/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64320/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64320/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 67D33A04F3;\n\tThu, 9 Jan 2020 04:24:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68ABC1DB6D;\n\tThu, 9 Jan 2020 04:23:50 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id A5CBE1DB3E\n for <dev@dpdk.org>; Thu, 9 Jan 2020 04:23:41 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id vwGCr2uLrQbXEV8k (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Thu, 09 Jan 2020 11:22:50 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Thu, 9 Jan 2020\n 11:16:13 +0800" ], "X-ASG-Debug-ID": "1578539509-0a3dd116d0042b0014-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 9 Jan 2020 11:15:57 +0800", "X-ASG-Orig-Subj": "[PATCH 09/11] net/hns3: fix dumping VF register information", "Message-ID": "<20200109031559.63194-10-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200109031559.63194-1-huwei013@chinasoftinc.com>", "References": "<20200109031559.63194-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1578540170", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "3053", "Subject": "[dpdk-dev] [PATCH 09/11] net/hns3: fix dumping VF register\n\tinformation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nCurrently, when the API interface named rte_eth_dev_get_reg_info is called\nby upper applications based on VF device, it returns error.\n\nWe can read registers directly to get ring and interrupt related\ninformation in hns3 PF/VF PMD driver. But for some other internal table\nentries and common configuration information, we can get them only\nthrough the command interface between driver and firmware in PF driver,\nand VF driver has not the related access permission.\n\nThis patch fixes it by preventing getting these information through the\ncommand interface based on VF device in 'get_reg' ops implementation\nfunction.\n\nFixes: 936eda25e8da (\"net/hns3: support dump register\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_regs.c | 29 ++++++++++++++++++-----------\n 1 file changed, 18 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c\nindex 23405030e..a3f2a51f9 100644\n--- a/drivers/net/hns3/hns3_regs.c\n+++ b/drivers/net/hns3/hns3_regs.c\n@@ -118,15 +118,9 @@ hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length)\n \tstruct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);\n \tint cmdq_lines, common_lines, ring_lines, tqp_intr_lines;\n \tuint32_t regs_num_32_bit, regs_num_64_bit;\n+\tuint32_t len;\n \tint ret;\n \n-\tret = hns3_get_regs_num(hw, ®s_num_32_bit, ®s_num_64_bit);\n-\tif (ret) {\n-\t\thns3_err(hw, \"Get register number failed, ret = %d.\",\n-\t\t\t ret);\n-\t\treturn -ENOTSUP;\n-\t}\n-\n \tcmdq_lines = sizeof(cmdq_reg_addrs) / REG_LEN_PER_LINE + 1;\n \tif (hns->is_vf)\n \t\tcommon_lines =\n@@ -136,11 +130,21 @@ hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length)\n \tring_lines = sizeof(ring_reg_addrs) / REG_LEN_PER_LINE + 1;\n \ttqp_intr_lines = sizeof(tqp_intr_reg_addrs) / REG_LEN_PER_LINE + 1;\n \n-\t*length = (cmdq_lines + common_lines + ring_lines * hw->tqps_num +\n-\t\t tqp_intr_lines * hw->num_msi) * REG_LEN_PER_LINE +\n-\t\t regs_num_32_bit * sizeof(uint32_t) +\n-\t\t regs_num_64_bit * sizeof(uint64_t);\n+\tlen = (cmdq_lines + common_lines + ring_lines * hw->tqps_num +\n+\t tqp_intr_lines * hw->num_msi) * REG_LEN_PER_LINE;\n \n+\tif (!hns->is_vf) {\n+\t\tret = hns3_get_regs_num(hw, ®s_num_32_bit, ®s_num_64_bit);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"Get register number failed, ret = %d.\",\n+\t\t\t\t ret);\n+\t\t\treturn -ENOTSUP;\n+\t\t}\n+\t\tlen += regs_num_32_bit * sizeof(uint32_t) +\n+\t\t regs_num_64_bit * sizeof(uint64_t);\n+\t}\n+\n+\t*length = len;\n \treturn 0;\n }\n \n@@ -346,6 +350,9 @@ hns3_get_regs(struct rte_eth_dev *eth_dev, struct rte_dev_reg_info *regs)\n \t/* fetching per-PF registers values from PF PCIe register space */\n \thns3_direct_access_regs(hw, data);\n \n+\tif (hns->is_vf)\n+\t\treturn 0;\n+\n \tret = hns3_get_regs_num(hw, ®s_num_32_bit, ®s_num_64_bit);\n \tif (ret) {\n \t\thns3_err(hw, \"Get register number failed, ret = %d\", ret);\n", "prefixes": [ "09/11" ] }