Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58390/?format=api
{ "id": 58390, "url": "http://patches.dpdk.org/api/patches/58390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190902121734.926-11-akhil.goyal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190902121734.926-11-akhil.goyal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190902121734.926-11-akhil.goyal@nxp.com", "date": "2019-09-02T12:17:24", "name": "[10/20] crypto/dpaa2_sec: disable 'write-safe' for PDCP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bda91630e99525629980e7646a1974a93722a0bf", "submitter": { "id": 517, "url": "http://patches.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190902121734.926-11-akhil.goyal@nxp.com/mbox/", "series": [ { "id": 6199, "url": "http://patches.dpdk.org/api/series/6199/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6199", "date": "2019-09-02T12:17:14", "name": "crypto/dpaaX_sec: Support Wireless algos", "version": 1, "mbox": "http://patches.dpdk.org/series/6199/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58390/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52DC31E949;\n\tMon, 2 Sep 2019 14:32:35 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id 7143F1D155\n\tfor <dev@dpdk.org>; Mon, 2 Sep 2019 14:32:08 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 5494F1A0697;\n\tMon, 2 Sep 2019 14:32:08 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 7F91D1A02F6;\n\tMon, 2 Sep 2019 14:32:06 +0200 (CEST)", "from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 4BF194032A;\n\tMon, 2 Sep 2019 20:32:02 +0800 (SGT)" ], "From": "Akhil Goyal <akhil.goyal@nxp.com>", "To": "dev@dpdk.org", "Cc": "hemant.agrawal@nxp.com,\n\tvakul.garg@nxp.com", "Date": "Mon, 2 Sep 2019 17:47:24 +0530", "Message-Id": "<20190902121734.926-11-akhil.goyal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190902121734.926-1-akhil.goyal@nxp.com>", "References": "<20190902121734.926-1-akhil.goyal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 10/20] crypto/dpaa2_sec: disable 'write-safe' for\n\tPDCP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vakul Garg <vakul.garg@nxp.com>\n\nPDCP descriptors in some cases internally use commands which overwrite\nmemory with extra '0s' if write-safe is kept enabled. This breaks\ncorrect functional behavior of PDCP apis and they in many cases give\nincorrect crypto output. There we disable 'write-safe' bit in FLC for\nPDCP cases. If there is a performance drop, then write-safe would be\nenabled selectively through a separate patch.\n\nSigned-off-by: Vakul Garg <vakul.garg@nxp.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex cbc7dff04..c9029e989 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -2899,8 +2899,12 @@ dpaa2_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \n \tflc->word1_sdl = (uint8_t)bufsize;\n \n-\t/* Set EWS bit i.e. enable write-safe */\n-\tDPAA2_SET_FLC_EWS(flc);\n+\t/* TODO - check the perf impact or\n+\t * align as per descriptor type\n+\t * Set EWS bit i.e. enable write-safe\n+\t * DPAA2_SET_FLC_EWS(flc);\n+\t */\n+\n \t/* Set BS = 1 i.e reuse input buffers as output buffers */\n \tDPAA2_SET_FLC_REUSE_BS(flc);\n \t/* Set FF = 10; reuse input buffers if they provide sufficient space */\n", "prefixes": [ "10/20" ] }