Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35062,
    "url": "http://patches.dpdk.org/api/patches/35062/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180208120803.95060-1-ferruh.yigit@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180208120803.95060-1-ferruh.yigit@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180208120803.95060-1-ferruh.yigit@intel.com",
    "date": "2018-02-08T12:08:03",
    "name": "[dpdk-dev] app/testpmd: enable CRC strip without capability check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c3e24cb7b600c61b2350ed0b729d07b82b2f101a",
    "submitter": {
        "id": 324,
        "url": "http://patches.dpdk.org/api/people/324/?format=api",
        "name": "Ferruh Yigit",
        "email": "ferruh.yigit@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180208120803.95060-1-ferruh.yigit@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35062/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/35062/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B38AB1B7C3;\n\tThu,  8 Feb 2018 13:08:14 +0100 (CET)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 21FF91B7BF\n\tfor <dev@dpdk.org>; Thu,  8 Feb 2018 13:08:12 +0100 (CET)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Feb 2018 04:08:11 -0800",
            "from silpixa00372839.ir.intel.com (HELO\n\tsilpixa00372839.ger.corp.intel.com) ([10.237.222.154])\n\tby FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2018 04:08:10 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.46,478,1511856000\"; d=\"scan'208\";a=\"25840959\"",
        "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
        "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>,\n\tJingjing Wu <jingjing.wu@intel.com>",
        "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, motih@mellanox.com,\n\tshahafs@mellanox.com",
        "Date": "Thu,  8 Feb 2018 12:08:03 +0000",
        "Message-Id": "<20180208120803.95060-1-ferruh.yigit@intel.com>",
        "X-Mailer": "git-send-email 2.14.3",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability\n\tcheck",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Some hardware doesn't support disabling CRC strip. In techboard it has\nbeen decided to enable CRC strip always.\n\nThe testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if\nPMD reports CRC strip capability. Not all PMDs updated to report CRC\nstrip.\n\nFor the PMDs not reporting CRC strip testpmd behavior changed and\ndisabling CRC strip for them. And this may generate error for PMDs that\ndoesn't support disabling CRC strip.\n\nRemoving capability check for this release. In long term there can be\noption to remove CRC strip flag completely or adding a new flag to let\nPMD say disabling is not supported.\n\nFixes: 8b9bd0efe0b6 (\"app/testpmd: disable Rx VLAN offloads by default\")\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: motih@mellanox.com\nCc: shahafs@mellanox.com\n---\n app/test-pmd/testpmd.c | 4 ----\n 1 file changed, 4 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 46dc22c94..4c0e2586c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -694,10 +694,6 @@ init_config(void)\n \t\t      DEV_TX_OFFLOAD_MBUF_FAST_FREE))\n \t\t\tport->dev_conf.txmode.offloads &=\n \t\t\t\t~DEV_TX_OFFLOAD_MBUF_FAST_FREE;\n-\t\tif (!(port->dev_info.rx_offload_capa &\n-\t\t      DEV_RX_OFFLOAD_CRC_STRIP))\n-\t\t\tport->dev_conf.rxmode.offloads &=\n-\t\t\t\t~DEV_RX_OFFLOAD_CRC_STRIP;\n \t\tif (numa_support) {\n \t\t\tif (port_numa[pid] != NUMA_NO_CONFIG)\n \t\t\t\tport_per_socket[port_numa[pid]]++;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}