From patchwork Thu Feb 8 12:08:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 35062 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B38AB1B7C3; Thu, 8 Feb 2018 13:08:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 21FF91B7BF for ; Thu, 8 Feb 2018 13:08:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 04:08:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="25840959" Received: from silpixa00372839.ir.intel.com (HELO silpixa00372839.ger.corp.intel.com) ([10.237.222.154]) by FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2018 04:08:10 -0800 From: Ferruh Yigit To: Wenzhuo Lu , Jingjing Wu Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon , Konstantin Ananyev , motih@mellanox.com, shahafs@mellanox.com Date: Thu, 8 Feb 2018 12:08:03 +0000 Message-Id: <20180208120803.95060-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.14.3 Subject: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some hardware doesn't support disabling CRC strip. In techboard it has been decided to enable CRC strip always. The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if PMD reports CRC strip capability. Not all PMDs updated to report CRC strip. For the PMDs not reporting CRC strip testpmd behavior changed and disabling CRC strip for them. And this may generate error for PMDs that doesn't support disabling CRC strip. Removing capability check for this release. In long term there can be option to remove CRC strip flag completely or adding a new flag to let PMD say disabling is not supported. Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default") Signed-off-by: Ferruh Yigit Acked-by: Konstantin Ananyev --- Cc: motih@mellanox.com Cc: shahafs@mellanox.com --- app/test-pmd/testpmd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 46dc22c94..4c0e2586c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -694,10 +694,6 @@ init_config(void) DEV_TX_OFFLOAD_MBUF_FAST_FREE)) port->dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MBUF_FAST_FREE; - if (!(port->dev_info.rx_offload_capa & - DEV_RX_OFFLOAD_CRC_STRIP)) - port->dev_conf.rxmode.offloads &= - ~DEV_RX_OFFLOAD_CRC_STRIP; if (numa_support) { if (port_numa[pid] != NUMA_NO_CONFIG) port_per_socket[port_numa[pid]]++;