Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28391/?format=api
{ "id": 28391, "url": "http://patches.dpdk.org/api/patches/28391/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170905205159.8606-7-luca.boccassi@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170905205159.8606-7-luca.boccassi@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170905205159.8606-7-luca.boccassi@gmail.com", "date": "2017-09-05T20:51:59", "name": "[dpdk-dev,v7,6/6] mk: install symlinks before build step", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9eab42a0488a9aa15f233cfd7038657a07f7d5c7", "submitter": { "id": 566, "url": "http://patches.dpdk.org/api/people/566/?format=api", "name": "Luca Boccassi", "email": "luca.boccassi@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170905205159.8606-7-luca.boccassi@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/28391/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/28391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1ACE55699;\n\tTue, 5 Sep 2017 22:52:59 +0200 (CEST)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 6B6A32C17\n\tfor <dev@dpdk.org>; Tue, 5 Sep 2017 22:52:58 +0200 (CEST)", "by mail-wm0-f65.google.com with SMTP id l19so877623wmi.1\n\tfor <dev@dpdk.org>; Tue, 05 Sep 2017 13:52:58 -0700 (PDT)", "from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749])\n\tby smtp.gmail.com with ESMTPSA id\n\tb58sm2149617wrg.86.2017.09.05.13.52.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 13:52:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=mrHLRNhAY2CCHx0ZLOkaIqdgXXm6NxZ1nee3UcaQUW8=;\n\tb=ce+GidreIGQ/o4AEr2ErXWn0UIaeoNbOlmIzkBif2W0RdKJY7/8lsuDS9e2G/nTtIW\n\txiOu1DVj0njgsN0YB0PkLtH6zfpTx3OlJE4coahntdnEhWnPHf9hQv8N3eOn+oOk2fdb\n\trear5c+CDUOcRsrWCYKJruZiL0mRqzP4CFLUzR0CNzjkiGkHhb5AOVhzXhF0WuECH2Qy\n\tHKfYoyZkMhYUv29VoA37cccOzxGoMPqwTOUq2PAk6Ij+8OvRBRRn97K8tfNSHA/tpKrK\n\tJJFNHTN6DDy5C5XoRwXtTInpsP+uzDdFDjvv0Q1mJsvWp+Ywhhl8Kr+c9WVXzUcyKvcP\n\tHMfQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=mrHLRNhAY2CCHx0ZLOkaIqdgXXm6NxZ1nee3UcaQUW8=;\n\tb=KSo9kMpcjG+eT/tPRExQSK9BfQjB24pkB8XQ+ZcwWwmYcFmfxGmYeXEqNrSI9Idqfo\n\tBmVzZEVfXStAfKEhrMXR5H20zzzSxC5plIupdkT/NxuCcOB+3oBEPYLA+4KQDww0jS5m\n\tCcyO7kqJEmrfk/pxPy2ALRmatPBteHet7aTdUVe08BehgKKWrn4vvWprODewO8tNt6pZ\n\t0O3AQ7YI/1h7SX43M7BeZqRkNuD0sqdvBud1FXSqdcl+mKQ7Zq/TONhmxg+VkZNiAv4y\n\t2intH8T5D5x+WEz7ih/ChGxsxJRuC5cGkbl2/G9H4HvpjJGeUKCW/+R4fRrCfTmN9sm7\n\t2Igg==", "X-Gm-Message-State": "AHPjjUhihAAw80JjkmcdIVdDpQnfWsEV7HncPeFHy8Xcw/Pv3b829MDT\n\tlqRAJG40BpcgikanXYs=", "X-Google-Smtp-Source": "ADKCNb7APoj0qwZGtXR5Y/C+fegJfmRXcaajrV/GAU0Cn11/Rovy4s/FNeKABwBmShpxOlLpRXg2vg==", "X-Received": "by 10.28.158.200 with SMTP id h191mr136687wme.25.1504644777783; \n\tTue, 05 Sep 2017 13:52:57 -0700 (PDT)", "From": "luca.boccassi@gmail.com", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tLuca Boccassi <luca.boccassi@gmail.com>", "Date": "Tue, 5 Sep 2017 21:51:59 +0100", "Message-Id": "<20170905205159.8606-7-luca.boccassi@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170905205159.8606-1-luca.boccassi@gmail.com>", "References": "<drivers/net/vmxnet3/vmxnet3_rxtx.c.rej>\n\t<20170905205159.8606-1-luca.boccassi@gmail.com>", "Subject": "[dpdk-dev] [PATCH v7 6/6] mk: install symlinks before build step", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Luca Boccassi <luca.boccassi@gmail.com>\n\nA race condition can happen during parallel builds, where a header\nmight be installed in RTE_OUT/include before CFLAGS is recursively\nexpanded. This causes GCC to sometimes pick the header path as\nSRCDIR/... and sometimes as RTE_OUT/include/... making the build\nunreproducible, as the full path is used for the expansion of\n__FILE__ and in the DWARF directory listing.\n\nInstalling all symlinks before all builds solves the problem. It is\nstill suboptimal, as the (fixed) path recorded in the DWARF dir\nlisting will include the user-configurable build output directory,\nand thus will result in a different binary between different users\ndespite all other conditions being equal, but it is a simpler\napproach that will anyway be obsolete once the build system is\nswitched to Meson.\n\nSuggested-by: Ferruh Yigit <ferruh.yigit@intel.com>\nSigned-off-by: Luca Boccassi <luca.boccassi@gmail.com>\n---\n mk/rte.lib.mk | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 13115d146..643da47da 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -59,14 +59,19 @@ endif\n \n \n _BUILD = $(LIB)\n-_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)\n+PREINSTALL = $(SYMLINK-FILES-y)\n+_INSTALL = $(INSTALL-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)\n _CLEAN = doclean\n \n .PHONY: all\n all: install\n \n .PHONY: install\n+ifeq ($(SYMLINK-FILES-y),)\n install: build _postinstall\n+else\n+install: _preinstall build _postinstall\n+endif\n \n _postinstall: build\n \n", "prefixes": [ "dpdk-dev", "v7", "6/6" ] }