Message ID | 20170905205159.8606-7-luca.boccassi@gmail.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
05/09/2017 22:51, luca.boccassi@gmail.com: > .PHONY: install > +ifeq ($(SYMLINK-FILES-y),) > install: build _postinstall > +else > +install: _preinstall build _postinstall > +endif I think you cannot be sure that "_preinstall" will be finished before the "build" target starts in parallel make. Am I missing something?
On Thu, 2017-10-12 at 04:58 +0200, Thomas Monjalon wrote: > 05/09/2017 22:51, luca.boccassi@gmail.com: > > .PHONY: install > > +ifeq ($(SYMLINK-FILES-y),) > > install: build _postinstall > > +else > > +install: _preinstall build _postinstall > > +endif > > I think you cannot be sure that "_preinstall" will be finished > before the "build" target starts in parallel make. > Am I missing something? Yes, you are right, good catch. I'll add a dependency: build: _preinstall Which should take care of it, retest and send a new version.
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 13115d146..643da47da 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -59,14 +59,19 @@ endif _BUILD = $(LIB) -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) +PREINSTALL = $(SYMLINK-FILES-y) +_INSTALL = $(INSTALL-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) _CLEAN = doclean .PHONY: all all: install .PHONY: install +ifeq ($(SYMLINK-FILES-y),) install: build _postinstall +else +install: _preinstall build _postinstall +endif _postinstall: build