Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14549/?format=api
{ "id": 14549, "url": "http://patches.dpdk.org/api/patches/14549/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1467703226-11836-1-git-send-email-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467703226-11836-1-git-send-email-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467703226-11836-1-git-send-email-i.maximets@samsung.com", "date": "2016-07-05T07:20:26", "name": "[dpdk-dev] app/testpmd: refactor of RSS fwd config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "86f4dbbd183794a832fec146a6562954ddca7ea3", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1467703226-11836-1-git-send-email-i.maximets@samsung.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14549/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14549/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5F09B47CD;\n\tTue, 5 Jul 2016 09:20:41 +0200 (CEST)", "from mailout4.w1.samsung.com (mailout4.w1.samsung.com\n\t[210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 3DF192C17\n\tfor <dev@dpdk.org>; Tue, 5 Jul 2016 09:20:40 +0200 (CEST)", "from eucpsbgm1.samsung.com (unknown [203.254.199.244])\n\tby mailout4.w1.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTP id <0O9T005XXZ2EA630@mailout4.w1.samsung.com> for\n\tdev@dpdk.org; Tue, 05 Jul 2016 08:20:38 +0100 (BST)", "from eusync2.samsung.com ( [203.254.199.212])\n\tby eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 88.ED.05254.6CF5B775;\n\tTue, 5 Jul 2016 08:20:38 +0100 (BST)", "from imaximets.rnd.samsung.ru ([106.109.129.180])\n\tby eusync2.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTPA id <0O9T00HE1Z292780@eusync2.samsung.com>; Tue,\n\t05 Jul 2016 08:20:38 +0100 (BST)" ], "X-AuditID": "cbfec7f4-f796c6d000001486-75-577b5fc6469a", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "Dyasly Sergey <s.dyasly@samsung.com>,\n\tHeetae Ahn <heetae82.ahn@samsung.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, \n\tIlya Maximets <i.maximets@samsung.com>", "Date": "Tue, 05 Jul 2016 10:20:26 +0300", "Message-id": "<1467703226-11836-1-git-send-email-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.7.4", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFnrLJMWRmVeSWpSXmKPExsVy+t/xK7rH4qvDDSae4rZ492k7k8W0z7fZ\n\tLa60/2S3OLpwG7PF5NlSFpsvTmJyYPP4tWApq8fiPS+ZPPq2rGIMYI7isklJzcksSy3St0vg\n\tymj6FlJwTaBi7p9NTA2M03i7GDk5JARMJBbePswCYYtJXLi3nq2LkYtDSGApo8Te/ZuYIZxW\n\tJokZmz6BVbEJ6EicWn2EEcQWEXCQeL1jF1gRs8AiRokN606DFQkLWEis2dYMVsQioCrxatcU\n\tJhCbV8BNorPtFSPEOjmJm+c6mScwci9gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERII\n\tX3YwLj5mdYhRgINRiYf3xMKqcCHWxLLiytxDjBIczEoivB9jqsOFeFMSK6tSi/Lji0pzUosP\n\tMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwKivyHLeao3PGn//4Bf3Tm9b68S/5Gmz\n\tVLNp4zWhvL41rwRu2/7TYzVPsX8d/akobuMM/rK4KZYVs76/Y88/vlpbUNRxGm/qDpmDmSv3\n\tRp68tbo95owjh6/29q/i5TkvGV62hPqskKl+YvNJ4p6TQeiGa2fXFlbcrHT6r1TL4L/t05tf\n\tr5wcbiuxFGckGmoxFxUnAgDsXiAvAAIAAA==", "Subject": "[dpdk-dev] [PATCH] app/testpmd: refactor of RSS fwd config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since\ncommit f2bb7ae1d204 (\"app/testpmd: handle all Rx queues in RSS setup\")\nbehavior of rss_fwd_config_setup() changed and description of this\nfunction is wrong now.\n\nAlso, there is a type mismatch in a loop.\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n app/test-pmd/config.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex c5865f9..bfcbff9 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1201,14 +1201,9 @@ simple_fwd_config_setup(void)\n }\n \n /**\n- * For the RSS forwarding test, each core is assigned on every port a transmit\n- * queue whose index is the index of the core itself. This approach limits the\n- * maximumm number of processing cores of the RSS test to the maximum number of\n- * TX queues supported by the devices.\n- *\n- * Each core is assigned a single stream, each stream being composed of\n- * a RX queue to poll on a RX port for input messages, associated with\n- * a TX queue of a TX port where to send forwarded packets.\n+ * For the RSS forwarding test all streams distributed over lcores. Each stream\n+ * being composed of a RX queue to poll on a RX port for input messages,\n+ * associated with a TX queue of a TX port where to send forwarded packets.\n * All packets received on the RX queue of index \"RxQj\" of the RX port \"RxPi\"\n * are sent on the TX queue \"TxQl\" of the TX port \"TxPk\" according to the two\n * following rules:\n@@ -1222,7 +1217,7 @@ rss_fwd_config_setup(void)\n \tportid_t txp;\n \tqueueid_t rxq;\n \tqueueid_t nb_q;\n-\tlcoreid_t lc_id;\n+\tstreamid_t sm_id;\n \n \tnb_q = nb_rxq;\n \tif (nb_q > nb_txq)\n@@ -1241,10 +1236,10 @@ rss_fwd_config_setup(void)\n \n \tsetup_fwd_config_of_each_lcore(&cur_fwd_config);\n \trxp = 0; rxq = 0;\n-\tfor (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_streams; lc_id++) {\n+\tfor (sm_id = 0; sm_id < cur_fwd_config.nb_fwd_streams; sm_id++) {\n \t\tstruct fwd_stream *fs;\n \n-\t\tfs = fwd_streams[lc_id];\n+\t\tfs = fwd_streams[sm_id];\n \n \t\tif ((rxp & 0x1) == 0)\n \t\t\ttxp = (portid_t) (rxp + 1);\n", "prefixes": [ "dpdk-dev" ] }