From patchwork Tue Jul 5 07:20:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 14549 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5F09B47CD; Tue, 5 Jul 2016 09:20:41 +0200 (CEST) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 3DF192C17 for ; Tue, 5 Jul 2016 09:20:40 +0200 (CEST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9T005XXZ2EA630@mailout4.w1.samsung.com> for dev@dpdk.org; Tue, 05 Jul 2016 08:20:38 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-75-577b5fc6469a Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 88.ED.05254.6CF5B775; Tue, 5 Jul 2016 08:20:38 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O9T00HE1Z292780@eusync2.samsung.com>; Tue, 05 Jul 2016 08:20:38 +0100 (BST) From: Ilya Maximets To: dev@dpdk.org, Pablo de Lara Cc: Dyasly Sergey , Heetae Ahn , Zhihong Wang , Ilya Maximets Date: Tue, 05 Jul 2016 10:20:26 +0300 Message-id: <1467703226-11836-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLJMWRmVeSWpSXmKPExsVy+t/xK7rH4qvDDSae4rZ492k7k8W0z7fZ La60/2S3OLpwG7PF5NlSFpsvTmJyYPP4tWApq8fiPS+ZPPq2rGIMYI7isklJzcksSy3St0vg ymj6FlJwTaBi7p9NTA2M03i7GDk5JARMJBbePswCYYtJXLi3nq2LkYtDSGApo8Te/ZuYIZxW JokZmz6BVbEJ6EicWn2EEcQWEXCQeL1jF1gRs8AiRokN606DFQkLWEis2dYMVsQioCrxatcU JhCbV8BNorPtFSPEOjmJm+c6mScwci9gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERII X3YwLj5mdYhRgINRiYf3xMKqcCHWxLLiytxDjBIczEoivB9jqsOFeFMSK6tSi/Lji0pzUosP MUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwKivyHLeao3PGn//4Bf3Tm9b68S/5Gmz VLNp4zWhvL41rwRu2/7TYzVPsX8d/akobuMM/rK4KZYVs76/Y88/vlpbUNRxGm/qDpmDmSv3 Rp68tbo95owjh6/29q/i5TkvGV62hPqskKl+YvNJ4p6TQeiGa2fXFlbcrHT6r1TL4L/t05tf r5wcbiuxFGckGmoxFxUnAgDsXiAvAAIAAA== Subject: [dpdk-dev] [PATCH] app/testpmd: refactor of RSS fwd config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since commit f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup") behavior of rss_fwd_config_setup() changed and description of this function is wrong now. Also, there is a type mismatch in a loop. Signed-off-by: Ilya Maximets --- app/test-pmd/config.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index c5865f9..bfcbff9 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1201,14 +1201,9 @@ simple_fwd_config_setup(void) } /** - * For the RSS forwarding test, each core is assigned on every port a transmit - * queue whose index is the index of the core itself. This approach limits the - * maximumm number of processing cores of the RSS test to the maximum number of - * TX queues supported by the devices. - * - * Each core is assigned a single stream, each stream being composed of - * a RX queue to poll on a RX port for input messages, associated with - * a TX queue of a TX port where to send forwarded packets. + * For the RSS forwarding test all streams distributed over lcores. Each stream + * being composed of a RX queue to poll on a RX port for input messages, + * associated with a TX queue of a TX port where to send forwarded packets. * All packets received on the RX queue of index "RxQj" of the RX port "RxPi" * are sent on the TX queue "TxQl" of the TX port "TxPk" according to the two * following rules: @@ -1222,7 +1217,7 @@ rss_fwd_config_setup(void) portid_t txp; queueid_t rxq; queueid_t nb_q; - lcoreid_t lc_id; + streamid_t sm_id; nb_q = nb_rxq; if (nb_q > nb_txq) @@ -1241,10 +1236,10 @@ rss_fwd_config_setup(void) setup_fwd_config_of_each_lcore(&cur_fwd_config); rxp = 0; rxq = 0; - for (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_streams; lc_id++) { + for (sm_id = 0; sm_id < cur_fwd_config.nb_fwd_streams; sm_id++) { struct fwd_stream *fs; - fs = fwd_streams[lc_id]; + fs = fwd_streams[sm_id]; if ((rxp & 0x1) == 0) txp = (portid_t) (rxp + 1);