Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138256/?format=api
{ "id": 138256, "url": "http://patches.dpdk.org/api/patches/138256/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240312180716.8515-6-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240312180716.8515-6-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240312180716.8515-6-shaibran@amazon.com", "date": "2024-03-12T18:06:50", "name": "[v4,05/31] net/ena: fix fast mbuf free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d599e0eecaa06cb1d32de7a108a1ad244be635f8", "submitter": { "id": 2930, "url": "http://patches.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240312180716.8515-6-shaibran@amazon.com/mbox/", "series": [ { "id": 31487, "url": "http://patches.dpdk.org/api/series/31487/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31487", "date": "2024-03-12T18:06:45", "name": "net/ena: v2.9.0 driver release", "version": 4, "mbox": "http://patches.dpdk.org/series/31487/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/138256/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/138256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4EF3743C94;\n\tTue, 12 Mar 2024 19:08:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE81D42E1D;\n\tTue, 12 Mar 2024 19:07:48 +0100 (CET)", "from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com\n [207.171.190.10])\n by mails.dpdk.org (Postfix) with ESMTP id 04B9B42E00;\n Tue, 12 Mar 2024 19:07:45 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-33001.sea14.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 18:07:39 +0000", "from EX19MTAEUB002.ant.amazon.com [10.0.43.254:15483]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.19.132:2525]\n with esmtp (Farcaster)\n id 474039b7-f110-4e15-abfe-2ac890e4464a;\n Tue, 12 Mar 2024 18:07:36 +0000 (UTC)", "from EX19D007EUA002.ant.amazon.com (10.252.50.68) by\n EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Tue, 12 Mar 2024 18:07:36 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Tue, 12 Mar 2024 18:07:35 +0000", "from HFA15-CG15235BS.amazon.com (10.85.143.174) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Tue, 12 Mar 2024 18:07:34 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1710266867; x=1741802867;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=jRXvh33M8au2hnsqdeTPPMIXMaeIaAg2AlxhoKCiUSU=;\n b=JNc2YrLMTNAMxk40CWVNqGDDjWvv902XVoapxFKFmcgYrwhtMv1TUiIV\n s3AOivut07iA8myoqe3tviiuTHdrpoU4HntL0OCxi262YAEegvIMw/Jck\n 8qCf8IdpNaYh1hJFv1kTQCW8kmkDG1SIs9WP6O5eCWipp4dKeYIJ6QG89 o=;", "X-IronPort-AV": "E=Sophos;i=\"6.07,119,1708387200\"; d=\"scan'208\";a=\"332398150\"", "X-Farcaster-Flow-ID": "474039b7-f110-4e15-abfe-2ac890e4464a", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>, <stable@dpdk.org>", "Subject": "[PATCH v4 05/31] net/ena: fix fast mbuf free", "Date": "Tue, 12 Mar 2024 20:06:50 +0200", "Message-ID": "<20240312180716.8515-6-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240312180716.8515-1-shaibran@amazon.com>", "References": "<20240312180716.8515-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nIn case the application enables fast mbuf release optimization,\nthe driver releases 256 TX mbufs in bulk upon reaching the\nTX free threshold.\nThe existing implementation utilizes rte_mempool_put_bulk for bulk\nfreeing TXs, which exclusively supports direct mbufs.\nIn case the application transmits indirect bufs, the driver must\nalso decrement the mbuf reference count and unlink the mbuf segment.\nFor such case, the driver should employ rte_pktmbuf_free_bulk.\n\nFixes: c339f53823f3 (\"net/ena: support fast mbuf free\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 6 ++----\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex a30be47241..cbd4669cbb 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -107,6 +107,7 @@ New Features\n \n * Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.\n * Added support for sub-optimal configuration notifications from the device.\n+ * Restructured fast release of mbufs when RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE optimization is enabled.\n \n * **Updated Atomic Rules' Arkville driver.**\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 3157237c0d..537ee9f8c3 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -3122,8 +3122,7 @@ ena_tx_cleanup_mbuf_fast(struct rte_mbuf **mbufs_to_clean,\n \t\tm_next = mbuf->next;\n \t\tmbufs_to_clean[mbuf_cnt++] = mbuf;\n \t\tif (mbuf_cnt == buf_size) {\n-\t\t\trte_mempool_put_bulk(mbufs_to_clean[0]->pool, (void **)mbufs_to_clean,\n-\t\t\t\t(unsigned int)mbuf_cnt);\n+\t\t\trte_pktmbuf_free_bulk(mbufs_to_clean, mbuf_cnt);\n \t\t\tmbuf_cnt = 0;\n \t\t}\n \t\tmbuf = m_next;\n@@ -3191,8 +3190,7 @@ static int ena_tx_cleanup(void *txp, uint32_t free_pkt_cnt)\n \t}\n \n \tif (mbuf_cnt != 0)\n-\t\trte_mempool_put_bulk(mbufs_to_clean[0]->pool,\n-\t\t\t(void **)mbufs_to_clean, mbuf_cnt);\n+\t\trte_pktmbuf_free_bulk(mbufs_to_clean, mbuf_cnt);\n \n \t/* Notify completion handler that full cleanup was performed */\n \tif (free_pkt_cnt == 0 || total_tx_pkts < cleanup_budget)\n", "prefixes": [ "v4", "05/31" ] }