Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137807/?format=api
{ "id": 137807, "url": "http://patches.dpdk.org/api/patches/137807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240302135328.531940-8-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240302135328.531940-8-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240302135328.531940-8-mattias.ronnblom@ericsson.com", "date": "2024-03-02T13:53:28", "name": "[RFC,7/7] eal: deprecate relaxed family of bit operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2861b5101f07b5d827051d3961c0931fcf7a2ca6", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240302135328.531940-8-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31345, "url": "http://patches.dpdk.org/api/series/31345/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31345", "date": "2024-03-02T13:53:21", "name": "Improve EAL bit operations API", "version": 1, "mbox": "http://patches.dpdk.org/series/31345/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137807/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/137807/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35C5643C3A;\n\tSat, 2 Mar 2024 15:03:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 74BE142DE7;\n\tSat, 2 Mar 2024 15:02:26 +0100 (CET)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-db3eur04on2059.outbound.protection.outlook.com [40.107.6.59])\n by mails.dpdk.org (Postfix) with ESMTP id 5E01642DB6\n for <dev@dpdk.org>; Sat, 2 Mar 2024 15:02:21 +0100 (CET)", "from AS4PR09CA0007.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::8)\n by AS8PR07MB7973.eurprd07.prod.outlook.com (2603:10a6:20b:396::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.37; Sat, 2 Mar\n 2024 14:02:19 +0000", "from AM4PEPF00027A6A.eurprd04.prod.outlook.com\n (2603:10a6:20b:5e0:cafe::4b) by AS4PR09CA0007.outlook.office365.com\n (2603:10a6:20b:5e0::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.34 via Frontend\n Transport; Sat, 2 Mar 2024 14:02:19 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AM4PEPF00027A6A.mail.protection.outlook.com (10.167.16.88) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7362.11 via Frontend Transport; Sat, 2 Mar 2024 14:02:19 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server\n id 15.2.1258.12; Sat, 2 Mar 2024 15:02:18 +0100", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n 7EB831C006A; Sat, 2 Mar 2024 15:02:18 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lyl5gM3x8R3NRvoUZPEZC0FJntKkfcaaDJWsSoxkzGDGL9mQ7is20tLggBY/vYkN829ktZ/J1aC0sf0PaXPAiR2F4deHSS2PZtF/C0EE9xIO/8hb7TQSW6Qz3tyBcP22Bp4w32odK3p3T/WquQNMX1EcQYDvmeMTEC37cZFs82sApGf/vleFI3REbISwccGlLF8Laqw4YxePbApYBL8B4HSAzoWHg4louz2wh6aDEPUOoMinyPsd0w4Dzfc2tSc/IU72xyft7L4FF+5/DhTHMrczN+GR38rDQronmcbzwsZ0HsYu3KsJ7yozRvm96WCvoOPzI2YOZ7y+9DXxpyBUUA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=/X/Y07R5vgas+EGUx5s6N1Q9VFslIyXUX7RVzHEHoUs=;\n b=R0trabEMRWKxTi/x9fTNKLNXh4tU8ypKus5+AFMvG9AK1CWgHMLpb0ZCSDlNSbbpKVWHkViur7JgvaxayULWme0FF2zH5euLTbXeXRA7EtGQqWpgWKVTlPNI/CavieIsPIKkTnpndXypnXvaWSGQK0IZ4CoQs/o8KGmvvTadE2m/+2Sn94Yn09gv1DUmfh2MWSB2500vcywE/TsCH9N2gE8eZRalXpruSZrYlxaZn0AnhztvwqPPmcD9rH3F0Veiqy8aLMUTz0FTjFQLHDAGIuh3NdPHu2lUad/RhBHrMDonMOzSiWQNvx9TFtH11Rfc1CtpKoiCh3hhhFKkh2N+Jw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/X/Y07R5vgas+EGUx5s6N1Q9VFslIyXUX7RVzHEHoUs=;\n b=aS2uNuRm6W5ld95NBaJBRpRiD8ed+kV+PmLkqg/ySbpkEnbUeViwcQa94rnMUuBdg8832SLTK0DjjA2QfteoMXHkj76IdpfGKlfjPYQtbKsVtlx5K/6GV/kSsedOsFpw+Jb3KOo5wnq9cwAD7uI0mBYtvkYcXNWe8mJ+PfhUdiXzFrMmD90wtD+GtJaYfyQcpn1EarFmcaX475q1emKYYChYvavgE4RzDSw+CvVOFPc8i8YJkCSW2JJKR9f+Z8YOSwnJ3hAj2jhXNw39LXnolvktu8Pbyjcr8C76dRdXJuUhq1AzSYhxLBXkXdGWALxUGgZza2LuibcMX6PA0vpidA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>, =?utf-8?q?M?=\n\t=?utf-8?q?attias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC 7/7] eal: deprecate relaxed family of bit operations", "Date": "Sat, 2 Mar 2024 14:53:28 +0100", "Message-ID": "<20240302135328.531940-8-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240302135328.531940-1-mattias.ronnblom@ericsson.com>", "References": "<20240302135328.531940-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM4PEPF00027A6A:EE_|AS8PR07MB7973:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8ed603ba-e22f-4b90-0e44-08dc3ac15fe7", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 8b3KaoePWhnngOvvU/2s0wKvtkl+S3EMxiwfb1GbMsds3g0GYP66uPxwYi1YP7syRyvLZv57pvJwFwqDLgA4xBLT3pvGJsmxZKMw9TO8776tCA/oZU+ujnxKa4zbU3Ogr1DU3WmkPhu9CdFPlmcVtXgZzajBMKFBd7XJmiiuoVaWguKbTwarwzU8QyRhvlo6x/C9bjL5P0Jk/h6gaadaZcyNb7rKP5M0802cwnKYG90bWiHGzCkeVZxqf81zWt1xcvcX1h5n2w9J49pprPncrlFaQWy1tzcY1Jx7dAAKIKKlFnBpOgmigcq8ySHSU29sXZcw4bszhZ0uBuEVx8cM8EUBun7wGio27kCkpX7Fcydbl6qMlzXhrQ70kq1yqaGf4NK5kee91yheGcsJExP9pu39O2iQRzaLufjM24clXWxpdMZimZe8lwuJsxxb8ggaWb5rDyXt4ihGz1qRrowmTWDHdWGjQjhHVqCEMUCejm7EtRaI3lazqr8dabIdvKWm46z+xopuNEEHtfFGp9pSFLFKpp2Xz7IzJmNriPb4Qq9QVGzqNXMdspERAPYgMQ0IxbeFhKB4mkserShM5zFTI/aCKgm4vFne7Dl4XH658K1LRVF+OdLv++r/VJtdvGEpsXHkS+LWFeYxSvH1m7RwfVzpucnuUz8TU6sb9b+b30LC5vSiBL4RuGQj/gksFCT/IsreUBSKpXv1bysHpPO0TY0YCUnNbED4p84jZY13HKaB0tL4DnsM829R3R+LiRvV", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Mar 2024 14:02:19.1219 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8ed603ba-e22f-4b90-0e44-08dc3ac15fe7", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM4PEPF00027A6A.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR07MB7973", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Informally (by means of documentation) deprecate the\nrte_bit_relaxed_*() family of bit-level operations.\n\nrte_bit_relaxed_*() has been replaced by three new families of\nbit-level query and manipulation functions.\n\nrte_bit_relaxed_*() failed to deliver the atomicity guarantees their\nname suggested. If deprecated, it will encourage the user to consider\nwhether the actual, implemented behavior (e.g., non-atomic\ntest-and-set with read/write-once semantics) or the semantics implied\nby their names (i.e., atomic), or something else, is what's actually\nneeded.\n\nBugzilla ID: 1385\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/eal/include/rte_bitops.h | 48 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 48 insertions(+)", "diff": "diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h\nindex b5a9df5930..783dd0e1ee 100644\n--- a/lib/eal/include/rte_bitops.h\n+++ b/lib/eal/include/rte_bitops.h\n@@ -1179,6 +1179,10 @@ __RTE_GEN_BIT_ATOMIC_OPS(64)\n * The address holding the bit.\n * @return\n * The target bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_test32(),\n+ * rte_bit_once_test32(), or rte_bit_atomic_test32() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline uint32_t\n rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)\n@@ -1196,6 +1200,10 @@ rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)\n * The target bit to set.\n * @param addr\n * The address holding the bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_set32(),\n+ * rte_bit_once_set32(), or rte_bit_atomic_set32() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline void\n rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t *addr)\n@@ -1213,6 +1221,10 @@ rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t *addr)\n * The target bit to clear.\n * @param addr\n * The address holding the bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_clear32(),\n+ * rte_bit_once_clear32(), or rte_bit_atomic_clear32() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline void\n rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t *addr)\n@@ -1233,6 +1245,12 @@ rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t *addr)\n * The address holding the bit.\n * @return\n * The original bit.\n+ * @note\n+ * This function is deprecated and replaced by\n+ * rte_bit_atomic_test_and_set32(), for use cases where the\n+ * operation needs to be atomic. For non-atomic/non-ordered use\n+ * cases, use rte_bit_test32() + rte_bit_set32() or\n+ * rte_bit_once_test32() + rte_bit_once_set32().\n */\n static inline uint32_t\n rte_bit_relaxed_test_and_set32(unsigned int nr, volatile uint32_t *addr)\n@@ -1255,6 +1273,12 @@ rte_bit_relaxed_test_and_set32(unsigned int nr, volatile uint32_t *addr)\n * The address holding the bit.\n * @return\n * The original bit.\n+ * @note\n+ * This function is deprecated and replaced by\n+ * rte_bit_atomic_test_and_clear32(), for use cases where the\n+ * operation needs to be atomic. For non-atomic/non-ordered use\n+ * cases, use rte_bit_test32() + rte_bit_clear32() or\n+ * rte_bit_once_test32() + rte_bit_once_clear32().\n */\n static inline uint32_t\n rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile uint32_t *addr)\n@@ -1278,6 +1302,10 @@ rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile uint32_t *addr)\n * The address holding the bit.\n * @return\n * The target bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_test64(),\n+ * rte_bit_once_test64(), or rte_bit_atomic_test64() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline uint64_t\n rte_bit_relaxed_get64(unsigned int nr, volatile uint64_t *addr)\n@@ -1295,6 +1323,10 @@ rte_bit_relaxed_get64(unsigned int nr, volatile uint64_t *addr)\n * The target bit to set.\n * @param addr\n * The address holding the bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_set64(),\n+ * rte_bit_once_set64(), or rte_bit_atomic_set64() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline void\n rte_bit_relaxed_set64(unsigned int nr, volatile uint64_t *addr)\n@@ -1312,6 +1344,10 @@ rte_bit_relaxed_set64(unsigned int nr, volatile uint64_t *addr)\n * The target bit to clear.\n * @param addr\n * The address holding the bit.\n+ * @note\n+ * This function is deprecated. Use rte_bit_clear64(),\n+ * rte_bit_once_clear64(), or rte_bit_atomic_clear64() instead,\n+ * depending on exactly what guarantees are required.\n */\n static inline void\n rte_bit_relaxed_clear64(unsigned int nr, volatile uint64_t *addr)\n@@ -1332,6 +1368,12 @@ rte_bit_relaxed_clear64(unsigned int nr, volatile uint64_t *addr)\n * The address holding the bit.\n * @return\n * The original bit.\n+ * @note\n+ * This function is deprecated and replaced by\n+ * rte_bit_atomic_test_and_set64(), for use cases where the\n+ * operation needs to be atomic. For non-atomic/non-ordered use\n+ * cases, use rte_bit_test64() + rte_bit_set64() or\n+ * rte_bit_once_test64() + rte_bit_once_set64().\n */\n static inline uint64_t\n rte_bit_relaxed_test_and_set64(unsigned int nr, volatile uint64_t *addr)\n@@ -1354,6 +1396,12 @@ rte_bit_relaxed_test_and_set64(unsigned int nr, volatile uint64_t *addr)\n * The address holding the bit.\n * @return\n * The original bit.\n+ * @note\n+ * This function is deprecated and replaced by\n+ * rte_bit_atomic_test_and_clear64(), for use cases where the\n+ * operation needs to be atomic. For non-atomic/non-ordered use\n+ * cases, use rte_bit_test64() + rte_bit_clear64() or\n+ * rte_bit_once_test64() + rte_bit_once_clear64().\n */\n static inline uint64_t\n rte_bit_relaxed_test_and_clear64(unsigned int nr, volatile uint64_t *addr)\n", "prefixes": [ "RFC", "7/7" ] }