Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137614/?format=api
{ "id": 137614, "url": "http://patches.dpdk.org/api/patches/137614/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-43-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-43-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-43-stephen@networkplumber.org", "date": "2024-02-29T22:58:29", "name": "[42/71] crypto/qat: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70776482ab9e1c0029d6a5fe0e731a363b819cd7", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-43-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patches.dpdk.org/api/series/31314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patches.dpdk.org/series/31314/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137614/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137614/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4468B43BAE;\n\tFri, 1 Mar 2024 00:04:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 42B74433B2;\n\tFri, 1 Mar 2024 00:01:28 +0100 (CET)", "from mail-pg1-f180.google.com (mail-pg1-f180.google.com\n [209.85.215.180])\n by mails.dpdk.org (Postfix) with ESMTP id 67F8742FE9\n for <dev@dpdk.org>; Fri, 1 Mar 2024 00:00:36 +0100 (CET)", "by mail-pg1-f180.google.com with SMTP id\n 41be03b00d2f7-5dbf7b74402so1133027a12.0\n for <dev@dpdk.org>; Thu, 29 Feb 2024 15:00:36 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 15:00:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247635;\n x=1709852435; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=;\n b=Lljb+1wj6arEIBJ106E6tVhupRiTKw1SnP7s8xLrElnSJAznVVckApuOwcqCwC3Ziv\n TrWrIjoagYO0STL9UMjJiRf0l3gMU4GgwfOQk9GstALPjcXtzCTixbME5qwBLCWMSUmv\n MkcyzDS3Zz0CeyU7JsbGyce6Zh2S3Nk+6P0C1dGr03LVAXWtvKi/fwZRJeIxw1BTS0Mf\n pNr/yjJ6izYiuvbEFMtNNmChSz7mkL2Zfy6/A16sasQnmFHi1hgr8YPotiDLAH5KU6kH\n gTQPcos3x4zSkgxzYWENl/gR/yNL4JvhmYzHZGt+hBlKtdBXkQuGWZWb7sTWhUEb8Hrn\n F+Nw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247635; x=1709852435;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=;\n b=MGo0nndP5t0wHBlfd6z/Lr+ZzBCR5HdNhfc92nHjvP8m/RepDXmYePLHAkRfaBsNSq\n y6XVRmq9pTFjHSJ3r8qH0c0ve8smer3F9iYOVWYfyHhwAGr3JLjYRaj8TH9+6czRVw6r\n 1Y5ykfk0uvKsaecxZOZ4z/f+wBMTxFBBdR+8M9PUSbk5yFBdi6PpajZi5VmU7uP9rTJj\n ctRUbtRXn1EZhle80HKN/iHdcndsbYcBMJQIpeM4sjnenT8Gz5bbnO2xCOakbp50Krz8\n g7Q7EOpOwONuMqXRBkjMcg0z1GrWFN7oWWHPO46oU+jLOsCTdBQuDtNKPc4xOaHYE24w\n phkQ==", "X-Gm-Message-State": "AOJu0YyGAOO3ABe0+6INu/TsGdaVD/lb8uoNinQQ055RkSj20nWqPV/D\n IXfYcibzluUwcz8Pxc8NcHek+MlcBHTy9OEEnUnbeDJfd7ydOnig7g4UOooQdJsu4lGkvIyoR9N\n n", "X-Google-Smtp-Source": "\n AGHT+IFsnu+a7O7NT1Ymq9pT3HTMmpVLCyo91ovOZ2chC8Ey3D8Ptm2TWrYrFge/J5OwnSP6tDnVBw==", "X-Received": "by 2002:a17:90a:4a83:b0:29b:1018:87cc with SMTP id\n f3-20020a17090a4a8300b0029b101887ccmr19718pjh.44.1709247635580;\n Thu, 29 Feb 2024 15:00:35 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, Kai Ji <kai.ji@intel.com>", "Subject": "[PATCH 42/71] crypto/qat: replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:58:29 -0800", "Message-ID": "<20240229225936.483472-43-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229225936.483472-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/crypto/qat/qat_sym_session.c | 52 +++++++++++++---------------\n 1 file changed, 25 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 9f4f6c3d93e0..8d7809bbec11 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -1310,7 +1310,7 @@ static int partial_hash_sha1(uint8_t *data_in, uint8_t *data_out)\n \tif (!SHA1_Init(&ctx))\n \t\treturn -EFAULT;\n \tSHA1_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, SHA_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, SHA_DIGEST_LENGTH);\n \treturn 0;\n }\n \n@@ -1321,7 +1321,7 @@ static int partial_hash_sha224(uint8_t *data_in, uint8_t *data_out)\n \tif (!SHA224_Init(&ctx))\n \t\treturn -EFAULT;\n \tSHA256_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, SHA256_DIGEST_LENGTH);\n \treturn 0;\n }\n \n@@ -1332,7 +1332,7 @@ static int partial_hash_sha256(uint8_t *data_in, uint8_t *data_out)\n \tif (!SHA256_Init(&ctx))\n \t\treturn -EFAULT;\n \tSHA256_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, SHA256_DIGEST_LENGTH);\n \treturn 0;\n }\n \n@@ -1343,7 +1343,7 @@ static int partial_hash_sha384(uint8_t *data_in, uint8_t *data_out)\n \tif (!SHA384_Init(&ctx))\n \t\treturn -EFAULT;\n \tSHA512_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, SHA512_DIGEST_LENGTH);\n \treturn 0;\n }\n \n@@ -1354,7 +1354,7 @@ static int partial_hash_sha512(uint8_t *data_in, uint8_t *data_out)\n \tif (!SHA512_Init(&ctx))\n \t\treturn -EFAULT;\n \tSHA512_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, SHA512_DIGEST_LENGTH);\n \treturn 0;\n }\n \n@@ -1365,7 +1365,7 @@ static int partial_hash_md5(uint8_t *data_in, uint8_t *data_out)\n \tif (!MD5_Init(&ctx))\n \t\treturn -EFAULT;\n \tMD5_Transform(&ctx, data_in);\n-\trte_memcpy(data_out, &ctx, MD5_DIGEST_LENGTH);\n+\tmemcpy(data_out, &ctx, MD5_DIGEST_LENGTH);\n \n \treturn 0;\n }\n@@ -1486,8 +1486,7 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,\n \t\t\t\treturn -ENOMEM;\n \t\t\t}\n \n-\t\t\trte_memcpy(in, AES_CMAC_SEED,\n-\t\t\t\t ICP_QAT_HW_AES_128_KEY_SZ);\n+\t\t\tmemcpy(in, AES_CMAC_SEED, ICP_QAT_HW_AES_128_KEY_SZ);\n \t\t\trte_memcpy(p_state_buf, auth_key, auth_keylen);\n \n \t\t\tif (AES_set_encrypt_key(auth_key, auth_keylen << 3,\n@@ -1531,8 +1530,8 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,\n \t\t\t\treturn -ENOMEM;\n \t\t\t}\n \n-\t\t\trte_memcpy(in, qat_aes_xcbc_key_seed,\n-\t\t\t\t\tICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ);\n+\t\t\tmemcpy(in, qat_aes_xcbc_key_seed,\n+\t\t\t ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ);\n \t\t\tfor (x = 0; x < HASH_XCBC_PRECOMP_KEY_NUM; x++) {\n \t\t\t\tif (AES_set_encrypt_key(auth_key,\n \t\t\t\t\t\t\tauth_keylen << 3,\n@@ -1795,8 +1794,8 @@ static int qat_sym_do_precomputes_ipsec_mb(enum icp_qat_hw_auth_algo hash_alg,\n \n \t\tuint8_t *input = in;\n \t\tuint8_t *out = p_state_buf;\n-\t\trte_memcpy(input, qat_aes_xcbc_key_seed,\n-\t\t\t\tICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ);\n+\t\tmemcpy(input, qat_aes_xcbc_key_seed,\n+\t\t ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ);\n \t\tfor (i = 0; i < HASH_XCBC_PRECOMP_KEY_NUM; i++) {\n \t\t\tif (aes_ipsecmb_job(input, out, m, auth_key, auth_keylen)) {\n \t\t\t\tmemset(input -\n@@ -2265,8 +2264,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcdesc->cd_cur_ptr += sizeof(struct icp_qat_hw_auth_setup);\n \tswitch (cdesc->qat_hash_alg) {\n \tcase ICP_QAT_HW_AUTH_ALGO_SM3:\n-\t\trte_memcpy(cdesc->cd_cur_ptr, sm3InitialState,\n-\t\t\t\tsizeof(sm3InitialState));\n+\t\tmemcpy(cdesc->cd_cur_ptr, sm3InitialState,\n+\t\t sizeof(sm3InitialState));\n \t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\tcdesc->qat_hash_alg);\n \t\tstate2_size = ICP_QAT_HW_SM3_STATE2_SZ;\n@@ -2277,9 +2276,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \t\thash_2->auth_config.config =\n \t\t\tICP_QAT_HW_AUTH_CONFIG_BUILD(ICP_QAT_HW_AUTH_MODE2,\n \t\t\t\tcdesc->qat_hash_alg, digestsize);\n-\t\trte_memcpy(cdesc->cd_cur_ptr + state1_size + state2_size +\n-\t\t\tsizeof(*hash_2), sm3InitialState,\n-\t\t\tsizeof(sm3InitialState));\n+\t\tmemcpy(cdesc->cd_cur_ptr + state1_size + state2_size + sizeof(*hash_2),\n+\t\t sm3InitialState, sizeof(sm3InitialState));\n \t\thash_cd_ctrl->inner_state1_sz = state1_size;\n \t\thash_cd_ctrl->inner_state2_sz = state2_size;\n \t\thash_cd_ctrl->inner_state2_offset =\n@@ -2316,8 +2314,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcase ICP_QAT_HW_AUTH_ALGO_SHA1:\n \t\tif (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) {\n \t\t\t/* Plain SHA-1 */\n-\t\t\trte_memcpy(cdesc->cd_cur_ptr, sha1InitialState,\n-\t\t\t\t\tsizeof(sha1InitialState));\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, sha1InitialState,\n+\t\t\t sizeof(sha1InitialState));\n \t\t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\t\tcdesc->qat_hash_alg);\n \t\t\tbreak;\n@@ -2343,8 +2341,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcase ICP_QAT_HW_AUTH_ALGO_SHA224:\n \t\tif (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) {\n \t\t\t/* Plain SHA-224 */\n-\t\t\trte_memcpy(cdesc->cd_cur_ptr, sha224InitialState,\n-\t\t\t\t\tsizeof(sha224InitialState));\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, sha224InitialState,\n+\t\t\t sizeof(sha224InitialState));\n \t\t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\t\tcdesc->qat_hash_alg);\n \t\t\tbreak;\n@@ -2368,8 +2366,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcase ICP_QAT_HW_AUTH_ALGO_SHA256:\n \t\tif (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) {\n \t\t\t/* Plain SHA-256 */\n-\t\t\trte_memcpy(cdesc->cd_cur_ptr, sha256InitialState,\n-\t\t\t\t\tsizeof(sha256InitialState));\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, sha256InitialState,\n+\t\t\t sizeof(sha256InitialState));\n \t\t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\t\tcdesc->qat_hash_alg);\n \t\t\tbreak;\n@@ -2393,8 +2391,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcase ICP_QAT_HW_AUTH_ALGO_SHA384:\n \t\tif (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) {\n \t\t\t/* Plain SHA-384 */\n-\t\t\trte_memcpy(cdesc->cd_cur_ptr, sha384InitialState,\n-\t\t\t\t\tsizeof(sha384InitialState));\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, sha384InitialState,\n+\t\t\t sizeof(sha384InitialState));\n \t\t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\t\tcdesc->qat_hash_alg);\n \t\t\tbreak;\n@@ -2418,8 +2416,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \tcase ICP_QAT_HW_AUTH_ALGO_SHA512:\n \t\tif (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) {\n \t\t\t/* Plain SHA-512 */\n-\t\t\trte_memcpy(cdesc->cd_cur_ptr, sha512InitialState,\n-\t\t\t\t\tsizeof(sha512InitialState));\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, sha512InitialState,\n+\t\t\t sizeof(sha512InitialState));\n \t\t\tstate1_size = qat_hash_get_state1_size(\n \t\t\t\t\tcdesc->qat_hash_alg);\n \t\t\tbreak;\n", "prefixes": [ "42/71" ] }