From patchwork Thu Feb 29 22:57:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137575 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C914343BAD; Fri, 1 Mar 2024 00:00:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B295442DBD; Fri, 1 Mar 2024 00:00:00 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 2E00E42DBD for ; Thu, 29 Feb 2024 23:59:59 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-29b18c81ee4so618249a91.3 for ; Thu, 29 Feb 2024 14:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247598; x=1709852398; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6uhYXuFO0hkzj3eBHFdCdGhcudl4GtPWett1S7Oeck=; b=Iu9NsTWLtub71hkSeZda0NABfHKEmon738fsSvbAIP/OLZ5a+t5saxEm3U0vLNhTkt dhIWRAsL0pfZXXO7iK5mJ4FUixLUth/cHa8RseWv4MsBwyVODzuE3ZC74AkJtg8S9cTj 7zL2ilY3BqyFuPcTHSPVSo3L5IOZn3rCOITmqURc+WXt8hHetprtoYwOwkhEqg811r63 ORU6BqvsZdJ9RFtrjL9k0CFbLk+SFbFA5EnxFB+B6Cm4VU4T1jScfrlv8Xfh77Cb6kyf 1YS36b510Bh3P0AyDvV72EyyFbttQp2WtiP7XKituT4tCSZZu9JksVd/wTZ/disPCp88 AV5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247598; x=1709852398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g6uhYXuFO0hkzj3eBHFdCdGhcudl4GtPWett1S7Oeck=; b=ZES+u9iViXQr7xRTNzRlSUoV7SVEGMJWUN1mGgNfUqR6j1qLMvI98DcavnpwGpdXw6 9ikk3yyIfA+J95QsVR5CR+cj2EoVM/XSaQbX0iFhuzP4XADkCqkIahMDnI4s2nplLk25 LrWw7TvUrG0tEPcMkNNFmBoMkjPEJ6+jfx3cPXCVGBw+TyQSB9vJWSuV3GTN8KLggTXe TLzcEDKe3ubPvzKbxmkzzDZ5hmHBLxVHrYhNYUGtlIaLOtJ3RcreVWyMqx4P26cMDV1M Fx7qJ1XRCvXTezvNldnYZIwVghSD+oV4t//yLkcXTJN03Ox+0gVypJf8PCNhumh6/c2T qv3w== X-Gm-Message-State: AOJu0Yyt56T0RpQ0z6sNI48VQXSYsbZYzq+fsi5Kn9OVUKvKVjU7kAbG o/HiaHWVm16mwoggZSymd6lCFHAHOILRznOYmGwfJr+ST+GHbtEM2k/vj2b8vtXHKeLfsrdX+CX s X-Google-Smtp-Source: AGHT+IEjJpjvkrvCK3qCjVxrx+/axmhuGlAWYJGHVj1Jq38lbJ7f++WD3nqwjEiTLiB8z5GbfWbFig== X-Received: by 2002:a17:90b:3603:b0:299:1f80:8c44 with SMTP id ml3-20020a17090b360300b002991f808c44mr14382pjb.40.1709247598379; Thu, 29 Feb 2024 14:59:58 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.14.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 14:59:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:48 -0800 Message-ID: <20240229225936.483472-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rte_memcpy should not be used for the simple case of copying a fix size structure because it is slower and will hide problems from code analysis tools. Coverity, fortify and other analyzers special case memcpy(). Gcc (and Clang) are smart enough to inline copies which will be faster. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- devtools/cocci/rte_memcpy.cocci | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 devtools/cocci/rte_memcpy.cocci diff --git a/devtools/cocci/rte_memcpy.cocci b/devtools/cocci/rte_memcpy.cocci new file mode 100644 index 000000000000..fa1038fc066d --- /dev/null +++ b/devtools/cocci/rte_memcpy.cocci @@ -0,0 +1,11 @@ +// +// rte_memcpy should not be used for simple fixed size structure +// because compiler's are smart enough to inline these. +// +@@ +expression src, dst; constant size; +@@ +( +- rte_memcpy(dst, src, size) ++ memcpy(dst, src, size) +) From patchwork Thu Feb 29 22:57:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137576 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D862E43BAE; Fri, 1 Mar 2024 00:00:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12572427D9; Fri, 1 Mar 2024 00:00:04 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 03E0242DBD for ; Fri, 1 Mar 2024 00:00:00 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-299b92948a6so1023436a91.3 for ; Thu, 29 Feb 2024 14:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247599; x=1709852399; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EFwKhKzbWxIKE4LKzTUwAw7ItEgO/nVUD+Tiqa1uL1U=; b=PTN08smjFOGHfWyfaPAkVl/V19xmw+U8Krd10OVNaBQDwdQCxMhYUXno+4wMk7jMpr jbljlKYLiNle2XM0aTQF48/3aOuFeGP25J4kYonLkmHTvfOIuyilkDperSefVqy8IdL4 U+7xNft8gV7RrnOXjDsI55krUt8caC7gsLWO8hhWsUuXZi8+eS0BDrPy47sEKSLDZVFU vC/qC+ZnjHkeWaG+zH4GF15+dJr6swbw6VK6s8BR6OKDGzQFMIap/WVqH5G9o2Lsp8xe 4ce9wrp1TNwux+fP+Q2/fydM3tRlFnzeINF7go3Op2LOyp+x7rEewphAja+VKD4RLhLL rpeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247599; x=1709852399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EFwKhKzbWxIKE4LKzTUwAw7ItEgO/nVUD+Tiqa1uL1U=; b=NL+UiSerqJAqEnGO4QUpbBjHThY6pdStPM76ZSimQjlDVFvUxxXiG3KOHBXqmpaA7i dXqhBc7C/7L8wziulJTT0lgt0rVK++M39BLZdnAEq5cHIdOe5ZujULAV/8fEZr/Wp7v7 ijDWH6sAW4PqoxBVhO4NYA5qbFY05uyV+0KwoVrSDvRpJrmmshcBOVbNF2kKB01DHbhx RmDI1QkOqIm9Ipk7F3W/sFB1KK5zQllCiIWH6ciSIdXkoHxuG0rephIIE6BhUAVDAzE6 pzVQnm3e4hzx5uEwdVd07xzKN7wvGk9guoDyh+OjNy2uU5ifYrf1B0Ueo/Hsw1iTEYTa paAw== X-Gm-Message-State: AOJu0YzzZk43EmWj0HAZ3emb7StZ8vb5/s/ZutQzap0/pVxoiP8yom4o DOwSjQyo+cNvwiZp1/sTHA+kRNai1no/HW+1OaKI+zyF2siyar/CZ0M3pju1CLyJvt70Dk15yU7 K X-Google-Smtp-Source: AGHT+IHV50NtfrEazGpFT4tWmWTB5Ig5+hPzfEshk6ZEJ9qpSdgyuUd/RrX6AeYwOvio74vexEqdyg== X-Received: by 2002:a17:90a:5986:b0:29a:e05f:3f55 with SMTP id l6-20020a17090a598600b0029ae05f3f55mr36163pji.2.1709247599205; Thu, 29 Feb 2024 14:59:59 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.14.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 14:59:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 02/71] eal: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:49 -0800 Message-ID: <20240229225936.483472-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index e541f0793964..07bfaffdac76 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -30,7 +30,6 @@ #include #include #include -#include #ifndef RTE_EXEC_ENV_WINDOWS #include #endif @@ -1253,7 +1252,7 @@ eal_parse_lcores(const char *lcores) /* without '@', by default using lcore_set as cpuset */ if (*lcores != '@') - rte_memcpy(&cpuset, &lcore_set, sizeof(cpuset)); + memcpy(&cpuset, &lcore_set, sizeof(cpuset)); set_count = CPU_COUNT(&lcore_set); /* start to update lcore_set */ @@ -1275,8 +1274,8 @@ eal_parse_lcores(const char *lcores) if (check_cpuset(&cpuset) < 0) goto err; - rte_memcpy(&lcore_config[idx].cpuset, &cpuset, - sizeof(rte_cpuset_t)); + memcpy(&lcore_config[idx].cpuset, &cpuset, + sizeof(rte_cpuset_t)); } /* some cores from the lcore_set can't be handled by EAL */ From patchwork Thu Feb 29 22:57:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137577 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4BDB43BAE; Fri, 1 Mar 2024 00:00:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 327FE43267; Fri, 1 Mar 2024 00:00:09 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id D5CD642F9D for ; Fri, 1 Mar 2024 00:00:00 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-29a2d0f69a6so1081456a91.3 for ; Thu, 29 Feb 2024 15:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247600; x=1709852400; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K+KGhTbHEnBZ+LWTV2nbhkUGGI/qctogtFJZDjHHhJo=; b=VmVev/0AqeRfkYbWKyZpU2te8emlaWBmU7atiHG4HEcUIkSh5wLU1AxImDhbq/TZxR lRQy9S5iV2RKYcEKOQEzXx+k4scCfEb8vav8vPmJRxndEEYBHrxGJCr+x2MyT4QyOBf7 m+5/jFV17U1SIrGZBFLqc9jdvO9AAIPGLPkphLKnt3nxiMhGMQ9ynPikegEb23364ZOB e/zVEh1n8oOs/ftjVvwq9qPCteM+rW+s4VLQrdF8aa2sjC8p7upnckWsiYQGA1EVBz5n jtnQdhm1weqJa7cXGaX+Om0gA2ug0TWkDYvrLKNEmxrhRM0DdJZYkPIgCFlsZgngOwVt OS1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247600; x=1709852400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K+KGhTbHEnBZ+LWTV2nbhkUGGI/qctogtFJZDjHHhJo=; b=ACAxaufe9QAZ7fW0SrTu6eznaqpKb8LuePusNKPZejMxcj/oDxouMmKprQb9FaZ/hb H7+s8zuk5moOb7ORxM0DTzpV1Y9SnX8d4sZxz1CLKweecEqMgstE6vebuPP3HYFwXknz jgAPnOsQl1XoUyGQmowvDIGkmpAbobzr/3xuKhcvRQA+22oMOXa+kHTBasktRLXrsiKl 4WWRVqhdGrmom3qHFOje3tikPK2AV5C1QV/dDrv7IQbo0h40ppawfpwEli7CgVMMyN3m JtPQcHrwhiTDXIwpD8Lk4u+OiWshGd8e9eAgZI89gjzweKz8owJh3lUJ7PkT/cdksgI2 xPDQ== X-Gm-Message-State: AOJu0Yw6ksyBUkV9baaapWJb0udB5uXRZuoi5CvezU86KeC/CM19gJb7 9LxErJ6cusRY2XN7W5U9BWgW8hD3T6RSZ3ewOuDSM7knifDVu8yxowOzYvmxQ/UMh8oA6dld4BB o X-Google-Smtp-Source: AGHT+IG5Wq6pV2cfL9hx+lBfkgACaqYxc3RLHM4b74AY5jDsiiA98Szh5PWwCQbcGHUKkcqft0p0ag== X-Received: by 2002:a17:90a:fb81:b0:29a:1708:9878 with SMTP id cp1-20020a17090afb8100b0029a17089878mr25518pjb.38.1709247600141; Thu, 29 Feb 2024 15:00:00 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.14.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 14:59:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ori Kam Subject: [PATCH 03/71] ethdev: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:50 -0800 Message-ID: <20240229225936.483472-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- lib/ethdev/rte_flow.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index f1c658f49e80..ef62a0260747 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -618,7 +617,7 @@ rte_eth_dev_owner_get(const uint16_t port_id, struct rte_eth_dev_owner *owner) rte_spinlock_lock(rte_mcfg_ethdev_get_lock()); if (eth_dev_shared_data_prepare() != NULL) { - rte_memcpy(owner, ðdev->data->owner, sizeof(*owner)); + memcpy(owner, ðdev->data->owner, sizeof(*owner)); ret = 0; } else { ret = -ENOMEM; diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 7ab1100ea049..9b831486eb5e 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -994,9 +994,8 @@ rte_flow_conv_rule(struct rte_flow_conv_rule *dst, if (src->attr_ro) { off = RTE_ALIGN_CEIL(off, sizeof(double)); if (size && size >= off + sizeof(*dst->attr)) - dst->attr = rte_memcpy - ((void *)((uintptr_t)dst + off), - src->attr_ro, sizeof(*dst->attr)); + dst->attr = memcpy((void *)((uintptr_t)dst + off), + src->attr_ro, sizeof(*dst->attr)); off += sizeof(*dst->attr); } if (src->pattern_ro) { From patchwork Thu Feb 29 22:57:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137578 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75FE843BAE; Fri, 1 Mar 2024 00:00:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 651F34327C; Fri, 1 Mar 2024 00:00:14 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 0F2A742FE9 for ; Fri, 1 Mar 2024 00:00:02 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29a5f100c1aso1039102a91.0 for ; Thu, 29 Feb 2024 15:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247601; x=1709852401; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=im1YDab7B8nfKxOBtYm+DLGPqYDNBgbQ261VP/ANWzE=; b=lFHy+5hkkF0fWbHchROu0igxSKerPctP/KhFA9eIhjJfY91/Je6GWZZ0ySSYRVlrDd vOeIUau1jPQusz+m+2GtyDSYZpw9EyMEmSiOa+Xzz6uV1wXbHcMZnxKe/iTeY59EBvjk IeXIRnlaaEjBMYjAOQB3KqxdAd8FAU9/ARqtw9RUOqydB+CFHfRVZF9o8zP6VvaGxP1G fOxMoiLXPslZu9Vf6272XqKOZJHXJz1jmhKozfxCKZ5ZFKy9Xv7bJpnmS7gwbBMKNeGh eyh5kuO8zKTXUtscBQl3bs3mxlJHQigX7+E+7/y33w6qZqFLny5YescjUZkfouc9Ek6E zYHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247601; x=1709852401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=im1YDab7B8nfKxOBtYm+DLGPqYDNBgbQ261VP/ANWzE=; b=rcYyChsnkSByVmki8+Y4S6s08L0k6zRFZS3hrT8pSFYcqHvFUSCgXRSnccl2ba89mk pVzqE8A+872NhccvJ7KXJHacl+qU705R7yHFJlbeUjRvsz0StgRigyJCqpQNhwxiLfVc dfnoNfrZXMn1Xt2lrR5OVsuibOZ0H/RthamoklM8KGjlr51pN4J4q6a2P4iMQirMTECL s46UGjZ7c7AEqSQ+MAwRH02jtixoUGF8ITZFm+FSsfhXS4UdBWdzhVbMKExzHZEnM389 RmvyRvJ1q1xIYfnQRnCKDFf6T2KzX7+mSzCTpbU+380Ys514qsStCduYsZToFDK2jrHL NMfw== X-Gm-Message-State: AOJu0Yx3UMoXUyNY/UznFZFVBzwJa/+LdFBvkTM805RmEedhAFM2HaPI 7U8sfjZkdDf9Ip47ZE9pqklGRDJuaqbeVT5sGMspsr+Iy372rBeIzNcogSTtYNCcgUxGmRR4qvE 1 X-Google-Smtp-Source: AGHT+IGy9YCKZGW2XyKwYht6KunQmcrc+qOxzhTsSFBcFMoL1yIVW0NigQgtwpVmHdqcX/H1z1fsUg== X-Received: by 2002:a17:90a:6406:b0:29b:905:e629 with SMTP id g6-20020a17090a640600b0029b0905e629mr19618pjj.32.1709247601078; Thu, 29 Feb 2024 15:00:01 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abhinandan Gujjar , Jerin Jacob , Amit Prakash Shukla , Erik Gabriel Carrillo Subject: [PATCH 04/71] eventdev: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:51 -0800 Message-ID: <20240229225936.483472-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 2 +- lib/eventdev/rte_event_dma_adapter.c | 4 ++-- lib/eventdev/rte_event_timer_adapter.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c index d46595d19028..d974404abe21 100644 --- a/lib/eventdev/rte_event_crypto_adapter.c +++ b/lib/eventdev/rte_event_crypto_adapter.c @@ -647,7 +647,7 @@ eca_ops_enqueue_burst(struct event_crypto_adapter *adapter, continue; } - rte_memcpy(ev, &m_data->response_info, sizeof(*ev)); + memcpy(ev, &m_data->response_info, sizeof(*ev)); ev->event_ptr = ops[i]; ev->event_type = RTE_EVENT_TYPE_CRYPTODEV; if (adapter->implicit_release_disabled) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index 4196164305d9..c50b3d23da2d 100644 --- a/lib/eventdev/rte_event_dma_adapter.c +++ b/lib/eventdev/rte_event_dma_adapter.c @@ -447,7 +447,7 @@ rte_event_dma_adapter_create(uint8_t id, uint8_t evdev_id, struct rte_event_port if (pc == NULL) return -ENOMEM; - rte_memcpy(pc, port_config, sizeof(struct rte_event_port_conf)); + memcpy(pc, port_config, sizeof(struct rte_event_port_conf)); ret = rte_event_dma_adapter_create_ext(id, evdev_id, edma_default_config_cb, mode, pc); if (ret != 0) rte_free(pc); @@ -668,7 +668,7 @@ edma_ops_enqueue_burst(struct event_dma_adapter *adapter, struct rte_event_dma_a continue; } - rte_memcpy(ev, response_info, sizeof(struct rte_event)); + memcpy(ev, response_info, sizeof(struct rte_event)); ev->event_ptr = ops[i]; ev->event_type = RTE_EVENT_TYPE_DMADEV; if (adapter->implicit_release_disabled) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index e6d34920561b..d033a58c133d 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -549,7 +549,7 @@ event_buffer_add(struct event_buffer *bufp, struct rte_event *eventp) /* Instead of modulus, bitwise AND with mask to get head_idx. */ head_idx = bufp->head & EVENT_BUFFER_MASK; buf_eventp = &bufp->events[head_idx]; - rte_memcpy(buf_eventp, eventp, sizeof(struct rte_event)); + memcpy(buf_eventp, eventp, sizeof(struct rte_event)); /* Wrap automatically when overflow occurs. */ bufp->head++; From patchwork Thu Feb 29 22:57:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137579 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E85A543BAE; Fri, 1 Mar 2024 00:00:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17FA2432A0; Fri, 1 Mar 2024 00:00:17 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id BDF9243067 for ; Fri, 1 Mar 2024 00:00:02 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e4d48a5823so1310421b3a.1 for ; Thu, 29 Feb 2024 15:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247602; x=1709852402; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C7kfBD3djBUDJJFpAGOmlkIh8y6zpuH5vxwEnCxBnrw=; b=GShHQn8MNWxqB9GRCjNYFAWVu9mW23OHQFV0XQPyX+VSxBnKdEyWMhw/L76vY7P2j6 vTd4CKbt6T09f2xuuUeSNJBQO550wBFGpm4/TP0IKq6qJHDfBHEm7WMoMdT7OXuWpq+m qqqrKEQTK9C+YUACYPD0jiVVJp45ObEyqGpf1mv1X22znB0x99OlNk6M+E4PpKTR8CX+ qcxtqrWkK8oJwWiL9+GCaFee+/Ql3Xy1ux1k0mhzFRJ38gTMnuRhsKhxXl66zgueoFm0 RW41y8RNizMDen99lCWMr/BVXZRNiQtg4LPV3GEPgppuZVGznO5LM+e3iPiQoPOZHm8e JRCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247602; x=1709852402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C7kfBD3djBUDJJFpAGOmlkIh8y6zpuH5vxwEnCxBnrw=; b=FrNoNdl4QYAd60/8LB14Nv/YfuupOwYDuN+Q/PsdVwywua5uDRwY26ELvKDyOrlEG6 ikwplq96LkEE8lBiKbLeJi6AWwU+qVDvGcq7LSBoOVI3yRoNamDg9s4CbacOrl6JKKm2 mB1HuaQyCIIf60pk/l9sNP+ziMghVs7Mb/ws7ZuSnKgfJ5dGqruDrq0C1hdyfinJojDJ DkLfXKqGK8EQ4gAYUNFF3gtI57jW4xY0RDNDpY+2aF1+HXtDhwfkTkewz1Oezsi4QvYx yzoOdsOmJi+rTqshNg1gyHpkQS/a+ZODr0leaJ79PHLkHI18b0WTb0u6JLT7NmDnUB3l YHGg== X-Gm-Message-State: AOJu0YzL7rHXGmO/lchMJB88J9CX9leafqcND+/0gedcDcQoNhJenH/W g4MP45IDrPcnOJVJE7OvFl/fGSmMn/VhjXXPwUy6tkoR0EytguGbL57Ofw1+eJZaKVuL+Myef0F l X-Google-Smtp-Source: AGHT+IF7e9drKg0LR/nlTPlzaUXHvxBdXumqpjlg/8vURMPFtJNf3cw/g4oLoJ0dKLb7LDaVqEB0mw== X-Received: by 2002:a05:6a21:1743:b0:19e:ce54:4731 with SMTP id nw3-20020a056a21174300b0019ece544731mr4707076pzb.50.1709247601842; Thu, 29 Feb 2024 15:00:01 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal , Fan Zhang Subject: [PATCH 05/71] cryptodev: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:52 -0800 Message-ID: <20240229225936.483472-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index 886eb7adc4a9..1377777525dc 100644 --- a/lib/cryptodev/rte_cryptodev.c +++ b/lib/cryptodev/rte_cryptodev.c @@ -2854,7 +2854,7 @@ crypto_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { memset(&caps_val, 0, CRYPTO_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < CRYPTO_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } From patchwork Thu Feb 29 22:57:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137580 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50F4B43BAE; Fri, 1 Mar 2024 00:00:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53F8742FFB; Fri, 1 Mar 2024 00:00:24 +0100 (CET) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id 5427C43245 for ; Fri, 1 Mar 2024 00:00:03 +0100 (CET) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3657dbe2008so7353215ab.1 for ; Thu, 29 Feb 2024 15:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247602; x=1709852402; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AjTHKv757QZS7wC8lHubmHNC99iGHDbQ91APaNvFEtw=; b=19BzVpsqIQUf3QKJJmqpON5mgjbtNWxVXPLdZWJvAkdABXeX983nhN3zrqvkdnZ4wz q/JTFbm+FMfL9jroQ+7LvXsbYaknLSxfHbtOFrSMHEUmuHRgF5ExqTmG2kl8DMCGbB2m FMQcG7XAEFmRPgDShZ1udknYjrFpnJodwtbdIRzyCATHgMo7mxLkZIkLk3K9hyDV3+Kz s4fpBc4MH9Yqu1cFiYY9rK86TLFO9C4dEfUg2fyt7IX6R9cuU6KwJGIA4fIwfZ6uTQrb o+kaQQB6hzR8GTQW8eF1oXlZNL4KXZ2YQXosQLZdedL8ABB+WYal6oDI++iDVJlRRXEZ UGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247602; x=1709852402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AjTHKv757QZS7wC8lHubmHNC99iGHDbQ91APaNvFEtw=; b=oDUHPeRAfrwfaOzE5lBBhx74yEPooCfptII/fydKf66kLYwUY8ovsNIMdKSl1o7E8L N8gTgCD2bqc3us12mvqMR/SUz0gdgF+vMl6J2w2aNO9tQ3rgYJ3yYPf/TJ4PzdFENS3O 9uMT3CQDJcW6f4pYnQSF5MUdQ+ykQUfpo36pkR4ii0nTdeKV/HsMWsvAzcGyf6sVfUuz Pxfs3qm2wg0b2RYlMcs1TIryJ/xdwKKmIFgyD5Y48Z0gbYhowjdKbL5MTUtXJJ4z5ZI2 pN0GkGu7uO1vmz9+gjLtp9BB5GvTxCQaVfSebxTTYtlpNOfDHJl9EIcyDw3Wi8uPeLtR dASQ== X-Gm-Message-State: AOJu0YxulYhrp/N9393ek3LCWUzyAL14y4aUlMPyuX+TE1H9S0Kaqgde M/g2SE8lzwN4JEgG/bqkK1Qs5eVlME/V2Ib+3uvFKgQd5sM+9TDFbVOn7jcKU7yuebWZnV7rQ8r U X-Google-Smtp-Source: AGHT+IFv2b0uz4ehRZedh1w6eRBRiosTN9n6IcAfO7+HiGoMLLHnZVPlx6FBf094W+8uJ+SPYnwcJg== X-Received: by 2002:a05:6e02:1aa9:b0:365:f79:baa8 with SMTP id l9-20020a056e021aa900b003650f79baa8mr88719ilv.23.1709247602667; Thu, 29 Feb 2024 15:00:02 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev Subject: [PATCH 06/71] ip_frag: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:53 -0800 Message-ID: <20240229225936.483472-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv6_fragmentation.c | 4 +--- lib/ip_frag/rte_ipv6_reassembly.c | 6 ++---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/ip_frag/rte_ipv6_fragmentation.c b/lib/ip_frag/rte_ipv6_fragmentation.c index 56696f32f851..72ce6501c864 100644 --- a/lib/ip_frag/rte_ipv6_fragmentation.c +++ b/lib/ip_frag/rte_ipv6_fragmentation.c @@ -5,8 +5,6 @@ #include #include -#include - #include "ip_frag_common.h" /** @@ -23,7 +21,7 @@ __fill_ipv6hdr_frag(struct rte_ipv6_hdr *dst, { struct rte_ipv6_fragment_ext *fh; - rte_memcpy(dst, src, sizeof(*dst)); + memcpy(dst, src, sizeof(*dst)); dst->payload_len = rte_cpu_to_be_16(len); dst->proto = IPPROTO_FRAGMENT; diff --git a/lib/ip_frag/rte_ipv6_reassembly.c b/lib/ip_frag/rte_ipv6_reassembly.c index 88863a98d1fe..663b1737a64e 100644 --- a/lib/ip_frag/rte_ipv6_reassembly.c +++ b/lib/ip_frag/rte_ipv6_reassembly.c @@ -4,8 +4,6 @@ #include -#include - #include "ip_frag_common.h" /** @@ -143,8 +141,8 @@ rte_ipv6_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl, int32_t ip_len; int32_t trim; - rte_memcpy(&key.src_dst[0], ip_hdr->src_addr, 16); - rte_memcpy(&key.src_dst[2], ip_hdr->dst_addr, 16); + memcpy(&key.src_dst[0], ip_hdr->src_addr, 16); + memcpy(&key.src_dst[2], ip_hdr->dst_addr, 16); key.id = frag_hdr->id; key.key_len = IPV6_KEYLEN; From patchwork Thu Feb 29 22:57:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137581 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDDC243BAE; Fri, 1 Mar 2024 00:00:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6200A432AC; Fri, 1 Mar 2024 00:00:27 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 75E1A42FC3 for ; Fri, 1 Mar 2024 00:00:04 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-29a430c3057so1104325a91.1 for ; Thu, 29 Feb 2024 15:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247603; x=1709852403; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Qu1uDcO72pNt9gZI74NAYZ43yqBgR5SOgUCdZ/xFmU=; b=vQRfjx3b/lH82zwv/NoYIafkXT1uyHTv+DNHBBkK+CL5jB2njB97xxd7k9DJpo//89 s9eBFflXfRMQNOTOR8DRFQqa1A8vQF4BlQoaX3yseyuvSq4LEdEUXxVx4dKxDMUwHtcP lJEBBzRdZUtyPGLIMwzx+sfpUvLhOGTUZmGbzOiTs1uQnF4ndgy+OwlZiAhtjvZ6OGtG RwwxyukCxCTZuF681Z2FMUuiOd+VkLEvlPUayIPz7lqKjJlDQnwsFCFHCsjqvzIt1dkN Vw/hmt4k7OQvBv/4/NkH78n9YlipZy92tqoYnHApSz4kbZpBZSiiHSd7SzHnTMuOnpB+ euCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247603; x=1709852403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Qu1uDcO72pNt9gZI74NAYZ43yqBgR5SOgUCdZ/xFmU=; b=VinT3851GCCj9p1eVdippVKUprtM7r8Wcs1+yOJr2Ak5XvSVqdfVjQ9n0tQruHnm2E 1SB1IqAbnsY675+1mlaYo0UPOimW5lRUkqKrEun12xnvoXc69SH8Rm/0Ok4qEu4nkarN 6sU8mauRLuoatQr1nhLGUP9coiUMPHpuOUWTYqL9rhW1qcZjp2CrDc80bcG2ZJHQb1VZ fo6QAfcKxC05qeTmN+a22ov+y9oyeM9gjzpes8OhEgDZYQKC1fI0cUJjYyUSW+R+a0a+ z05zOlmszSwTBCkb1enbslRgkcLJ1yxQgI4Nwo/tmJp0XtO8W/aR2C6YkPlDGGjKEHfv SusA== X-Gm-Message-State: AOJu0Yx/FaByw9poNhuzZR/EjLXtfiTHEAd0+P1sFipTJB2SifL4A72Z C1ViDS6j+05BvcA3ibiz2XdBlVJL8SI2Clz3KRfBKYzoGj8UTvJYdPXcILhslj0rXf/ly5hju0Y u X-Google-Smtp-Source: AGHT+IEWdDgNGYI5BLePbkLvjhTyu7/toIBs7Cdig2IbXLHfpdAXdIsSNcAhkP0uex7hPHkaxD7igQ== X-Received: by 2002:a17:90a:7503:b0:29a:8de5:a33c with SMTP id q3-20020a17090a750300b0029a8de5a33cmr29375pjk.17.1709247603479; Thu, 29 Feb 2024 15:00:03 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 07/71] net: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:54 -0800 Message-ID: <20240229225936.483472-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/rte_ether.c b/lib/net/rte_ether.c index f59c20289d37..761b38f8053f 100644 --- a/lib/net/rte_ether.c +++ b/lib/net/rte_ether.c @@ -13,7 +13,7 @@ rte_eth_random_addr(uint8_t *addr) uint64_t rand = rte_rand(); uint8_t *p = (uint8_t *)&rand; - rte_memcpy(addr, p, RTE_ETHER_ADDR_LEN); + memcpy(addr, p, RTE_ETHER_ADDR_LEN); addr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR; /* clear multicast bit */ addr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR; /* set local assignment bit */ } From patchwork Thu Feb 29 22:57:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137583 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E26F243BAE; Fri, 1 Mar 2024 00:01:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4922427E5; Fri, 1 Mar 2024 00:00:36 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 7D75743258 for ; Fri, 1 Mar 2024 00:00:05 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-299a2456948so1154071a91.1 for ; Thu, 29 Feb 2024 15:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247604; x=1709852404; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cge62oB2hQoJVYLWwyWpZK/rL/hv6e9die6Yf0FWap4=; b=GvdsM3tsAnyyKq4rRjHZt4xk53N8UOsmtkwbM1k6bPgGgh63XjN0jCqddM539nKfzi ppbBF1hypdlCZ1W7WZP47XH0NsEi60VNES0zeXgzpKIDBoqR1lItiTJWhakzrI3O01sO HNYl0PMUHiObHoIvGtVjoJB3GFEa/iV5tyEoxux28Bbf4d9oSUKXtXI+jVSh1Uefo55i g3fDAgM9fWwlUtycDXbyM9Pxp3IoO72a4DrwrdJK+OcbzKuWZPUq4273zhJG42+ouw7I eewUlGmBOMwFHlmfP+KgjYqKMZrklZiiX3r3VbggeYxUthXmKO9V+FE3ykzpbHXGz3VU ZMHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247604; x=1709852404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cge62oB2hQoJVYLWwyWpZK/rL/hv6e9die6Yf0FWap4=; b=JvpevWDbDkWvdk+amyRh2FJ+3I4hgJnPS2hVkY6OFlEu/9qKHYAZnb+UG5I/rbWcnJ eUA+58Ws21h6ik8RF2A1FjCnh4cyXe9DSfGWv949XTdkkL2uX4KucMUNGGbCES7hW9Sr QtJrOpAYHmwWD478gv6kDfSVwQtN3R8HmFIKm9P9r3azQx2KUXrQ/mWNFEk9crlFI0x8 bI39O1fLTthG+SyeEbx256Pg1VuNwRd+EJBm5rOS4owyUHmADt8jqJrn89SX2Z5kyvod IEkT1l/oPkTPyvrc+9/80hwSj/rC1N2m+m+bHWWU+NuPkWiuswRy0vEzehQv7I44ZhZp CSpA== X-Gm-Message-State: AOJu0Yz2LHxIx3t2aq0AXQjH0316lFINPnMoHA9O2ZRUSt6ulLTQjH9e K5Kp66HXXQ7wt3XJsGKK6W72Jo4Uv8cmPwAAJNCOTKry79Vt828ttt3H7XMJsxWKXevMAvLPS9m 9 X-Google-Smtp-Source: AGHT+IFUifyV1y59NErZWH96B3uoSkKO6R2zoJMvZkmErIHPqWZ7HyzYFzvXJYddMOGk0vvX9BFgNQ== X-Received: by 2002:a17:90a:db12:b0:299:3f10:20ba with SMTP id g18-20020a17090adb1200b002993f1020bamr28622pjv.27.1709247604313; Thu, 29 Feb 2024 15:00:04 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson , Vladimir Medvedkin Subject: [PATCH 08/71] lpm: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:55 -0800 Message-ID: <20240229225936.483472-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 271bc480dc60..3303463fbd0a 100644 --- a/lib/lpm/rte_lpm6.c +++ b/lib/lpm/rte_lpm6.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -138,7 +137,7 @@ ip6_mask_addr(uint8_t *ip, uint8_t depth) static inline void ip6_copy_addr(uint8_t *dst, const uint8_t *src) { - rte_memcpy(dst, src, RTE_LPM6_IPV6_ADDR_SIZE); + memcpy(dst, src, RTE_LPM6_IPV6_ADDR_SIZE); } /* From patchwork Thu Feb 29 22:57:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137582 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD68343BAE; Fri, 1 Mar 2024 00:00:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19B7E40294; Fri, 1 Mar 2024 00:00:31 +0100 (CET) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by mails.dpdk.org (Postfix) with ESMTP id DA5634325B for ; Fri, 1 Mar 2024 00:00:05 +0100 (CET) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3c1a1e1e539so1479738b6e.1 for ; Thu, 29 Feb 2024 15:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247605; x=1709852405; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IWKz5vDuhvQw5GeEv6mkSttdCRlXm2J+mfGzk12cTK4=; b=cnegadCumrQoFZL+m3mDcxZYiEQNZldjiOd8Zs+yqN3qiinwrpBmwQQ/q8kQxMZ+bb AlTrapab5z1ki2ROyXsR8iLOg6xKZEuz5sO3fyWl+2y5Pnnjj2H9YnuVQmSA/RNoH7Hp Yx2bXVKjilH9WDS8l39VJ7LQUULex05WqekXJBJcW0+HOiwfYgypCYRgiLNzslaZkQmx KN/uU/4Ch0P7XZ2pd/SGeaTIICeW9dKzVyz0DUjhYNoudlHp0eV+2ARGoQkY5b74qpu7 Qzkg0TJVYko81/L3rdb7JFxnpv9dNb0D4tz4DtrT4brXAF5MFwFwaDpDXlY8csVgj0g0 0ozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247605; x=1709852405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IWKz5vDuhvQw5GeEv6mkSttdCRlXm2J+mfGzk12cTK4=; b=jx4+2XOuPjUYc9eGijQxxJ8NKf9umZqVx4XJCM6FBgkd4OqfURQpHfA593GgmWvX5H /vFvurc/rclkIxaAwTWfxpOfiYF4DjHvCAhX5isQpgUV37Sbv0IDSA/lOtPdmJ8DvSfT kDKh5C6MEiCNI6JkXP7MjrOlGwyAWa85xuPFhsscDmFVLA+elmwJaZFuU3WdALKEeycK bpQ3pdJ2zHXTRvWOb1Gg2BfXBCznUsUbUJaC2y+nRIbJ+cDhzFENwOt0rxqZBQJ3yBPL cccB54uU0a3AjbmQujT62nm9GwKB1Rs+0EwRSgarm6+Qav35TEev4Yvx+3RDgnchA7eC eW5A== X-Gm-Message-State: AOJu0YwTwgir51XOMbZX9oQToQ0laomH/EDtz40YmcUAxKnQR7nlUnWo S4gJ4UOtEOhwW+jKxMIBcgKX5A262O5wtRKmQM1JPCiFBIGAptqrX18uYf9PjkB8VhDtd+0T75Y k X-Google-Smtp-Source: AGHT+IFcb2HXQCuj5yCHUGoiTNRJEIuOFBKDhwnebpawA9te2Rr5d28nwRuiJOgfrjDIv0Q3a9qOww== X-Received: by 2002:a05:6808:124b:b0:3c1:7de9:492d with SMTP id o11-20020a056808124b00b003c17de9492dmr35691oiv.21.1709247605164; Thu, 29 Feb 2024 15:00:05 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Pavan Nikhilesh Subject: [PATCH 09/71] node: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:56 -0800 Message-ID: <20240229225936.483472-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/node/ip6_lookup.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c index 309964f60fd6..b8e567ccd92d 100644 --- a/lib/node/ip6_lookup.c +++ b/lib/node/ip6_lookup.c @@ -112,28 +112,28 @@ ip6_lookup_node_process_scalar(struct rte_graph *graph, struct rte_node *node, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf0, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[0], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[0], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf1 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf1, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf1, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[1], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[1], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf2 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf2, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf2, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[2], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[2], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf3 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf3, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf3, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16); rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop, 4); From patchwork Thu Feb 29 22:57:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137584 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88BC943BAE; Fri, 1 Mar 2024 00:01:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40708432BC; Fri, 1 Mar 2024 00:00:40 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 530CF4325A for ; Fri, 1 Mar 2024 00:00:07 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5cf2d73a183so2067613a12.1 for ; Thu, 29 Feb 2024 15:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247606; x=1709852406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j2GRggaBe0l63nkJ4Ur1Xfc/M4c8TdNUa8v+1VNgYSo=; b=hDbJof8gp7CGKmb4gEMhdeU5GO0kL8vkYNXyjFKHVXp0neahMHNeTFTgUtkj3S3edK pk8JmuOK0EwS7vIpIHhrDYPArerD2FbRnQWvRYsIyTuRdGYVEYbjcFAPGrCr9TiazPVR PIB4hpe7oHxmxYpTyYUcqBK34D8MyqW/ufLg7kTu5QO/DdZC4v8wnmJV9U1XUW1I03Fi yvZSiAD9pjq3WXMhsvPGT2yAqDZapqe0fDNEJPQnQNuLamPdFBNrEJl2tF0HfSqmbv0R ZhFqWhCjB6KLCoat3al/N47SBdZ9ztx446u6W8JOgHkW2zWxzLw6cUXAtXuR5ngRF9gI RYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247606; x=1709852406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j2GRggaBe0l63nkJ4Ur1Xfc/M4c8TdNUa8v+1VNgYSo=; b=j/UVXiP+gBxnH0R08IkvqjE6NgWLwHlv67DOuet7NJ1SWbo0SXwaQX4Uj+sTmb+O0F j1bilr8IzR+WwKy5rV3PqIrgihshPxsHVxJC5NqF4cHrMjuamDQ6syexLJ3geCf4saYz RLXb+B0V0V1FElh9oP+7Pam3BmiMpE17ZmrESDtTTsEd20zvkg9cQ3b3LYtlaDZaIo6F +BiWiH8z39PvPVps07S5dbbCUYdXSTcDuij3akCthtS/ewG06dPN2R8LNbC9sqDEhdV/ JsElV4zLqOoU2xH2HkjxKWtvjynjR8YnI+CPazdA59RTOXIjjwQDxU86ZHpN+ODPptKS cqAQ== X-Gm-Message-State: AOJu0YzdLz1eN3jMfhKTDlI00hhK0t6YFY8WO0awwRnWU8h0rUCUG3+e W7A0spL9FDpwcBlZ4rPN4LGSfr1TEIMpc9nRBVOWfQOV2pFYeoX8dtDbvBOPiCECNQaPvUAwCmy l X-Google-Smtp-Source: AGHT+IEgqbI9/RAGGVMWO2+Lxf0jwpNss3MX/XY0bFZb0wDwZUV59rhHZNsMiyWyDNQRV+tYMV/Wag== X-Received: by 2002:a17:90a:8905:b0:29a:72b:df85 with SMTP id u5-20020a17090a890500b0029a072bdf85mr510202pjn.7.1709247606082; Thu, 29 Feb 2024 15:00:06 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph , Volodymyr Fialko Subject: [PATCH 10/71] pdcp: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:57 -0800 Message-ID: <20240229225936.483472-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pdcp/pdcp_process.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/pdcp/pdcp_process.c b/lib/pdcp/pdcp_process.c index 9b9b881124b8..6c0693f66629 100644 --- a/lib/pdcp/pdcp_process.c +++ b/lib/pdcp/pdcp_process.c @@ -60,7 +60,7 @@ pdcp_iv_gen_null_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv *e m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -72,10 +72,10 @@ pdcp_iv_gen_null_zs(struct rte_crypto_op *cop, const struct entity_priv *en_priv iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static void @@ -89,7 +89,7 @@ pdcp_iv_gen_aes_ctr_null(struct rte_crypto_op *cop, const struct entity_priv *en iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, 16); + memcpy(iv, iv_u64, 16); } static void @@ -101,8 +101,8 @@ pdcp_iv_gen_zs_null(struct rte_crypto_op *cop, const struct entity_priv *en_priv iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64 = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64, 8); - rte_memcpy(iv + 8, &iv_u64, 8); + memcpy(iv, &iv_u64, 8); + memcpy(iv + 8, &iv_u64, 8); } static void @@ -115,17 +115,17 @@ pdcp_iv_gen_zs_zs(struct rte_crypto_op *cop, const struct entity_priv *en_priv, /* Generating cipher IV */ iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); - rte_memcpy(iv + 8, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); + memcpy(iv + 8, &iv_u64[0], 8); iv += PDCP_IV_LEN; /* Generating auth IV */ iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static void @@ -140,12 +140,12 @@ pdcp_iv_gen_zs_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv *en_ iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); - rte_memcpy(iv + 8, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); + memcpy(iv + 8, &iv_u64[0], 8); m_ptr = (uint8_t *)rte_pktmbuf_prepend(mb, 8); m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -162,11 +162,11 @@ pdcp_iv_gen_aes_ctr_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, PDCP_IV_LEN); + memcpy(iv, iv_u64, PDCP_IV_LEN); m_ptr = (uint8_t *)rte_pktmbuf_prepend(mb, 8); m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -179,15 +179,15 @@ pdcp_iv_gen_aes_ctr_zs(struct rte_crypto_op *cop, const struct entity_priv *en_p iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, PDCP_IV_LEN); + memcpy(iv, iv_u64, PDCP_IV_LEN); iv += PDCP_IV_LEN; iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static int From patchwork Thu Feb 29 22:57:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137585 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6FAC43BAE; Fri, 1 Mar 2024 00:01:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 042C1432E8; Fri, 1 Mar 2024 00:00:43 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id C729A4325A for ; Fri, 1 Mar 2024 00:00:07 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29ae4c7da02so1107388a91.2 for ; Thu, 29 Feb 2024 15:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247607; x=1709852407; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/xlAJnwaWn+Xw+Q/XhSlkHfr43MGX/g/yNBJJd1u4nU=; b=o8L2XIp/jcU6roDT4/evRWk++wUTD/J6SiQ9qXRYYF/FfHVS92L20/bXL4kaHHxo6n TUo6FY0wboutm3iduJdxzGR+sDjDZrpVj/WKVTbjvsVRNKzYGJZ+7/YKwU2NggXjACBD dc0QYJ52d58suPrJrqL+9ws4z1Yz6gYOhfZw7iEmW+PlH/gCXkqDj45L7MemdQtSRwWE zkKWR5PfUu7g45AqnmTtKTd9XpMlMqWDDnJAJAFNPeZgCu+dxlDRkgxgK+ObAac/LZF3 yHxF201d0W3iQpLsqByZFOHcYzE4ZaRKCs1YaK26xZOXBzrJ63h3cq+uhXrc+vDPNT5U zvOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247607; x=1709852407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/xlAJnwaWn+Xw+Q/XhSlkHfr43MGX/g/yNBJJd1u4nU=; b=ZCjlyapPxQc7v5es7Gxd+jrJjMpsClX+qnFhdKP4cQcX21tOaHGAMnSv+3jCQYG8rP 4LvE3mji8M5R0L3tlPDUZZ5cCHtP4bwPXS1SOhT16d9d8kIFag5ToEDEjjeSLt+HSwAu 2i6+hkQgNklhP4cxQONgC1wcwK6TkxYfwjYjWdO3TgmUaOjzi5UkDjH+daOVptMUhl0t cAToHbekR5HZii7ue2r3osKQDqZwBR8YhiZ22Ar+rE+7PSwUd+6aF7ywe98OdYZ8W2mV nWDw81EG0xp/cErBAhwpbWFT8x72Gl61shog2Q29ipLkFCL8qwWr+UkmQrctfn1QYwr2 Z8kg== X-Gm-Message-State: AOJu0Yw95qumV5ZIEw4CjPWNvwygH3EEWsVt89FGxzxmwCtLbTH/lrb7 BDKirLA6CIWZj2hJcp9ZBcuFfIIBlCtZrkL5kUhiaYCCCNcWaZOILpr7zWu2jnsIxD+2u7RRits n X-Google-Smtp-Source: AGHT+IG9O4ifyoghEcBf8xBkgNlR+CTptB1QkHSKKPkD8dV91OqHUTEw6cTjFm1jPEbq5VzkfHKliw== X-Received: by 2002:a17:90b:1256:b0:29a:7303:f7d7 with SMTP id gx22-20020a17090b125600b0029a7303f7d7mr22393pjb.38.1709247606839; Thu, 29 Feb 2024 15:00:06 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 11/71] pipeline: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:58 -0800 Message-ID: <20240229225936.483472-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_table_action.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c index dfdbc66b087c..c2312dc803a1 100644 --- a/lib/pipeline/rte_table_action.c +++ b/lib/pipeline/rte_table_action.c @@ -1441,7 +1441,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, tcp->src_port, data->port); - rte_memcpy(ip->src_addr, data->addr, 16); + memcpy(ip->src_addr, data->addr, 16); tcp->src_port = data->port; tcp->cksum = tcp_cksum; } else { @@ -1454,7 +1454,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, udp->src_port, data->port); - rte_memcpy(ip->src_addr, data->addr, 16); + memcpy(ip->src_addr, data->addr, 16); udp->src_port = data->port; udp->dgram_cksum = udp_cksum; } @@ -1469,7 +1469,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, tcp->dst_port, data->port); - rte_memcpy(ip->dst_addr, data->addr, 16); + memcpy(ip->dst_addr, data->addr, 16); tcp->dst_port = data->port; tcp->cksum = tcp_cksum; } else { @@ -1482,7 +1482,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, udp->dst_port, data->port); - rte_memcpy(ip->dst_addr, data->addr, 16); + memcpy(ip->dst_addr, data->addr, 16); udp->dst_port = data->port; udp->dgram_cksum = udp_cksum; } From patchwork Thu Feb 29 22:57:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137586 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F4CF43BAE; Fri, 1 Mar 2024 00:01:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80B1843245; Fri, 1 Mar 2024 00:00:45 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 7C06E43269 for ; Fri, 1 Mar 2024 00:00:08 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-53fa455cd94so1244836a12.2 for ; Thu, 29 Feb 2024 15:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247608; x=1709852408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oInQe7TJwsx4haBs0A5610somZKv4suPtH2RLw/8KEY=; b=kAUDgV08WzOKQQFKYmnU0C0qtX4bOzT4epY84TSFohPbimyWk/YDlpBW1aLP+vjx8x AejMpqi2nJ9quHFOVTA23WpQkjV0a+k089a0zYnYx2IqGf2rkwYlmdilRgYwPp6byJWd 0hi/trq9kZrm+E/3hloN4uLB0ES5mxrlx2H4FMEn8NWXqzeeRQ1F1g7W8qOfH2Jnx2/O TFnneEI/mUZYZxrSK333fWjnUKAdZ4LUZBVxhxNLnWecENN/NUG435lk84sEmjTOkwyi QTTrVJtLeCdWZPypE7rDdQpQyKsYULKQuLvMViRAImuZjel7tfqrMuaZ7OzFAFsuplPq IOPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247608; x=1709852408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oInQe7TJwsx4haBs0A5610somZKv4suPtH2RLw/8KEY=; b=tTFhSD9un1L42SavXuUZIVsvQ19GHEOMa9VNImmH96eCmA5iV/+RQNmMczt/pX3DqC yWODBB9Dc7UlcFdZnDda3kPdHBLz9WqNGnhM9IO0weCADZsJCGzRLBI4pO3gC6KymKCP 3VpMdBIHcWHP4iOhzQI/zeGKqNZEJQe8N56oa7I9My4tzM+YkwVD+FloaLJs0z0q+gAz aRSNwJZ+Gcf1rmkVIovcKRWNCiZQCEdO3oFtAVOO+PK6o30hhBZVlcFM8e3ZMcs7nRkf HhUAKfMshpYp0KCfW/0Jd5rHMlChBZFRffkFmsj00yrLoiDo+NAevASj+6R38N3CJSw/ spGQ== X-Gm-Message-State: AOJu0Yzq1K+zO3ES9R8rWOadRLhtVWyuHb75zH/KA6Fazr1DC4Gk/1zo Z0lh9uRekwZXB5of73xDU9FU8lSvRPAbqK9inst7Me91iUNONl2kxAbrctleSfSrJt4Tc+aQoqN h X-Google-Smtp-Source: AGHT+IEpPiAEpb9D5TdzQodWlYQyErLKzNzr9He3XEERN1dme6Op6RMXX5dpfvjEoEQiA1V8XsrD8Q== X-Received: by 2002:a17:90a:cb94:b0:29b:171c:a787 with SMTP id a20-20020a17090acb9400b0029b171ca787mr34447pju.19.1709247607630; Thu, 29 Feb 2024 15:00:07 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Vladimir Medvedkin Subject: [PATCH 12/71] rib: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:57:59 -0800 Message-ID: <20240229225936.483472-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Mostly automatically generated by devtools/cocci/rte_memcpy.cocci The fib/trie.c was relying on headers rte_rib6 -> rte_memcpy -> rte_vect since rib6 is no longer using rte_memcpy need to get rte_vect.h Signed-off-by: Stephen Hemminger --- lib/fib/trie.c | 2 +- lib/rib/rte_rib6.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287cc..a77f6c758b0d 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -9,7 +9,7 @@ #include #include #include - +#include #include #include #include "trie.h" diff --git a/lib/rib/rte_rib6.h b/lib/rib/rte_rib6.h index 775286f965f2..8fa5752bddec 100644 --- a/lib/rib/rte_rib6.h +++ b/lib/rib/rte_rib6.h @@ -14,7 +14,6 @@ * Level compressed tree implementation for IPv6 Longest Prefix Match */ -#include #include #ifdef __cplusplus @@ -61,7 +60,7 @@ rte_rib6_copy_addr(uint8_t *dst, const uint8_t *src) { if ((dst == NULL) || (src == NULL)) return; - rte_memcpy(dst, src, RTE_RIB6_IPV6_ADDR_SIZE); + memcpy(dst, src, RTE_RIB6_IPV6_ADDR_SIZE); } /** From patchwork Thu Feb 29 22:58:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137587 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2964C43BAE; Fri, 1 Mar 2024 00:01:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E827A432FC; Fri, 1 Mar 2024 00:00:47 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 6706E4325A for ; Fri, 1 Mar 2024 00:00:09 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-299dba8fd24so1098943a91.2 for ; Thu, 29 Feb 2024 15:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247608; x=1709852408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f7ShVjOP7v3RAN9c6QxL/R4mkZ6ArXruvMZ0jTEazuM=; b=krwyCyUh32WDu+EhtOpglW2IbbHZAWlar2aJq3pcc6XUEim8ZYS8oyCgAjM5hI1YJp QeR5tSTJoFS3G2cVqptO9tuVEZj46e9J1fUVBM670JazQ5jACD60EqDVKI4ATv34KQeE 37UaLxh+vXtXY5fDcoIZsuXLV5rLkJ3G0N4lZuK85BolgiUOJQrCFz4whhZETjl6clIs bqi/0Flev1JNQENAB5y/PNVqed1sk54UIuuoct54/c5JrC/yGdFo80mv+1cWoCZE9UHO cFKi3VkUJwJOiuGkOm6rigwrZKiDcs+nXB8vKMBVjJmsqpChYDtyAOIrZ59MdW0yjnBJ /bzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247608; x=1709852408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7ShVjOP7v3RAN9c6QxL/R4mkZ6ArXruvMZ0jTEazuM=; b=K8clWF3KWV4hj4B0IpOkkTtIb333NjJX0PdYku17u7/W3c0IR1OJc6H6GHhRXX/XXN 1VSaLLPt16zXXUuZkIaOr9RWeSaky+Pmy82sjZgGMjkHCsB/osiJ0HVrW+1Uwzt6S7Fy WV2rWs4d4+6fAADP8Kuz97qSEoVfa3uRAfGOxDsMwwgYpOESEkDEUF202bGc4MgYeZrT sJzKnIsUFNUA3Y0uKYy5aJWrP3iDCEbAz99f4ZJGBCFLzl1BBi+bOhb1F7uy/kPdjJyZ Cp3ubejh7U2opW2IRNCCnqWG/+wIHsX1ANRWd2sUn+vM7i+RgVkrSduNuEycLDS6I3rL 589w== X-Gm-Message-State: AOJu0Yz+4a9Sstx33JSF1XG4IXn/zaoXaj+T8sAfqwSY6WjpUQJ5H/5m xqraKsZtfNU9GtApZlsIswGk5pxgYurpkI7l5L9HAZ4T9wCI5cqFQx7zE2V3cyd++eZzWWwvVTP G X-Google-Smtp-Source: AGHT+IE3AR78b4OOlkoNn8ixdrg+4SD/cylLdvV9ORvuSohPHf1JxeNp+MAFY6lavZF11xzU7PV9YQ== X-Received: by 2002:a17:90a:d58a:b0:29a:2860:28b9 with SMTP id v10-20020a17090ad58a00b0029a286028b9mr14907pju.48.1709247608485; Thu, 29 Feb 2024 15:00:08 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal , Anoob Joseph Subject: [PATCH 13/71] security: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:00 -0800 Message-ID: <20240229225936.483472-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/security/rte_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index e5c862f5f570..28d59ef38831 100644 --- a/lib/security/rte_security.c +++ b/lib/security/rte_security.c @@ -384,7 +384,7 @@ crypto_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { memset(&caps_val, 0, CRYPTO_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < CRYPTO_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } @@ -409,7 +409,7 @@ sec_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->action != RTE_SECURITY_ACTION_TYPE_NONE) { memset(&caps_val, 0, SEC_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < SEC_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } From patchwork Thu Feb 29 22:58:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137588 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 035E043BAE; Fri, 1 Mar 2024 00:01:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 946B34029E; Fri, 1 Mar 2024 00:00:50 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 7766243269 for ; Fri, 1 Mar 2024 00:00:11 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so1263992a12.0 for ; Thu, 29 Feb 2024 15:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247610; x=1709852410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J5lGsz8zSj9bml/O+Ktt4X06wyer0sRSUXfJgwoKNqU=; b=hrTdnwHwxYfWeCL02dQ8Av0NRGLEFcTEzRtmiDG4a1Ta71OmFf9rwQzFjg22RMnDwu 0M8XX7Qoo5pGL15JP508IGjiatP54YhJfzemcwIeYAfXg/L3TZMq/iO0tou+AHMUaroZ IBRx6XvW4lOHOcnKrwojTdAFmz7yx8cwU9BsATn+yyLDYgMbP4yzPUhIAQwu2UFJ3h5x hMHpcU4pcumlJACuv5jucmP7CHP4XcZNi9bue50bIPNiOpvzzLpkFd23DVcD4o6w4lNR K5s5AiRXrAwUp5tGKaZp4/JgBekMmCiayHsNcrWlm2JjX7yrt6PWYRRI7t5LfSokI44q umFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247610; x=1709852410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J5lGsz8zSj9bml/O+Ktt4X06wyer0sRSUXfJgwoKNqU=; b=qCDJnqQCFRTLkVcdz81QQBlq2/9PBmk5IE2OXswSZxQh8hv2zqI+89bTH3yreCrr0r MSbIZ1/6ucjI6v10rLFJ5S426pfIfD5ISIH3BYK1ISrQX+mdSTz2xL3SLGhdQgwKtVp7 rH5/9+77rMwDXvvBqYfcUovifk0Vhocpg0JJb/K7EhyQTQcZYbLzNv4j2mFu9EzxQgUd Ql4s9/N6lQhXhu+js5rWUT2/yGij+BJkegEYdG+kcetcAl25XqKsctX3oXGmHMzMnDWN Hxuk/EV9ImLzh7tSZKXAY1rm7xndSPE/k7a5E6O5Vrl0uShfnbKJNuwDMBT8ZZAM4cZm Kr9A== X-Gm-Message-State: AOJu0YzGNInJlBhCBZjq0mv5Vvao5gGre8Rq1VdxInYTjsW2Wm6StYh6 +AJVGfuasapGBVKaglLlebu0nNDOtCreG29OnO8ARAfuxeW2qdvTXXI3AukFigPXEUN0Qo2xIiY F X-Google-Smtp-Source: AGHT+IGQPitrhzAul3vArWlltamUcL0l4tbtv3r/UFU4hLjONrxUgucsV/mP5QcXUZDugr7+MH5YHA== X-Received: by 2002:a17:90a:1f09:b0:296:530:996e with SMTP id u9-20020a17090a1f0900b002960530996emr408209pja.20.1709247609494; Thu, 29 Feb 2024 15:00:09 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH 14/71] net/mlx5: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:01 -0800 Message-ID: <20240229225936.483472-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_devx.c | 4 ++-- drivers/net/mlx5/mlx5_flow.c | 38 ++++++++++++++++---------------- drivers/net/mlx5/mlx5_flow_aso.c | 6 ++--- drivers/net/mlx5/mlx5_flow_hw.c | 16 +++++++------- drivers/net/mlx5/mlx5_rx.c | 6 ++--- drivers/net/mlx5/mlx5_rxtx_vec.c | 8 +++---- 6 files changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index 9fa400fc48ef..6380a5c83cd3 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -512,7 +512,7 @@ mlx5_rxq_obj_hairpin_new(struct mlx5_rxq_priv *rxq) * during queue setup. */ MLX5_ASSERT(hca_attr->hairpin_data_buffer_locked); - rte_memcpy(&locked_attr, &unlocked_attr, sizeof(locked_attr)); + memcpy(&locked_attr, &unlocked_attr, sizeof(locked_attr)); locked_attr.hairpin_data_buffer_type = MLX5_RQC_HAIRPIN_DATA_BUFFER_TYPE_LOCKED_INTERNAL_BUFFER; tmpl->rq = mlx5_devx_cmd_create_rq(priv->sh->cdev->ctx, &locked_attr, @@ -1289,7 +1289,7 @@ mlx5_txq_obj_hairpin_new(struct rte_eth_dev *dev, uint16_t idx) */ MLX5_ASSERT(hca_attr->hairpin_sq_wq_in_host_mem); MLX5_ASSERT(hca_attr->hairpin_sq_wqe_bb_size > 0); - rte_memcpy(&host_mem_attr, &dev_mem_attr, sizeof(host_mem_attr)); + memcpy(&host_mem_attr, &dev_mem_attr, sizeof(host_mem_attr)); umem_size = MLX5_WQE_SIZE * RTE_BIT32(host_mem_attr.wq_attr.log_hairpin_num_packets); umem_dbrec = RTE_ALIGN(umem_size, MLX5_DBR_SIZE); diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 2b2ae626186e..53c20592b91a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -4495,8 +4495,8 @@ flow_action_handles_translate(struct rte_eth_dev *dev, (error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_NUM, NULL, "too many shared actions"); } - rte_memcpy(&handle[copied_n].action, &actions[n].conf, - sizeof(actions[n].conf)); + memcpy(&handle[copied_n].action, &actions[n].conf, + sizeof(actions[n].conf)); handle[copied_n].index = n; copied_n++; } @@ -5362,29 +5362,29 @@ flow_hairpin_split(struct rte_eth_dev *dev, case RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP: case RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN: case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP: - rte_memcpy(actions_tx, actions, + memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); actions_tx++; break; case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID: if (push_vlan) { - rte_memcpy(actions_tx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, + sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; case RTE_FLOW_ACTION_TYPE_COUNT: if (encap) { - rte_memcpy(actions_tx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, + sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; @@ -5396,8 +5396,8 @@ flow_hairpin_split(struct rte_eth_dev *dev, actions_tx++; encap = 1; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; @@ -5408,14 +5408,14 @@ flow_hairpin_split(struct rte_eth_dev *dev, sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; default: - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; break; } @@ -5425,7 +5425,7 @@ flow_hairpin_split(struct rte_eth_dev *dev, tag_action->type = (enum rte_flow_action_type) MLX5_RTE_FLOW_ACTION_TYPE_TAG; actions_rx++; - rte_memcpy(actions_rx, actions, sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, sizeof(struct rte_flow_action)); actions_rx++; set_tag = (void *)actions_rx; *set_tag = (struct mlx5_rte_flow_action_set_tag) { @@ -5435,7 +5435,7 @@ flow_hairpin_split(struct rte_eth_dev *dev, MLX5_ASSERT(set_tag->id > REG_NON); tag_action->conf = set_tag; /* Create Tx item list. */ - rte_memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); addr = (void *)&pattern_tx[2]; item = pattern_tx; item->type = (enum rte_flow_item_type) diff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c index f3114434729e..49de92c675cd 100644 --- a/drivers/net/mlx5/mlx5_flow_aso.c +++ b/drivers/net/mlx5/mlx5_flow_aso.c @@ -1327,9 +1327,9 @@ mlx5_aso_ct_status_update(struct mlx5_aso_sq *sq, uint16_t num) MLX5_ASSERT(ct); MLX5_ASO_CT_UPDATE_STATE(ct, ASO_CONNTRACK_READY); if (sq->elts[idx].query_data) - rte_memcpy(sq->elts[idx].query_data, - (char *)((uintptr_t)sq->mr.addr + idx * 64), - 64); + memcpy(sq->elts[idx].query_data, + (char *)((uintptr_t)sq->mr.addr + idx * 64), + 64); } } diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index bcf43f545779..04b12bba95a9 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -1970,7 +1970,7 @@ mlx5_tbl_translate_modify_header(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "translate modify_header: no memory for modify header context"); - rte_memcpy(acts->mhdr, mhdr, sizeof(*mhdr)); + memcpy(acts->mhdr, mhdr, sizeof(*mhdr)); pattern.data = (__be64 *)acts->mhdr->mhdr_cmds; if (mhdr->shared) { uint32_t flags = mlx5_hw_act_flag[!!attr->group][tbl_type] | @@ -2823,9 +2823,9 @@ flow_hw_modify_field_construct(struct mlx5_hw_q_job *job, mhdr_action->src.field != RTE_FLOW_FIELD_POINTER) return 0; if (mhdr_action->src.field == RTE_FLOW_FIELD_VALUE) - rte_memcpy(values, &mhdr_action->src.value, sizeof(values)); + memcpy(values, &mhdr_action->src.value, sizeof(values)); else - rte_memcpy(values, mhdr_action->src.pvalue, sizeof(values)); + memcpy(values, mhdr_action->src.pvalue, sizeof(values)); if (mhdr_action->dst.field == RTE_FLOW_FIELD_META || mhdr_action->dst.field == RTE_FLOW_FIELD_TAG || mhdr_action->dst.field == RTE_FLOW_FIELD_METER_COLOR || @@ -4467,7 +4467,7 @@ flow_hw_table_create(struct rte_eth_dev *dev, rte_flow_error_set(error, err, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "Failed to create template table"); else - rte_memcpy(error, &sub_error, sizeof(sub_error)); + memcpy(error, &sub_error, sizeof(sub_error)); } return NULL; } @@ -7773,8 +7773,8 @@ flow_hw_create_tx_repr_tag_jump_acts_tmpl(struct rte_eth_dev *dev, struct rte_flow_action actions_m[4] = { { 0 } }; unsigned int idx = 0; - rte_memcpy(set_tag_v.src.value, &tag_value, sizeof(tag_value)); - rte_memcpy(set_tag_m.src.value, &tag_mask, sizeof(tag_mask)); + memcpy(set_tag_v.src.value, &tag_value, sizeof(tag_value)); + memcpy(set_tag_m.src.value, &tag_mask, sizeof(tag_mask)); flow_hw_update_action_mask(&actions_v[idx], &actions_m[idx], RTE_FLOW_ACTION_TYPE_MODIFY_FIELD, &set_tag_v, &set_tag_m); @@ -8181,8 +8181,8 @@ flow_hw_create_ctrl_regc_jump_actions_template(struct rte_eth_dev *dev, }; set_reg_v.dst.offset = rte_bsf32(marker_mask); - rte_memcpy(set_reg_v.src.value, &marker_bits, sizeof(marker_bits)); - rte_memcpy(set_reg_m.src.value, &marker_mask, sizeof(marker_mask)); + memcpy(set_reg_v.src.value, &marker_bits, sizeof(marker_bits)); + memcpy(set_reg_m.src.value, &marker_mask, sizeof(marker_mask)); return flow_hw_actions_template_create(dev, &attr, actions_v, actions_m, error); } diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c index 5bf1a679b2d8..e35f9abd2064 100644 --- a/drivers/net/mlx5/mlx5_rx.c +++ b/drivers/net/mlx5/mlx5_rx.c @@ -761,9 +761,9 @@ mlx5_rx_poll_len(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cqe, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_cqe, - (const void *)(uintptr_t)cqe, - sizeof(struct mlx5_cqe)); + memcpy(&rxq->title_cqe, + (const void *)(uintptr_t)cqe, + sizeof(struct mlx5_cqe)); } } } diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.c b/drivers/net/mlx5/mlx5_rxtx_vec.c index 2363d7ed27a7..c3bcd3ef16de 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec.c +++ b/drivers/net/mlx5/mlx5_rxtx_vec.c @@ -349,8 +349,8 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_pkt, elts[nocmp_n - 1], - sizeof(struct rte_mbuf)); + memcpy(&rxq->title_pkt, elts[nocmp_n - 1], + sizeof(struct rte_mbuf)); } /* Decompress the last CQE if compressed. */ if (comp_idx < MLX5_VPMD_DESCS_PER_LOOP) { @@ -499,8 +499,8 @@ rxq_burst_mprq_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_pkt, elts[nocmp_n - 1], - sizeof(struct rte_mbuf)); + memcpy(&rxq->title_pkt, elts[nocmp_n - 1], + sizeof(struct rte_mbuf)); } /* Decompress the last CQE if compressed. */ if (comp_idx < MLX5_VPMD_DESCS_PER_LOOP) { From patchwork Thu Feb 29 22:58:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137589 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B509F43BAE; Fri, 1 Mar 2024 00:01:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AA7A4330C; Fri, 1 Mar 2024 00:00:52 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 266554325B for ; Fri, 1 Mar 2024 00:00:11 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-299a2456948so1154173a91.1 for ; Thu, 29 Feb 2024 15:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247610; x=1709852410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=; b=syL9TY01yLSVt0TfGAEr3ngJr95bmBo/2NVjOH2xyNS/UxFh8ND9CFoakcKFMJW8a9 ZKGDGjYUl4kswsg9KVQjGx+WG2z6dzLFofB0K/3ZjNSJuEn0SmfoEqBEXnrftHk9rWz8 JcIntpWbJP31K49qw7TF4dSqn4nhtRVSK6FBf88ycMkcjivsDjTslLwRkV3eruY/jNvH 79eqk3QbMM+Y0oH2S1Gkp2FVKMNAWYj4XNALlq3Dw6XdZjmNYZ/loc6jtwy6HTP6sIqh 49Ha6LEo43jzeCR1/WcxBGJ5J9l2H9jAPUintAYnUxKbWLJs/ZGyUBG0m6YCOgKMRqWz aqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247610; x=1709852410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=; b=wM6CYsLF9U4BMwxsv1xrxGxaoY6mCvQEho9gj/dD3kZnrj3E9+blnR2x9Gg7EADl3G kiQNWzOd6+g2F4D7oc8x7J8p/tHzxyfQqkf+gbijsLgLQtMRImR0xGztVFcO74ylS7ya lgUUTPK+bZtRiPWvLUTAT3Oy8DHvlTlb3Kn8/MDYPD9bnIbw2zeqeW6fnh7zDfr5+B0l FXbdN8ACXaw2BYWlHIvWDfgcYuPKzYsAdpI067oROuzvNtdPHXEaz+248pvpv8ByJ5Yt VVPg4MhP1ZZrvYz0BsuYEH4FuIFkkCiTsPmTgu3hlzCACJRBwzXcuZVzT+RSBzJGLaIj W4tQ== X-Gm-Message-State: AOJu0YxXqI6/b/YFQITkZHQqxFJpBzsyxynVQczCIn0RD3IPPLFqS+BT qvZz+miX2+kflNpd0N6Fn1Xbtbta4ObqRQsS/Uf5lLqej8upEtZcWxXvMoVrWLmTH05bNgK/42+ K X-Google-Smtp-Source: AGHT+IHRqrCqbV/wMrWBwH+hEXk65UyFtRqv54EBd2gkvFBx5+kv1zlWbtmFfNR5IjM2ERrbVY+uTg== X-Received: by 2002:a17:90a:dd93:b0:29a:7579:88bc with SMTP id l19-20020a17090add9300b0029a757988bcmr18225pjv.46.1709247610248; Thu, 29 Feb 2024 15:00:10 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chaoyong He Subject: [PATCH 15/71] net/nfp: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:02 -0800 Message-ID: <20240229225936.483472-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_conntrack.c | 2 +- drivers/net/nfp/flower/nfp_flower_flow.c | 16 ++++++++-------- drivers/net/nfp/flower/nfp_flower_representor.c | 2 +- drivers/net/nfp/nfp_mtr.c | 10 +++++----- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_conntrack.c b/drivers/net/nfp/flower/nfp_conntrack.c index f89003be8b40..279bf17eb3a5 100644 --- a/drivers/net/nfp/flower/nfp_conntrack.c +++ b/drivers/net/nfp/flower/nfp_conntrack.c @@ -1470,7 +1470,7 @@ nfp_ct_do_flow_merge(struct nfp_ct_zone_entry *ze, merge_entry->ze = ze; merge_entry->pre_ct_parent = pre_ct_entry; merge_entry->post_ct_parent = post_ct_entry; - rte_memcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie)); + memcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie)); merge_entry->rule.items_cnt = pre_ct_entry->rule.items_cnt + post_ct_entry->rule.items_cnt - cnt_same_item - 1; merge_entry->rule.actions_cnt = pre_ct_entry->rule.actions_cnt + diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c index e26be30d1833..3d07a4429b62 100644 --- a/drivers/net/nfp/flower/nfp_flower_flow.c +++ b/drivers/net/nfp/flower/nfp_flower_flow.c @@ -178,10 +178,10 @@ nfp_mask_id_alloc(struct nfp_flow_priv *priv, return -ENOENT; } - rte_memcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS); *mask_id = temp_id; - rte_memcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS); ring->tail = (ring->tail + NFP_FLOWER_MASK_ELEMENT_RS) % (NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS); @@ -200,7 +200,7 @@ nfp_mask_id_free(struct nfp_flow_priv *priv, if (CIRC_SPACE(ring->head, ring->tail, NFP_FLOWER_MASK_ENTRY_RS) == 0) return -ENOBUFS; - rte_memcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS); ring->head = (ring->head + NFP_FLOWER_MASK_ELEMENT_RS) % (NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS); @@ -2247,13 +2247,13 @@ nfp_flow_action_set_mac(char *act_data, set_mac = action->conf; if (mac_src_flag) { - rte_memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], - set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], + set_mac->mac_addr, RTE_ETHER_ADDR_LEN); for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) set_eth->eth_addr_mask[RTE_ETHER_ADDR_LEN + i] = 0xff; } else { - rte_memcpy(&set_eth->eth_addr[0], - set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&set_eth->eth_addr[0], set_mac->mac_addr, + RTE_ETHER_ADDR_LEN); for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) set_eth->eth_addr_mask[i] = 0xff; } @@ -2329,7 +2329,7 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->reserved = 0; for (i = 0; i < 4; i++) { - rte_memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4); + memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4); set_ip->ipv6[i].exact = tmp; set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); } diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 4f4df0cd2ee2..ce2b06611802 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -181,7 +181,7 @@ nfp_flower_repr_stats_get(struct rte_eth_dev *ethdev, struct nfp_flower_representor *repr; repr = ethdev->data->dev_private; - rte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats)); + memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats)); return 0; } diff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c index 255977ec2236..1f173409b421 100644 --- a/drivers/net/nfp/nfp_mtr.c +++ b/drivers/net/nfp/nfp_mtr.c @@ -243,7 +243,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower, struct nfp_profile_conf old_conf; /* Get the old profile config */ - rte_memcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf)); + memcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf)); memset(&mtr_profile->conf, 0, sizeof(struct nfp_profile_conf)); @@ -267,7 +267,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower, return 0; rollback: - rte_memcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf)); + memcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf)); return ret; } @@ -492,8 +492,8 @@ nfp_mtr_policy_add(struct rte_eth_dev *dev, } mtr_policy->policy_id = mtr_policy_id; - rte_memcpy(&mtr_policy->policy, policy, - sizeof(struct rte_mtr_meter_policy_params)); + memcpy(&mtr_policy->policy, policy, + sizeof(struct rte_mtr_meter_policy_params)); /* Insert policy into policy list */ LIST_INSERT_HEAD(&priv->policies, mtr_policy, next); @@ -1028,7 +1028,7 @@ nfp_mtr_stats_read(struct rte_eth_dev *dev, *stats_mask = mtr->stats_mask; rte_spinlock_lock(&priv->mtr_stats_lock); - rte_memcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr)); + memcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr)); rte_spinlock_unlock(&priv->mtr_stats_lock); prev = &mtr->mtr_stats.prev; From patchwork Thu Feb 29 22:58:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137591 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAD8943BAE; Fri, 1 Mar 2024 00:02:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F00984326A; Fri, 1 Mar 2024 00:00:55 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id D46A64325B for ; Fri, 1 Mar 2024 00:00:12 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-29a378040daso1026592a91.1 for ; Thu, 29 Feb 2024 15:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247612; x=1709852412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GEbsLnLgcuyzMnZrYqny/7Ykl6Zj5T6JhoXq2O6L540=; b=ON9DjzS/nInovNMuR9RgwGvQJV2xo3wojblLhv8JlSyyf3oszS+sH2SDfUV8v6Dw99 FIXR46ToIA2y6lqSn3vr1d+jvoXcTc1p0y04zP3YARl/PlEZhpyyZFqiToKCUkKRFP8Q 7fDac1cAQWOTS1nJ9fwAkvd8Gg49WHe+UVvrlL4tM+OaaiwPaw1/I1aKiu5sLgX662a4 rp9A6nY8qCl5rIU/6Ot9Q6O1Pqlj7el20VDPxblMNapCzP+hdYCOdIMn6cz7GkqrL6SQ oNQC0d2q2GHX6SMGop3fk/Z3NFAB4PU7syKAHtUdKuQPWtoJ3uw9hs2L3t/A/tlhHTcn 9pTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247612; x=1709852412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GEbsLnLgcuyzMnZrYqny/7Ykl6Zj5T6JhoXq2O6L540=; b=oiWdzCtbah90+DSI40UqBHOANQzxKjKXCx3qgAhmrWjJx2h8vvfjwtYl/dRpCXQ029 D37kUfsWs/Zpq7fTvIaXTQsgl7IBK19U0GJRqDlGL1ecbqvThbZ7es19T4ONPsYeU5re U5GZFOHv7xfUxYNlkflc4RLcO+5DV7jT2JwmYPeKpnAgx76C/iNlGS51K27SNxbxziYw 45ENVw8mOMhCb2nFqaOAuIv/bHtDz6b02265df6hwuTLfHWCnCa20gvoOrYACt9RcVvY TikMPFU8iHvt/0ab+vr0HRZuf7b20I5x1qx5MIY2l+7ubEiZXxVEHxvvj6ha1a0hThO1 mg0g== X-Gm-Message-State: AOJu0YxdCBnO/cM4AGAMY0BicC6W7SetqNWb14wrI9GgTFdEJjbChjmv r3YXi7LDzYRGzFm3opdBzdomu1f3FmfZAbgrrLuh/0dx22SZKcwGU76PO7Fo4BkKS129Rv+6XHf v X-Google-Smtp-Source: AGHT+IG0N8LMDGdl+bB1S1sEEWJGO2wNT8t8g8FERt42X8DTG/7gp3UF9khanwqVskd6wLCJyEZLvQ== X-Received: by 2002:a17:90a:a606:b0:29a:a3a6:dde7 with SMTP id c6-20020a17090aa60600b0029aa3a6dde7mr29943pjq.18.1709247611321; Thu, 29 Feb 2024 15:00:11 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu Subject: [PATCH 16/71] net/ngbe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:03 -0800 Message-ID: <20240229225936.483472-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ngbe/ngbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_pf.c b/drivers/net/ngbe/ngbe_pf.c index 947ae7fe942a..48f578b06626 100644 --- a/drivers/net/ngbe/ngbe_pf.c +++ b/drivers/net/ngbe/ngbe_pf.c @@ -347,7 +347,7 @@ ngbe_vf_reset(struct rte_eth_dev *eth_dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = NGBE_VF_RESET | NGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -369,7 +369,7 @@ ngbe_vf_set_mac_addr(struct rte_eth_dev *eth_dev, struct rte_ether_addr *ea = (struct rte_ether_addr *)new_mac; if (rte_is_valid_assigned_ether_addr(ea)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.set_rar(hw, rar_entry, new_mac, vf, true); } return -1; From patchwork Thu Feb 29 22:58:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137590 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A417943BAE; Fri, 1 Mar 2024 00:02:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 063E443312; Fri, 1 Mar 2024 00:00:54 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 1111343252 for ; Fri, 1 Mar 2024 00:00:13 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so1054225a12.0 for ; Thu, 29 Feb 2024 15:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247612; x=1709852412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZaMQur2ANK3nI5KoKBp9hmJFLLNTC5nTlo/tTsJ8sZk=; b=HX8Ot6SL4tB+H2gFpJuiQhaifUbfQO0fgvjzDvysrds2irRwlqPiqjSN2TxW/V0v15 //Wz9TfpCuVeOoAZ67OsCa9HiZm40ofMJq1ID5awy1anxZqTYFfVtAIqSvdrbbJqFDMM r9jV1HXnbguUQKKmd3EENhfiqQCc2UgrRdmT8EBZt0t1hLxxVOfLrSqt27kGodBIZaDf jPMPMugqvUedNU6X6ysQXNkT3C1K+oUjCOSLc5m9sb8GAUfb/A1q6HaFPmbs5KQjlFMp WsPpOQ0qL4A3+ji6IiNHzSqwkaAROTiSUawQJhiGaN0x5y5WsFJaScxOGbmkxeL2/yYw GAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247612; x=1709852412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZaMQur2ANK3nI5KoKBp9hmJFLLNTC5nTlo/tTsJ8sZk=; b=ItfTo9qtU7W2x9acXvoDpkDS3skYTlVM6qK0TWKiI2aslY75vi7VlgNqHXN8nCl7nr EBtGBPtn7FceRGpF13Xsv4LEy87pcPxbsjmhz4y9YagJFuVRIfh1ClGtUzV59ta2R/I+ OE0L7smkWutfb8YspLdFePbPo8zcL93SSWk3Ozlidjpuu4QtZxrUTxbO3DA4by++Pupl qVcR8GtauOO+kQa0ScSkGTd9gIKTkteHAtP/ySflSGMst8OLK2IxNvPtZurCHHaaXkYx IU6uXnR3ry3zF9FAGCqS2WfrWqhfPVS8jSLGU0+hMJXoQx2xchaEso8nyN9lsWToP6Cc NLyw== X-Gm-Message-State: AOJu0YyDkpagGpWrOEkqLaMf2mbgSAvcdG5kOxm+mMWsT6t5/s92bP7T XNT3xSwkdYPUfZJofjgtXOPlA1a2Z4P522RbIY88qBg74DSoExyEnCzM9SeWWM1QOhzaWG5s7xY S X-Google-Smtp-Source: AGHT+IEyBm2eYkZy1pwW+sbv+YQArJayPAOxIBK02elXjJN42UN2ZUVIpIwy3Hbx3G1/aWpXF70TFA== X-Received: by 2002:a17:90a:a516:b0:299:2927:4d2c with SMTP id a22-20020a17090aa51600b0029929274d2cmr17549pjq.48.1709247612383; Thu, 29 Feb 2024 15:00:12 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tetsuya Mukawa Subject: [PATCH 17/71] net/null: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:04 -0800 Message-ID: <20240229225936.483472-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 7c46004f1e33..fd8b01b2b17b 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -465,7 +465,7 @@ eth_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf) rss_conf->rss_hf & internal->flow_type_rss_offloads; if (rss_conf->rss_key) - rte_memcpy(internal->rss_key, rss_conf->rss_key, 40); + memcpy(internal->rss_key, rss_conf->rss_key, 40); rte_spinlock_unlock(&internal->rss_lock); @@ -482,7 +482,7 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev, rss_conf->rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf; if (rss_conf->rss_key) - rte_memcpy(rss_conf->rss_key, internal->rss_key, 40); + memcpy(rss_conf->rss_key, internal->rss_key, 40); rte_spinlock_unlock(&internal->rss_lock); @@ -577,7 +577,7 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args) internals->flow_type_rss_offloads = RTE_ETH_RSS_PROTO_MASK; internals->reta_size = RTE_DIM(internals->reta_conf) * RTE_ETH_RETA_GROUP_SIZE; - rte_memcpy(internals->rss_key, default_rss_key, 40); + memcpy(internals->rss_key, default_rss_key, 40); data = eth_dev->data; data->nb_rx_queues = (uint16_t)nb_rx_queues; From patchwork Thu Feb 29 22:58:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137592 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F06843BAE; Fri, 1 Mar 2024 00:02:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A638443322; Fri, 1 Mar 2024 00:00:57 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 365CC402A2 for ; Fri, 1 Mar 2024 00:00:14 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso1295558a12.0 for ; Thu, 29 Feb 2024 15:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247614; x=1709852414; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BWtdyG5rsTZMIzCe2l7ha4SnqMibQAxbFiLTEf2hi40=; b=YKUhT4NVY8L3kS2LLCuStUvoNw/YuvAyd5RpntO/b83SnC9Xv2ORmruFVJPePLAuka T0H/0XPlW2Xf2611ObI78h65OgsAfSLyMRDpV768YgcWjJ+YpYeTCLiQFtw2hb0x7a9B 9eaEmrx8dyW2jST7Kvxiue7m5luCsqsz/9nWkpi+QMr0JNaS9e9ayO3/fWyEKlEfTOCa GDYgzKn02BMGn/kSIgI68A0Ju4qhydonGO8k8CxWxzgXtbuPvTI+PBiD5aED+wCiZucZ QAIEy7GlaD61HWPZ8495Y9XTRr4WK2fpNtXGwNOroVdP/WIBMvUCBYlu65sj293lRo0y ItOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247614; x=1709852414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BWtdyG5rsTZMIzCe2l7ha4SnqMibQAxbFiLTEf2hi40=; b=a4lU5Qf8nuGa8yUzAvMwmJjog7yB8fJ/jevC88Qw1gEHuQ5/1xqbYhN2lMZc+bf6hM Zo4erxYlR5A1nSnDbiA11dyGSVcyERPtzJr9M5cdvLhU9/BW76SeQhPKYpp2R+u/gxlA UG1oI5IkuWZMTX7tQ0ASv3suA8jK2xChpipXTOQbtRUTqKEFf7WZ+eELZ5i3tTBceFJB +oGoL7kmSmJXWu8pNTOodlZncKGIM2V4KPMwA+6H4W4sl+qF88Rvu+L+z3nv5iuUpkLa Jpg0ip0IESkTx7jlFboi68iTFjgbFvTzNSa+ADyqcWaJoD5Eh/Y8XIrWNoOK/Q1QXTB5 KAlg== X-Gm-Message-State: AOJu0Yx6KKNRr3Bkr+MZwIGYh4zxdRG2M4OyLwqwVWTRkjsFM8Jo2LV+ /L5TDuh7GDAq9cxvypWahu1DJG6eTqEY1OVQoL2ZlOwR9Yi/uxE7mMp0xEhJmvDLu/dUo2i4WQd y X-Google-Smtp-Source: AGHT+IGIg/YPYgiRbysyPszaaZWRZqh+NzyQL3d5s257SduZ6vqZ0ZGfs7kJCJhWa4M/4APquHDT+w== X-Received: by 2002:a05:6a21:2d08:b0:19e:9a59:20df with SMTP id tw8-20020a056a212d0800b0019e9a5920dfmr4312876pzb.9.1709247613667; Thu, 29 Feb 2024 15:00:13 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 18/71] net/pcap: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:05 -0800 Message-ID: <20240229225936.483472-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c | 2 +- drivers/net/pcap/pcap_osdep_freebsd.c | 2 +- drivers/net/pcap/pcap_osdep_linux.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index bfec0850456f..54f0dfffbdd0 100644 --- a/drivers/net/pcap/pcap_ethdev.c +++ b/drivers/net/pcap/pcap_ethdev.c @@ -1270,7 +1270,7 @@ eth_pcap_update_mac(const char *if_name, struct rte_eth_dev *eth_dev, return -1; PMD_LOG(INFO, "Setting phy MAC for %s", if_name); - rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); eth_dev->data->mac_addrs = mac_addrs; return 0; } diff --git a/drivers/net/pcap/pcap_osdep_freebsd.c b/drivers/net/pcap/pcap_osdep_freebsd.c index 20556b3e9215..d395a5957d56 100644 --- a/drivers/net/pcap/pcap_osdep_freebsd.c +++ b/drivers/net/pcap/pcap_osdep_freebsd.c @@ -52,7 +52,7 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac) ifm = (struct if_msghdr *)buf; sdl = (struct sockaddr_dl *)(ifm + 1); - rte_memcpy(mac->addr_bytes, LLADDR(sdl), RTE_ETHER_ADDR_LEN); + memcpy(mac->addr_bytes, LLADDR(sdl), RTE_ETHER_ADDR_LEN); rte_free(buf); return 0; diff --git a/drivers/net/pcap/pcap_osdep_linux.c b/drivers/net/pcap/pcap_osdep_linux.c index 97033f57c5d9..fc79ad6cdf9e 100644 --- a/drivers/net/pcap/pcap_osdep_linux.c +++ b/drivers/net/pcap/pcap_osdep_linux.c @@ -35,7 +35,7 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac) return -1; } - rte_memcpy(mac->addr_bytes, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); + memcpy(mac->addr_bytes, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); close(if_fd); return 0; From patchwork Thu Feb 29 22:58:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137593 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDDDF43BAE; Fri, 1 Mar 2024 00:02:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7189443332; Fri, 1 Mar 2024 00:00:59 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id D96174329E for ; Fri, 1 Mar 2024 00:00:16 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-299566373d4so1085225a91.1 for ; Thu, 29 Feb 2024 15:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247615; x=1709852415; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OoUWowKhrMEflDaoUwwzGnre0FIbuyfQ26+Nm2E73oY=; b=GE3THGSsTBiwBqiIf+9KCgU32pLzbryeyghakHnU3TmnMduC0ASp+6SU7PhASP74Mv NMsvYVH0ebCzOJwT6mDqIWtZBumZAaWSYxLVYHQqjB94VcI1NUtEX4lRAxBF8rA1i443 gnNLYvvr8FpyGZxSP6bZTNbqsGMcCfAKP+aFJuFewqDhRrwgOj5IVWvaKR8oPI0txroX y0Q/OEVmzfT5KL+vejF7tAPYkAXYmK+rYZ8LAj8KyXHpIIb9wZLTVW967giuyvcQojG0 D0eHfKoMwBHPEiXFxlJDVQfqu+Z6YgWhRzDUoo50TdhNQf6MWmmvD4T4xJIpe8Q+ymIY XCyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247615; x=1709852415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OoUWowKhrMEflDaoUwwzGnre0FIbuyfQ26+Nm2E73oY=; b=DbwHmfxO/Oa/ue3lPpI1KN1Fk4+5BNYf0xIzGLEgAUGDiD03gyixGve3F8Z+1Io90I 60fLKqa3bE5mnfhWKsBon1iXvjLtkOM5Tdn/JXoZAuF4d874VJei9czkGa/SZkJsD/TJ 2aH302wC0jadbUi4dE7ZvPDLd+TAp6Is1TxDwIwtEB5jvzffVNuFR+eE1LqJctgwa4qi i9xYUHIFAEDxaXdnt5S6kl+jcdwg4IjGVFLD9SPLaOz7teZUQKDxMJePaL8JAxpiKuoG h1JK3zPiBXZFKTvNwIUbHaWnbTMefxXO/tMf4agJGxg4GumXDApxnl2OgBZe1pDjDNVZ t53Q== X-Gm-Message-State: AOJu0YxKpGHpWYpTkpTXKww2MD2Zu9IAAjfAmZc6/hbDEyZTqn+JB/zE p4/ZpWdp6hpdCRD0GBzqeR429GmnPfjgypqkBuA9QZ3m72uTQGT0xQ6CG20Z/HPDeTu0TwtEAfp / X-Google-Smtp-Source: AGHT+IHL616GhU3fOSyuO+5jTCnqVPiXp6vhmxQKBbPIacKadblgnS7bVex+c2yLpYrL0iICHNwdMw== X-Received: by 2002:a17:90a:3d45:b0:29b:125c:a97a with SMTP id o5-20020a17090a3d4500b0029b125ca97amr14195pjf.43.1709247614825; Thu, 29 Feb 2024 15:00:14 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH 19/71] net/sfc: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:06 -0800 Message-ID: <20240229225936.483472-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc.c | 2 +- drivers/net/sfc/sfc_ef10_tx.c | 2 +- drivers/net/sfc/sfc_ethdev.c | 11 +++++------ drivers/net/sfc/sfc_flow.c | 20 ++++++++++---------- drivers/net/sfc/sfc_flow_rss.c | 2 +- drivers/net/sfc/sfc_mae.c | 2 +- drivers/net/sfc/sfc_rx.c | 2 +- drivers/net/sfc/sfc_tso.c | 2 +- drivers/net/sfc/sfc_tso.h | 9 ++++----- 9 files changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 2cfff20f4783..2fd160e99ed2 100644 --- a/drivers/net/sfc/sfc.c +++ b/drivers/net/sfc/sfc.c @@ -850,7 +850,7 @@ sfc_rss_attach(struct sfc_adapter *sa) efx_ev_fini(sa->nic); efx_intr_fini(sa->nic); - rte_memcpy(rss->key, default_rss_key, sizeof(rss->key)); + memcpy(rss->key, default_rss_key, sizeof(rss->key)); memset(&rss->dummy_ctx, 0, sizeof(rss->dummy_ctx)); rss->dummy_ctx.conf.qid_span = 1; rss->dummy_ctx.dummy = true; diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c index 116229382b68..0b78a9eaccd1 100644 --- a/drivers/net/sfc/sfc_ef10_tx.c +++ b/drivers/net/sfc/sfc_ef10_tx.c @@ -514,7 +514,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, struct rte_mbuf *m_seg, first_m_seg->outer_l2_len); th = (const struct rte_tcp_hdr *)(hdr_addr + tcph_off); - rte_memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); + memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); sent_seq = rte_be_to_cpu_32(sent_seq); sfc_ef10_tx_qdesc_tso2_create(txq, *added, packet_id, outer_packet_id, diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 92ca5e7a60de..a6f0743f102c 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1287,8 +1287,7 @@ sfc_set_mc_addr_list(struct rte_eth_dev *dev, } for (i = 0; i < nb_mc_addr; ++i) { - rte_memcpy(mc_addrs, mc_addr_set[i].addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(mc_addrs, mc_addr_set[i].addr_bytes, EFX_MAC_ADDR_LEN); mc_addrs += EFX_MAC_ADDR_LEN; } @@ -1672,7 +1671,7 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, rss_conf->rss_hf = sfc_rx_hf_efx_to_rte(rss, rss->hash_types); rss_conf->rss_key_len = EFX_RSS_KEY_SIZE; if (rss_conf->rss_key != NULL) - rte_memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE); + memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE); return 0; } @@ -1741,7 +1740,7 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev, } } - rte_memcpy(rss->key, rss_conf->rss_key, sizeof(rss->key)); + memcpy(rss->key, rss_conf->rss_key, sizeof(rss->key)); } rss->hash_types = efx_hash_types; @@ -1840,7 +1839,7 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev, sfc_adapter_lock(sa); - rte_memcpy(rss_tbl_new, rss->tbl, sizeof(rss->tbl)); + memcpy(rss_tbl_new, rss->tbl, sizeof(rss->tbl)); for (entry = 0; entry < reta_size; entry++) { int grp_idx = entry % RTE_ETH_RETA_GROUP_SIZE; @@ -1864,7 +1863,7 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev, goto fail_scale_tbl_set; } - rte_memcpy(rss->tbl, rss_tbl_new, sizeof(rss->tbl)); + memcpy(rss->tbl, rss_tbl_new, sizeof(rss->tbl)); fail_scale_tbl_set: bad_reta_entry: diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c index 1b50aefe5c48..2bb98a443335 100644 --- a/drivers/net/sfc/sfc_flow.c +++ b/drivers/net/sfc/sfc_flow.c @@ -325,8 +325,8 @@ sfc_flow_parse_eth(const struct rte_flow_item *item, efx_spec->efs_match_flags |= is_ifrm ? EFX_FILTER_MATCH_IFRM_LOC_MAC : EFX_FILTER_MATCH_LOC_MAC; - rte_memcpy(loc_mac, spec->hdr.dst_addr.addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(loc_mac, spec->hdr.dst_addr.addr_bytes, + EFX_MAC_ADDR_LEN); } else if (memcmp(mask->hdr.dst_addr.addr_bytes, ig_mask, EFX_MAC_ADDR_LEN) == 0) { if (rte_is_unicast_ether_addr(&spec->hdr.dst_addr)) @@ -348,8 +348,8 @@ sfc_flow_parse_eth(const struct rte_flow_item *item, */ if (rte_is_same_ether_addr(&mask->hdr.src_addr, &supp_mask.hdr.src_addr)) { efx_spec->efs_match_flags |= EFX_FILTER_MATCH_REM_MAC; - rte_memcpy(efx_spec->efs_rem_mac, spec->hdr.src_addr.addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(efx_spec->efs_rem_mac, spec->hdr.src_addr.addr_bytes, + EFX_MAC_ADDR_LEN); } else if (!rte_is_zero_ether_addr(&mask->hdr.src_addr)) { goto fail_bad_mask; } @@ -624,8 +624,8 @@ sfc_flow_parse_ipv6(const struct rte_flow_item *item, RTE_BUILD_BUG_ON(sizeof(efx_spec->efs_rem_host) != sizeof(spec->hdr.src_addr)); - rte_memcpy(&efx_spec->efs_rem_host, spec->hdr.src_addr, - sizeof(efx_spec->efs_rem_host)); + memcpy(&efx_spec->efs_rem_host, spec->hdr.src_addr, + sizeof(efx_spec->efs_rem_host)); } else if (!sfc_flow_is_zero(mask->hdr.src_addr, sizeof(mask->hdr.src_addr))) { goto fail_bad_mask; @@ -637,8 +637,8 @@ sfc_flow_parse_ipv6(const struct rte_flow_item *item, RTE_BUILD_BUG_ON(sizeof(efx_spec->efs_loc_host) != sizeof(spec->hdr.dst_addr)); - rte_memcpy(&efx_spec->efs_loc_host, spec->hdr.dst_addr, - sizeof(efx_spec->efs_loc_host)); + memcpy(&efx_spec->efs_loc_host, spec->hdr.dst_addr, + sizeof(efx_spec->efs_loc_host)); } else if (!sfc_flow_is_zero(mask->hdr.dst_addr, sizeof(mask->hdr.dst_addr))) { goto fail_bad_mask; @@ -889,8 +889,8 @@ sfc_flow_set_efx_spec_vni_or_vsid(efx_filter_spec_t *efx_spec, if (memcmp(vni_or_vsid_mask, vni_or_vsid_full_mask, EFX_VNI_OR_VSID_LEN) == 0) { efx_spec->efs_match_flags |= EFX_FILTER_MATCH_VNI_OR_VSID; - rte_memcpy(efx_spec->efs_vni_or_vsid, vni_or_vsid_val, - EFX_VNI_OR_VSID_LEN); + memcpy(efx_spec->efs_vni_or_vsid, vni_or_vsid_val, + EFX_VNI_OR_VSID_LEN); } else if (!sfc_flow_is_zero(vni_or_vsid_mask, EFX_VNI_OR_VSID_LEN)) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, diff --git a/drivers/net/sfc/sfc_flow_rss.c b/drivers/net/sfc/sfc_flow_rss.c index e28c943335f3..a46ce1fa87e1 100644 --- a/drivers/net/sfc/sfc_flow_rss.c +++ b/drivers/net/sfc/sfc_flow_rss.c @@ -119,7 +119,7 @@ sfc_flow_rss_parse_conf(struct sfc_adapter *sa, key = ethdev_rss->key; } - rte_memcpy(out->key, key, sizeof(out->key)); + memcpy(out->key, key, sizeof(out->key)); switch (in->func) { case RTE_ETH_HASH_FUNCTION_DEFAULT: diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 60ff6d21810a..1f243e798e00 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -547,7 +547,7 @@ sfc_mae_mac_addr_add(struct sfc_adapter *sa, if (mac_addr == NULL) return ENOMEM; - rte_memcpy(mac_addr->addr_bytes, addr_bytes, EFX_MAC_ADDR_LEN); + memcpy(mac_addr->addr_bytes, addr_bytes, EFX_MAC_ADDR_LEN); mac_addr->refcnt = 1; mac_addr->fw_rsrc.mac_id.id = EFX_MAE_RSRC_ID_INVALID; diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index a19322926572..55aae9ef04f3 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -1526,7 +1526,7 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa, sizeof(rss->key)); return EINVAL; } - rte_memcpy(rss->key, conf->rss_key, sizeof(rss->key)); + memcpy(rss->key, conf->rss_key, sizeof(rss->key)); } rss->hash_types = efx_hash_types; diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c index a0827d1c0dd6..5da2de3c3d49 100644 --- a/drivers/net/sfc/sfc_tso.c +++ b/drivers/net/sfc/sfc_tso.c @@ -159,7 +159,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx, /* Handle TCP header */ th = (const struct rte_tcp_hdr *)(tsoh + tcph_off); - rte_memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); + memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); sent_seq = rte_be_to_cpu_32(sent_seq); efx_tx_qdesc_tso2_create(txq->common, packet_id, 0, sent_seq, diff --git a/drivers/net/sfc/sfc_tso.h b/drivers/net/sfc/sfc_tso.h index 9029ad159014..e914eae77ef8 100644 --- a/drivers/net/sfc/sfc_tso.h +++ b/drivers/net/sfc/sfc_tso.h @@ -35,7 +35,7 @@ sfc_tso_ip4_get_ipid(const uint8_t *pkt_hdrp, size_t ip_hdr_off) uint16_t ipid; ip_hdrp = (const struct rte_ipv4_hdr *)(pkt_hdrp + ip_hdr_off); - rte_memcpy(&ipid, &ip_hdrp->packet_id, sizeof(ipid)); + memcpy(&ipid, &ip_hdrp->packet_id, sizeof(ipid)); return rte_be_to_cpu_16(ipid); } @@ -46,9 +46,8 @@ sfc_tso_outer_udp_fix_len(const struct rte_mbuf *m, uint8_t *tsoh) rte_be16_t len = rte_cpu_to_be_16(m->l2_len + m->l3_len + m->l4_len + m->tso_segsz); - rte_memcpy(tsoh + m->outer_l2_len + m->outer_l3_len + - offsetof(struct rte_udp_hdr, dgram_len), - &len, sizeof(len)); + memcpy(tsoh + m->outer_l2_len + m->outer_l3_len + offsetof(struct rte_udp_hdr, dgram_len), + &len, sizeof(len)); } static inline void @@ -67,7 +66,7 @@ sfc_tso_innermost_ip_fix_len(const struct rte_mbuf *m, uint8_t *tsoh, len = rte_cpu_to_be_16(ip_payload_len); } - rte_memcpy(tsoh + iph_ofst + field_ofst, &len, sizeof(len)); + memcpy(tsoh + iph_ofst + field_ofst, &len, sizeof(len)); } unsigned int sfc_tso_prepare_header(uint8_t *tsoh, size_t header_len, From patchwork Thu Feb 29 22:58:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137595 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1FF643BAE; Fri, 1 Mar 2024 00:02:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 116474334C; Fri, 1 Mar 2024 00:01:02 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 9094342FD1 for ; Fri, 1 Mar 2024 00:00:17 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e59bbdd8c7so970721b3a.3 for ; Thu, 29 Feb 2024 15:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247617; x=1709852417; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ADwliB5YG1I5rnLwuOE9AHiZ+t1JRTJrOeqRGTG73M4=; b=JVTGvrsra35WUn8tb4YlNlOTdUNP4oE+55lFxEWtM7Wwq3sgKXPCaOPeweFbagm40G Tc5+ur23COIdndc17daG9/c+L/a9tIPNv2u588LJo7EDU0v1HafC762RS7viw/LLUpxt 12YQxF20g5T6BsQJSwXOOjAEib5+dUh+3rSODviUofLB6DijwAYkx4kLYyBKpbYmR6Jm D99PmicfttribX1a5B48E8aTtX2wnI9+tWHuJ+23sRhjyM9jJj1qyrxR0vFQT70rA0qx vi/iVarXNAPxZ5mbpRyUCkN+hqEz4XOLdotItj03euDg5ZEknoH4uQlvN82eRwtpJVrT Qt0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247617; x=1709852417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADwliB5YG1I5rnLwuOE9AHiZ+t1JRTJrOeqRGTG73M4=; b=Pf0kFwtAKn986Je0JLtNg7HxoRUHH3R77RIPo7XrIsmXDXDepKjifz1lAwtRnnFXbn 8qCafXX9P5MG6J1c9jxNRwBkBOpncpA+EK1RsKDPaymuxjhZbd5rMRJHpSOoMEC/ByGF okexL3vv07BqTAZ9LEmQUPHZAimuEbOHM5N02tn1larsM13SPysh7hkZkljsn9NOzRXk X9BupTDiSi75l5PFBarEl/HRtB1ztkBe7altbF5x1ImQOd0008ezXghdpqXwqV9HMtqT fyHwo1SHQLKaSb6c8IYluYnCy3++78viW6ocLfAOawNjRQdvRX7uH9EWanvLItCdnmNf PAEA== X-Gm-Message-State: AOJu0YwYP2nkdArQ90CKvx7V35KkXSxFTLIhJgvMKD3ZoEGCRCs7PgtQ 26KwTJ/UEzMdlRCo33zgJhTnoontvrpa9QD3/x2lcfvUFV0NpXMFWnZAXa4S+TpZXR3njhehzj2 X X-Google-Smtp-Source: AGHT+IHie2txYkPqc7N9J+Jt97nj/iJJU8/Rzb1vnd2KcqmK4QrlmvOEB0OMK5OtiHiiqRYegy4B+w== X-Received: by 2002:a05:6a20:93a0:b0:1a0:e463:fcad with SMTP id x32-20020a056a2093a000b001a0e463fcadmr5737032pzh.2.1709247615611; Thu, 29 Feb 2024 15:00:15 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 20/71] net/tap: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:07 -0800 Message-ID: <20240229225936.483472-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 69d9da695bed..518619c53b4a 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1404,11 +1404,11 @@ tap_mac_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) mac_addr)) mode = LOCAL_AND_REMOTE; ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(ifr.ifr_hwaddr.sa_data, mac_addr, RTE_ETHER_ADDR_LEN); ret = tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 1, mode); if (ret < 0) return ret; - rte_memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); if (pmd->remote_if_index && !pmd->flow_isolate) { /* Replace MAC redirection rule after a MAC change */ ret = tap_flow_implicit_destroy(pmd, TAP_REMOTE_LOCAL_MAC); @@ -2010,7 +2010,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (rte_is_zero_ether_addr(mac_addr)) rte_eth_random_addr((uint8_t *)&pmd->eth_addr); else - rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); + memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); } /* @@ -2033,8 +2033,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (pmd->type == ETH_TUNTAP_TYPE_TAP) { memset(&ifr, 0, sizeof(struct ifreq)); ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, &pmd->eth_addr, - RTE_ETHER_ADDR_LEN); + memcpy(ifr.ifr_hwaddr.sa_data, &pmd->eth_addr, + RTE_ETHER_ADDR_LEN); if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) goto error_exit; } @@ -2091,8 +2091,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, pmd->name, pmd->remote_iface); goto error_remote; } - rte_memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data, - RTE_ETHER_ADDR_LEN); + memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data, + RTE_ETHER_ADDR_LEN); /* The desired MAC is already in ifreq after SIOCGIFHWADDR. */ if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) { TAP_LOG(ERR, "%s: failed to get %s MAC address.", From patchwork Thu Feb 29 22:58:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137594 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44F8D43BAE; Fri, 1 Mar 2024 00:02:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D45DC4333C; Fri, 1 Mar 2024 00:01:00 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 444D7432A8 for ; Fri, 1 Mar 2024 00:00:17 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so1054298a12.0 for ; Thu, 29 Feb 2024 15:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247616; x=1709852416; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qwocySNCXgh3M3EevzPG9njYICKO5SkeRDh6ctOKxNE=; b=emIc76B8CGD+cqc2oLOfCIc0mzByQaWA/nQLKy7rR7AOc8DgKWzhWi/I4HflAYF7iI 95Qt4L4BHDb0pCHiZGNd7oqOpb2xCaKG5taYsrKxaipNWtrf4q9VN9hB8obNIUf3cL0m aANYpM0ZpnH/ToU0XnD8CQuI5GbBYXnXJDD33Iws7Qx6d5Tb3N9oSLesUB7ncpBsKFTG KQl1WmRQHOVGD3oEDX6e4TVHRFPRW8IvHtXmzXNbXxNp9u8vV2t84/f5pFGK+ythixpY A0rCbUXHOMY52H+Ru8EewXtd/sCQGZvzHvVxYtbBuRuVp6Iv8opbWxZHTVFz4P/CSR/5 Buzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247616; x=1709852416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwocySNCXgh3M3EevzPG9njYICKO5SkeRDh6ctOKxNE=; b=dItK7ndLn35RXlO0nyLE2NzNa20CYbCzHoWMWOVO9DDHHSSOEnW2tGF0bDhwcE+YCw /Bo37qWKNmgwM2gFMJYa8et+UgWCdFa6sJPuOooL3DL5MWBQrwJto6FOZqGtiPCd7uUt RKPoTCzY4wQL1qgmVrce7c41l9PsXJJ1vaCAm9Fq+RUyd1EKmU2wegOgnXGTkz5JDKfL y5VC0dLOPT+/gjztY3KO3/z85K7QCW1iHrJLR3yXc9f8+V5rMpNQj9FuUgs8WGj+d9Ue nXoVuEmi39RJkDJ1Kuqct5A7m1Xkn4/sal334o/0/339W9UOhspaxqNaChe5NRNtZwY6 Ot5Q== X-Gm-Message-State: AOJu0Yx6MLVI39QGp6/uuhqXGHAolRnbd88DezqXcLO4gzwFfKRZsYe0 +8g7agtqOqFq6WyV80YmQu3chMcQBWBY18HUw2IaldZy0PWLoxzigmeQLBillbUfRybCdAXF/dy K X-Google-Smtp-Source: AGHT+IGTFmvzm4oiT+EvKf1Qznl3262KwAQivbZl9J5Ut4I32c7YAb+QKuSqCte2LxlASIjjUJY3aw== X-Received: by 2002:a17:90a:d983:b0:29a:b31e:2801 with SMTP id d3-20020a17090ad98300b0029ab31e2801mr36597pjv.1.1709247616459; Thu, 29 Feb 2024 15:00:16 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH 21/71] net/txgbe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:08 -0800 Message-ID: <20240229225936.483472-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 9 ++--- drivers/net/txgbe/txgbe_fdir.c | 6 +-- drivers/net/txgbe/txgbe_flow.c | 65 ++++++++++++++------------------ drivers/net/txgbe/txgbe_ipsec.c | 8 ++-- drivers/net/txgbe/txgbe_pf.c | 4 +- drivers/net/txgbe/txgbe_tm.c | 11 +++--- 6 files changed, 46 insertions(+), 57 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index b75e8898e2d4..1c42fd74b47d 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -4304,9 +4304,8 @@ txgbe_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct txgbe_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, - &filter_5tuple, - sizeof(struct txgbe_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct txgbe_5tuple_filter_info)); filter->queue = ntuple_filter->queue; ret = txgbe_add_5tuple_filter(dev, filter); if (ret < 0) { @@ -5109,9 +5108,7 @@ txgbe_dev_l2_tunnel_filter_add(struct rte_eth_dev *dev, if (!node) return -ENOMEM; - rte_memcpy(&node->key, - &key, - sizeof(struct txgbe_l2_tn_key)); + memcpy(&node->key, &key, sizeof(struct txgbe_l2_tn_key)); node->pool = l2_tunnel->pool; ret = txgbe_insert_l2_tn_filter(l2_tn_info, node); if (ret < 0) { diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c index a198b6781bad..00366ed87323 100644 --- a/drivers/net/txgbe/txgbe_fdir.c +++ b/drivers/net/txgbe/txgbe_fdir.c @@ -42,7 +42,7 @@ else \ ipv6_addr[i] = 0; \ } \ - rte_memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ + memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ } while (0) /** @@ -858,8 +858,8 @@ txgbe_fdir_filter_program(struct rte_eth_dev *dev, sizeof(struct txgbe_fdir_filter), 0); if (!node) return -ENOMEM; - rte_memcpy(&node->input, &rule->input, - sizeof(struct txgbe_atr_input)); + memcpy(&node->input, &rule->input, + sizeof(struct txgbe_atr_input)); node->fdirflags = rule->fdirflags; node->fdirhash = fdirhash; node->queue = queue; diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7ef52d0b0fcd..c76fc0eed0e0 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -1834,10 +1834,10 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused, if (item->spec) { rule->b_spec = TRUE; ipv6_spec = item->spec; - rte_memcpy(rule->input.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(rule->input.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->input.src_ip, ipv6_spec->hdr.src_addr, + 16); + memcpy(rule->input.dst_ip, ipv6_spec->hdr.dst_addr, + 16); } /** @@ -2756,9 +2756,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -2782,9 +2782,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -2806,9 +2806,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&filter_syn_list, syn_filter_ptr, entries); @@ -2827,9 +2826,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct txgbe_hw_fdir_mask)); + memcpy(&fdir_info->mask, &fdir_rule.mask, + sizeof(struct txgbe_hw_fdir_mask)); fdir_info->flex_bytes_offset = fdir_rule.flex_bytes_offset; @@ -2873,9 +2871,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, "failed to allocate memory"); goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, - &fdir_rule, - sizeof(struct txgbe_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, + &fdir_rule, + sizeof(struct txgbe_fdir_rule)); TAILQ_INSERT_TAIL(&filter_fdir_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -2910,9 +2908,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&l2_tn_filter_ptr->filter_info, - &l2_tn_filter, - sizeof(struct txgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter_ptr->filter_info, &l2_tn_filter, + sizeof(struct txgbe_l2_tunnel_conf)); TAILQ_INSERT_TAIL(&filter_l2_tunnel_list, l2_tn_filter_ptr, entries); flow->rule = l2_tn_filter_ptr; @@ -3038,9 +3035,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct txgbe_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, - &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = txgbe_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_ntuple_list, @@ -3051,9 +3047,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct txgbe_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = txgbe_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3065,9 +3060,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_SYN: syn_filter_ptr = (struct txgbe_eth_syn_filter_ele *) pmd_flow->rule; - rte_memcpy(&syn_filter, - &syn_filter_ptr->filter_info, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter, &syn_filter_ptr->filter_info, + sizeof(struct rte_eth_syn_filter)); ret = txgbe_syn_filter_set(dev, &syn_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_syn_list, @@ -3077,9 +3071,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct txgbe_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct txgbe_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct txgbe_fdir_rule)); ret = txgbe_fdir_filter_program(dev, &fdir_rule, TRUE, FALSE); if (!ret) { TAILQ_REMOVE(&filter_fdir_list, @@ -3092,8 +3085,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_L2_TUNNEL: l2_tn_filter_ptr = (struct txgbe_eth_l2_tunnel_conf_ele *) pmd_flow->rule; - rte_memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, - sizeof(struct txgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, + sizeof(struct txgbe_l2_tunnel_conf)); ret = txgbe_dev_l2_tunnel_filter_del(dev, &l2_tn_filter); if (!ret) { TAILQ_REMOVE(&filter_l2_tunnel_list, diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..000dd5ec6d39 100644 --- a/drivers/net/txgbe/txgbe_ipsec.c +++ b/drivers/net/txgbe/txgbe_ipsec.c @@ -658,10 +658,10 @@ txgbe_crypto_add_ingress_sa_from_flow(const void *sess, const struct rte_flow_item_ipv6 *ipv6 = ip_spec; ic_session->src_ip.type = IPv6; ic_session->dst_ip.type = IPv6; - rte_memcpy(ic_session->src_ip.ipv6, - ipv6->hdr.src_addr, 16); - rte_memcpy(ic_session->dst_ip.ipv6, - ipv6->hdr.dst_addr, 16); + memcpy(ic_session->src_ip.ipv6, ipv6->hdr.src_addr, + 16); + memcpy(ic_session->dst_ip.ipv6, ipv6->hdr.dst_addr, + 16); } else { const struct rte_flow_item_ipv4 *ipv4 = ip_spec; ic_session->src_ip.type = IPv4; diff --git a/drivers/net/txgbe/txgbe_pf.c b/drivers/net/txgbe/txgbe_pf.c index 176f79005cde..a0f5a67d9c78 100644 --- a/drivers/net/txgbe/txgbe_pf.c +++ b/drivers/net/txgbe/txgbe_pf.c @@ -435,7 +435,7 @@ txgbe_vf_reset(struct rte_eth_dev *eth_dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = TXGBE_VF_RESET | TXGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -457,7 +457,7 @@ txgbe_vf_set_mac_addr(struct rte_eth_dev *eth_dev, struct rte_ether_addr *ea = (struct rte_ether_addr *)new_mac; if (rte_is_valid_assigned_ether_addr(ea)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.set_rar(hw, rar_entry, new_mac, vf, true); } return -1; diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 3171be73d05d..7d77b01dfef2 100644 --- a/drivers/net/txgbe/txgbe_tm.c +++ b/drivers/net/txgbe/txgbe_tm.c @@ -280,8 +280,8 @@ txgbe_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&tm_conf->shaper_profile_list, shaper_profile, node); @@ -625,8 +625,8 @@ txgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->no = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); tm_conf->root = tm_node; /* increase the reference counter of the shaper profile */ @@ -706,8 +706,7 @@ txgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == TXGBE_TM_NODE_TYPE_PORT) { tm_node->no = parent_node->reference_count; TAILQ_INSERT_TAIL(&tm_conf->tc_list, From patchwork Thu Feb 29 22:58:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137596 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A49E643BB1; Fri, 1 Mar 2024 00:02:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 591BA43344; Fri, 1 Mar 2024 00:01:03 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 22EF942FFB for ; Fri, 1 Mar 2024 00:00:18 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e5a50d91b4so884403b3a.2 for ; Thu, 29 Feb 2024 15:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247617; x=1709852417; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vGk46ToImmd8JoOGy/Hu/uL0vYkj3p8E0mw0PS880YU=; b=15++jMReYKAb2OhaCAs8CB000ciyiaXBPU2lk52b77965fo7ZioPgNL/xwtlJCJHf8 /l+XRa2DcAjg6GJuc7UgII17ybwozCWP9zOimV9xhuN8GvA5NPeV/AuMzSt9HMsisFJa Z9R9gUw5OzHiTO1EVA1WZa5Wn/RiybrenJMHZ6f1Udw2TlPojLIGqF8i+0j72bup7eK+ ruZqRXWHKQJSK79ACtSYxpSDsv7UdqSlg8Ro5/RW8Mf3FrPyOfM4nLHfrXupeHZoMYZb qkarQCq07FwCh/CUbi0mfKHP0uDmjmWafQVmc0xW/GpsaUd4wleFnzIiFmHvs0ZQewgp bsuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247617; x=1709852417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vGk46ToImmd8JoOGy/Hu/uL0vYkj3p8E0mw0PS880YU=; b=NZGthy3i0vkTm0hKTTSf/ZHvt8maI8NsnGgBs4knLOH0idX413ec5SrCTQtd8wEalR h9mwXTldmNWhp1Ljoxdw5l8TvjMQBmFOU+Cy5Tzm1wNd1BiN/kunxMK596HSip9TsWbk VaO9hhjRDvaBSlQSq5YBQdTHIiuVG/Xw94HhuWQ2JEN3Dzkr1tpFr6F8ftVBgO0A53Xe a4bXsBKJRnenmud9xuaCtxyNGk9Tx254654uCSVJGZj9snlctf4vKwFnsybepH/vGbt3 wqsclkFauaNMUnAAQAPVKapt6ryCtVSLoOZoPJIk3KraLhyVHADIiSoA5HNuo32fuk/l p0eA== X-Gm-Message-State: AOJu0Yw1ehGLWGbBmFFLjQzpOVjvlycj6+CZYiZf62LwJq5DbFMxQOck +oDKo3lJPwfqbniQ6Ro4pljEFOwLecXHAOseAPQcXgHfuzHiW9ePvlUTVKDQ6BliUxq3lZFnTvg 1 X-Google-Smtp-Source: AGHT+IFtYifjxoPhHRum73/Gd1dIAgouT37j4eMCTkLsPBKV+bTCy+j4aJxHftCBwSjAMT1YK/Ek7g== X-Received: by 2002:a05:6a20:d806:b0:1a1:1f7b:9b08 with SMTP id iv6-20020a056a20d80600b001a11f7b9b08mr4926598pzb.47.1709247617291; Thu, 29 Feb 2024 15:00:17 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH 22/71] raw/ifpga: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:09 -0800 Message-ID: <20240229225936.483472-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/afu_pmd_he_hssi.c | 2 +- drivers/raw/ifpga/afu_pmd_he_lpbk.c | 2 +- drivers/raw/ifpga/afu_pmd_he_mem.c | 2 +- drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++---- drivers/raw/ifpga/ifpga_rawdev.c | 10 +++++----- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c index 859f28dcc1f0..1ff4b3f9d12a 100644 --- a/drivers/raw/ifpga/afu_pmd_he_hssi.c +++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c @@ -314,7 +314,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config, if (cfg->port >= NUM_HE_HSSI_PORTS) return -EINVAL; - rte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg)); + memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c index c7c5cda48c35..69644281774a 100644 --- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c +++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c @@ -363,7 +363,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config, if ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES)) return -EINVAL; - rte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg)); + memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c index a1db533eeb93..2332a33213c1 100644 --- a/drivers/raw/ifpga/afu_pmd_he_mem.c +++ b/drivers/raw/ifpga/afu_pmd_he_mem.c @@ -126,7 +126,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config, if (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg)) return -EINVAL; - rte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg)); + memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c index 67b394126595..9236c0b15371 100644 --- a/drivers/raw/ifpga/afu_pmd_n3000.c +++ b/drivers/raw/ifpga/afu_pmd_n3000.c @@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config, if ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) || (cfg->nlb_cfg.end > MAX_CACHE_LINES)) return -EINVAL; - rte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg, - sizeof(struct rte_pmd_afu_nlb_cfg)); + memcpy(&priv->nlb_cfg, &cfg->nlb_cfg, + sizeof(struct rte_pmd_afu_nlb_cfg)); } else if (cfg->type == RTE_PMD_AFU_N3000_DMA) { if (cfg->dma_cfg.index >= NUM_N3000_DMA) return -EINVAL; @@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config, cfg->dma_cfg.length); } } - rte_memcpy(&priv->dma_cfg, &cfg->dma_cfg, - sizeof(struct rte_pmd_afu_dma_cfg)); + memcpy(&priv->dma_cfg, &cfg->dma_cfg, + sizeof(struct rte_pmd_afu_dma_cfg)); } else { IFPGA_RAWDEV_PMD_ERR("Invalid type of N3000 AFU"); return -EINVAL; diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index f89bd3f9e2c3..61b82c781b7d 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -258,7 +258,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev) if (point < 12) return -1; point -= 12; - rte_memcpy(ifpga_dev->parent_bdf, &link[point], 12); + memcpy(ifpga_dev->parent_bdf, &link[point], 12); point = strlen(link1); if (point < 26) @@ -948,10 +948,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev, if (ret) return ret; - rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b, - sizeof(u64)); - rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8, - sizeof(u64)); + memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b, + sizeof(u64)); + memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8, + sizeof(u64)); IFPGA_RAWDEV_PMD_INFO("%s: uuid_l=0x%lx, uuid_h=0x%lx\n", __func__, From patchwork Thu Feb 29 22:58:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137597 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 439E443BAE; Fri, 1 Mar 2024 00:03:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04B264334B; Fri, 1 Mar 2024 00:01:04 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 6B5D24325B for ; Fri, 1 Mar 2024 00:00:19 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-299dba8fd24so1099064a91.2 for ; Thu, 29 Feb 2024 15:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247618; x=1709852418; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qlT84LLO8F031Gnwzj2I+iXnNWFtKWuZ85KZacOSKt4=; b=TzhHX2Ewt7WQ8T7DQF8dPRwjSH2cNHQoudBuJAoQ3anozxQKQ/WqRg4hDrlJgbC5t3 Iuo11yUbdECiZ1wH/PV11mgfiJSrI8vfCge8RpBmP/n2SoPAKwNBHHh7xWwSTVyutbUf 1zN6/KzplqR9NAGUsS9KyCDmPEc6tw7htcMKdUndTX5uZsCO2RvraifXyRNFS3eJ6qdU vPRSvbCIEyMS6cwdm4JBth/v8olEqvLzrkh09rruSBzL3cJfZl3uXfFNhRQ2xqLtwXnv UuKFoyn5zKYLXW4u+5HHDaWANbjXiQSLF/gRaRd8PxSKC4TOJ6D6FUgWGmNntbTeXaNh KLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247618; x=1709852418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qlT84LLO8F031Gnwzj2I+iXnNWFtKWuZ85KZacOSKt4=; b=tYZbC8Pwgw1UoGN7GUY6/p749C0o9eEekbqjMugah7xvas0pyQ1x7dNHG33KRohchE KMCsjw46mXyD6mS1Xflt1kp31cTPA/36YDibXBDODH9nm7jcn9g4dKyFUPwRqH+uOw0I b1L3DlIF7wG2Id6B0R3Xi0q4iyp1+wwoQU0J5mVIGfYYg7PWdJr4FoqKZ54cJMoFNqdk I18wXalWZvpbiGN6QjgfLVwdAfrDskL9bZ2jQRAG7AJj9S0d7PrDLmF1Zmt2SsGoGG1Y ksmilXnNWqWLQFWvX5kSa1/2kHO2bxkRgXn8ofbmBnV1ndAmL33GGBWt2kQmv5MGguKW OVQQ== X-Gm-Message-State: AOJu0YyQO8Z77LT+x9T8Np0gvkuQQtDcvzRta4cO1dA/KQ7aBluEEp4U fOb/bbcFHe2vHQCxJspEuM28S+VB6ogp0Lhnhgeuy1KDTDTXqD9CjaTwoC8qYurJ1eEG0UG7Igo w X-Google-Smtp-Source: AGHT+IH2JJuLQKbcXyYrsTr6V6Z+mrC7Q59AkVEYd/75bXdeE2cQne+tfiPxmA5SwtheASurqbI1mw== X-Received: by 2002:a17:90a:688c:b0:29a:bdbe:5859 with SMTP id a12-20020a17090a688c00b0029abdbe5859mr35286pjd.7.1709247618066; Thu, 29 Feb 2024 15:00:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sachin Saxena , Hemant Agrawal Subject: [PATCH 23/71] raw/skeleton: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:10 -0800 Message-ID: <20240229225936.483472-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/skeleton/skeleton_rawdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index 6e99d35536d7..967b3964f24a 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -245,8 +245,8 @@ static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev, skelq = &skeldev->queues[queue_id]; if (queue_id < SKELETON_MAX_QUEUES) - rte_memcpy(queue_conf, skelq, - sizeof(struct skeleton_rawdev_queue)); + memcpy(queue_conf, skelq, + sizeof(struct skeleton_rawdev_queue)); return 0; } @@ -281,8 +281,7 @@ static int skeleton_rawdev_queue_setup(struct rte_rawdev *dev, if (skeldev->num_queues > queue_id && q->depth < SKELETON_QUEUE_MAX_DEPTH) { - rte_memcpy(q, queue_conf, - sizeof(struct skeleton_rawdev_queue)); + memcpy(q, queue_conf, sizeof(struct skeleton_rawdev_queue)); clear_queue_bufs(queue_id); } else { SKELETON_PMD_ERR("Invalid queue configuration"); From patchwork Thu Feb 29 22:58:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137598 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D9D143BAE; Fri, 1 Mar 2024 00:03:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AB3D43355; Fri, 1 Mar 2024 00:01:06 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id B3C1A4328F for ; Fri, 1 Mar 2024 00:00:19 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-299354e5f01so2106351a91.1 for ; Thu, 29 Feb 2024 15:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247619; x=1709852419; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1eW22QZ42KJpLACHXjb2S2ak0hAYtAORjULbMVpXEH4=; b=q5tCZcuJM2+mUFMgyVuWExp+UahYQ1+t2vixpvWBITc89gA5qv3n36q6kmvmKrj9Ll ylqx7M6WCvruD6nDNZB0PgAOQbCGspDvHfeYvtx97KcFTUPzil6xb2i/4OIaCrBVeaJq sGZjHzZGDxRc7SsZQMk8NLvD9vVolW+u4xwoRp4VRyco0oaQuTYvk3l6YnwGXukHxYJM MicNNSa1P18EDsKnyRk2YElis0+IpofFZkiv7xOlAEw/NxwL4uraola8jYxTyJ34wVQf ZtqlbTOX2yi3HxfQbAmkcGk16yPI42q0J8H7+iPBUKPIgXo6/QDhYz4iTNIIMezi29dN Kc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247619; x=1709852419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1eW22QZ42KJpLACHXjb2S2ak0hAYtAORjULbMVpXEH4=; b=ACD32TRhog1Vs2KFH8OSgoMeWiWhs0CmU5wpTZegIx5vVV491esritU7u+p9B2rtLR kL5mU0qiDJxsDDr3Wa1RIf7ffz9Nt23Qh4hblR5hDBtlg4W+7gB69qyvDlvBPGZEnLYM kVmbEa7jp3T7Cg4nrG5idYh7oTxlzrvhJ+SSjJD8IUBJ4YUDoHFj5sWzA+Kk6AxxMwkX cCoUi9aHkf3ZwxhD1t3Nti5QH2lhKTlgjgcE10vqrewh+CrqyZNCg6LhGR/t6E7Q5mtJ UKzWGgc8C+Z0SPgytU6YdQLvWpLp2E8mhh9cl7B8x025+j5NCemgxYJsqX7r3AWGHpDj wk5A== X-Gm-Message-State: AOJu0YymPHia7EiWdtZGQvjwCwPMN4ZV0RAc2tRogQICcxlu4/pSho4X s2QXRFyWhNPSevK7bEB4bVYqyAJW4Z2hvbVVgtzbzdv5PpT0pbBifP42VclXcPLhUtwk3++cacg U X-Google-Smtp-Source: AGHT+IGZXEeuNB7CagYm1jfy2lKtTo3Hp+lFVYhiNcy45iAHvqoGKxns6z4zbVirdY7+n1n0PkYdlA== X-Received: by 2002:a17:90a:f09:b0:29b:171f:4f8e with SMTP id 9-20020a17090a0f0900b0029b171f4f8emr426150pjy.14.1709247618929; Thu, 29 Feb 2024 15:00:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jie Hai , Yisen Zhuang Subject: [PATCH 24/71] net/hns3: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:11 -0800 Message-ID: <20240229225936.483472-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_fdir.c | 2 +- drivers/net/hns3/hns3_flow.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c index d100e58d102b..332cbb847be3 100644 --- a/drivers/net/hns3/hns3_fdir.c +++ b/drivers/net/hns3/hns3_fdir.c @@ -996,7 +996,7 @@ int hns3_fdir_filter_program(struct hns3_adapter *hns, return -ENOMEM; } - rte_memcpy(&node->fdir_conf, rule, sizeof(struct hns3_fdir_rule)); + memcpy(&node->fdir_conf, rule, sizeof(struct hns3_fdir_rule)); ret = hns3_insert_fdir_filter(hw, fdir_info, node); if (ret < 0) { rte_free(node); diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 7fbe65313ca2..96b91bed6b18 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -2416,8 +2416,8 @@ hns3_flow_query(struct rte_eth_dev *dev, struct rte_flow *flow, } rss_conf = (struct rte_flow_action_rss *)data; rss_rule = (struct hns3_rss_conf_ele *)flow->rule; - rte_memcpy(rss_conf, &rss_rule->filter_info.conf, - sizeof(struct rte_flow_action_rss)); + memcpy(rss_conf, &rss_rule->filter_info.conf, + sizeof(struct rte_flow_action_rss)); break; default: return rte_flow_error_set(error, ENOTSUP, From patchwork Thu Feb 29 22:58:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137599 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F68343BAE; Fri, 1 Mar 2024 00:03:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 780924335A; Fri, 1 Mar 2024 00:01:07 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id D616B4325B for ; Fri, 1 Mar 2024 00:00:20 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e58a984ea1so1072855b3a.2 for ; Thu, 29 Feb 2024 15:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247620; x=1709852420; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ddeQV9oDwmOp+myMyEXab268axpaB2tVwC7KUA3dTI=; b=hBrMupudxunBw4VRYNuXNwbwoVHeDP36Rc5me80cxxgT+XCf104oFNAdfuSy7A9SGg AFw34CkDvXrmQo1CcQwNB3ZBbprwCDgykOPsw6di0B6CRtH1EZbaptWSawsr9K1nzuEy Hnns4dOvgUf2xPn6ZjtxN+dpWbx3b45ChCN2ugpQM5LDolPRudeHBrvKZlNvVSkes3Zs nZ/iKZ+90Yh9b5kvxsD4yOFfHVUkp4v5AfVJahuhI8ipkiXleiv8v5boiEgQOdu9Gpbx gnICN+rD8uOib4j0Hkwkf+NjDW9w2n30NmuGg9Xi+iIBT9QRmDPWSUq2w84zOql3kWSi /Z/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247620; x=1709852420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ddeQV9oDwmOp+myMyEXab268axpaB2tVwC7KUA3dTI=; b=am3FAYjA5L9tlDHuRwaszCKwgxPGihdFUKeCO8lY6KhY+8m0v76pJB779OuCqFoO5f FMh+adT0VMiq4yPP+jxnpUTRSQrvlIySFKLq/NkuU0h+r++6Vg/57UUoeGt4GqHP12OY aWtyQJMQmxlOiiaNc6MALqq9jA5NhQ3QoatZH9S+ZORPMHDEzXe/mJ3tKEuiIpLvgaV3 rEFVRawHtGNIw4/JYmtLDNdK+WmElszuP/0BzU6fuAa/52PmfQhRWssukTvniCqZoS8A SDGURYtTN28SHf6eGxecSDnl8MAL7cQvSIYtuWWVg+D46ZT0ZFtIF7Rh81N1GtIjmjRz VXZw== X-Gm-Message-State: AOJu0YwQKURGmGskSmTPFSKePeAHlCWY5iVF7Ze8iS3WwOEyCSC8G6Hl 7qzJ0wCBPHV+cQgxeIwG3R6MClpc5p94jQa2AWfGQo6tjY70oGN5cFixczkEWAA2k/pbISBQbAS J X-Google-Smtp-Source: AGHT+IHsr2B7vzabH8DHF36zYTjOP2yKXdEQZffDmxqw63cqRscO60kw6q5o54IodPh85q0mDwAXgQ== X-Received: by 2002:a05:6a20:9f9a:b0:1a1:2092:8868 with SMTP id mm26-20020a056a209f9a00b001a120928868mr4359325pzb.1.1709247619906; Thu, 29 Feb 2024 15:00:19 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang Subject: [PATCH 25/71] net/i40e: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:12 -0800 Message-ID: <20240229225936.483472-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 108 ++++++++++++++------------------ drivers/net/i40e/i40e_fdir.c | 28 ++++----- drivers/net/i40e/i40e_flow.c | 56 ++++++++--------- drivers/net/i40e/i40e_pf.c | 2 +- drivers/net/i40e/i40e_tm.c | 11 ++-- drivers/net/i40e/rte_pmd_i40e.c | 34 +++++----- 6 files changed, 108 insertions(+), 131 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4d21341382d8..7ed394862ffa 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4310,7 +4310,7 @@ i40e_macaddr_add(struct rte_eth_dev *dev, return -EINVAL; } - rte_memcpy(&mac_filter.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&mac_filter.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) mac_filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; else @@ -5195,7 +5195,7 @@ i40e_vsi_vlan_pvid_set(struct i40e_vsi *vsi, vsi->info.valid_sections = rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID); memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -5234,8 +5234,8 @@ i40e_vsi_update_tc_bandwidth(struct i40e_vsi *vsi, uint8_t enabled_tcmap) return ret; } - rte_memcpy(vsi->info.qs_handle, tc_bw_data.qs_handles, - sizeof(vsi->info.qs_handle)); + memcpy(vsi->info.qs_handle, tc_bw_data.qs_handles, + sizeof(vsi->info.qs_handle)); return I40E_SUCCESS; } @@ -5492,8 +5492,7 @@ i40e_update_default_filter_setting(struct i40e_vsi *vsi) if (vsi->type != I40E_VSI_MAIN) return I40E_ERR_CONFIG; memset(&def_filter, 0, sizeof(def_filter)); - rte_memcpy(def_filter.mac_addr, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(def_filter.mac_addr, hw->mac.perm_addr, ETH_ADDR_LEN); def_filter.vlan_tag = 0; def_filter.flags = I40E_AQC_MACVLAN_DEL_PERFECT_MATCH | I40E_AQC_MACVLAN_DEL_IGNORE_VLAN; @@ -5511,16 +5510,15 @@ i40e_update_default_filter_setting(struct i40e_vsi *vsi) return I40E_ERR_NO_MEMORY; } mac = &f->mac_info.mac_addr; - rte_memcpy(&mac->addr_bytes, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(&mac->addr_bytes, hw->mac.perm_addr, ETH_ADDR_LEN); f->mac_info.filter_type = I40E_MACVLAN_PERFECT_MATCH; TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); vsi->mac_num++; return ret; } - rte_memcpy(&filter.mac_addr, - (struct rte_ether_addr *)(hw->mac.perm_addr), ETH_ADDR_LEN); + memcpy(&filter.mac_addr, (struct rte_ether_addr *)(hw->mac.perm_addr), + ETH_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; return i40e_vsi_add_mac(vsi, &filter); } @@ -5839,8 +5837,8 @@ i40e_vsi_setup(struct i40e_pf *pf, PMD_DRV_LOG(ERR, "Failed to get VSI params"); goto fail_msix_alloc; } - rte_memcpy(&vsi->info, &ctxt.info, - sizeof(struct i40e_aqc_vsi_properties_data)); + memcpy(&vsi->info, &ctxt.info, + sizeof(struct i40e_aqc_vsi_properties_data)); vsi->vsi_id = ctxt.vsi_number; vsi->info.valid_sections = 0; @@ -5857,8 +5855,8 @@ i40e_vsi_setup(struct i40e_pf *pf, rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID); vsi->info.port_vlan_flags = I40E_AQ_VSI_PVLAN_MODE_ALL | I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH; - rte_memcpy(&ctxt.info, &vsi->info, - sizeof(struct i40e_aqc_vsi_properties_data)); + memcpy(&ctxt.info, &vsi->info, + sizeof(struct i40e_aqc_vsi_properties_data)); ret = i40e_vsi_config_tc_queue_mapping(vsi, &ctxt.info, I40E_DEFAULT_TCMAP); if (ret != I40E_SUCCESS) { @@ -5878,16 +5876,15 @@ i40e_vsi_setup(struct i40e_pf *pf, goto fail_msix_alloc; } - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; - rte_memcpy(pf->dev_addr.addr_bytes, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(pf->dev_addr.addr_bytes, hw->mac.perm_addr, + ETH_ADDR_LEN); /** * Updating default filter settings are necessary to prevent @@ -6030,7 +6027,7 @@ i40e_vsi_setup(struct i40e_pf *pf, if (vsi->type != I40E_VSI_FDIR) { /* MAC/VLAN configuration for non-FDIR VSI*/ - rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; ret = i40e_vsi_add_mac(vsi, &filter); @@ -6143,7 +6140,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on) vsi->info.port_vlan_flags &= ~(I40E_AQ_VSI_PVLAN_EMOD_MASK); vsi->info.port_vlan_flags |= vlan_flags; ctxt.seid = vsi->seid; - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); if (ret) PMD_DRV_LOG(INFO, "Update VSI failed to %s vlan stripping", @@ -7010,8 +7007,8 @@ i40e_add_macvlan_filters(struct i40e_vsi *vsi, memset(req_list, 0, ele_buff_size); for (i = 0; i < actual_num; i++) { - rte_memcpy(req_list[i].mac_addr, - &filter[num + i].macaddr, ETH_ADDR_LEN); + memcpy(req_list[i].mac_addr, &filter[num + i].macaddr, + ETH_ADDR_LEN); req_list[i].vlan_tag = rte_cpu_to_le_16(filter[num + i].vlan_id); @@ -7086,8 +7083,8 @@ i40e_remove_macvlan_filters(struct i40e_vsi *vsi, memset(req_list, 0, ele_buff_size); for (i = 0; i < actual_num; i++) { - rte_memcpy(req_list[i].mac_addr, - &filter[num + i].macaddr, ETH_ADDR_LEN); + memcpy(req_list[i].mac_addr, &filter[num + i].macaddr, + ETH_ADDR_LEN); req_list[i].vlan_tag = rte_cpu_to_le_16(filter[num + i].vlan_id); @@ -7243,8 +7240,8 @@ i40e_find_all_vlan_for_mac(struct i40e_vsi *vsi, "vlan number doesn't match"); return I40E_ERR_PARAM; } - rte_memcpy(&mv_f[i].macaddr, - addr, ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, addr, + ETH_ADDR_LEN); mv_f[i].vlan_id = j * I40E_UINT32_BIT_SIZE + k; i++; @@ -7272,8 +7269,7 @@ i40e_find_all_mac_for_vlan(struct i40e_vsi *vsi, PMD_DRV_LOG(ERR, "buffer number not match"); return I40E_ERR_PARAM; } - rte_memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, ETH_ADDR_LEN); mv_f[i].vlan_id = vlan; mv_f[i].filter_type = f->mac_info.filter_type; i++; @@ -7308,8 +7304,8 @@ i40e_vsi_remove_all_macvlan_filter(struct i40e_vsi *vsi) i = 0; if (vsi->vlan_num == 0) { TAILQ_FOREACH(f, &vsi->mac_list, next) { - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); mv_f[i].filter_type = f->mac_info.filter_type; mv_f[i].vlan_id = 0; i++; @@ -7478,8 +7474,7 @@ i40e_vsi_add_mac(struct i40e_vsi *vsi, struct i40e_mac_filter_info *mac_filter) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = mac_filter->filter_type; - rte_memcpy(&mv_f[i].macaddr, &mac_filter->mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &mac_filter->mac_addr, ETH_ADDR_LEN); } if (mac_filter->filter_type == I40E_MACVLAN_PERFECT_MATCH || @@ -7501,8 +7496,7 @@ i40e_vsi_add_mac(struct i40e_vsi *vsi, struct i40e_mac_filter_info *mac_filter) ret = I40E_ERR_NO_MEMORY; goto DONE; } - rte_memcpy(&f->mac_info.mac_addr, &mac_filter->mac_addr, - ETH_ADDR_LEN); + memcpy(&f->mac_info.mac_addr, &mac_filter->mac_addr, ETH_ADDR_LEN); f->mac_info.filter_type = mac_filter->filter_type; TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); vsi->mac_num++; @@ -7548,8 +7542,7 @@ i40e_vsi_delete_mac(struct i40e_vsi *vsi, struct rte_ether_addr *addr) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = filter_type; - rte_memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, ETH_ADDR_LEN); } if (filter_type == I40E_MACVLAN_PERFECT_MATCH || filter_type == I40E_MACVLAN_HASH_MATCH) { @@ -7835,9 +7828,8 @@ i40e_tunnel_filter_convert( tunnel_filter->input.flags = cld_filter->element.flags; tunnel_filter->input.tenant_id = cld_filter->element.tenant_id; tunnel_filter->queue = cld_filter->element.queue_number; - rte_memcpy(tunnel_filter->input.general_fields, - cld_filter->general_fields, - sizeof(cld_filter->general_fields)); + memcpy(tunnel_filter->input.general_fields, + cld_filter->general_fields, sizeof(cld_filter->general_fields)); return 0; } @@ -8384,9 +8376,8 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, ip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV4; ipv4_addr = rte_be_to_cpu_32(tunnel_filter->ip_addr.ipv4_addr); ipv4_addr_le = rte_cpu_to_le_32(ipv4_addr); - rte_memcpy(&pfilter->element.ipaddr.v4.data, - &ipv4_addr_le, - sizeof(pfilter->element.ipaddr.v4.data)); + memcpy(&pfilter->element.ipaddr.v4.data, &ipv4_addr_le, + sizeof(pfilter->element.ipaddr.v4.data)); } else { ip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV6; for (i = 0; i < 4; i++) { @@ -8394,9 +8385,8 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, rte_cpu_to_le_32(rte_be_to_cpu_32( tunnel_filter->ip_addr.ipv6_addr[i])); } - rte_memcpy(&pfilter->element.ipaddr.v6.data, - &convert_ipv6, - sizeof(pfilter->element.ipaddr.v6.data)); + memcpy(&pfilter->element.ipaddr.v6.data, &convert_ipv6, + sizeof(pfilter->element.ipaddr.v6.data)); } /* check tunneled type */ @@ -8641,7 +8631,7 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, return -ENOMEM; } - rte_memcpy(tunnel, &check_filter, sizeof(check_filter)); + memcpy(tunnel, &check_filter, sizeof(check_filter)); ret = i40e_sw_tunnel_filter_insert(pf, tunnel); if (ret < 0) rte_free(tunnel); @@ -9766,8 +9756,7 @@ static int i40e_ethertype_filter_convert(const struct rte_eth_ethertype_filter *input, struct i40e_ethertype_filter *filter) { - rte_memcpy(&filter->input.mac_addr, &input->mac_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->input.mac_addr, &input->mac_addr, RTE_ETHER_ADDR_LEN); filter->input.ether_type = input->ether_type; filter->flags = input->flags; filter->queue = input->queue; @@ -9914,8 +9903,7 @@ i40e_ethertype_filter_set(struct i40e_pf *pf, return -ENOMEM; } - rte_memcpy(ethertype_filter, &check_filter, - sizeof(check_filter)); + memcpy(ethertype_filter, &check_filter, sizeof(check_filter)); ret = i40e_sw_ethertype_filter_insert(pf, ethertype_filter); if (ret < 0) rte_free(ethertype_filter); @@ -10795,11 +10783,10 @@ i40e_vsi_config_tc(struct i40e_vsi *vsi, uint8_t tc_map) goto out; } /* update the local VSI info with updated queue map */ - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; @@ -11551,9 +11538,8 @@ i40e_tunnel_filter_restore(struct i40e_pf *pf) cld_filter.element.flags = f->input.flags; cld_filter.element.tenant_id = f->input.tenant_id; cld_filter.element.queue_number = f->queue; - rte_memcpy(cld_filter.general_fields, - f->input.general_fields, - sizeof(f->input.general_fields)); + memcpy(cld_filter.general_fields, f->input.general_fields, + sizeof(f->input.general_fields)); if (((f->input.flags & I40E_AQC_ADD_CLOUD_FILTER_0X11) == diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 47f79ecf11cc..554b763e9f84 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -464,10 +464,10 @@ fill_ip6_head(const struct i40e_fdir_input *fdir_input, unsigned char *raw_pkt, * need to be presented in a reversed order with respect * to the expected received packets. */ - rte_memcpy(&ip6->src_addr, &fdir_input->flow.ipv6_flow.dst_ip, - IPV6_ADDR_LEN); - rte_memcpy(&ip6->dst_addr, &fdir_input->flow.ipv6_flow.src_ip, - IPV6_ADDR_LEN); + memcpy(&ip6->src_addr, &fdir_input->flow.ipv6_flow.dst_ip, + IPV6_ADDR_LEN); + memcpy(&ip6->dst_addr, &fdir_input->flow.ipv6_flow.src_ip, + IPV6_ADDR_LEN); len += sizeof(struct rte_ipv6_hdr); return len; @@ -528,18 +528,16 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf *pf, [I40E_FILTER_PCTYPE_NONF_IPV6_OTHER] = IPPROTO_NONE, }; - rte_memcpy(raw_pkt, &fdir_input->flow.l2_flow.dst, - sizeof(struct rte_ether_addr)); - rte_memcpy(raw_pkt + sizeof(struct rte_ether_addr), - &fdir_input->flow.l2_flow.src, - sizeof(struct rte_ether_addr)); + memcpy(raw_pkt, &fdir_input->flow.l2_flow.dst, + sizeof(struct rte_ether_addr)); + memcpy(raw_pkt + sizeof(struct rte_ether_addr), + &fdir_input->flow.l2_flow.src, sizeof(struct rte_ether_addr)); raw_pkt += 2 * sizeof(struct rte_ether_addr); if (vlan && fdir_input->flow_ext.vlan_tci) { - rte_memcpy(raw_pkt, vlan_frame, sizeof(vlan_frame)); - rte_memcpy(raw_pkt + sizeof(uint16_t), - &fdir_input->flow_ext.vlan_tci, - sizeof(uint16_t)); + memcpy(raw_pkt, vlan_frame, sizeof(vlan_frame)); + memcpy(raw_pkt + sizeof(uint16_t), + &fdir_input->flow_ext.vlan_tci, sizeof(uint16_t)); raw_pkt += sizeof(vlan_frame); len += sizeof(vlan_frame); } @@ -1003,7 +1001,7 @@ static int i40e_fdir_filter_convert(const struct i40e_fdir_filter_conf *input, struct i40e_fdir_filter *filter) { - rte_memcpy(&filter->fdir, input, sizeof(struct i40e_fdir_filter_conf)); + memcpy(&filter->fdir, input, sizeof(struct i40e_fdir_filter_conf)); if (input->input.flow_ext.pkt_template) { filter->fdir.input.flow.raw_flow.packet = NULL; filter->fdir.input.flow.raw_flow.length = @@ -1060,7 +1058,7 @@ i40e_sw_fdir_filter_insert(struct i40e_pf *pf, struct i40e_fdir_filter *filter) return -1; hash_filter = &fdir_info->fdir_filter_array[ret]; - rte_memcpy(hash_filter, filter, sizeof(*filter)); + memcpy(hash_filter, filter, sizeof(*filter)); fdir_info->hash_map[ret] = hash_filter; TAILQ_INSERT_TAIL(&fdir_info->fdir_list, hash_filter, rules); diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 92165c8422d5..9afb7a540d21 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -1175,7 +1175,7 @@ i40e_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ @@ -1986,10 +1986,10 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, filter->input.flow_ext.oip_type = I40E_FDIR_IPTYPE_IPV6; - rte_memcpy(filter->input.flow.ipv6_flow.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(filter->input.flow.ipv6_flow.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(filter->input.flow.ipv6_flow.src_ip, + ipv6_spec->hdr.src_addr, 16); + memcpy(filter->input.flow.ipv6_flow.dst_ip, + ipv6_spec->hdr.dst_addr, 16); /* Check if it is fragment. */ if (ipv6_spec->hdr.proto == @@ -2926,14 +2926,14 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev, } if (!vxlan_flag) { - rte_memcpy(&filter->outer_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->outer_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_OMAC; } else { - rte_memcpy(&filter->inner_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->inner_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_IMAC; } } @@ -3026,8 +3026,8 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev, return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - vxlan_spec->hdr.vni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + vxlan_spec->hdr.vni, 3); filter->tenant_id = rte_be_to_cpu_32(tenant_id_be); filter_type |= RTE_ETH_TUNNEL_FILTER_TENID; @@ -3156,14 +3156,14 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev, } if (!nvgre_flag) { - rte_memcpy(&filter->outer_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->outer_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_OMAC; } else { - rte_memcpy(&filter->inner_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->inner_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_IMAC; } } @@ -3278,8 +3278,8 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev, "Invalid NVGRE item"); return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - nvgre_spec->tni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + nvgre_spec->tni, 3); filter->tenant_id = rte_be_to_cpu_32(tenant_id_be); filter_type |= RTE_ETH_TUNNEL_FILTER_TENID; @@ -3447,8 +3447,8 @@ i40e_flow_parse_mpls_pattern(__rte_unused struct rte_eth_dev *dev, "Invalid MPLS label mask"); return -rte_errno; } - rte_memcpy(((uint8_t *)&label_be + 1), - mpls_spec->label_tc_s, 3); + memcpy(((uint8_t *)&label_be + 1), + mpls_spec->label_tc_s, 3); filter->tenant_id = rte_be_to_cpu_32(label_be) >> 4; break; default: @@ -4051,9 +4051,8 @@ i40e_flow_destroy_tunnel_filter(struct i40e_pf *pf, cld_filter.element.flags = filter->input.flags; cld_filter.element.tenant_id = filter->input.tenant_id; cld_filter.element.queue_number = filter->queue; - rte_memcpy(cld_filter.general_fields, - filter->input.general_fields, - sizeof(cld_filter.general_fields)); + memcpy(cld_filter.general_fields, filter->input.general_fields, + sizeof(cld_filter.general_fields)); if (!filter->is_to_vf) vsi = pf->main_vsi; @@ -4271,9 +4270,8 @@ i40e_flow_query(struct rte_eth_dev *dev __rte_unused, "action not supported"); return -rte_errno; } - rte_memcpy(rss_conf, - &rss_rule->rss_filter_info.conf, - sizeof(struct rte_flow_action_rss)); + memcpy(rss_conf, &rss_rule->rss_filter_info.conf, + sizeof(struct rte_flow_action_rss)); break; default: return rte_flow_error_set(error, ENOTSUP, diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..9a33afade3d3 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -869,7 +869,7 @@ i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf, for (i = 0; i < addr_list->num_elements; i++) { mac = (struct rte_ether_addr *)(addr_list->list[i].addr); - rte_memcpy(&filter.mac_addr, mac, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, mac, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; if (rte_is_zero_ether_addr(mac) || i40e_vsi_add_mac(vf->vsi, &filter)) { diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index cab296e1a4af..3f77a7b3a056 100644 --- a/drivers/net/i40e/i40e_tm.c +++ b/drivers/net/i40e/i40e_tm.c @@ -279,8 +279,8 @@ i40e_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&pf->tm_conf.shaper_profile_list, shaper_profile, node); @@ -526,8 +526,8 @@ i40e_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); pf->tm_conf.root = tm_node; /* increase the reference counter of the shaper profile */ @@ -600,8 +600,7 @@ i40e_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == I40E_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&pf->tm_conf.tc_list, tm_node, node); diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 9d39984ea1fc..03d0b61902a9 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -90,7 +90,7 @@ rte_pmd_i40e_set_vf_mac_anti_spoof(uint16_t port, uint16_t vf_id, uint8_t on) vsi->info.sec_flags &= ~I40E_AQ_VSI_SEC_FLAG_ENABLE_MAC_CHK; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -192,7 +192,7 @@ rte_pmd_i40e_set_vf_vlan_anti_spoof(uint16_t port, uint16_t vf_id, uint8_t on) vsi->info.sec_flags &= ~I40E_AQ_VSI_SEC_FLAG_ENABLE_VLAN_CHK; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -237,9 +237,8 @@ i40e_vsi_rm_mac_filter(struct i40e_vsi *vsi) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = filter_type; - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); } if (filter_type == I40E_MACVLAN_PERFECT_MATCH || filter_type == I40E_MACVLAN_HASH_MATCH) { @@ -298,9 +297,8 @@ i40e_vsi_restore_mac_filter(struct i40e_vsi *vsi) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = f->mac_info.filter_type; - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); } if (f->mac_info.filter_type == I40E_MACVLAN_PERFECT_MATCH || @@ -380,7 +378,7 @@ i40e_vsi_set_tx_loopback(struct i40e_vsi *vsi, uint8_t on) vsi->info.switch_id &= ~I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); @@ -705,7 +703,7 @@ int rte_pmd_i40e_set_vf_vlan_insert(uint16_t port, uint16_t vf_id, vsi->info.port_vlan_flags &= ~I40E_AQ_VSI_PVLAN_INSERT_PVID; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -767,7 +765,7 @@ int rte_pmd_i40e_set_vf_broadcast(uint16_t port, uint16_t vf_id, } if (on) { - rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; ret = i40e_vsi_add_mac(vsi, &filter); } else { @@ -839,7 +837,7 @@ int rte_pmd_i40e_set_vf_vlan_tag(uint16_t port, uint16_t vf_id, uint8_t on) } memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -2586,11 +2584,10 @@ i40e_vsi_update_queue_region_mapping(struct i40e_hw *hw, return ret; } /* update the local VSI info with updated queue map */ - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; @@ -2961,8 +2958,7 @@ i40e_queue_region_get_all_info(struct i40e_pf *pf, { struct i40e_queue_regions *info = &pf->queue_region; - rte_memcpy(regions_ptr, info, - sizeof(struct i40e_queue_regions)); + memcpy(regions_ptr, info, sizeof(struct i40e_queue_regions)); return 0; } From patchwork Thu Feb 29 22:58:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137600 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A12D43BAE; Fri, 1 Mar 2024 00:03:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C59B543362; Fri, 1 Mar 2024 00:01:08 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id C635442FFB for ; Fri, 1 Mar 2024 00:00:21 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-29a61872f4eso1082824a91.2 for ; Thu, 29 Feb 2024 15:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247621; x=1709852421; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pJfsyrMcQ8xTN23o1pauOoIoqNV5wjsYf/z1finubS0=; b=J+ea+eaQVLglTozC88nE0AKUgSwWRMmqiWQ1jSWZdTR6LB61sZ1MgdkGg4uLAQVkhN hTWB1yty1bo/1Ko5tb2kxCZ1FujE6fplCHJCBoI+n/NP+xQZyLSlk7r/qtoHZ+n98dQd IppCIL7aibQD1FHgNwXhqtJ/duyDJlpGNhKJLdKJBJEYSJYiZUCWugnACG1M8HnEGKX9 AYv/fXbBGSjwpz3S1HfbTc1pRgWL4kiCjLfVZUqgHAoeRArA0E0gIMXz7ZQNj/OrTnKS PxIuiMFEikv9V6tfZ0LeGZGGOOM5vXVLBI0VMGbkoXLc5Ud8UFzj631+YTxkXpc+j5+F d/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247621; x=1709852421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJfsyrMcQ8xTN23o1pauOoIoqNV5wjsYf/z1finubS0=; b=YBF90ukzxLbRYgsnvEW4xUP473tpDv09ep457wl8v8CepTcR3wxux4FFHkhO9DIb2z FE0bt/UbngGGN2L8GQS/fMLeka7zjywZnBWhNGgADWh1yah/W7GGk0gAdHANvl6IxVIH RkgIhHOZ0Gk1u6ut4pOI0x7sHh9UFdxgyH0b/jrjTVj8zj1tromRI5UkrbVV23STMZfU mQKNL7a2wfY0whkxUWjsA2fBgju5CJoZokT8ImtNgUUsLH45CBBzEaUJ744DWRU/U+VF sC04TE30xKrpEigu98YX/2zjJSzF5FT+xIPWseCs3HG8hcOp1Y//RG6nxNN7hUiScvEb 5+ig== X-Gm-Message-State: AOJu0YymIBLgFk95BpQvceDsp5cUqtn1EXXezMZZvnjMvWiYfRpN7IF7 KFhxcshfqj2NOykKEk2HlBKE1vr1sH+2J9x75r65mUKV5ykv83k6pkjn8qpqA/6/LgP3G/222fZ Z X-Google-Smtp-Source: AGHT+IF2iKDy9LTz6NeKOxAgtFLToJvj9MoHyW6feOJ/Ec4LSA3w0cWStaXKmQj/EyWtXV6Igfnv+g== X-Received: by 2002:a17:90b:3557:b0:29a:5f51:cd88 with SMTP id lt23-20020a17090b355700b0029a5f51cd88mr33244pjb.27.1709247620846; Thu, 29 Feb 2024 15:00:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH 26/71] net/iavf: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:13 -0800 Message-ID: <20240229225936.483472-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_fdir.c | 93 +++++++++++++--------------- drivers/net/iavf/iavf_fsub.c | 50 +++++++-------- drivers/net/iavf/iavf_generic_flow.c | 2 +- drivers/net/iavf/iavf_tm.c | 11 ++-- drivers/net/iavf/iavf_vchnl.c | 9 ++- 5 files changed, 77 insertions(+), 88 deletions(-) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index 811a10287b70..35257c43f135 100644 --- a/drivers/net/iavf/iavf_fdir.c +++ b/drivers/net/iavf/iavf_fdir.c @@ -374,7 +374,7 @@ iavf_fdir_create(struct iavf_adapter *ad, if (filter->mark_flag == 1) iavf_fdir_rx_proc_enable(ad, 1); - rte_memcpy(rule, filter, sizeof(*rule)); + memcpy(rule, filter, sizeof(*rule)); flow->rule = rule; return 0; @@ -672,15 +672,13 @@ iavf_fdir_refine_input_set(const uint64_t input_set, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV4, PROT); memset(&ipv4_spec, 0, sizeof(ipv4_spec)); ipv4_spec.hdr.next_proto_id = proto_id; - rte_memcpy(hdr->buffer, &ipv4_spec.hdr, - sizeof(ipv4_spec.hdr)); + memcpy(hdr->buffer, &ipv4_spec.hdr, sizeof(ipv4_spec.hdr)); return true; case VIRTCHNL_PROTO_HDR_IPV6: VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, PROT); memset(&ipv6_spec, 0, sizeof(ipv6_spec)); ipv6_spec.hdr.proto = proto_id; - rte_memcpy(hdr->buffer, &ipv6_spec.hdr, - sizeof(ipv6_spec.hdr)); + memcpy(hdr->buffer, &ipv6_spec.hdr, sizeof(ipv6_spec.hdr)); return true; default: return false; @@ -885,8 +883,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, ETHERTYPE); } - rte_memcpy(hdr1->buffer, eth_spec, - sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer, eth_spec, + sizeof(struct rte_ether_hdr)); } hdrs->count = ++layer; @@ -976,8 +974,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, input_set |= IAVF_PROT_IPV4_INNER; } - rte_memcpy(hdr->buffer, &ipv4_spec->hdr, - sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer, &ipv4_spec->hdr, + sizeof(ipv4_spec->hdr)); hdrs->count = ++layer; @@ -1066,8 +1064,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, input_set |= IAVF_PROT_IPV6_INNER; } - rte_memcpy(hdr->buffer, &ipv6_spec->hdr, - sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer, &ipv6_spec->hdr, + sizeof(ipv6_spec->hdr)); hdrs->count = ++layer; break; @@ -1101,8 +1099,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr1, ETH, ETHERTYPE); - rte_memcpy(hdr->buffer, &ipv6_frag_spec->hdr, - sizeof(ipv6_frag_spec->hdr)); + memcpy(hdr->buffer, &ipv6_frag_spec->hdr, + sizeof(ipv6_frag_spec->hdr)); } else if (ipv6_frag_mask->hdr.id == UINT32_MAX) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, @@ -1153,13 +1151,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &udp_spec->hdr, - sizeof(udp_spec->hdr)); + memcpy(hdr->buffer, &udp_spec->hdr, + sizeof(udp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &udp_spec->hdr, - sizeof(udp_spec->hdr)); + memcpy(hdr->buffer, &udp_spec->hdr, + sizeof(udp_spec->hdr)); } hdrs->count = ++layer; @@ -1210,13 +1206,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); } hdrs->count = ++layer; @@ -1256,13 +1250,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &sctp_spec->hdr, - sizeof(sctp_spec->hdr)); + memcpy(hdr->buffer, &sctp_spec->hdr, + sizeof(sctp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &sctp_spec->hdr, - sizeof(sctp_spec->hdr)); + memcpy(hdr->buffer, &sctp_spec->hdr, + sizeof(sctp_spec->hdr)); } hdrs->count = ++layer; @@ -1291,8 +1283,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_IP, TEID); } - rte_memcpy(hdr->buffer, - gtp_spec, sizeof(*gtp_spec)); + memcpy(hdr->buffer, gtp_spec, + sizeof(*gtp_spec)); } tun_inner = 1; @@ -1346,8 +1338,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, psc.qfi = gtp_psc_spec->hdr.qfi; psc.type = gtp_psc_spec->hdr.type; psc.next = 0; - rte_memcpy(hdr->buffer, &psc, - sizeof(struct iavf_gtp_psc_spec_hdr)); + memcpy(hdr->buffer, &psc, + sizeof(struct iavf_gtp_psc_spec_hdr)); } hdrs->count = ++layer; @@ -1367,8 +1359,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, L2TPV3, SESS_ID); } - rte_memcpy(hdr->buffer, l2tpv3oip_spec, - sizeof(*l2tpv3oip_spec)); + memcpy(hdr->buffer, l2tpv3oip_spec, + sizeof(*l2tpv3oip_spec)); } hdrs->count = ++layer; @@ -1388,8 +1380,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, ESP, SPI); } - rte_memcpy(hdr->buffer, &esp_spec->hdr, - sizeof(esp_spec->hdr)); + memcpy(hdr->buffer, &esp_spec->hdr, + sizeof(esp_spec->hdr)); } hdrs->count = ++layer; @@ -1409,8 +1401,7 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, AH, SPI); } - rte_memcpy(hdr->buffer, ah_spec, - sizeof(*ah_spec)); + memcpy(hdr->buffer, ah_spec, sizeof(*ah_spec)); } hdrs->count = ++layer; @@ -1430,8 +1421,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, PFCP, S_FIELD); } - rte_memcpy(hdr->buffer, pfcp_spec, - sizeof(*pfcp_spec)); + memcpy(hdr->buffer, pfcp_spec, + sizeof(*pfcp_spec)); } hdrs->count = ++layer; @@ -1455,8 +1446,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, PC_RTC_ID); } - rte_memcpy(hdr->buffer, ecpri_spec, - sizeof(*ecpri_spec)); + memcpy(hdr->buffer, ecpri_spec, + sizeof(*ecpri_spec)); } hdrs->count = ++layer; @@ -1471,8 +1462,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GRE); if (gre_spec && gre_mask) { - rte_memcpy(hdr->buffer, gre_spec, - sizeof(*gre_spec)); + memcpy(hdr->buffer, gre_spec, + sizeof(*gre_spec)); } tun_inner = 1; @@ -1520,8 +1511,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, SESS_ID); } - rte_memcpy(hdr->buffer, l2tpv2_spec, - sizeof(*l2tpv2_spec)); + memcpy(hdr->buffer, l2tpv2_spec, + sizeof(*l2tpv2_spec)); } tun_inner = 1; @@ -1538,8 +1529,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, PPP); if (ppp_spec && ppp_mask) { - rte_memcpy(hdr->buffer, ppp_spec, - sizeof(*ppp_spec)); + memcpy(hdr->buffer, ppp_spec, + sizeof(*ppp_spec)); } hdrs->count = ++layer; diff --git a/drivers/net/iavf/iavf_fsub.c b/drivers/net/iavf/iavf_fsub.c index 74e1e7099b8c..d98cde0fa59d 100644 --- a/drivers/net/iavf/iavf_fsub.c +++ b/drivers/net/iavf/iavf_fsub.c @@ -92,7 +92,7 @@ iavf_fsub_create(struct iavf_adapter *ad, struct rte_flow *flow, goto free_entry; } - rte_memcpy(rule, filter, sizeof(*rule)); + memcpy(rule, filter, sizeof(*rule)); flow->rule = rule; rte_free(meta); @@ -272,10 +272,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr1->buffer_spec, eth_spec, - sizeof(struct rte_ether_hdr)); - rte_memcpy(hdr1->buffer_mask, eth_mask, - sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer_spec, eth_spec, + sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer_mask, eth_mask, + sizeof(struct rte_ether_hdr)); } else { /* flow subscribe filter will add dst mac in kernel */ input_set_byte += 6; @@ -325,10 +325,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte++; } - rte_memcpy(hdr->buffer_spec, &ipv4_spec->hdr, - sizeof(ipv4_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &ipv4_mask->hdr, - sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer_spec, &ipv4_spec->hdr, + sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer_mask, &ipv4_mask->hdr, + sizeof(ipv4_spec->hdr)); } hdrs->count = ++layer; @@ -388,10 +388,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 4; } - rte_memcpy(hdr->buffer_spec, &ipv6_spec->hdr, - sizeof(ipv6_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &ipv6_mask->hdr, - sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer_spec, &ipv6_spec->hdr, + sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer_mask, &ipv6_mask->hdr, + sizeof(ipv6_spec->hdr)); } hdrs->count = ++layer; @@ -425,10 +425,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr->buffer_spec, &udp_spec->hdr, - sizeof(udp_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &udp_mask->hdr, - sizeof(udp_mask->hdr)); + memcpy(hdr->buffer_spec, &udp_spec->hdr, + sizeof(udp_spec->hdr)); + memcpy(hdr->buffer_mask, &udp_mask->hdr, + sizeof(udp_mask->hdr)); } hdrs->count = ++layer; @@ -466,10 +466,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr->buffer_spec, &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &tcp_mask->hdr, - sizeof(tcp_mask->hdr)); + memcpy(hdr->buffer_spec, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer_mask, &tcp_mask->hdr, + sizeof(tcp_mask->hdr)); } hdrs->count = ++layer; @@ -498,10 +498,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], return -rte_errno; } - rte_memcpy(hdr->buffer_spec, &vlan_spec->hdr, - sizeof(vlan_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &vlan_mask->hdr, - sizeof(vlan_mask->hdr)); + memcpy(hdr->buffer_spec, &vlan_spec->hdr, + sizeof(vlan_spec->hdr)); + memcpy(hdr->buffer_mask, &vlan_mask->hdr, + sizeof(vlan_mask->hdr)); } hdrs->count = ++layer; diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c index 6f6e95fc453f..0bcfb5bf242b 100644 --- a/drivers/net/iavf/iavf_generic_flow.c +++ b/drivers/net/iavf/iavf_generic_flow.c @@ -2019,7 +2019,7 @@ iavf_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ diff --git a/drivers/net/iavf/iavf_tm.c b/drivers/net/iavf/iavf_tm.c index 32bb3be45e1b..a6ad6bb0a28d 100644 --- a/drivers/net/iavf/iavf_tm.c +++ b/drivers/net/iavf/iavf_tm.c @@ -342,8 +342,8 @@ iavf_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->id = node_id; tm_node->parent = NULL; tm_node->reference_count = 0; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); vf->tm_conf.root = tm_node; return 0; } @@ -403,8 +403,7 @@ iavf_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == IAVF_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&vf->tm_conf.tc_list, tm_node, node); @@ -543,8 +542,8 @@ iavf_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&vf->tm_conf.shaper_profile_list, shaper_profile, node); diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 1111d30f57d1..711186c1b552 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -920,7 +920,7 @@ iavf_get_vlan_offload_caps_v2(struct iavf_adapter *adapter) return ret; } - rte_memcpy(&vf->vlan_v2_caps, vf->aq_resp, sizeof(vf->vlan_v2_caps)); + memcpy(&vf->vlan_v2_caps, vf->aq_resp, sizeof(vf->vlan_v2_caps)); return 0; } @@ -1427,8 +1427,8 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add) addr = &adapter->dev_data->mac_addrs[i]; if (rte_is_zero_ether_addr(addr)) continue; - rte_memcpy(list->list[j].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[j].addr, addr->addr_bytes, + sizeof(addr->addr_bytes)); list->list[j].type = (j == 0 ? VIRTCHNL_ETHER_ADDR_PRIMARY : VIRTCHNL_ETHER_ADDR_EXTRA); @@ -1547,8 +1547,7 @@ iavf_add_del_eth_addr(struct iavf_adapter *adapter, struct rte_ether_addr *addr, list->vsi_id = vf->vsi_res->vsi_id; list->num_elements = 1; list->list[0].type = type; - rte_memcpy(list->list[0].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[0].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); args.ops = add ? VIRTCHNL_OP_ADD_ETH_ADDR : VIRTCHNL_OP_DEL_ETH_ADDR; args.in_args = cmd_buffer; From patchwork Thu Feb 29 22:58:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137601 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B9243BAE; Fri, 1 Mar 2024 00:03:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39CEC4335D; Fri, 1 Mar 2024 00:01:10 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id C264342FEF for ; Fri, 1 Mar 2024 00:00:22 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-29b1ee96191so292004a91.0 for ; Thu, 29 Feb 2024 15:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247622; x=1709852422; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sucpImUOk72On1AycV8jrZiKcZFV6ng/DVXTZJdMBF0=; b=ajxFkGQ54gvUIR/oR0zxvywUnl3+KMcWizJhabKjAI9+pzkxCflJdCsgq3RxvddIcj q7qvoY8zwTAhO0pUzdXAerCkHvjNiR8WMONi5MZ2RT+enWy4Z/As70hRtjuJRUnPiycH 72XerYL6tcc+grGiRSLSc+k8ZUzjG71ZU97RDQBdc3/E/T5DG+8lS3z9vtmbO9HbylzM OYxN5UKf532y4Zwu6DhGGesHCjfyTKUP9X0DVLmlhHR32BMUaBL88wjEUXTitiFsETYj UvwMfWfjLuRJrF32w2hlOWQ3jFjHSpPk26SZ89fuKubHbtk5u5FjSGBqgunTNoWyYQKf PvkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247622; x=1709852422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sucpImUOk72On1AycV8jrZiKcZFV6ng/DVXTZJdMBF0=; b=Q2C2N/y5CBYcjinfU6l5W/A/0JyrSkspyh+ZUfA1q8MZgiOBuxCu7Wb+FmARxYLjq2 yW/VuaDOdiZMRqSlR67MmjXDfkwxTejRjV7v/MiiWkgasNfxsoDlU7cEyiEDszPqxjYQ wiHoeNlF+okNDeVaUQqHI7/0WxIAZcJwqnax6DdlVy0+2wbS6U3g7dxsRdmAk8BvqvDq F0RAzh7SVpAxJJSrW5Q+gEs32eNkb0B4hn+pQz6fKEukbkWnKYrzwL5t+XjXU41sJhhK nO/YzsYhUPXsjZjaCZIvQiufAM/MBTRIH7mCuFANDoYLwaX7eNnEAcvKfXR5vRNrseai P/fg== X-Gm-Message-State: AOJu0YyRsYF2AHkgUJFWbvE21DEymjm2tpiSs9jqxFh/fhKUpnP+nQiT 1+emXhwr4VCzn0sAV4tq425XjSbWQBxCpDQ0Dj9ObtohX3sZZs9OsTrFY02aUbV5bj5uyCjbzoL x X-Google-Smtp-Source: AGHT+IEx75YOD/YHCkx9PWvPNIlv1e8es9AbEp53xfZttSKXhM20DQmQtlSaOsrUpjw6k1qYFIofbw== X-Received: by 2002:a17:90a:a516:b0:299:2927:4d2c with SMTP id a22-20020a17090aa51600b0029929274d2cmr17959pjq.48.1709247621836; Thu, 29 Feb 2024 15:00:21 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 27/71] net/ice: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:14 -0800 Message-ID: <20240229225936.483472-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_dcf.c | 5 ++-- drivers/net/ice/ice_dcf_parent.c | 2 +- drivers/net/ice/ice_dcf_sched.c | 11 ++++----- drivers/net/ice/ice_diagnose.c | 4 ++-- drivers/net/ice/ice_ethdev.c | 14 +++++------ drivers/net/ice/ice_fdir_filter.c | 37 +++++++++++++++--------------- drivers/net/ice/ice_generic_flow.c | 2 +- drivers/net/ice/ice_hash.c | 2 +- drivers/net/ice/ice_tm.c | 11 ++++----- 9 files changed, 43 insertions(+), 45 deletions(-) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c index 7f8f5163acef..42e5b30b2b5e 100644 --- a/drivers/net/ice/ice_dcf.c +++ b/drivers/net/ice/ice_dcf.c @@ -731,7 +731,7 @@ dcf_get_vlan_offload_caps_v2(struct ice_dcf_hw *hw) return ret; } - rte_memcpy(&hw->vlan_v2_caps, &vlan_v2_caps, sizeof(vlan_v2_caps)); + memcpy(&hw->vlan_v2_caps, &vlan_v2_caps, sizeof(vlan_v2_caps)); return 0; } @@ -1407,8 +1407,7 @@ ice_dcf_add_del_all_mac_addr(struct ice_dcf_hw *hw, return -ENOMEM; } - rte_memcpy(list->list[0].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[0].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); PMD_DRV_LOG(DEBUG, "add/rm mac:" RTE_ETHER_ADDR_PRT_FMT, RTE_ETHER_ADDR_BYTES(addr)); diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c index 6e845f458acd..0c53755c9d04 100644 --- a/drivers/net/ice/ice_dcf_parent.c +++ b/drivers/net/ice/ice_dcf_parent.c @@ -407,7 +407,7 @@ ice_dcf_load_pkg(struct ice_adapter *adapter) use_dsn = ice_dcf_execute_virtchnl_cmd(&dcf_adapter->real_hw, &vc_cmd) == 0; if (use_dsn) - rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn)); + memcpy(&dsn, pkg_info.dsn, sizeof(dsn)); return ice_load_pkg(adapter, use_dsn, dsn); } diff --git a/drivers/net/ice/ice_dcf_sched.c b/drivers/net/ice/ice_dcf_sched.c index b08bc5f1dee0..465ae75d5c97 100644 --- a/drivers/net/ice/ice_dcf_sched.c +++ b/drivers/net/ice/ice_dcf_sched.c @@ -308,8 +308,8 @@ ice_dcf_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->id = node_id; tm_node->parent = NULL; tm_node->reference_count = 0; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); hw->tm_conf.root = tm_node; return 0; @@ -373,8 +373,7 @@ ice_dcf_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->shaper_profile = shaper_profile; tm_node->reference_count = 0; tm_node->parent = parent_node; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == ICE_DCF_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&hw->tm_conf.tc_list, tm_node, node); @@ -520,8 +519,8 @@ ice_dcf_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&hw->tm_conf.shaper_profile_list, shaper_profile, node); diff --git a/drivers/net/ice/ice_diagnose.c b/drivers/net/ice/ice_diagnose.c index 3be819d7f8f4..c22f71e48efa 100644 --- a/drivers/net/ice/ice_diagnose.c +++ b/drivers/net/ice/ice_diagnose.c @@ -362,13 +362,13 @@ ice_dump_pkg(struct rte_eth_dev *dev, uint8_t **buff, uint32_t *size) count = *size / ICE_PKG_BUF_SIZE; for (i = 0; i < count; i++) { next_buff = (uint8_t *)(*buff) + i * ICE_PKG_BUF_SIZE; - rte_memcpy(pkg_buff.buf, next_buff, ICE_PKG_BUF_SIZE); + memcpy(pkg_buff.buf, next_buff, ICE_PKG_BUF_SIZE); if (ice_aq_upload_section(hw, (struct ice_buf_hdr *)&pkg_buff.buf[0], ICE_PKG_BUF_SIZE, NULL)) return -EINVAL; - rte_memcpy(next_buff, pkg_buff.buf, ICE_PKG_BUF_SIZE); + memcpy(next_buff, pkg_buff.buf, ICE_PKG_BUF_SIZE); } cache_size = sizeof(struct ice_package_header) + *size; diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index f07b236ad4b6..93e364811d2e 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3387,11 +3387,11 @@ static int ice_init_rss(struct ice_pf *pf) RTE_MIN(rss_conf->rss_key_len, vsi->rss_key_size)); - rte_memcpy(key.standard_rss_key, vsi->rss_key, - ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE); - rte_memcpy(key.extended_hash_key, - &vsi->rss_key[ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE], - ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE); + memcpy(key.standard_rss_key, vsi->rss_key, + ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE); + memcpy(key.extended_hash_key, + &vsi->rss_key[ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE], + ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE); ret = ice_aq_set_rss_key(hw, vsi->idx, &key); if (ret) goto out; @@ -4483,7 +4483,7 @@ ice_vsi_config_vlan_filter(struct ice_vsi *vsi, bool on) vsi->info.sw_flags2 &= ~sw_flags2; vsi->info.sw_id = hw->port_info->sw_id; - (void)rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.info.valid_sections = rte_cpu_to_le_16(ICE_AQ_VSI_PROP_SW_VALID | ICE_AQ_VSI_PROP_SECURITY_VALID); @@ -5301,7 +5301,7 @@ ice_vsi_vlan_pvid_set(struct ice_vsi *vsi, struct ice_vsi_vlan_pvid_info *info) ICE_AQ_VSI_INNER_VLAN_EMODE_M); vsi->info.inner_vlan_flags |= vlan_flags; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.info.valid_sections = rte_cpu_to_le_16(ICE_AQ_VSI_PROP_VLAN_VALID); ctxt.vsi_num = vsi->vsi_id; diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 0b7920ad4475..de7b531aa023 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -1224,13 +1224,13 @@ ice_fdir_extract_fltr_key(struct ice_fdir_fltr_pattern *key, memset(key, 0, sizeof(*key)); key->flow_type = input->flow_type; - rte_memcpy(&key->ip, &input->ip, sizeof(key->ip)); - rte_memcpy(&key->mask, &input->mask, sizeof(key->mask)); - rte_memcpy(&key->ext_data, &input->ext_data, sizeof(key->ext_data)); - rte_memcpy(&key->ext_mask, &input->ext_mask, sizeof(key->ext_mask)); + memcpy(&key->ip, &input->ip, sizeof(key->ip)); + memcpy(&key->mask, &input->mask, sizeof(key->mask)); + memcpy(&key->ext_data, &input->ext_data, sizeof(key->ext_data)); + memcpy(&key->ext_mask, &input->ext_mask, sizeof(key->ext_mask)); - rte_memcpy(&key->gtpu_data, &input->gtpu_data, sizeof(key->gtpu_data)); - rte_memcpy(&key->gtpu_mask, &input->gtpu_mask, sizeof(key->gtpu_mask)); + memcpy(&key->gtpu_data, &input->gtpu_data, sizeof(key->gtpu_data)); + memcpy(&key->gtpu_mask, &input->gtpu_mask, sizeof(key->gtpu_mask)); key->tunnel_type = filter->tunnel_type; } @@ -1358,7 +1358,7 @@ ice_fdir_create_filter(struct ice_adapter *ad, if (!entry) goto error; - rte_memcpy(entry, filter, sizeof(*filter)); + memcpy(entry, filter, sizeof(*filter)); flow->rule = entry; @@ -1419,7 +1419,7 @@ ice_fdir_create_filter(struct ice_adapter *ad, if (filter->mark_flag == 1) ice_fdir_rx_parsing_enable(ad, 1); - rte_memcpy(entry, filter, sizeof(*entry)); + memcpy(entry, filter, sizeof(*entry)); ret = ice_fdir_entry_insert(pf, entry, &key); if (ret) { rte_flow_error_set(error, -ret, @@ -1720,8 +1720,8 @@ ice_fdir_parse_action(struct ice_adapter *ad, act_count = actions->conf; filter->input.cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS; - rte_memcpy(&filter->act_count, act_count, - sizeof(filter->act_count)); + memcpy(&filter->act_count, act_count, + sizeof(filter->act_count)); break; default: @@ -1978,12 +1978,13 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, p_ext_data = (tunnel_type && is_outer) ? &filter->input.ext_data_outer : &filter->input.ext_data; - rte_memcpy(&p_ext_data->src_mac, - ð_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN); - rte_memcpy(&p_ext_data->dst_mac, - ð_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN); - rte_memcpy(&p_ext_data->ether_type, - ð_spec->hdr.ether_type, sizeof(eth_spec->hdr.ether_type)); + memcpy(&p_ext_data->src_mac, ð_spec->hdr.src_addr, + RTE_ETHER_ADDR_LEN); + memcpy(&p_ext_data->dst_mac, ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); + memcpy(&p_ext_data->ether_type, + ð_spec->hdr.ether_type, + sizeof(eth_spec->hdr.ether_type)); break; case RTE_FLOW_ITEM_TYPE_IPV4: flow_type = ICE_FLTR_PTYPE_NONF_IPV4_OTHER; @@ -2108,8 +2109,8 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, if (ipv6_mask->hdr.hop_limits == UINT8_MAX) *input_set |= ICE_INSET_IPV6_HOP_LIMIT; - rte_memcpy(&p_v6->dst_ip, ipv6_spec->hdr.dst_addr, 16); - rte_memcpy(&p_v6->src_ip, ipv6_spec->hdr.src_addr, 16); + memcpy(&p_v6->dst_ip, ipv6_spec->hdr.dst_addr, 16); + memcpy(&p_v6->src_ip, ipv6_spec->hdr.src_addr, 16); vtc_flow_cpu = rte_be_to_cpu_32(ipv6_spec->hdr.vtc_flow); p_v6->tc = (uint8_t)(vtc_flow_cpu >> ICE_FDIR_IPV6_TC_OFFSET); p_v6->proto = ipv6_spec->hdr.proto; diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index 50d760004f90..9e7de43575b9 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -1969,7 +1969,7 @@ ice_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f92364153376..80b44713a9d1 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -715,7 +715,7 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad, pkt_len, ICE_BLK_RSS, true, &prof)) return -rte_errno; - rte_memcpy(&meta->raw.prof, &prof, sizeof(prof)); + memcpy(&meta->raw.prof, &prof, sizeof(prof)); rte_free(pkt_buf); rte_free(msk_buf); diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index fbab0b8808b9..a8b20ef889fc 100644 --- a/drivers/net/ice/ice_tm.c +++ b/drivers/net/ice/ice_tm.c @@ -293,8 +293,8 @@ ice_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&pf->tm_conf.shaper_profile_list, shaper_profile, node); @@ -403,8 +403,8 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->shaper_profile = shaper_profile; tm_node->children = (void *)((uint8_t *)tm_node + sizeof(struct ice_tm_node)); - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); pf->tm_conf.root = tm_node; return 0; } @@ -480,8 +480,7 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, PMD_DRV_LOG(WARNING, "weight != 1 not supported in level %d", level_id); - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); tm_node->parent->reference_count++; return 0; From patchwork Thu Feb 29 22:58:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137603 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF29543BAE; Fri, 1 Mar 2024 00:03:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9374043372; Fri, 1 Mar 2024 00:01:13 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 5F20643291 for ; Fri, 1 Mar 2024 00:00:25 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29a940614easo1097426a91.3 for ; Thu, 29 Feb 2024 15:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247624; x=1709852424; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XUHvwBLFAbLslSMTmZSKyZCQSLx2BGir5+OP+Lo8mC8=; b=Hdv7Wq1Op3Gnvoqf0KP97pouPXs//3w9TM4qwHvqrcM7woTIS/lnPx8iX1QlXlwzg5 8qdnHcu9SgD4/P4LQ4mpI7d85CmGm1E0Ypvb/MU3jjP8+q4IdIpyJHDsTZRiaCSIurji ecEE5ypbIzF+CHVgYmEiBORfgPI3cczYCbn+AxOspLpJsFBwm4pcK+n00qaL3/aQ7o/F 3zbm9wauvrDEcfVSq1HX6s4JAl5cW/964pwPxS/g7Z9yN2JbqnF+qzdOZIkOH+QWp3II PXWS+xo0PD5nI3rgiRio82NRlndfzWpN/SV/ACgry4J6fI7C0bxMmi5gPfableNVi6a6 R8rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247624; x=1709852424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUHvwBLFAbLslSMTmZSKyZCQSLx2BGir5+OP+Lo8mC8=; b=koI77cdssRQR/NwOdJdN28qW+N6rCIi4um5vIrAH3ZQhWyDdSLyR0+DPbKbBHHGKe5 xvRjUxJJs1dRouUG3riW398EU/M8qQULt4DqRgquPqJxYCu91zHHpwCZPllgSKfMekQH FGybrGhC9vYpxrnkmWGbj2OS2NXiUwAvl+FksD9PVgpvQVWkAR8qFq7ZwYMjhnvFGkLz LsdGI7SgjrvGHpOY1ma75cLOD4oY6bFZEP1D9q5V2n2HBKHe1u23I30IUg1uHsiku7VG 9s0eVu5Wvzi9KgWYWsifsYTfb6b48WpMtHJrDTI8bCMbPwh/znDpq8ganVnqMFfcXxdR 0T1A== X-Gm-Message-State: AOJu0YwezXV1TXX2BBSvMfc2/yvL3iZ7eAC7gwv3zG5W06wy6bILAFQ6 pi8D9YgYCqE7PGwFLbf+xqd3w9VH8fOzDdF4rv49jM6/2dZVkU7wH9KIjslwzWgHETcEtGNIXa/ S X-Google-Smtp-Source: AGHT+IE1PoacfrbOoeSSA6ZbBIg6a1MGrrQBjEJ3dvjdrsiJ+08iy4QZBR7lCGiibtZoxqiPG1l7hQ== X-Received: by 2002:a17:90a:e7cc:b0:29b:2179:b1df with SMTP id kb12-20020a17090ae7cc00b0029b2179b1dfmr66593pjb.0.1709247623371; Thu, 29 Feb 2024 15:00:23 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH 28/71] net/idpf: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:15 -0800 Message-ID: <20240229225936.483472-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/idpf/idpf_ethdev.c | 7 ++++--- drivers/net/idpf/idpf_rxtx.c | 10 ++++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 86151c9ec9fa..9cf33c4b7058 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -1088,8 +1088,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex) return; } - rte_memcpy(adapter->mbx_resp, ctlq_msg.ctx.indirect.payload->va, - IDPF_DFLT_MBX_BUF_SIZE); + memcpy(adapter->mbx_resp, ctlq_msg.ctx.indirect.payload->va, + IDPF_DFLT_MBX_BUF_SIZE); mbx_op = rte_le_to_cpu_16(ctlq_msg.opcode); vc_op = rte_le_to_cpu_32(ctlq_msg.cookie.mbx.chnl_opcode); @@ -1202,7 +1202,8 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); - rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&base->caps, &req_caps, + sizeof(struct virtchnl2_get_capabilities)); ret = idpf_adapter_init(base); if (ret != 0) { diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index 64f22355804e..da659e16531c 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -76,7 +76,7 @@ idpf_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t queue_idx, else ring_size = RTE_ALIGN(len * sizeof(struct idpf_base_tx_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Tx ring", sizeof("idpf Tx ring")); + memcpy(ring_name, "idpf Tx ring", sizeof("idpf Tx ring")); break; case VIRTCHNL2_QUEUE_TYPE_RX: if (splitq) @@ -85,17 +85,19 @@ idpf_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t queue_idx, else ring_size = RTE_ALIGN(len * sizeof(struct virtchnl2_singleq_rx_buf_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Rx ring", sizeof("idpf Rx ring")); + memcpy(ring_name, "idpf Rx ring", sizeof("idpf Rx ring")); break; case VIRTCHNL2_QUEUE_TYPE_TX_COMPLETION: ring_size = RTE_ALIGN(len * sizeof(struct idpf_splitq_tx_compl_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Tx compl ring", sizeof("idpf Tx compl ring")); + memcpy(ring_name, "idpf Tx compl ring", + sizeof("idpf Tx compl ring")); break; case VIRTCHNL2_QUEUE_TYPE_RX_BUFFER: ring_size = RTE_ALIGN(len * sizeof(struct virtchnl2_splitq_rx_buf_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Rx buf ring", sizeof("idpf Rx buf ring")); + memcpy(ring_name, "idpf Rx buf ring", + sizeof("idpf Rx buf ring")); break; default: PMD_INIT_LOG(ERR, "Invalid queue type"); From patchwork Thu Feb 29 22:58:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137602 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07E4443BAE; Fri, 1 Mar 2024 00:03:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A6ED4336C; Fri, 1 Mar 2024 00:01:12 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 1525D4328F for ; Fri, 1 Mar 2024 00:00:25 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-29a940614easo1097420a91.3 for ; Thu, 29 Feb 2024 15:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247624; x=1709852424; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=; b=qdAA3iJSf0kN6lRRf3OZ1XpyKBJJ/7yNhjjfszqSWsVLcjHNzyspyAXuIVEjpKz1xx X9vUPfgTxhmiEpXh4Wzv3OV11WfA3LIAVAbXEW2D8EeCnsdrSTLO+eoNueMxAWHPDrsE LewXQ2Pz/pAzvcLuTpVeKSWtiKnt0leg5XxnnTiViV3PeIkiXZTBSNXIq/+o0OFOqtKq FtZJ1XJn7WksGZtCV3AMNQ3aYUqF6o/0zsBcKqNH08+hu4HTn+RvXc4Wo1pNmbztdEY0 vixP1xaNDMcQc9w5DthJNGnisA56AMj6Zv1FE4/ll1g2BvdGKIR/Cr4FLgmC1ia6rCL8 cjyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247624; x=1709852424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=; b=ARPtUaeZyqS65eHRbflcDcAJu9PSKC/cs/Lb+glo4wUFQvMXuTYDKYAEOxMv43RE5+ GcF6t7Xw8vd8zIYhgzk7TD1w+GZ3esIoXvJHDwagffVzbVR4eaysMTQIIxPHxm+Cmvzm SdZS1CHn+RyQe+ymGsVM90LcpFEpYCQ3zGV31gNRsuvdJmiYHYkC7pHLd6EDPlgoiJz+ uOArpxNd5Ftaq7bP4dN8R550q927hXd1zyrcGOXro7lvIpMfVW0oY8BOr2YNBBExjLEw wUPp/kst6Bgs+W2vcg2hZXPHKIOGWJUKLUi117YgpwX46dlv428FtZV+7UL46RIOYA9f u27w== X-Gm-Message-State: AOJu0YxIcMP2BMt23lZOjVfIscYFUT5ulxLAFjsiwdHF9xjQAqN0T64g 8ljnCsWpsUIVPO+fFNoxQMEEogZcqXgfDNvRqeGoPPVCp2kphELmdm0ZQBEypRsbf/kaKbM/w2o q X-Google-Smtp-Source: AGHT+IGktSQuWWjzNgk0xFWucN1o5I8lcsyg5iw4+hubYb0Gv1MZDDJcB0GNwAFHZo6mT/EwMACLmw== X-Received: by 2002:a17:90a:4a89:b0:29b:9e1:2fb3 with SMTP id f9-20020a17090a4a8900b0029b09e12fb3mr37376pjh.8.1709247624197; Thu, 29 Feb 2024 15:00:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH 29/71] net/ipn3ke: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:16 -0800 Message-ID: <20240229225936.483472-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ipn3ke/ipn3ke_flow.c | 32 ++++++++++++------------- drivers/net/ipn3ke/ipn3ke_representor.c | 16 ++++++------- drivers/net/ipn3ke/ipn3ke_tm.c | 6 ++--- 3 files changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c index d20a29b9a2d6..eeb0ec55d9a6 100644 --- a/drivers/net/ipn3ke/ipn3ke_flow.c +++ b/drivers/net/ipn3ke/ipn3ke_flow.c @@ -100,15 +100,14 @@ ipn3ke_pattern_vxlan(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_ETH: eth = item->spec; - rte_memcpy(&parser->key[0], - eth->hdr.src_addr.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(&parser->key[0], eth->hdr.src_addr.addr_bytes, + RTE_ETHER_ADDR_LEN); break; case RTE_FLOW_ITEM_TYPE_VXLAN: vxlan = item->spec; - rte_memcpy(&parser->key[6], vxlan->hdr.vni, 3); + memcpy(&parser->key[6], vxlan->hdr.vni, 3); break; default: @@ -164,9 +163,8 @@ ipn3ke_pattern_mac(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_ETH: eth = item->spec; - rte_memcpy(parser->key, - eth->hdr.src_addr.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(parser->key, eth->hdr.src_addr.addr_bytes, + RTE_ETHER_ADDR_LEN); break; default: @@ -369,13 +367,13 @@ ipn3ke_pattern_ip_tcp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_TCP: tcp = item->spec; - rte_memcpy(&parser->key[4], &tcp->hdr.src_port, 2); + memcpy(&parser->key[4], &tcp->hdr.src_port, 2); break; default: @@ -434,13 +432,13 @@ ipn3ke_pattern_ip_udp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2); + memcpy(&parser->key[4], &udp->hdr.src_port, 2); break; default: @@ -502,19 +500,19 @@ ipn3ke_pattern_ip_nvgre(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2); + memcpy(&parser->key[4], &udp->hdr.src_port, 2); break; case RTE_FLOW_ITEM_TYPE_NVGRE: nvgre = item->spec; - rte_memcpy(&parser->key[6], nvgre->tni, 3); + memcpy(&parser->key[6], nvgre->tni, 3); break; default: @@ -576,19 +574,19 @@ ipn3ke_pattern_vxlan_ip_udp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_VXLAN: vxlan = item->spec; - rte_memcpy(&parser->key[0], vxlan->hdr.vni, 3); + memcpy(&parser->key[0], vxlan->hdr.vni, 3); break; case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[7], &udp->hdr.src_port, 2); + memcpy(&parser->key[7], &udp->hdr.src_port, 2); break; default: diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c index 8145f1bb2a0e..99527d18793a 100644 --- a/drivers/net/ipn3ke/ipn3ke_representor.c +++ b/drivers/net/ipn3ke/ipn3ke_representor.c @@ -137,17 +137,17 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev) if (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) { /* Set mac address */ - rte_memcpy(((char *)(&val)), - (char *)&dev->data->mac_addrs->addr_bytes[0], - sizeof(uint32_t)); + memcpy(((char *)(&val)), + (char *)&dev->data->mac_addrs->addr_bytes[0], + sizeof(uint32_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, rpst->port_id, 0); - rte_memcpy(((char *)(&val)), - (char *)&dev->data->mac_addrs->addr_bytes[4], - sizeof(uint16_t)); + memcpy(((char *)(&val)), + (char *)&dev->data->mac_addrs->addr_bytes[4], + sizeof(uint16_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR1, @@ -2753,13 +2753,13 @@ ipn3ke_rpst_mac_addr_set(struct rte_eth_dev *ethdev, rte_ether_addr_copy(&mac_addr[0], &rpst->mac_addr); /* Set mac address */ - rte_memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t)); + memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, rpst->port_id, 0); - rte_memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t)); + memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c index 0260227900ae..b7097083d2d6 100644 --- a/drivers/net/ipn3ke/ipn3ke_tm.c +++ b/drivers/net/ipn3ke/ipn3ke_tm.c @@ -814,7 +814,7 @@ ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev, rte_strerror(EINVAL)); } else { sp->valid = 1; - rte_memcpy(&sp->params, profile, sizeof(sp->params)); + memcpy(&sp->params, profile, sizeof(sp->params)); } tm->h.n_shaper_profiles++; @@ -960,7 +960,7 @@ ipn3ke_tm_tdrop_profile_add(struct rte_eth_dev *dev, IPN3KE_TDROP_TH2_MASK); tp->th1 = th1; tp->th2 = th2; - rte_memcpy(&tp->params, profile, sizeof(tp->params)); + memcpy(&tp->params, profile, sizeof(tp->params)); /* Add to list */ tm->h.n_tdrop_profiles++; @@ -1308,7 +1308,7 @@ ipn3ke_tm_node_add(struct rte_eth_dev *dev, n->tdrop_profile = ipn3ke_hw_tm_tdrop_profile_search(hw, params->leaf.wred.wred_profile_id); - rte_memcpy(&n->params, params, sizeof(n->params)); + memcpy(&n->params, params, sizeof(n->params)); return 0; } From patchwork Thu Feb 29 22:58:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137604 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2406743BAE; Fri, 1 Mar 2024 00:03:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9F2843376; Fri, 1 Mar 2024 00:01:14 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id F35B84328F for ; Fri, 1 Mar 2024 00:00:25 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2995fa850ddso2124623a91.0 for ; Thu, 29 Feb 2024 15:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247625; x=1709852425; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dVdYzFeS6R1f2Mr8BG/pwkFEeBvBuT7tMok+utry1kk=; b=XzHxU39DxpkdddTEluIgyl4SQ4vEaS06ARuwbT1CqsIaDkXgSkxzLmdcv3dmT3pNJj zBSKJ+REBu6ia3Bdffw+vGTPCD1x2r38lRBRuOexL0X9vnfDC0YO9w9DYKMkV5tMdjrJ w4Z8A/B0tHCxEDYxGjlL/0Af46DVF6m5WZF8+xyLHdkNaoT0xGkmGGeCDZ7aRlv/OdX1 2tS8ZztBzzfspHtJrZ3Z7wzxA6ADJUBDyiWs5KmSG+cNQ5ACfJjVVRgBOytHgyqlm532 BIfsXcCBFU8NlerziqxTHwU6yKzrG3uusxO7KlIyYFrIZbUFB3nUg1ycIMwlLtPfN9d3 QMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247625; x=1709852425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dVdYzFeS6R1f2Mr8BG/pwkFEeBvBuT7tMok+utry1kk=; b=LZ9CmowolS4BxnP3fRIQNAqFKI+kuyqxXOXbQ8RJvkFMJC2ikwwI5iMNITBY/odtOJ ym35EH4LE62JhWpqwq23HIlC70rFq5b5rgZPtCkf8fmZEGgC7N+Y9oV7Nkwl8z/0W9jU uNuLBOtY4knY11q0GHWdJfKRMBLrX+1sXsAXeOxppbDSiTvOnLryb/gBxpbSR/6nJmjs oxU5SKvNgVrbHJ+MwjFmfS0sIM+adakIirhOIh+jEZe4cxeAWycxKWcb6LX5lTQmvFi7 d8B/I2kdXzywEOp5+QpNDtgY5VAveG7qrPYDNE63Iov9s+Gn5sq/8tcYc9xK1V1uUqDm 4PUQ== X-Gm-Message-State: AOJu0YzWZTTyFYcj3BswGGp8m9YxBU83k2J54x9Vs8c5zxKOJ5zW7qfd BsrZBUN14OqrejqsEdbp15QDbRiTUgpSzqLmKaTbAAlxKiqwgno1J626Fvs/bTkFS/bnBA3h/cU f X-Google-Smtp-Source: AGHT+IHgqNjP9i0vLjzv29GUqGB8yE1z6SUoYKsoB8ta6p70+x5fuJbFkbNXeF3AarIGg7ksAVhh4Q== X-Received: by 2002:a17:90a:d17:b0:299:43fd:e967 with SMTP id t23-20020a17090a0d1700b0029943fde967mr425195pja.18.1709247625004; Thu, 29 Feb 2024 15:00:25 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 30/71] net/ixgbe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:17 -0800 Message-ID: <20240229225936.483472-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++--- drivers/net/ixgbe/ixgbe_fdir.c | 7 ++-- drivers/net/ixgbe/ixgbe_flow.c | 65 ++++++++++++++----------------- drivers/net/ixgbe/ixgbe_ipsec.c | 8 ++-- drivers/net/ixgbe/ixgbe_pf.c | 4 +- drivers/net/ixgbe/ixgbe_tm.c | 11 +++--- drivers/net/ixgbe/rte_pmd_ixgbe.c | 4 +- 7 files changed, 48 insertions(+), 60 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 0cd3d0b105f4..6040cac9a896 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -6597,9 +6597,8 @@ ixgbe_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct ixgbe_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, - &filter_5tuple, - sizeof(struct ixgbe_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct ixgbe_5tuple_filter_info)); filter->queue = ntuple_filter->queue; ret = ixgbe_add_5tuple_filter(dev, filter); if (ret < 0) { @@ -7596,9 +7595,7 @@ ixgbe_dev_l2_tunnel_filter_add(struct rte_eth_dev *dev, if (!node) return -ENOMEM; - rte_memcpy(&node->key, - &key, - sizeof(struct ixgbe_l2_tn_key)); + memcpy(&node->key, &key, sizeof(struct ixgbe_l2_tn_key)); node->pool = l2_tunnel->pool; ret = ixgbe_insert_l2_tn_filter(l2_tn_info, node); if (ret < 0) { diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c index 06d6e2126de5..b168ab82781b 100644 --- a/drivers/net/ixgbe/ixgbe_fdir.c +++ b/drivers/net/ixgbe/ixgbe_fdir.c @@ -74,7 +74,7 @@ else \ ipv6_addr[i] = 0; \ } \ - rte_memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ + memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ } while (0) #define IXGBE_FDIRIP6M_INNER_MAC_SHIFT 4 @@ -1217,9 +1217,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, 0); if (!node) return -ENOMEM; - rte_memcpy(&node->ixgbe_fdir, - &rule->ixgbe_fdir, - sizeof(union ixgbe_atr_input)); + memcpy(&node->ixgbe_fdir, &rule->ixgbe_fdir, + sizeof(union ixgbe_atr_input)); node->fdirflags = fdircmd_flags; node->fdirhash = fdirhash; node->queue = queue; diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 687341c6b8d3..8a13f47f2b8c 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -1944,10 +1944,10 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev, if (item->spec) { rule->b_spec = TRUE; ipv6_spec = item->spec; - rte_memcpy(rule->ixgbe_fdir.formatted.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(rule->ixgbe_fdir.formatted.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->ixgbe_fdir.formatted.src_ip, + ipv6_spec->hdr.src_addr, 16); + memcpy(rule->ixgbe_fdir.formatted.dst_ip, + ipv6_spec->hdr.dst_addr, 16); } /** @@ -3070,9 +3070,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -3096,9 +3096,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -3120,9 +3120,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&filter_syn_list, syn_filter_ptr, entries); @@ -3141,9 +3140,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct ixgbe_hw_fdir_mask)); + memcpy(&fdir_info->mask, &fdir_rule.mask, + sizeof(struct ixgbe_hw_fdir_mask)); if (fdir_rule.mask.flex_bytes_mask) { ret = ixgbe_fdir_set_flexbytes_offset(dev, @@ -3185,9 +3183,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, - &fdir_rule, - sizeof(struct ixgbe_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, + &fdir_rule, + sizeof(struct ixgbe_fdir_rule)); TAILQ_INSERT_TAIL(&filter_fdir_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -3222,9 +3220,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&l2_tn_filter_ptr->filter_info, - &l2_tn_filter, - sizeof(struct ixgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter_ptr->filter_info, &l2_tn_filter, + sizeof(struct ixgbe_l2_tunnel_conf)); TAILQ_INSERT_TAIL(&filter_l2_tunnel_list, l2_tn_filter_ptr, entries); flow->rule = l2_tn_filter_ptr; @@ -3351,9 +3348,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct ixgbe_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, - &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = ixgbe_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_ntuple_list, @@ -3364,9 +3360,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct ixgbe_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = ixgbe_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3378,9 +3373,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_SYN: syn_filter_ptr = (struct ixgbe_eth_syn_filter_ele *) pmd_flow->rule; - rte_memcpy(&syn_filter, - &syn_filter_ptr->filter_info, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter, &syn_filter_ptr->filter_info, + sizeof(struct rte_eth_syn_filter)); ret = ixgbe_syn_filter_set(dev, &syn_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_syn_list, @@ -3390,9 +3384,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct ixgbe_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct ixgbe_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct ixgbe_fdir_rule)); ret = ixgbe_fdir_filter_program(dev, &fdir_rule, TRUE, FALSE); if (!ret) { TAILQ_REMOVE(&filter_fdir_list, @@ -3405,8 +3398,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_L2_TUNNEL: l2_tn_filter_ptr = (struct ixgbe_eth_l2_tunnel_conf_ele *) pmd_flow->rule; - rte_memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, - sizeof(struct ixgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, + sizeof(struct ixgbe_l2_tunnel_conf)); ret = ixgbe_dev_l2_tunnel_filter_del(dev, &l2_tn_filter); if (!ret) { TAILQ_REMOVE(&filter_l2_tunnel_list, diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index d3313085560d..d8ed095dce0c 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -680,10 +680,10 @@ ixgbe_crypto_add_ingress_sa_from_flow(const void *sess, const struct rte_flow_item_ipv6 *ipv6 = ip_spec; ic_session->src_ip.type = IPv6; ic_session->dst_ip.type = IPv6; - rte_memcpy(ic_session->src_ip.ipv6, - ipv6->hdr.src_addr, 16); - rte_memcpy(ic_session->dst_ip.ipv6, - ipv6->hdr.dst_addr, 16); + memcpy(ic_session->src_ip.ipv6, ipv6->hdr.src_addr, + 16); + memcpy(ic_session->dst_ip.ipv6, ipv6->hdr.dst_addr, + 16); } else { const struct rte_flow_item_ipv4 *ipv4 = ip_spec; ic_session->src_ip.type = IPv4; diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 0a0f639e3986..9836d05540a3 100644 --- a/drivers/net/ixgbe/ixgbe_pf.c +++ b/drivers/net/ixgbe/ixgbe_pf.c @@ -450,7 +450,7 @@ ixgbe_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -472,7 +472,7 @@ ixgbe_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) if (rte_is_valid_assigned_ether_addr( (struct rte_ether_addr *)new_mac)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.ops.set_rar(hw, rar_entry, new_mac, vf, IXGBE_RAH_AV); } return -1; diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index ac8976062fa7..00d9de43936b 100644 --- a/drivers/net/ixgbe/ixgbe_tm.c +++ b/drivers/net/ixgbe/ixgbe_tm.c @@ -289,8 +289,8 @@ ixgbe_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&tm_conf->shaper_profile_list, shaper_profile, node); @@ -637,8 +637,8 @@ ixgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->no = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); tm_conf->root = tm_node; /* increase the reference counter of the shaper profile */ @@ -718,8 +718,7 @@ ixgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == IXGBE_TM_NODE_TYPE_PORT) { tm_node->no = parent_node->reference_count; TAILQ_INSERT_TAIL(&tm_conf->tc_list, diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c index f76ef6392194..ba700fe02313 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c @@ -37,8 +37,8 @@ rte_pmd_ixgbe_set_vf_mac_addr(uint16_t port, uint16_t vf, if (rte_is_valid_assigned_ether_addr( (struct rte_ether_addr *)new_mac)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, - RTE_ETHER_ADDR_LEN); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, + RTE_ETHER_ADDR_LEN); return hw->mac.ops.set_rar(hw, rar_entry, new_mac, vf, IXGBE_RAH_AV); } From patchwork Thu Feb 29 22:58:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137605 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4256443BAE; Fri, 1 Mar 2024 00:04:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 355F84337D; Fri, 1 Mar 2024 00:01:16 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id BB03D432A4 for ; Fri, 1 Mar 2024 00:00:26 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-299a2456948so1154472a91.1 for ; Thu, 29 Feb 2024 15:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247626; x=1709852426; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U14p3o16DPpdZQJaoD/yjieBVV9R77lJfaIzC2sPjsE=; b=YusOYQ+CDbEfSqQDQSqaWf6Ix2dyxvK1fm/9+RLeduEH4Ypwg1FaBY4zT30XHLJv/D GztrOIOBzo0JZXnTrmtZbfK9BOLPcQQ5s3EBSMM8BwbJRtT8Hmb22jQlBYEGZLKsnM5S Cq7TJyF+M8ZnItEdYwx7h6uRuFJx6RcQY3jdasaUttrUnkSuEVOsIzcxn1A8YHVopXQo C6SQQQF19bCVcA5E6IrBY4zqZWmfqY3Vt4XWE+apsuYvumr+G7vLVcD3ar5le9k338WS wLbg1Wpmxd7hYFVi5G4vvgIyF7R6UCc5MUZLVIyYxRTt1Ae+GXC0B3uYyGERIsX/QxWS bMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247626; x=1709852426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U14p3o16DPpdZQJaoD/yjieBVV9R77lJfaIzC2sPjsE=; b=aSnheznWRIs8ozU+J9cFtDvjRGJRCXnG0U0fPVxtquaU8U1ThQ79L9Os46UbOHS5C5 R5lpYIJ3KLRevP0TLhaUvEhWumtu301+ILrZwkVJrIl93hrP8YblNyHZyKWdLFdpqt9z 2E/ZNLz8zzBSG2ejOo9fGCGyGTWu/R2lWxa685sCpEX8MFKfe4SK6QL68IffrquGECoS PMkOR8G23nIuGllMTsCl3J9QvqXLS2NeBY72S807KEQvdbyY+03HXIL/+GHBzdDbsdNF IH3UgQpHxYDCVpOXckS5kOR/x28fmYXoUCe5XAT/fcg/slEXNfVqD7Hp9lPSvMCDzM7O uluQ== X-Gm-Message-State: AOJu0YxRjuUTY3CC5n8j0dN7oVjqvhmMdFp2RW5tDvELsjHJoNuM3g4N A0KGXa1nfSvqKf9es1FwELUV+oF8JryGJMKQxFuCDFqn+GYvAyYdt8pn2F69Jl0pKUq+55VmN76 y X-Google-Smtp-Source: AGHT+IEfVseheOZ+kjDVpTwYCJwtG7Pv1HzM7PdzP+Tv/n32tOzMOWCm7z7IKeK40uXXN5depMACJw== X-Received: by 2002:a17:90b:1214:b0:29b:23bc:19a5 with SMTP id gl20-20020a17090b121400b0029b23bc19a5mr33812pjb.26.1709247625769; Thu, 29 Feb 2024 15:00:25 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Grajciar Subject: [PATCH 31/71] net/memif: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:18 -0800 Message-ID: <20240229225936.483472-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/memif_socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 649f8d0e618f..f5a3354c4652 100644 --- a/drivers/net/memif/memif_socket.c +++ b/drivers/net/memif/memif_socket.c @@ -48,7 +48,7 @@ memif_msg_send(int fd, memif_msg_t *msg, int afd) cmsg->cmsg_len = CMSG_LEN(sizeof(int)); cmsg->cmsg_level = SOL_SOCKET; cmsg->cmsg_type = SCM_RIGHTS; - rte_memcpy(CMSG_DATA(cmsg), &afd, sizeof(int)); + memcpy(CMSG_DATA(cmsg), &afd, sizeof(int)); } return sendmsg(fd, &mh, 0); @@ -675,7 +675,7 @@ memif_msg_receive(struct memif_control_channel *cc) if (cmsg->cmsg_type == SCM_CREDENTIALS) cr = (struct ucred *)CMSG_DATA(cmsg); else if (cmsg->cmsg_type == SCM_RIGHTS) - rte_memcpy(&afd, CMSG_DATA(cmsg), sizeof(int)); + memcpy(&afd, CMSG_DATA(cmsg), sizeof(int)); } cmsg = CMSG_NXTHDR(&mh, cmsg); } From patchwork Thu Feb 29 22:58:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137606 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8862C43BAE; Fri, 1 Mar 2024 00:04:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88FCB4337F; Fri, 1 Mar 2024 00:01:17 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 70D82432A4 for ; Fri, 1 Mar 2024 00:00:27 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-29954bb87b4so1078691a91.2 for ; Thu, 29 Feb 2024 15:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247626; x=1709852426; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=teUGuCMa5oE2y6ygxjJUYiCErkP2+/WR1Ef3UB62su4=; b=cKeVN+Bk0TL9LFAFZNzupuWpFN0Q5kI3rWkvfbDWAsSr1cfMMSXhctg6YYKOvQrnfh NxRP9Tl79l9Zp5oUb6tfHYoLJHHfuU0jD5iyHdwuBbQ1S0TBWZwAj/F0WQVlNlf7GXcF P9GamSlCCFFUT85t5kxuosgJbk8ATD+3KGd5ojD4XYLI1i0yfRuTIam/ClFqRENwW8q7 rTSI6ku102CF6m0/8D/gHfiJS2KPYdOM/Uf2T75apQsj49n3pXnvQ3xfm8bgWVHMQa1U 9oKRZ0xyd5q+J5EJZNykzo971wWTridbpoNb8pd5i875VmRZrSkXm4kfDygK87Tvg4Fr 8LUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247626; x=1709852426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teUGuCMa5oE2y6ygxjJUYiCErkP2+/WR1Ef3UB62su4=; b=l8DL9yA7ZhyBYLyJnLhu7yffl0EYHD93n5aOU31BkBQygnXjIkHsIMv1upHHqDj+AC aey8liV7MjovkAW1YImUI2cedhxcANbDwVuj9WkoPdInBxd999V+f5LTIJKEEtFVdEpk ofHN6RGUIsYwD0QrYLK8SShjoOXYVxxzIUnv/P6nBGrrDaA1lSOJJBtpi82Gvx1OO73p APKpJFg3Pv0dNq1ihakIV5n4XBIvG3jwu2dX2fbr6HopMIKsrRtx/TKqvN0wpWQezWUi 82mqvkUJ8c70fSIdBSuLB8xPnQBzwpYayJ1auHnWWWOuSC4RxjxKixFslAPzTdsAUXl8 GTzA== X-Gm-Message-State: AOJu0YxSgMyjKxsw7rI5+dyYgaf67gEaZxSra+mP1aSOxA4zJj2HZ+4k Mm0dATzkwlC0D7NxDKYBuLdjEZtDwhJbC+ghhb9xbeTOMX7Un0n5ni4vE1FfA/Nup2dUlUy8acv d X-Google-Smtp-Source: AGHT+IGphKZByAUekhoPYICcuIgADHF3BW3h25E9rvwP9QOUZEhVdTblfy+NTvWHdF7CNULmnlLgRQ== X-Received: by 2002:a17:90a:a618:b0:29a:795:a132 with SMTP id c24-20020a17090aa61800b0029a0795a132mr37666pjq.18.1709247626492; Thu, 29 Feb 2024 15:00:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Devendra Singh Rawat , Alok Prasad Subject: [PATCH 32/71] net/qede: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:19 -0800 Message-ID: <20240229225936.483472-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index fd63262f3a47..32fa2016d260 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -180,7 +180,7 @@ static void qed_handle_bulletin_change(struct ecore_hwfn *hwfn) is_mac_exist = ecore_vf_bulletin_get_forced_mac(hwfn, mac, &is_mac_forced); if (is_mac_exist && is_mac_forced) - rte_memcpy(hwfn->hw_info.hw_mac_addr, mac, ETH_ALEN); + memcpy(hwfn->hw_info.hw_mac_addr, mac, ETH_ALEN); /* Always update link configuration according to bulletin */ qed_link_update(hwfn); From patchwork Thu Feb 29 22:58:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137607 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0201943BAE; Fri, 1 Mar 2024 00:04:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDD4D432A0; Fri, 1 Mar 2024 00:01:18 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 6D143432A4 for ; Fri, 1 Mar 2024 00:00:28 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29aa8c4710bso1170550a91.1 for ; Thu, 29 Feb 2024 15:00:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247627; x=1709852427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pqtp6rRq/Z9SMHLL8eL6a3sxNrgwAaRmf0Fh/Pk+3GA=; b=tJYp7gQB5Z4PWrEbrfUNFk0Tp9lg8GmA75Nngq8yPCutZ+q1B74PCZq0BkW1XRCsHs 3gwvwQCGyB8n9yEROM3ZuT66u+/n8Xl9g65tovlsvgm0MXp5sK+VhyATZzgEjl/37Vsb 01LNAjpmX71DAJuhN0cK0GqUIaTinzCUSnBE2NIc+2w6PoACdul2FvRIznRjqNnw1T12 qgkMAsQGkIcckyAxtOcX7dZqXPsbCV/Co3TdqLuNOGUvoiRNbwhiMq4om+zLknsBvgW4 4W45GQVXHLizZuXVpmsxT9+Iljx7ruZOdD0RJCciLLQZRwPAVtHD/Dga4Tra/yVOc/wF zSPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247627; x=1709852427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pqtp6rRq/Z9SMHLL8eL6a3sxNrgwAaRmf0Fh/Pk+3GA=; b=oTJI1dMXlZTtf98pbYI5pIx1UUjZ6mynX94R4CH2o1hm6n1d4Koa310ZfCKOFYHaoh gf5gmAxZM3dR0c4Msilx9Jbw/RJKw3HSZydRouzndmvxp/r/JcqdZpQxeTKPtXkn78W+ 69VqiDvfjE0zcbiaSMQvfnNq2m0qzXVMLeMR9krcbeZQUWWPAnwFnRblcNfRb7h8FDR1 7dUbaIdHQlg/6YrXuTe+XQLPF+KG8Xo/dZTp5FNAapByAKRrj90BzhSG//5U1cf4GdFZ 1CzEz9u6gCbRs2XZFmuU/2FZflzbg41uuoa4mAT3BSwqPO7MoCuchzj6KOVoxur2Hq3r 1J6Q== X-Gm-Message-State: AOJu0YwDPLPLk3q1NJYsbkcYQOmDi0Kz8MPBQNN3aTF787F1aMhpRcq4 E8ZOBY6w3bNCiM1ibDGQnP7KJE3Ea11ofFfT2tg9uGj5TPtDDsOdL5YX2xSMKjrxhrCtFc2FeGq n X-Google-Smtp-Source: AGHT+IHyKp8dOXzE69er75kh+W6QS2HS5zAl6jmE4njCmlLfERNE4HesIGqsTTo/NAIaF32Bb/BPqw== X-Received: by 2002:a17:90a:bf05:b0:29b:12ba:d470 with SMTP id c5-20020a17090abf0500b0029b12bad470mr496320pjs.14.1709247627630; Thu, 29 Feb 2024 15:00:27 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH 33/71] baseband/acc: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:20 -0800 Message-ID: <20240229225936.483472-34-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 19 +++++++++---------- drivers/baseband/acc/rte_vrb_pmd.c | 21 ++++++++++----------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 292537e24dc9..8bc0ce9d5532 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -3102,15 +3102,13 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, uint8_t *prev_ptr = (uint8_t *) prev_desc; uint8_t *new_ptr = (uint8_t *) desc; /* Copy first 4 words and BDESCs */ - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0, - prev_ptr + ACC_5GUL_OFFSET_0, - ACC_5GUL_SIZE_1); + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); + memcpy(new_ptr + ACC_5GUL_OFFSET_0, + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1); desc->req.op_addr = prev_desc->req.op_addr; /* Copy FCW */ - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET, - prev_ptr + ACC_DESC_FCW_OFFSET, - ACC_FCW_LD_BLEN); + memcpy(new_ptr + ACC_DESC_FCW_OFFSET, + prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN); acc100_dma_desc_ld_update(op, &desc->req, input, h_output, &in_offset, &h_out_offset, &h_out_length, harq_layout); @@ -3257,7 +3255,8 @@ enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op, desc = acc_desc(q, total_enqueued_cbs); desc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset; desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN; - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN); + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, + ACC_FCW_LD_BLEN); ret = acc100_dma_desc_ld_fill(op, &desc->req, &input, h_output, &in_offset, &h_out_offset, &h_out_length, @@ -4560,7 +4559,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); value = acc_reg_read(d, HwPfPcieGpexBridgeControl); bool firstCfg = (value != ACC100_CFG_PCI_BRIDGE); @@ -4955,7 +4954,7 @@ acc101_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); /* PCIe Bridge configuration */ acc_reg_write(d, HwPfPcieGpexBridgeControl, ACC101_CFG_PCI_BRIDGE); diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c index 686e086a5c5c..72f6bff16081 100644 --- a/drivers/baseband/acc/rte_vrb_pmd.c +++ b/drivers/baseband/acc/rte_vrb_pmd.c @@ -2450,15 +2450,13 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, uint8_t *prev_ptr = (uint8_t *) prev_desc; uint8_t *new_ptr = (uint8_t *) desc; /* Copy first 4 words and BDESCs. */ - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0, - prev_ptr + ACC_5GUL_OFFSET_0, - ACC_5GUL_SIZE_1); + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); + memcpy(new_ptr + ACC_5GUL_OFFSET_0, + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1); desc->req.op_addr = prev_desc->req.op_addr; /* Copy FCW. */ - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET, - prev_ptr + ACC_DESC_FCW_OFFSET, - ACC_FCW_LD_BLEN); + memcpy(new_ptr + ACC_DESC_FCW_OFFSET, + prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN); vrb_dma_desc_ld_update(op, &desc->req, input, h_output, &in_offset, &h_out_offset, &h_out_length, harq_layout); @@ -2566,7 +2564,8 @@ vrb_enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op, fcw_offset = (desc_idx << 8) + ACC_DESC_FCW_OFFSET; desc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset; desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN; - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN); + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, + ACC_FCW_LD_BLEN); desc->req.fcw_ld.tb_trailer_size = (c - r - 1) * trail_len; ret = vrb_dma_desc_ld_fill(op, &desc->req, &input, h_output, &in_offset, &h_out_offset, @@ -4041,7 +4040,7 @@ enqueue_mldts_split_op(struct acc_queue *q, struct rte_bbdev_mldts_op *op, if (symb == 0) desc->req.cbs_in_tb = num_syms; else - rte_memcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN); + memcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN); desc->req.data_ptrs[1].address = rte_pktmbuf_iova_offset(input_q, in_offset); desc->req.data_ptrs[1].blen = q_size; in_offset += q_size; @@ -4396,7 +4395,7 @@ vrb1_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration. */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); /* Check we are already out of PG. */ status = acc_reg_read(d, VRB1_PfHiSectionPowerGatingAck); @@ -4803,7 +4802,7 @@ vrb2_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration. */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); /* Explicitly releasing AXI as this may be stopped after PF FLR/BME. */ address = VRB2_PfDmaAxiControl; From patchwork Thu Feb 29 22:58:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137608 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA0A943BAE; Fri, 1 Mar 2024 00:04:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 600F14338A; Fri, 1 Mar 2024 00:01:20 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 4A7AB432BA for ; Fri, 1 Mar 2024 00:00:29 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29aa8c4710bso1170558a91.1 for ; Thu, 29 Feb 2024 15:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247628; x=1709852428; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Orm/qFRDO0ClXKFHxnQCXc+zrpbQfCCDz7is4dR9wn8=; b=hNByY0ZeiEgAdnprSb/4F6P/Cx3STSAclOgQE1DocyEQqa0mYl/ooANVfbpt1EoyDg CdQ808g4DtMvBvFYkWqSki4ldPhBqRV0CwXQHriwiT11k8+jdc9kgUo1sCDTq+QkaqnB PZkAKfaVi3J25YCX5w1xboLJi3JHfjc1PPJWsYAhWaXR6VOAfQqtWi/xsz78ZZ50Ypxh cYCAz/StSkkROCtWiLDpFGHsMzgyx301qTKbk/BSfE9s5av6IDO/H7mpmPES7GGkKD7r 7/rYuumZTym+riK1VmFlhs4lsBHYW2hoQXe1V0WQJIWI1wuC5J5lfEatL9zsBwnsSefM V3LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247628; x=1709852428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Orm/qFRDO0ClXKFHxnQCXc+zrpbQfCCDz7is4dR9wn8=; b=Ce4UG+BVNlmeZ1+4IEmibnsXSvLU5k+Xna1QsiRVFIR0NghGwUZqTO6KoXVzXwZ+w2 aoIJxab6Ht3xPtbmNwq9LE0t6vVchFheNtWoR5YPPR9EHc/kFyOlYOVxfFYr1gfDxKYT 2MyWsa9FsGZdBA8EkdN7s/dHv6HF/WfckfybJYQHVvKBiZO55/AmxibxYQDESG3wkTld M8TbCkIwujJ57y9lZJKnYFC/qZzbXEDafIpxMXyPOqG25rBBChD1n15nJAePURO9Rmce upbP5fyBBG7DCQJup7CliHm8wTQ2gAkW9blhPhGzhUbu/JykVTsMmi65U8/R1thh/+aA GfhQ== X-Gm-Message-State: AOJu0YwLwjgvgk965NlgUHarvdzyj/LUqfPs1p4kLbFJ0guwrx/ANYc2 QEdlebZ7O+cCNpDlBWXorob+nUszWELRRZhIe36uiM15tud5XfZ7Ho2YXQBfPEtRbV+zcqOQQbO w X-Google-Smtp-Source: AGHT+IGVELTvW6ISEjTkLF5pBVbOqKZ6nq11xj3HMgW49hTh/xPbJaxRre9vyTfsDATjv1ViaRwxpw== X-Received: by 2002:a17:90a:4491:b0:299:3c2c:b680 with SMTP id t17-20020a17090a449100b002993c2cb680mr490242pjg.15.1709247628547; Thu, 29 Feb 2024 15:00:28 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 34/71] baseband/la12xx: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:21 -0800 Message-ID: <20240229225936.483472-35-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index bb754a539580..23e2fdb81116 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -597,8 +597,8 @@ dequeue_single_op(struct bbdev_la12xx_q_priv *q_priv, void *dst) op = q_priv->bbdev_op[ci]; - rte_memcpy(dst, q_priv->msg_ch_vaddr[ci], - sizeof(struct bbdev_ipc_enqueue_op)); + memcpy(dst, q_priv->msg_ch_vaddr[ci], + sizeof(struct bbdev_ipc_enqueue_op)); /* Move Consumer Index forward */ ci++; From patchwork Thu Feb 29 22:58:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137609 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17BD043BAE; Fri, 1 Mar 2024 00:04:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4B8843390; Fri, 1 Mar 2024 00:01:21 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 40BF6432BC for ; Fri, 1 Mar 2024 00:00:30 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5d4a1e66750so1082186a12.0 for ; Thu, 29 Feb 2024 15:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247629; x=1709852429; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKo3GX8T9YEP25rIsWFSPZg4wU3SDSgtwfmRWuCrJao=; b=VFIJQE2dk1uyhDsVT8rsQt/b9mldUSEUePND4d4k8f2UKv0ntFyu/+KyEHWEAEyHz2 6XgHUv2tvukafsbPfbmbV0lzQv9MVjGNtmvHdXY7vEYfk9PCFYzMM4uazjFOVFHBe1ME dbcjEKH7yY+1hl2u5EIQ1eBvToNS+yQrDumb1yjZpEEK1BKcfDSL94lpStQ/ZIJ5SeRk NCIwM3RjyZKM+4Z2M1j4ubLFqiCa5IGnWt99IuVP8X7ftKedEKbmm4omJrMDyvq2yYPJ A+N1cpy4n/p8SY6SOdSGjkUNsafOsr8EF4tclhgC8WJQ2ojF0WSQnVX2xQGFis/ppQiz JXww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247629; x=1709852429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKo3GX8T9YEP25rIsWFSPZg4wU3SDSgtwfmRWuCrJao=; b=fvBesukhzUFOXo/Bv87ha6a3yro+VeT2w3dWoyZQFixpp1R+w2ZZ/rqO5gw6E1D5gM rFHP+qWCunTr5w02D8ysI0f7So529LtqhKOq+nlpVYJ1pxUl/gbqP4WHSp2rsF6pbVJF CCXdXG3rvLNMAHPaR7Rlgb6mHm0/ytnMICaGfXjBoUDYOXDWcEL2/WgFMsTA+BfzTV5b J/ltpJrRU3N6xOPKxhwfaZJDvl8Qur/EixXYEAsZWBwGtABtC9IQfDrTo+HlaOnzUrfg b4Ie46y9SNLwdRNVnZIgrf94VbpLAQ7Y412bolbtqasCcAI5OYdkWbEUYO4xoG8bkBcH 4r/w== X-Gm-Message-State: AOJu0YzhvfuUuIDLDqIg1uvT0CwzFbMOhFDXsB2+fXiYjakE5BYAj0h8 mj62ixsqhQiPpRMwqIl9DXR/EQmjsi96iwn7kmupEkCfl5oiPV1DW19LbgqU+ZkzXUK0OCyFqOU Q X-Google-Smtp-Source: AGHT+IFQ9Soj06aaBm1ZYod5wv04pWc4aVSDJT0hegLmxCm6TDZZk+LNDbGHXOksTh8oI8ZVS3T05w== X-Received: by 2002:a05:6a20:8d07:b0:1a0:cd54:6d9f with SMTP id q7-20020a056a208d0700b001a0cd546d9fmr2931451pzi.23.1709247629349; Thu, 29 Feb 2024 15:00:29 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH 35/71] common/idpf: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:22 -0800 Message-ID: <20240229225936.483472-36-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_virtchnl.c | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c index cc4207a46e5e..2cb66371c4bd 100644 --- a/drivers/common/idpf/idpf_common_device.c +++ b/drivers/common/idpf/idpf_common_device.c @@ -459,8 +459,8 @@ idpf_vport_init(struct idpf_vport *vport, vport->num_rx_q = vport_info->num_rx_q; vport->num_rx_bufq = vport_info->num_rx_bufq; vport->max_mtu = vport_info->max_mtu; - rte_memcpy(vport->default_mac_addr, - vport_info->default_mac_addr, ETH_ALEN); + memcpy(vport->default_mac_addr, vport_info->default_mac_addr, + ETH_ALEN); vport->rss_algorithm = vport_info->rss_algorithm; vport->rss_key_size = RTE_MIN(IDPF_RSS_KEY_LEN, vport_info->rss_key_size); diff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c index 6455f640da25..96232c29d64f 100644 --- a/drivers/common/idpf/idpf_common_virtchnl.c +++ b/drivers/common/idpf/idpf_common_virtchnl.c @@ -294,7 +294,8 @@ idpf_vc_caps_get(struct idpf_adapter *adapter) return err; } - rte_memcpy(&adapter->caps, args.out_buffer, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&adapter->caps, args.out_buffer, + sizeof(struct virtchnl2_get_capabilities)); return 0; } @@ -331,7 +332,8 @@ idpf_vc_vport_create(struct idpf_vport *vport, return err; } - rte_memcpy(&(vport->vport_info.info), args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(&(vport->vport_info.info), args.out_buffer, + IDPF_DFLT_MBX_BUF_SIZE); return 0; } @@ -387,7 +389,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport, return err; } - rte_memcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); return 0; } From patchwork Thu Feb 29 22:58:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137610 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 224E143BAE; Fri, 1 Mar 2024 00:04:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4558743392; Fri, 1 Mar 2024 00:01:23 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 1936C4027C for ; Fri, 1 Mar 2024 00:00:31 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-29aa8c4710bso1170576a91.1 for ; Thu, 29 Feb 2024 15:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247630; x=1709852430; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MBJ9KbebiLctnXbRqq3++6bQ1vDYpL0QWPR9AA8xA1k=; b=NHAM0JG26SouS6zPAApkXduXxMED4zyJ8EclVJrcRtZv5ki5K/VAuqiM4J/hnhX6cp PqD5RIMWAyQ0Pr1DOJdX72PYl8m0jw5XaOXjDcNjKi3n6cQsZjK+KX1edOnDQRwYDusc 7wVMy5kGEDKJd7ksS7PQEskIFEoAQdWShuzRqqn9J6CzGifqFew229oYAhhJaU2rkxmf 7Cj2oCXmQgizAZIl3iPgqeiKK0X5r5E3G4g3o4suPIS8ChJOGMnvb2UgUKWltIKw3ohX XhjFq70RbYacwxFTmt57yNqeT9/rhRNmt96JR8zAl2Cd5tQ3wDJ+INSKQzDOWjIgIOz8 G0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247630; x=1709852430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MBJ9KbebiLctnXbRqq3++6bQ1vDYpL0QWPR9AA8xA1k=; b=fXc3xCeuZNc4W1esnS2lNizzcYEiXwwmnOCdY1n5b3E3FfdtT0Xv8zXAM5Zgd/xjTg it1jhrLoPJgQFS/WsOnrv45oW7QhTarDyOQOl3rRWwuABl+3TNrM1MPv+L99jL046TiK OqGoBGgpV0n5oNrzyDY5xCCKh+HqftxUK/Eh/wza52o50mbj6DRTO/C0D9xoyKadwQL5 tTiQ/5X82upbEmxey/TCZgZx2wOlruQ+Q5U4JJtJxgfhlGh962LQK3FZHudHDn+opL3q SkHmn8ar25lFJo5ma2Lnwc+GoHolrvHze6jHt02sS3ZJWuUolka9LSVCricUzXUikKL7 cjRA== X-Gm-Message-State: AOJu0YwXy/riuMu8ljnf63wGoiNtURDnQir+LryLTcdQNugk8x04rh0a nM/SqCkuO2pVnERXGfVFpy5rf/PRoJS43fxuigCtc3R3M/3TJCkYWqPG5DAIxlFKBzj6KzLftad Y X-Google-Smtp-Source: AGHT+IE4kClvKcYaF4mLCJmcD6yuorXd7yDayBSzLNIy0C4OHnalDM5xv/jxhQzAuV3SgC9duj38Jg== X-Received: by 2002:a17:90a:b10b:b0:299:3780:e9c7 with SMTP id z11-20020a17090ab10b00b002993780e9c7mr504689pjq.2.1709247630096; Thu, 29 Feb 2024 15:00:30 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH 36/71] common/qat: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:23 -0800 Message-ID: <20240229225936.483472-37-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_qp.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index f95dd33375a0..0c30c4d8c18d 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -871,9 +871,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp) return -EINVAL; } - rte_memcpy(src_data_addr, - cipher_crc_cap_check_plaintext, - sizeof(cipher_crc_cap_check_plaintext)); + memcpy(src_data_addr, cipher_crc_cap_check_plaintext, + sizeof(cipher_crc_cap_check_plaintext)); phy_src_addr = rte_mem_virt2iova(src_data_addr); if (phy_src_addr == 0 || phy_src_addr == RTE_BAD_IOVA) { @@ -892,9 +891,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp) auth_param = (void *)((uint8_t *)cipher_param + ICP_QAT_FW_HASH_REQUEST_PARAMETERS_OFFSET); - rte_memcpy(cipher_param->u.cipher_IV_array, - cipher_crc_cap_check_iv, - sizeof(cipher_crc_cap_check_iv)); + memcpy(cipher_param->u.cipher_IV_array, cipher_crc_cap_check_iv, + sizeof(cipher_crc_cap_check_iv)); cipher_param->cipher_offset = cipher_crc_cap_check_cipher_offset; cipher_param->cipher_length = From patchwork Thu Feb 29 22:58:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137612 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C25043BAE; Fri, 1 Mar 2024 00:04:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9ABD04339F; Fri, 1 Mar 2024 00:01:25 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 1F5F742FEF for ; Fri, 1 Mar 2024 00:00:32 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5dc949f998fso1055107a12.3 for ; Thu, 29 Feb 2024 15:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247631; x=1709852431; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9KW1zdzm5T01/a+cb3Ov3Qa2achdwwIyvlZZPbx3Vx0=; b=npueT5+fmUJf9mvPIQ6RLyc+iR/26jgWeX1H5vyD1DA78bQl0/led4ul60ckY6GU94 BnP0h1fS++/8pTquqA+0FJK+jm+m+AvQ54Fbv1T5C/qjCWU+e2kGeBW9eo3hDu9uQnth gPibUccqT/ipjuy6Vl84HpQsKvC5Vpi8dSyJPKuhVweFE9B4nl/ETzaAdpg+YwZMoVZi f8RcCa0wy27XnJeoWzQ5YQdcX18O96JEB0j76A7ajxCIc0AsGm30PaBGENMMI8Ui2A+I vdt+dSxIfaXHZhz9Zd3eXzeqdDVLpJXkPr5go4SoM+BQRl37Hzcf87x6vBAIk8smQRFd Yq/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247631; x=1709852431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KW1zdzm5T01/a+cb3Ov3Qa2achdwwIyvlZZPbx3Vx0=; b=hDbhdnXy7lJIJSQ0IIiw4T+Cpl+O5us+h325hZ/TWoKzkNJ0LJbK7xiD9IkHiC0xrk FIUqLRzYjlsHhPYGSW9PMUjXLLXttA/ZAwNH9yHkUJVsNn+E1MIs2loWpR1CMn2+ROqF UFwJI3bi23I5gU+h+9j4XDDIcuAzvQwbPtcvAOPn02UhZt/PiQm0AgN2FhZYJhIWEszB nIw3r0AbEzNkCu5MoKKyUPbuTBtpLS7N2SEb6thwt+7eeYy8ZETGpGeg+s4jFCy+CUfn vRp9pWnzHH92bNeRNQhuf9+rO/2peHNS+ubnJAi5jdiYmevUSk68BxVXPCZRxH1QF4O6 BIrw== X-Gm-Message-State: AOJu0YxHCldEgADpdyxYmq289+ReSTmjJyxsn1Hyd36sFDpuExm5rGyM 87NqVTpND97XOg8IL+1NdV8zzI/j5Aru77zjUqfb709Gj1mWWzokNo5i8IXTJYtu93Gdshw7Izj 7 X-Google-Smtp-Source: AGHT+IE6FyCGvpQexAAVNIcat5LuBaHzrC2kJnwH2vjoM6CBFspRxEAY+AGd1Fm+q1y/v0d7q+srBA== X-Received: by 2002:a17:90a:cb94:b0:29b:171c:a787 with SMTP id a20-20020a17090acb9400b0029b171ca787mr35478pju.19.1709247631426; Thu, 29 Feb 2024 15:00:31 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Fan Zhang , Ashish Gupta Subject: [PATCH 37/71] compress/qat: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:24 -0800 Message-ID: <20240229225936.483472-38-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/qat/qat_comp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 559948a46a12..5bcbefe395bf 100644 --- a/drivers/compress/qat/qat_comp.c +++ b/drivers/compress/qat/qat_comp.c @@ -375,7 +375,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, QAT_DP_LOG(DEBUG, "op %p, parent_cookie %p", op, parent_cookie); /* copy original op to the local variable for restoring later */ - rte_memcpy(&op_backup, op, sizeof(op_backup)); + memcpy(&op_backup, op, sizeof(op_backup)); parent_cookie->nb_child_responses = 0; parent_cookie->nb_children = 0; @@ -401,7 +401,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, } /* prepare local dst mbuf */ - rte_memcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf)); + memcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf)); rte_pktmbuf_reset(&dst_mbuf); dst_mbuf.buf_len = dst_data_size; dst_mbuf.data_len = dst_data_size; @@ -457,7 +457,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, if (ret < 0) { QAT_DP_LOG(WARNING, "Failed to build child descriptor"); /* restore op and clear cookie */ - rte_memcpy(op, &op_backup, sizeof(op_backup)); + memcpy(op, &op_backup, sizeof(op_backup)); parent_cookie->split_op = 0; parent_cookie->nb_children = 0; return ret; @@ -468,7 +468,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, } /* restore backed up original op */ - rte_memcpy(op, &op_backup, sizeof(op_backup)); + memcpy(op, &op_backup, sizeof(op_backup)); if (nb_descr != num_descriptors_built) QAT_DP_LOG(ERR, "split op. expected %d, built %d", From patchwork Thu Feb 29 22:58:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137611 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EA6543BAE; Fri, 1 Mar 2024 00:04:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7436243399; Fri, 1 Mar 2024 00:01:24 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 1F44342FA5 for ; Fri, 1 Mar 2024 00:00:33 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29a940614easo1097540a91.3 for ; Thu, 29 Feb 2024 15:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247632; x=1709852432; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ml8BNtMCdJye1xhS+3MVMIo0y3q/nXOGoIniv8RYhzM=; b=ZpNHIXEgpJfJDn8rY3wZj2N8fPZcGJxClgtrFZLUAVNvry28KxHmowBYn5zaROgndK F1KD1feIqatrs0B3fUrATsmtiDLDYxQZB7AoWwudDbPCxT2ymfSz4Fqk5xiq8kiDhXvH dpygLE7myhHiv0LLkzL+9EPsUXI6l2mIsep1GJf+LZZSe2htI7kxER95TFKSy/1CFwNh nRJMe+bxPfo7+iPVN9UhpF0Bkm1wj+iQjNnztm+XPJwRjyojS2aGtJOE283SGG+jcOZK Iwpm8Sqw8xjuzlLza8DwFO6rtuNHPQqbZsAm73wERi/eYLfAb/QIxnpcZZQO5TkT/DgR tk4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247632; x=1709852432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ml8BNtMCdJye1xhS+3MVMIo0y3q/nXOGoIniv8RYhzM=; b=mFPqMmGWzoTDQot70N+eJWn8WBISN1bVVv+n6R+vw2JVXTXGPAPzizpvdXGxpNSawC 8IGkAe9yQYi6s0FjhMvPzCsnDTDH4y+hwtxZexCZZqeL5HcR14jVm6MFU5+jq08kmyqs DqrCkCu/eacYO0A55dxQSqBDuFzv4roUM4GA99JPc2EvFDUHMtVmGkZxWoHfsob/clUK NTGdP5zdP/k/oXsL55M772tM7uy4aYF8n8aH+inzu6MM1g0auCK+X2C9Wdog3EaUnShA 6FWdqrwKs7mttaAUi8JmVDx8Ej6stq11YmhjdJcU1DKXAtQ/361HJYFI8xfdnZQlQRwR 6Q6w== X-Gm-Message-State: AOJu0YzZgaLrZRrmKBe3Ig1R6yb0iyTUCSNmRsLxU+hAbs4RzU76OYjW 2TcRBBe8OCQcuTxiu3qBhW7jr4YlX7Vg19qN4ex5MzsFcw4aGwWviI6BrdkjMGMw2DklouaTHC1 M X-Google-Smtp-Source: AGHT+IG432gz76L8C/srG9fC/y8u+VrRs4qx8WbgZwTBVlB4t5nYPnDbkpzWdYpc+TgBzyc7EYi8Qg== X-Received: by 2002:a17:90a:f60b:b0:29b:2019:9577 with SMTP id bw11-20020a17090af60b00b0029b20199577mr19398pjb.41.1709247632261; Thu, 29 Feb 2024 15:00:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Uttarwar Subject: [PATCH 38/71] crypto/ccp: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:25 -0800 Message-ID: <20240229225936.483472-39-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_crypto.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 4b84b3303e18..4a70bc5d6e05 100644 --- a/drivers/crypto/ccp/ccp_crypto.c +++ b/drivers/crypto/ccp/ccp_crypto.c @@ -168,7 +168,7 @@ static int partial_hash_sha1(uint8_t *data_in, uint8_t *data_out) if (!SHA1_Init(&ctx)) return -EFAULT; SHA1_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); return 0; } @@ -179,8 +179,7 @@ static int partial_hash_sha224(uint8_t *data_in, uint8_t *data_out) if (!SHA224_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -191,8 +190,7 @@ static int partial_hash_sha256(uint8_t *data_in, uint8_t *data_out) if (!SHA256_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -203,8 +201,7 @@ static int partial_hash_sha384(uint8_t *data_in, uint8_t *data_out) if (!SHA384_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -215,8 +212,7 @@ static int partial_hash_sha512(uint8_t *data_in, uint8_t *data_out) if (!SHA512_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } From patchwork Thu Feb 29 22:58:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137613 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7F1F43BAE; Fri, 1 Mar 2024 00:04:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8D23433A7; Fri, 1 Mar 2024 00:01:26 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 1F814432BE for ; Fri, 1 Mar 2024 00:00:33 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5d8b519e438so1328706a12.1 for ; Thu, 29 Feb 2024 15:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247633; x=1709852433; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FINMwYiClSWzDgSE/KQmfKaD2/JiBuvKG9zmhUkGrGw=; b=knlj4PAM04tPhoioqCOTkpmsGmwlk8dlgub3pwiVlBfIq4QBq7S7KMI4XfbvW98KqK 05cQTA3bzXoW1bkttaKAyIIUFq+K3S7yQ+YdNMBOPU7QGUSL+xv2TSBTa8KV8/11UFJY DPbfkkbg+MPln68HXD/v1VU37t47lgs3k7lzWZINNhnq7HJUeIx5Z8xL/U/MKdcxTRDv sxmuzldauSQkT2pHn6LyPujEorVFTroBgI/iHDAWOspeEsoyPkzmO6m+h9F6XiPxxmjC CJyxN5GBx5yAvjYGG7jc9+22AFm/FDOplAsyv1KswOp4s/lFtixR9L5mnQObuf4E6+5o tPXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247633; x=1709852433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FINMwYiClSWzDgSE/KQmfKaD2/JiBuvKG9zmhUkGrGw=; b=rCoyEV4ymg1si6zakZRPKIWEyNnxWOWMyRSRSruDm40oPNf9xUx5fJNeCczH5Vlac9 UXbRkxskzBEwFZ6F7H66GX/stnDKaFFnBrkDyv2u5WFTgat9XLnhkEqQDxv14qR7Sr2s lT7M6Zir0ex9d3w/4l8WW/PceO4Ixo7xbIaN7fAsGYY9Dgy75aMOGT7jPY/V3wWWPebj 0DdppEXu2MQolmV820fL1136bWHax8FyOsgszR7XQu4j1hBS+x379YPCTj2KsCbZymnz rcDz2r6aWRxbzoopVF4wdI2wJu70i9VxEJjbRfX+iInCLyHIxjPDCVLzKm9xcriO/ToC CY+Q== X-Gm-Message-State: AOJu0Yxvf7bn4fKse6HjWaPzY209be2cXzGhxnuUhXGuqiFK1XEDsdf9 EQmmhIIceBuQzhesQKLwAhBV2gjkq9v+OuPjd/NT1+nDi16RhQVxxejX9XGLBiKEtnawuWHjDf+ P X-Google-Smtp-Source: AGHT+IGSvFqkhQ/enp5Rm9s5hDM8Sk5SJ2drKSMqc2FAq0RZaODFDtoqJaO95fV/Zckz/tC4lx4hww== X-Received: by 2002:a05:6a21:e85:b0:1a1:26f3:c21c with SMTP id ma5-20020a056a210e8500b001a126f3c21cmr3942147pzb.17.1709247633089; Thu, 29 Feb 2024 15:00:33 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj Subject: [PATCH 39/71] crypto/cnxk: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:26 -0800 Message-ID: <20240229225936.483472-40-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_se.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c index 1dd1dbac9afc..a67af3ec35a1 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c @@ -959,7 +959,7 @@ cnxk_crypto_cn10k_submit(void *qptr, void *inst, uint16_t nb_inst) lmt_dst = PLT_PTR_CAST(lmt_base); for (j = 0; j < i; j++) { - rte_memcpy(lmt_dst, inst, sizeof(struct cpt_inst_s)); + memcpy(lmt_dst, inst, sizeof(struct cpt_inst_s)); inst = RTE_PTR_ADD(inst, sizeof(struct cpt_inst_s)); lmt_dst = RTE_PTR_ADD(lmt_dst, 2 * sizeof(struct cpt_inst_s)); } diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c211884ddaea..e6c1e1586b9b 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -1161,7 +1161,7 @@ cpt_sm_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens, struct roc_se_fc_p void *dst = PLT_PTR_ADD(offset_vaddr, ROC_SE_OFF_CTRL_LEN); const uint64_t *src = fc_params->iv_buf; - rte_memcpy(dst, src, 16); + memcpy(dst, src, 16); } inst->w4.u64 = cpt_inst_w4.u64; } else { From patchwork Thu Feb 29 22:58:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137615 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F35843BAE; Fri, 1 Mar 2024 00:05:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D65433B8; Fri, 1 Mar 2024 00:01:29 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 5FF16432CC for ; Fri, 1 Mar 2024 00:00:35 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-29a858a0981so1100082a91.0 for ; Thu, 29 Feb 2024 15:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247634; x=1709852434; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sb5rBdinnRC1Ats/IVCilK5XYF3UQ7Bby6sO8IAUAI4=; b=ZwzeIzVHZlC69EQu7PiMRH1BG4oNmSwubPrgBd5JOMJ6fNsMxiVBn/YeM+ewQ1UpzG 4WGqpjxb246tj9GLx00CyAnSAleFr4oyrH9J2ZFz1utESyY2dZlb/EUwiPbZT9t+ee5g 1HYVoviTk4VhzMH5NVr/C0XbZmpjhHS8T4R9NNgSxS3uVWcSAoFCguI1ltWOiL8Y+sT6 izbOtmGq+3/RWJF/g+v/5O/h+6YWpEhDL5F0RCOF5zykQtkwOPh60+H1Ac/ug6ME0dwO ywxEWLozysYBKh8msu9Is5+jS3l6w/sdd9AppIMb4nNcAQbGOKG2Kmvb/EixCwbkKSUK EiPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247634; x=1709852434; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sb5rBdinnRC1Ats/IVCilK5XYF3UQ7Bby6sO8IAUAI4=; b=XyP3VjBzMDCTeTYqigIChtWbZdwkWn3LB8uBkJ/c0Q8zGwdd9+ARNL02iFGgOqn/yQ mz4Mo75J0zzkjXUAOneoaH4qcjIsMRq3C0Y5UAyzdF+QVEjC2CHqMy2qhvcMX9nn9Xoc +9kNPtOjSDwiVsOEmYdFq1bEB6ygztng5De7auDyVzNax0mcylcWlZphiihv9A2U0GzQ og7pIAexMU16myUxOdRU4KJ4NDWA097ZXWURlVLa0ABGVsBJ31WiPOdlXTdjFSDKYEE0 iU5l3dppraDzffyr80Lg3+VNK/pVUB6dtWtajVB1yej6QuljgNTNmbq7iR0T+i1ebNG2 +0tQ== X-Gm-Message-State: AOJu0YxQl45AoIB2Q59xxfvcjd3ATZMFlwUOiweZWh+Iv1Y4a34tdbbh EByU//oIxqIWm9yxLmEmLQ4jzR83oZ920LxE+DZ2Uf6M3MDeq1JJnxTeuCUHv8jcknGtUhg6znd U X-Google-Smtp-Source: AGHT+IE+ZRHyF1Maf3PrGx2SxIyCO7V1IfEzbxR5NRxpyr4Ouix5kGTUSbrZc3mYgvBGSC4Ebq73ww== X-Received: by 2002:a17:90b:3585:b0:29b:f79:2b75 with SMTP id mm5-20020a17090b358500b0029b0f792b75mr43373pjb.7.1709247634015; Thu, 29 Feb 2024 15:00:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:27 -0800 Message-ID: <20240229225936.483472-41-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 44528eaf7f7a..3e7b78656bb4 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -676,7 +676,7 @@ dpaa_sec_dump(struct dpaa_sec_op_ctx *ctx, struct dpaa_sec_qp *qp) } cdb = &sess->cdb; - rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); + memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); #ifdef RTE_LIB_SECURITY printf("\nsession protocol type = %d\n", sess->proto_alg); #endif From patchwork Thu Feb 29 22:58:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137617 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF4F943BAE; Fri, 1 Mar 2024 00:05:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBBFC433BF; Fri, 1 Mar 2024 00:01:31 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 2199F432BE for ; Fri, 1 Mar 2024 00:00:37 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5ce942efda5so1192355a12.2 for ; Thu, 29 Feb 2024 15:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247636; x=1709852436; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2/dZv4tXYcaE5nRc+9W8tixDh3nyUhSr+lOt9LzaCY=; b=bUU4i4qMxJv3N86YVJkAI/bvO0YLU/y+TYjVXLi5RdkfEIUl0fdCKHnUdlMPDEMCrW XAQTRSQ/n0oP3T0QWRs9FUm1ApVsTarERpsjOBFmQsVgo+6dAK10x6a+aJ+1AXdr1997 o/RJJ9AJhg/D/nxA+L0JZVR8lUw8Qxkcoh/UZMJVHdrvJfXUcRzrTZBO+ZhVXSq9MlYZ EA8rcqVI7Hdm01aSYJqi3TckXzTIQh7BuXOkMvO0rfX4W0EKaLdz9P64oFqT8jY7NwqS 3qtrR8f8hGcNIyeM3BRm9fwntZHQuXRpaB+wdr+5SJnIxjt0hPJhOqMJWvjDhPMH5RnZ YBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247636; x=1709852436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2/dZv4tXYcaE5nRc+9W8tixDh3nyUhSr+lOt9LzaCY=; b=M44ByG/2KrUqBiqxUc8QPNvbUIotm1l1IGj4E19GBvGNwnSf5OiLBhVt6oU5ciJQi8 EX4hFeyEU5AoNzinmoUdhC8vhrB3NbAS8MbojTzs7VgcqGlF9TS98XrUfyBoFCaxwa84 lFhaNYW+/VC2h3AYSvonDpdKk0m+6m1Pa9RTLE1wXI7BryVee1ihiVxsPYl0wD7BWV+0 goywo751sNxBnHu6I92PF+Guz/q+hA5EJBi/1AE1rcokc/w2LrrLLqqOs8Y2ZaLLP/oe Ke2QKiPiQgGA3+hg6Im1HTO39jBoxy7b5nv74ef4jWTv7XmABGiQZpDpwvKSRHQIAyRC 1Nqg== X-Gm-Message-State: AOJu0Yy+PokX0rtZxLyBmolYhkug8PsKOoO2C9XnhSgHWXcOBmzRGvBR MkLVyFIwdLxND7N45UhXxtjLlxFT+wiHYrqXaXngmAyBAqPzmECtHfw477lTRF0RTj+O8BnXlmL I X-Google-Smtp-Source: AGHT+IGPAXLMvK59ekRAXrhUUtd2Xvm3KZbTUGG4miooDrMvnaNirpfXb2EePL4dzngHEZMWUqsTig== X-Received: by 2002:a17:90a:a893:b0:29a:9b11:9a5a with SMTP id h19-20020a17090aa89300b0029a9b119a5amr13124pjq.43.1709247634832; Thu, 29 Feb 2024 15:00:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Pablo de Lara Subject: [PATCH 41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:28 -0800 Message-ID: <20240229225936.483472-42-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c index a96779f05942..f3f519f2d451 100644 --- a/drivers/crypto/ipsec_mb/pmd_snow3g.c +++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c @@ -291,8 +291,8 @@ process_snow3g_hash_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops, /* Copy back digest from src to auth.digest.data */ if (digest_appended) - rte_memcpy(ops[i]->sym->auth.digest.data, - dst, SNOW3G_DIGEST_LENGTH); + memcpy(ops[i]->sym->auth.digest.data, dst, + SNOW3G_DIGEST_LENGTH); } processed_ops++; } From patchwork Thu Feb 29 22:58:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137614 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4468B43BAE; Fri, 1 Mar 2024 00:04:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42B74433B2; Fri, 1 Mar 2024 00:01:28 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 67F8742FE9 for ; Fri, 1 Mar 2024 00:00:36 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5dbf7b74402so1133027a12.0 for ; Thu, 29 Feb 2024 15:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247635; x=1709852435; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=; b=Lljb+1wj6arEIBJ106E6tVhupRiTKw1SnP7s8xLrElnSJAznVVckApuOwcqCwC3Ziv TrWrIjoagYO0STL9UMjJiRf0l3gMU4GgwfOQk9GstALPjcXtzCTixbME5qwBLCWMSUmv MkcyzDS3Zz0CeyU7JsbGyce6Zh2S3Nk+6P0C1dGr03LVAXWtvKi/fwZRJeIxw1BTS0Mf pNr/yjJ6izYiuvbEFMtNNmChSz7mkL2Zfy6/A16sasQnmFHi1hgr8YPotiDLAH5KU6kH gTQPcos3x4zSkgxzYWENl/gR/yNL4JvhmYzHZGt+hBlKtdBXkQuGWZWb7sTWhUEb8Hrn F+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247635; x=1709852435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=; b=MGo0nndP5t0wHBlfd6z/Lr+ZzBCR5HdNhfc92nHjvP8m/RepDXmYePLHAkRfaBsNSq y6XVRmq9pTFjHSJ3r8qH0c0ve8smer3F9iYOVWYfyHhwAGr3JLjYRaj8TH9+6czRVw6r 1Y5ykfk0uvKsaecxZOZ4z/f+wBMTxFBBdR+8M9PUSbk5yFBdi6PpajZi5VmU7uP9rTJj ctRUbtRXn1EZhle80HKN/iHdcndsbYcBMJQIpeM4sjnenT8Gz5bbnO2xCOakbp50Krz8 g7Q7EOpOwONuMqXRBkjMcg0z1GrWFN7oWWHPO46oU+jLOsCTdBQuDtNKPc4xOaHYE24w phkQ== X-Gm-Message-State: AOJu0YyGAOO3ABe0+6INu/TsGdaVD/lb8uoNinQQ055RkSj20nWqPV/D IXfYcibzluUwcz8Pxc8NcHek+MlcBHTy9OEEnUnbeDJfd7ydOnig7g4UOooQdJsu4lGkvIyoR9N n X-Google-Smtp-Source: AGHT+IFsnu+a7O7NT1Ymq9pT3HTMmpVLCyo91ovOZ2chC8Ey3D8Ptm2TWrYrFge/J5OwnSP6tDnVBw== X-Received: by 2002:a17:90a:4a83:b0:29b:1018:87cc with SMTP id f3-20020a17090a4a8300b0029b101887ccmr19718pjh.44.1709247635580; Thu, 29 Feb 2024 15:00:35 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH 42/71] crypto/qat: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:29 -0800 Message-ID: <20240229225936.483472-43-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/qat/qat_sym_session.c | 52 +++++++++++++--------------- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 9f4f6c3d93e0..8d7809bbec11 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -1310,7 +1310,7 @@ static int partial_hash_sha1(uint8_t *data_in, uint8_t *data_out) if (!SHA1_Init(&ctx)) return -EFAULT; SHA1_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); return 0; } @@ -1321,7 +1321,7 @@ static int partial_hash_sha224(uint8_t *data_in, uint8_t *data_out) if (!SHA224_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -1332,7 +1332,7 @@ static int partial_hash_sha256(uint8_t *data_in, uint8_t *data_out) if (!SHA256_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -1343,7 +1343,7 @@ static int partial_hash_sha384(uint8_t *data_in, uint8_t *data_out) if (!SHA384_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -1354,7 +1354,7 @@ static int partial_hash_sha512(uint8_t *data_in, uint8_t *data_out) if (!SHA512_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -1365,7 +1365,7 @@ static int partial_hash_md5(uint8_t *data_in, uint8_t *data_out) if (!MD5_Init(&ctx)) return -EFAULT; MD5_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, MD5_DIGEST_LENGTH); + memcpy(data_out, &ctx, MD5_DIGEST_LENGTH); return 0; } @@ -1486,8 +1486,7 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg, return -ENOMEM; } - rte_memcpy(in, AES_CMAC_SEED, - ICP_QAT_HW_AES_128_KEY_SZ); + memcpy(in, AES_CMAC_SEED, ICP_QAT_HW_AES_128_KEY_SZ); rte_memcpy(p_state_buf, auth_key, auth_keylen); if (AES_set_encrypt_key(auth_key, auth_keylen << 3, @@ -1531,8 +1530,8 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg, return -ENOMEM; } - rte_memcpy(in, qat_aes_xcbc_key_seed, - ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); + memcpy(in, qat_aes_xcbc_key_seed, + ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); for (x = 0; x < HASH_XCBC_PRECOMP_KEY_NUM; x++) { if (AES_set_encrypt_key(auth_key, auth_keylen << 3, @@ -1795,8 +1794,8 @@ static int qat_sym_do_precomputes_ipsec_mb(enum icp_qat_hw_auth_algo hash_alg, uint8_t *input = in; uint8_t *out = p_state_buf; - rte_memcpy(input, qat_aes_xcbc_key_seed, - ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); + memcpy(input, qat_aes_xcbc_key_seed, + ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); for (i = 0; i < HASH_XCBC_PRECOMP_KEY_NUM; i++) { if (aes_ipsecmb_job(input, out, m, auth_key, auth_keylen)) { memset(input - @@ -2265,8 +2264,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, cdesc->cd_cur_ptr += sizeof(struct icp_qat_hw_auth_setup); switch (cdesc->qat_hash_alg) { case ICP_QAT_HW_AUTH_ALGO_SM3: - rte_memcpy(cdesc->cd_cur_ptr, sm3InitialState, - sizeof(sm3InitialState)); + memcpy(cdesc->cd_cur_ptr, sm3InitialState, + sizeof(sm3InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); state2_size = ICP_QAT_HW_SM3_STATE2_SZ; @@ -2277,9 +2276,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, hash_2->auth_config.config = ICP_QAT_HW_AUTH_CONFIG_BUILD(ICP_QAT_HW_AUTH_MODE2, cdesc->qat_hash_alg, digestsize); - rte_memcpy(cdesc->cd_cur_ptr + state1_size + state2_size + - sizeof(*hash_2), sm3InitialState, - sizeof(sm3InitialState)); + memcpy(cdesc->cd_cur_ptr + state1_size + state2_size + sizeof(*hash_2), + sm3InitialState, sizeof(sm3InitialState)); hash_cd_ctrl->inner_state1_sz = state1_size; hash_cd_ctrl->inner_state2_sz = state2_size; hash_cd_ctrl->inner_state2_offset = @@ -2316,8 +2314,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA1: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-1 */ - rte_memcpy(cdesc->cd_cur_ptr, sha1InitialState, - sizeof(sha1InitialState)); + memcpy(cdesc->cd_cur_ptr, sha1InitialState, + sizeof(sha1InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2343,8 +2341,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA224: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-224 */ - rte_memcpy(cdesc->cd_cur_ptr, sha224InitialState, - sizeof(sha224InitialState)); + memcpy(cdesc->cd_cur_ptr, sha224InitialState, + sizeof(sha224InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2368,8 +2366,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA256: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-256 */ - rte_memcpy(cdesc->cd_cur_ptr, sha256InitialState, - sizeof(sha256InitialState)); + memcpy(cdesc->cd_cur_ptr, sha256InitialState, + sizeof(sha256InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2393,8 +2391,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA384: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-384 */ - rte_memcpy(cdesc->cd_cur_ptr, sha384InitialState, - sizeof(sha384InitialState)); + memcpy(cdesc->cd_cur_ptr, sha384InitialState, + sizeof(sha384InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2418,8 +2416,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA512: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-512 */ - rte_memcpy(cdesc->cd_cur_ptr, sha512InitialState, - sizeof(sha512InitialState)); + memcpy(cdesc->cd_cur_ptr, sha512InitialState, + sizeof(sha512InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; From patchwork Thu Feb 29 22:58:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137616 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BD8D43BAE; Fri, 1 Mar 2024 00:05:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92EA5433AB; Fri, 1 Mar 2024 00:01:30 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 6BBAE42FE9 for ; Fri, 1 Mar 2024 00:00:37 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5c6bd3100fcso1133012a12.3 for ; Thu, 29 Feb 2024 15:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247636; x=1709852436; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kr1WKZncDCsMZXScbKAM4rAgqfeNUJlqgLjmJ+Cu/Xo=; b=WMNdEvKHn2+8jJ8ohjDry/KzJdXS2+yMJJD7Zqv0LflFtD9HE1J9wmMBlIUL1wrq3D tzJjkAKgxdA9KYDN1KUSkWnoutlT1q33yHUuBD8Z0SngTzz/0/8Xzp+ncw1F+r1Ih24e VV85KFxwY3Dw7MyEIzp9tE7mamjx2gKMXp4jvapJ+IvcY4PXihWF1E3d9gJ3QKxATAE7 TSel4/YKpgkVrKU7iNw8XR9/ByJr+PsBcwHbvme1qMljrCEAisiJFIiNmOSSTM9LRQ1w wPjG6FdU7h9C1kby0IjrxXzZ3C4F6lOFuhm5STAKxExzrN5kvZHxMbjjwBEGDQwAcUUK hj3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247636; x=1709852436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kr1WKZncDCsMZXScbKAM4rAgqfeNUJlqgLjmJ+Cu/Xo=; b=DFy1WP+kkTkamN2vggmIo+vcL6dASQW3svGdSoQUMrv1eRmc3tMTIX9Ryp4sGp0o37 3Pjj3ki8RybjC376fhUsYsoYjW5sHwo1vybl94WUaZpuUvkylTMaPRLmtPcy1zU0ObQR k07z6LAnYLwh1cetAvQwflIC592+yn99WE4yMLFNNR2ph2RSJShNFIlylqmBrFHTQQeL tsmWlZ002QKLoELVig2HkQ5VZ9Fh/H4vyvYpRwNo9BlZpvi057qa+QFxrtQt3hg0+G1/ 0nUFNouR1u7IyFHcyuWFBBN3EzFRkDFuc9dwsZsewxl4mb9M1gArmjpAG/2Wudlx2AX/ 4ZLQ== X-Gm-Message-State: AOJu0Ywg6ZKzPZQcnOWTC340b29C+hUjDOj+S/bUcnafsy1UXPe7sA0c 1gX1IKeXg146HfSp9eyN7KcJcVk8coz649hEw2/cBbDwIOqPPQ25Dg7KWtE/Wso61itQadIrmvw 3 X-Google-Smtp-Source: AGHT+IEWtXmIchbOi9W8rq6F3udTnNyhFq09+i3+tel5mj9DwmNMWSpzGajZGN3t78EpWafdF0RbpQ== X-Received: by 2002:a17:90a:4d8f:b0:29b:2268:3349 with SMTP id m15-20020a17090a4d8f00b0029b22683349mr38531pjh.18.1709247636477; Thu, 29 Feb 2024 15:00:36 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH 43/71] crypto/scheduler: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:30 -0800 Message-ID: <20240229225936.483472-44-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 6 +++--- drivers/crypto/scheduler/scheduler_failover.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c index 9a21edd32a9c..ed1833a7c61d 100644 --- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c +++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c @@ -79,7 +79,7 @@ sync_caps(struct rte_cryptodev_capabilities *caps, /* remove a uncommon cap from the array */ for (j = i; j < sync_nb_caps - 1; j++) - rte_memcpy(&caps[j], &caps[j+1], sizeof(*cap)); + memcpy(&caps[j], &caps[j + 1], sizeof(*cap)); memset(&caps[sync_nb_caps - 1], 0, sizeof(*cap)); sync_nb_caps--; @@ -216,8 +216,8 @@ sync_sec_caps(uint32_t worker_idx, * caps, from the arrays */ for (j = i; j < nb_sec_caps - 1; j++) { - rte_memcpy(&sec_caps[j], &sec_caps[j+1], - sizeof(*sec_cap)); + memcpy(&sec_caps[j], &sec_caps[j + 1], + sizeof(*sec_cap)); rte_memcpy(&sec_crypto_caps[j][0], &sec_crypto_caps[j+1][0], diff --git a/drivers/crypto/scheduler/scheduler_failover.c b/drivers/crypto/scheduler/scheduler_failover.c index 52ff2ffbb7f6..e7c6d19d25b8 100644 --- a/drivers/crypto/scheduler/scheduler_failover.c +++ b/drivers/crypto/scheduler/scheduler_failover.c @@ -171,12 +171,12 @@ scheduler_start(struct rte_cryptodev *dev) sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i; sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i; - rte_memcpy(&qp_ctx->primary_worker, - &sched_ctx->workers[PRIMARY_WORKER_IDX], - sizeof(struct scheduler_worker)); - rte_memcpy(&qp_ctx->secondary_worker, - &sched_ctx->workers[SECONDARY_WORKER_IDX], - sizeof(struct scheduler_worker)); + memcpy(&qp_ctx->primary_worker, + &sched_ctx->workers[PRIMARY_WORKER_IDX], + sizeof(struct scheduler_worker)); + memcpy(&qp_ctx->secondary_worker, + &sched_ctx->workers[SECONDARY_WORKER_IDX], + sizeof(struct scheduler_worker)); } return 0; From patchwork Thu Feb 29 22:58:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137618 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91A0443BAE; Fri, 1 Mar 2024 00:05:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21869433C6; Fri, 1 Mar 2024 00:01:33 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 6710242FEF for ; Fri, 1 Mar 2024 00:00:38 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-299c11b250fso1021400a91.2 for ; Thu, 29 Feb 2024 15:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247637; x=1709852437; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OCPeaSpmoR4pGr1jr7yoEFFyqdCQ+w7/Q6s+B5JelMs=; b=tO2CcsB/qHCGF13ie74eTNmUFokIkCMalACpip05KhM/JH1G1ksLza2r6OkUo/3rRy l9M+9EM57Wpk1jjnAz7it9GriuKmYGtOqSLnQeaDrZcVoAUq/qeDvEV7tCMtlx8LqftI RuPvX47585vsJHkJiohTlm8hwgows0eLAywBQnuIYTVjsjuR1mw/gr++iI+z2U2DQqFY DJtqf4kOprrtDiHkcNyEnjB14eGIftDumYzi3S3WFrl+e2czlMwfW+m6AOrllyjnOWGJ Fv4xZVWGw2DqdO7u8UyMqhiZxrmZxV2Y/cRn7jVBPKKEO0PTQZRZ/nzrvmmiMzMeur1t gBjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247637; x=1709852437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OCPeaSpmoR4pGr1jr7yoEFFyqdCQ+w7/Q6s+B5JelMs=; b=Xa9/VgoOGoZFKY0VtIdksBwVWmKO04orCJraOj8awGGVTSgFr5aalYmp9DhKzPrqeI 80SXBJVDGyV3smVKVFHgxHxPkNMCpxks9S+pQJEXIww9Jhy25CKln4p9TFYbWHSLun2c iSA0KynIjHl7YWH02qQsGbN+ksvjw6UR9ljRtEMg4zJonjSvux9rg3ExSFLLKQx8yXtE EVi878PMuYmZtKHKQO6UVThg7fKJ5/KYAqEMH1zQPULgGEeKYFyE4dKJ/bRQqqxSNzBq 3tvEvWuPg8z5j6ZIzlRvngkt0DmhbZi/nwJCBCe/8HF6lYsyNZ1mJNDADK0AvSejQpKP AYYQ== X-Gm-Message-State: AOJu0Yx/rjlX+0ZSgxCOQZiSgn87E4jjX+ZyUkd9ETpy8UEu+jHoPIcG MN06Qe2pTJmWsoqXQYXzRUf33Wu2k9KvkYIYmZW9qS3qBVIo+9df2+tdsNAwlnGzwJM0ruvX8PV r X-Google-Smtp-Source: AGHT+IHYoE8rERaD4a7xUa6dH7XuXbVLT0InFwzR5jo+YhKA058WcrGKNLXoJciY1j0voAfPwgOdEg== X-Received: by 2002:a17:90a:7143:b0:29a:842b:d8b3 with SMTP id g3-20020a17090a714300b0029a842bd8b3mr30809pjs.7.1709247637292; Thu, 29 Feb 2024 15:00:37 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Pavan Nikhilesh , Shijith Thotton Subject: [PATCH 44/71] event/cnxk: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:31 -0800 Message-ID: <20240229225936.483472-45-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_tim_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cnxk/cnxk_tim_evdev.c index 6d59fdf90983..2027c4644c5d 100644 --- a/drivers/event/cnxk/cnxk_tim_evdev.c +++ b/drivers/event/cnxk/cnxk_tim_evdev.c @@ -115,8 +115,8 @@ cnxk_tim_ring_info_get(const struct rte_event_timer_adapter *adptr, adptr_info->min_resolution_ns = tim_ring->ena_periodic ? tim_ring->max_tout : tim_ring->tck_nsec; - rte_memcpy(&adptr_info->conf, &adptr->data->conf, - sizeof(struct rte_event_timer_adapter_conf)); + memcpy(&adptr_info->conf, &adptr->data->conf, + sizeof(struct rte_event_timer_adapter_conf)); } static int From patchwork Thu Feb 29 22:58:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137619 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAE4343BAE; Fri, 1 Mar 2024 00:05:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9145F432AC; Fri, 1 Mar 2024 00:01:34 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 1D595432BC for ; Fri, 1 Mar 2024 00:00:39 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5ca29c131ebso1171563a12.0 for ; Thu, 29 Feb 2024 15:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247638; x=1709852438; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0X2ZlNRffbU8lumW96o5qjKL55GvanO22xjlz/60sIs=; b=S9gHwdbRizg5WUp8I1MnZprnpbFS2yaj45eE9+rh2B+PU55ZgFg7MEafBAMTaTDwln Zz+zYA4dLGJZ4Rc6PUQyCleUB1d29VKlQNBU+ndl+/ESubh+vCmlrWnuzvBXWumCIE4w x2psDDNjj/ne9gMXSm6tvNl99GDPvK0IDlji8p/at8S9TR5wgMIjuoNjt4L182TWnY7G tGOZTuzHv4nb0WY6o6ra1Klx1DQm4yehVk58qSFl4H7GPgS2Z31+9xooVaZviVHIVIab BkddSMAzTgjzfWcdX541XuTr7BxiI1F91+9HRVBL0qXShOzQ9s7+49/d3zeISOjYZ3SV 9J5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247638; x=1709852438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0X2ZlNRffbU8lumW96o5qjKL55GvanO22xjlz/60sIs=; b=TNdWQLxmWAjxt+qIOOPUtj/4bGE511/AksYdxJp6Z3E1XS1FU1X45pswJWTYmsbPBS 6gMZz7Dh7nIAw9wc/QoL80qKVgyh17xdPev9mD3J9QZZQw8hlgITQebwcX4gc15GgI9Z RmpvGxLFbg93qcYg+pm6/j+AfXmC/QsCPizhpH0/5FNf2XcS9T/Si56FtSPETxCAxU1S KbSX9zRulMXMUsFWhDc/XKHYRz7lIYc4u6sQoGgWkpKygiodLrQ7kSskmpDbUrPL9w07 IhqTFue06Gjd0OvTkeaKsO3hSEf5mNRSmKhzw/cSSPUXuclF7CEYYqqdmBu3wj4Ia5NT 7Q4A== X-Gm-Message-State: AOJu0YzAgBhC8LQJo6BUdv0fW1rlJrntd8mkCdje/yBVSbZgFQPp3ATW qp266+apV4co4KRLtYn+Diu3Pkh7WdBoBbsQsPu9mpnHwjnw5HoNwqNkpfWh/LY+F6ShYP87cN5 Z X-Google-Smtp-Source: AGHT+IFK2+FZvq3/95Ymapg50MZVrOFlRlJx7izgFPRdpW8D6MuX5z5GBgT9E6R1EpPgIfroxUjxFA== X-Received: by 2002:a17:90a:d685:b0:29a:c4a3:ca0a with SMTP id x5-20020a17090ad68500b0029ac4a3ca0amr43298pju.18.1709247638074; Thu, 29 Feb 2024 15:00:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abdullah Sevincer Subject: [PATCH 45/71] event/dlb2: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:32 -0800 Message-ID: <20240229225936.483472-46-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 271bbce54a3a..5c1cd35dbda6 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -225,7 +225,7 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2) handle->info.hw_rsrc_max.reorder_window_size = dlb2->hw_rsrc_query_results.num_hist_list_entries; - rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info)); + memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info)); return 0; } @@ -1671,7 +1671,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, qm_port->issued_releases = 0; /* Save config message too. */ - rte_memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb)); + memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb)); /* update state */ qm_port->state = PORT_STARTED; /* enabled at create time */ @@ -1872,7 +1872,7 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2, qm_port->issued_releases = 0; /* Save config message too. */ - rte_memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir)); + memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir)); /* update state */ qm_port->state = PORT_STARTED; /* enabled at create time */ From patchwork Thu Feb 29 22:58:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137620 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15A6E43BAE; Fri, 1 Mar 2024 00:05:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE0C5433EF; Fri, 1 Mar 2024 00:01:37 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id A0D33432BE for ; Fri, 1 Mar 2024 00:00:39 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5cfd95130c6so1056453a12.1 for ; Thu, 29 Feb 2024 15:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247639; x=1709852439; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S0fEpE8a6QKja7RmbiOboSr13Jtrc1PCG6xQDYs4NKY=; b=c9GzUeFc2LURtz8mPBgUrP4UUJyFUDgPyIUGIPqus6J8jSSMF8uv2tLKoy5CAE7/H2 EXOkyBQ7jXLKI1PK+HnXeTUqG5mTghfV3sgcxGNidWrZOGb0bWRd/ri4ErulGliXx7rh Q3gUUe8wazwbq5bTx8Q2KnXiZoAfVzKctKuJDjGtrr47xjKnK0HRWRuImutScskg52ju 0gRXWbWQRIzWOdfWid3GK6qP/SXS27lyqcjXLXMgRMxLSr3rY2Ie7dJ+wg5sCwq3QlHq wE1tmTaoR4qYJtTuV2LSiImw1h9m+aGIWmqt43DaFP0sGaGdMdMfC4TrgJ4Ff2Gz/IyT Jy1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247639; x=1709852439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S0fEpE8a6QKja7RmbiOboSr13Jtrc1PCG6xQDYs4NKY=; b=YXisYMLyA0UTKqWHSsdTMLMT4eZBip+fv+aGYPizLJ4NyPzqVO6FQC8vU9AnJRMjbf vfWIjzRajCQBcJaSpSTZgkhaZJa9pip+azNw/NkWmLR0ANKDdEJYoTGrZ2nK+PrZTzvh O4xUQwrDZFsdNOd+VAELGxrX/c/5zYGQJpS07BYUYzTmS77wDOuSOL+/5sdiQ6kwVrQ4 9tOyrCrZaHbty9hQLvuetPqnPXuyK9ML8lBHh+L3EbsWsGyLBsrak2ADuNO3MPylitGk yLRuFo6nn9N0UJvvL/wNDY/ozJNTiS31JwwSy5Npf6onYEb7IQBvu+U21o+Yf5/hoD1B zdTQ== X-Gm-Message-State: AOJu0YyWGtLs+FQu2Ij2HDLQZjzOVOZj3Enw+KulkoJ9gNbDS3lvcNOD s9qIlGyTiTPEOUHN3vPaZryq0KoCOUozO5EKyeuq5X0TVP4j4AwfKCo0LCAYfYRaDzeT9xzKmyj H X-Google-Smtp-Source: AGHT+IFzeiSnd0ia6ZFQ62Pd/OAgnFYGCxtk8g2cpHJVdUFr4mzqL6YCORaj48g+/Q+cELVCSV0ADQ== X-Received: by 2002:a17:90a:17e9:b0:299:bade:ed0b with SMTP id q96-20020a17090a17e900b00299badeed0bmr19073pja.45.1709247638876; Thu, 29 Feb 2024 15:00:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 46/71] event/dpaa2: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:33 -0800 Message-ID: <20240229225936.483472-47-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 1273455673ad..0331bb6fb91d 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -159,7 +159,7 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[], "Unable to allocate event object"); goto send_partial; } - rte_memcpy(ev_temp, event, sizeof(struct rte_event)); + memcpy(ev_temp, event, sizeof(struct rte_event)); DPAA2_SET_FD_ADDR((&fd_arr[loop]), (size_t)ev_temp); DPAA2_SET_FD_LEN((&fd_arr[loop]), sizeof(struct rte_event)); @@ -230,7 +230,7 @@ static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp, RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + memcpy(ev, ev_temp, sizeof(struct rte_event)); rte_free(ev_temp); qbman_swp_dqrr_consume(swp, dq); @@ -249,7 +249,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp, RTE_SET_USED(swp); RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + memcpy(ev, ev_temp, sizeof(struct rte_event)); rte_free(ev_temp); *dpaa2_seqn(ev->mbuf) = dqrr_index + 1; DPAA2_PER_LCORE_DQRR_SIZE++; From patchwork Thu Feb 29 22:58:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137621 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A9F43BAE; Fri, 1 Mar 2024 00:05:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11FD2433F2; Fri, 1 Mar 2024 00:01:39 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id B4BC7432DE for ; Fri, 1 Mar 2024 00:00:40 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso1174191a12.1 for ; Thu, 29 Feb 2024 15:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247640; x=1709852440; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kc3UkBu7gBJywBZiNoLul3e8PTLdPQrjXqfUVikGILo=; b=BhOWGax3DiXDRwaUHG5COaVZZmcQdiUtMoKMRHjkaUBxqGmTyTZHb/OR8ea3tBGteI 1iZjcgqTbAeagcs6X0yizUlYOn9ZJUSNn5QcaQmzTAe4enkjwpyINoFKaqH7i89AoQjy K9DwMjWFKFWdQh9LxBWrs/+1930U43NZ7kSbiCt0wohRHL3m6Mrbv5vzZ1n8QgDFisde VVK7Q1NKYQOcnbra2y864Z8DE4dpSrH22l4l5Gsrh+3HUoNK3DiTW8bSyorsxMTFiV+/ mc5WNiuJaavyMZelNjE9U2MjBpT65UR2T0oMU9vVyyLOK80UsK4dWVHKm1fabPR6YCLT PBAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247640; x=1709852440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kc3UkBu7gBJywBZiNoLul3e8PTLdPQrjXqfUVikGILo=; b=ita4jk/sL33OwhTt5oL2HT7utm7I8pZYAbmFX07TKkazH9tW1MJSd1FDClHhtFxceJ NACSAItm5AzlcC++hFpy5fvbpT25UmnNPxLoFjY8igBMukxoKlb/dr7eZ9XNSa9FSPWZ 0G4eVqrxLqxieHNx3cLq1MGV1bUdpFdxLC9hSG0FauOFc9u3YzyNLvZxyNyZneAF12+8 3OUgeVCGqyRtPTXlPSAbzTIftDMtCBKeWdEDEOhAWU71csF+BK4o8Y98k2aJ6iXLSPRN unAR9pV/j9gsDealHQ9AzhaAb75o4eXcjmpHGuAM/w6DV3ne0HzMsxi8fCsdnifHeydZ biiA== X-Gm-Message-State: AOJu0Yy56BBd/BC3bGHhv2nKpi3JL7hDXqJicb9aiLkNED4FHkYwZjp2 vxM1XWBIkgjvqpiO7X3UM1LVd0zi6qy8gZo14h+e8VtBSbRWc/yqNlAgkjX4vSl98nasit5DUeT B X-Google-Smtp-Source: AGHT+IEuVedUhQA+kCJfUGsky62XCaa5RYhEj5wlonDSHRz5qomVmFJEDP1WYuoc7aB+iWxCpNlm2A== X-Received: by 2002:a17:90a:9a9:b0:299:56ee:6946 with SMTP id 38-20020a17090a09a900b0029956ee6946mr22205pjo.32.1709247639676; Thu, 29 Feb 2024 15:00:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Pavan Nikhilesh , Jerin Jacob Subject: [PATCH 47/71] event/octeontx: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:34 -0800 Message-ID: <20240229225936.483472-48-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/octeontx/timvf_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c index 090b3ed18378..6409d6d1615b 100644 --- a/drivers/event/octeontx/timvf_evdev.c +++ b/drivers/event/octeontx/timvf_evdev.c @@ -42,8 +42,8 @@ timvf_ring_info_get(const struct rte_event_timer_adapter *adptr, struct timvf_ring *timr = adptr->data->adapter_priv; adptr_info->max_tmo_ns = timr->max_tout; adptr_info->min_resolution_ns = timr->tck_nsec; - rte_memcpy(&adptr_info->conf, &adptr->data->conf, - sizeof(struct rte_event_timer_adapter_conf)); + memcpy(&adptr_info->conf, &adptr->data->conf, + sizeof(struct rte_event_timer_adapter_conf)); } static int From patchwork Thu Feb 29 22:58:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137622 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF6BC43BAE; Fri, 1 Mar 2024 00:06:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 771A3433FA; Fri, 1 Mar 2024 00:01:40 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 64044432EA for ; Fri, 1 Mar 2024 00:00:41 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5cdbc4334edso1080819a12.3 for ; Thu, 29 Feb 2024 15:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247640; x=1709852440; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8vcCsDhuWsN3glG3aolJk3c1HTMjImo/ucYVrTc3AQg=; b=FY9TrJj/jzCKVmouMY0Hg5+ieLaYTotd5mz1RNfH1KXn22cWDStE2MqJtXVMfovfSc ljjx73DSqtfonrgAghZ46oJS84tE7sanOvZYL8MCSob3anrLYOX6f87LmsGa+nwlCiXy g/Bvxia4954ZUoi/LRQ3+r/v1ddya/bMpWlVrQE2HSWE7IemTyemJQNIM5yaErpFLsje kKlr7XYlfuo3diiAsMHcDdOv5ci8yTfy1FriYyGSqYDDexbZkSFL/4IKX2nF/5Ju+CMA eyY+6JflblLxmWdazHkgsJKk/tGoUdUCt1FVtci2w1LN/3LR2d+w455ZNqabOXb/gZzv du1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247640; x=1709852440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8vcCsDhuWsN3glG3aolJk3c1HTMjImo/ucYVrTc3AQg=; b=UchzLbvQygYkaV3ppBm9lVPQsR3tOBaMcl6UdXc1FW1b0LCErEK/q+AfwN6reRavbK F9N6NTPW716YrFbHzBx7eCwBHhuWb9UvWZ20evQiMrAFBvrMGaFe2pJYo0032TannEAh u/lewEsMah0h3LxJY1/yx+jAaso4cU18l5zQm1luEB12aWQ7Mq8p3uMBKKjeN/e4HRR0 JahNRxqVG4LZCt2oewfYTLoxLe49wQPvZlorTlc8q8EK6sq+V+9ul3L6W1pGnsRJv6kq cGF3zeCqV0Vd2QpHj5LO+qequs+M/tIJpgBExYTDJll9KhI5IncnLIIR58MGlYgUy/rz 9BnA== X-Gm-Message-State: AOJu0YxH4qbhK7Ll6ykMIy1gtbCl00Sv4JgcwzSvNVdAFtdKN78pvyXV dUd5RfvU+0POSjqlT74sej1KCyQOUGfbRj7xEuHodV3T9PL4ShVT89U8LULv8UVxoQTIw3amHV/ l X-Google-Smtp-Source: AGHT+IGZ1E7OtgIgdndhxGJ1vp5Z2G5noVjDHEAuxVQkL21pdf+rg0GbNk9/FRb42kOuxzvVydNv3Q== X-Received: by 2002:a05:6a21:318c:b0:1a0:e839:abf with SMTP id za12-20020a056a21318c00b001a0e8390abfmr4420525pzb.44.1709247640479; Thu, 29 Feb 2024 15:00:40 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 48/71] mempool/dpaa: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:35 -0800 Message-ID: <20240229225936.483472-49-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa/dpaa_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index 0b484b3d9c7d..f72b51b47271 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.c +++ b/drivers/mempool/dpaa/dpaa_mempool.c @@ -115,8 +115,8 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp) return -ENOMEM; } - rte_memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid], - sizeof(struct dpaa_bp_info)); + memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid], + sizeof(struct dpaa_bp_info)); mp->pool_data = (void *)bp_info; DPAA_MEMPOOL_INFO("BMAN pool created for bpid =%d", bpid); From patchwork Thu Feb 29 22:58:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137623 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B866F43BAE; Fri, 1 Mar 2024 00:06:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6C1043401; Fri, 1 Mar 2024 00:01:41 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 3E15142DBD for ; Fri, 1 Mar 2024 00:00:42 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-29aa8c4710bso1170722a91.1 for ; Thu, 29 Feb 2024 15:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247641; x=1709852441; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MkUNJtSoIYYAMgTw+Jm6s7CNgW9axur4RCVJ0m1KmQU=; b=0WFii2uGnjadR6v4U4GZHBs4Zs18003aHzxJZMBtGmtc54i/C7GWS0GduiZuwy1EBU QpPyRHl8Kh5KagNXZZhIEVpvoMyKXvYyspM3FagdgCy3U+10HWCR8oboX1hpkAAa1dRl l0NRiNhnZQ19kaZmE8m2MoWMOrp//vg22pVdATMMpUMZasltzta2S6w256OPimnr9Cc8 qJYzuU1sWuQCXIxl5x8WKT8AEn0yFAEazIpN8eQ8huzWkXCVyAE/RK0qBNGwM38Fjrww 5/+5bZ9puJxqpkZMlp7P43P7CsgR6Id3nHTf3RQXbYja1uS5mN3xqVEqhDrq6vj7d8DL m/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247641; x=1709852441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkUNJtSoIYYAMgTw+Jm6s7CNgW9axur4RCVJ0m1KmQU=; b=kJ+MF43BLsa6Inv7yfjQ23hLSO3hjkhfQo3oE8Z3axg6WdgLC1/N6riLywjpXYhUzc 9Qv8bpURna02l+c7I49OCT+0MTc/UIFdw7B86hZ8hJKb0dFbCmWwKJjHHR4NRn3HC+Tz 8onSDk+mqw3Ii25gfWL4XjEwHYayMHWHipgfO5mBdaBT7wlErwfWZMUu1sGnwprR76jf 7UsnRnUjwQX3JdkN4nb3NL22ytfZrtTmguMN0Tmj5B+xsAdhNIJ4vUfRI508ATOfDHw5 gVCPrHcQAcMmswHa1YRHr5vVSRSvgyfKThBMfpg9oJBbdCkxZo3t5SX9mPv6PS852CxU 9Gkg== X-Gm-Message-State: AOJu0Yz6NkP5Q+Iw9Gu46Lv11a9vto1JQpvLBJYc4ifxFELIpHGP4Qo+ MHLDcINHR7t52SgmIBWRpNndco6tC3JA3eIMgk0tkuqqjwZ3ZwPnQKjUZHg5DQ9NIC1rlloUCUV C X-Google-Smtp-Source: AGHT+IF/OXDzQzeOy9LLmpZLE9hJ1o6/jixVELJwUJF+M6Vt7V2WPwTxepzB7J/JmUWp29HJc/Y6fg== X-Received: by 2002:a17:90b:1084:b0:29a:525f:4c5 with SMTP id gj4-20020a17090b108400b0029a525f04c5mr503379pjb.12.1709247641293; Thu, 29 Feb 2024 15:00:41 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 49/71] mempool/dpaa2: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:36 -0800 Message-ID: <20240229225936.483472-50-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 4c9245cb814c..8899c0f8e683 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -125,8 +125,8 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp) rte_dpaa2_bpid_info[bpid].bp_list = bp_list; rte_dpaa2_bpid_info[bpid].bpid = bpid; - rte_memcpy(bp_info, (void *)&rte_dpaa2_bpid_info[bpid], - sizeof(struct dpaa2_bp_info)); + memcpy(bp_info, (void *)&rte_dpaa2_bpid_info[bpid], + sizeof(struct dpaa2_bp_info)); mp->pool_data = (void *)bp_info; DPAA2_MEMPOOL_DEBUG("BP List created for bpid =%d", dpbp_attr.bpid); From patchwork Thu Feb 29 22:58:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137624 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 928FF43BAE; Fri, 1 Mar 2024 00:06:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A46B1433E1; Fri, 1 Mar 2024 00:01:43 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 27429432DA for ; Fri, 1 Mar 2024 00:00:43 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-29b10d73630so866693a91.0 for ; Thu, 29 Feb 2024 15:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247642; x=1709852442; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PEwuNOTQWu0Y17XX0KUVhKsbjqIXZhbEqqdqjoqnCTI=; b=usxDEqDMdiT3vHoxDR6AhfvQXleLC2qhgNhbznTe+nqqzOympiN+FQS52gsRPhkXrz RaIv8FoQOp0cQL3+uc1clwxzm/gZOUDqgGGZ2G2direvpfAt1PAOJJzCtoWLL8l4sVh3 ciWDasJoYZazMUNDMQApAIgJqfuVEG5OM3RaIC2JK1xRHdddGkI/6oAS/l65KGkSabap 0JopwZAlr+N0mAcb2hvWUTu4Zk96pAgy7KPAJODwZgFBaBivrp0uusS+uaKMEi9xlUCD EIvefOAcLcEaf/MkApUI07mzWDajACJs11/R6jSJC/n7f4yKUVUw12GPx8WVWIZguNIg wxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247642; x=1709852442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEwuNOTQWu0Y17XX0KUVhKsbjqIXZhbEqqdqjoqnCTI=; b=dc7jcb8/eI8/xhg3RSiH5E6aL5IIBrQXXES70UpxrIz90ZNMOm5kRnIxuJwPc4QaEh 3EarX5JTnP4El/pjMWGpzHwRtskBBlfDlqnm+NXQnedV8MXyyckflgyn5IJF7MFtistN wlv/zv3WER/RBDHaHpSvWZ2uhv6czmTKL69/xI01jInVeF5SztxfxDy/miHAjmdmTxXe VREXpooOBsPqjcc7R5wHh6UZuDQ66RErpMXes7iwfmrUspkVid30zOUBs8IcTdMtRin3 k8oaFr0RI0Lc4oDHgYNUabT0lpJ9gK5LUceeOceiWtPryQCMmiVlMyiQgXk/cYwc7GGn VW2g== X-Gm-Message-State: AOJu0YxWSQywM3/vmERLnXX3H8HI6o+rGGf8KLIlzEtOFBfffIITwg8J Yo+yUa1Ga4FsZcBkinT4gTViIGAYnjDRbGbnypTYfSNaGUl5zzDTwAckdDOt09w2CfTEMk5N1a9 x X-Google-Smtp-Source: AGHT+IG+bpBYHHw+udbF3UJ2t/ElHmz90xW0Z4w+EAjBBFGop2Mt/2g8uMg1uclh2+Q1BdrJsuqirg== X-Received: by 2002:a17:90b:3603:b0:299:1f80:8c44 with SMTP id ml3-20020a17090b360300b002991f808c44mr15944pjb.40.1709247642200; Thu, 29 Feb 2024 15:00:42 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Srikanth Yalavarthi Subject: [PATCH 50/71] ml/cnxk: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:37 -0800 Message-ID: <20240229225936.483472-51-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cn10k_ml_model.c | 8 +++++--- drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++++++---- drivers/ml/cnxk/cnxk_ml_ops.c | 2 +- drivers/ml/cnxk/mvtvm_ml_model.c | 8 +++++--- drivers/ml/cnxk/mvtvm_ml_ops.c | 8 +++++--- 5 files changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/ml/cnxk/cn10k_ml_model.c b/drivers/ml/cnxk/cn10k_ml_model.c index 0325cd54f1f0..4e39a584fa82 100644 --- a/drivers/ml/cnxk/cn10k_ml_model.c +++ b/drivers/ml/cnxk/cn10k_ml_model.c @@ -560,7 +560,7 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set model info */ memset(info, 0, sizeof(struct rte_ml_model_info)); - rte_memcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN); + memcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN); snprintf(info->version, RTE_ML_STR_MAX, "%u.%u.%u.%u", metadata->model.version[0], metadata->model.version[1], metadata->model.version[2], metadata->model.version[3]); @@ -579,7 +579,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set input info */ for (i = 0; i < info->nb_inputs; i++) { - rte_memcpy(input[i].name, io_info->input[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(input[i].name, io_info->input[i].name, + MRVL_ML_INPUT_NAME_LEN); input[i].nb_dims = io_info->input[i].nb_dims; input[i].shape = &io_info->input[i].shape[0]; input[i].type = io_info->input[i].qtype; @@ -590,7 +591,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set output info */ for (i = 0; i < info->nb_outputs; i++) { - rte_memcpy(output[i].name, io_info->output[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(output[i].name, io_info->output[i].name, + MRVL_ML_INPUT_NAME_LEN); output[i].nb_dims = io_info->output[i].nb_dims; output[i].shape = &io_info->output[i].shape[0]; output[i].type = io_info->output[i].qtype; diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c index 834e55e88e9b..e53ada7b1ce4 100644 --- a/drivers/ml/cnxk/cn10k_ml_ops.c +++ b/drivers/ml/cnxk/cn10k_ml_ops.c @@ -668,11 +668,13 @@ cn10k_ml_layer_load(void *device, uint16_t model_id, const char *layer_name, uin } /* Copy metadata to internal buffer */ - rte_memcpy(&layer->glow.metadata, buffer, sizeof(struct cn10k_ml_model_metadata)); + memcpy(&layer->glow.metadata, buffer, + sizeof(struct cn10k_ml_model_metadata)); cn10k_ml_model_metadata_update(&layer->glow.metadata); /* Set layer name */ - rte_memcpy(layer->name, layer->glow.metadata.model.name, MRVL_ML_MODEL_NAME_LEN); + memcpy(layer->name, layer->glow.metadata.model.name, + MRVL_ML_MODEL_NAME_LEN); /* Enable support for batch_size of 256 */ if (layer->glow.metadata.model.batch_size == 0) @@ -748,11 +750,12 @@ cn10k_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * model->subtype = ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL; /* Copy metadata to internal buffer */ - rte_memcpy(&model->glow.metadata, params->addr, sizeof(struct cn10k_ml_model_metadata)); + memcpy(&model->glow.metadata, params->addr, + sizeof(struct cn10k_ml_model_metadata)); cn10k_ml_model_metadata_update(&model->glow.metadata); /* Set model name */ - rte_memcpy(model->name, (char *)model->glow.metadata.model.name, 64); + memcpy(model->name, (char *)model->glow.metadata.model.name, 64); /* Enable support for batch_size of 256 */ if (model->glow.metadata.model.batch_size == 0) diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.c index 971362b24202..f9d0f50e1fc4 100644 --- a/drivers/ml/cnxk/cnxk_ml_ops.c +++ b/drivers/ml/cnxk/cnxk_ml_ops.c @@ -1400,7 +1400,7 @@ cnxk_ml_model_info_get(struct rte_ml_dev *dev, uint16_t model_id, } info = (struct rte_ml_model_info *)model->info; - rte_memcpy(model_info, info, sizeof(struct rte_ml_model_info)); + memcpy(model_info, info, sizeof(struct rte_ml_model_info)); model_info->input_info = info->input_info; model_info->output_info = info->output_info; diff --git a/drivers/ml/cnxk/mvtvm_ml_model.c b/drivers/ml/cnxk/mvtvm_ml_model.c index e3234ae44226..99b4774a2e11 100644 --- a/drivers/ml/cnxk/mvtvm_ml_model.c +++ b/drivers/ml/cnxk/mvtvm_ml_model.c @@ -310,7 +310,7 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo goto tvm_mrvl_model; metadata = &model->mvtvm.metadata; - rte_memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); + memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); snprintf(info->version, RTE_ML_STR_MAX, "%u.%u.%u.%u", metadata->model.version[0], metadata->model.version[1], metadata->model.version[2], metadata->model.version[3]); @@ -327,7 +327,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set input info */ for (i = 0; i < info->nb_inputs; i++) { - rte_memcpy(input[i].name, metadata->input[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(input[i].name, metadata->input[i].name, + MRVL_ML_INPUT_NAME_LEN); input[i].nb_dims = metadata->input[i].ndim; input[i].shape = &model->mvtvm.info.input[i].shape[0]; input[i].type = model->mvtvm.info.input[i].qtype; @@ -338,7 +339,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set output info */ for (i = 0; i < info->nb_outputs; i++) { - rte_memcpy(output[i].name, metadata->output[i].name, MRVL_ML_OUTPUT_NAME_LEN); + memcpy(output[i].name, metadata->output[i].name, + MRVL_ML_OUTPUT_NAME_LEN); output[i].nb_dims = metadata->output[i].ndim; output[i].shape = &model->mvtvm.info.output[i].shape[0]; output[i].type = model->mvtvm.info.output[i].qtype; diff --git a/drivers/ml/cnxk/mvtvm_ml_ops.c b/drivers/ml/cnxk/mvtvm_ml_ops.c index e825c3fb23e6..fca7e0c3c0bc 100644 --- a/drivers/ml/cnxk/mvtvm_ml_ops.c +++ b/drivers/ml/cnxk/mvtvm_ml_ops.c @@ -194,7 +194,7 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * /* Copy mod.so */ model->mvtvm.object.so.addr = mz->addr; model->mvtvm.object.so.size = object[0].size; - rte_memcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.so.addr, object[0].buffer, object[0].size); rte_free(object[0].buffer); @@ -203,7 +203,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * RTE_PTR_ADD(model->mvtvm.object.so.addr, RTE_ALIGN_CEIL(model->mvtvm.object.so.size, RTE_CACHE_LINE_MIN_SIZE)); model->mvtvm.object.json.size = object[1].size; - rte_memcpy(model->mvtvm.object.json.name, object[1].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.json.name, object[1].name, + TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.json.addr, object[1].buffer, object[1].size); rte_free(object[1].buffer); @@ -212,7 +213,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * RTE_PTR_ADD(model->mvtvm.object.json.addr, RTE_ALIGN_CEIL(model->mvtvm.object.json.size, RTE_CACHE_LINE_MIN_SIZE)); model->mvtvm.object.params.size = object[2].size; - rte_memcpy(model->mvtvm.object.params.name, object[2].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.params.name, object[2].name, + TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.params.addr, object[2].buffer, object[2].size); rte_free(object[2].buffer); From patchwork Thu Feb 29 22:58:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137625 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFF6843BAE; Fri, 1 Mar 2024 00:06:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41E1E432BE; Fri, 1 Mar 2024 00:01:45 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id E89B1432E0 for ; Fri, 1 Mar 2024 00:00:43 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-299566373d4so1085587a91.1 for ; Thu, 29 Feb 2024 15:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247643; x=1709852443; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4IfoUpHHXH5RcaWSJbL8DbKLH5aCTDa+W+jP7s5eerI=; b=oQIC7dKhh05jwG8YEOZ70xRFCsbNG+VtjyOujIt/08WGvlntj5lHNnnrVlnr4UEgf+ +RYzY6rrqd5a/WInKoSiIwt2XlmUaG2NTApsdWVKqrGvj6gppAWqx3XNbZzo3dfftzM6 Kl4wbdjiDXuTUr9nlG4mUA2vB/4EGinXhpT0pFXeSPSSO9GanQXHEjq4TR0FGTmyusGE zb9vJC0eRcruhrN8VfKTwGIAEFgTlCT7aO487V30wR2HNUoI+UkoAfGTTHrHivoccqEL PPglWF24MD5P5jCSsUkP6nV1uy17wxFTy8JBUxpETfwqdwPNFegWFHunBIQYxYhuwEfH mivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247643; x=1709852443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4IfoUpHHXH5RcaWSJbL8DbKLH5aCTDa+W+jP7s5eerI=; b=OJntcNKo4zUfUESQJeVSHcOIKOI2pk7TMWbetyLw0XABk1EaBKcrUFQjdZrufzmEZL jzVoslUnYmYZ4CIBszrvUTEx704841mCeO21OWxlkb1IM53cXlf+bNqg3M3YwENWSP0c UqiCwwPOEYCj4frTkehmh0w+ijim8Ddthze36iM1vHWOzSMqs7gQrilJoc9KmiBhoySZ WwJUTuK8nXM66I+0Sq2r2rq4dSm+BJhhaarjmNqoQwUILyD3G45NkA5NNO6R7SlR40/2 wu1p88uvCJj+1rmnBSJm7SDXSf8CVbaOwBrKa09e6paxvVm7PFoInr1n5I8diB6FwcgE OyXQ== X-Gm-Message-State: AOJu0Yxj/TN85Ylz5Ch/aOIpdGNCX7tq5YIOBfHmQmJQl5HHLd2xVdQ4 nzqSo94ylJLaSUVMOS07FcyMx4uXdXkiX0QT2IJKywmeC38tvJ4KSCrcUoHMj4EZ2dYuPlz/l8I V X-Google-Smtp-Source: AGHT+IHk8pHV6HXmX9DmKEY+XaCaiHloX5kyvIO3cWScNiZIaxZLQ+k5BpBTlEy+w75RPBg/b5tGYQ== X-Received: by 2002:a17:90a:990b:b0:29b:10bc:acaf with SMTP id b11-20020a17090a990b00b0029b10bcacafmr22430pjp.30.1709247643155; Thu, 29 Feb 2024 15:00:43 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ciara Loftus Subject: [PATCH 51/71] net/af_xdp: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:38 -0800 Message-ID: <20240229225936.483472-52-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 2d151e45c7cd..8efc0e707a78 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -2094,7 +2094,7 @@ get_iface_info(const char *if_name, if (ioctl(sock, SIOCGIFHWADDR, &ifr)) goto error; - rte_memcpy(eth_addr, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); + memcpy(eth_addr, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); close(sock); return 0; From patchwork Thu Feb 29 22:58:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137626 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D671C43BAE; Fri, 1 Mar 2024 00:06:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D2E943419; Fri, 1 Mar 2024 00:01:46 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id C453F432F6 for ; Fri, 1 Mar 2024 00:00:44 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso1296113a12.0 for ; Thu, 29 Feb 2024 15:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247644; x=1709852444; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nfrm44DPjmag7kpP9gtPqq7De/oX3KXQugUZcgN/YrM=; b=svGTt8x4zpcBYmHl9UkJayK5N58uqocLE04KZQEiDZw3bdgO4LBCPy9NDDPrGVYAzU TEQ5xkGw0asQOyG6VKIWYIoSN0mK6PAXZIeXmuBy43z5xSouWnhchbLFhzsqV8Ns13+7 3YVAfNjYianlZpvEfXtFBvFKyJ4g0D36jtWmzXEcybd/u5HU8HmKGkADWU7ltTnHrTNj EMm89HlTkelLj42Ne6s0/IUmN04eKqekf6cYyGbfZ7GpBqLCz6BXx47Ndh7xEV/pFvny utl1uri7/Z7zGPHXngm3NPO2jZlFLf+Dnhs6z6hLslJEJAg6anjpjN29jgIAv6KGR6Hu fo9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247644; x=1709852444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nfrm44DPjmag7kpP9gtPqq7De/oX3KXQugUZcgN/YrM=; b=fU5QEqEUXVVb/XnUWntQbcr3YEWHs9C2J7fRaOLjrh54K1sDFpJEmNCDduUG5Pa3Tg JH1y67342+K0c+bQy7eOEO8kmqWGudX26pcQXv0z7w1YGlmAlsAmLg5rvykXb89ngGxJ qFdBM1UvzGQuFWcG6sio4Cotm9vNZMGS7/9Shl4QUYUJnEDIuSxipBu7eniwBuK3xLAW lGN3As35BHWVEhZ0BVQwwZLNYefHw6FXRCpfrR+sGNGTZT/053fWbMDQRpRZ7iu3dUl4 f4c4pm6J0aGAYh9bzf4pQSf7VgcckS9XX1V1nJ0tNMvbGKNwwCg3dFVT+KkAqXbvzi6E a0rw== X-Gm-Message-State: AOJu0YyvLxMurXK/7WxvxTbD+OQsZVnKXCfbzgvY6SfTGQOMxu/fhq56 0E/RcqmcuIQ6nefgbUCf+eKQknAVHYLIUxkvD/fT9+dkwNGkgfRFNw28+8ysxIUxwkKsK/TKSV8 1 X-Google-Smtp-Source: AGHT+IGLe+9eh96DA9JF8jF26gLxkeQmDyem+mA9XpO2kA2eZhyLtNZGO5zxefr4V4pH0beep3hFMA== X-Received: by 2002:a05:6a21:394c:b0:1a0:eddb:f2f7 with SMTP id ac12-20020a056a21394c00b001a0eddbf2f7mr4182667pzc.51.1709247644044; Thu, 29 Feb 2024 15:00:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Steven Webster , Matt Peters Subject: [PATCH 52/71] net/avp: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:39 -0800 Message-ID: <20240229225936.483472-53-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 53d9e38c939b..9bd05301720e 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -248,7 +248,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) while (avp_fifo_get(avp->resp_q, (void **)&resp_addr, 1)) PMD_DRV_LOG(DEBUG, "Discarding stale response\n"); - rte_memcpy(avp->sync_addr, request, sizeof(*request)); + memcpy(avp->sync_addr, request, sizeof(*request)); count = avp_fifo_put(avp->req_q, &avp->host_sync_addr, 1); if (count < 1) { PMD_DRV_LOG(ERR, "Cannot send request %u to host\n", @@ -285,7 +285,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) } /* copy to user buffer */ - rte_memcpy(request, avp->sync_addr, sizeof(*request)); + memcpy(request, avp->sync_addr, sizeof(*request)); ret = 0; PMD_DRV_LOG(DEBUG, "Result %d received for request %u\n", From patchwork Thu Feb 29 22:58:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137627 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D02E343BAE; Fri, 1 Mar 2024 00:06:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B76F043421; Fri, 1 Mar 2024 00:01:47 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id B339943302 for ; Fri, 1 Mar 2024 00:00:45 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-299dba8fd24so1099425a91.2 for ; Thu, 29 Feb 2024 15:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247645; x=1709852445; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HJr/Ss1fl8QbNYvRFPhXAtqePcIQdwdA+0iZtITQPSo=; b=d0xS1HxqZHyqHTieYzU8eRvyKFCmyjjNHo1uR4VKVhJcBrhoZ1VOmzKRBWAxicMvbI S85Uec8t/krhzYivMVn+ZDqfDqMwXFrd3wmXCfuYjLq2ItrmOgkYBPI5DOAsoORTlIQc HECHvto/0P9I871T4uvVAgF02hrrK0OWbLGQCgd+PXZvjtUytOFXNFtvUjv0YJLYZM3L BE2KBWbyfHmj3rX65N1vmHwgUCjGyeLRbMDSMXSTyWqNXI5aYHCg5t7+4pAEX213dIuV AWSQUnzcJDPAuwzsvMwrrNiuA11UXk638xzNxfJNtWCtQQNuKevBkbyg4h//EqWTuaQP dX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247645; x=1709852445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HJr/Ss1fl8QbNYvRFPhXAtqePcIQdwdA+0iZtITQPSo=; b=oHjxLXnI7tk+vYM0KwCRQ9MZPv0BW6UOLlEg39B0KEwuG6BtFrH4dG77tRCzAs+Wh3 TgfZCI0LPKFmZ2yf/fU/ppNjp00Lm9WdoHxIx1hbKolTuQuYJfwgKRuKyF7u3/vB+SQN NuyoW+5MYbPBuX8j84Myh/0cZa/9hNTZBSd/M04fCvUr/Dm4LnSa/xRrpHskD4jx1m6d icnj/rz+E07juWicQBOkmb75RuaOOFk9jOwJi8Ch1NHckdByrP14H9bY4d56OMGQBf2k nBUG8fndjSF1Wdz14QAw8y0Yq0sGuYMGZRsRvMNmJmxbOieKjBUXxxkhz0/4Fn4+0QAH j85Q== X-Gm-Message-State: AOJu0YxnYCpvhX7CSRVs4zD4wCRZ0ML9SCUj+5PRxM6rNmfjT3Dn6Snv lcYK4HddO9NpCNgw+sAHS/8EL9wGAEMngXpjQjSuuZIvCREgIGY6rveCiqzl9G6tZgI9sGLV3TT H X-Google-Smtp-Source: AGHT+IF+QdrZJhmOqOSoyFdAb521FmQYmsv8g9w8HRKEluAreVKQmrrdPnzSpW+bmVAARhuASue1Pw== X-Received: by 2002:a17:90a:f405:b0:29b:1658:e575 with SMTP id ch5-20020a17090af40500b0029b1658e575mr34024pjb.19.1709247644841; Thu, 29 Feb 2024 15:00:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Selwin Sebastian Subject: [PATCH 53/71] net/axgbe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:40 -0800 Message-ID: <20240229225936.483472-54-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index dd681f15a01e..7ac30106e335 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -594,7 +594,7 @@ axgbe_dev_rss_hash_update(struct rte_eth_dev *dev, if (rss_conf->rss_key != NULL && rss_conf->rss_key_len == AXGBE_RSS_HASH_KEY_SIZE) { - rte_memcpy(pdata->rss_key, rss_conf->rss_key, + memcpy(pdata->rss_key, rss_conf->rss_key, AXGBE_RSS_HASH_KEY_SIZE); /* Program the hash key */ ret = axgbe_write_rss_hash_key(pdata); @@ -637,7 +637,7 @@ axgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev, if (rss_conf->rss_key != NULL && rss_conf->rss_key_len >= AXGBE_RSS_HASH_KEY_SIZE) { - rte_memcpy(rss_conf->rss_key, pdata->rss_key, + memcpy(rss_conf->rss_key, pdata->rss_key, AXGBE_RSS_HASH_KEY_SIZE); } rss_conf->rss_key_len = AXGBE_RSS_HASH_KEY_SIZE; From patchwork Thu Feb 29 22:58:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137628 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5B9443BAE; Fri, 1 Mar 2024 00:07:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65C3F4342C; Fri, 1 Mar 2024 00:01:49 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id EAFA8432F6 for ; Fri, 1 Mar 2024 00:00:46 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so1051044a12.3 for ; Thu, 29 Feb 2024 15:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247646; x=1709852446; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cjxhR4csAsqJ0aUw/Iixg8P9RLtulDrA5Ua4mBysleI=; b=AAnukQF4k0mnej/6QlFOe9+ORzynMRC+oP7ULH7heL8mL5m0kBB7jJx62iaZxZsZMZ jOIDpTm9Vps3p41fXO+aKOZeuxKYvqSIHj1H7vp+6koec1gP9PLwJgF6L3sFtcTk521X hj9qU3LBsE29Z0Uh1qU5Sj8/afybqE9lvxdBTx8gSKz93UCfxWRAvURfRmV6n49cUT8r gkrAta5bAsgKY/ZdYCd1lwpg8tBAPqdnwlK70RLu8/MrQ3M6/E2Es3moKrL/3oSoI0Cy onGnpd2TawOld5iHF+uUKj6CbU2waTX+Jndr13pFz4G4lm8suDzXtrmvYAXegtwwAW5L q3QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247646; x=1709852446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjxhR4csAsqJ0aUw/Iixg8P9RLtulDrA5Ua4mBysleI=; b=LeByNTr56Wftnt2TmXtSLkCEpNMDPuDm02DJhgd6LwitR/PT6eErZXO5ASQMT2SG3i p7vw86o7R23Zs2ED+EA284aEy4o0u/NpRtiKgCgAZ0WWbW2P+MHFyYqSANCAZeJKoAip MWR0bUgdqijOfgc33NDbCxvAytvybFW9QzZ6Dy21wbdmVsOLeNSVpr9Ds3xecRoI3T0U 1Z+rHifzScvi2inq4nIckAxMhdpY6Ig3/G6VQXheQYaEOQoTmR864XUb31n9apFg9RuO u3lkDvRniS6sgq8xY6XtXLWTK8SW/UXl96q9sWI23eOrV/Ik76akWqpziY2mtM+FR9b1 aspQ== X-Gm-Message-State: AOJu0YzWo4M497CkEd25xTNeYc3G/n/mX7FJvh6RQE2WYptnUD0NZQ7H wsubmLQRm71vACVK/xhKYYVVFnLBFWp0OxQ+37NQADtIPyX/cs1oeFQDotRNVJ6XLb05saSEZZn w X-Google-Smtp-Source: AGHT+IE/EWnuMTX8c9dWH7uiT8u31FQtpQ+ivPulxEt0wXNuc6ZRxu+wXgwDjxyj7/lqxfL+zgFo7g== X-Received: by 2002:a17:90a:de18:b0:29a:97f5:9970 with SMTP id m24-20020a17090ade1800b0029a97f59970mr15052pjv.45.1709247645953; Thu, 29 Feb 2024 15:00:45 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH 54/71] net/bnx2x: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:41 -0800 Message-ID: <20240229225936.483472-55-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci. Note: the indentation in this file does not follow the coding standard of DPDK, so it will get some checkpatch warnings. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 32 +++++++++++++++----------------- drivers/net/bnx2x/bnx2x_stats.c | 10 +++++----- drivers/net/bnx2x/bnx2x_vfpf.c | 19 ++++++++++--------- 3 files changed, 30 insertions(+), 31 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 597ee4335977..16a9ff7f8c06 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -2242,18 +2242,18 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0) tx_parse_bd->parsing_data = (mac_type << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_hi, - &eh->dst_addr.addr_bytes[0], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_mid, - &eh->dst_addr.addr_bytes[2], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_lo, - &eh->dst_addr.addr_bytes[4], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_hi, - &eh->src_addr.addr_bytes[0], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_mid, - &eh->src_addr.addr_bytes[2], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_lo, - &eh->src_addr.addr_bytes[4], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_hi, + &eh->dst_addr.addr_bytes[0], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_mid, + &eh->dst_addr.addr_bytes[2], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_lo, + &eh->dst_addr.addr_bytes[4], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_hi, + &eh->src_addr.addr_bytes[0], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_mid, + &eh->src_addr.addr_bytes[2], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_lo, + &eh->src_addr.addr_bytes[4], 2); tx_parse_bd->data.mac_addr.dst_hi = rte_cpu_to_be_16(tx_parse_bd->data.mac_addr.dst_hi); @@ -6675,8 +6675,7 @@ bnx2x_config_rss_pf(struct bnx2x_softc *sc, struct ecore_rss_config_obj *rss_obj /* Hash bits */ params.rss_result_mask = MULTI_MASK; - rte_memcpy(params.ind_table, rss_obj->ind_table, - sizeof(params.ind_table)); + memcpy(params.ind_table, rss_obj->ind_table, sizeof(params.ind_table)); if (config_hash) { /* RSS keys */ @@ -6742,8 +6741,7 @@ bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac, /* fill a user request section if needed */ if (!rte_bit_relaxed_get32(RAMROD_CONT, ramrod_flags)) { - rte_memcpy(ramrod_param.user_req.u.mac.mac, mac, - ETH_ALEN); + memcpy(ramrod_param.user_req.u.mac.mac, mac, ETH_ALEN); rte_bit_relaxed_set32(mac_type, &ramrod_param.user_req.vlan_mac_flags); @@ -6958,7 +6956,7 @@ static void bnx2x_link_report_locked(struct bnx2x_softc *sc) ELINK_DEBUG_P1(sc, "link status change count = %x", sc->link_cnt); /* report new link params and remember the state for the next time */ - rte_memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); + memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); if (rte_bit_relaxed_get32(BNX2X_LINK_REPORT_LINK_DOWN, &cur_data.link_report_flags)) { diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index c07b01510a06..23c74c21c635 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -114,8 +114,8 @@ bnx2x_hw_stats_post(struct bnx2x_softc *sc) /* Update MCP's statistics if possible */ if (sc->func_stx) { - rte_memcpy(BNX2X_SP(sc, func_stats), &sc->func_stats, - sizeof(sc->func_stats)); + memcpy(BNX2X_SP(sc, func_stats), &sc->func_stats, + sizeof(sc->func_stats)); } /* loader */ @@ -817,10 +817,10 @@ bnx2x_hw_stats_update(struct bnx2x_softc *sc) etherstatspktsover1522octets); } - rte_memcpy(old, new, sizeof(struct nig_stats)); + memcpy(old, new, sizeof(struct nig_stats)); - rte_memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]), - sizeof(struct mac_stx)); + memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]), + sizeof(struct mac_stx)); estats->brb_drop_hi = pstats->brb_drop_hi; estats->brb_drop_lo = pstats->brb_drop_lo; diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c index 63953c2979ce..678c9e7d7d7c 100644 --- a/drivers/net/bnx2x/bnx2x_vfpf.c +++ b/drivers/net/bnx2x/bnx2x_vfpf.c @@ -52,9 +52,9 @@ bnx2x_check_bull(struct bnx2x_softc *sc) /* check the mac address and VLAN and allocate memory if valid */ if (valid_bitmap & (1 << MAC_ADDR_VALID) && memcmp(bull->mac, sc->old_bulletin.mac, ETH_ALEN)) - rte_memcpy(&sc->link_params.mac_addr, bull->mac, ETH_ALEN); + memcpy(&sc->link_params.mac_addr, bull->mac, ETH_ALEN); if (valid_bitmap & (1 << VLAN_VALID)) - rte_memcpy(&bull->vlan, &sc->old_bulletin.vlan, RTE_VLAN_HLEN); + memcpy(&bull->vlan, &sc->old_bulletin.vlan, RTE_VLAN_HLEN); sc->old_bulletin = *bull; @@ -569,7 +569,7 @@ bnx2x_vf_set_mac(struct bnx2x_softc *sc, int set) bnx2x_check_bull(sc); - rte_memcpy(query->filters[0].mac, sc->link_params.mac_addr, ETH_ALEN); + memcpy(query->filters[0].mac, sc->link_params.mac_addr, ETH_ALEN); bnx2x_add_tlv(sc, query, query->first_tlv.tl.length, BNX2X_VF_TLV_LIST_END, @@ -583,10 +583,10 @@ bnx2x_vf_set_mac(struct bnx2x_softc *sc, int set) while (BNX2X_VF_STATUS_FAILURE == reply->status && bnx2x_check_bull(sc)) { /* A new mac was configured by PF for us */ - rte_memcpy(sc->link_params.mac_addr, sc->pf2vf_bulletin->mac, - ETH_ALEN); - rte_memcpy(query->filters[0].mac, sc->pf2vf_bulletin->mac, - ETH_ALEN); + memcpy(sc->link_params.mac_addr, sc->pf2vf_bulletin->mac, + ETH_ALEN); + memcpy(query->filters[0].mac, sc->pf2vf_bulletin->mac, + ETH_ALEN); rc = bnx2x_do_req4pf(sc, sc->vf2pf_mbox_mapping.paddr); if (rc) @@ -622,10 +622,11 @@ bnx2x_vf_config_rss(struct bnx2x_softc *sc, BNX2X_VF_TLV_LIST_END, sizeof(struct channel_list_end_tlv)); - rte_memcpy(query->rss_key, params->rss_key, sizeof(params->rss_key)); + memcpy(query->rss_key, params->rss_key, sizeof(params->rss_key)); query->rss_key_size = T_ETH_RSS_KEY; - rte_memcpy(query->ind_table, params->ind_table, T_ETH_INDIRECTION_TABLE_SIZE); + memcpy(query->ind_table, params->ind_table, + T_ETH_INDIRECTION_TABLE_SIZE); query->ind_table_size = T_ETH_INDIRECTION_TABLE_SIZE; query->rss_result_mask = params->rss_result_mask; From patchwork Thu Feb 29 22:58:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137629 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C724643BAE; Fri, 1 Mar 2024 00:07:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2BAA43423; Fri, 1 Mar 2024 00:01:50 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id A9FD14029E for ; Fri, 1 Mar 2024 00:00:47 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-299b818d63aso1190410a91.0 for ; Thu, 29 Feb 2024 15:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247647; x=1709852447; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1BdvH/jouAqBbSMTjtk2oSIPDlB0H24n6S0x1MNUw1s=; b=2zyJrtZo/udH4i5F0Htc3LaXGCVF+SDLuHE372SKhB1VwXOcAL4nFf8PW6b6UUQteH uYxu158Znt9BHacNxnBYwEs2BAiCBreyUNW9nNNdP2gj2rkvd//rU8XFzqWlUWih8BTM 8C/+fBMGgkos74kIfLpvJ+3O7OVj3NN+a+VAoHbyXB2+rNjaBSdF4IaKDx5YP1HpU5Ig 4m09u8FLwogGS97agneFrappk095mD6Cn2srB6IvJO7JByKNFjlEXpmioMdTIVFLgWTy n83e8GswCWKFUoIrj/SNHAVpTBdG+ybPxdjxAHu7cyHazr3rv0rQolcr8CFwOz9yWsMF BDyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247647; x=1709852447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1BdvH/jouAqBbSMTjtk2oSIPDlB0H24n6S0x1MNUw1s=; b=u7fdb0yWwUZDHVf2/qin1AeGzF+PmaWv0MOC/8i4D4XrXt18wn0e8Y1W6iXWBEhMYt u+amTgoIQuZVHN9qeqTDLjufvSNw/DDXrclYH1oq+znqLU4GidiZyzvoI0zGwBjlluZo SKBNZ7vtB5QD61KjrJOJvbs5vA8RdpQZzvLRqTOcdaL4n+f1BKCBSaSzjCszJDW4NyGE EZyFm/bd/mwN2FHK0IMv+XJj5HA5lQiYq6SQMXoH2qWbaAO9XDHxP2mND81SPExVkLaw CAM4SpJz091GwPPviIjGsdSt4icH62vBoA50foFB0DOlDjLXR5H5WjdTHsHDqp/PGwlz NjMw== X-Gm-Message-State: AOJu0Yx7DnCuTyFcoSRah/jf+KPkrb+K1tij0RUuRyDOqNB6FFw5INx6 JV9coyZ3AuriqIC0BAIMlz3g+G4J1Qd6wizmJa68CXlysCw8hptllDeLZkSRZaWJPi8z3x0GAT6 e X-Google-Smtp-Source: AGHT+IFbkqfFXr+gPLz1AfGJWZ8GHWXUmU5xzGcUYN5lfd7ky7Auz984T1zz59A7KS+L0oquOS3FDQ== X-Received: by 2002:a17:90a:6047:b0:296:f2d5:6567 with SMTP id h7-20020a17090a604700b00296f2d56567mr441226pjm.4.1709247646812; Thu, 29 Feb 2024 15:00:46 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH 55/71] net/bnxt: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:42 -0800 Message-ID: <20240229225936.483472-56-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index f25bc6ff78c7..6466aa394af1 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -233,8 +233,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "DMAC is invalid!\n"); return -rte_errno; } - rte_memcpy(filter->dst_macaddr, - ð_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN); + memcpy(filter->dst_macaddr, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); en |= use_ntuple ? NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR : EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR; @@ -257,8 +258,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "SMAC is invalid!\n"); return -rte_errno; } - rte_memcpy(filter->src_macaddr, - ð_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN); + memcpy(filter->src_macaddr, + ð_spec->hdr.src_addr, + RTE_ETHER_ADDR_LEN); en |= use_ntuple ? NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR : EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR; @@ -423,23 +425,23 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR | EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR; - rte_memcpy(filter->src_ipaddr, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(filter->dst_ipaddr, - ipv6_spec->hdr.dst_addr, 16); + memcpy(filter->src_ipaddr, ipv6_spec->hdr.src_addr, + 16); + memcpy(filter->dst_ipaddr, ipv6_spec->hdr.dst_addr, + 16); if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr, 16)) { - rte_memcpy(filter->src_ipaddr_mask, - ipv6_mask->hdr.src_addr, 16); + memcpy(filter->src_ipaddr_mask, + ipv6_mask->hdr.src_addr, 16); en |= !use_ntuple ? 0 : NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK; } if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr, 16)) { - rte_memcpy(filter->dst_ipaddr_mask, - ipv6_mask->hdr.dst_addr, 16); + memcpy(filter->dst_ipaddr_mask, + ipv6_mask->hdr.dst_addr, 16); en |= !use_ntuple ? 0 : NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK; } @@ -591,8 +593,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - vxlan_spec->hdr.vni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + vxlan_spec->hdr.vni, 3); filter->vni = rte_be_to_cpu_32(tenant_id_be); filter->tunnel_type = @@ -645,8 +647,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "Invalid TNI mask"); return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - nvgre_spec->tni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + nvgre_spec->tni, 3); filter->vni = rte_be_to_cpu_32(tenant_id_be); filter->tunnel_type = From patchwork Thu Feb 29 22:58:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137630 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C21E443BAE; Fri, 1 Mar 2024 00:07:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE28243424; Fri, 1 Mar 2024 00:01:52 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 7CAB84029E for ; Fri, 1 Mar 2024 00:00:48 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5ce2aada130so1311676a12.1 for ; Thu, 29 Feb 2024 15:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247648; x=1709852448; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AajPaKn7ygQ2cAj/mS0n9MAjLbXQRA2KL0MgyQghs3s=; b=UM2OrpT4+UHp04Ov4uegsQLMTmqbWeqdZK3vcdu7sH/u9qiyKhfoHETwOjLgMjkAxv uDJUG/xhKC4T7WwOC+i95ri+Zm9MiaQDrfzGYXWBJOEfE+Ggnb3LqJCb+4W4ozIGWmVd 0ftHGim9g+UNqbD1CGGDUO+iceACeAgXOLkQwUST6r41BHkfUTUsjpcJonryyuxKHoIr WaPFhvud5IZzeTC2T/RU6PwDyfypvsWDRC0vPIxURiFgJtIsSBWagK7BBwlfT7arlqxQ p/+xR9RJduXJilVmo4pv/mCSzIwTWHmixoDJ4WuSl/jyIzg0qq7/fGttnHvBvJodh5rv jsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247648; x=1709852448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AajPaKn7ygQ2cAj/mS0n9MAjLbXQRA2KL0MgyQghs3s=; b=XtzNW69VvOjj3VTRVxyNe3HZO8dVIpJIYlxOVWJEsSoFGS9alKyYrPcCRpyohZmKx5 sxHR28/5zH2TVjXTYOQY5tEMPnXqkrbW1dAugb1wkWaMzXtQ1b4KmfEur1oAfiJRbiBA xGaB1Q09s57omMg/9nM0StuSEsLJc2zqGcvwEusLDWeAtMAzy0ISaF8sXRQrVRwjM8HB T3PGUfHxtczd0VB3NAg6LHPXZaILLRKoCxLQzvUZY9Ot/dzePxXVXbl7aDG+ITw/93JX O9O4LBnEgRvE8LBpfWJzmlR7T+gWitmkCX9JmIlwYTkc4bIl8MayULFRXT84MYKbJ2xF 0l8w== X-Gm-Message-State: AOJu0YxhcAdJvv2seviaV4MFrMmpwRwGUo4USzwq5sdQI052ia9ptK2B hLobO8fM3HyjBlxoQI9f6UvA/T7hX6bzCMrFfL5ZScBzL7CKjVz+4F254RcShQoT9zYB+3EUK1S 2 X-Google-Smtp-Source: AGHT+IGcpV4aIYkQncB56AWOoPiQr0M5zq1hWxOKzapfJPz2uZIXkN9+AyUYKxDQ15u0JTkULsDoAQ== X-Received: by 2002:a17:90a:b88:b0:29a:76f5:6557 with SMTP id 8-20020a17090a0b8800b0029a76f56557mr35101pjr.19.1709247647724; Thu, 29 Feb 2024 15:00:47 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chas Williams , "Min Hu (Connor)" Subject: [PATCH 56/71] net/bonding: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:43 -0800 Message-ID: <20240229225936.483472-57-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- drivers/net/bonding/rte_eth_bond_flow.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 79f1b3f1a0f2..8ddf5dc80aff 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1539,10 +1539,10 @@ rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id, info->selected = port->selected; info->actor_state = port->actor_state; - rte_memcpy(&info->actor, &port->actor, sizeof(port->actor)); + memcpy(&info->actor, &port->actor, sizeof(port->actor)); info->partner_state = port->partner_state; - rte_memcpy(&info->partner, &port->partner, sizeof(port->partner)); + memcpy(&info->partner, &port->partner, sizeof(port->partner)); info->agg_port_id = port->aggregator_port_id; return 0; diff --git a/drivers/net/bonding/rte_eth_bond_flow.c b/drivers/net/bonding/rte_eth_bond_flow.c index 5d0be5caf54b..bb9d347e2be4 100644 --- a/drivers/net/bonding/rte_eth_bond_flow.c +++ b/drivers/net/bonding/rte_eth_bond_flow.c @@ -182,7 +182,7 @@ bond_flow_query_count(struct rte_eth_dev *dev, struct rte_flow *flow, count->hits = 0; count->bytes_set = 0; count->hits_set = 0; - rte_memcpy(&member_count, count, sizeof(member_count)); + memcpy(&member_count, count, sizeof(member_count)); for (i = 0; i < internals->member_count; i++) { ret = rte_flow_query(internals->members[i].port_id, flow->flows[i], action, From patchwork Thu Feb 29 22:58:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137631 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E5A43BAE; Fri, 1 Mar 2024 00:07:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A13343435; Fri, 1 Mar 2024 00:01:57 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 56E5D4029E for ; Fri, 1 Mar 2024 00:00:49 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso1296172a12.0 for ; Thu, 29 Feb 2024 15:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247648; x=1709852448; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OEuU8lt6jliQgN/Zn/GWIVDAUxPwXJnWEslwIl4Qoao=; b=tK8eNmrRaRI+RbZj+UD5W2/2PRlWhrhUerze50n9qV9bo5Nqht3Dxr1RRbOh99DWo2 O4xGo6uS2NaBrbmqHacuqzhJZxsgD6Ug2Bls0ED5YxZhXT1XnARUBnPvBzoPd+RpCXdM dSPHZ5MajRjS/aZeJxq/2dSVKaJ3RWU3+cZz97dQQyYJJlhgDr+kYB36gokHYgM47wbc CLKKqGfPVHK4F2n58F0sKouTR9wJmQAdhnNTACg0uXYQzW7xkj2nS7NVhz/lVvHI0H4h IFdy0cjl/pBI1tTWxUwRWEg6eDi9qmUEUXMy6S9ljGg0HOhsOqWWWsC3OMX/1eQuRGvd mQow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247648; x=1709852448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OEuU8lt6jliQgN/Zn/GWIVDAUxPwXJnWEslwIl4Qoao=; b=rOgkBB8/OsRG3ZXQh1lnXs6pt3c9DoHDzPIqh/+gs3oS1nOfmY2Tyv2DeY7Ji+OXQs n68AhYo7GE1oFvOFmZPDpJ4fR1nNs+jMGkD1p7I6wt+GGRLU+D9gNgv/ma/JzKJuCuuU ZM2WwlK9a+u/W8ZfI1L8H71Y7oMc3EOdmP7ziCWpWgaaafcBojnMRpZ2/qkSv+PmvWaq VWjueaqtzVn9NUZ3hBh+itPY2lGOnwVvaIxNKIfik+Fl/nH2NVpDu4CjP3mLAqel/45K EvHEPe9BeC4tgPC1ggkMFqKsscROHjTrgD4tWh0ao1AaqRZ8ajdXITdAoTKOyXOLnVW+ mmaA== X-Gm-Message-State: AOJu0Yw/bQRCo83XcNoQHePcSbLalIfVKl1N70sru9+3kXojPdd8gPio KZsR0mSyRrM8EfnWIhSSOU0QD2Cih2MeXbOVvcWUfkovDne3d8v6DAcVz6OoodjiDzF++CSzwfp v X-Google-Smtp-Source: AGHT+IEuNQ9A8JbUCMLAQ0adlWOuHa3MRQj+aj7kYPO+xut6tmLe0NnBpoUyb6FPdgcPEA91wD8lUA== X-Received: by 2002:a17:90b:892:b0:299:5401:89d2 with SMTP id bj18-20020a17090b089200b00299540189d2mr18809pjb.45.1709247648611; Thu, 29 Feb 2024 15:00:48 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH 57/71] net/cnxk: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:44 -0800 Message-ID: <20240229225936.483472-58-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +- drivers/net/cnxk/cnxk_tm.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c index 5de2919047c1..ee407b177ec0 100644 --- a/drivers/net/cnxk/cnxk_ethdev_ops.c +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c @@ -451,7 +451,7 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr) } /* Update mac address to cnxk ethernet device */ - rte_memcpy(dev->mac_addr, addr->addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(dev->mac_addr, addr->addr_bytes, RTE_ETHER_ADDR_LEN); exit: return rc; diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c index c799193cb89b..5c8b0997ca7c 100644 --- a/drivers/net/cnxk/cnxk_tm.c +++ b/drivers/net/cnxk/cnxk_tm.c @@ -300,8 +300,7 @@ cnxk_nix_tm_shaper_profile_add(struct rte_eth_dev *eth_dev, uint32_t id, profile->profile.pkt_len_adj = params->pkt_length_adjust; profile->profile.pkt_mode = params->packet_mode; profile->profile.free_fn = rte_free; - rte_memcpy(&profile->params, params, - sizeof(struct rte_tm_shaper_params)); + memcpy(&profile->params, params, sizeof(struct rte_tm_shaper_params)); rc = roc_nix_tm_shaper_profile_add(nix, &profile->profile); @@ -373,7 +372,7 @@ cnxk_nix_tm_node_add(struct rte_eth_dev *eth_dev, uint32_t node_id, if (!node) return -ENOMEM; - rte_memcpy(&node->params, params, sizeof(struct rte_tm_node_params)); + memcpy(&node->params, params, sizeof(struct rte_tm_node_params)); node->nix_node.id = node_id; node->nix_node.parent_id = parent_node_id; From patchwork Thu Feb 29 22:58:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137632 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE97F43BAE; Fri, 1 Mar 2024 00:07:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F71343436; Fri, 1 Mar 2024 00:01:59 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 76EA643306 for ; Fri, 1 Mar 2024 00:00:50 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-29a8911d11cso1031037a91.1 for ; Thu, 29 Feb 2024 15:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247649; x=1709852449; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5nmo9BK1Og/gZ6s0zOgoE7yxSApmEIe1cya3yqZhKEg=; b=X4gRR8+JuCSw+btVZsL+KaG4vlF6Wd4AwHZeVdfxaTYLeC1Gw1Jh23slj9lnldQ6h/ j+VpHqe5pryS6Aw9lSzBGdXjc4ildNBeSl2E33B0nWTeTqDr1a8IQcPAOmVno4SkmpV7 MFGAmN7QZ7AOEDv4NPCOVB/+MlYeONNvhQreIBZRZVS16ZIIpIQ6QklbitUWWilrknyz 6+VKrZN2RHb9d0mKcsc3jVN+5XFlggpPZf+O5e+LaLWzeP8IbxYKSQ/3meOw9hwQ0wMd 42/O2gbO1FODwrb7Z8uq3SfW4TvAaSucpU2qYlODmQkNTunDYD0RYrot6DRZapecrE+e eNIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247649; x=1709852449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nmo9BK1Og/gZ6s0zOgoE7yxSApmEIe1cya3yqZhKEg=; b=K3tOXiviVy5a6qGH2GrKBMs1iCC/TpWQPUMsOsRyiwd7JXu6jvbq9EWtP2s5D2jhHv 7wUr6N28f5FsRRDb32tlIHNJuxzMXsEaIsJ8IYclS75kBwa13D98uWqeLiTl06qncI0U BA6b1y8KfTtFinif4iUBPoqo3PbpJOiYQ/JkPt27GJy8eeQujr473lb/G2Vh8y2X3B5p pijs0mkUusRG9zeO/n6kdFFqDj5PeYF1oiB6khuX16hOnVH3uUqCbBgWGUjgxZ3ZiYe6 w3ZtGmQ6G84Gtsi1XODM9qMTKiuw12N/23PKefyngboyfgSIbumYXjsbzL8Y7zJAG8XM ctJA== X-Gm-Message-State: AOJu0YxXKw2GEEHbJcvLfX+/EppmqL5OWQkvvQKl4bx0SJ+ip76L0IVl oBygCa3di6DkmndjcYf4dtgvuI0p6EyPGMt6a4BlA6obwfrrSg5yKRocLHMINzffmiQQXFbRvV4 n X-Google-Smtp-Source: AGHT+IEpXRzS577SQTncmM/XxTwJlemk3AVzONQqEGH/7p881ElNT4r4+2v5lokLJX/O5mLzkrlRDw== X-Received: by 2002:a17:90b:60b:b0:296:416e:ce88 with SMTP id gb11-20020a17090b060b00b00296416ece88mr18938pjb.49.1709247649506; Thu, 29 Feb 2024 15:00:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang Subject: [PATCH 58/71] net/cpfl: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:45 -0800 Message-ID: <20240229225936.483472-59-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_vchnl.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ef19aa1b6a96..1037aec68d2d 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -2292,7 +2292,8 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *a strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); - rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&base->caps, &req_caps, + sizeof(struct virtchnl2_get_capabilities)); ret = idpf_adapter_init(base); if (ret != 0) { diff --git a/drivers/net/cpfl/cpfl_vchnl.c b/drivers/net/cpfl/cpfl_vchnl.c index 7d277a0e8e83..e914014d8a9b 100644 --- a/drivers/net/cpfl/cpfl_vchnl.c +++ b/drivers/net/cpfl/cpfl_vchnl.c @@ -32,7 +32,7 @@ cpfl_cc_vport_list_get(struct cpfl_adapter_ext *adapter, return err; } - rte_memcpy(response, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(response, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); return 0; } @@ -66,7 +66,7 @@ cpfl_cc_vport_info_get(struct cpfl_adapter_ext *adapter, return err; } - rte_memcpy(response, args.out_buffer, sizeof(*response)); + memcpy(response, args.out_buffer, sizeof(*response)); return 0; } From patchwork Thu Feb 29 22:58:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137633 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A82B443BAE; Fri, 1 Mar 2024 00:07:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C11A14343E; Fri, 1 Mar 2024 00:02:00 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 320A443254 for ; Fri, 1 Mar 2024 00:00:51 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-299dba8fd24so1099520a91.2 for ; Thu, 29 Feb 2024 15:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247650; x=1709852450; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=; b=X1E/9M0XwYWw5xtz9PgwjtfRFAeAlmcgeB/VYeDkMtPR/jGAuyMLXJF14HlKRzNg/f qXc0gfT8LInae8jUbSkjXZoWTR/N//hj+zXwveJCKk3NMkANs+7x1H/uj9c7chnj1DDH 2Y3Ewbh+PXv5Y3Qb4mhFTAZGK4mUCcFNjT3kd8D+Tq6rDqaHh9LzWz1gHOcLWJJ1p8/m OQPX1SZfMRrCXzYvpdkjgEITWax+O+RbU4JViG8QDQkKv4LMn6rMXyqLpzshhs64rrbO TNs9476JZaAMBkWPhFB4hjG5s55IEsY56n4dUP0qvaOu8PZhz7h4bFem5VlATOW0Lr/I Ljww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247650; x=1709852450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=; b=UJw9xS909HB6oDH2tCZgnOnzGG4QXb4U2F7EZUz9ehSu4zIYW6OTqN4aXX7euf4tRB viZfSdj5i4FXhv/eW9V9gctc9VGsFYAJNoTT0aq1ECcJf/qnKcv/mcFa95yz/O7lPjVE //WgLYPnIV0K5XgD9h8+AwCXLnv+EScKs0Z7zVr7yh0R+g3vsC5joPFDPndMGCn0jFp3 hAJ5kweVf8wn/KFnfQmk6ADO9Ed4aea6HFDv4f+1V2h8o8X5egENndDrR6qEPrUq8SQV jenIFtgy1Lo6wr2FTuMbWBOR84LG34zNptLjO30HnVOfSOzfXyottGdzGQmS8khlcRdj zecw== X-Gm-Message-State: AOJu0YwBiOYfx6qXhom/W5WPwejwyI8GD4tbrvY3QINegzyWpYbcisDd Bi79xPnNczluPDeZ8ypegNdCKCoVeCY0aTKxFloEo/GFmYHJIdStX0Zq4QSdZLbY2l3IshEWkQO m X-Google-Smtp-Source: AGHT+IFEtoIer21yr2h4D06qUfHaMDaeAmhRxfm5PuLfWRZ+Gsb1QuLK3H3b6/M16OkPdmRgTKlszA== X-Received: by 2002:a17:90a:8c9:b0:299:3f2a:4309 with SMTP id 9-20020a17090a08c900b002993f2a4309mr39205pjn.18.1709247650340; Thu, 29 Feb 2024 15:00:50 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH 59/71] net/cxgbe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:46 -0800 Message-ID: <20240229225936.483472-60-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/clip_tbl.c | 2 +- drivers/net/cxgbe/cxgbe_filter.c | 8 ++++---- drivers/net/cxgbe/l2t.c | 4 ++-- drivers/net/cxgbe/smt.c | 20 +++++++++----------- 4 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/net/cxgbe/clip_tbl.c b/drivers/net/cxgbe/clip_tbl.c index b709e26f6aa9..d30fa6425f28 100644 --- a/drivers/net/cxgbe/clip_tbl.c +++ b/drivers/net/cxgbe/clip_tbl.c @@ -115,7 +115,7 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev, if (ce) { t4_os_lock(&ce->lock); if (__atomic_load_n(&ce->refcnt, __ATOMIC_RELAXED) == 0) { - rte_memcpy(ce->addr, lip, sizeof(ce->addr)); + memcpy(ce->addr, lip, sizeof(ce->addr)); if (v6) { ce->type = FILTER_TYPE_IPV6; __atomic_store_n(&ce->refcnt, 1, diff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c index 5a7efe7a733e..3d1d087ec215 100644 --- a/drivers/net/cxgbe/cxgbe_filter.c +++ b/drivers/net/cxgbe/cxgbe_filter.c @@ -851,10 +851,10 @@ static int set_filter_wr(struct rte_eth_dev *dev, unsigned int fidx) fwr->ivlanm = cpu_to_be16(f->fs.mask.ivlan); fwr->ovlan = cpu_to_be16(f->fs.val.ovlan); fwr->ovlanm = cpu_to_be16(f->fs.mask.ovlan); - rte_memcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip)); - rte_memcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm)); - rte_memcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip)); - rte_memcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm)); + memcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip)); + memcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm)); + memcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip)); + memcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm)); fwr->lp = cpu_to_be16(f->fs.val.lport); fwr->lpm = cpu_to_be16(f->fs.mask.lport); fwr->fp = cpu_to_be16(f->fs.val.fport); diff --git a/drivers/net/cxgbe/l2t.c b/drivers/net/cxgbe/l2t.c index 21f4019ae626..7721c7953ec0 100644 --- a/drivers/net/cxgbe/l2t.c +++ b/drivers/net/cxgbe/l2t.c @@ -82,7 +82,7 @@ static int write_l2e(struct rte_eth_dev *dev, struct l2t_entry *e, int sync, V_L2T_W_NOREPLY(!sync)); req->l2t_idx = cpu_to_be16(l2t_idx); req->vlan = cpu_to_be16(e->vlan); - rte_memcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN); + memcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN); if (loopback) memset(req->dst_mac, 0, RTE_ETHER_ADDR_LEN); @@ -155,7 +155,7 @@ static struct l2t_entry *t4_l2t_alloc_switching(struct rte_eth_dev *dev, e->state = L2T_STATE_SWITCHING; e->vlan = vlan; e->lport = port; - rte_memcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN); + memcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN); __atomic_store_n(&e->refcnt, 1, __ATOMIC_RELAXED); ret = write_l2e(dev, e, 0, !L2T_LPBK, !L2T_ARPMISS); if (ret < 0) diff --git a/drivers/net/cxgbe/smt.c b/drivers/net/cxgbe/smt.c index 4e14a73753de..a74b2e0794e6 100644 --- a/drivers/net/cxgbe/smt.c +++ b/drivers/net/cxgbe/smt.c @@ -55,26 +55,24 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e) */ if (e->idx & 1) { req->pfvf1 = 0x0; - rte_memcpy(req->src_mac1, e->src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac1, e->src_mac, RTE_ETHER_ADDR_LEN); /* fill pfvf0/src_mac0 with entry * at prev index from smt-tab. */ req->pfvf0 = 0x0; - rte_memcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac, + RTE_ETHER_ADDR_LEN); } else { req->pfvf0 = 0x0; - rte_memcpy(req->src_mac0, e->src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac0, e->src_mac, RTE_ETHER_ADDR_LEN); /* fill pfvf1/src_mac1 with entry * at next index from smt-tab */ req->pfvf1 = 0x0; - rte_memcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac, + RTE_ETHER_ADDR_LEN); } row = (e->hw_idx >> 1); } else { @@ -87,8 +85,8 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e) /* fill pfvf0/src_mac0 from smt-tab */ t6req->pfvf0 = 0x0; - rte_memcpy(t6req->src_mac0, s->smtab[e->idx].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(t6req->src_mac0, s->smtab[e->idx].src_mac, + RTE_ETHER_ADDR_LEN); row = e->hw_idx; req = (struct cpl_smt_write_req *)t6req; } @@ -158,7 +156,7 @@ static struct smt_entry *t4_smt_alloc_switching(struct rte_eth_dev *dev, t4_os_lock(&e->lock); if (__atomic_load_n(&e->refcnt, __ATOMIC_RELAXED) == 0) { e->pfvf = pfvf; - rte_memcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN); + memcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN); ret = write_smt_entry(dev, e); if (ret) { e->pfvf = 0; From patchwork Thu Feb 29 22:58:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137634 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAD4343BAE; Fri, 1 Mar 2024 00:07:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33CDB43441; Fri, 1 Mar 2024 00:02:02 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 4714B43312 for ; Fri, 1 Mar 2024 00:00:52 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-299ea1f1989so1113453a91.0 for ; Thu, 29 Feb 2024 15:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247651; x=1709852451; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xv2g9Jo+DqiSnwHtWo/W83oWOJcmG/jpHUqtxWJGkFQ=; b=nnqZp3+vzvx7mG02iPCOKXWuU4T8AwpVnHUTmBoV6MOPDB7wRnxC1yl7PPU7vIA7NC PZKcgauyhUuN78jkcXF8Qj6UQw7/pFqSaO5DkFp7dbXZ/cYu0AO7c9QTDDlVg4RTCG/A zNlKAraWzI7KvHVG/fAY7R0p7Fd3qPpDcHkUk8uhn21u7uJJIkLnsF2T3AdxU+0msS+y +cvmXkNk3MYhUvh0gdtKuVXrXcDloBfE40F1pqgv12bifL3olqEJrmYaC+U7u8CH1hGP qZ02xFfVSpGf/EoMPs65su5nYotcip2RXSojWKgBFUWn0I6y1FPTq7ICtI7ZeQEzlwWz No2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247651; x=1709852451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xv2g9Jo+DqiSnwHtWo/W83oWOJcmG/jpHUqtxWJGkFQ=; b=OvT8kLDXEb4T2a+AWYMCih9rITTyol8BlqyMYr8meUPXN1gM8s/w1ydAwxYrgLPpql 4afuTErVb0zh9X3PgbAVbW49VLGJBIGGO+Buv8TNBUUA38y6FG/oso0dM+BnEnC9gLqC Q9aEnc5nV2Kc32Za2e7y/Z3yrrxjhTISDZdrEK2G9cAr0A3SfVY+3jPDJXVw6K+uCpgB nAgvqLGYTiFFKJjduinjCAvMLKpJIvOdPtoyfTmxG3GljPHdIUpBBwEYNdbNZSUehYsb aqcjoUpqy4TFEn+jgL8gY1WFJkzjMCcL0wuCmBeXRqFhz3qNSIRLMDnGCA4oADDh285v oh/w== X-Gm-Message-State: AOJu0YyEe+OKH5zcN4j/ZnV3XQRYR+vWMAUz1BIHEO3P8m3Sm4Ni1UK6 j8Ph2Zm2dk6MjAVMn2ZCaN+xg24IaSLHAa+zw3YZYwvIg5NOy4O0DGQxTsHE4yd3miIr1wtxoFp b X-Google-Smtp-Source: AGHT+IHbH8sweHEmNK6GI++/wOmqABMZ4GEYN1zhJfWJ2Uc0XaCulVOpiHyOBnY87AkdglCvYtiF5A== X-Received: by 2002:a17:90a:f60b:b0:29b:2019:9577 with SMTP id bw11-20020a17090af60b00b0029b20199577mr20445pjb.41.1709247651420; Thu, 29 Feb 2024 15:00:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 60/71] net/dpaa2: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:47 -0800 Message-ID: <20240229225936.483472-61-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_tm.c b/drivers/net/dpaa2/dpaa2_tm.c index 8fe5bfa013bb..1749b1be2295 100644 --- a/drivers/net/dpaa2/dpaa2_tm.c +++ b/drivers/net/dpaa2/dpaa2_tm.c @@ -324,7 +324,7 @@ dpaa2_shaper_profile_add(struct rte_eth_dev *dev, uint32_t shaper_profile_id, NULL, NULL); profile->id = shaper_profile_id; - rte_memcpy(&profile->params, params, sizeof(profile->params)); + memcpy(&profile->params, params, sizeof(profile->params)); LIST_INSERT_HEAD(&priv->shaper_profiles, profile, next); From patchwork Thu Feb 29 22:58:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137635 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BADC43BAE; Fri, 1 Mar 2024 00:07:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C614343B; Fri, 1 Mar 2024 00:02:03 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 1381C432DE for ; Fri, 1 Mar 2024 00:00:53 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-29b10d73630so866864a91.0 for ; Thu, 29 Feb 2024 15:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247652; x=1709852452; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=; b=PGICq3QwRIMYHIy9PswUuE3ERvhLPDyu2imV6oZELHBzJxPnaX5W3qCW0IQKoiFIrW 5P1LPs/AbxGQESXK9qjcVutT+y4Wko0JyTaa/Umud2xwNaNdMWBQA1Avs6e7b+Dx2rhe cya7fvpu59YRzvejzyz2d9MTgN4xU1srWYUdrRZ8TNT1XMQf7DTkO1LeVpsqfyYG0QjE dqJ0s8balO/Bt48YR7GxaF4HTlMB5BOTfbpE/yS4/ziSbEAgBSHng/zN6imcMiBA0Xo5 X7fe3a0rjUv7klwHl8nKskyrHlsR84j50WAJrEm4Cvucdtg87ROBr4ZUQfQfFqETY72T Xykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247652; x=1709852452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=; b=HKJbtFVT/DTlBcEha5015ZKkEuUBfN4P0tEDvTwbjeufcHZE6DCwCjW1oCZzE/CBz5 QskEKPY41YU0ZU4+/An06y0TfbnI+VE5kEAjgpLxv/3xtM18Ifl9z74k1MPBTrtpFVx6 ieP00M9JfPBd+YkotWH6NLTKy1Ph42DdyKmCetcOdyFbf/qhFbRbkU+uSGppcN9hHBD+ 16JnqpTi1kDZZacYeRV8QgBadr78laTUShiO6GnbFCG0G0WSEIL4NT870FhMfaeR3MEk yXxu6NEPih/F2N/KNaUCrAu2kEidfZKLraCg87he7Z2oFkLPf8GjSVqdZ2C87y1uYN2q 4wTg== X-Gm-Message-State: AOJu0YxhfpMcX4evvzztfycDkXFr+SLeljzrSdSs0l8gFj5hVI1bP9s/ nADUC+HiejXgagUfeWlDwiUR2+lbl/WzwpMqibHJ3rAd94XfqgBdltZUgxoEMPv0W8RChDLEimp h X-Google-Smtp-Source: AGHT+IHAVUS7D6XrQ0doo363XkJDeioImSeezY687ySQb/PAxMdCK0pN7eZuHLn6LbBAZMBtO3ST7Q== X-Received: by 2002:a17:90b:1e51:b0:29b:6a1:4036 with SMTP id pi17-20020a17090b1e5100b0029b06a14036mr70979pjb.0.1709247652431; Thu, 29 Feb 2024 15:00:52 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 61/71] net/e1000: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:48 -0800 Message-ID: <20240229225936.483472-62-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_flow.c | 22 ++++++++++------------ drivers/net/e1000/igb_pf.c | 6 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index ea9b290e1cb5..8bca48496035 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1484,9 +1484,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&igb_filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -1511,9 +1511,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&igb_filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -1536,9 +1536,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&igb_filter_syn_list, syn_filter_ptr, entries); @@ -1562,9 +1561,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&flex_filter_ptr->filter_info, - &flex_filter, - sizeof(struct igb_flex_filter)); + memcpy(&flex_filter_ptr->filter_info, &flex_filter, + sizeof(struct igb_flex_filter)); TAILQ_INSERT_TAIL(&igb_filter_flex_list, flex_filter_ptr, entries); flow->rule = flex_filter_ptr; diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index c7588ea57eaa..7e2ea3bdbcc1 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -290,7 +290,7 @@ igb_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = E1000_VF_RESET | E1000_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); e1000_write_mbx(hw, msgbuf, 3, vf); return 0; @@ -308,8 +308,8 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) if (rte_is_unicast_ether_addr((struct rte_ether_addr *)new_mac)) { if (!rte_is_zero_ether_addr((struct rte_ether_addr *)new_mac)) - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, - sizeof(vfinfo[vf].vf_mac_addresses)); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, + sizeof(vfinfo[vf].vf_mac_addresses)); hw->mac.ops.rar_set(hw, new_mac, rar_entry); rah = E1000_READ_REG(hw, E1000_RAH(rar_entry)); rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf)); From patchwork Thu Feb 29 22:58:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137636 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 514C943BAE; Fri, 1 Mar 2024 00:07:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F361D43383; Fri, 1 Mar 2024 00:02:04 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 3DEF14331A for ; Fri, 1 Mar 2024 00:00:54 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5dbcfa0eb5dso1392114a12.3 for ; Thu, 29 Feb 2024 15:00:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247653; x=1709852453; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JOANpzi1ifQoaA4VhE1b6CgmCmpwuT76cyLQX4CJIYs=; b=DMlubYdH4gF9sVsSYhUVoQVC1TYh78+/qFvHi90oJtrz2AN3aG1uJvuVe6ehEBHDDT yuIq+NKUIp7ueQtV3r51eBtN6hC99Hg++dCN0c+AQSbHL9UHYCeg9CraTwkP3c6FIzpo MYrNll36JgZt3jYYldzWERtY+lJ7rSsGcvXg9pbiS10h2BQpkHUQOnrSt8WTwaBmE0pN hJ+5FVyCFpSKfSHPrBjoZdryqPxO7fcKmVs5MdIwAiP9Q2Z9QO4uCCwPVoNHXFZslozi +ug/6loTLX2w3bZJSNXGhHmUzISlmjlWElK4gt8f6ClzNvUeP+ZZ8bMUNCPTljMCmCaL 6uNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247653; x=1709852453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JOANpzi1ifQoaA4VhE1b6CgmCmpwuT76cyLQX4CJIYs=; b=syHOZSxg9RJjkBQ2kGjPc/MIEk4eH9ZeZ3JhVldLPjNU7FQP0/wx187d03LuI8Bli5 rFmj14pQBHNEE3E+ZzwBfRsMwUOLX2NIk3p1ewIIJOrTar3fQXN+zSaMnIs59Ugo3LNM /LmONTpOgqyMJ+Txy1f/ll6MTHewDPdWvwHd6r1HhzetatWqcvie0qxyDbmF252Dwa3C HM0S/1EoHWjDFiYY3GEeWhtBaWXl1Ohe/bt8oERpAaS6K+mikhvVO+rdVsKA99jCbCGC mg+c9JH9c6YMBkEsHU9XhOv/dAcXHHAfGSCQ8Q7pQIS1oFWdedJtFNkygefOcid2JqJ+ DSWA== X-Gm-Message-State: AOJu0YxaZY2eMdt/NmsE0bhqUiX+L6WMgeh5MhXmB8mUS0jgA0Q/MmvR D9V56GyYBjqJcKppZJfccr4Gw03+FonmswPuVHxFygFD9l655SNvfj4ly69cjrd1eqGvoetqnqk D X-Google-Smtp-Source: AGHT+IEPW2mVihGibU/z4eXgiTxLTMOYmPZ9feEGtq35XjJlvtniw0yJxMx3NPVHX9VMc6A7ufTm6w== X-Received: by 2002:a17:90a:7566:b0:299:6627:2fa2 with SMTP id q93-20020a17090a756600b0029966272fa2mr32258pjk.17.1709247653297; Thu, 29 Feb 2024 15:00:53 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , John Daley , Hyong Youb Kim Subject: [PATCH 62/71] net/enic: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:49 -0800 Message-ID: <20240229225936.483472-63-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index a6aaa760ca91..a940c160c9f1 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1221,8 +1221,8 @@ static int enic_set_rsskey(struct enic *enic, uint8_t *user_key) /* Save for later queries */ if (!err) { - rte_memcpy(&enic->rss_key, rss_key_buf_va, - sizeof(union vnic_rss_key)); + memcpy(&enic->rss_key, rss_key_buf_va, + sizeof(union vnic_rss_key)); } enic_free_consistent(enic, sizeof(union vnic_rss_key), rss_key_buf_va, rss_key_buf_pa); @@ -1243,7 +1243,7 @@ int enic_set_rss_reta(struct enic *enic, union vnic_rss_cpu *rss_cpu) if (!rss_cpu_buf_va) return -ENOMEM; - rte_memcpy(rss_cpu_buf_va, rss_cpu, sizeof(union vnic_rss_cpu)); + memcpy(rss_cpu_buf_va, rss_cpu, sizeof(union vnic_rss_cpu)); err = enic_set_rss_cpu(enic, rss_cpu_buf_pa, @@ -1254,7 +1254,7 @@ int enic_set_rss_reta(struct enic *enic, union vnic_rss_cpu *rss_cpu) /* Save for later queries */ if (!err) - rte_memcpy(&enic->rss_cpu, rss_cpu, sizeof(union vnic_rss_cpu)); + memcpy(&enic->rss_cpu, rss_cpu, sizeof(union vnic_rss_cpu)); return err; } From patchwork Thu Feb 29 22:58:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137637 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91E2F43BAE; Fri, 1 Mar 2024 00:08:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FAC44344A; Fri, 1 Mar 2024 00:02:06 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 3EC1B432DE for ; Fri, 1 Mar 2024 00:00:55 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so1264585a12.0 for ; Thu, 29 Feb 2024 15:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247654; x=1709852454; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w4ZGJeq99gzn4mnFJnxYqd9ykfHfsHLb6rRl7FjUkUs=; b=jKXeEPMYhBHDvQK7vRP1zadzdRvN9hqz+dJE+GbFZ7LeQePwWEyZT4eZauNg+HcwsQ ID2Gv0BuP7plT57JLDKxZuPxiQ5JJT3E4PyUY6z2BhkkRxnvl72IXrCG+IbChen9OKrF vq/N6rr7DE4GvsdWbOOF5T/Xc6wSGn/kHYGDBcbqC0ScIXQB6Pn6X3ft1evw6LorF8wp /gFleURzzc+aCk9HI1lbL0m/jICZamiYHGDXe/40kcWJ+BSX0nt3LvG30KXkQRbARbTg WQNzP8U/9pfDT0gsubaax6bSyi1h5CAIljRSJMAxr9heW0kCMO1i5nTz6LELEp7unr+d KOtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247654; x=1709852454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w4ZGJeq99gzn4mnFJnxYqd9ykfHfsHLb6rRl7FjUkUs=; b=ANjmtsZijV485GEHsBxKI4oGoTRiIyH02+kNAZjDIr1PlPW/79OvNbSv7xxyrNN7UF 4etLtV/yvNJn8paXnParQSGPQRaZ0I9F/K8jcdqtkqiXkEK1E8PTMW39GcBSrLpSZeW/ E7105vBLoHP2LFOAlFA+xry/o/UEYx+4Es7DXT2CQo0fLuPW49eckHDFDb73UkdAYgUq VrKLXtynpIdrds5/CYFSkMWGQtF+L1jv4zv7+XY8Fodye5hMMpuapbSE/CdZM4aeWfc8 y8N38fP0y+OMTF6RQchjmNhg0GpIKoBtjoQUULNjR/hHvEEaqJ22fYBgIIbzORCn3eeN J9Gw== X-Gm-Message-State: AOJu0YykhrRl5z7uCK9GisYZ1dPKGwnplQVGpX7BCBVL2nfp1mrgjZoM EqIj7p0ZdUJ52QYHEsqKH/jhUrivgfzULE7OEl8dMQVKVSk+dR2bA8+8Ak1/Q63KIEPbynuL5up B X-Google-Smtp-Source: AGHT+IHdGPOIIf89uSKPx3UcA5gD7Ei9cfBB71tO5oiV04+4m/+1gpdADLgsu/3if9UDg8Y3vA9iSw== X-Received: by 2002:a17:90b:1084:b0:29a:525f:4c5 with SMTP id gj4-20020a17090b108400b0029a525f04c5mr504466pjb.12.1709247654421; Thu, 29 Feb 2024 15:00:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gaetan Rivet Subject: [PATCH 63/71] net/failsafe: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:50 -0800 Message-ID: <20240229225936.483472-64-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 9c013e04195c..47d453ef8028 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -902,16 +902,16 @@ fs_stats_get(struct rte_eth_dev *dev, ret = fs_lock(dev, 0); if (ret != 0) return ret; - rte_memcpy(stats, &PRIV(dev)->stats_accumulator, sizeof(*stats)); + memcpy(stats, &PRIV(dev)->stats_accumulator, sizeof(*stats)); FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) { struct rte_eth_stats *snapshot = &sdev->stats_snapshot.stats; uint64_t *timestamp = &sdev->stats_snapshot.timestamp; - rte_memcpy(&backup, snapshot, sizeof(backup)); + memcpy(&backup, snapshot, sizeof(backup)); ret = rte_eth_stats_get(PORT_ID(sdev), snapshot); if (ret) { if (!fs_err(sdev, ret)) { - rte_memcpy(snapshot, &backup, sizeof(backup)); + memcpy(snapshot, &backup, sizeof(backup)); goto inc; } ERROR("Operation rte_eth_stats_get failed for sub_device %d with error %d", From patchwork Thu Feb 29 22:58:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137638 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2034C43BAE; Fri, 1 Mar 2024 00:08:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 975C043450; Fri, 1 Mar 2024 00:02:07 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 2F5D74331A for ; Fri, 1 Mar 2024 00:00:56 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-29b1ee96191so292433a91.0 for ; Thu, 29 Feb 2024 15:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247655; x=1709852455; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hKqEFCNTObx0gRK9+izVTkCMNLSW9gW0LxjHqhk3RFg=; b=1rEKKhc4IXa0kB2PVWXsrrUzk/nXZvkuqpAgMD3iyekN0Vn2K9TRlR2mTGbBt8HgXl nyqTRHJP+VR82QKX9l9wZkBFKD9c6Pv667QhuU2NSVIDZH8QEvkybH/NhqaH56NzMfC8 fikcf2X8ge/iLiyFjdCn5jLgUOVUQjau3FFnFcP3fsWfwFZPNuaXHHA0X6pTqTz4NGpY Wksy2BCa37I5kfb76fxJSE7xlWHIZfKGzga5TZFmjMgTKR2idXYx1PCXg6nKXbz3JHOy 8+PJmBP1UJCcINTCNK7mrJRVlqSOmfUh8hd2bs1Mfky+RFZAbi/7A6ulMAO0HvdcSjOx 5tdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247655; x=1709852455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hKqEFCNTObx0gRK9+izVTkCMNLSW9gW0LxjHqhk3RFg=; b=KeuzgJMsQFgBhe5ytXKiQ+zB2s3a0n/eLqLlWnOJFsfG7iiT1hJuCg/DGIPTLt80Rn dQ0j+4R6j0yY8nU8Huxd5ASPV7z7AdZOE7UmX0i/iVqu1MZ0oTKZDnzuPD+ss7JwSGo5 ZBV0eWnDmQOvDQ4FtRXKoUxhV0VPbxCmoMiUYvWTldhrEwgJbCFA0iVhZaQnZimM6+Dt YTv8rFvSv65bQ+JUeked9w2Y4krF8zAbevCVB6P962bGTmWcj3PLlQ6dZESRzZGra0WM ABpWAqT1SlDYSVo2NXU/c03ntvKcgUxjilct+t3qBYuo2bjAhjYUvKnyqyX5IMTCOhGU JXRA== X-Gm-Message-State: AOJu0YzjfUhTL0OpEyQC/k8hF1myjbzWR0b8s50K45taG6KD+Xz0GRcC lzaSgFZSBBIIxwxohWBQcXPwl6UmHFizwA0h1fRJPvwiWHRVp23yVXPGYxztnYeVEWI5xKg5y0f 0+5k= X-Google-Smtp-Source: AGHT+IHww8EWGBpCaVeWe4yRX09JvUMiw1sYRoC9B3nPoNIf1wK3qpBgGj8jEFysO+gHJ+di2k0ZWg== X-Received: by 2002:a17:90a:9e4:b0:299:9d8:d7c9 with SMTP id 91-20020a17090a09e400b0029909d8d7c9mr35722pjo.18.1709247655354; Thu, 29 Feb 2024 15:00:55 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Junfeng Guo , Jeroen de Borst , Rushil Gupta , Joshua Washington Subject: [PATCH 64/71] net/gve/base: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:51 -0800 Message-ID: <20240229225936.483472-65-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/gve/base/gve_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c index 629d15cfbe77..24b00a1fbf5b 100644 --- a/drivers/net/gve/base/gve_adminq.c +++ b/drivers/net/gve/base/gve_adminq.c @@ -785,7 +785,7 @@ int gve_adminq_describe_device(struct gve_priv *priv) } priv->max_mtu = mtu; priv->num_event_counters = be16_to_cpu(descriptor->counters); - rte_memcpy(priv->dev_addr.addr_bytes, descriptor->mac, ETH_ALEN); + memcpy(priv->dev_addr.addr_bytes, descriptor->mac, ETH_ALEN); PMD_DRV_LOG(INFO, "MAC addr: " RTE_ETHER_ADDR_PRT_FMT, RTE_ETHER_ADDR_BYTES(&priv->dev_addr)); priv->tx_pages_per_qpl = be16_to_cpu(descriptor->tx_pages_per_qpl); From patchwork Thu Feb 29 22:58:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137639 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BDB843BAE; Fri, 1 Mar 2024 00:08:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C127043454; Fri, 1 Mar 2024 00:02:08 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 3977743322 for ; Fri, 1 Mar 2024 00:00:57 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-29b21dc7a92so121377a91.1 for ; Thu, 29 Feb 2024 15:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247656; x=1709852456; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=; b=gv9vRvLOXFe/kWJwzIAdBGAYsQn+w+tzTmSyPIRXvyBMyhnFT8JDa1k2MxytOFCEtI HoUahbZsq8C2DiBH3fo0qwlppu1PeYUCkqyAfDz6JpZWRGsOeLEREwtAo3SXkVLe9TcX Ajg1Lozm92WKJOXCoFdcaeft998WpyYmdypLRqL02F7rD3BGJ/Eljlj0e/rMB7TG5Tvg RkqnQ6q4xYj9UrZD4teNeJaAilc/QLEca3LmEsCU03HWjt3egkOMPoP3jTpMelUumr6M Qec6oCWsRJ+oe1DSNB0GkJfdnSy44Z6LC4o/VsdyxIvfStPBRgSIOO0Hdo7CEeUQpF8B bl5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247656; x=1709852456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=; b=v8mqzOATRH1BTHTUucVY4MCkZRw9qoKUHPrFWv4DregIEJXAzbjaNT4qo095e35XdP BPZXKBdl2qgmmnTqRABOKMmTeX0z/CIscEkc/ctc9Su8v2KHuo53rI1Mu/UCzAhMm/tS XcwCqFprcHOun3jntTC9hc/J6363b/cL3hsiQb/HHQ9QF/qwYLusfqV8HaBRl7pXMSEr 3R6SXGmYqnY39RTQLoKO2t823NZ7ApmLXGybM04+oUDVZRMol3gWSbmzxJfF45C6WWWo 9Vh9WUZ+78Mi6PZf86/xCrxGCWI1HY+4ufPxiRWRGHxBXj2LlseEEtAgK93UVTls8wXc MZPg== X-Gm-Message-State: AOJu0YxCJZe+ddBKVw4jtnrc6IlUR5KSdXF8BRfDCUT2l+GbSpQCKLKx MrOE6hE3nmaqmiOMbX1l5cs7XwnXDYlMyYlmgvxi9CaE3nU84fkIoPMnischZWCtHoneCti6Ppf s+zc= X-Google-Smtp-Source: AGHT+IFLXicHYMSVkzsFgkuc6lxFNarpAa+jSX5F8U6JH0Av+6bvsJ2faFCFQ6hqCs0q0uiwCQ/NoA== X-Received: by 2002:a17:90b:3c1:b0:29a:998a:cdf1 with SMTP id go1-20020a17090b03c100b0029a998acdf1mr27553pjb.35.1709247656422; Thu, 29 Feb 2024 15:00:56 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Subject: [PATCH 65/71] net/hinic: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:52 -0800 Message-ID: <20240229225936.483472-66-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_flow.c | 40 ++++++++++++++---------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pmd_flow.c index d1a564a16303..cb61c989fd36 100644 --- a/drivers/net/hinic/hinic_pmd_flow.c +++ b/drivers/net/hinic/hinic_pmd_flow.c @@ -983,8 +983,7 @@ static int hinic_normal_item_check_ip(const struct rte_flow_item **in_out_item, } ipv6_spec = (const struct rte_flow_item_ipv6 *)item->spec; - rte_memcpy(rule->hinic_fdir.dst_ipv6, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->hinic_fdir.dst_ipv6, ipv6_spec->hdr.dst_addr, 16); /* * Check if the next not void item is TCP or UDP or ICMP. @@ -2193,8 +2192,8 @@ static int hinic_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct hinic_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, &filter_5tuple, - sizeof(struct hinic_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct hinic_5tuple_filter_info)); filter->queue = ntuple_filter->queue; filter_info->qid = ntuple_filter->queue; @@ -2912,8 +2911,7 @@ static int hinic_add_del_tcam_fdir_filter(struct rte_eth_dev *dev, sizeof(struct hinic_tcam_filter), 0); if (tcam_filter == NULL) return -ENOMEM; - (void)rte_memcpy(&tcam_filter->tcam_key, - &tcam_key, sizeof(struct tag_tcam_key)); + memcpy(&tcam_filter->tcam_key, &tcam_key, sizeof(struct tag_tcam_key)); tcam_filter->queue = fdir_tcam_rule.data.qid; ret = hinic_add_tcam_filter(dev, tcam_filter, &fdir_tcam_rule); @@ -2990,9 +2988,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, &ntuple_filter, FALSE); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&nic_dev->filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -3022,9 +3020,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, ðertype_filter, FALSE); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&nic_dev->filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -3065,8 +3063,8 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, &fdir_rule, - sizeof(struct hinic_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, &fdir_rule, + sizeof(struct hinic_fdir_rule)); TAILQ_INSERT_TAIL(&nic_dev->filter_fdir_rule_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -3109,8 +3107,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct hinic_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = hinic_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&nic_dev->filter_ntuple_list, @@ -3121,9 +3119,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct hinic_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = hinic_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3134,9 +3131,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct hinic_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct hinic_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct hinic_fdir_rule)); if (fdir_rule.mode == HINIC_FDIR_MODE_NORMAL) { ret = hinic_add_del_fdir_filter(dev, &fdir_rule, FALSE); } else if (fdir_rule.mode == HINIC_FDIR_MODE_TCAM) { From patchwork Thu Feb 29 22:58:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137640 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FCEC43BAE; Fri, 1 Mar 2024 00:08:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F01AB43458; Fri, 1 Mar 2024 00:02:09 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id E7BA04332C for ; Fri, 1 Mar 2024 00:00:58 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5cedfc32250so1286508a12.0 for ; Thu, 29 Feb 2024 15:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247658; x=1709852458; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GHdnJw6wwF7B7iZ/PeJHD1EkHIyhK1xX2lT3kawF+kI=; b=vAF07Z80/50kp4eawpIv2iVdk2M2dgkkRvWs+3c24lkEiJV8DYPTyLPqErvy1PGPye 98RZSsV2zxm19Y3sLITV3wN9jrdoKX6Zluh62xy3Mjq11GsE/45kWtTU5o8hzPwrR0gl UoodBA2cx0DSF/3+rO3wv0ajfZBvgzcRJMtWWh7Yi/g9XURyaaITO3OB+H/l51V9VDiZ NlwyvTLQI1pZ1jx32h0MN0qK6FZUjYgkLqEoEC66G6/SRZDLQP2/l8X/xzHj7lZsVlDy qIsStx5wGDAHctelQ4yXUuZMigx+XcVBUknsJFpPsIpi+NNxmr7Cv32/+zGRV12T3tjI H5UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247658; x=1709852458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHdnJw6wwF7B7iZ/PeJHD1EkHIyhK1xX2lT3kawF+kI=; b=ri0mpyclFbVbCkeVN6YlIjfsica7xp8IvyMbH/g6SM2GS24ybzMz9tEiZeAlh8Xoi0 jC888SLaAkkHdBxBJZ9jZGYZKDzgUFg/BjGAgaVgAfj0P2B+g6mROJtyWtaRsRMPYOGV 5OzPG32u1kGF/efVaR0/CGKmmxMySfl8BjvOmFOs7crbY7zB/AmXMhIeZWTeDZFJrD53 XJiJrd3lYoCjIf65iTo+WZ616v/SshY4jXf2gHcATujxC5qg7rp8ROQx9YxMn9TlLdBo ghjF6u1o8Nsh7G569oh28Dw06e5yTHZD4dYU851yenBg49NCiqk7b6KI+oeZ6zb8rLkZ VAww== X-Gm-Message-State: AOJu0Yydo+Q1tKob9n+99OgkxTz1I7nsy/eKj9kpWe6R3mzigU5DOsd3 U66f1GEIKAs6pcOL3kBcNHuZDoWuhbk4/fsYq9IA08tuhYyNRlRGdaSKErDB4XkdmsQVYCmP3Ya eozI= X-Google-Smtp-Source: AGHT+IEgPOdB6fKWbuJMfIsmh3GJMehwd06Yoj1dwrntu+QtTh74uY5eUiKFm9ZVurXGtOTovF2hEg== X-Received: by 2002:a17:90a:d392:b0:29a:a37f:22c6 with SMTP id q18-20020a17090ad39200b0029aa37f22c6mr35060pju.28.1709247657274; Thu, 29 Feb 2024 15:00:57 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH 66/71] net/mvpp2: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:53 -0800 Message-ID: <20240229225936.483472-67-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_tm.c b/drivers/net/mvpp2/mrvl_tm.c index 9fac80b867be..a5cdae6d1d0d 100644 --- a/drivers/net/mvpp2/mrvl_tm.c +++ b/drivers/net/mvpp2/mrvl_tm.c @@ -437,7 +437,7 @@ mrvl_shaper_profile_add(struct rte_eth_dev *dev, uint32_t shaper_profile_id, NULL, NULL); profile->id = shaper_profile_id; - rte_memcpy(&profile->params, params, sizeof(profile->params)); + memcpy(&profile->params, params, sizeof(profile->params)); LIST_INSERT_HEAD(&priv->shaper_profiles, profile, next); From patchwork Thu Feb 29 22:58:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137641 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7328543BAE; Fri, 1 Mar 2024 00:08:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E40F43389; Fri, 1 Mar 2024 00:02:26 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 50FA343330 for ; Fri, 1 Mar 2024 00:00:59 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-29a7951c6faso1117129a91.1 for ; Thu, 29 Feb 2024 15:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247658; x=1709852458; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hBjpL2B+GH6WMvX1UmW3MDbk0gtjo8OUJmzZdg4n6Y8=; b=Pyjzi1rUKKt3UI8I0CpBeHxWkypzzkoS5aXKDus13e4o61mPNDLIdQHT1I5m0pMQRO qkxDPJM7rqBx8A7evO4NJgKax59XdRRjK1iDgwunbAxLQogYS/AJJJPX6CUW4Lr1454o LcFCsOfVZ3pD9IHhVlx0YGBE3ghUAZOONnIs5Bxo9iBssLUgoB5MYgm6z5AoFJE/WbwX dld0E2cbechvvFE6L8mFrOM+dClrCgVyHxid1rX88MXlJdy20ui8EBEbXjpMZCkGWc8i UfcFuJKQRuewAKUfeUfVTRfbHl3ctAc2ctLivFngxv87Cxcg4Ri3BSQtRIA1Qvksz2W/ sCVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247658; x=1709852458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hBjpL2B+GH6WMvX1UmW3MDbk0gtjo8OUJmzZdg4n6Y8=; b=htACYRJtDWMGbYOFi1kiC0feWPdOi/r9R8UuRaaYvKWfzZYrNc8INMocd9VFxEpwEw oZXgqi3wDOV7+yocnafsToHRGgGexyCvE4EifL6aL27jRivlfYPOydPiBQE7BoQQu/ME 3M0oa59WESzanrxf5K7zTRg6/EQTnOpOC/PEsYKBSigZAjcyWfkf0VuQAPTo1Bz8//uv UIhv+AuKs+sb/BmcrtcrWHy2dfdvqfB/s8INSkI10+kzeNyHX59U9eRfqL2bZfO8g/LS o5J6XnbRRPMkgpBBTfHxYK1+2xbf9e5UxRXkp1cb9xNurkDxFYcTnIrfdfyLey6NwwIf HlsQ== X-Gm-Message-State: AOJu0Yyj+s0bnuVtD+EoagGuxplPNdTCMsE/GZ4MWRMbYBOGp9V7wWVi GlID0I51stAuLgTZesEjLqfNQqKvA4EiKmsD02TQ/nACZpVzbjyD7V94giagj7/ELCZh/TpwJdB +3TQ= X-Google-Smtp-Source: AGHT+IHsAA11DWXyh36yU4o8m/KGH9gXFN5GK+rTz4E7o6MDCJjKxQgYncwJqKtnNF9bM/skX5dFXg== X-Received: by 2002:a17:90a:8046:b0:29a:7efc:4720 with SMTP id e6-20020a17090a804600b0029a7efc4720mr25405pjw.31.1709247658488; Thu, 29 Feb 2024 15:00:58 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aman Singh , Yuying Zhang , Ori Kam Subject: [PATCH 67/71] app/test-pmd: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:54 -0800 Message-ID: <20240229225936.483472-68-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 48 ++++++++++++++++++------------------- app/test-pmd/cmdline_flow.c | 24 +++++++++---------- app/test-pmd/config.c | 8 +++---- 3 files changed, 40 insertions(+), 40 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 566057caa523..898fb69a2f4d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -9529,7 +9529,7 @@ static void cmd_set_vxlan_parsed(void *parsed_result, vxlan_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(vxlan_encap_conf.vni, &id.vni[1], 3); + memcpy(vxlan_encap_conf.vni, &id.vni[1], 3); vxlan_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src); vxlan_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst); vxlan_encap_conf.ip_tos = res->tos; @@ -9543,10 +9543,10 @@ static void cmd_set_vxlan_parsed(void *parsed_result, } if (vxlan_encap_conf.select_vlan) vxlan_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_vxlan = { @@ -9724,7 +9724,7 @@ static void cmd_set_nvgre_parsed(void *parsed_result, nvgre_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(nvgre_encap_conf.tni, &id.tni[1], 3); + memcpy(nvgre_encap_conf.tni, &id.tni[1], 3); if (nvgre_encap_conf.select_ipv4) { IPV4_ADDR_TO_UINT(res->ip_src, nvgre_encap_conf.ipv4_src); IPV4_ADDR_TO_UINT(res->ip_dst, nvgre_encap_conf.ipv4_dst); @@ -9734,10 +9734,10 @@ static void cmd_set_nvgre_parsed(void *parsed_result, } if (nvgre_encap_conf.select_vlan) nvgre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_nvgre = { @@ -9851,10 +9851,10 @@ static void cmd_set_l2_encap_parsed(void *parsed_result, return; if (l2_encap_conf.select_vlan) l2_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_l2_encap = { @@ -10033,7 +10033,7 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result, mplsogre_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(mplsogre_encap_conf.label, &id.label, 3); + memcpy(mplsogre_encap_conf.label, &id.label, 3); if (mplsogre_encap_conf.select_ipv4) { IPV4_ADDR_TO_UINT(res->ip_src, mplsogre_encap_conf.ipv4_src); IPV4_ADDR_TO_UINT(res->ip_dst, mplsogre_encap_conf.ipv4_dst); @@ -10043,10 +10043,10 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result, } if (mplsogre_encap_conf.select_vlan) mplsogre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_mplsogre_encap = { @@ -10269,7 +10269,7 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result, mplsoudp_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(mplsoudp_encap_conf.label, &id.label, 3); + memcpy(mplsoudp_encap_conf.label, &id.label, 3); mplsoudp_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src); mplsoudp_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst); if (mplsoudp_encap_conf.select_ipv4) { @@ -10281,10 +10281,10 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result, } if (mplsoudp_encap_conf.select_vlan) mplsoudp_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_mplsoudp_encap = { diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index b4389e51506b..17b73d2407c4 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -13732,7 +13732,7 @@ cmd_set_raw_parsed_sample(const struct buffer *in) fprintf(stderr, "Error - Not supported action\n"); return; } - rte_memcpy(data, action, sizeof(struct rte_flow_action)); + memcpy(data, action, sizeof(struct rte_flow_action)); data++; } } @@ -13893,8 +13893,8 @@ cmd_set_raw_parsed(const struct buffer *in) /* We have to add GTP header extra word. */ *total_size += sizeof(ext_word); - rte_memcpy(data_tail - (*total_size), - &ext_word, sizeof(ext_word)); + memcpy(data_tail - (*total_size), &ext_word, + sizeof(ext_word)); } size = sizeof(struct rte_gtp_hdr); break; @@ -13939,21 +13939,21 @@ cmd_set_raw_parsed(const struct buffer *in) if (opt->checksum_rsvd.checksum) { *total_size += sizeof(opt->checksum_rsvd); - rte_memcpy(data_tail - (*total_size), - &opt->checksum_rsvd, - sizeof(opt->checksum_rsvd)); + memcpy(data_tail - (*total_size), + &opt->checksum_rsvd, + sizeof(opt->checksum_rsvd)); } if (opt->key.key) { *total_size += sizeof(opt->key.key); - rte_memcpy(data_tail - (*total_size), - &opt->key.key, - sizeof(opt->key.key)); + memcpy(data_tail - (*total_size), + &opt->key.key, + sizeof(opt->key.key)); } if (opt->sequence.sequence) { *total_size += sizeof(opt->sequence.sequence); - rte_memcpy(data_tail - (*total_size), - &opt->sequence.sequence, - sizeof(opt->sequence.sequence)); + memcpy(data_tail - (*total_size), + &opt->sequence.sequence, + sizeof(opt->sequence.sequence)); } } proto = 0x2F; diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 08d7d0e2f87c..2b81f3ef3d2d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2639,8 +2639,8 @@ port_flow_template_table_create(portid_t port_id, uint32_t id, } pt->nb_pattern_templates = nb_pattern_templates; pt->nb_actions_templates = nb_actions_templates; - rte_memcpy(&pt->flow_attr, &table_attr->flow_attr, - sizeof(struct rte_flow_attr)); + memcpy(&pt->flow_attr, &table_attr->flow_attr, + sizeof(struct rte_flow_attr)); printf("Template table #%u created\n", pt->id); return 0; } @@ -3261,8 +3261,8 @@ port_queue_action_handle_update(portid_t port_id, update = action->conf; break; case RTE_FLOW_ACTION_TYPE_METER_MARK: - rte_memcpy(&mtr_update.meter_mark, action->conf, - sizeof(struct rte_flow_action_meter_mark)); + memcpy(&mtr_update.meter_mark, action->conf, + sizeof(struct rte_flow_action_meter_mark)); if (mtr_update.meter_mark.profile) mtr_update.profile_valid = 1; if (mtr_update.meter_mark.policy) From patchwork Thu Feb 29 22:58:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137642 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48C3F43BAE; Fri, 1 Mar 2024 00:08:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E24343460; Fri, 1 Mar 2024 00:02:27 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 0E0D843330 for ; Fri, 1 Mar 2024 00:01:00 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5d8b519e438so1329028a12.1 for ; Thu, 29 Feb 2024 15:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247659; x=1709852459; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CEfszso0YsVDHyLSbXcdrEEUdq5SMGrX+9HGQAEv90o=; b=A4UPSqAqfert0lYr5IOiz/bLQOoti4Xe5zFUDJZTpEN0Ro+8CfDBR7wpNk8V4rfjCX /wKx8OO2K5i9nHqXB4ETTAmCLsA1eYmkNt9kMndV7dGL2EgQElJsKZkMmCzUbauKsSAW 4HPZ4uNy5TSQENHCbsjmulVJlcZa2PwF5L2SWnGf0qkewunEEWJGHfzyOdnJGBpcMQRF qdBrlHXbJn1M5/9CTsE0NAChmJmaXBncVQXWgmlwXEF0itL0HqhwtAG8gXuN0niWuhSn VkdtU0nixUyTdyJDnXMteLPMkme+d48rmYlHjM9rfkUArybSrdTWPBf5Cn1YV6qCh3lP x11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247659; x=1709852459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CEfszso0YsVDHyLSbXcdrEEUdq5SMGrX+9HGQAEv90o=; b=mu3uC+NVnfSyau3dutYof+kbBxBWLy0CODhw2aK8lEc/6eK/3QnPHbHagzVg66Mqpw D7Tg/3xoimxM1EJ+Zd4KmzWviPToFZd0xtnGwm1hpcR2foWSFScVvHhGwBdR+pqQgmnD 9HVZFPeAgdy0ld+XqN+NcU1mkL5QfOwirWBv64UDFiZo3fKWOUxrzVaTf7qrILQiU/7F 30YXAjyBb+0w5WNR1JJXJ/qOSHkE5UH4Y4HSPWGHLq7nHnoayBSZ06npCEinBMrLWtn3 AnrmOkD5umkS2gjDDYPF/jLl6WsDJWfT484mdLKq/pgZmvXIXmLwOBfU35rzLR94hoKH OgsQ== X-Gm-Message-State: AOJu0Ywi31JPCB8sMBXwu1vP2qqVHCnAkBLfUzi9Nbq5+p98PWSCuGcq BY6Dpsz1yheJnUx9K63gFEG3ThZ7oe0fROOWHiGPWOa/E1LZsAmCnItd8HHRZkcAGW7ikWvKSxZ oaUo= X-Google-Smtp-Source: AGHT+IGMhrkbQ+uIz7NxWGLqG1ZlVY7lp5MQPXoJ9F0TfoNkZg0YWQnpEUKrCZCjNHYD3bZsn0D4WQ== X-Received: by 2002:a17:90a:9748:b0:29a:8b1b:1f61 with SMTP id i8-20020a17090a974800b0029a8b1b1f61mr31214pjw.17.1709247659322; Thu, 29 Feb 2024 15:00:59 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Kumar Kori , Rakesh Kudurumalla Subject: [PATCH 68/71] app/graph: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:55 -0800 Message-ID: <20240229225936.483472-69-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/graph/neigh.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/graph/neigh.c b/app/graph/neigh.c index 22be7361e310..a99d2b6981a2 100644 --- a/app/graph/neigh.c +++ b/app/graph/neigh.c @@ -91,14 +91,14 @@ ip6_rewrite_node_add(struct neigh_ipv6_config *v6_config) memset(data, 0, len); /* Copy dst mac */ - rte_memcpy((void *)&data[0], (void *)&v6_config->mac, RTE_ETHER_ADDR_LEN); + memcpy((void *)&data[0], (void *)&v6_config->mac, RTE_ETHER_ADDR_LEN); /* Copy src mac */ rc = rte_eth_macaddr_get(portid, &smac); if (rc < 0) return rc; - rte_memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); return rte_node_ip6_rewrite_add(portid, data, len, portid); } @@ -121,7 +121,7 @@ ip4_rewrite_node_add(struct neigh_ipv4_config *v4_config) memset(data, 0, len); /* Copy dst mac */ - rte_memcpy((void *)&data[0], (void *)&v4_config->mac, RTE_ETHER_ADDR_LEN); + memcpy((void *)&data[0], (void *)&v4_config->mac, RTE_ETHER_ADDR_LEN); /* Copy src mac */ rc = rte_eth_macaddr_get(portid, &smac); @@ -130,7 +130,7 @@ ip4_rewrite_node_add(struct neigh_ipv4_config *v4_config) return rc; } - rte_memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); return rte_node_ip4_rewrite_add(portid, data, len, portid); } From patchwork Thu Feb 29 22:58:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137643 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 740B643BAE; Fri, 1 Mar 2024 00:08:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B53A24346F; Fri, 1 Mar 2024 00:02:28 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id F412D43340 for ; Fri, 1 Mar 2024 00:01:00 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so1264689a12.0 for ; Thu, 29 Feb 2024 15:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247660; x=1709852460; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rO7SIIkiWVQ2S4NTSuaHfv9iQv4J+F5xqVXp01dtZ2g=; b=kgRfyPjW39R2VEeUMb3EPdugF0vmkCkCme3Jt2hZXPRGnFOo83aJk6E6dbvgmqXepY Jd4KjKlDvGzL5yOHTjCZ8Dv3jRCYVWQv8Rem7z8pHhM62PTBCMNwQ/+bPXqQDlIdGHM+ 5b5Ma+Jh2jkdGDXmtdX61tLmHxCRoVkK+ryTEZud7obavMt/+evbAVAia5NtTyvEY0dc 3OaFWXxqlRsts/Mb4MmBVSc+sX94nEK4Qr3dGxn+fyRa5JQ/AIkoMKzl4PdgomqE1aJC qcVrieek2rqJs5tLpLTp/+b7lBNOTeITJTTuK9jyKwYRMY/znyV+yJo7P1UrlFlf34Aq tg1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247660; x=1709852460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rO7SIIkiWVQ2S4NTSuaHfv9iQv4J+F5xqVXp01dtZ2g=; b=C1RjyWIWU3RsJ9XOyNkGxQIyogwgBeqtuWMl+rp8i+t8tZGL+RipF5y+LUc8BHvEyH f1Pcixkqxtq8Phe7F8dLJmVPF8pHIG61DONGausxd12CbnxGtQdaJ0AaXqEiyxFCJh3m GUEgUYOtHEQKa9nJZNmjN9gFXYRRejm07+XH62/4qhGldp+Uu1RTVO2hkgM5O15b8MXa /hSG2NLkzPYxrc5eaUNILei7Xw96nasCtYDgljjktB3ZfP4aK6ad1hhMpQ5BqUf9Ae5m Uxrhjv+Cd6mJMz2CdNSijHHt1sLoiAq2iQ307Ymo4+xS3/s9batuinet8xIf83peTGRU Kj0w== X-Gm-Message-State: AOJu0Ywq2jzFzRNy6cKM5/ims92Qo1F/xmUz0JIDI9kQ97bwseVi1zZK 2+hcConUL720xkbdbBx0pMGRzeu7hKOOzdBX7v6J0vOgJBA+0I9xOnT89k/lYP7+ZGLxSaMtDHk SdFU= X-Google-Smtp-Source: AGHT+IG7uMzy023C/lC90yuECwUtJYtLjxomGQOFgl0FXVtPdk3pB16gupaRlRXTZSLNt3Q5mlmPkA== X-Received: by 2002:a17:90b:35ce:b0:29a:f227:a7ce with SMTP id nb14-20020a17090b35ce00b0029af227a7cemr425105pjb.12.1709247660181; Thu, 29 Feb 2024 15:01:00 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob Subject: [PATCH 69/71] app/test-eventdev: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:56 -0800 Message-ID: <20240229225936.483472-70-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-eventdev/test_pipeline_common.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index b111690b7cd4..49bfd0c363f5 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -177,22 +177,17 @@ pipeline_tx_first(struct test_pipeline *t, struct evt_options *opt) mbuf->pkt_len = pkt_sz; /* Copy Ethernet header */ - rte_memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, 0), - ð_hdr, sizeof(struct rte_ether_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, 0), + ð_hdr, sizeof(struct rte_ether_hdr)); /* Copy Ipv4 header */ - rte_memcpy(rte_pktmbuf_mtod_offset( - mbuf, char *, - sizeof(struct rte_ether_hdr)), - &ip_hdr, sizeof(struct rte_ipv4_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, sizeof(struct rte_ether_hdr)), + &ip_hdr, sizeof(struct rte_ipv4_hdr)); /* Copy UDP header */ - rte_memcpy( - rte_pktmbuf_mtod_offset( - mbuf, char *, - sizeof(struct rte_ipv4_hdr) + - sizeof(struct rte_ether_hdr)), - &udp_hdr, sizeof(struct rte_udp_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, sizeof(struct rte_ipv4_hdr) + + sizeof(struct rte_ether_hdr)), + &udp_hdr, sizeof(struct rte_udp_hdr)); pkt_udp_hdr = rte_pktmbuf_mtod_offset( mbuf, struct rte_udp_hdr *, sizeof(struct rte_ipv4_hdr) + From patchwork Thu Feb 29 22:58:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137644 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 662BC43BAE; Fri, 1 Mar 2024 00:08:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9FAC43478; Fri, 1 Mar 2024 00:02:29 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 325E04334E for ; Fri, 1 Mar 2024 00:01:02 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so1264713a12.0 for ; Thu, 29 Feb 2024 15:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247661; x=1709852461; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XSEMg3TCYyZIudIgtwMBgU3c4CpT7ovRAKXAVds8zm4=; b=Afa0PfpRI+kuO5baz7ImlrszZJA0jILQ20Vq9paHuIBY7Hk1TgfxNZFGt5PcJIxvsH QV2CNM+IkHj140zcnhq8/hPzw4R+QOe8KS2r+lzqcd2c0V8lYBfVS82SwM39lArNDuXo EtmvR3optAanJYk+MJG1rhHVm/rwQ5nsgD4Oqxf1sJXykcJerlXiyELUAxnYfqW14ttV 74vgv+dCK9J57adZr7CHz4lDl8WbRqxMxVYFqj62+63FcTYXj2gS2YLXcugHP42o36Qx hiDq8xypSa7d8wiiuboW5vYdY011VKYTn4b116m+sIlYLh+ITlEYW3SP6MpaioAV6Nq1 O7Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247661; x=1709852461; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XSEMg3TCYyZIudIgtwMBgU3c4CpT7ovRAKXAVds8zm4=; b=UQ3mpq5sk3th2osnb0CFqSFsmLztPAd9NjtaHZqUo3GvDE9d0sVPpw5zAb3FEzNZ3A f5y6Cu5GH62vi4khP0b47TNtoXUj81gyL2hnsqd1eZg5JVISL3T1H4wVJLIqWOGcWmAT by7QH2dtkt73NB0UkS+Kk7jRMWNrGLpadBGpWnHm7yCrRiT+BjBwEDtqGHkVB+nwqbjX 4ZlS96mliuBvZnM/pFLb0+MEgNok+yqVlgY/oAJRoe6LG7Ciu6n57aEuC8cc7LoBs5dP IQpujCM1GldV4H60YLnQFTF48LXMciiSQqTxH2bv8aZNIeF3jO2enXy17UexHhebdTpP Pbrg== X-Gm-Message-State: AOJu0YxEilVpwCI8191yCwMqvOe9ufLJs6I2dio/Y27mDHy/Aflu3KLx W7nFK7W3vP4+dT/epJqOt2F1PcbCV6FIaPvljAt+WlXsWzAKWgYyTpzDgpnw0HDz5FeQMMfk5N7 3Qow= X-Google-Smtp-Source: AGHT+IELV7yf9n1i5eT8m51rlba8JMOb8BF0xYZRa2RxHJTF2z9HP9bFPD+oSwAc9oV950uN7Fa4zQ== X-Received: by 2002:a17:90a:1f09:b0:296:530:996e with SMTP id u9-20020a17090a1f0900b002960530996emr412593pja.20.1709247661274; Thu, 29 Feb 2024 15:01:01 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:01:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jasvinder Singh , Akhil Goyal , Fan Zhang , Abhinandan Gujjar , Amit Prakash Shukla , Konstantin Ananyev , Vladimir Medvedkin , Chas Williams , "Min Hu (Connor)" , Anoob Joseph Subject: [PATCH 70/71] app/test: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:57 -0800 Message-ID: <20240229225936.483472-71-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test/packet_burst_generator.c | 4 +-- app/test/test_crc.c | 4 +-- app/test/test_cryptodev.c | 18 ++++++-------- app/test/test_event_crypto_adapter.c | 12 ++++----- app/test/test_event_dma_adapter.c | 4 +-- app/test/test_ipsec.c | 6 ++--- app/test/test_link_bonding_mode4.c | 8 +++--- app/test/test_security_inline_proto.c | 36 +++++++++++++-------------- app/test/virtual_pmd.c | 2 +- 9 files changed, 46 insertions(+), 48 deletions(-) diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c index 867a88da0055..fcca2d238ece 100644 --- a/app/test/packet_burst_generator.c +++ b/app/test/packet_burst_generator.c @@ -148,8 +148,8 @@ initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, ip_hdr->proto = IPPROTO_UDP; ip_hdr->hop_limits = IP_DEFTTL; - rte_memcpy(ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); - rte_memcpy(ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); + memcpy(ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); + memcpy(ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); return (uint16_t) (pkt_data_len + sizeof(struct rte_ipv6_hdr)); } diff --git a/app/test/test_crc.c b/app/test/test_crc.c index b85fca35fe2d..67252b18a84a 100644 --- a/app/test/test_crc.c +++ b/app/test/test_crc.c @@ -83,7 +83,7 @@ test_crc_calc(void) return -7; for (i = 0; i < CRC32_VEC_LEN1; i += 12) - rte_memcpy(&test_data[i], crc32_vec1, 12); + memcpy(&test_data[i], crc32_vec1, 12); result = crc_calc(test_data, CRC32_VEC_LEN1, type); if (result != crc32_vec1_res) { @@ -93,7 +93,7 @@ test_crc_calc(void) /* 32-bit ethernet CRC: Test 3 */ for (i = 0; i < CRC32_VEC_LEN2; i += 12) - rte_memcpy(&test_data[i], crc32_vec1, 12); + memcpy(&test_data[i], crc32_vec1, 12); result = crc_calc(test_data, CRC32_VEC_LEN2, type); if (result != crc32_vec2_res) { diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 38a65aa88f04..d87bcbb05b86 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -2345,8 +2345,8 @@ test_AES_CBC_HMAC_SHA1_encrypt_digest(void) sym_op->auth.data.length = QUOTE_512_BYTES; /* Copy IV at the end of the crypto operation */ - rte_memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), - aes_cbc_iv, CIPHER_IV_LENGTH_AES_CBC); + memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), + aes_cbc_iv, CIPHER_IV_LENGTH_AES_CBC); /* Set crypto operation cipher parameters */ sym_op->cipher.data.offset = 0; @@ -2480,9 +2480,7 @@ test_AES_CBC_HMAC_SHA512_decrypt_perform(void *sess, DIGEST_BYTE_LENGTH_SHA512); TEST_ASSERT_NOT_NULL(ut_params->digest, "no room to append digest"); - rte_memcpy(ut_params->digest, - digest, - DIGEST_BYTE_LENGTH_SHA512); + memcpy(ut_params->digest, digest, DIGEST_BYTE_LENGTH_SHA512); /* Generate Crypto op data structure */ ut_params->op = rte_crypto_op_alloc(ts_params->op_mpool, @@ -2505,8 +2503,8 @@ test_AES_CBC_HMAC_SHA512_decrypt_perform(void *sess, sym_op->auth.data.length = QUOTE_512_BYTES; /* Copy IV at the end of the crypto operation */ - rte_memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), - iv, CIPHER_IV_LENGTH_AES_CBC); + memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), + iv, CIPHER_IV_LENGTH_AES_CBC); sym_op->cipher.data.offset = 0; sym_op->cipher.data.length = QUOTE_512_BYTES; @@ -8863,7 +8861,7 @@ create_aead_operation(enum rte_crypto_aead_operation op, uint8_t *, IV_OFFSET); if (tdata->iv.len == 0) { - rte_memcpy(iv_ptr, tdata->iv.data, AES_GCM_J0_LENGTH); + memcpy(iv_ptr, tdata->iv.data, AES_GCM_J0_LENGTH); debug_hexdump(stdout, "iv:", iv_ptr, AES_GCM_J0_LENGTH); } else { @@ -13659,8 +13657,8 @@ test_multi_session_random_usage(void) for (i = 0; i < MB_SESSION_NUMBER; i++) { - rte_memcpy(&ut_paramz[i].ut_params, &unittest_params, - sizeof(struct crypto_unittest_params)); + memcpy(&ut_paramz[i].ut_params, &unittest_params, + sizeof(struct crypto_unittest_params)); test_AES_CBC_HMAC_SHA512_decrypt_create_session_params( &ut_paramz[i].ut_params, diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c index 0c56744ba031..4992c5bc5035 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -454,7 +454,7 @@ test_op_forward_mode(uint8_t session_less) m_data.request_info.cdev_id = request_info.cdev_id; m_data.request_info.queue_pair_id = request_info.queue_pair_id; m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); } sym_op->m_src = m; @@ -653,8 +653,8 @@ test_asym_op_forward_mode(uint8_t session_less) m_data.request_info.cdev_id = request_info.cdev_id; m_data.request_info.queue_pair_id = request_info.queue_pair_id; m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + op->private_data_offset, - &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + op->private_data_offset, &m_data, + sizeof(m_data)); } /* Fill in event info and update event_ptr with rte_crypto_op */ memset(&ev, 0, sizeof(ev)); @@ -820,7 +820,7 @@ test_op_new_mode(uint8_t session_less) op->private_data_offset = len; /* Fill in private data information */ m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); } sym_op->m_src = m; @@ -977,8 +977,8 @@ test_asym_op_new_mode(uint8_t session_less) sizeof(struct rte_crypto_asym_xform)); /* Fill in private data information */ m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + op->private_data_offset, - &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + op->private_data_offset, &m_data, + sizeof(m_data)); } ret = send_op_recv_ev(op); diff --git a/app/test/test_event_dma_adapter.c b/app/test/test_event_dma_adapter.c index 35b417b69f7b..af2e44a703e4 100644 --- a/app/test/test_event_dma_adapter.c +++ b/app/test/test_event_dma_adapter.c @@ -269,8 +269,8 @@ test_op_forward_mode(void) op->vchan = TEST_DMA_VCHAN_ID; response_info.event = dma_response_info.event; - rte_memcpy((uint8_t *)op + sizeof(struct rte_event_dma_adapter_op), &response_info, - sizeof(struct rte_event)); + memcpy((uint8_t *)op + sizeof(struct rte_event_dma_adapter_op), + &response_info, sizeof(struct rte_event)); /* Fill in event info and update event_ptr with rte_event_dma_adapter_op */ memset(&ev[i], 0, sizeof(struct rte_event)); diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 6cb1bac1e732..25aabdb616da 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test_ipsec.c @@ -601,10 +601,10 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string, /* copy outer IP and ESP header */ ipv4_outer.total_length = rte_cpu_to_be_16(t_len); ipv4_outer.packet_id = rte_cpu_to_be_16(seq); - rte_memcpy(dst, &ipv4_outer, sizeof(ipv4_outer)); + memcpy(dst, &ipv4_outer, sizeof(ipv4_outer)); dst += sizeof(ipv4_outer); m->l3_len = sizeof(ipv4_outer); - rte_memcpy(dst, &esph, sizeof(esph)); + memcpy(dst, &esph, sizeof(esph)); dst += sizeof(esph); if (string != NULL) { @@ -616,7 +616,7 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string, sizeof(esp_pad_bytes))); dst += padlen; /* copy ESP tail header */ - rte_memcpy(dst, &espt, sizeof(espt)); + memcpy(dst, &espt, sizeof(espt)); } else memset(dst, 0, t_len); diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index ff13dbed93f3..e4827c1e8091 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -1399,8 +1399,8 @@ test_mode4_ext_ctrl(void) for (i = 0; i < MEMBER_COUNT; i++) { lacp_tx_buf[i] = rte_pktmbuf_alloc(test_params.mbuf_pool); - rte_memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), - &lacpdu, sizeof(lacpdu)); + memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), &lacpdu, + sizeof(lacpdu)); rte_pktmbuf_pkt_len(lacp_tx_buf[i]) = sizeof(lacpdu); } @@ -1453,8 +1453,8 @@ test_mode4_ext_lacp(void) for (i = 0; i < MEMBER_COUNT; i++) { lacp_tx_buf[i] = rte_pktmbuf_alloc(test_params.mbuf_pool); - rte_memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), - &lacpdu, sizeof(lacpdu)); + memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), &lacpdu, + sizeof(lacpdu)); rte_pktmbuf_pkt_len(lacp_tx_buf[i]) = sizeof(lacpdu); } diff --git a/app/test/test_security_inline_proto.c b/app/test/test_security_inline_proto.c index 481382b64e85..8268a0855ba7 100644 --- a/app/test/test_security_inline_proto.c +++ b/app/test/test_security_inline_proto.c @@ -245,8 +245,8 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, /* Copy cipher session parameters */ if (sa->aead) { - rte_memcpy(sess_conf->crypto_xform, &sa->xform.aead, - sizeof(struct rte_crypto_sym_xform)); + memcpy(sess_conf->crypto_xform, &sa->xform.aead, + sizeof(struct rte_crypto_sym_xform)); sess_conf->crypto_xform->aead.key.data = sa->key.data; /* Verify crypto capabilities */ if (test_sec_crypto_caps_aead_verify(sec_cap, sess_conf->crypto_xform) != 0) { @@ -256,13 +256,13 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, } } else { if (dir == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) { - rte_memcpy(&sess_conf->crypto_xform->cipher, - &sa->xform.chain.cipher.cipher, - sizeof(struct rte_crypto_cipher_xform)); + memcpy(&sess_conf->crypto_xform->cipher, + &sa->xform.chain.cipher.cipher, + sizeof(struct rte_crypto_cipher_xform)); - rte_memcpy(&sess_conf->crypto_xform->next->auth, - &sa->xform.chain.auth.auth, - sizeof(struct rte_crypto_auth_xform)); + memcpy(&sess_conf->crypto_xform->next->auth, + &sa->xform.chain.auth.auth, + sizeof(struct rte_crypto_auth_xform)); sess_conf->crypto_xform->cipher.key.data = sa->key.data; sess_conf->crypto_xform->next->auth.key.data = @@ -282,12 +282,12 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, return TEST_SKIPPED; } } else { - rte_memcpy(&sess_conf->crypto_xform->next->cipher, - &sa->xform.chain.cipher.cipher, - sizeof(struct rte_crypto_cipher_xform)); - rte_memcpy(&sess_conf->crypto_xform->auth, - &sa->xform.chain.auth.auth, - sizeof(struct rte_crypto_auth_xform)); + memcpy(&sess_conf->crypto_xform->next->cipher, + &sa->xform.chain.cipher.cipher, + sizeof(struct rte_crypto_cipher_xform)); + memcpy(&sess_conf->crypto_xform->auth, + &sa->xform.chain.auth.auth, + sizeof(struct rte_crypto_auth_xform)); sess_conf->crypto_xform->auth.key.data = sa->auth_key.data; sess_conf->crypto_xform->next->cipher.key.data = @@ -463,12 +463,12 @@ init_packet(struct rte_mempool *mp, const uint8_t *data, unsigned int len, bool return NULL; if (outer_ipv4) { - rte_memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), - &dummy_ipv4_eth_hdr, RTE_ETHER_HDR_LEN); + memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), + &dummy_ipv4_eth_hdr, RTE_ETHER_HDR_LEN); pkt->l3_len = sizeof(struct rte_ipv4_hdr); } else { - rte_memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), - &dummy_ipv6_eth_hdr, RTE_ETHER_HDR_LEN); + memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), + &dummy_ipv6_eth_hdr, RTE_ETHER_HDR_LEN); pkt->l3_len = sizeof(struct rte_ipv6_hdr); } pkt->l2_len = RTE_ETHER_HDR_LEN; diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index b7d74a467a22..18056eff1051 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -186,7 +186,7 @@ virtual_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) struct virtual_ethdev_private *dev_private = dev->data->dev_private; if (stats) - rte_memcpy(stats, &dev_private->eth_stats, sizeof(*stats)); + memcpy(stats, &dev_private->eth_stats, sizeof(*stats)); return 0; } From patchwork Thu Feb 29 22:58:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137645 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F66E43BAE; Fri, 1 Mar 2024 00:09:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 420E04347A; Fri, 1 Mar 2024 00:02:31 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 056B24334B for ; Fri, 1 Mar 2024 00:01:03 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-299e4b352cdso1034796a91.0 for ; Thu, 29 Feb 2024 15:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247662; x=1709852462; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AUKs81hKZunyk3wFcrrlREf0TGlUU5PWAiTZswg+L+E=; b=VGBJn5yAFoit1fmXkaQ7T8UWCLphUyY/4fiAFXOC1hbXe6hfCGd8a0XEWM52SCjrt3 dySMD6fMuFKal8JYzBFScNrd/iuAD2AJ/4ZjtXReyeQsbLECRbzaOmVLPfdcxqKPkj4l m9W0Z04LIFfWrun8L3wDZz2MO6aHhc9d6/8cxjvbAiXDi/0aaenOypSr3U6cR3EGV6g2 bT8f1ZYFbrq0m8h6dGMgiVmh8wIOa0FSO60zUSh+LDQaubVEbXnHhsb1Do1Vp71ODzec NyS6kvKl9UtWUC6G1Q9U9JUpNPea4VADZxl/naHyDCxpaKAHiD1v/Y2X31NNRPo2pEs5 4ADQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247662; x=1709852462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AUKs81hKZunyk3wFcrrlREf0TGlUU5PWAiTZswg+L+E=; b=uKvqxs2KlE8Fw7ryI575dNB617dRuiHRDmtraIEK2WmmhaUPB052KEn33WT1lloFsS G0ydBLuS8CkhwQtOr9JD3XNLXEtXRyHZdjEyXo7kKHZkotK7tmJ5jVe9XjUfsQemIbc4 /wT3dsaqBu34AOS/m3rlNFbjlJ5S96OPOOEpZ89W6V8c9reql0gi037AMXyo/i8jvlvt ZM0PTMsVt2loQ1vzd3A/eOvvImDSrVctczNfMNhTwyRXn5kTqs1soTdXCYUP60WHLOra knlMzRPOvcokRLwcb4iwHabH7irtGxz6cec2YTRKUs17bdo9gjaiPdb01qs9A3FZ4NWr PK4Q== X-Gm-Message-State: AOJu0YysrauBaxZ+H884kMabVMqDiqbTLzxdtG8NEKaWHJaHbWblV42p 73VhpGwPXWXZM39vrLujXLxOx1qruB9Nf+bi1CG/MWYu7sUtcXkqd/lbKAcrnI5f/IQTCzGutgp ukWg= X-Google-Smtp-Source: AGHT+IFZrqEQxo4tvvfoAnRXiVQ0n8CfFQ8ZTp7Bu/RnkrbcZH5PWqJH5yZmnN5XmpwffLNOaEn6og== X-Received: by 2002:a17:90b:fc9:b0:299:7f4c:31e0 with SMTP id gd9-20020a17090b0fc900b002997f4c31e0mr36199pjb.1.1709247662195; Thu, 29 Feb 2024 15:01:02 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:01:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru , Tomasz Kantecki , Kirill Rybalchenko , Maxime Coquelin , Chenbo Xia Subject: [PATCH 71/71] examples: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:58 -0800 Message-ID: <20240229225936.483472-72-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 2 +- examples/l2fwd-cat/cat.c | 3 +-- examples/ptpclient/ptpclient.c | 11 +++++------ examples/vhost/main.c | 5 ++--- examples/vmdq/main.c | 5 ++--- examples/vmdq_dcb/main.c | 14 +++++--------- 6 files changed, 16 insertions(+), 24 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 16599ae9cee3..52c8eabba778 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -359,7 +359,7 @@ add_ether_hdr(struct rte_mbuf *pkt_src, struct rte_mbuf *pkt_dst) eth_to = rte_pktmbuf_mtod(pkt_dst, struct rte_ether_hdr *); /* copy header */ - rte_memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr)); + memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr)); } static inline void diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 00e4cde48b48..b03fef47fdb7 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -314,8 +314,7 @@ parse_l3ca(const char *l3ca) if (cmask != 0 && is_contiguous(cmask) == 0) goto err; - rte_memcpy(&m_config[idx].cpumask, - &cpuset, sizeof(rte_cpuset_t)); + memcpy(&m_config[idx].cpumask, &cpuset, sizeof(rte_cpuset_t)); if (cmask != 0) { m_config[idx].cdp = 1; diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c index 2535d848a1e9..e918bc05db34 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -359,9 +359,9 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx) ptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id); if (ptp_data->ptpset == 0) { - rte_memcpy(&ptp_data->master_clock_id, - &ptp_hdr->source_port_id.clock_id, - sizeof(struct clock_id)); + memcpy(&ptp_data->master_clock_id, + &ptp_hdr->source_port_id.clock_id, + sizeof(struct clock_id)); ptp_data->ptpset = 1; } @@ -466,9 +466,8 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data) client_clkid->id[6] = eth_hdr->src_addr.addr_bytes[4]; client_clkid->id[7] = eth_hdr->src_addr.addr_bytes[5]; - rte_memcpy(&ptp_data->client_clock_id, - client_clkid, - sizeof(struct clock_id)); + memcpy(&ptp_data->client_clock_id, client_clkid, + sizeof(struct clock_id)); /* Enable flag for hardware timestamping. */ created_pkt->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST; diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 3fc1b151d182..5691ec110ac8 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -405,9 +405,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_devices) conf.pool_map[i].pools = (1UL << i); } - (void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, - sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); + (void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); return 0; } diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index 4a3ce6884c5c..3a9d1281d901 100644 --- a/examples/vmdq/main.c +++ b/examples/vmdq/main.c @@ -151,9 +151,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_pools) conf.pool_map[i].pools = (1UL << (i % num_pools)); } - (void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, - sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); + (void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); if (rss_enable) { eth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_RSS; eth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP | diff --git a/examples/vmdq_dcb/main.c b/examples/vmdq_dcb/main.c index 4ccc2fe4b01c..4aab67b23d67 100644 --- a/examples/vmdq_dcb/main.c +++ b/examples/vmdq_dcb/main.c @@ -161,15 +161,11 @@ get_eth_conf(struct rte_eth_conf *eth_conf) tx_conf.dcb_tc[i] = i % num_tcs; } dcb_conf.nb_tcs = (enum rte_eth_nb_tcs)num_tcs; - (void)(rte_memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf, - sizeof(conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf, - sizeof(dcb_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf, - sizeof(vmdq_conf))); - (void)(rte_memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf, - sizeof(tx_conf))); + (void)(memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf, sizeof(conf))); + (void)(memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf, sizeof(dcb_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf, sizeof(vmdq_conf))); + (void)(memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf, sizeof(tx_conf))); if (rss_enable) { eth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_DCB_RSS; eth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP |