Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137208/?format=api
{ "id": 137208, "url": "http://patches.dpdk.org/api/patches/137208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240226131848.2982242-2-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240226131848.2982242-2-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240226131848.2982242-2-michaelba@nvidia.com", "date": "2024-02-26T13:18:46", "name": "[v7,1/3] net/mlx5/hws: add support for compare matcher", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "70bb4de8fb437b217c280c13de74a3d068410855", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240226131848.2982242-2-michaelba@nvidia.com/mbox/", "series": [ { "id": 31223, "url": "http://patches.dpdk.org/api/series/31223/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31223", "date": "2024-02-26T13:18:46", "name": "net/mlx5: add compare item support", "version": 7, "mbox": "http://patches.dpdk.org/series/31223/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137208/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137208/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86BCF43BED;\n\tMon, 26 Feb 2024 14:19:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56E8640271;\n\tMon, 26 Feb 2024 14:19:16 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85])\n by mails.dpdk.org (Postfix) with ESMTP id D621940144\n for <dev@dpdk.org>; Mon, 26 Feb 2024 14:19:14 +0100 (CET)", "from BYAPR07CA0033.namprd07.prod.outlook.com (2603:10b6:a02:bc::46)\n by BN9PR12MB5339.namprd12.prod.outlook.com (2603:10b6:408:104::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Mon, 26 Feb\n 2024 13:19:10 +0000", "from DS3PEPF000099E2.namprd04.prod.outlook.com\n (2603:10b6:a02:bc:cafe::9f) by BYAPR07CA0033.outlook.office365.com\n (2603:10b6:a02:bc::46) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend\n Transport; Mon, 26 Feb 2024 13:19:09 +0000", "from mail.nvidia.com (216.228.118.233) by\n DS3PEPF000099E2.mail.protection.outlook.com (10.167.17.201) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Mon, 26 Feb 2024 13:19:09 +0000", "from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com\n (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 26 Feb\n 2024 05:18:57 -0800", "from drhqmail203.nvidia.com (10.126.190.182) by\n drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Mon, 26 Feb 2024 05:18:57 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.182)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Mon, 26 Feb 2024 05:18:55 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=bCaEjSGZ4aFn3zPHw/ep5RwT9ndXMaSLd4XkbSyfxPPjuC9scLoZ6v7lMRshHkN/FkwiCs6GafsZ+/MIyLAotFnHuysrU6ssOmf0UJipsPGOoBeWc6UkOTAYzSoTxbV0pnITfDZt3l4Txttn0T92AOr9J3952GdtmAQJP3QS/+kleRYJLg6TUD7DWgB3Kqc1UKIj4j7v37q4a/2sy6WNii+XpwXknb9ExGS+s9nvccTPO4yAR8a3IsQbgA7kn/fIay/JmjNxHUZ7Il+G3NHaswMPe7JtAJc23hIFLw945v6pFNuG3v0lEaiVk1+hwmhz3hEzWRIKsiR0ipQO9uVg8A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Lql5G0O/Fk0x2ccZ3a3XlPzq4ioTlv/bt61ACavDjHM=;\n b=nmTJBctKM+J3t/Y/ow13KskXH3zABt5kYeDLmmvg2hw1ssR/ZxpRf+z/y7epaIeE95Ns7CMIeNFCjEKwASUvLwZzRxQmyj/+KIwRXY+2jtLqj61j56R+NJgihtRjislUS+P5f5uDLP/7F8Uz2z29n1LUdIW4cZkhfvv0MeYLjuGpdrMMj4DBxtWYBT4xJYOj6X9y+5V3OWHbcEPka0uAnYE9R/vqp/SqSV9d63fb5KLD6KYJa1s3K+I6cLkzQyvN2a1CQ6E3+fBQRNCul54HCJ3KHhMejdu3F14EVTcBKZ3S+rGY5fQkLyVG1DzQMKZnaTiEE8mBHGyxErwVSqeP5g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Lql5G0O/Fk0x2ccZ3a3XlPzq4ioTlv/bt61ACavDjHM=;\n b=Z4laZuj1nC8swSkb9ft5+hiCo1a7JIEodHdoCwkdDAMdyUrg/pkzaesRIGY419I9EJsR36Nj/AbP018d/mUkCB+VgvnM/iYF+eBJ/yjpK0RUpiMYy0EInVy2Nj3x6HChgiaftaX1htKm22rMxk4xqJ2nrS2TO8r8IIbvZLe7heLpr0PEtcbVlehC6qjf50v14YPYktrH/tMjDDp4eTSJ1ktrnWek54g8qgKIPd927m2G5ltQQsLXavXC8wzI5w0ESa8yzhPtH/KXsKmkLIS7L6QPDTzwYpHcD2SJ2gYH1CjKeV34sWL85vxgnSRVJZYT7hu7xHelohk0omnFcnilMA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.233)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.233 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>, Hamdan Igbaria <hamdani@nvidia.com>", "Subject": "[PATCH v7 1/3] net/mlx5/hws: add support for compare matcher", "Date": "Mon, 26 Feb 2024 15:18:46 +0200", "Message-ID": "<20240226131848.2982242-2-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240226131848.2982242-1-michaelba@nvidia.com>", "References": "<20240226130324.2981025-1-michaelba@nvidia.com>\n <20240226131848.2982242-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS3PEPF000099E2:EE_|BN9PR12MB5339:EE_", "X-MS-Office365-Filtering-Correlation-Id": "2e645260-74d8-4542-7c1d-08dc36cd844a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 4IaKxx8nUA53oNXe3zXXwX6uhy8eZJcQ9SIRK4xQ23j1p9E/+fBiS0zD1u2RNyUc9y4MJJ25A3ewCjFBnc9Dx0BClVCFJ7zYp8J2v4CuqVSUi1K6GUg2+dSAld+xJzhiI7OsraDT6v/Ena66SNv8I3X0az8slhRdwH1Y5hfpFFc+r+kntf7SoqmHRwa8nB3JkesG9IGzHWW4zjJwddnVnLpxWw45OGL5S8OlBamiFNeXn50vQ5br31iXLMxRnhUY8vtWKYZ7vAIJIXmG2/KlZHenCkYqIn7mymA9iM6Aw1EZqXKWXA4xT3NVQv87+ysF0AWX2clifvPuTSP107H9KEAw6HtGvg/O/Q87sjdvtd6TNYr+udKEHOsjeCOGSItW+9xh0TD39sn3Ck2XsrcEMzjJpNnWUOupj64ZwfsQ5dap3keo6cseIxArQd2rUu72QCFWIkGXBrO4GOXNlmwtNMJGV2F4XwEMitdgwoy4VOPSwhxZeGmo5HGyC8uh9JmzkKec3inHl1ieWNhgBe8XC/s28goPMHcqFA5FjjQkUS5/yeRLUwwKga5uff70ozaqg1z1I9baxSyNQ/eBRIHA81inaw9crwpWKwnNHwUg0+jF9L3L5FjovG2cexvZhitDPZMpf0F6R3oiDKa8v9PaH5GSLv8RHHxjchqZORLafvUIJPzHvi7OfACw2qQlGbkqzxgjw0DKZL8UhXa5+YeS03UqFDwOcQJY++6sxMX9xDtGCNCtheBIfL9bPZ+fuXci", "X-Forefront-Antispam-Report": "CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Feb 2024 13:19:09.4187 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2e645260-74d8-4542-7c1d-08dc36cd844a", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DS3PEPF000099E2.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN9PR12MB5339", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hamdan Igbaria <hamdani@nvidia.com>\n\nAdd support for compare matcher, this matcher will allow\ndirect comparison between two packet fields, or a packet\nfield and a value, with fully masked DW.\nFor now this matcher hash table is limited to size 1x1,\nthus it supports only 1 rule STE.\n\nSigned-off-by: Hamdan Igbaria <hamdani@nvidia.com>\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Suanming Mou <suanmingm@nvidia.com>\n---\n drivers/common/mlx5/mlx5_prm.h | 16 ++\n drivers/net/mlx5/hws/mlx5dr_cmd.c | 9 +-\n drivers/net/mlx5/hws/mlx5dr_cmd.h | 1 +\n drivers/net/mlx5/hws/mlx5dr_debug.c | 4 +-\n drivers/net/mlx5/hws/mlx5dr_debug.h | 1 +\n drivers/net/mlx5/hws/mlx5dr_definer.c | 243 +++++++++++++++++++++++++-\n drivers/net/mlx5/hws/mlx5dr_definer.h | 33 ++++\n drivers/net/mlx5/hws/mlx5dr_matcher.c | 53 ++++++\n drivers/net/mlx5/hws/mlx5dr_matcher.h | 12 +-\n 9 files changed, 363 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex 282e59e52c..aceacb04d0 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -3463,6 +3463,7 @@ enum mlx5_ifc_rtc_ste_format {\n \tMLX5_IFC_RTC_STE_FORMAT_8DW = 0x4,\n \tMLX5_IFC_RTC_STE_FORMAT_11DW = 0x5,\n \tMLX5_IFC_RTC_STE_FORMAT_RANGE = 0x7,\n+\tMLX5_IFC_RTC_STE_FORMAT_4DW_RANGE = 0x8,\n };\n \n enum mlx5_ifc_rtc_reparse_mode {\n@@ -3501,6 +3502,21 @@ struct mlx5_ifc_rtc_bits {\n \tu8 reserved_at_1a0[0x260];\n };\n \n+struct mlx5_ifc_ste_match_4dw_range_ctrl_dw_bits {\n+\tu8 match[0x1];\n+\tu8 reserved_at_1[0x2];\n+\tu8 base1[0x1];\n+\tu8 inverse1[0x1];\n+\tu8 reserved_at_5[0x1];\n+\tu8 operator1[0x2];\n+\tu8 reserved_at_8[0x3];\n+\tu8 base0[0x1];\n+\tu8 inverse0[0x1];\n+\tu8 reserved_at_a[0x1];\n+\tu8 operator0[0x2];\n+\tu8 compare_delta[0x10];\n+};\n+\n struct mlx5_ifc_alias_context_bits {\n \tu8 vhca_id_to_be_accessed[0x10];\n \tu8 reserved_at_10[0xd];\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c\nindex fd07028e5f..0e0cc479a6 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c\n@@ -370,9 +370,12 @@ mlx5dr_cmd_rtc_create(struct ibv_context *ctx,\n \t\t attr, obj_type, MLX5_GENERAL_OBJ_TYPE_RTC);\n \n \tattr = MLX5_ADDR_OF(create_rtc_in, in, rtc);\n-\tMLX5_SET(rtc, attr, ste_format_0, rtc_attr->is_frst_jumbo ?\n-\t\tMLX5_IFC_RTC_STE_FORMAT_11DW :\n-\t\tMLX5_IFC_RTC_STE_FORMAT_8DW);\n+\tif (rtc_attr->is_compare) {\n+\t\tMLX5_SET(rtc, attr, ste_format_0, MLX5_IFC_RTC_STE_FORMAT_4DW_RANGE);\n+\t} else {\n+\t\tMLX5_SET(rtc, attr, ste_format_0, rtc_attr->is_frst_jumbo ?\n+\t\t\t MLX5_IFC_RTC_STE_FORMAT_11DW : MLX5_IFC_RTC_STE_FORMAT_8DW);\n+\t}\n \n \tif (rtc_attr->is_scnd_range) {\n \t\tMLX5_SET(rtc, attr, ste_format_1, MLX5_IFC_RTC_STE_FORMAT_RANGE);\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h\nindex ee4a61b7eb..9d385fc57f 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h\n@@ -82,6 +82,7 @@ struct mlx5dr_cmd_rtc_create_attr {\n \tuint8_t reparse_mode;\n \tbool is_frst_jumbo;\n \tbool is_scnd_range;\n+\tbool is_compare;\n };\n \n struct mlx5dr_cmd_alias_obj_create_attr {\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5dr_debug.c\nindex 11557bcab8..a9094cd35b 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_debug.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_debug.c\n@@ -99,6 +99,7 @@ static int\n mlx5dr_debug_dump_matcher_match_template(FILE *f, struct mlx5dr_matcher *matcher)\n {\n \tbool is_root = matcher->tbl->level == MLX5DR_ROOT_LEVEL;\n+\tbool is_compare = mlx5dr_matcher_is_compare(matcher);\n \tenum mlx5dr_debug_res_type type;\n \tint i, ret;\n \n@@ -117,7 +118,8 @@ mlx5dr_debug_dump_matcher_match_template(FILE *f, struct mlx5dr_matcher *matcher\n \t\t\treturn rte_errno;\n \t\t}\n \n-\t\ttype = MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_MATCH_DEFINER;\n+\t\ttype = is_compare ? MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_COMPARE_MATCH_DEFINER :\n+\t\t\t\t MLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_MATCH_DEFINER;\n \t\tret = mlx5dr_debug_dump_matcher_template_definer(f, mt, mt->definer, type);\n \t\tif (ret)\n \t\t\treturn ret;\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_debug.h b/drivers/net/mlx5/hws/mlx5dr_debug.h\nindex 5cffdb10b5..a89a6a0b1d 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_debug.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_debug.h\n@@ -24,6 +24,7 @@ enum mlx5dr_debug_res_type {\n \tMLX5DR_DEBUG_RES_TYPE_MATCHER_ACTION_TEMPLATE = 4204,\n \tMLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_HASH_DEFINER = 4205,\n \tMLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_RANGE_DEFINER = 4206,\n+\tMLX5DR_DEBUG_RES_TYPE_MATCHER_TEMPLATE_COMPARE_MATCH_DEFINER = 4207,\n };\n \n static inline uint64_t\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c\nindex cde41f1617..45e5bc5a61 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_definer.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c\n@@ -411,6 +411,86 @@ mlx5dr_definer_ptype_frag_set(struct mlx5dr_definer_fc *fc,\n \tDR_SET(tag, !!packet_type, fc->byte_off, fc->bit_off, fc->bit_mask);\n }\n \n+static void\n+mlx5dr_definer_compare_base_value_set(const void *item_spec,\n+\t\t\t\t uint8_t *tag)\n+{\n+\tuint32_t *ctrl = &(((uint32_t *)tag)[MLX5DR_DEFINER_COMPARE_STE_ARGUMENT_1]);\n+\tuint32_t *base = &(((uint32_t *)tag)[MLX5DR_DEFINER_COMPARE_STE_BASE_0]);\n+\tconst struct rte_flow_item_compare *v = item_spec;\n+\tconst struct rte_flow_field_data *a = &v->a;\n+\tconst struct rte_flow_field_data *b = &v->b;\n+\tconst uint32_t *value;\n+\n+\tvalue = (const uint32_t *)&b->value[0];\n+\n+\tif (a->field == RTE_FLOW_FIELD_RANDOM)\n+\t\t*base = htobe32(*value << 16);\n+\telse\n+\t\t*base = htobe32(*value);\n+\n+\tMLX5_SET(ste_match_4dw_range_ctrl_dw, ctrl, base0, 1);\n+}\n+\n+static void\n+mlx5dr_definer_compare_op_translate(enum rte_flow_item_compare_op op,\n+\t\t\t\t uint8_t *tag)\n+{\n+\tuint32_t *ctrl = &(((uint32_t *)tag)[MLX5DR_DEFINER_COMPARE_STE_ARGUMENT_1]);\n+\tuint8_t operator = 0;\n+\tuint8_t inverse = 0;\n+\n+\tswitch (op) {\n+\tcase RTE_FLOW_ITEM_COMPARE_EQ:\n+\t\toperator = 2;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_COMPARE_NE:\n+\t\toperator = 2;\n+\t\tinverse = 1;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_COMPARE_LT:\n+\t\tinverse = 1;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_COMPARE_LE:\n+\t\toperator = 1;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_COMPARE_GT:\n+\t\toperator = 1;\n+\t\tinverse = 1;\n+\t\tbreak;\n+\tcase RTE_FLOW_ITEM_COMPARE_GE:\n+\t\tbreak;\n+\tdefault:\n+\t\tDR_LOG(ERR, \"Invalid operation type %d\", op);\n+\t\tassert(false);\n+\t}\n+\n+\tMLX5_SET(ste_match_4dw_range_ctrl_dw, ctrl, inverse0, inverse);\n+\tMLX5_SET(ste_match_4dw_range_ctrl_dw, ctrl, operator0, operator);\n+}\n+\n+static void\n+mlx5dr_definer_compare_arg_set(const void *item_spec,\n+\t\t\t uint8_t *tag)\n+{\n+\tconst struct rte_flow_item_compare *v = item_spec;\n+\tenum rte_flow_item_compare_op op = v->operation;\n+\n+\tmlx5dr_definer_compare_op_translate(op, tag);\n+}\n+\n+static void\n+mlx5dr_definer_compare_set(struct mlx5dr_definer_fc *fc,\n+\t\t\t const void *item_spec,\n+\t\t\t uint8_t *tag)\n+{\n+\tif (fc->compare_idx == MLX5DR_DEFINER_COMPARE_ARGUMENT_0) {\n+\t\tmlx5dr_definer_compare_arg_set(item_spec, tag);\n+\t\tif (fc->compare_set_base)\n+\t\t\tmlx5dr_definer_compare_base_value_set(item_spec, tag);\n+\t}\n+}\n+\n static void\n mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc,\n \t\t\t const void *item_spec,\n@@ -2782,10 +2862,124 @@ mlx5dr_definer_conv_item_vxlan_gpe(struct mlx5dr_definer_conv_data *cd,\n \treturn 0;\n }\n \n+static int\n+mlx5dr_definer_conv_item_compare_field(const struct rte_flow_field_data *f,\n+\t\t\t\t const struct rte_flow_field_data *other_f,\n+\t\t\t\t struct mlx5dr_definer_conv_data *cd,\n+\t\t\t\t int item_idx,\n+\t\t\t\t enum mlx5dr_definer_compare_dw_selectors dw_offset)\n+{\n+\tstruct mlx5dr_definer_fc *fc = NULL;\n+\tint reg;\n+\n+\tif (f->offset) {\n+\t\tDR_LOG(ERR, \"field offset %u is not supported, only offset zero supported\",\n+\t\t f->offset);\n+\t\tgoto err_notsup;\n+\t}\n+\n+\tswitch (f->field) {\n+\tcase RTE_FLOW_FIELD_META:\n+\t\treg = flow_hw_get_reg_id_from_ctx(cd->ctx,\n+\t\t\t\t\t\t RTE_FLOW_ITEM_TYPE_META, -1);\n+\t\tif (reg <= 0) {\n+\t\t\tDR_LOG(ERR, \"Invalid register for compare metadata field\");\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn rte_errno;\n+\t\t}\n+\n+\t\tfc = mlx5dr_definer_get_register_fc(cd, reg);\n+\t\tif (!fc)\n+\t\t\treturn rte_errno;\n+\n+\t\tfc->item_idx = item_idx;\n+\t\tfc->tag_set = &mlx5dr_definer_compare_set;\n+\t\tfc->tag_mask_set = &mlx5dr_definer_ones_set;\n+\t\tfc->compare_idx = dw_offset;\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_TAG:\n+\t\treg = flow_hw_get_reg_id_from_ctx(cd->ctx,\n+\t\t\t\t\t\t RTE_FLOW_ITEM_TYPE_TAG,\n+\t\t\t\t\t\t f->tag_index);\n+\t\tif (reg <= 0) {\n+\t\t\tDR_LOG(ERR, \"Invalid register for compare tag field\");\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn rte_errno;\n+\t\t}\n+\n+\t\tfc = mlx5dr_definer_get_register_fc(cd, reg);\n+\t\tif (!fc)\n+\t\t\treturn rte_errno;\n+\n+\t\tfc->item_idx = item_idx;\n+\t\tfc->tag_set = &mlx5dr_definer_compare_set;\n+\t\tfc->tag_mask_set = &mlx5dr_definer_ones_set;\n+\t\tfc->compare_idx = dw_offset;\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_VALUE:\n+\t\tif (dw_offset == MLX5DR_DEFINER_COMPARE_ARGUMENT_0) {\n+\t\t\tDR_LOG(ERR, \"Argument field does not support immediate value\");\n+\t\t\tgoto err_notsup;\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\tfc = &cd->fc[MLX5DR_DEFINER_FNAME_RANDOM_NUM];\n+\t\tfc->item_idx = item_idx;\n+\t\tfc->tag_set = &mlx5dr_definer_compare_set;\n+\t\tfc->tag_mask_set = &mlx5dr_definer_ones_set;\n+\t\tfc->compare_idx = dw_offset;\n+\t\tDR_CALC_SET_HDR(fc, random_number, random_number);\n+\t\tbreak;\n+\tdefault:\n+\t\tDR_LOG(ERR, \"%u field is not supported\", f->field);\n+\t\tgoto err_notsup;\n+\t}\n+\n+\tif (fc && other_f && other_f->field == RTE_FLOW_FIELD_VALUE)\n+\t\tfc->compare_set_base = true;\n+\n+\treturn 0;\n+\n+err_notsup:\n+\trte_errno = ENOTSUP;\n+\treturn rte_errno;\n+}\n+\n+static int\n+mlx5dr_definer_conv_item_compare(struct mlx5dr_definer_conv_data *cd,\n+\t\t\t\t struct rte_flow_item *item,\n+\t\t\t\t int item_idx)\n+{\n+\tconst struct rte_flow_item_compare *m = item->mask;\n+\tconst struct rte_flow_field_data *a = &m->a;\n+\tconst struct rte_flow_field_data *b = &m->b;\n+\tint ret;\n+\n+\tif (m->width != 0xffffffff) {\n+\t\tDR_LOG(ERR, \"compare item width of 0x%x is not supported, only full DW supported\",\n+\t\t\t\tm->width);\n+\t\trte_errno = ENOTSUP;\n+\t\treturn rte_errno;\n+\t}\n+\n+\tret = mlx5dr_definer_conv_item_compare_field(a, b, cd, item_idx,\n+\t\t\t\t\t\t MLX5DR_DEFINER_COMPARE_ARGUMENT_0);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = mlx5dr_definer_conv_item_compare_field(b, NULL, cd, item_idx,\n+\t\t\t\t\t\t MLX5DR_DEFINER_COMPARE_BASE_0);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\treturn 0;\n+}\n+\n static int\n mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,\n \t\t\t\tstruct mlx5dr_match_template *mt,\n-\t\t\t\tuint8_t *hl)\n+\t\t\t\tuint8_t *hl,\n+\t\t\t\tstruct mlx5dr_matcher *matcher)\n {\n \tstruct mlx5dr_definer_fc fc[MLX5DR_DEFINER_FNAME_MAX] = {{0}};\n \tstruct mlx5dr_definer_conv_data cd = {0};\n@@ -2805,6 +2999,11 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,\n \t\tif (ret)\n \t\t\treturn ret;\n \n+\t\tif (mlx5dr_matcher_is_compare(matcher)) {\n+\t\t\tDR_LOG(ERR, \"Compare matcher not supported for more than one item\");\n+\t\t\tgoto not_supp;\n+\t\t}\n+\n \t\tswitch ((int)items->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t\tret = mlx5dr_definer_conv_item_eth(&cd, items, i);\n@@ -2950,12 +3149,20 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,\n \t\t\tret = mlx5dr_definer_conv_item_vxlan_gpe(&cd, items, i);\n \t\t\titem_flags |= MLX5_FLOW_LAYER_VXLAN_GPE;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_COMPARE:\n+\t\t\tif (i) {\n+\t\t\t\tDR_LOG(ERR, \"Compare matcher not supported for more than one item\");\n+\t\t\t\tgoto not_supp;\n+\t\t\t}\n+\t\t\tret = mlx5dr_definer_conv_item_compare(&cd, items, i);\n+\t\t\titem_flags |= MLX5_FLOW_ITEM_COMPARE;\n+\t\t\tmatcher->flags |= MLX5DR_MATCHER_FLAGS_COMPARE;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_VOID:\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tDR_LOG(ERR, \"Unsupported item type %d\", items->type);\n-\t\t\trte_errno = ENOTSUP;\n-\t\t\treturn rte_errno;\n+\t\t\tgoto not_supp;\n \t\t}\n \n \t\tcd.last_item = items->type;\n@@ -2976,6 +3183,10 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,\n \t}\n \n \treturn 0;\n+\n+not_supp:\n+\trte_errno = ENOTSUP;\n+\treturn rte_errno;\n }\n \n static int\n@@ -3393,6 +3604,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,\n {\n \tstruct mlx5dr_context *ctx = matcher->tbl->ctx;\n \tstruct mlx5dr_match_template *mt = matcher->mt;\n+\tstruct mlx5dr_definer_fc *fc;\n \tuint8_t *match_hl;\n \tint i, ret;\n \n@@ -3410,13 +3622,35 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,\n \t * and allocate the match and range field copy array (fc & fcr).\n \t */\n \tfor (i = 0; i < matcher->num_of_mt; i++) {\n-\t\tret = mlx5dr_definer_conv_items_to_hl(ctx, &mt[i], match_hl);\n+\t\tret = mlx5dr_definer_conv_items_to_hl(ctx, &mt[i], match_hl, matcher);\n \t\tif (ret) {\n \t\t\tDR_LOG(ERR, \"Failed to convert items to header layout\");\n \t\t\tgoto free_fc;\n \t\t}\n \t}\n \n+\tif (mlx5dr_matcher_is_compare(matcher)) {\n+\t\tret = mlx5dr_matcher_validate_compare_attr(matcher);\n+\t\tif (ret)\n+\t\t\tgoto free_fc;\n+\n+\t\t/* Due some HW limitation need to fill unused\n+\t\t * DW's 0-5 and byte selectors with 0xff.\n+\t\t */\n+\t\tfor (i = 0; i < DW_SELECTORS_MATCH; i++)\n+\t\t\tmatch_definer->dw_selector[i] = 0xff;\n+\n+\t\tfor (i = 0; i < BYTE_SELECTORS; i++)\n+\t\t\tmatch_definer->byte_selector[i] = 0xff;\n+\n+\t\tfor (i = 0; i < mt[0].fc_sz; i++) {\n+\t\t\tfc = &mt[0].fc[i];\n+\t\t\tmatch_definer->dw_selector[fc->compare_idx] = fc->byte_off / DW_SIZE;\n+\t\t}\n+\n+\t\tgoto out;\n+\t}\n+\n \t/* Find the match definer layout for header layout match union */\n \tret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl);\n \tif (ret) {\n@@ -3437,6 +3671,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,\n \t\tgoto free_fc;\n \t}\n \n+out:\n \tsimple_free(match_hl);\n \treturn 0;\n \ndiff --git a/drivers/net/mlx5/hws/mlx5dr_definer.h b/drivers/net/mlx5/hws/mlx5dr_definer.h\nindex 71cc0e94de..ca530ebf30 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_definer.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_definer.h\n@@ -17,6 +17,37 @@\n #define DW_SELECTORS_RANGE 2\n #define BYTE_SELECTORS_RANGE 8\n \n+enum mlx5dr_definer_compare_ste_dw_offset {\n+\t/* In compare STE the matching DW's starts after the 3 actions */\n+\tMLX5DR_DEFINER_COMPARE_STE_ARGUMENT_1 = 3,\n+\tMLX5DR_DEFINER_COMPARE_STE_ARGUMENT_0,\n+\tMLX5DR_DEFINER_COMPARE_STE_BASE_1,\n+\tMLX5DR_DEFINER_COMPARE_STE_BASE_0,\n+\tMLX5DR_DEFINER_COMPARE_STE_TAG_DW_3,\n+\tMLX5DR_DEFINER_COMPARE_STE_TAG_DW_2,\n+\tMLX5DR_DEFINER_COMPARE_STE_TAG_DW_1,\n+\tMLX5DR_DEFINER_COMPARE_STE_TAG_DW_0,\n+};\n+\n+enum mlx5dr_definer_dw_selectors {\n+\tMLX5DR_DEFINER_SELECTOR_DW0,\n+\tMLX5DR_DEFINER_SELECTOR_DW1,\n+\tMLX5DR_DEFINER_SELECTOR_DW2,\n+\tMLX5DR_DEFINER_SELECTOR_DW3,\n+\tMLX5DR_DEFINER_SELECTOR_DW4,\n+\tMLX5DR_DEFINER_SELECTOR_DW5,\n+\tMLX5DR_DEFINER_SELECTOR_DW6,\n+\tMLX5DR_DEFINER_SELECTOR_DW7,\n+\tMLX5DR_DEFINER_SELECTOR_DW8,\n+};\n+\n+enum mlx5dr_definer_compare_dw_selectors {\n+\tMLX5DR_DEFINER_COMPARE_ARGUMENT_0 = MLX5DR_DEFINER_SELECTOR_DW4,\n+\tMLX5DR_DEFINER_COMPARE_ARGUMENT_1 = MLX5DR_DEFINER_SELECTOR_DW5,\n+\tMLX5DR_DEFINER_COMPARE_BASE_0 = MLX5DR_DEFINER_SELECTOR_DW2,\n+\tMLX5DR_DEFINER_COMPARE_BASE_1 = MLX5DR_DEFINER_SELECTOR_DW3,\n+};\n+\n enum mlx5dr_definer_fname {\n \tMLX5DR_DEFINER_FNAME_ETH_SMAC_48_16_O,\n \tMLX5DR_DEFINER_FNAME_ETH_SMAC_48_16_I,\n@@ -188,6 +219,8 @@ struct mlx5dr_definer_fc {\n \tuint8_t item_idx;\n \tuint8_t is_range;\n \tuint16_t extra_data;\n+\tuint8_t compare_idx;\n+\tbool compare_set_base;\n \tuint32_t byte_off;\n \tint bit_off;\n \tuint32_t bit_mask;\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c\nindex 402242308d..8a74a1ed7d 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c\n@@ -485,6 +485,7 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher,\n \t\trtc_attr.log_depth = attr->table.sz_col_log;\n \t\trtc_attr.is_frst_jumbo = mlx5dr_matcher_mt_is_jumbo(mt);\n \t\trtc_attr.is_scnd_range = mlx5dr_matcher_mt_is_range(mt);\n+\t\trtc_attr.is_compare = mlx5dr_matcher_is_compare(matcher);\n \t\trtc_attr.miss_ft_id = matcher->end_ft->id;\n \n \t\tif (attr->insert_mode == MLX5DR_MATCHER_INSERT_BY_HASH) {\n@@ -497,6 +498,10 @@ static int mlx5dr_matcher_create_rtc(struct mlx5dr_matcher *matcher,\n \t\t\t\trtc_attr.num_hash_definer = 1;\n \t\t\t\trtc_attr.match_definer_0 =\n \t\t\t\t\tmlx5dr_definer_get_id(matcher->hash_definer);\n+\t\t\t} else if (mlx5dr_matcher_is_compare(matcher)) {\n+\t\t\t\trtc_attr.match_definer_0 = ctx->caps->trivial_match_definer;\n+\t\t\t\trtc_attr.fw_gen_wqe = true;\n+\t\t\t\trtc_attr.num_hash_definer = 1;\n \t\t\t} else {\n \t\t\t\t/* The first mt is used since all share the same definer */\n \t\t\t\trtc_attr.match_definer_0 = mlx5dr_definer_get_id(mt->definer);\n@@ -1635,3 +1640,51 @@ int mlx5dr_matcher_resize_rule_move(struct mlx5dr_matcher *src_matcher,\n \trte_errno = EINVAL;\n \treturn -rte_errno;\n }\n+\n+int mlx5dr_matcher_validate_compare_attr(struct mlx5dr_matcher *matcher)\n+{\n+\tstruct mlx5dr_cmd_query_caps *caps = matcher->tbl->ctx->caps;\n+\tstruct mlx5dr_matcher_attr *attr = &matcher->attr;\n+\n+\tif (mlx5dr_table_is_root(matcher->tbl)) {\n+\t\tDR_LOG(ERR, \"Compare matcher is not supported for root tables\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (attr->mode != MLX5DR_MATCHER_RESOURCE_MODE_HTABLE) {\n+\t\tDR_LOG(ERR, \"Compare matcher is only supported with pre-defined table size\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (attr->insert_mode != MLX5DR_MATCHER_INSERT_BY_HASH ||\n+\t\tattr->distribute_mode != MLX5DR_MATCHER_DISTRIBUTE_BY_HASH) {\n+\t\tDR_LOG(ERR, \"Gen WQE for compare matcher must be inserted and distribute by hash\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (matcher->num_of_mt != 1 || matcher->num_of_at != 1) {\n+\t\tDR_LOG(ERR, \"Compare matcher match templates and action templates must be 1 for each\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (attr->table.sz_col_log || attr->table.sz_row_log) {\n+\t\tDR_LOG(ERR, \"Compare matcher supports only 1x1 table size\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (attr->resizable) {\n+\t\tDR_LOG(ERR, \"Compare matcher does not support resizeing\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (!IS_BIT_SET(caps->supp_ste_format_gen_wqe, MLX5_IFC_RTC_STE_FORMAT_4DW_RANGE)) {\n+\t\tDR_LOG(ERR, \"Gen WQE Compare match format not supported\");\n+\t\tgoto err;\n+\t}\n+\n+\treturn 0;\n+\n+err:\n+\trte_errno = ENOTSUP;\n+\treturn rte_errno;\n+}\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.h b/drivers/net/mlx5/hws/mlx5dr_matcher.h\nindex 0f2bf96e8b..6dc3bf4d0d 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_matcher.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.h\n@@ -27,6 +27,7 @@ enum mlx5dr_matcher_flags {\n \tMLX5DR_MATCHER_FLAGS_HASH_DEFINER\t= 1 << 1,\n \tMLX5DR_MATCHER_FLAGS_COLLISION\t\t= 1 << 2,\n \tMLX5DR_MATCHER_FLAGS_RESIZABLE\t\t= 1 << 3,\n+\tMLX5DR_MATCHER_FLAGS_COMPARE\t\t= 1 << 4,\n };\n \n struct mlx5dr_match_template {\n@@ -110,12 +111,19 @@ static inline bool mlx5dr_matcher_is_in_resize(struct mlx5dr_matcher *matcher)\n \treturn !!matcher->resize_dst;\n }\n \n+static inline bool\n+mlx5dr_matcher_is_compare(struct mlx5dr_matcher *matcher)\n+{\n+\treturn !!(matcher->flags & MLX5DR_MATCHER_FLAGS_COMPARE);\n+}\n+\n static inline bool mlx5dr_matcher_req_fw_wqe(struct mlx5dr_matcher *matcher)\n {\n \t/* Currently HWS doesn't support hash different from match or range */\n \treturn unlikely(matcher->flags &\n \t\t\t(MLX5DR_MATCHER_FLAGS_HASH_DEFINER |\n-\t\t\t MLX5DR_MATCHER_FLAGS_RANGE_DEFINER));\n+\t\t\t MLX5DR_MATCHER_FLAGS_RANGE_DEFINER |\n+\t\t\t MLX5DR_MATCHER_FLAGS_COMPARE));\n }\n \n int mlx5dr_matcher_conv_items_to_prm(uint64_t *match_buf,\n@@ -141,4 +149,6 @@ int mlx5dr_matcher_free_rtc_pointing(struct mlx5dr_context *ctx,\n \t\t\t\t enum mlx5dr_table_type type,\n \t\t\t\t struct mlx5dr_devx_obj *devx_obj);\n \n+int mlx5dr_matcher_validate_compare_attr(struct mlx5dr_matcher *matcher);\n+\n #endif /* MLX5DR_MATCHER_H_ */\n", "prefixes": [ "v7", "1/3" ] }