Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136410/?format=api
{ "id": 136410, "url": "http://patches.dpdk.org/api/patches/136410/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240205180328.131019-24-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240205180328.131019-24-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240205180328.131019-24-stephen@networkplumber.org", "date": "2024-02-05T17:43:51", "name": "[v9,23/23] drivers: remove use of term sanity check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e0536806563a05a3d7f93fdb527b38a171454af0", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240205180328.131019-24-stephen@networkplumber.org/mbox/", "series": [ { "id": 31003, "url": "http://patches.dpdk.org/api/series/31003/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31003", "date": "2024-02-05T17:43:28", "name": "Use inclusive naming in DPDK", "version": 9, "mbox": "http://patches.dpdk.org/series/31003/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136410/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136410/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E776743A3D;\n\tMon, 5 Feb 2024 19:06:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B878142DC9;\n\tMon, 5 Feb 2024 19:04:06 +0100 (CET)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id A594A427E8\n for <dev@dpdk.org>; Mon, 5 Feb 2024 19:04:00 +0100 (CET)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1d93b525959so37921905ad.0\n for <dev@dpdk.org>; Mon, 05 Feb 2024 10:04:00 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n x8-20020a170902b40800b001d9b0a15bbfsm144867plr.262.2024.02.05.10.03.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 05 Feb 2024 10:03:59 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707156240;\n x=1707761040; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BTxIIJtDDAub74TaBkECgdiDvPJkkLOw8MTt5rTvcgk=;\n b=q+lTtgvzlG5SBCEE+by/1uSF3Zegvs9MAB7uhK3wEDVQa8JuIgWTCfVy5eYxiSYE9N\n O6/Qth95Gfx0iVK5N2jEVp2vpEFgpFBA6NUNzwJpskkCfSTs0M4ihMHPjrDflbObwHqA\n RoypxpqpJ13LdtzSIVmtgypzWmIdxarozn1Hz1RI9lLd/Bx2ecLpypv7RCfVuK79VzAM\n HLhFq884vq+0DBlm4Jys1lhp8NYrxe/9LQ3Xfnm3ZNG0FairSum8IGBnoqMyM3Vj/K2S\n RscjenJUTInTbW74LogHKC24YiP3ISwo+WEu/2bzDa+iwL4c+bFSreL26LsO1OQFSHwy\n dfzg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1707156240; x=1707761040;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=BTxIIJtDDAub74TaBkECgdiDvPJkkLOw8MTt5rTvcgk=;\n b=QYqoGIjBGWfVegbBKIPSXZvvtqjKUFI6yAKTm/BUpv6kE1BctS+4Hot5nxgUwqaaah\n pjH7KZoSLGuqQytHbyDpiXV2OwMT3UMPPwJLtIGTaefNaCcRVFystol7jchDq/A4HLKS\n eE5vmRc/CaL34VWTlAUa51mmyEFD6quYjE89q/MjVrJpV8Q+wRy56pyieQ59w11spL5w\n CKqYfv9KLT9mhp/yBAFsR9HYph3SIQxWI1doMHbFTd1O9lnLQTaSEYZni4A3XDRIzxVc\n WWVbwVaHIMtu2021FkolhhruJskxugWtuJ3BQvRWrIKN/SQZZz8hWPgl3OWsO5u3bNvl\n yzlQ==", "X-Gm-Message-State": "AOJu0YzVIYHXvcEIKnVnbQf/5GQ0Vk2k3cqNbxGOs5wjXhCWLWSCR5q/\n 01eOizy5Z8xo5wmzIVycJD4k1s1iMu6kJm+7w1YvzYVr8/2RNWLv3kB2FTT3DJxgUDJQh6n7Yjr\n ahPQ=", "X-Google-Smtp-Source": "\n AGHT+IFTK9AbTv4B64ml4SG55rBIhTS+7ZO62H7iKLqww9dEWFZ3FUJA7rITyJKz9XCrjM7GdVkZkQ==", "X-Received": "by 2002:a17:903:646:b0:1d7:836d:7b3f with SMTP id\n kh6-20020a170903064600b001d7836d7b3fmr489029plb.9.1707156239649;\n Mon, 05 Feb 2024 10:03:59 -0800 (PST)", "X-Forwarded-Encrypted": "i=0;\n AJvYcCXv4f1QS8EXimI/0QX6jfEnxf5oCAO12i6Rzuo5q9IPu5IVWc8sqC7Jg4Z9xqVcJ84GAj3YWe2CI4X3SNqpO3aWqyBJWpUdtdIxz7YssUFCS5z4xfR8jVietUib8moWZICcKeJnbkrMaBmPees0t6Y1CiMIb5/wojDueT4vX1ZNWbWMghK3b0GaGdBY33V5AxEz9t9pWcguxaWG05vs3knI4pID9SWqpHfER5/rujxV9i9S6FubqrwQNbYBolAad9AEYOZ6Tx4fFBwvzQH5BRmnlcg+m4iCDzo4ERZ1cYMVz6kS+4KSXpQjARFRexfwCuei1MGG6uz9AjCv3NdOzA1/rvUn8AuclC2EoqNDvOfpTg1Iyr4RwKUkOA06UobCKLnwgjMoV5vlh5kKdBBCbeKtEpVD/r3izJ5XB07/ULwT83gv9DMGWgta43PPw+d+34yb20/GqAinNmj70mZiTRqb9oksyWMOT/Z/mL5OqGbDQ9+UxG+9A7BhhbApLwH7F2FX5TsBZ+XIT50=", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>, Liron Himi <lironh@marvell.com>,\n Chaoyong He <chaoyong.he@corigine.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>", "Subject": "[PATCH v9 23/23] drivers: remove use of term sanity check", "Date": "Mon, 5 Feb 2024 09:43:51 -0800", "Message-ID": "<20240205180328.131019-24-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240205180328.131019-1-stephen@networkplumber.org>", "References": "<0230331200824.195294-1-stephen@networkplumber.org>\n <20240205180328.131019-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace non-inclusive language with better comments.\nCovers multiple drivers\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +-\n drivers/common/cnxk/roc_npa.c | 2 +-\n drivers/common/dpaax/caamflib/desc.h | 2 +-\n drivers/common/sfc_efx/base/ef10_nvram.c | 4 ++--\n drivers/common/sfc_efx/base/efx_rx.c | 2 +-\n drivers/dma/idxd/idxd_pci.c | 2 +-\n drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-\n drivers/net/mvpp2/mrvl_qos.c | 2 +-\n drivers/net/nfp/nfp_flow.c | 2 +-\n drivers/net/qede/qede_rxtx.c | 6 +++---\n 10 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\nindex caaae417773c..2b6162d0ceaf 100644\n--- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n+++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n@@ -9,7 +9,7 @@\n #include <compat.h>\n #include <fsl_qbman_base.h>\n \n-/* Sanity check */\n+/* Byte order check */\n #if (__BYTE_ORDER__ != __ORDER_BIG_ENDIAN__) && \\\n \t(__BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__)\n #error \"Unknown endianness!\"\ndiff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c\nindex 5e38ecf0414e..bd8ab1b39584 100644\n--- a/drivers/common/cnxk/roc_npa.c\n+++ b/drivers/common/cnxk/roc_npa.c\n@@ -622,7 +622,7 @@ npa_aura_alloc(struct npa_lf *lf, const uint32_t block_count, int pool_id,\n {\n \tint rc, aura_id;\n \n-\t/* Sanity check */\n+\t/* parameter check */\n \tif (!lf || !aura || !aura_handle)\n \t\treturn NPA_ERR_PARAM;\n \ndiff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/caamflib/desc.h\nindex 4a1285c4d488..37c87eebd5b4 100644\n--- a/drivers/common/dpaax/caamflib/desc.h\n+++ b/drivers/common/dpaax/caamflib/desc.h\n@@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era;\n \n /*\n * ONE - should always be set. Combination of ONE (always\n- * set) and ZRO (always clear) forms an endianness sanity check\n+ * set) and ZRO (always clear) forms an endianness check\n */\n #define HDR_ONE\t\t\tBIT(23)\n #define HDR_ZRO\t\t\tBIT(15)\ndiff --git a/drivers/common/sfc_efx/base/ef10_nvram.c b/drivers/common/sfc_efx/base/ef10_nvram.c\nindex ce8357fa94ce..fad9f0f507f3 100644\n--- a/drivers/common/sfc_efx/base/ef10_nvram.c\n+++ b/drivers/common/sfc_efx/base/ef10_nvram.c\n@@ -595,13 +595,13 @@ tlv_update_partition_len_and_cks(\n \n \t/*\n \t * We just modified the partition, so the total length may not be\n-\t * valid. Don't use tlv_find(), which performs some sanity checks\n+\t * valid. Don't use tlv_find(), which performs some checks\n \t * that may fail here.\n \t */\n \tpartition.data = cursor->block;\n \tmemcpy(&partition.tlv_cursor, cursor, sizeof (*cursor));\n \theader = (struct tlv_partition_header *)partition.data;\n-\t/* Sanity check. */\n+\t/* Header check */\n \tif (__LE_TO_CPU_32(header->tag) != TLV_TAG_PARTITION_HEADER) {\n \t\trc = EFAULT;\n \t\tgoto fail1;\ndiff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c\nindex dce9ada55d28..28676c5a5b99 100644\n--- a/drivers/common/sfc_efx/base/efx_rx.c\n+++ b/drivers/common/sfc_efx/base/efx_rx.c\n@@ -930,7 +930,7 @@ efx_rx_qcreate_internal(\n \t ndescs, id, flags, eep, erp)) != 0)\n \t\tgoto fail4;\n \n-\t/* Sanity check queue creation result */\n+\t/* Check queue creation result */\n \tif (flags & EFX_RXQ_FLAG_RSS_HASH) {\n \t\tconst efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout;\n \t\tconst efx_rx_prefix_field_info_t *rss_hash_field;\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex a78889a7efa0..ba36a96f085d 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -204,7 +204,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,\n \t\tgoto err;\n \t}\n \n-\t/* sanity check device status */\n+\t/* check device status */\n \tif (pci->regs->gensts & GENSTS_DEV_STATE_MASK) {\n \t\t/* need function-level-reset (FLR) or is enabled */\n \t\tIDXD_PMD_ERR(\"Device status is not disabled, cannot init\");\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 79f1b3f1a0f2..57a67bd029ed 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -1476,7 +1476,7 @@ bond_8023ad_setup_validate(uint16_t port_id,\n \t\treturn -EINVAL;\n \n \tif (conf != NULL) {\n-\t\t/* Basic sanity check */\n+\t\t/* Basic input check */\n \t\tif (conf->slow_periodic_ms == 0 ||\n \t\t\t\tconf->fast_periodic_ms >= conf->slow_periodic_ms ||\n \t\t\t\tconf->long_timeout_ms == 0 ||\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex f43217bc589c..db5052a9ab6f 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab,\n \t\t\tif (nb_rng_tokens != 2)\n \t\t\t\treturn -3;\n \n-\t\t\t/* Range and sanity checks. */\n+\t\t\t/* Range and input checks. */\n \t\t\tif (get_val_securely(rng_tokens[0], &token_val) < 0)\n \t\t\t\treturn -4;\n \t\t\tbeg = (char)token_val;\ndiff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c\nindex f832b52d8996..c867697e05c9 100644\n--- a/drivers/net/nfp/nfp_flow.c\n+++ b/drivers/net/nfp/nfp_flow.c\n@@ -2071,7 +2071,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr,\n \t\t\tbreak;\n \t\t}\n \n-\t\t/* Perform basic sanity checks */\n+\t\t/* Perform basic checks */\n \t\tret = nfp_flow_item_check(item, proc);\n \t\tif (ret != 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"nfp flow item %d check failed\", item->type);\ndiff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c\nindex c35585f5fdd6..8b89841e03b1 100644\n--- a/drivers/net/qede/qede_rxtx.c\n+++ b/drivers/net/qede/qede_rxtx.c\n@@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev,\n \t\t\t\t\t cqe->len_list[0]);\n \t/* Update total length and frags based on end TPA */\n \trx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head;\n-\t/* TODO: Add Sanity Checks */\n+\t/* TODO: Add more checks */\n \trx_mb->nb_segs = cqe->num_of_bds;\n \trx_mb->pkt_len = cqe->total_packet_len;\n \n@@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,\n \n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n static inline void\n-qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf,\n+qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf,\n \t\t\t struct qede_tx_queue *txq)\n {\n \tif (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff)\n@@ -2473,7 +2473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_MPLSINUDP) {\n \t\t\t\tmplsoudp_flg = true;\n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n-\t\t\t\tqede_mpls_tunn_tx_sanity_check(mbuf, txq);\n+\t\t\t\tqede_mpls_tunn_tx_basic_check(mbuf, txq);\n #endif\n \t\t\t\t/* Outer L4 offset in two byte words */\n \t\t\t\ttunn_l4_hdr_start_offset =\n", "prefixes": [ "v9", "23/23" ] }