From patchwork Mon Feb 5 17:43:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136410 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E776743A3D; Mon, 5 Feb 2024 19:06:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B878142DC9; Mon, 5 Feb 2024 19:04:06 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id A594A427E8 for ; Mon, 5 Feb 2024 19:04:00 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d93b525959so37921905ad.0 for ; Mon, 05 Feb 2024 10:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707156240; x=1707761040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BTxIIJtDDAub74TaBkECgdiDvPJkkLOw8MTt5rTvcgk=; b=q+lTtgvzlG5SBCEE+by/1uSF3Zegvs9MAB7uhK3wEDVQa8JuIgWTCfVy5eYxiSYE9N O6/Qth95Gfx0iVK5N2jEVp2vpEFgpFBA6NUNzwJpskkCfSTs0M4ihMHPjrDflbObwHqA RoypxpqpJ13LdtzSIVmtgypzWmIdxarozn1Hz1RI9lLd/Bx2ecLpypv7RCfVuK79VzAM HLhFq884vq+0DBlm4Jys1lhp8NYrxe/9LQ3Xfnm3ZNG0FairSum8IGBnoqMyM3Vj/K2S RscjenJUTInTbW74LogHKC24YiP3ISwo+WEu/2bzDa+iwL4c+bFSreL26LsO1OQFSHwy dfzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707156240; x=1707761040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BTxIIJtDDAub74TaBkECgdiDvPJkkLOw8MTt5rTvcgk=; b=QYqoGIjBGWfVegbBKIPSXZvvtqjKUFI6yAKTm/BUpv6kE1BctS+4Hot5nxgUwqaaah pjH7KZoSLGuqQytHbyDpiXV2OwMT3UMPPwJLtIGTaefNaCcRVFystol7jchDq/A4HLKS eE5vmRc/CaL34VWTlAUa51mmyEFD6quYjE89q/MjVrJpV8Q+wRy56pyieQ59w11spL5w CKqYfv9KLT9mhp/yBAFsR9HYph3SIQxWI1doMHbFTd1O9lnLQTaSEYZni4A3XDRIzxVc WWVbwVaHIMtu2021FkolhhruJskxugWtuJ3BQvRWrIKN/SQZZz8hWPgl3OWsO5u3bNvl yzlQ== X-Gm-Message-State: AOJu0YzVIYHXvcEIKnVnbQf/5GQ0Vk2k3cqNbxGOs5wjXhCWLWSCR5q/ 01eOizy5Z8xo5wmzIVycJD4k1s1iMu6kJm+7w1YvzYVr8/2RNWLv3kB2FTT3DJxgUDJQh6n7Yjr ahPQ= X-Google-Smtp-Source: AGHT+IFTK9AbTv4B64ml4SG55rBIhTS+7ZO62H7iKLqww9dEWFZ3FUJA7rITyJKz9XCrjM7GdVkZkQ== X-Received: by 2002:a17:903:646:b0:1d7:836d:7b3f with SMTP id kh6-20020a170903064600b001d7836d7b3fmr489029plb.9.1707156239649; Mon, 05 Feb 2024 10:03:59 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXv4f1QS8EXimI/0QX6jfEnxf5oCAO12i6Rzuo5q9IPu5IVWc8sqC7Jg4Z9xqVcJ84GAj3YWe2CI4X3SNqpO3aWqyBJWpUdtdIxz7YssUFCS5z4xfR8jVietUib8moWZICcKeJnbkrMaBmPees0t6Y1CiMIb5/wojDueT4vX1ZNWbWMghK3b0GaGdBY33V5AxEz9t9pWcguxaWG05vs3knI4pID9SWqpHfER5/rujxV9i9S6FubqrwQNbYBolAad9AEYOZ6Tx4fFBwvzQH5BRmnlcg+m4iCDzo4ERZ1cYMVz6kS+4KSXpQjARFRexfwCuei1MGG6uz9AjCv3NdOzA1/rvUn8AuclC2EoqNDvOfpTg1Iyr4RwKUkOA06UobCKLnwgjMoV5vlh5kKdBBCbeKtEpVD/r3izJ5XB07/ULwT83gv9DMGWgta43PPw+d+34yb20/GqAinNmj70mZiTRqb9oksyWMOT/Z/mL5OqGbDQ9+UxG+9A7BhhbApLwH7F2FX5TsBZ+XIT50= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x8-20020a170902b40800b001d9b0a15bbfsm144867plr.262.2024.02.05.10.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:03:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Andrew Rybchenko , Bruce Richardson , Kevin Laatz , Chas Williams , "Min Hu (Connor)" , Liron Himi , Chaoyong He , Devendra Singh Rawat , Alok Prasad Subject: [PATCH v9 23/23] drivers: remove use of term sanity check Date: Mon, 5 Feb 2024 09:43:51 -0800 Message-ID: <20240205180328.131019-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240205180328.131019-1-stephen@networkplumber.org> References: <0230331200824.195294-1-stephen@networkplumber.org> <20240205180328.131019-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace non-inclusive language with better comments. Covers multiple drivers Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/cnxk/roc_npa.c | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/common/sfc_efx/base/ef10_nvram.c | 4 ++-- drivers/common/sfc_efx/base/efx_rx.c | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- drivers/net/mvpp2/mrvl_qos.c | 2 +- drivers/net/nfp/nfp_flow.c | 2 +- drivers/net/qede/qede_rxtx.c | 6 +++--- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h index caaae417773c..2b6162d0ceaf 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h +++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h @@ -9,7 +9,7 @@ #include #include -/* Sanity check */ +/* Byte order check */ #if (__BYTE_ORDER__ != __ORDER_BIG_ENDIAN__) && \ (__BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__) #error "Unknown endianness!" diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 5e38ecf0414e..bd8ab1b39584 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -622,7 +622,7 @@ npa_aura_alloc(struct npa_lf *lf, const uint32_t block_count, int pool_id, { int rc, aura_id; - /* Sanity check */ + /* parameter check */ if (!lf || !aura || !aura_handle) return NPA_ERR_PARAM; diff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/caamflib/desc.h index 4a1285c4d488..37c87eebd5b4 100644 --- a/drivers/common/dpaax/caamflib/desc.h +++ b/drivers/common/dpaax/caamflib/desc.h @@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era; /* * ONE - should always be set. Combination of ONE (always - * set) and ZRO (always clear) forms an endianness sanity check + * set) and ZRO (always clear) forms an endianness check */ #define HDR_ONE BIT(23) #define HDR_ZRO BIT(15) diff --git a/drivers/common/sfc_efx/base/ef10_nvram.c b/drivers/common/sfc_efx/base/ef10_nvram.c index ce8357fa94ce..fad9f0f507f3 100644 --- a/drivers/common/sfc_efx/base/ef10_nvram.c +++ b/drivers/common/sfc_efx/base/ef10_nvram.c @@ -595,13 +595,13 @@ tlv_update_partition_len_and_cks( /* * We just modified the partition, so the total length may not be - * valid. Don't use tlv_find(), which performs some sanity checks + * valid. Don't use tlv_find(), which performs some checks * that may fail here. */ partition.data = cursor->block; memcpy(&partition.tlv_cursor, cursor, sizeof (*cursor)); header = (struct tlv_partition_header *)partition.data; - /* Sanity check. */ + /* Header check */ if (__LE_TO_CPU_32(header->tag) != TLV_TAG_PARTITION_HEADER) { rc = EFAULT; goto fail1; diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c index dce9ada55d28..28676c5a5b99 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -930,7 +930,7 @@ efx_rx_qcreate_internal( ndescs, id, flags, eep, erp)) != 0) goto fail4; - /* Sanity check queue creation result */ + /* Check queue creation result */ if (flags & EFX_RXQ_FLAG_RSS_HASH) { const efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout; const efx_rx_prefix_field_info_t *rss_hash_field; diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index a78889a7efa0..ba36a96f085d 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -204,7 +204,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, goto err; } - /* sanity check device status */ + /* check device status */ if (pci->regs->gensts & GENSTS_DEV_STATE_MASK) { /* need function-level-reset (FLR) or is enabled */ IDXD_PMD_ERR("Device status is not disabled, cannot init"); diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 79f1b3f1a0f2..57a67bd029ed 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1476,7 +1476,7 @@ bond_8023ad_setup_validate(uint16_t port_id, return -EINVAL; if (conf != NULL) { - /* Basic sanity check */ + /* Basic input check */ if (conf->slow_periodic_ms == 0 || conf->fast_periodic_ms >= conf->slow_periodic_ms || conf->long_timeout_ms == 0 || diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index f43217bc589c..db5052a9ab6f 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab, if (nb_rng_tokens != 2) return -3; - /* Range and sanity checks. */ + /* Range and input checks. */ if (get_val_securely(rng_tokens[0], &token_val) < 0) return -4; beg = (char)token_val; diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index f832b52d8996..c867697e05c9 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2071,7 +2071,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr, break; } - /* Perform basic sanity checks */ + /* Perform basic checks */ ret = nfp_flow_item_check(item, proc); if (ret != 0) { PMD_DRV_LOG(ERR, "nfp flow item %d check failed", item->type); diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index c35585f5fdd6..8b89841e03b1 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev, cqe->len_list[0]); /* Update total length and frags based on end TPA */ rx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head; - /* TODO: Add Sanity Checks */ + /* TODO: Add more checks */ rx_mb->nb_segs = cqe->num_of_bds; rx_mb->pkt_len = cqe->total_packet_len; @@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts, #ifdef RTE_LIBRTE_QEDE_DEBUG_TX static inline void -qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf, +qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf, struct qede_tx_queue *txq) { if (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff) @@ -2473,7 +2473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) RTE_MBUF_F_TX_TUNNEL_MPLSINUDP) { mplsoudp_flg = true; #ifdef RTE_LIBRTE_QEDE_DEBUG_TX - qede_mpls_tunn_tx_sanity_check(mbuf, txq); + qede_mpls_tunn_tx_basic_check(mbuf, txq); #endif /* Outer L4 offset in two byte words */ tunn_l4_hdr_start_offset =