Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136364/?format=api
{ "id": 136364, "url": "http://patches.dpdk.org/api/patches/136364/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240203041230.285599-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240203041230.285599-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240203041230.285599-10-stephen@networkplumber.org", "date": "2024-02-03T04:11:42", "name": "[v7,09/19] raw/cnxk: replace PMD logtype with dynamic type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ef8d1862fc91f0d295305118831c160c6a0752b3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240203041230.285599-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 30996, "url": "http://patches.dpdk.org/api/series/30996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30996", "date": "2024-02-03T04:11:33", "name": "Replace uses of RTE_LOGTYPE_PMD", "version": 7, "mbox": "http://patches.dpdk.org/series/30996/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136364/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136364/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D5D0443A57;\n\tSat, 3 Feb 2024 05:13:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DF8842EA5;\n\tSat, 3 Feb 2024 05:13:35 +0100 (CET)", "from mail-pl1-f176.google.com (mail-pl1-f176.google.com\n [209.85.214.176])\n by mails.dpdk.org (Postfix) with ESMTP id 11EE442E92\n for <dev@dpdk.org>; Sat, 3 Feb 2024 05:13:31 +0100 (CET)", "by mail-pl1-f176.google.com with SMTP id\n d9443c01a7336-1d731314e67so20407635ad.1\n for <dev@dpdk.org>; Fri, 02 Feb 2024 20:13:31 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 02 Feb 2024 20:13:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933610;\n x=1707538410; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3PUGQibq4Z04OHz5a5w2IsgLwCxy9TOKdOEbRTjZwLg=;\n b=xPCriKqSSVpyjXB+sk2oRBxul3wm41q8wkwIv98d8GKE1VKkoUX17EArMK1rYY8dJw\n YzhEw0abGS4dnH3Z52TNeFfyAnrEtXi0Cshbt0D+Acrf/zp5EeMPGrAuom9i2oKhpoza\n yildITQnmpZRPsfUJYLedZHTgQatQ5/33fRsi54he/QyURq10Y2ES/URtDFED1C7VM7W\n RUkNeYHb5+ELqTlDtbw745dELlb7VZUMOozz45++XbPvZCtk9YYGqxC0xu+tKKP39RtH\n G+J4aV4O4oykewLFkmRG1ZbjKctqQUr9XXWzqNOk1QraRh/sSZ6ACYAMSv6hMAUteu2t\n AX/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1706933610; x=1707538410;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3PUGQibq4Z04OHz5a5w2IsgLwCxy9TOKdOEbRTjZwLg=;\n b=ZBhdF4JCcse4FWC7UTHQ8tq8VADNUN8YN1K0f7Y4JsknwsvI+7/5A+OQxUPHYmx5xw\n qHri7yJ7PziNGakBixllXtW+/ytnmyHLD7172oWLBr7/69vueHpiMcAv7ykO14UN1zpp\n zNp7NU+KjcEEcpxfPg9tF4AZ0EhX5M1UOScGLGaUnXBmpB2v2IIb6tOqYD6lew4K9MPe\n uRutJTQcS1yTYiojY5G0PPYy16mNJSJrkRMLKt+jg/2YYW9dllBZzaszfgAzHs65nZVk\n Tc2D7JJfH+UiC2rCv4OBBV+rMs8wq+PFXXQ9UOLFvVlpuiUmv9OSbRNHdVsUlg4eqaXL\n BQQg==", "X-Gm-Message-State": "AOJu0YxE9km3fZbg1hJzHBhJ1xYOMlBZFO1Bws2F/0N4RwXBXvgk6/ac\n /cqmzCzvGZf2sEaSgsQ/ui1zgcu9TS1VWXN+4wzENTE7j6iRDksHRtWRurW8y40MGZRSo0wsJrW\n aJ1s=", "X-Google-Smtp-Source": "\n AGHT+IHBP6RYlswJzrJpgUKH99cJG9ZqJAq0fM15gvO4cZZxn0aQz2LLf0+jJoA4jPqMz6g3iquRyg==", "X-Received": "by 2002:a17:902:d489:b0:1d9:6cc7:d40b with SMTP id\n c9-20020a170902d48900b001d96cc7d40bmr4592409plg.25.1706933610240;\n Fri, 02 Feb 2024 20:13:30 -0800 (PST)", "X-Forwarded-Encrypted": "i=0;\n AJvYcCVkBpWFP/OGTnvmRHKBk8jDbuB9Wj4LiPt1k5kDuNPeeAVzO6mUJvBYp4SY4Ihq1mSwSMqjkiGU4os4sCZG0mqVOQoQxxrZpyT4HLN2fhHFTeM6IMavmlsUB6z3jvwacJiIqy8JtERlbw3fr16XjXn2bFB9JZ/UK0YaVK83cwBVEKDekWAYjMCtw34+TPZcMdAH3KESLW6aCN7X34UErLikEQFho2OC4IpIW0CyanlX60BT45kZFlsTTQ==", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Jakub Palider <jpalider@marvell.com>,\n Tomasz Duszynski <tduszynski@marvell.com>", "Subject": "[PATCH v7 09/19] raw/cnxk: replace PMD logtype with dynamic type", "Date": "Fri, 2 Feb 2024 20:11:42 -0800", "Message-ID": "<20240203041230.285599-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240203041230.285599-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20240203041230.285599-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Driver should not be using PMD logtype, they should have their\nown logtype.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/cnxk/roc_platform.h | 16 ++++++-----\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++-\n drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +-\n drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +++++++++++-----------\n drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 6 +++++\n drivers/raw/cnxk_gpio/cnxk_gpio.c | 21 ++++++++-------\n drivers/raw/cnxk_gpio/cnxk_gpio.h | 5 ++++\n drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 17 ++++++------\n 8 files changed, 57 insertions(+), 44 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h\nindex ba23b2e0d79e..9d2ea8f00965 100644\n--- a/drivers/common/cnxk/roc_platform.h\n+++ b/drivers/common/cnxk/roc_platform.h\n@@ -265,11 +265,13 @@ extern int cnxk_logtype_tm;\n extern int cnxk_logtype_ree;\n extern int cnxk_logtype_dpi;\n \n+#define RTE_LOGTYPE_CNXK cnxk_logtype_base\n+\n #define plt_err(fmt, args...) \\\n-\tRTE_LOG(ERR, PMD, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n-#define plt_info(fmt, args...) RTE_LOG(INFO, PMD, fmt \"\\n\", ##args)\n-#define plt_warn(fmt, args...) RTE_LOG(WARNING, PMD, fmt \"\\n\", ##args)\n-#define plt_print(fmt, args...) RTE_LOG(INFO, PMD, fmt \"\\n\", ##args)\n+\tRTE_LOG(ERR, CNXK, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n+#define plt_info(fmt, args...) RTE_LOG(INFO, CNXK, fmt \"\\n\", ##args)\n+#define plt_warn(fmt, args...) RTE_LOG(WARNING, CNXK, fmt \"\\n\", ##args)\n+#define plt_print(fmt, args...) RTE_LOG(INFO, CNXK, fmt \"\\n\", ##args)\n #define plt_dump(fmt, ...) fprintf(stderr, fmt \"\\n\", ##__VA_ARGS__)\n #define plt_dump_no_nl(fmt, ...) fprintf(stderr, fmt, ##__VA_ARGS__)\n \n@@ -296,11 +298,11 @@ extern int cnxk_logtype_dpi;\n \n /* Datapath logs */\n #define plt_dp_err(fmt, args...) \\\n-\tRTE_LOG_DP(ERR, PMD, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n+\tRTE_LOG_DP(ERR, CNXK, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n #define plt_dp_info(fmt, args...) \\\n-\tRTE_LOG_DP(INFO, PMD, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n+\tRTE_LOG_DP(INFO, CNXK, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n #define plt_dp_dbg(fmt, args...) \\\n-\tRTE_LOG_DP(DEBUG, PMD, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n+\tRTE_LOG_DP(DEBUG, CNXK, \"%s():%u \" fmt \"\\n\", __func__, __LINE__, ##args)\n \n #ifdef __cplusplus\n #define CNXK_PCI_ID(subsystem_dev, dev) \\\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex 15dbc4c1a637..1dbab6fb3e12 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -251,7 +251,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,\n \n \t/* get rid of last response if any */\n \tif (qp->rsp) {\n-\t\tRTE_LOG(WARNING, PMD, \"Previous response got overwritten\\n\");\n+\t\tCNXK_BPHY_LOG(WARNING, \"Previous response got overwritten\");\n \t\trte_free(qp->rsp);\n \t}\n \tqp->rsp = rsp;\n@@ -410,3 +410,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = {\n RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map);\n RTE_PMD_REGISTER_KMOD_DEP(bphy_rawdev_pci_driver, \"vfio-pci\");\n+RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_bphy, bphy, INFO);\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\nindex 2d8466ef918b..4358aeecc3e5 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\n@@ -189,7 +189,7 @@ cnxk_bphy_cgx_process_buf(struct cnxk_bphy_cgx *cgx, unsigned int queue,\n \n \t/* get rid of last response if any */\n \tif (qp->rsp) {\n-\t\tRTE_LOG(WARNING, PMD, \"Previous response got overwritten\\n\");\n+\t\tCNXK_BPHY_LOG(WARNING, \"Previous response got overwritten\");\n \t\trte_free(qp->rsp);\n \t}\n \tqp->rsp = rsp;\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\nindex a3021b4bb7db..f01d958661ad 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\n@@ -57,62 +57,61 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)\n \t\tif (ret)\n \t\t\tbreak;\n \t\tif (descs != 1) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Wrong number of descs reported\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Wrong number of descs reported\");\n \t\t\tret = -ENODEV;\n \t\t\tbreak;\n \t\t}\n \n-\t\tRTE_LOG(INFO, PMD, \"Testing queue %d\\n\", i);\n+\t\tCNXK_BPHY_LOG(INFO, \"Testing queue %d\", i);\n \n \t\tret = rte_pmd_bphy_cgx_stop_rxtx(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to stop rx/tx\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to stop rx/tx\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_start_rxtx(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to start rx/tx\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to start rx/tx\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, false);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set link down\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to set link down\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = cnxk_bphy_cgx_link_cond(dev_id, i, 0);\n \t\tif (ret != 0)\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Timed out waiting for a link down\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Timed out waiting for a link down\");\n \n \t\tret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, true);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set link up\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to set link up\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = cnxk_bphy_cgx_link_cond(dev_id, i, 1);\n \t\tif (ret != 1)\n-\t\t\tRTE_LOG(ERR, PMD, \"Timed out waiting for a link up\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Timed out waiting for a link up\");\n \n \t\tret = rte_pmd_bphy_cgx_intlbk_enable(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to enable internal lbk\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to enable internal lbk\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_intlbk_disable(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable internal lbk\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to disable internal lbk\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_ptp_rx_enable(dev_id, i);\n \t\t/* ptp not available on RPM */\n \t\tif (ret < 0 && ret != -ENOTSUP) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to enable ptp\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to enable ptp\");\n \t\t\tbreak;\n \t\t}\n \t\tret = 0;\n@@ -120,27 +119,27 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)\n \t\tret = rte_pmd_bphy_cgx_ptp_rx_disable(dev_id, i);\n \t\t/* ptp not available on RPM */\n \t\tif (ret < 0 && ret != -ENOTSUP) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable ptp\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to disable ptp\");\n \t\t\tbreak;\n \t\t}\n \t\tret = 0;\n \n \t\tret = rte_pmd_bphy_cgx_get_supported_fec(dev_id, i, &fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to get supported FEC\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to get supported FEC\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set FEC to %d\\n\", fec);\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to set FEC to %d\", fec);\n \t\t\tbreak;\n \t\t}\n \n \t\tfec = CNXK_BPHY_CGX_ETH_LINK_FEC_NONE;\n \t\tret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable FEC\\n\");\n+\t\t\tCNXK_BPHY_LOG(ERR, \"Failed to disable FEC\");\n \t\t\tbreak;\n \t\t}\n \t}\ndiff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\nindex 9d8d0285581b..7a7d9f6fa66f 100644\n--- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n+++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n@@ -26,6 +26,12 @@\n extern \"C\" {\n #endif\n \n+extern int cnxk_logtype_bphy;\n+\n+#define CNXK_BPHY_LOG(level, fmt, args...)\t\\\n+\trte_log(RTE_LOG_ ## level, cnxk_logtype_bphy, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n+\n /** Available message types */\n enum cnxk_bphy_cgx_msg_type {\n \t/** Type used to obtain link information */\ndiff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c\nindex 3c4d79e4810e..329ac28a2736 100644\n--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c\n+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c\n@@ -215,13 +215,13 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist)\n \t\terrno = 0;\n \t\tval = strtol(token, NULL, 10);\n \t\tif (errno) {\n-\t\t\tRTE_LOG(ERR, PMD, \"failed to parse %s\\n\", token);\n+\t\t\tCNXK_GPIO_LOG(ERR, \"failed to parse %s\", token);\n \t\t\tret = -errno;\n \t\t\tgoto out;\n \t\t}\n \n \t\tif (val < 0 || val >= gpiochip->num_gpios) {\n-\t\t\tRTE_LOG(ERR, PMD, \"gpio%d out of 0-%d range\\n\", val,\n+\t\t\tCNXK_GPIO_LOG(ERR, \"gpio%d out of 0-%d range\", val,\n \t\t\t\tgpiochip->num_gpios - 1);\n \t\t\tret = -EINVAL;\n \t\t\tgoto out;\n@@ -231,7 +231,7 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist)\n \t\t\tif (list[i] != val)\n \t\t\t\tcontinue;\n \n-\t\t\tRTE_LOG(WARNING, PMD, \"gpio%d already allowed\\n\", val);\n+\t\t\tCNXK_GPIO_LOG(WARNING, \"gpio%d already allowed\", val);\n \t\t\tbreak;\n \t\t}\n \t\tif (i == queue)\n@@ -398,7 +398,7 @@ cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id,\n \t\t\treturn ret;\n \t\t}\n \t} else {\n-\t\tRTE_LOG(WARNING, PMD, \"using existing gpio%d\\n\", gpio->num);\n+\t\tCNXK_GPIO_LOG(WARNING, \"using existing gpio%d\", gpio->num);\n \t}\n \n \tgpiochip->gpios[num] = gpio;\n@@ -647,7 +647,7 @@ cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct rte_rawdev_buf *rbuf)\n \n \t/* get rid of last response if any */\n \tif (gpio->rsp) {\n-\t\tRTE_LOG(WARNING, PMD, \"previous response got overwritten\\n\");\n+\t\tCNXK_GPIO_LOG(WARNING, \"previous response got overwritten\");\n \t\trte_free(gpio->rsp);\n \t}\n \tgpio->rsp = rsp;\n@@ -741,7 +741,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)\n \tcnxk_gpio_format_name(name, sizeof(name));\n \trawdev = rte_rawdev_pmd_allocate(name, sizeof(*gpiochip), rte_socket_id());\n \tif (!rawdev) {\n-\t\tRTE_LOG(ERR, PMD, \"failed to allocate %s rawdev\\n\", name);\n+\t\tCNXK_GPIO_LOG(ERR, \"failed to allocate %s rawdev\", name);\n \t\treturn -ENOMEM;\n \t}\n \n@@ -770,7 +770,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)\n \tsnprintf(buf, sizeof(buf), \"%s/gpiochip%d/base\", CNXK_GPIO_CLASS_PATH, gpiochip->num);\n \tret = cnxk_gpio_read_attr_int(buf, &gpiochip->base);\n \tif (ret) {\n-\t\tRTE_LOG(ERR, PMD, \"failed to read %s\\n\", buf);\n+\t\tCNXK_GPIO_LOG(ERR, \"failed to read %s\", buf);\n \t\tgoto out;\n \t}\n \n@@ -778,20 +778,20 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)\n \tsnprintf(buf, sizeof(buf), \"%s/gpiochip%d/ngpio\", CNXK_GPIO_CLASS_PATH, gpiochip->num);\n \tret = cnxk_gpio_read_attr_int(buf, &gpiochip->num_gpios);\n \tif (ret) {\n-\t\tRTE_LOG(ERR, PMD, \"failed to read %s\\n\", buf);\n+\t\tCNXK_GPIO_LOG(ERR, \"failed to read %s\", buf);\n \t\tgoto out;\n \t}\n \tgpiochip->num_queues = gpiochip->num_gpios;\n \n \tret = cnxk_gpio_parse_allowlist(gpiochip, params->allowlist);\n \tif (ret) {\n-\t\tRTE_LOG(ERR, PMD, \"failed to parse allowed gpios\\n\");\n+\t\tCNXK_GPIO_LOG(ERR, \"failed to parse allowed gpios\");\n \t\tgoto out;\n \t}\n \n \tgpiochip->gpios = rte_calloc(NULL, gpiochip->num_gpios, sizeof(struct cnxk_gpio *), 0);\n \tif (!gpiochip->gpios) {\n-\t\tRTE_LOG(ERR, PMD, \"failed to allocate gpios memory\\n\");\n+\t\tCNXK_GPIO_LOG(ERR, \"failed to allocate gpios memory\");\n \t\tret = -ENOMEM;\n \t\tgoto out;\n \t}\n@@ -851,3 +851,4 @@ RTE_PMD_REGISTER_VDEV(cnxk_gpio, cnxk_gpio_drv);\n RTE_PMD_REGISTER_PARAM_STRING(cnxk_gpio,\n \t\t\"gpiochip=<int> \"\n \t\t\"allowlist=<list>\");\n+RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_gpio, gpio, INFO);\ndiff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h b/drivers/raw/cnxk_gpio/cnxk_gpio.h\nindex e62f78a7604a..336d7ac373d7 100644\n--- a/drivers/raw/cnxk_gpio/cnxk_gpio.h\n+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h\n@@ -5,6 +5,11 @@\n #ifndef _CNXK_GPIO_H_\n #define _CNXK_GPIO_H_\n \n+extern int cnxk_logtype_gpio;\n+\n+#define CNXK_GPIO_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, cnxk_logtype_gpio, fmt \"\\n\", ## args)\n+\n struct cnxk_gpiochip;\n \n struct cnxk_gpio {\ndiff --git a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c\nindex 10742b5dc48a..2f3973a7b5e6 100644\n--- a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c\n+++ b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c\n@@ -56,7 +56,7 @@ cnxk_gpio_read_attr(char *attr, char *val)\n \n #define CNXK_GPIO_ERR_STR(err, str, ...) do { \\\n \tif (err) { \\\n-\t\tRTE_LOG(ERR, PMD, \"%s:%d: \" str \" (%d)\\n\", __func__, __LINE__, \\\n+\t\tCNXK_GPIO_LOG(ERR, \"%s:%d: \" str \" (%d)\", __func__, __LINE__, \\\n \t\t\t##__VA_ARGS__, err); \\\n \t\tgoto out; \\\n \t} \\\n@@ -330,30 +330,29 @@ cnxk_gpio_selftest(uint16_t dev_id)\n \tfor (i = 0; i < queues; i++) {\n \t\tret = rte_rawdev_queue_conf_get(dev_id, i, &conf, sizeof(conf));\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"failed to read queue configuration (%d)\\n\",\n+\t\t\tCNXK_GPIO_LOG(ERR, \"failed to read queue configuration (%d)\",\n \t\t\t\tret);\n \t\t\tgoto out;\n \t\t}\n \n-\t\tRTE_LOG(INFO, PMD, \"testing queue%d (gpio%d)\\n\", i, conf.gpio);\n+\t\tCNXK_GPIO_LOG(INFO, \"testing queue%d (gpio%d)\", i, conf.gpio);\n \n \t\tif (conf.size != 1) {\n-\t\t\tRTE_LOG(ERR, PMD, \"wrong queue size received\\n\");\n+\t\t\tCNXK_GPIO_LOG(ERR, \"wrong queue size received\");\n \t\t\tret = -EIO;\n \t\t\tgoto out;\n \t\t}\n \n \t\tret = rte_rawdev_queue_setup(dev_id, i, NULL, 0);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"failed to setup queue (%d)\\n\", ret);\n+\t\t\tCNXK_GPIO_LOG(ERR, \"failed to setup queue (%d)\", ret);\n \t\t\tgoto out;\n \t\t}\n \n \t\tgpio = gpiochip->gpios[conf.gpio];\n \t\tsnprintf(buf, sizeof(buf), CNXK_GPIO_PATH_FMT, gpio->num);\n \t\tif (!cnxk_gpio_attr_exists(buf)) {\n-\t\t\tRTE_LOG(ERR, PMD, \"%s does not exist\\n\", buf);\n+\t\t\tCNXK_GPIO_LOG(ERR, \"%s does not exist\", buf);\n \t\t\tret = -ENOENT;\n \t\t\tgoto release;\n \t\t}\n@@ -371,13 +370,13 @@ cnxk_gpio_selftest(uint16_t dev_id)\n \t\tret2 = ret;\n \t\tret = rte_rawdev_queue_release(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"failed to release queue (%d)\\n\",\n+\t\t\tCNXK_GPIO_LOG(ERR, \"failed to release queue (%d)\",\n \t\t\t\tret);\n \t\t\tbreak;\n \t\t}\n \n \t\tif (cnxk_gpio_attr_exists(buf)) {\n-\t\t\tRTE_LOG(ERR, PMD, \"%s still exists\\n\", buf);\n+\t\t\tCNXK_GPIO_LOG(ERR, \"%s still exists\", buf);\n \t\t\tret = -EIO;\n \t\t\tbreak;\n \t\t}\n", "prefixes": [ "v7", "09/19" ] }