From patchwork Sat Feb 3 04:11:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136356 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 835CF43A57; Sat, 3 Feb 2024 05:12:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCD1642E3B; Sat, 3 Feb 2024 05:12:46 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 6F15E4028C for ; Sat, 3 Feb 2024 05:12:44 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-295d22bd625so2058288a91.1 for ; Fri, 02 Feb 2024 20:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933563; x=1707538363; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=3HOib+8tzdCrRytFnpv0KFU/PRM7P44Xkb3Uj5kG2sjP9JYiCI/fZZU/WRRfc9cKmt RE3p/FIden9bG8vCCskNrk3vNaRALiWdRMeNb+nOa8Mm3Gqsw65emupvL8HSZ+a3ny6U avY4lYsQ/Ec8kjhhwCQp2lH68Md7wLTN27F7/5mIHqw4vImzwYWmjuiHDUuqxsHxD/OF uH1T2R4X5pu4OcybtdKJ3pX0KnE/10GNnb8hi8psSTWg/CiqdYcA6TBPBz11etOXpYGq zm/aWDKX9q3gMvuKAH1zGRPV94/QqO+vicyY64vkGkT2/eRy5U2njyvKE6hZqoyQxxyL q39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933563; x=1707538363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=; b=mh12FDW5ToYkwy1RkXdEHYlLWAVR0/hJovSA/qT1xZAOyHKS9nj9ANeQzPGvpFVnRL ikKTJV3t+vOPFFTKDAJ4xrX5OmhZPf0rH/r2UXd1J3BtSj4DgpJEMX/5uTjspn0DlhSG g6YhOBmVtndiIFyUtoPMHuHwDSKYnIcMS91+Fq8adXhLGJ1FSGqmOEnhRYuXibSHgvjm OOI1lFQtSTGVfFQcpEX4AQOXOdMm0XKI5x8OtpVP19SAagz7LFnmErLUWkWILPHNh6L+ dmZqGrcl8BlraN1km6lsLgvxxcOj/U2K/YHJvGm56r8U9biOkDehEMxglVqSKRyavzPx ByiA== X-Gm-Message-State: AOJu0YwS735cFmsBTcrNQeFjgTF2nO0K4dTSgc6bGeNdwfS+G2aSfoYj /EVh7kGb6w+/XUkDZ5HfaMR0cHfN+M1rT7rQD0xPAnFmjUZSQLkEIBYfcd5B55zgXQdff3kvxKj 5Kok= X-Google-Smtp-Source: AGHT+IFnLh3P/pkboEFd3WJXYkCvRGVTIP1M8iafusSg75RWkyJMy6xlUSzXnZN3Z2qnI+HPf5ILHg== X-Received: by 2002:a17:903:22cd:b0:1d9:4d3f:cbf6 with SMTP id y13-20020a17090322cd00b001d94d3fcbf6mr4314353plg.48.1706933563645; Fri, 02 Feb 2024 20:12:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWIyoiazHDEGXyeWc7v8ni6tNOhKN8VkyKBmSZ6pkMl+ouo2U6MK4W5bJLkIUMz16y8aNjBJxWF7cs4p+tW5eQU/FvcI+5bf/bVvYGnCg== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:12:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v7 01/19] common/sfc_efx: remove use of PMD logtype Date: Fri, 2 Feb 2024 20:11:34 -0800 Message-ID: <20240203041230.285599-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++--------- drivers/common/sfc_efx/sfc_efx_log.h | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c index 2dc5545760b8..5eeffb065b0d 100644 --- a/drivers/common/sfc_efx/sfc_efx.c +++ b/drivers/common/sfc_efx/sfc_efx.c @@ -15,7 +15,7 @@ #include "sfc_efx_log.h" #include "sfc_efx.h" -uint32_t sfc_efx_logtype; +int sfc_efx_logtype; static int sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key, @@ -117,11 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev, return rc; } -RTE_INIT(sfc_efx_register_logtype) -{ - int ret; - - ret = rte_log_register_type_and_pick_level("pmd.common.sfc_efx", - RTE_LOG_NOTICE); - sfc_efx_logtype = (ret < 0) ? RTE_LOGTYPE_PMD : ret; -} +RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE); diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h index 694455c1b14e..1519ebdc175f 100644 --- a/drivers/common/sfc_efx/sfc_efx_log.h +++ b/drivers/common/sfc_efx/sfc_efx_log.h @@ -11,7 +11,7 @@ #define _SFC_EFX_LOG_H_ /** Generic driver log type */ -extern uint32_t sfc_efx_logtype; +extern int sfc_efx_logtype; /** Log message, add a prefix and a line break */ #define SFC_EFX_LOG(level, ...) \ From patchwork Sat Feb 3 04:11:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136357 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EF7A43A57; Sat, 3 Feb 2024 05:12:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4612342E54; Sat, 3 Feb 2024 05:12:48 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 36CCE4028C for ; Sat, 3 Feb 2024 05:12:45 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d94323d547so23189615ad.3 for ; Fri, 02 Feb 2024 20:12:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933564; x=1707538364; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nv8FTd4nIOkDpIrFZS5XqniknFq2wcwUf8nwWdOzVQw=; b=WDO6KfNTcV7vIriR33XWHWlDMGzyZBSzHJX9vRzPGNlHo8AqbswFCKQxBbfWVUqoOf D1ZC0RELykpyiOGxOA5/dZdtaywP/z1V6EJywFAg3AZTju+TviZ/AHx1izmP94EqIsOH gq7jEk5Li4ykwYNb3TMeCL8ndKq5b39w7q3GbW2EWZc89ImdCTChzgL0Jv9y/BddQgFc TPAhYDNe8x+DbPob0ofndz5fUazS83D7AFr0x6VXaVnsL6HuZCIHqGnmJpTFP6S9h6hc NpvK0sCKpGnwjHufcjB959HgJUaZMPRdaGDzT9Xp/ci7zXZ/wlg/0sHxHyI1ITzHT9HR jgfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933564; x=1707538364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nv8FTd4nIOkDpIrFZS5XqniknFq2wcwUf8nwWdOzVQw=; b=HunUJKzJjQBrDjgYqIyP+p5mNr8epWDTGMdhN+8OnuYxvDORATDapPCIN8eXPwKrkR gb+vDl5kdGdQR7Goe7OgJvsWCAByySEz/BFfXcxk65Wf+WHKESgfIpeMLNx3FhmNLuMI dSm7rA99zvBwf1UBRcCPSPwODhus5uPIi5CtAcKeifa/D5Dc0zfwCipKCXNdPeZtWRou 6c/dKSawhf6KJ4VyUKSWduBe9b9isOC0JHDiPpqAN95CCgYvL7kPYr9w9so4flLfrtOc sokRNNtmf1GlR6pvVrMe8F7QMgBszMyVtHoTSEHhuauom7x2U8ijYjM2ILb8bZ5EYroq Qyfw== X-Gm-Message-State: AOJu0YxS4guUeX/WzYifIV0vHkcfctsB+D3Nf4AfllKFnLMNHUYRhLKa DHizWwOIDhuZ4wVL3nP3fBaoe8mASI+KOvpktf+G2KYB0WxRIAjygsbHBnQP27ZQY6wBBkqVLh+ Mti4= X-Google-Smtp-Source: AGHT+IFNAjYnOe06pk/UX9dtOTkH+PAycYiy9Glj+Kf0FLnX1I1uWZRa/cta4v+eQCgRBOesPNuICQ== X-Received: by 2002:a17:902:e748:b0:1d9:10ce:d950 with SMTP id p8-20020a170902e74800b001d910ced950mr5162239plf.63.1706933564434; Fri, 02 Feb 2024 20:12:44 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXTfNY8crAWsPbiRUh0fGUcbNp06CGs31f3k/C19SbfmHDIxgGaW/ICr6ZFWmlToftyN6N+5+2nSVj/DH832TyYFTrmNgrATRyT+wJWw0K3svyQlHhoqRZiXobnMipnWbj514mNzyTR+6O0+0usAmY/lQd3TDoDoHC51aNhwjUT4UBQQowB3cUEn0U= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:12:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Shreyansh Jain , Nipun Gupta Subject: [PATCH v7 02/19] mempool/dpaa2: use driver logtype not PMD Date: Fri, 2 Feb 2024 20:11:35 -0800 Message-ID: <20240203041230.285599-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has macros for logging, use them. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 84371d5d1abb..4c9245cb814c 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -293,7 +293,7 @@ rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_ERR("DPAA2 buffer pool not configured"); return -ENOMEM; } @@ -307,7 +307,7 @@ rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr) bp_info = mempool_to_bpinfo(mp); if (!(bp_info->bp_list)) { - RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n"); + DPAA2_MEMPOOL_ERR("DPAA2 buffer pool not configured"); return NULL; } From patchwork Sat Feb 3 04:11:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136358 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EDDC43A57; Sat, 3 Feb 2024 05:13:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 995E942E59; Sat, 3 Feb 2024 05:12:49 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 1047842DE8 for ; Sat, 3 Feb 2024 05:12:46 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d7431e702dso23983185ad.1 for ; Fri, 02 Feb 2024 20:12:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933565; x=1707538365; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GTucNmFfel9Scf8V63ReMufh9ptwWoYEP/RBAwAFyUU=; b=s1BlbVCJ/HuGR1UZmXyjOSb9vduk+BbdB3eTFKGKZPlZuXCJ/pKq2cc/IGDNrlN+AL 9q3aOyiHgE1SiYL01op4s1EuGvLqEVJG1FYy8TVLPwS/UzRLu4xAW+VhuLNhJpr/nd3V g8bGEhPHyc9cftZk2F5FzuPAebVsjxAyEnbVebYxvCxD3HVjuIaB4d2ADuK7+3vSOxJP VB5O9mwve28DvcCKJNeVECmRtmAY7vQmMsKIDfhY5mhPlPKPY1ERSw79ABguoJe96VXR gLaAp7MmX2tRI3J/+KUHNW3tlgwhUrtMCZbt6v0M86yhlZvtnCm6gO0B/5nLvEBX4CVq 44Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933565; x=1707538365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTucNmFfel9Scf8V63ReMufh9ptwWoYEP/RBAwAFyUU=; b=ILUZmiKBq4sQsdBao1NqCSfKNaMFooFMq7juUzl3tvjCRU5tgQ5Tbv/IVijCgZHIq/ 3y/8xeD25hVUW6+qBV7mKS1EiQv0J49+tgs70yl1buMR0ftkLMMD4MMWuxNHn/7Iqkw7 T7MIYPmoG573Fp5Tj7V4s5buhmh63QEzUfzGyqIbwJGLsH001fz9qB2yoT2cBAUjKZxX HmhS4Kl6Qkoz4g92IfUYkph3tcEyLP4ap+otYURUQ3K3aJLENcCuXCZGsq8WN82ucNzJ DMS6gutOHjHlffjI3oovA/aCUGwt1VRX7rptVDFII7nIUIjX98sIjwhaKjPpcjjtE03x gN0g== X-Gm-Message-State: AOJu0YwGsw5550V7Lm3EqjXJ2pyocEe7i8fh6zpBf1odlZ4/3oR69ZzN DZ9SaLXJ0kQChS5udwTMJ+tv9PsxZs2hvcDpPz0+lp5/OpKWtyonjdsQyt0KH5A0SvdIyi8jd3k IPuA= X-Google-Smtp-Source: AGHT+IFlib02Q4oNDZ/BuNqTcxhczMaRwgRhOjG1iGW1wP4Y3otsGjPqbh15XM7ML/IqDiSUB/gKXw== X-Received: by 2002:a17:902:ea08:b0:1d9:55b:6a4c with SMTP id s8-20020a170902ea0800b001d9055b6a4cmr12959525plg.32.1706933565294; Fri, 02 Feb 2024 20:12:45 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVGm+t5wuCKCVEJCcmZu6VPPd6onYW77thn63luBeSTV5GJfaNM1Ufnt+hfVGitWrIekpTNRxJFK1BH1M1Kuf8neew/gAYyDOaHH4/XB205NOYT1zARJJcPdqpD+SrBlbmMve6Pd7Ry97O++gXm/kcgYRSL7fQSqgR6cYcePvw+Nj6vDTAXvSOhuvU5Vgr5mQqyVeATGcdE+D3AqNqFfEzluhGIX6k= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:12:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Nipun Gupta , Aman Singh , Ferruh Yigit Subject: [PATCH v7 03/19] net/dpaa: use dedicated logtype not PMD Date: Fri, 2 Feb 2024 20:11:36 -0800 Message-ID: <20240203041230.285599-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver already has a logtype, but was not used in couple places. Fixes: 6b10d1f7bdea ("net/dpaa: update process specific device info") Fixes: c2c4f87b1259 ("net: add macro for MAC address print") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06db6a4d..bb2de5de801c 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -2096,8 +2096,8 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) /* copy the primary mac address */ rte_ether_addr_copy(&fman_intf->mac_addr, ð_dev->data->mac_addrs[0]); - RTE_LOG(INFO, PMD, "net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT "\n", - dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr)); + DPAA_PMD_INFO("net: dpaa: %s: " RTE_ETHER_ADDR_PRT_FMT, + dpaa_device->name, RTE_ETHER_ADDR_BYTES(&fman_intf->mac_addr)); if (!fman_intf->is_shared_mac) { /* Configure error packet handling */ @@ -2166,7 +2166,7 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, ret = dpaa_dev_init_secondary(eth_dev); if (ret != 0) { - RTE_LOG(ERR, PMD, "secondary dev init failed\n"); + DPAA_PMD_ERR("secondary dev init failed"); return ret; } From patchwork Sat Feb 3 04:11:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136359 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 308A743A57; Sat, 3 Feb 2024 05:13:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24A0C42E28; Sat, 3 Feb 2024 05:13:26 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id D156142E28 for ; Sat, 3 Feb 2024 05:13:24 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d7431e702dso23985725ad.1 for ; Fri, 02 Feb 2024 20:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933604; x=1707538404; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Y949PQVoZ0MsGzQje0CViLo2gY8MRdgQrEma/yqLOA=; b=ieWM7VAme3N6giPOmICu17evD7i3ED7snz6BtFFdubNvKwn/TpRQH5cPeg5tq2xQP8 SxXFCmr8RozDiCUufFUxgWgpTx7t98XWWiGbBKmNpDiAPh74qcWok/TD86On3HixywTQ bO/2CzNuOnzxsxz47Lz3eGxtF5VVkfmimJiXHkiGqqJUrXig+fqSolnSFvgIsGf6evZe zrtghlSNRC1t/b2hcPaEZ7JcO8UXMKJmBPlpFSN/oM75zrVuEIjdXwaBbxKZa/kib1Yi /BlUvxJ5uBiFv9Tj1F/M2TtSNElNl/3jdEzYcT/ddhxDZYnknC+0bodcFFNaFO7hcNAu gYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933604; x=1707538404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Y949PQVoZ0MsGzQje0CViLo2gY8MRdgQrEma/yqLOA=; b=h4zcyD40aWTkeT4C9ysadAMY3puCGIfzFrPoToss1SLZ1Y1um1CknIMsm4FVpbpKgq ULZtaTEA+6mWfyYs4jQaR3xu+JV4vf3bZes0gHfA/iITeaRjzcb0P7NsvNBPYWHYoKrS RaCI21FExcO6821n97Xmx8VscrlJYPuwkZAVftmIPf3ma3kuVS+gu+0JNYsEsp5d87BA mzmdRubROTNw1Xwy00PZ0pmX7VSCwwx9xQaW40F6tqc975wC4SOYfCG4GsW1SUwAddVH ibBtf5eWqfRNqqESOpvg74jurpFmuSgvkaRW0U29Nu8ozdHHysNrvgUuOcK0TOHU6q1W bMtA== X-Gm-Message-State: AOJu0YwJcYAnGmsPDrvbkJCNe/3rLIfxgxc4xzIqKVmGz2UD59B8QnPT 4ii+rGwVbOTeP43vtuEFifHDG1WPKyIlregeC3CCPgTD8Pxz79yipFDtf3dMa06j/16To3sON4D Tj9M= X-Google-Smtp-Source: AGHT+IHbRIUL5LefYukZwmwXz2qKMlXRwB4c9fsLQHv/BLrEkZ1k+NIibrhognqEwXtuzGutDQAnBA== X-Received: by 2002:a17:902:c942:b0:1d9:909f:40b6 with SMTP id i2-20020a170902c94200b001d9909f40b6mr165509pla.58.1706933604039; Fri, 02 Feb 2024 20:13:24 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUdzBU1W0ae1P8wDMiFZfjzWKPDBF2QP9CE7m9IAZ7e8GSb85DxBWAxrKzoTavSwdWrOOCMJlUjWvEUpGCwHj0W7c08xWdQZmakNRVb0DC4qtG8uw7JrEPdhknJWi1gRjY3l4keaFZNCzTrH4SWyKc= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Jun Yang Subject: [PATCH v7 04/19] net/dpaa2: used dedicated logtype not PMD Date: Fri, 2 Feb 2024 20:11:37 -0800 Message-ID: <20240203041230.285599-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver has a logtype, but was not being used in one place. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver") Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 8e610b6bba30..91846fcd2f23 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2851,7 +2851,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev) return ret; } } - RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n", + DPAA2_PMD_INFO("%s: netdev created, connected to %s", eth_dev->data->name, dpaa2_dev->ep_name); return 0; diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c index 63463c4fbfd6..36a14526a5c5 100644 --- a/drivers/net/dpaa2/dpaa2_sparser.c +++ b/drivers/net/dpaa2/dpaa2_sparser.c @@ -181,7 +181,7 @@ int dpaa2_eth_load_wriop_soft_parser(struct dpaa2_dev_priv *priv, priv->ss_iova = (uint64_t)(DPAA2_VADDR_TO_IOVA(addr)); priv->ss_offset += sp_param.size; - RTE_LOG(INFO, PMD, "Soft parser loaded for dpni@%d\n", priv->hw_id); + DPAA2_PMD_INFO("Soft parser loaded for dpni@%d", priv->hw_id); rte_free(addr); return 0; @@ -234,6 +234,6 @@ int dpaa2_eth_enable_wriop_soft_parser(struct dpaa2_dev_priv *priv, } rte_free(param_addr); - RTE_LOG(INFO, PMD, "Soft parser enabled for dpni@%d\n", priv->hw_id); + DPAA2_PMD_INFO("Soft parser enabled for dpni@%d", priv->hw_id); return 0; } From patchwork Sat Feb 3 04:11:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136360 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BDC443A57; Sat, 3 Feb 2024 05:13:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5197842E85; Sat, 3 Feb 2024 05:13:28 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id A461442E70 for ; Sat, 3 Feb 2024 05:13:26 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5ceb3fe708eso2173775a12.3 for ; Fri, 02 Feb 2024 20:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933606; x=1707538406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O/3FVf6ronbFhbT65lMIeqaoXXZAJg+9bIB9D2tN89c=; b=mCLgdy+DDCpLRFH1RZWxA5BhD4XhWkIppAH6knWoi4vab/TXngT+fo1XvJ6DIU5It0 6ORtEDxe06fm1yrpgnvoAK5eCxeqFjfI2vaGx2NzCmWxvSAARrhm09eXGAbAGLnrVLkj i5oG6+KBaGC9b1LcH1V7Ft+vOZt6rMWnKsQUJgg8ZhFd64MGvC5HEsDEc4MIVqt7zQM/ E+r0VRRy93WLBoGUF7fUEYAzuyD1e53mO1vM79PuJt4MIzkhaIawOkPB71Qdc7rJ2vXG SD3V7C2NvRNkc847TARjCdx9hpnAlyBzPAFqNhMhVqxInIvcxyWoaK6U3dpfdKgkhgvK ZTAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933606; x=1707538406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O/3FVf6ronbFhbT65lMIeqaoXXZAJg+9bIB9D2tN89c=; b=nPDYavm7vcEnlOB0sKzaZD9MA31HIoENw5TbhMRtjQ90DmcL1VUTaa0I2eXPoFFT5d f6x/HyYDHmauA0jJ6+hnyqajfDKaoQ8LzzhkqRdC5f/CZQvHXsWlD3mM1ol5BaMdeZtB fxQ1YfWGdui0gAcPrfQzRnEx63PjOquY58kbNC1mRgKL+iL7OP+GJqE0YAIl6ntvZnoJ Hom9p0vPB0JIscqRS/2lzbzoQAU09ENqMFI0iMxSBA9iqO88uImlVy7xPmg+z8aZVO4d 25bmrjZR1UOaVI6pfSoqL7DozNcEuwxUK1rTprHQnCdlyyU27lRYgyzqRT4yjoyxhjtY uOPA== X-Gm-Message-State: AOJu0Yw4r9oGkHlnWGTNrLmLYPKiKSmVgX5bdkA9hEhalHqD7P3D//5j VstXP1wqVyssJFe12zT02/Jw+5nAxB7tjpvcEa7q/662gwd2PzW9qoxMyDKpDq0X27OTVLHURSS jIyY= X-Google-Smtp-Source: AGHT+IEuGwo+Z8g9MirhMyN9oHOOSvHdbTgJz9yIy3IiAghoClZzM61rdEkROezhjzH0jEICAJ/69Q== X-Received: by 2002:a17:902:d2c4:b0:1d9:7acf:f15b with SMTP id n4-20020a170902d2c400b001d97acff15bmr3680131plc.62.1706933605944; Fri, 02 Feb 2024 20:13:25 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXa5UQDpYQJpNmJAYAOXjjH4SxowoLst0QrXPFJAHwCCnzbwUTD5La9nOQwn2ljs+92yQAdbxdhsEXte6H2gF74oJMB1XXdtVMMJWjumOpKYDg2ardlgB7Y6I42zfgsqrKAAIQ9U2RuygyvY/c= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi , Natalie Samsonov , Yelena Krivosheev Subject: [PATCH v7 05/19] net/mrvl: do not use PMD logtype Date: Fri, 2 Feb 2024 20:11:38 -0800 Message-ID: <20240203041230.285599-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use the same logtype as other places in the driver. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index c12364941d62..1ca13e8b89d7 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -2976,8 +2976,7 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, */ if (nb_segs > PP2_PPIO_DESC_NUM_FRAGS) { total_descs -= nb_segs; - RTE_LOG(ERR, PMD, - "Too many segments. Packet won't be sent.\n"); + MRVL_LOG(ERR, "Too many segments. Packet won't be sent."); break; } From patchwork Sat Feb 3 04:11:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136361 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86EAF43A57; Sat, 3 Feb 2024 05:13:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B00B142E8B; Sat, 3 Feb 2024 05:13:29 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 4622142E6C for ; Sat, 3 Feb 2024 05:13:28 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d51ba18e1bso25425985ad.0 for ; Fri, 02 Feb 2024 20:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933607; x=1707538407; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vbPK1CESofefM0HP3tGfFHeTe9I03ArjMmDBkxCln1U=; b=n9TzQ2s9DS5DK1wcE6IGKBl3UG86//rg692nfVldhfoHA4X6Vw9vuegM6VxuRE7ONn REF95fwoRAZSjuVjwlb+PyepFaHf08KVe2UA0pDH4PmnNCadkympOx6QsBCnvfXiWuA1 KkiKk7sXE0gkS6NUzd+6LroF3Aw+/yDBHQx6bZNo9dHi2iQQPgrz9nv2DkioSsWjZmYq XUdTwi+EnCXy/yK5+CRbNFpbJsi8TFiFzLEQ0pf4CiUUPrwWXmYhk1Bl3iO/YiobsN+O XfBN3fbOFkVoc73pWfTKdxxC9VgDuNEGolm7L4hkScUVhw9G5Dr6FDK3zYTEZ9KQXNbw GM+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933607; x=1707538407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vbPK1CESofefM0HP3tGfFHeTe9I03ArjMmDBkxCln1U=; b=r/kugSxjUsrFqAPngvF1CF9l6/lMLdPqrMDSO1smgtutbVWYEwxv7mYrmXhKHk1zY9 PRyKeUGpHZhZfsoZ6mlHyAEmfRsa1FY6LwJ1mJwqSMU+oGj1xFlS8C54WwYZaMpZ/k6G I0vWM18uNrwSAO8wna+zKBW+WogN4EZSZc29XWco0eSYXXnBcKZF1LzpXLviJzkueStj 6bv6BIpVjKpiccGNQQDFWi6x58YCKCseMtBtx07/XqgTtd68uMUZlwdvcAU82TZ4VWBG HXONRv7wiRVRG8PbruzudU7ZBLPOxKM+SvyVpG+LNTZQsARP6L6MHkBTI9BnWPelKtTq 8t+g== X-Gm-Message-State: AOJu0YxSI9SBZWhNpBO2haYuI8zIRvAMm5MJ0rUk4hcbSGkEa7BLceuQ RctLOceTkGFkuDFQtItVx/ZNZut2tWd3cAEWS65r1vSyvqAx0NpNZpPsrB7XDPYRGlLCJB42GYm +hCA= X-Google-Smtp-Source: AGHT+IEByg99vojuPrYIzzYMkIPNdycJ0qHEXjv3yEiV9BU4WbTVgyAlaYkoNOJ80K/Psgt8C4YVkQ== X-Received: by 2002:a17:902:e88a:b0:1d9:5371:bc with SMTP id w10-20020a170902e88a00b001d9537100bcmr5323913plg.37.1706933607542; Fri, 02 Feb 2024 20:13:27 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUoTh0BdyjTZtaDvIBiEkjD28vAVBDnCY+f/TCES1HbHS0Haz2HCyPcUTF8WXziNAwn1EdIjJsEqpERhikKtaupsNdOgwRdiQ/eZ0IQmLboLpkCQy0/ubHRRFX2O169BcwxjpmV+kH8sFCS5ok= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi , Yelena Krivosheev , Natalie Samsonov Subject: [PATCH v7 06/19] net/mvpp2: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:39 -0800 Message-ID: <20240203041230.285599-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Always use the dedicated logtype, not PMD. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 1ca13e8b89d7..a91509d92afb 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -415,10 +415,10 @@ mrvl_set_tx_function(struct rte_eth_dev *dev) /* Use a simple Tx queue (no offloads, no multi segs) if possible */ if (priv->multiseg) { - RTE_LOG(INFO, PMD, "Using multi-segment tx callback\n"); + MRVL_LOG(INFO, "Using multi-segment tx callback"); dev->tx_pkt_burst = mrvl_tx_sg_pkt_burst; } else { - RTE_LOG(INFO, PMD, "Using single-segment tx callback\n"); + MRVL_LOG(INFO, "Using single-segment tx callback"); dev->tx_pkt_burst = mrvl_tx_pkt_burst; } } From patchwork Sat Feb 3 04:11:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136362 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAD1C43A57; Sat, 3 Feb 2024 05:13:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFB6142E95; Sat, 3 Feb 2024 05:13:32 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 292C74064E for ; Sat, 3 Feb 2024 05:13:29 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d71cb97937so26124435ad.3 for ; Fri, 02 Feb 2024 20:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933608; x=1707538408; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p1CL05txfCQAMKHdoVGLoD22ggOCmji7+06/aHMlspA=; b=wC5I3pq7gAumFI8anAlLfqgRDSHj6AKD0EGo71mTTscZ81i6XBi6DgaVViQakj2QA+ lQAJpZmwltm9vjzbvSGrpXoYe3VyUBpLF/VCGzpJwc/gMg/wglPlolqD28nEMSH8gaaF Ki7H8Z+slFx5rmIFmC6PMNcRwMoQ3wmCRQd2lm5EDCVS5muqHLETQoZt5TwRIEUypB/i IB4068+DPBobjQc7hNHjJN/Lsc9RzBleoemn1pOsD41Ji9BuQaY6pVoazadiCTI255lV ifJpon3e2hsme8gX8QLCDdCa02xZBvtczyD7Z6wkUjLTPEhgF6pyNFCMDO+lKKxE55v9 aVnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933608; x=1707538408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1CL05txfCQAMKHdoVGLoD22ggOCmji7+06/aHMlspA=; b=qoWmGOI6ipduki0EKnS51wdoRSsd+VEE/oYrtmxNd+cbBmn5f32a2XWbB8WPdefIr3 KJt2MXtTurdfENDwIWTQm2UGTj9SyPos4Oq2cEKwzz9di7R20AXZpCx7BnHrJydQe/WK 0KEkEQxz56ObZQJ56mJaH2tkgTgpl0cMhUzERTjPG9m4cXqEK2Y12aJqravEkIMLSeBt C50XmEkSJClC2F1Lu8rOKK6mWzY4jMJfhMtubIMe9Ef+YP386p1j0cdzlUlgH6gd9qDs SqkMquIqeWiKcF5jMDVeywxzgg7BdBvfTHlFRrxWiUgCvZjDDJLteHXi4VMJj33GQqkG D0BQ== X-Gm-Message-State: AOJu0YzQbgBhMoMDP7eCiLQVSMBzDXrvW+t+GQE1DeNKhOa6y9QI3Grl BbXsGVe5vm+eYEyf7qSZzqSRNr+Wg5z0mPhBdiqYhKtQC8UwCLvzbXN6tGT35Q5Nqzw84n6v0xs uYro= X-Google-Smtp-Source: AGHT+IGfxNoheoQKiqGcgaAPRSmvYowm0I3LQirtSZv/oputtre91Vk4pGFZB7W28BK2F+po8VL4hA== X-Received: by 2002:a17:903:11cd:b0:1d8:fb03:a01e with SMTP id q13-20020a17090311cd00b001d8fb03a01emr12695609plh.32.1706933608349; Fri, 02 Feb 2024 20:13:28 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX00RaAWcLU88qy4sF++34zytdxunbo/GbPKwhMXFbtM6Ly4QuzaoUXVUsJrX+zO5+SSnvj7czdiBSVQz8YZHDiqQ6/9+MHaxgj/Z8C8sT1AUwQN2k3 Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Martin Spinler , Rastislav Cernay Subject: [PATCH v7 07/19] net/nfb: use dynamic logtype Date: Fri, 2 Feb 2024 20:11:40 -0800 Message-ID: <20240203041230.285599-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org All drivers should be using dynamic logtype. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: Stephen Hemminger --- drivers/net/nfb/nfb.h | 5 +++++ drivers/net/nfb/nfb_ethdev.c | 20 +++++++++----------- drivers/net/nfb/nfb_rx.c | 10 +++++----- drivers/net/nfb/nfb_rx.h | 2 +- drivers/net/nfb/nfb_tx.c | 10 +++++----- drivers/net/nfb/nfb_tx.h | 2 +- 6 files changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/net/nfb/nfb.h b/drivers/net/nfb/nfb.h index 7dc5bd29e44c..45226ee3d938 100644 --- a/drivers/net/nfb/nfb.h +++ b/drivers/net/nfb/nfb.h @@ -12,6 +12,11 @@ #include #include +extern int nfb_logtype; +#define NFB_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, nfb_logtype, "%s(): " fmt "\n", \ + __func__, ## args) + #include "nfb_rx.h" #include "nfb_tx.h" diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c index defd118bd0ee..da9e4167ea69 100644 --- a/drivers/net/nfb/nfb_ethdev.c +++ b/drivers/net/nfb/nfb_ethdev.c @@ -192,8 +192,7 @@ nfb_eth_dev_configure(struct rte_eth_dev *dev __rte_unused) (&nfb_timestamp_dynfield_offset, &nfb_timestamp_rx_dynflag); if (ret != 0) { - RTE_LOG(ERR, PMD, "Cannot register Rx timestamp" - " field/flag %d\n", ret); + NFB_LOG(ERR, "Cannot register Rx timestamp field/flag %d", ret); nfb_close(internals->nfb); return -rte_errno; } @@ -520,7 +519,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) struct rte_ether_addr eth_addr_init; struct rte_kvargs *kvlist; - RTE_LOG(INFO, PMD, "Initializing NFB device (" PCI_PRI_FMT ")\n", + NFB_LOG(INFO, "Initializing NFB device (" PCI_PRI_FMT ")", pci_addr->domain, pci_addr->bus, pci_addr->devid, pci_addr->function); @@ -536,7 +535,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) kvlist = rte_kvargs_parse(dev->device->devargs->args, VALID_KEYS); if (kvlist == NULL) { - RTE_LOG(ERR, PMD, "Failed to parse device arguments %s", + NFB_LOG(ERR, "Failed to parse device arguments %s", dev->device->devargs->args); rte_kvargs_free(kvlist); return -EINVAL; @@ -551,14 +550,14 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) */ internals->nfb = nfb_open(internals->nfb_dev); if (internals->nfb == NULL) { - RTE_LOG(ERR, PMD, "nfb_open(): failed to open %s", + NFB_LOG(ERR, "nfb_open(): failed to open %s", internals->nfb_dev); return -EINVAL; } data->nb_rx_queues = ndp_get_rx_queue_available_count(internals->nfb); data->nb_tx_queues = ndp_get_tx_queue_available_count(internals->nfb); - RTE_LOG(INFO, PMD, "Available NDP queues RX: %u TX: %u\n", + NFB_LOG(INFO, "Available NDP queues RX: %u TX: %u", data->nb_rx_queues, data->nb_tx_queues); nfb_nc_rxmac_init(internals->nfb, @@ -583,7 +582,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) data->mac_addrs = rte_zmalloc(data->name, sizeof(struct rte_ether_addr) * mac_count, RTE_CACHE_LINE_SIZE); if (data->mac_addrs == NULL) { - RTE_LOG(ERR, PMD, "Could not alloc space for MAC address!\n"); + NFB_LOG(ERR, "Could not alloc space for MAC address"); nfb_close(internals->nfb); return -EINVAL; } @@ -601,8 +600,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; - RTE_LOG(INFO, PMD, "NFB device (" - PCI_PRI_FMT ") successfully initialized\n", + NFB_LOG(INFO, "NFB device (" PCI_PRI_FMT ") successfully initialized", pci_addr->domain, pci_addr->bus, pci_addr->devid, pci_addr->function); @@ -626,8 +624,7 @@ nfb_eth_dev_uninit(struct rte_eth_dev *dev) nfb_eth_dev_close(dev); - RTE_LOG(INFO, PMD, "NFB device (" - PCI_PRI_FMT ") successfully uninitialized\n", + NFB_LOG(INFO, "NFB device (" PCI_PRI_FMT ") successfully uninitialized", pci_addr->domain, pci_addr->bus, pci_addr->devid, pci_addr->function); @@ -690,3 +687,4 @@ static struct rte_pci_driver nfb_eth_driver = { RTE_PMD_REGISTER_PCI(RTE_NFB_DRIVER_NAME, nfb_eth_driver); RTE_PMD_REGISTER_PCI_TABLE(RTE_NFB_DRIVER_NAME, nfb_pci_id_table); RTE_PMD_REGISTER_KMOD_DEP(RTE_NFB_DRIVER_NAME, "* nfb"); +RTE_LOG_REGISTER_DEFAULT(nfb_logtype, NOTICE); diff --git a/drivers/net/nfb/nfb_rx.c b/drivers/net/nfb/nfb_rx.c index 8a9b232305f2..f72afafe8fb9 100644 --- a/drivers/net/nfb/nfb_rx.c +++ b/drivers/net/nfb/nfb_rx.c @@ -6,8 +6,8 @@ #include -#include "nfb_rx.h" #include "nfb.h" +#include "nfb_rx.h" uint64_t nfb_timestamp_rx_dynflag; int nfb_timestamp_dynfield_offset = -1; @@ -19,7 +19,7 @@ nfb_eth_rx_queue_start(struct rte_eth_dev *dev, uint16_t rxq_id) int ret; if (rxq->queue == NULL) { - RTE_LOG(ERR, PMD, "RX NDP queue is NULL!\n"); + NFB_LOG(ERR, "RX NDP queue is NULL"); return -EINVAL; } @@ -40,7 +40,7 @@ nfb_eth_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rxq_id) int ret; if (rxq->queue == NULL) { - RTE_LOG(ERR, PMD, "RX NDP queue is NULL!\n"); + NFB_LOG(ERR, "RX NDP queue is NULL"); return -EINVAL; } @@ -70,8 +70,8 @@ nfb_eth_rx_queue_setup(struct rte_eth_dev *dev, RTE_CACHE_LINE_SIZE, socket_id); if (rxq == NULL) { - RTE_LOG(ERR, PMD, "rte_zmalloc_socket() failed for rx queue id " - "%" PRIu16 "!\n", rx_queue_id); + NFB_LOG(ERR, "rte_zmalloc_socket() failed for rx queue id %" PRIu16, + rx_queue_id); return -ENOMEM; } diff --git a/drivers/net/nfb/nfb_rx.h b/drivers/net/nfb/nfb_rx.h index b618682e1393..2802f17091a0 100644 --- a/drivers/net/nfb/nfb_rx.h +++ b/drivers/net/nfb/nfb_rx.h @@ -156,7 +156,7 @@ nfb_eth_ndp_rx(void *queue, struct rte_mbuf *mbufs[nb_pkts]; if (unlikely(ndp->queue == NULL || nb_pkts == 0)) { - RTE_LOG(ERR, PMD, "RX invalid arguments!\n"); + NFB_LOG(ERR, "RX invalid arguments"); return 0; } diff --git a/drivers/net/nfb/nfb_tx.c b/drivers/net/nfb/nfb_tx.c index d49fc324e76b..a1318a420580 100644 --- a/drivers/net/nfb/nfb_tx.c +++ b/drivers/net/nfb/nfb_tx.c @@ -4,8 +4,8 @@ * All rights reserved. */ -#include "nfb_tx.h" #include "nfb.h" +#include "nfb_tx.h" int nfb_eth_tx_queue_start(struct rte_eth_dev *dev, uint16_t txq_id) @@ -14,7 +14,7 @@ nfb_eth_tx_queue_start(struct rte_eth_dev *dev, uint16_t txq_id) int ret; if (txq->queue == NULL) { - RTE_LOG(ERR, PMD, "RX NDP queue is NULL!\n"); + NFB_LOG(ERR, "RX NDP queue is NULL"); return -EINVAL; } @@ -35,7 +35,7 @@ nfb_eth_tx_queue_stop(struct rte_eth_dev *dev, uint16_t txq_id) int ret; if (txq->queue == NULL) { - RTE_LOG(ERR, PMD, "TX NDP queue is NULL!\n"); + NFB_LOG(ERR, "TX NDP queue is NULL"); return -EINVAL; } @@ -62,8 +62,8 @@ nfb_eth_tx_queue_setup(struct rte_eth_dev *dev, RTE_CACHE_LINE_SIZE, socket_id); if (txq == NULL) { - RTE_LOG(ERR, PMD, "rte_zmalloc_socket() failed for tx queue id " - "%" PRIu16 "!\n", tx_queue_id); + NFB_LOG(ERR, "rte_zmalloc_socket() failed for tx queue id %" PRIu16, + tx_queue_id); return -ENOMEM; } diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h index 910020e9e96f..f107cf914bbd 100644 --- a/drivers/net/nfb/nfb_tx.h +++ b/drivers/net/nfb/nfb_tx.h @@ -140,7 +140,7 @@ nfb_eth_ndp_tx(void *queue, return 0; if (unlikely(ndp->queue == NULL)) { - RTE_LOG(ERR, PMD, "TX invalid arguments!\n"); + NFB_LOG(ERR, "TX invalid arguments"); return 0; } From patchwork Sat Feb 3 04:11:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136363 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBF9E43A57; Sat, 3 Feb 2024 05:13:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27FEF42EA1; Sat, 3 Feb 2024 05:13:34 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 106FD42E90 for ; Sat, 3 Feb 2024 05:13:30 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so2201630a12.3 for ; Fri, 02 Feb 2024 20:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933609; x=1707538409; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u986atT1BkRmtCNh10url9mKtsPhvh7P/VKgHCU2mrY=; b=UdC2UzVDfYjdNNZPgPEbsxeeCoeNwM9Kj0NbvdNVWhiHIVuEm4Ev5djVSa/HxU6pe5 kywYDWzRkpXHj7dAXM5lb7ErFhx9A4KOySt+bEoLGsTdfHupbk9ZQPQLn/eNDaS/rPtq EnVld8V9G+CTuoe7zMHJFk5bMFkSJsyVB4QxlLPevvmMGopeQz9Z8dLIj5HCufbMDA6F AiIbxWbMX2tRhvAipXtS9g3Zpelo2x68Z0sqAJMNCQ8e2pvMMdGHVK5gf0LpaunYA0Fx TXwGoo/1sArD0eEQpWjjqLUY4ljX/mLT2diFAkVADhvhfyDpmV2cXjJTAa2FusgiFi+g ef4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933609; x=1707538409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u986atT1BkRmtCNh10url9mKtsPhvh7P/VKgHCU2mrY=; b=lhDw+ioeVVCaRLUayVavUknOZegA156hc1wB0+Qo9LrMoDMWkG2OEJetDqhHLpVsET 08zJ45snKBVo7oBqk2bJx44nzudnPbRUUBmOg2TH8iBXsXN3/OO8T3f3/GOhdtQkdmF+ ItLesyy4BxCBrQsNTqaKxhuirFxwyvNj10jvPJGsdJNuNhBUuM/YkDPS7yncCDo25DUB NI0oVt1uNNf9ERDt1RC6R8sBGOgapCq+4TKPvIIIrZue3Zi+LI1WGEnJ4I2ev4bCICIh 281R9Je3/cDNkwPRQRRB6Rxss2h6X7iwKKBl8jqEttrc98rhAjDtBkDpENhUGvn2tCPr QYjw== X-Gm-Message-State: AOJu0Ywfa0tw2qgptToUon6ToVnAaNXNhH/3Izf2+XFHv9G4SMYEDOG/ nSzown0RMYoHTyl3STA+cXGSW7UrGJS98ib4E5I7Ie4CUKnX+WEAK9DpZ5wxPEV4aCi8u9L7TZM ZCfo= X-Google-Smtp-Source: AGHT+IE0jZ66i1mDsgPrcnkQPPcEgDe9/foOmijnypF1KncDmlWSNm7yyQ2z1sV5fWr9PwpFxLPm7w== X-Received: by 2002:a05:6a21:150b:b0:19e:5110:be0 with SMTP id nq11-20020a056a21150b00b0019e51100be0mr3402892pzb.54.1706933609290; Fri, 02 Feb 2024 20:13:29 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXj6OtrmDTvQLr+MdgRQ4OW2PugYI+wIMhsJl7b0JG3Uj41MlwZIU6pXmdFZcxsVR+0lObt3DBVTrND6yEghP7/ntMYokbyCpBKSt5zXC5xniTCS0LaS8qnDfdX Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jochen Behrens , Yong Wang Subject: [PATCH v7 08/19] net/vmxnet3: used dedicated logtype not PMD Date: Fri, 2 Feb 2024 20:11:41 -0800 Message-ID: <20240203041230.285599-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver has log macros, just not used in one place. Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index e49191718aea..4fd704045fc4 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1919,7 +1919,7 @@ vmxnet3_interrupt_handler(void *param) if (events == 0) goto done; - RTE_LOG(DEBUG, PMD, "Reading events: 0x%X", events); + PMD_DRV_LOG(DEBUG, "Reading events: 0x%X", events); vmxnet3_process_events(dev); done: vmxnet3_enable_intr(hw, *eventIntrIdx); From patchwork Sat Feb 3 04:11:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136364 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5D0443A57; Sat, 3 Feb 2024 05:13:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DF8842EA5; Sat, 3 Feb 2024 05:13:35 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 11EE442E92 for ; Sat, 3 Feb 2024 05:13:31 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1d731314e67so20407635ad.1 for ; Fri, 02 Feb 2024 20:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933610; x=1707538410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3PUGQibq4Z04OHz5a5w2IsgLwCxy9TOKdOEbRTjZwLg=; b=xPCriKqSSVpyjXB+sk2oRBxul3wm41q8wkwIv98d8GKE1VKkoUX17EArMK1rYY8dJw YzhEw0abGS4dnH3Z52TNeFfyAnrEtXi0Cshbt0D+Acrf/zp5EeMPGrAuom9i2oKhpoza yildITQnmpZRPsfUJYLedZHTgQatQ5/33fRsi54he/QyURq10Y2ES/URtDFED1C7VM7W RUkNeYHb5+ELqTlDtbw745dELlb7VZUMOozz45++XbPvZCtk9YYGqxC0xu+tKKP39RtH G+J4aV4O4oykewLFkmRG1ZbjKctqQUr9XXWzqNOk1QraRh/sSZ6ACYAMSv6hMAUteu2t AX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933610; x=1707538410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PUGQibq4Z04OHz5a5w2IsgLwCxy9TOKdOEbRTjZwLg=; b=ZBhdF4JCcse4FWC7UTHQ8tq8VADNUN8YN1K0f7Y4JsknwsvI+7/5A+OQxUPHYmx5xw qHri7yJ7PziNGakBixllXtW+/ytnmyHLD7172oWLBr7/69vueHpiMcAv7ykO14UN1zpp zNp7NU+KjcEEcpxfPg9tF4AZ0EhX5M1UOScGLGaUnXBmpB2v2IIb6tOqYD6lew4K9MPe uRutJTQcS1yTYiojY5G0PPYy16mNJSJrkRMLKt+jg/2YYW9dllBZzaszfgAzHs65nZVk Tc2D7JJfH+UiC2rCv4OBBV+rMs8wq+PFXXQ9UOLFvVlpuiUmv9OSbRNHdVsUlg4eqaXL BQQg== X-Gm-Message-State: AOJu0YxE9km3fZbg1hJzHBhJ1xYOMlBZFO1Bws2F/0N4RwXBXvgk6/ac /cqmzCzvGZf2sEaSgsQ/ui1zgcu9TS1VWXN+4wzENTE7j6iRDksHRtWRurW8y40MGZRSo0wsJrW aJ1s= X-Google-Smtp-Source: AGHT+IHBP6RYlswJzrJpgUKH99cJG9ZqJAq0fM15gvO4cZZxn0aQz2LLf0+jJoA4jPqMz6g3iquRyg== X-Received: by 2002:a17:902:d489:b0:1d9:6cc7:d40b with SMTP id c9-20020a170902d48900b001d96cc7d40bmr4592409plg.25.1706933610240; Fri, 02 Feb 2024 20:13:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVkBpWFP/OGTnvmRHKBk8jDbuB9Wj4LiPt1k5kDuNPeeAVzO6mUJvBYp4SY4Ihq1mSwSMqjkiGU4os4sCZG0mqVOQoQxxrZpyT4HLN2fhHFTeM6IMavmlsUB6z3jvwacJiIqy8JtERlbw3fr16XjXn2bFB9JZ/UK0YaVK83cwBVEKDekWAYjMCtw34+TPZcMdAH3KESLW6aCN7X34UErLikEQFho2OC4IpIW0CyanlX60BT45kZFlsTTQ== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jakub Palider , Tomasz Duszynski Subject: [PATCH v7 09/19] raw/cnxk: replace PMD logtype with dynamic type Date: Fri, 2 Feb 2024 20:11:42 -0800 Message-ID: <20240203041230.285599-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 16 ++++++----- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +++++++++++----------- drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 6 +++++ drivers/raw/cnxk_gpio/cnxk_gpio.c | 21 ++++++++------- drivers/raw/cnxk_gpio/cnxk_gpio.h | 5 ++++ drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 17 ++++++------ 8 files changed, 57 insertions(+), 44 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index ba23b2e0d79e..9d2ea8f00965 100644 --- a/drivers/common/cnxk/roc_platform.h +++ b/drivers/common/cnxk/roc_platform.h @@ -265,11 +265,13 @@ extern int cnxk_logtype_tm; extern int cnxk_logtype_ree; extern int cnxk_logtype_dpi; +#define RTE_LOGTYPE_CNXK cnxk_logtype_base + #define plt_err(fmt, args...) \ - RTE_LOG(ERR, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) -#define plt_info(fmt, args...) RTE_LOG(INFO, PMD, fmt "\n", ##args) -#define plt_warn(fmt, args...) RTE_LOG(WARNING, PMD, fmt "\n", ##args) -#define plt_print(fmt, args...) RTE_LOG(INFO, PMD, fmt "\n", ##args) + RTE_LOG(ERR, CNXK, "%s():%u " fmt "\n", __func__, __LINE__, ##args) +#define plt_info(fmt, args...) RTE_LOG(INFO, CNXK, fmt "\n", ##args) +#define plt_warn(fmt, args...) RTE_LOG(WARNING, CNXK, fmt "\n", ##args) +#define plt_print(fmt, args...) RTE_LOG(INFO, CNXK, fmt "\n", ##args) #define plt_dump(fmt, ...) fprintf(stderr, fmt "\n", ##__VA_ARGS__) #define plt_dump_no_nl(fmt, ...) fprintf(stderr, fmt, ##__VA_ARGS__) @@ -296,11 +298,11 @@ extern int cnxk_logtype_dpi; /* Datapath logs */ #define plt_dp_err(fmt, args...) \ - RTE_LOG_DP(ERR, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) + RTE_LOG_DP(ERR, CNXK, "%s():%u " fmt "\n", __func__, __LINE__, ##args) #define plt_dp_info(fmt, args...) \ - RTE_LOG_DP(INFO, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) + RTE_LOG_DP(INFO, CNXK, "%s():%u " fmt "\n", __func__, __LINE__, ##args) #define plt_dp_dbg(fmt, args...) \ - RTE_LOG_DP(DEBUG, PMD, "%s():%u " fmt "\n", __func__, __LINE__, ##args) + RTE_LOG_DP(DEBUG, CNXK, "%s():%u " fmt "\n", __func__, __LINE__, ##args) #ifdef __cplusplus #define CNXK_PCI_ID(subsystem_dev, dev) \ diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c index 15dbc4c1a637..1dbab6fb3e12 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c @@ -251,7 +251,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev, /* get rid of last response if any */ if (qp->rsp) { - RTE_LOG(WARNING, PMD, "Previous response got overwritten\n"); + CNXK_BPHY_LOG(WARNING, "Previous response got overwritten"); rte_free(qp->rsp); } qp->rsp = rsp; @@ -410,3 +410,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = { RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd); RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map); RTE_PMD_REGISTER_KMOD_DEP(bphy_rawdev_pci_driver, "vfio-pci"); +RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_bphy, bphy, INFO); diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index 2d8466ef918b..4358aeecc3e5 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -189,7 +189,7 @@ cnxk_bphy_cgx_process_buf(struct cnxk_bphy_cgx *cgx, unsigned int queue, /* get rid of last response if any */ if (qp->rsp) { - RTE_LOG(WARNING, PMD, "Previous response got overwritten\n"); + CNXK_BPHY_LOG(WARNING, "Previous response got overwritten"); rte_free(qp->rsp); } qp->rsp = rsp; diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c index a3021b4bb7db..f01d958661ad 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c @@ -57,62 +57,61 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id) if (ret) break; if (descs != 1) { - RTE_LOG(ERR, PMD, "Wrong number of descs reported\n"); + CNXK_BPHY_LOG(ERR, "Wrong number of descs reported"); ret = -ENODEV; break; } - RTE_LOG(INFO, PMD, "Testing queue %d\n", i); + CNXK_BPHY_LOG(INFO, "Testing queue %d", i); ret = rte_pmd_bphy_cgx_stop_rxtx(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to stop rx/tx\n"); + CNXK_BPHY_LOG(ERR, "Failed to stop rx/tx"); break; } ret = rte_pmd_bphy_cgx_start_rxtx(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to start rx/tx\n"); + CNXK_BPHY_LOG(ERR, "Failed to start rx/tx"); break; } ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, false); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set link down\n"); + CNXK_BPHY_LOG(ERR, "Failed to set link down"); break; } ret = cnxk_bphy_cgx_link_cond(dev_id, i, 0); if (ret != 0) - RTE_LOG(ERR, PMD, - "Timed out waiting for a link down\n"); + CNXK_BPHY_LOG(ERR, "Timed out waiting for a link down"); ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, true); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set link up\n"); + CNXK_BPHY_LOG(ERR, "Failed to set link up"); break; } ret = cnxk_bphy_cgx_link_cond(dev_id, i, 1); if (ret != 1) - RTE_LOG(ERR, PMD, "Timed out waiting for a link up\n"); + CNXK_BPHY_LOG(ERR, "Timed out waiting for a link up"); ret = rte_pmd_bphy_cgx_intlbk_enable(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to enable internal lbk\n"); + CNXK_BPHY_LOG(ERR, "Failed to enable internal lbk"); break; } ret = rte_pmd_bphy_cgx_intlbk_disable(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "Failed to disable internal lbk\n"); + CNXK_BPHY_LOG(ERR, "Failed to disable internal lbk"); break; } ret = rte_pmd_bphy_cgx_ptp_rx_enable(dev_id, i); /* ptp not available on RPM */ if (ret < 0 && ret != -ENOTSUP) { - RTE_LOG(ERR, PMD, "Failed to enable ptp\n"); + CNXK_BPHY_LOG(ERR, "Failed to enable ptp"); break; } ret = 0; @@ -120,27 +119,27 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id) ret = rte_pmd_bphy_cgx_ptp_rx_disable(dev_id, i); /* ptp not available on RPM */ if (ret < 0 && ret != -ENOTSUP) { - RTE_LOG(ERR, PMD, "Failed to disable ptp\n"); + CNXK_BPHY_LOG(ERR, "Failed to disable ptp"); break; } ret = 0; ret = rte_pmd_bphy_cgx_get_supported_fec(dev_id, i, &fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to get supported FEC\n"); + CNXK_BPHY_LOG(ERR, "Failed to get supported FEC"); break; } ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to set FEC to %d\n", fec); + CNXK_BPHY_LOG(ERR, "Failed to set FEC to %d", fec); break; } fec = CNXK_BPHY_CGX_ETH_LINK_FEC_NONE; ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec); if (ret) { - RTE_LOG(ERR, PMD, "Failed to disable FEC\n"); + CNXK_BPHY_LOG(ERR, "Failed to disable FEC"); break; } } diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h index 9d8d0285581b..7a7d9f6fa66f 100644 --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h @@ -26,6 +26,12 @@ extern "C" { #endif +extern int cnxk_logtype_bphy; + +#define CNXK_BPHY_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, cnxk_logtype_bphy, \ + "%s(): " fmt "\n", __func__, ## args) + /** Available message types */ enum cnxk_bphy_cgx_msg_type { /** Type used to obtain link information */ diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 3c4d79e4810e..329ac28a2736 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio.c +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c @@ -215,13 +215,13 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist) errno = 0; val = strtol(token, NULL, 10); if (errno) { - RTE_LOG(ERR, PMD, "failed to parse %s\n", token); + CNXK_GPIO_LOG(ERR, "failed to parse %s", token); ret = -errno; goto out; } if (val < 0 || val >= gpiochip->num_gpios) { - RTE_LOG(ERR, PMD, "gpio%d out of 0-%d range\n", val, + CNXK_GPIO_LOG(ERR, "gpio%d out of 0-%d range", val, gpiochip->num_gpios - 1); ret = -EINVAL; goto out; @@ -231,7 +231,7 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist) if (list[i] != val) continue; - RTE_LOG(WARNING, PMD, "gpio%d already allowed\n", val); + CNXK_GPIO_LOG(WARNING, "gpio%d already allowed", val); break; } if (i == queue) @@ -398,7 +398,7 @@ cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id, return ret; } } else { - RTE_LOG(WARNING, PMD, "using existing gpio%d\n", gpio->num); + CNXK_GPIO_LOG(WARNING, "using existing gpio%d", gpio->num); } gpiochip->gpios[num] = gpio; @@ -647,7 +647,7 @@ cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct rte_rawdev_buf *rbuf) /* get rid of last response if any */ if (gpio->rsp) { - RTE_LOG(WARNING, PMD, "previous response got overwritten\n"); + CNXK_GPIO_LOG(WARNING, "previous response got overwritten"); rte_free(gpio->rsp); } gpio->rsp = rsp; @@ -741,7 +741,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) cnxk_gpio_format_name(name, sizeof(name)); rawdev = rte_rawdev_pmd_allocate(name, sizeof(*gpiochip), rte_socket_id()); if (!rawdev) { - RTE_LOG(ERR, PMD, "failed to allocate %s rawdev\n", name); + CNXK_GPIO_LOG(ERR, "failed to allocate %s rawdev", name); return -ENOMEM; } @@ -770,7 +770,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) snprintf(buf, sizeof(buf), "%s/gpiochip%d/base", CNXK_GPIO_CLASS_PATH, gpiochip->num); ret = cnxk_gpio_read_attr_int(buf, &gpiochip->base); if (ret) { - RTE_LOG(ERR, PMD, "failed to read %s\n", buf); + CNXK_GPIO_LOG(ERR, "failed to read %s", buf); goto out; } @@ -778,20 +778,20 @@ cnxk_gpio_probe(struct rte_vdev_device *dev) snprintf(buf, sizeof(buf), "%s/gpiochip%d/ngpio", CNXK_GPIO_CLASS_PATH, gpiochip->num); ret = cnxk_gpio_read_attr_int(buf, &gpiochip->num_gpios); if (ret) { - RTE_LOG(ERR, PMD, "failed to read %s\n", buf); + CNXK_GPIO_LOG(ERR, "failed to read %s", buf); goto out; } gpiochip->num_queues = gpiochip->num_gpios; ret = cnxk_gpio_parse_allowlist(gpiochip, params->allowlist); if (ret) { - RTE_LOG(ERR, PMD, "failed to parse allowed gpios\n"); + CNXK_GPIO_LOG(ERR, "failed to parse allowed gpios"); goto out; } gpiochip->gpios = rte_calloc(NULL, gpiochip->num_gpios, sizeof(struct cnxk_gpio *), 0); if (!gpiochip->gpios) { - RTE_LOG(ERR, PMD, "failed to allocate gpios memory\n"); + CNXK_GPIO_LOG(ERR, "failed to allocate gpios memory"); ret = -ENOMEM; goto out; } @@ -851,3 +851,4 @@ RTE_PMD_REGISTER_VDEV(cnxk_gpio, cnxk_gpio_drv); RTE_PMD_REGISTER_PARAM_STRING(cnxk_gpio, "gpiochip= " "allowlist="); +RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_gpio, gpio, INFO); diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h b/drivers/raw/cnxk_gpio/cnxk_gpio.h index e62f78a7604a..336d7ac373d7 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio.h +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h @@ -5,6 +5,11 @@ #ifndef _CNXK_GPIO_H_ #define _CNXK_GPIO_H_ +extern int cnxk_logtype_gpio; + +#define CNXK_GPIO_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, cnxk_logtype_gpio, fmt "\n", ## args) + struct cnxk_gpiochip; struct cnxk_gpio { diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c index 10742b5dc48a..2f3973a7b5e6 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c +++ b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c @@ -56,7 +56,7 @@ cnxk_gpio_read_attr(char *attr, char *val) #define CNXK_GPIO_ERR_STR(err, str, ...) do { \ if (err) { \ - RTE_LOG(ERR, PMD, "%s:%d: " str " (%d)\n", __func__, __LINE__, \ + CNXK_GPIO_LOG(ERR, "%s:%d: " str " (%d)", __func__, __LINE__, \ ##__VA_ARGS__, err); \ goto out; \ } \ @@ -330,30 +330,29 @@ cnxk_gpio_selftest(uint16_t dev_id) for (i = 0; i < queues; i++) { ret = rte_rawdev_queue_conf_get(dev_id, i, &conf, sizeof(conf)); if (ret) { - RTE_LOG(ERR, PMD, - "failed to read queue configuration (%d)\n", + CNXK_GPIO_LOG(ERR, "failed to read queue configuration (%d)", ret); goto out; } - RTE_LOG(INFO, PMD, "testing queue%d (gpio%d)\n", i, conf.gpio); + CNXK_GPIO_LOG(INFO, "testing queue%d (gpio%d)", i, conf.gpio); if (conf.size != 1) { - RTE_LOG(ERR, PMD, "wrong queue size received\n"); + CNXK_GPIO_LOG(ERR, "wrong queue size received"); ret = -EIO; goto out; } ret = rte_rawdev_queue_setup(dev_id, i, NULL, 0); if (ret) { - RTE_LOG(ERR, PMD, "failed to setup queue (%d)\n", ret); + CNXK_GPIO_LOG(ERR, "failed to setup queue (%d)", ret); goto out; } gpio = gpiochip->gpios[conf.gpio]; snprintf(buf, sizeof(buf), CNXK_GPIO_PATH_FMT, gpio->num); if (!cnxk_gpio_attr_exists(buf)) { - RTE_LOG(ERR, PMD, "%s does not exist\n", buf); + CNXK_GPIO_LOG(ERR, "%s does not exist", buf); ret = -ENOENT; goto release; } @@ -371,13 +370,13 @@ cnxk_gpio_selftest(uint16_t dev_id) ret2 = ret; ret = rte_rawdev_queue_release(dev_id, i); if (ret) { - RTE_LOG(ERR, PMD, "failed to release queue (%d)\n", + CNXK_GPIO_LOG(ERR, "failed to release queue (%d)", ret); break; } if (cnxk_gpio_attr_exists(buf)) { - RTE_LOG(ERR, PMD, "%s still exists\n", buf); + CNXK_GPIO_LOG(ERR, "%s still exists", buf); ret = -EIO; break; } From patchwork Sat Feb 3 04:11:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136365 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2B1B43A57; Sat, 3 Feb 2024 05:13:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AD3E42E50; Sat, 3 Feb 2024 05:13:36 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id B45AC42E92 for ; Sat, 3 Feb 2024 05:13:31 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-295cfe8f199so1750973a91.2 for ; Fri, 02 Feb 2024 20:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933611; x=1707538411; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ReCHWYVVFgtu2iT5BN6vOCJzI4k8TVKmnR1CS2RbRyg=; b=gRCEB3yr3QDHfYvzVhmOztZFMEG5IBM9Ofw4Z/gsbIOHmjmMVHGQfzE/Kpp3pEYrdK Aw4D2FIgHktOTSa855YJPXHgGWc+HC77Zn4plmd5YuZTt6cGhaTO/sPY29uGBKQZnFwK kNyXRfExqfBRcDRadXNpzoV35248Fyz6rS6VA7kbL3BuBtFyRhfJOGBhsX6NpD9nxh+A uqlUmDxZoLCuCZL7+Bj7w39aEJ0TgEssdlRD5FoIf3RRmgFISwPaybfCgjev9d0fV4iS Riy2v1x5lpuWzP0KFAnhBsqOlzleZ2F4caA1c1kLrL08VpQ1P2g5tLwc8vIC/PXNnWRP Zxmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933611; x=1707538411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ReCHWYVVFgtu2iT5BN6vOCJzI4k8TVKmnR1CS2RbRyg=; b=n/lFBeeuoMwU7rxMrvG1Ky8RqadrNY7XoK3+Sx8UUL22jUpfsTjxhrUHwNaZwH/6iR P1RzieF5s3LiUQZ/no+CcJs5X2UQANKxPYovgqiA90p4SOASFSeGA2JsGmSIpMHfIgjq DzNo8R7EAxgOmhtEPe/HtdG2kuqRfzwLZxXdyEuAnsukznHxtqQVJuAgbPskpucskVYi 0qnf0mXQSyCfNvor4may0TuleAIwLdO+eQQB78JIGihKMN2npOh+YRVlkiw5iG/K4UA/ Om5vgbZB3NFynuXQNj4v2RRatE+C+l2+fkhdA5RZn7vwiwWPt7x2jxdw4XiL74GvJmki I1Bw== X-Gm-Message-State: AOJu0Yw51Ts27AA7bSygcjsnNbI+BgSPjvRlJXxiwJhBZ+WbBHcHH210 wKootM2FIYyhY+q8Cy2+al2gfW6e0f/B2vM5KHWBXMAFMrTUsL0BpvMmk4AXMwUlEGttMhm0408 URUM= X-Google-Smtp-Source: AGHT+IFNE/atadJBH66EajpGw01tb6tkzBBLHM+KXmr1/PSshpEIEvN+2lrD4AlVf2H5rFXpFiSHWw== X-Received: by 2002:a17:902:c94b:b0:1d9:8e37:56d6 with SMTP id i11-20020a170902c94b00b001d98e3756d6mr506944pla.40.1706933610987; Fri, 02 Feb 2024 20:13:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXAfFPt8F8xs8XIwdY0H8Gwrh+e1G6K6n3gxhEd1YYSR6tpmRZ2hx8nVEXmEcfzPReCr2ev9CsnufpF5q8/5V17vLuUSqExbKlr9GzgYHhMGAfNPqgM7CUg Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Fan Zhang Subject: [PATCH v7 10/19] crypto/scheduler: replace use of logtype PMD Date: Fri, 2 Feb 2024 20:11:43 -0800 Message-ID: <20240203041230.285599-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index 589d092d7457..95ce893f0540 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -197,8 +197,8 @@ cryptodev_scheduler_create(const char *name, return -EINVAL; } - RTE_LOG(INFO, PMD, " Sched mode param (%s = %s)\n", - param_name, param_val); + CR_SCHED_LOG(INFO, " Sched mode param (%s = %s)", + param_name, param_val); } } From patchwork Sat Feb 3 04:11:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136366 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49BE143A57; Sat, 3 Feb 2024 05:14:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57ABC42EA0; Sat, 3 Feb 2024 05:13:38 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 8B13642E92 for ; Sat, 3 Feb 2024 05:13:32 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d91397bd22so22613115ad.0 for ; Fri, 02 Feb 2024 20:13:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933612; x=1707538412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7zwXoD2valPsEkojsAY4KpK474GjhitnGorZfEmYlek=; b=hj02PPE3w7w9nNunjyjzJyqkDOO4Kv9ek5RYVmbALcLLwfCCNYwUAhskF8JE8kT3KJ 1CCKFAa6HGEYIlrDFgnmSZBhAJP4ANJ65DiAR1ISER6YC79reSTzozmeGx3mzeKO6jat jxBEc6096gXS9uDnCZFVwelmGUuLoNXhu6xrYuHktotaBJJxHUvwxysDHO9P6+2eDkX0 ZPzc/tHMsd/Zq790BiFd32QJntrlBVjnaF8SEyWqeJD6JW2EG8JfmJTh8g/E6yX9kKdt EXe/HcizvB7IsXmJ5O6pkeIEiIUeJTDhT1E1NLt4nRbDRcA1Th4Dq/dpIL3U1jpfAkwn /Kmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933612; x=1707538412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7zwXoD2valPsEkojsAY4KpK474GjhitnGorZfEmYlek=; b=OUu+8nqzwZUUodPPL8TvUE8e0I7qz4Ld1M9c0ctWANsCeXlL4qOL8BNKGv3WF+diEM VbS0RbiHG0LiH7zN+14f4nfay75661khWP9XBVNAvRmwvPa+dKw25XXae9PpJAT2DDjk dEP6smEEbeZ/VdOUPSKBGEUCW45thw+97POEOZrmUKAqlc8Qhk7mN3bB+Ef5qesuyBh7 ANpfAGuFnd7R1/GZCWMsx43OctLxE9Oh/TYBTxzrrVIzajaHwflXxlfp3Pm8JIB9mlyw ofOpAUYh/LMcZ9m+mUzO6Mip72qJt777lJD++fU5vU/EFip45/dszJKlzUj9pFXm5esI E/3w== X-Gm-Message-State: AOJu0YyHNHvkjw08qSrtvzhgbih3/5H3S1BmJiZpjtJHZCb3PZk9oPL+ Qj8NC/jErIMk8cDdEnCBW61ugauMCDB4OJmVeJgF4cfQulM8VJ5zv7j5Ac6PXW+jbcVz8WRetj1 120g= X-Google-Smtp-Source: AGHT+IFo2gQWAam13b8bI8Fo54mlkFgvy77Wziv2YAfLwY3JbjIVaL4uIbRPx26oFca5kYZBxbZ/FA== X-Received: by 2002:a17:903:110c:b0:1d9:1cb5:558f with SMTP id n12-20020a170903110c00b001d91cb5558fmr11354251plh.2.1706933611811; Fri, 02 Feb 2024 20:13:31 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWhuzZt7NsgLwDGMUU6cCo3zmLxN3FbrHWadlt5Szb6TxN4ZacWvfUJHoo5XVSMK2q+u6lG/M4RXhYRNDRCBubvRcpQUYsdtdl0SBaIKjPNfJKZcIj4NnYoUv/9JAdYq0DXcju9DLF8+oXA3UQpyo71f9+9cHoVGpXLJDwBZzVC+xjsIPz372g= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ruifeng Wang , Jerin Jacob , Zbigniew Bodek Subject: [PATCH v7 11/19] crypto/armv8: do not use PMD logtype Date: Fri, 2 Feb 2024 20:11:44 -0800 Message-ID: <20240203041230.285599-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver already has logging macros, just not used in one place. Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors") Signed-off-by: Stephen Hemminger --- drivers/crypto/armv8/rte_armv8_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c index 824a2cc7352a..026cdf5105dd 100644 --- a/drivers/crypto/armv8/rte_armv8_pmd.c +++ b/drivers/crypto/armv8/rte_armv8_pmd.c @@ -833,8 +833,8 @@ cryptodev_armv8_crypto_uninit(struct rte_vdev_device *vdev) if (name == NULL) return -EINVAL; - RTE_LOG(INFO, PMD, - "Closing ARMv8 crypto device %s on numa socket %u\n", + ARVM8_CRYPTO_LOG_INFO( + "Closing ARMv8 crypto device %s on numa socket %u", name, rte_socket_id()); cryptodev = rte_cryptodev_pmd_get_named_dev(name); From patchwork Sat Feb 3 04:11:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136367 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F88043A57; Sat, 3 Feb 2024 05:14:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1421A42EC7; Sat, 3 Feb 2024 05:13:40 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 4C5FF42E9E for ; Sat, 3 Feb 2024 05:13:33 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d932f6ccfaso22155555ad.1 for ; Fri, 02 Feb 2024 20:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933612; x=1707538412; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X8BuX/97kwrOE/xh84p/hVAmDRKQYtjMwbt7oeeaO68=; b=KpxqVNdfuKpligl6k13/KDdgj3VL7i67SYglQ1KQF0mOz7vVeUI4BiaFq4Pv9YHyO/ F64CMXEDMQNxBDTOYQJwQBF+5ATflaGM5omVejOmoaesRMSt8NAn6c3/lIxN9JhUfRXC wXwt9i39yKJPcFwHUjpxq4EZErMjvnvI903NoZKq5HpHOncoguCkjfIt0B6R4q1HQrA5 lmGn+PAxj+SLITQ6UsqPQF8cz9FUnmBzPWpsNVMVkYNmfs/mwBdjcGJgkJ4ho/ZT3VjS Y4VQeXkFB6flqMRCIvazqC62u7Z8Nd9vVxAIrCowLkk1ibReqmF4gt5Gk3MJg54wVJOt hz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933612; x=1707538412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X8BuX/97kwrOE/xh84p/hVAmDRKQYtjMwbt7oeeaO68=; b=fDKTa/1xufvLljQHe0uy4Bhmmk3pzZ0tPm/bK0LqU1Yi7Ue7n82ZRTBudtOti1wbf9 NQmzYV4QMaH+1LHp8iXePun3vq1HZ6Gh1OGJJNTCjDMTBHhTes+h+TycQMlxaxQPMVW4 7OCrL+97U8BeUTF7Eb3kHKS7JpvBnUDmGsdElkdPDC7g59rUNqjG1zcZCul3ATdIU8AY pHw57mcLhukXzMybPoJcy4Y3gXDd84pBG3HQ163KdtvMN207/eLBbva00qemjXmA93V4 tPI66/yCeENc/+pUsRdFnWTMzqhQcuGcfpQrkquXGUp1lbXPzFAFqV5FhhTJXbd9jPla M2oQ== X-Gm-Message-State: AOJu0YyU888nKOaKD/FMJ7th1WtT6WAm6ZmQxlLqdoRYDcwPfwUgsiUB IHYWOquwCMJQIZfqcWQiGqptok0NcjNTvHfIfaxCHNVL+GEaQizPAML9JObKnt56q4L7Cq03wFe YVJg= X-Google-Smtp-Source: AGHT+IEm/sfvuwKWRxlP72+4uKkjBCCUswZXR1ZhLePt14C8vCF9qiXom0Hy4Aebo9P6VmMvW7cP3w== X-Received: by 2002:a17:902:bf4c:b0:1d7:3067:aab5 with SMTP id u12-20020a170902bf4c00b001d73067aab5mr8929713pls.57.1706933612595; Fri, 02 Feb 2024 20:13:32 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUTr/SKW+juGAejVzbVc31qk66j0ILD/hKvqutOEb9E7kKVHVrm18UODqFERqO37jY+7yn0T+PT6NmxEcGpVXOum0V8rKSEMLS6ouTmuz3wx1zBliUCDgYW1pj3e56gH2UI5mGykTMqE0AVLQ== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal , Akhil Goyal Subject: [PATCH v7 12/19] crypto/caam_jr: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:45 -0800 Message-ID: <20240203041230.285599-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver has macro and logtype but not used in a couple places. Fixes: af7c9b5e9ce7 ("crypto/caam_jr: introduce basic driver") Signed-off-by: Stephen Hemminger --- drivers/crypto/caam_jr/caam_jr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c index 9c96fd21a48d..a6c0cdc93135 100644 --- a/drivers/crypto/caam_jr/caam_jr.c +++ b/drivers/crypto/caam_jr/caam_jr.c @@ -2346,7 +2346,7 @@ caam_jr_dev_init(const char *name, rte_cryptodev_pmd_probing_finish(dev); - RTE_LOG(INFO, PMD, "%s cryptodev init\n", dev->data->name); + CAAM_JR_LOG(INFO, "%s cryptodev init", dev->data->name); return 0; @@ -2386,8 +2386,7 @@ cryptodev_caam_jr_probe(struct rte_vdev_device *vdev) ret = of_init(); if (ret) { - RTE_LOG(ERR, PMD, - "of_init failed\n"); + CAAM_JR_LOG(ERR, "of_init failed"); return -EINVAL; } /* if sec device version is not configured */ From patchwork Sat Feb 3 04:11:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136368 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8617E43A57; Sat, 3 Feb 2024 05:14:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44A6E42EC6; Sat, 3 Feb 2024 05:13:41 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 1189842E9E for ; Sat, 3 Feb 2024 05:13:34 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d7881b1843so23930455ad.3 for ; Fri, 02 Feb 2024 20:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933613; x=1707538413; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w6XNvsluzYEUaPqXdnYNnznpRxZgur3JSnJK348vD6E=; b=yEn/MUuSPYwFGug2CQe3+5oZnuCC+1G6/VETQKD1PHAEK7J7b3/IxGhRaU34JAAZkx Qphz+QZi7H60Cu/qk2lB3rISE7+Qwjy4xIGY88+oaqT0Jpfr5UsJOZ7vqOta3ANoWu0/ xcgm1rXg1brjjoyj1EID3U+B6WLgwcHYgoWE+EsV/GAHGI3ZGeD8ecYnbAu2GrDzT56N zY/iOk5VHz2OcAU9kcbT9STTfcG7e4SNWY/I0aZYf23iSwguOmzBUoc+5gdP9qLqc3Jk PqIrHZTDf3Jgjrtx+7fyFRYALa2NmmHzHSOCqTUMLBYKHcBkq7BF5medpUhRRhnSXjES 4KbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933613; x=1707538413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w6XNvsluzYEUaPqXdnYNnznpRxZgur3JSnJK348vD6E=; b=a6JiYi7AyXv/b/9AAYDtfnUq9BODI0g236vsIROVAg5ODuRTjO4yfw1ertxEPHzOm/ KB/Io/y9wcVaAHSzGeBnmSWuDqRBFezJxdsCHun5Y/sAdS1sp5yaDTknFkgdNk99iKVs CvpzjLsieA4/n03LMYi+ahYSFi3DPXP8/5fkIqZ7NQ2If26guWkjN1udUydZga7IaqU/ B67bKn+C9MxpBS2sYL9A3RfTk4U5Iix+eVxgO9NAvGGQ8TiPUMGwsSJJbTH604eGGBt0 eBZEFUeHbrTWjqbbKBOGvA/tS1021ER5ZpbfW/xgC/uAHWF914vIK3cIDMCSLN/3+IJm dYag== X-Gm-Message-State: AOJu0YwwsEx6VoXcYiFpNFBWl0n8yBBSuksvxE0wUQPGD9WsGWLZst3y Z44oxFAf47C0XNWE0HfyJiTZvmed3WdztKWF3FalmyHEhLn2m3waUY00k8CKonmGvwV5xffzuSZ BO7Q= X-Google-Smtp-Source: AGHT+IEeMeaY0zxqBYjUgHkRXuqumCp4/oFPBN6plIngY+Y3d2vSl/jn2ujsyM0L3u8VjUZLuGtuQQ== X-Received: by 2002:a17:902:c94d:b0:1d9:5038:f10f with SMTP id i13-20020a170902c94d00b001d95038f10fmr6151164pla.46.1706933613330; Fri, 02 Feb 2024 20:13:33 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUb5M8+819Hre2oRFHrZowwp9UjvEzmv/ZgeW4qb26IBjLWY/W5c12cEZ6P+tKAKaPqkI8tAWi3rL/Ayi46iCTWtVE7lmPxzIPG2GW/WZ3SQoyCiaUpei91WtZLPXWoUtYu9+sn/Q== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Uttarwar , Ravi Kumar Subject: [PATCH v7 13/19] crypto/ccp: do not use PMD logtype Date: Fri, 2 Feb 2024 20:11:46 -0800 Message-ID: <20240203041230.285599-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index a5271d72273d..869399597ef1 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -194,8 +194,7 @@ cryptodev_ccp_remove(struct rte_pci_device *pci_dev) ccp_pmd_init_done = 0; - RTE_LOG(INFO, PMD, "Closing ccp device %s on numa socket %u\n", - name, rte_socket_id()); + CCP_LOG_INFO("Closing ccp device %s on numa socket %u", name, rte_socket_id()); return rte_cryptodev_pmd_destroy(dev); } @@ -279,7 +278,7 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused, }; if (ccp_pmd_init_done) { - RTE_LOG(INFO, PMD, "CCP PMD already initialized\n"); + CCP_LOG_INFO("CCP PMD already initialized"); return -EFAULT; } rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); @@ -288,11 +287,11 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused, init_params.def_p.max_nb_queue_pairs = CCP_PMD_MAX_QUEUE_PAIRS; - RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n", name, + CCP_LOG_INFO("Initialising %s on NUMA node %d", name, init_params.def_p.socket_id); - RTE_LOG(INFO, PMD, "Max number of queue pairs = %d\n", + CCP_LOG_INFO("Max number of queue pairs = %d", init_params.def_p.max_nb_queue_pairs); - RTE_LOG(INFO, PMD, "Authentication offload to %s\n", + CCP_LOG_INFO("Authentication offload to %s", ((init_params.auth_opt == 0) ? "CCP" : "CPU")); rte_pci_device_name(&pci_dev->addr, name, sizeof(name)); From patchwork Sat Feb 3 04:11:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136369 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E5CD43A57; Sat, 3 Feb 2024 05:14:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CCE242EC9; Sat, 3 Feb 2024 05:13:42 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 0125C42EA5 for ; Sat, 3 Feb 2024 05:13:34 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d7431e702dso23986495ad.1 for ; Fri, 02 Feb 2024 20:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933614; x=1707538414; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7b++1J2gLUx6NDJv7+P8qjyP68Z7y4QCIYZi5ANpsi0=; b=hlgKtwIFKS7L8naILc2+xxisTwrcC1RdRLYE2uX7ho57KwfsVecxONipg4KpdYHwcG J5I7LkSPN6CPN4db4ad+7HeQ68GAAWNv1xUd8SpTi03vT56+mRRYI7aDrmyFG3gymLey YXNWIngOoNECpetFTjHBaiuDtkJVjihy98G+IY//3hVC+TpeShYEVZL18qxXB4mbiBU1 J4VkGsupdkrRmQl/eBLmwAFbVTSQQrGgF8LLmyKyZqffmhbHstTyujBSjAB3K3dg5joC 6KAZVqgwKIlLh336uk+IJuXeL9gm91r9WvS4KdMTy0xYdEjvJhsVTZbPuxPqq8SodBHz oW8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933614; x=1707538414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7b++1J2gLUx6NDJv7+P8qjyP68Z7y4QCIYZi5ANpsi0=; b=qQpbpKyCMxuFiM7l3UOGoMDDX8tpXi1jFJCEfxX9fzVC9GcZ/D6a+V5n//YqMaBo3f 7T7lEnu4eGND+dLB58r1f4kTNFT9HYU5SqM/Lh7NSRYShUpyg4EV/VjdpOBCZcvmmMrm 0SSC26vm9RE0guC8ROAy+h7UVKCr7ngo6xx/urErGomJmKzRf54IR7yizwkHal3t79Wj TrbQUw/4PND1GZ7ZV4x8nVbfb7IBWR8T7oUrnj4Nc5knYzRzkyHe4sNFDdka36izP1iz FFBvEkRLtvg2ONQq+U8hFi/W5X6LauskN3t4IoR0h5nLSy9TV3uQJpD+ugX9HkUjRJ5R dpBA== X-Gm-Message-State: AOJu0Yx07TLrIPCsKglm5tWRno8BXqr1WDLpOL9Sq6/12WdWGK1nxEvG bwHU+aSPye811Imf5IYIt5+pXbKGqZZI7olTtmYXA+CeCMKoTdkBxMWTGfwOVDVSyWAsTJ7EmvA zMBs= X-Google-Smtp-Source: AGHT+IHrvhJXjdJJ6eYVQ8k2pDZKMm7l67V7NM/RHtP/azr0bAv02UkUUmjU6UmYdt5VJvPLjEF6GA== X-Received: by 2002:a17:902:7794:b0:1d0:b1f0:1005 with SMTP id o20-20020a170902779400b001d0b1f01005mr9268921pll.63.1706933614197; Fri, 02 Feb 2024 20:13:34 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXpzBq60qMdj7aEVOoRvyJWS3L7ZKaTPO6GnrNMqP0SXIsqcA81ovQuh8NAGWc4PyLi1QfGlCOzZYNm1z/i9FWUsP64kKKfKegR869uQRAxvKfM92bvGPve/YbkCuiHxOHYQZ6edNOAkivhOyxXZUoG11oOklaD9euFffkT2jnq+A== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal , Akhil Goyal , Ashish Jain Subject: [PATCH v7 14/19] crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:47 -0800 Message-ID: <20240203041230.285599-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A couple of messages were using RTE_LOGTYPE_PMD when dedicated logtype was already available. Fixes: fe3688ba7950 ("crypto/dpaa_sec: support event crypto adapter") Fixes: bffc7d561c81 ("crypto/dpaa2_sec: support event crypto adapter") Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 ++--- drivers/crypto/dpaa_sec/dpaa_sec.c | 30 ++++++++++----------- 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index bb5a2c629e53..1cae6c45059e 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -4153,7 +4153,7 @@ dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev, ret = dpseci_set_opr(dpseci, CMD_PRI_LOW, priv->token, qp_id, OPR_OPT_CREATE, &ocfg); if (ret) { - RTE_LOG(ERR, PMD, "Error setting opr: ret: %d\n", ret); + DPAA2_SEC_ERR("Error setting opr: ret: %d", ret); return ret; } qp->tx_vq.cb_eqresp_free = dpaa2_sec_free_eqresp_buf; @@ -4163,7 +4163,7 @@ dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev, ret = dpseci_set_rx_queue(dpseci, CMD_PRI_LOW, priv->token, qp_id, &cfg); if (ret) { - RTE_LOG(ERR, PMD, "Error in dpseci_set_queue: ret: %d\n", ret); + DPAA2_SEC_ERR("Error in dpseci_set_queue: ret: %d", ret); return ret; } @@ -4188,7 +4188,7 @@ dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev, ret = dpseci_set_rx_queue(dpseci, CMD_PRI_LOW, priv->token, qp_id, &cfg); if (ret) - RTE_LOG(ERR, PMD, "Error in dpseci_set_queue: ret: %d\n", ret); + DPAA2_SEC_ERR("Error in dpseci_set_queue: ret: %d", ret); return ret; } diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index a301e8edb2a4..e7ebcbe2af22 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -102,7 +102,7 @@ ern_sec_fq_handler(struct qman_portal *qm __rte_unused, struct qman_fq *fq, const struct qm_mr_entry *msg) { - DPAA_SEC_DP_ERR("sec fq %d error, RC = %x, seqnum = %x\n", + DPAA_SEC_DP_ERR("sec fq %d error, RC = %x, seqnum = %x", fq->fqid, msg->ern.rc, msg->ern.seqnum); } @@ -849,7 +849,7 @@ dpaa_sec_deq(struct dpaa_sec_qp *qp, struct rte_crypto_op **ops, int nb_ops) op->status = RTE_CRYPTO_OP_STATUS_SUCCESS; } else { if (dpaa_sec_dp_dump > DPAA_SEC_DP_NO_DUMP) { - DPAA_SEC_DP_WARN("SEC return err:0x%x\n", + DPAA_SEC_DP_WARN("SEC return err:0x%x", ctx->fd_status); if (dpaa_sec_dp_dump > DPAA_SEC_DP_ERR_DUMP) dpaa_sec_dump(ctx, qp); @@ -1943,8 +1943,7 @@ dpaa_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops, } } else if (unlikely(ses->qp[rte_lcore_id() % MAX_DPAA_CORES] != qp)) { - DPAA_SEC_DP_ERR("Old:sess->qp = %p" - " New qp = %p\n", + DPAA_SEC_DP_ERR("Old: sess->qp = %p New qp = %p", ses->qp[rte_lcore_id() % MAX_DPAA_CORES], qp); frames_to_send = loop; @@ -2054,7 +2053,7 @@ dpaa_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops, fd->cmd = 0x80000000 | *((uint32_t *)((uint8_t *)op + ses->pdcp.hfn_ovd_offset)); - DPAA_SEC_DP_DEBUG("Per packet HFN: %x, ovd:%u\n", + DPAA_SEC_DP_DEBUG("Per packet HFN: %x, ovd:%u", *((uint32_t *)((uint8_t *)op + ses->pdcp.hfn_ovd_offset)), ses->pdcp.hfn_ovd); @@ -2095,7 +2094,7 @@ dpaa_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops, dpaa_qp->rx_pkts += num_rx; dpaa_qp->rx_errs += nb_ops - num_rx; - DPAA_SEC_DP_DEBUG("SEC Received %d Packets\n", num_rx); + DPAA_SEC_DP_DEBUG("SEC Received %d Packets", num_rx); return num_rx; } @@ -2158,7 +2157,7 @@ dpaa_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id, NULL, NULL, NULL, NULL, SOCKET_ID_ANY, 0); if (!qp->ctx_pool) { - DPAA_SEC_ERR("%s create failed\n", str); + DPAA_SEC_ERR("%s create failed", str); return -ENOMEM; } } else @@ -2459,7 +2458,7 @@ dpaa_sec_aead_init(struct rte_cryptodev *dev __rte_unused, session->aead_key.data = rte_zmalloc(NULL, xform->aead.key.length, RTE_CACHE_LINE_SIZE); if (session->aead_key.data == NULL && xform->aead.key.length > 0) { - DPAA_SEC_ERR("No Memory for aead key\n"); + DPAA_SEC_ERR("No Memory for aead key"); return -ENOMEM; } session->aead_key.length = xform->aead.key.length; @@ -2508,7 +2507,7 @@ dpaa_sec_detach_rxq(struct dpaa_sec_dev_private *qi, struct qman_fq *fq) for (i = 0; i < RTE_DPAA_MAX_RX_QUEUE; i++) { if (&qi->inq[i] == fq) { if (qman_retire_fq(fq, NULL) != 0) - DPAA_SEC_DEBUG("Queue is not retired\n"); + DPAA_SEC_DEBUG("Queue is not retired"); qman_oos_fq(fq); qi->inq_attach[i] = 0; return 0; @@ -3483,7 +3482,7 @@ dpaa_sec_eventq_attach(const struct rte_cryptodev *dev, qp->outq.cb.dqrr_dpdk_cb = dpaa_sec_process_atomic_event; break; case RTE_SCHED_TYPE_ORDERED: - DPAA_SEC_ERR("Ordered queue schedule type is not supported\n"); + DPAA_SEC_ERR("Ordered queue schedule type is not supported"); return -ENOTSUP; default: opts.fqd.fq_ctrl |= QM_FQCTRL_AVOIDBLOCK; @@ -3518,7 +3517,7 @@ dpaa_sec_eventq_detach(const struct rte_cryptodev *dev, qman_oos_fq(&qp->outq); ret = qman_init_fq(&qp->outq, 0, &opts); if (ret) - RTE_LOG(ERR, PMD, "Error in qman_init_fq: ret: %d\n", ret); + DPAA_SEC_ERR("Error in qman_init_fq: ret: %d", ret); qp->outq.cb.dqrr = NULL; return ret; @@ -3581,8 +3580,7 @@ check_devargs_handler(__rte_unused const char *key, const char *value, { dpaa_sec_dp_dump = atoi(value); if (dpaa_sec_dp_dump > DPAA_SEC_DP_FULL_DUMP) { - DPAA_SEC_WARN("WARN: DPAA_SEC_DP_DUMP_LEVEL is not " - "supported, changing to FULL error prints\n"); + DPAA_SEC_WARN("WARN: DPAA_SEC_DP_DUMP_LEVEL is not supported, changing to FULL error prints"); dpaa_sec_dp_dump = DPAA_SEC_DP_FULL_DUMP; } @@ -3645,7 +3643,7 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev) ret = munmap(internals->sec_hw, MAP_SIZE); if (ret) - DPAA_SEC_WARN("munmap failed\n"); + DPAA_SEC_WARN("munmap failed"); close(map_fd); cryptodev->driver_id = dpaa_cryptodev_driver_id; @@ -3709,11 +3707,11 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev) dpaa_sec_get_devargs(cryptodev->device->devargs, DRIVER_DUMP_MODE); - RTE_LOG(INFO, PMD, "%s cryptodev init\n", cryptodev->data->name); + DPAA_SEC_INFO("%s cryptodev init", cryptodev->data->name); return 0; init_error: - DPAA_SEC_ERR("driver %s: create failed\n", cryptodev->data->name); + DPAA_SEC_ERR("driver %s: create failed", cryptodev->data->name); rte_free(cryptodev->security_ctx); return -EFAULT; From patchwork Sat Feb 3 04:11:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136370 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D2C043A57; Sat, 3 Feb 2024 05:14:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9048B42ED3; Sat, 3 Feb 2024 05:13:44 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 0824B42EAB for ; Sat, 3 Feb 2024 05:13:37 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d746856d85so21644915ad.0 for ; Fri, 02 Feb 2024 20:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933616; x=1707538416; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7fmLyGTEsBMDiSo/AXk6vGJW073GLmANpKukqMpxbjw=; b=CiLfYFikLOb6fjuHRfmc0CPJbF4SAfmz3zjIxlHOFdXKoPtTKaXc+aMFfoWIDZJc/9 z70WdO+3Ls8gxd8Pi5bDxt0XVzksvDIBp8ePR22cqZ8tloasgr7cZqBSOpJhdSFYZ/P8 jxFkKi4K9RBEnpt7LfT2+gfYgCzw6a/R2DRP9UeAkjubTfxIiiQI/oI2dJwYGxl1AfgB ai/ToASNX2wJ2c4tAtG4oedYWLeRUkfjLjj6D7mYR/J9pY+uX0UlgTLNWeN0FJ74y4H4 2p6Wdzxy88K3FD3IusuoD66n6AQS6aD67MG5wR/wdEoZtsuPJvAOI7525OOz03qNy4rP CyXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933616; x=1707538416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7fmLyGTEsBMDiSo/AXk6vGJW073GLmANpKukqMpxbjw=; b=iQHeFnGPsNmV3JjUZV0YaW3DZmLLk2aIox99SS9TxaedYY2BB+M1wBifba0TeMpAXc Hsfw2K24+Uiwq2z6/652eIouOeQk3nMzH9XSfSACgZk4YbhJPTm6ZskTzIOud6qpuJox W3C+yWOTdhXs1VJs8jnoJPQccDYSN8YA4SwLtoWgPOuQOmTXvVG6i3SNKGYiHdj1vU/h Al07+VPG/UrwpE9cTBURtPKWo5rcgIh+mCTaIhthbC8XoM8nnd6AZ4Zbub2Yr87A3bP+ uzRttOSLQs3MH/cD7uUX1WiFrcFyJw+inxw/KkhrnV6EQb7CKB+9v9kll15QfjoVw01I 8s+A== X-Gm-Message-State: AOJu0YxDcmTBM4V98fH0rKj4LfP/JJOz/q3AeI3n/PCkVoOA4K0SPLo3 nhpFiOHDWzWAxsc56bDvP599nWnm9XZcfs2VbT7I8YDUP1vmyWzYmzTflQ8LBXQ2c53wlEI2Jqg noUI= X-Google-Smtp-Source: AGHT+IEAmXD1WEtPOOV8yTY2K68R0IEevYHTp3EAbXPL5p1sCtNoTb/3fWNNtnk0L8+aVdbU4toL5Q== X-Received: by 2002:a17:902:6849:b0:1d9:6381:a4b3 with SMTP id f9-20020a170902684900b001d96381a4b3mr3807282pln.36.1706933616272; Fri, 02 Feb 2024 20:13:36 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW/fqhvzcWRp/sDx0CNfXffXTX0RwVrYCjzqPblGKv3LDLGIyyOS0u/zXJmuJ5WezVO/04E1g9Nd7DmEssU3kZQkJEE3YYORCKp4IIrMqlnHI8yjsTQglUSzNXc+4y+SFR8Qm0LPqYvHhHeuhCNL7vrBw== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena , Akhil Goyal Subject: [PATCH v7 15/19] event/dpaa, event/dpaa2: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:48 -0800 Message-ID: <20240203041230.285599-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use RTE_LOGTYPE_PMD. Fixes: b0f66a68ca74 ("event/dpaa: support crypto adapter") Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c | 2 +- drivers/event/dpaa2/dpaa2_eventdev.c | 4 ++-- drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 46a9b88c73ae..a8e5c3421df1 100644 --- a/drivers/event/dpaa/dpaa_eventdev.c +++ b/drivers/event/dpaa/dpaa_eventdev.c @@ -1025,7 +1025,7 @@ dpaa_event_dev_create(const char *name, const char *params, struct rte_vdev_devi eventdev->txa_enqueue = dpaa_eventdev_txa_enqueue; eventdev->txa_enqueue_same_dest = dpaa_eventdev_txa_enqueue_same_dest; - RTE_LOG(INFO, PMD, "%s eventdev added", name); + DPAA_EVENTDEV_INFO("%s eventdev added", name); /* For secondary processes, the primary has done all the work */ if (rte_eal_process_type() != RTE_PROC_PRIMARY) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index dd4e64395fe5..85c2dbd998dd 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -1141,7 +1141,7 @@ dpaa2_eventdev_create(const char *name, struct rte_vdev_device *vdev) priv->max_event_queues++; } while (dpcon_dev && dpci_dev); - RTE_LOG(INFO, PMD, "%s eventdev created\n", name); + DPAA2_EVENTDEV_INFO("%s eventdev created", name); done: event_dev_probing_finish(eventdev); @@ -1178,7 +1178,7 @@ dpaa2_eventdev_destroy(const char *name) } priv->max_event_queues = 0; - RTE_LOG(INFO, PMD, "%s eventdev cleaned\n", name); + DPAA2_EVENTDEV_INFO("%s eventdev cleaned", name); return 0; } diff --git a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c index 427aff4b1111..9d4938efe6aa 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c +++ b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c @@ -774,15 +774,15 @@ static void dpaa2_test_run(int (*setup)(void), void (*tdown)(void), int (*test)(void), const char *name) { if (setup() < 0) { - RTE_LOG(INFO, PMD, "Error setting up test %s", name); + DPAA2_EVENTDEV_INFO("Error setting up test %s", name); unsupported++; } else { if (test() < 0) { failed++; - RTE_LOG(INFO, PMD, "%s Failed\n", name); + DPAA2_EVENTDEV_INFO("%s Failed", name); } else { passed++; - RTE_LOG(INFO, PMD, "%s Passed", name); + DPAA2_EVENTDEV_INFO("%s Passed", name); } } From patchwork Sat Feb 3 04:11:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136371 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FAC743A57; Sat, 3 Feb 2024 05:14:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D243042ED9; Sat, 3 Feb 2024 05:13:45 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id DBB5F42EB5 for ; Sat, 3 Feb 2024 05:13:37 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d934c8f8f7so25260275ad.2 for ; Fri, 02 Feb 2024 20:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933617; x=1707538417; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D073T9oCR/FMcEo39lDhoqF3fnLbyykZdVZY/4anjVU=; b=gQRQ9or2sRYV2a0X+M4Xk4xoeLViJJo2jlWA9TS7xJXNxjAwzLdW6HKDAyyNZnNoeJ 7erg6oV6BeKj1YSkmAXlWd/P9pSTqbYUs8Oq8svPbZY1ScLMX4Ojk0m9ErfnuUWnQ53M rWln+CRk0vZZq04+VmWPyedwYftsrO4aOCmHt1k6qaoREMom8Ya7zRYIJMQKdeRZfXoR EZXSJabQZZTcub38ZmHPYT3/nognyI5wdxRcIcSZZt4THBIVbA6o08JsCbeonXw90gyL g211g3CMVb2UNPs40d7+B6I7JiIrbOpvQO+P4GPJa9Iwbcchj+Ueic3qjs2pKFFG1twW nLcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933617; x=1707538417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D073T9oCR/FMcEo39lDhoqF3fnLbyykZdVZY/4anjVU=; b=ljIh62T8wYXyc8haBRQqIqcecCBiPy+E7tKaYn0cck3lQ0dsMgLEBMvqS02w510N2A nYWFZhTRx8Y4v9iiqL43CM1r/QkZ9Q/cz2snyyuVYMTLPBxkbkAWd8EC06XcCpbIygN8 MzNHLNxdFExSv92Z2qkiIzUGKZeYuluL6G63kUEeuqVt3HDoSuWaotQNuymG32yfCSOj Q4iWOk7fnppq74357mLg1iSBW0OT/N9QSzpWcpaEfxkLK++StN8g157ilKzAqOBCsbWt +Wqbfrqwh6XyrXzpdcSztqw7kJniCf98TiOeGo7xZ5mmx/JY1o+kGYZotBagzVM/1xSX 1pzg== X-Gm-Message-State: AOJu0YwVgBNXaQnsUjX4FhK5vgG/I19occuUBCR+E6vmC94h9AbD3Kzw g1DsMEEnhM3tpjprAFXpfGE2IvRkVrTAyYVfeX5fM0TclIn5JW37tPOiN43bEg9zjVuZV6WAqaj e/NM= X-Google-Smtp-Source: AGHT+IFVn4185uHc+ib0FcWBC1bFs5mGh4RUy9zqf0wunMY+iUcPkIVw74z0cVu6KlYISxIfHz+opg== X-Received: by 2002:a17:902:684f:b0:1d9:72a5:53e9 with SMTP id f15-20020a170902684f00b001d972a553e9mr2967006pln.64.1706933617063; Fri, 02 Feb 2024 20:13:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW9vunjht/KCLy51u+hv89yFgzasUCdgC5LPuCBmJGZcShYYCtWk2pS3GZbFm6oPugQQpGEJW4iDfAqUdBp+3nCgckf4QAaj2vPMEL5Vjzfpchk6MvPrzSPfdA/nPVcK5LhrgIPyXS8BIh28APeY+pSHFeTK2oHXWvxkG46 Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abdullah Sevincer , Gage Eads , Timothy McDaniel Subject: [PATCH v7 16/19] event/dlb2: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:49 -0800 Message-ID: <20240203041230.285599-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver was using RTE_LOGTYPE_PMD when it had its own logtype. Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 050ace0904b4..c26f2219d40c 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -4741,9 +4741,8 @@ dlb2_parse_params(const char *params, struct rte_kvargs *kvlist = rte_kvargs_parse(params, args); if (kvlist == NULL) { - RTE_LOG(INFO, PMD, - "Ignoring unsupported parameters when creating device '%s'\n", - name); + DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'", + name); } else { int ret = rte_kvargs_process(kvlist, NUMA_NODE_ARG, set_numa_node, From patchwork Sat Feb 3 04:11:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136372 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C7243A57; Sat, 3 Feb 2024 05:14:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 223B542EDC; Sat, 3 Feb 2024 05:13:47 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 9B93542EBF for ; Sat, 3 Feb 2024 05:13:38 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d7881b1843so23930645ad.3 for ; Fri, 02 Feb 2024 20:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933618; x=1707538418; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=; b=ZheOS06X14VM0545TadRv4dpwEDjPVPNuTuwGjGXYcAK46Z2G3H7oTlq4eJS9WARXk e1dcPkAiVXH3E56yUrFAa/mWKVpin8E26K4n0v5FMNP3JMBVogkZuAqyc14IGv5cmukx M4V7DZ7Pa8tjIXhWYavdK5IgsVKJUNEhNEdmv+9qE5Mfx4DwINhHXJVpFQ1YWJNf4yVp sCZhPed3jV3JPB1mP4eW+pizprmNrvUCKZ4/SoHLGOWWiIkDLy036/ZlDMoEksyvfn/K qvLeVNclHnJT+6wO2kf8GmjKQINPGrwNe2BaUF45Vmps61gHb1ugS5g7zhtMpGUNwyOv JnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933618; x=1707538418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=; b=RyshDh0Tf0Zl+sjtLl7Qnl8oGNKH4kCK+LAjG5vB2qy2Nz56rH04TM6XB2D4v4FLG9 o6eE6s+jVN1KUJMw78saeEMorL79C/E9k2by5s3CaJryKd9i8O1dysjSmTCTWqloOymR 80QfX/3sfUbyZL7aJMGTDcFe/VXgaj02qzHpt2FjZPdM49CTJDd9vjjhNUZUNYMhNde2 /R5jg0hIECHSoLRxZJugXHx43m6RSVu1hxwlOEaL/JJPlqSlDFAUQgY+mxviTd4FXZWA MJi6NL1OaOZuoiIGaBuSZAnGG5p2SyCZ6ZTK+opsxRsstHt/Sf09RhKHgKToplmzmuJa MVQw== X-Gm-Message-State: AOJu0YyuPTmIwemtVzHbfuv7KbbWlkFFLKco/XXpUY0DBi9gOsh/GEln 8fRnpL/lB4/q/vkVjUHhpvSY+MYkUOG6EOmrbeUIg0OrfoDUHyyO+LKJvDGMWn1aa/oykg7nL5X TUmI= X-Google-Smtp-Source: AGHT+IFc0zYnHrgOlimmo1g7t8oCmdSVL5OI8Zv/a3oofHoxVnFJyvzXfPDJoSN39Q7xk6RaJYUfuw== X-Received: by 2002:a17:902:d4d2:b0:1d9:55b:6a17 with SMTP id o18-20020a170902d4d200b001d9055b6a17mr4399645plg.18.1706933617859; Fri, 02 Feb 2024 20:13:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWWAZjQhKvTb22gYFNLJ1Hu78oTUj++7k7ywP54XshSEo4MGd+hkC8g86GGRtoKaY0/fk2CB5amnONrAssT6B2aJV4= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob Subject: [PATCH v7 17/19] event/skeleton: replace logtype PMD with dynamic type Date: Fri, 2 Feb 2024 20:11:50 -0800 Message-ID: <20240203041230.285599-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 4 ++-- drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c index 7df032b7daa1..848b3be82c40 100644 --- a/drivers/event/skeleton/skeleton_eventdev.c +++ b/drivers/event/skeleton/skeleton_eventdev.c @@ -457,8 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev) const char *name; name = rte_vdev_device_name(vdev); - RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name, - rte_socket_id()); + PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d", name, rte_socket_id()); return skeleton_eventdev_create(name, rte_socket_id(), vdev); } @@ -479,3 +478,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = { }; RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd); +RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO); diff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h index 9193f45f4782..9c1ed4ec5755 100644 --- a/drivers/event/skeleton/skeleton_eventdev.h +++ b/drivers/event/skeleton/skeleton_eventdev.h @@ -8,9 +8,12 @@ #include #include +extern int skeleton_eventdev_logtype; + #ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG #define PMD_DRV_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, ">>") #else #define PMD_DRV_LOG(level, fmt, args...) do { } while (0) @@ -18,7 +21,8 @@ #endif #define PMD_DRV_ERR(fmt, args...) \ - RTE_LOG(ERR, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \ + "%s(): " fmt "\n", __func__, ## args) struct skeleton_eventdev { uintptr_t reg_base; From patchwork Sat Feb 3 04:11:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136373 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B43743A57; Sat, 3 Feb 2024 05:14:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7BCD40281; Sat, 3 Feb 2024 05:13:48 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 6DCEE42EC4 for ; Sat, 3 Feb 2024 05:13:39 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d9607f2b3aso9716015ad.0 for ; Fri, 02 Feb 2024 20:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933618; x=1707538418; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+8K8aM/eDl/j95kjfXB1e7jWZldW/p4FDToC2O3/f8Y=; b=Rbaplo1Dtlftq7gftQT6YBzQ7R4eD3Uh5nAct9AZjaYU7EgWp37Y54xAQPB+t8wKLZ V1DMg+ioe1Ck5lmXHvZ7wN0tozp9Io1pIaA49Xu+NlHXnd3nA/gi9R5zpURnojidqBUK aI8sfrru2k7cUR5S0z/D+dD6kF9vQR37O0JOHga07umeUtgq8stU4a2AYzsYCgavNMZ7 iVC36XfCsValWUb7e7A03oWknF/V3t+cqTxgh+QmwnG+lj0IHdYw3JERAjvK7S5Pbd4D GiPIByO68dqCl5tKDyWnP3xWsP/CZeYtyqKHE02VRmp8a2eTyfx035qlS2GFJf06weom 7wVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933618; x=1707538418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8K8aM/eDl/j95kjfXB1e7jWZldW/p4FDToC2O3/f8Y=; b=BiSSqJ3F20+2ZOPRA43kV4b6j7IEB4zEZpEPWI4p4gUMQYaJk6U8F+XpXz61DQmp03 cPbshGhaqb1x/eZurjNcZ6GEezQIokCfWTyi7b16AEO57X1atYLJi+HbySVQ3SPGpOJ2 b73UcereUCnmGEsFravaVDmw1GptFdQzZaowGVNrtbPqN6PYZHJqLQjyjCcWSlwllmyo iU5DYU8j6aTni2mhi6QEdW+sipG1R5kpLQInGF5nt0C05Q2K0fl7AEaTjFytWxed6iMw Ld/vQClCMP67Vu4ti02euhDoo+I1uoUdc2PEgwkILVBsjKA/Oq7PvRO7QurBevV3R9nc TVYA== X-Gm-Message-State: AOJu0Yw9NvS0cXkv3S9spGdZUfeK9tq7R85FHNL0qhHETwFnjznMGyyp Zhi3/0WV4BGfu2lVFv+TQeTyFBH4VmjYzK4R+xKXQsHRjfRtGlgThzAW9/IbgohJi2NYQAYgwiS OpbY= X-Google-Smtp-Source: AGHT+IHFbt3KdZ7M435vJxhmRsu47pWbgY6Y3CVi7jXNykbyLud2RftnQjC9NRryLJ+ZrYTWtER9BA== X-Received: by 2002:a17:902:db01:b0:1d9:907f:636d with SMTP id m1-20020a170902db0100b001d9907f636dmr329162plx.10.1706933618649; Fri, 02 Feb 2024 20:13:38 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVbIbpYOfcboI+C40W51AcGdFRxUc0aU5M5kXM+4JXijtV+96J1uOSHbJbz+VdCE2Tre5+nZVsq78Uct36F+xkgEcBTyAZXPec8wE5mqTg86rM38HX9A7f6WgHoSO+jVT6igjkRBdlL4Wb5kOeLHtR9o3JGGl1yye+pJoMSqerW8lqFsNGpm5DflwO7TB5b+5Ss Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Brian Dooley , Gowrishankar Muthukrishnan , Damian Nowak , Fan Zhang Subject: [PATCH v7 18/19] examples/fips_validation: replace use of PMD logtype Date: Fri, 2 Feb 2024 20:11:51 -0800 Message-ID: <20240203041230.285599-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace PMD with USER1 since that is already used in main Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c index b17f664a5eda..667f5da4e7d9 100644 --- a/examples/fips_validation/fips_dev_self_test.c +++ b/examples/fips_validation/fips_dev_self_test.c @@ -1032,7 +1032,7 @@ prepare_cipher_xform(uint8_t dev_id, cap = rte_cryptodev_sym_capability_get(dev_id, &cap_idx); if (!cap) { - RTE_LOG(ERR, PMD, "Failed to get capability for cdev %u\n", + RTE_LOG(ERR, USER1, "Failed to get capability for cdev %u\n", dev_id); return -EACCES; } @@ -1040,7 +1040,7 @@ prepare_cipher_xform(uint8_t dev_id, if (rte_cryptodev_sym_capability_check_cipher(cap, cipher_xform->key.length, cipher_xform->iv.length) != 0) { - RTE_LOG(ERR, PMD, "PMD %s key length %u IV length %u\n", + RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n", rte_cryptodev_name_get(dev_id), cipher_xform->key.length, cipher_xform->iv.length); @@ -1088,7 +1088,7 @@ prepare_auth_xform(uint8_t dev_id, cap = rte_cryptodev_sym_capability_get(dev_id, &cap_idx); if (!cap) { - RTE_LOG(ERR, PMD, "Failed to get capability for cdev %u\n", + RTE_LOG(ERR, USER1, "Failed to get capability for cdev %u\n", dev_id); return -EACCES; } @@ -1096,7 +1096,7 @@ prepare_auth_xform(uint8_t dev_id, if (rte_cryptodev_sym_capability_check_auth(cap, auth_xform->key.length, auth_xform->digest_length, 0) != 0) { - RTE_LOG(ERR, PMD, "PMD %s key length %u Digest length %u\n", + RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n", rte_cryptodev_name_get(dev_id), auth_xform->key.length, auth_xform->digest_length); @@ -1147,7 +1147,7 @@ prepare_aead_xform(uint8_t dev_id, cap = rte_cryptodev_sym_capability_get(dev_id, &cap_idx); if (!cap) { - RTE_LOG(ERR, PMD, "Failed to get capability for cdev %u\n", + RTE_LOG(ERR, USER1, "Failed to get capability for cdev %u\n", dev_id); return -EACCES; } @@ -1156,7 +1156,7 @@ prepare_aead_xform(uint8_t dev_id, aead_xform->key.length, aead_xform->digest_length, aead_xform->aad_length, aead_xform->iv.length) != 0) { - RTE_LOG(ERR, PMD, + RTE_LOG(ERR, USER1, "PMD %s key_len %u tag_len %u aad_len %u iv_len %u\n", rte_cryptodev_name_get(dev_id), aead_xform->key.length, @@ -1195,7 +1195,7 @@ prepare_cipher_op(struct rte_crypto_op *op, dst = (uint8_t *)rte_pktmbuf_append(mbuf, len); if (!dst) { - RTE_LOG(ERR, PMD, "Error %i: MBUF too small\n", -ENOMEM); + RTE_LOG(ERR, USER1, "Error %i: MBUF too small\n", -ENOMEM); return -ENOMEM; } @@ -1219,7 +1219,7 @@ prepare_auth_op(struct rte_crypto_op *op, uint8_t *dst; if (vec->input.len + vec->digest.len > RTE_MBUF_MAX_NB_SEGS) { - RTE_LOG(ERR, PMD, "Error %i: Test data too long (%u).\n", + RTE_LOG(ERR, USER1, "Error %i: Test data too long (%u).\n", -ENOMEM, vec->input.len + vec->digest.len); return -ENOMEM; } @@ -1229,7 +1229,7 @@ prepare_auth_op(struct rte_crypto_op *op, dst = (uint8_t *)rte_pktmbuf_append(mbuf, vec->input.len + vec->digest.len); if (!dst) { - RTE_LOG(ERR, PMD, "Error %i: MBUF too small\n", -ENOMEM); + RTE_LOG(ERR, USER1, "Error %i: MBUF too small\n", -ENOMEM); return -ENOMEM; } @@ -1274,7 +1274,7 @@ prepare_aead_op(struct rte_crypto_op *op, memcpy(iv, vec->iv.data, vec->iv.len); if (len + vec->digest.len > RTE_MBUF_MAX_NB_SEGS) { - RTE_LOG(ERR, PMD, "Error %i: Test data too long (%u).\n", + RTE_LOG(ERR, USER1, "Error %i: Test data too long (%u).\n", -ENOMEM, len + vec->digest.len); return -ENOMEM; } @@ -1282,7 +1282,7 @@ prepare_aead_op(struct rte_crypto_op *op, dst = (uint8_t *)rte_pktmbuf_append(mbuf, RTE_ALIGN_CEIL(len + vec->digest.len, 16)); if (!dst) { - RTE_LOG(ERR, PMD, "Error %i: MBUF too small\n", -ENOMEM); + RTE_LOG(ERR, USER1, "Error %i: MBUF too small\n", -ENOMEM); return -ENOMEM; } @@ -1303,7 +1303,7 @@ prepare_aead_op(struct rte_crypto_op *op, dst = rte_malloc(NULL, len, 16); if (!dst) { - RTE_LOG(ERR, PMD, "Error %i: Not enough memory\n", -ENOMEM); + RTE_LOG(ERR, USER1, "Error %i: Not enough memory\n", -ENOMEM); return -ENOMEM; } @@ -1474,24 +1474,24 @@ run_single_test(uint8_t dev_id, ret = test_ops->prepare_xform(dev_id, &xform, vec, dir, key, negative_test); if (ret < 0) { - RTE_LOG(ERR, PMD, "Error %i: Prepare Xform\n", ret); + RTE_LOG(ERR, USER1, "Error %i: Prepare Xform\n", ret); return ret; } sess = rte_cryptodev_sym_session_create(dev_id, &xform, env->sess_pool); if (!sess) { - RTE_LOG(ERR, PMD, "Error %i: Init session\n", ret); + RTE_LOG(ERR, USER1, "Error %i: Init session\n", ret); return ret; } ret = test_ops->prepare_op(env->op, env->mbuf, sess, dir, vec); if (ret < 0) { - RTE_LOG(ERR, PMD, "Error %i: Prepare op\n", ret); + RTE_LOG(ERR, USER1, "Error %i: Prepare op\n", ret); return ret; } if (rte_cryptodev_enqueue_burst(dev_id, 0, &env->op, 1) < 1) { - RTE_LOG(ERR, PMD, "Error: Failed enqueue\n"); + RTE_LOG(ERR, USER1, "Error: Failed enqueue\n"); return ret; } @@ -1622,7 +1622,7 @@ fips_dev_self_test(uint8_t dev_id, ret = fips_dev_auto_test_init(dev_id, &env); if (ret < 0) { - RTE_LOG(ERR, PMD, "Failed to init self-test for PMD %u\n", + RTE_LOG(ERR, USER1, "Failed to init self-test for PMD %u\n", dev_id); return ret; } @@ -1644,7 +1644,7 @@ fips_dev_self_test(uint8_t dev_id, negative_test = 0; } - RTE_LOG(INFO, PMD, "Testing (ID %u) %s %s%s...\n", + RTE_LOG(INFO, USER1, "Testing (ID %u) %s %s%s...\n", i, vec->name, j == self_test_dir_enc_auth_gen ? @@ -1658,18 +1658,18 @@ fips_dev_self_test(uint8_t dev_id, if (!negative_test) break; ret = -1; - RTE_LOG(ERR, PMD, "PMD %u Failed test %s %s\n", + RTE_LOG(ERR, USER1, "PMD %u Failed test %s %s\n", dev_id, vec->name, j == self_test_dir_enc_auth_gen ? "Encrypt" : "Decrypt"); goto error_exit; case -EACCES: - RTE_LOG(ERR, PMD, "Not supported by %s. Skip\n", + RTE_LOG(ERR, USER1, "Not supported by %s. Skip\n", rte_cryptodev_name_get(dev_id)); ret = 0; break; default: - RTE_LOG(ERR, PMD, "PMD %u Failed test %s %s\n", + RTE_LOG(ERR, USER1, "PMD %u Failed test %s %s\n", dev_id, vec->name, j == self_test_dir_enc_auth_gen ? "Encrypt" : "Decrypt"); @@ -1682,7 +1682,7 @@ fips_dev_self_test(uint8_t dev_id, fips_dev_auto_test_uninit(dev_id, &env); if (ret == 0) { - RTE_LOG(INFO, PMD, "PMD %u finished self-test successfully\n", + RTE_LOG(INFO, USER1, "PMD %u finished self-test successfully\n", dev_id); } From patchwork Sat Feb 3 04:11:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136374 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22CD143A57; Sat, 3 Feb 2024 05:14:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27E0342EE7; Sat, 3 Feb 2024 05:13:50 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 123F242EC6 for ; Sat, 3 Feb 2024 05:13:40 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d751bc0c15so23953555ad.2 for ; Fri, 02 Feb 2024 20:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933619; x=1707538419; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3pS2Y6r2gbrtf7dpapzBhdwZSh2cYS5qc7PuaEm6BOg=; b=UCom0iURL1uy7JTMcvcLw8JXw0dNKJKaqxP3MKigx2eoQOzr7kU5S7r+UMUOLVJHGH JPtSCONtVSNWqtUqyKcIKTU8BYN6mF9/a4h16hTALX+LSzcTf38D66xEpEO6TnWD6PPT jbF1s1ozhGSEvzh5eqNxuL6Lxq+01bnJZZMLCLcWxqSzpqNfThb6/e7qY09rBcGjJE9r ijIrZz5kQneRHDg8CzBoX/9SbijzWyA7s5Ds4yIeaooaPqJxWQRcc9Exv6KEzmAYUGNC TAUju+YT5zdSWQY6RxV9hxph70QX2sAF4y9gSYgU5gLQCQHUsKEgp1/o0gtNrqXSDSlD J2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933619; x=1707538419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3pS2Y6r2gbrtf7dpapzBhdwZSh2cYS5qc7PuaEm6BOg=; b=F8MMkQGr3ZTEodY9jO+HIUMCFUZGtBkNy+HFW2DhQPKl4lY84pL0EX7CBQ99Ylol2X ixxaB86Dk1Jf17WeaRjukVE85hgZMR5WUmnu9cjkUVRXT5UbAtAGBnyz5fT+AXqDDzdH uQinTW85g417gklz6X0B2xFxUL0qjR6aI92KqEiy7vcMrppmLCQlf25plTtHoPP8d+8C Rw5jaQsveYc9+r2DcY1FLY4yYP743tZ8pvtjWTf4PwMM5rCH15UQr9btEzh4fRRQdQTM sVCSYE9BJLwSWHESal+SeowF0tHh0EHfFERMfm7Va6Dbl6VzXWBvKd5m3Za4xDOI4BwU sxkA== X-Gm-Message-State: AOJu0YzvA3PdDg1erFK76BD8jn99yXBr5Wc0umdd8QrqlT1oxwA0ENcr oPi0tnpfNFTe7h8ryZYRpCxhRN6LfFdHG2lsZxkVDulwoEyQd8gUwTxPyPcuremXgjYf5g33/wg hBE8= X-Google-Smtp-Source: AGHT+IG1/aKWMB5MsXlueguqYvP8hykgF4AW5jf70VrKE381ptozct+6HMvXh5C/FDQP7O5z7lKmcA== X-Received: by 2002:a17:902:7c8d:b0:1d9:4871:75c5 with SMTP id y13-20020a1709027c8d00b001d9487175c5mr6238321pll.17.1706933619351; Fri, 02 Feb 2024 20:13:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v7 19/19] log: remove PMD log type Date: Fri, 2 Feb 2024 20:11:52 -0800 Message-ID: <20240203041230.285599-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org All uses of PMD logtype in core DPDK have been replaced by dynamic types. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 2 +- lib/log/rte_log.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 4cb07121b915..255f757d94cc 100644 --- a/lib/log/log.c +++ b/lib/log/log.c @@ -352,7 +352,7 @@ struct logtype { static const struct logtype logtype_strings[] = { {RTE_LOGTYPE_EAL, "lib.eal"}, - {RTE_LOGTYPE_PMD, "pmd"}, + {RTE_LOGTYPE_USER1, "user1"}, {RTE_LOGTYPE_USER2, "user2"}, {RTE_LOGTYPE_USER3, "user3"}, diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index 47ab63635e0d..fbc0df74ca6a 100644 --- a/lib/log/rte_log.h +++ b/lib/log/rte_log.h @@ -32,7 +32,7 @@ extern "C" { /* was RTE_LOGTYPE_RING */ /* was RTE_LOGTYPE_MEMPOOL */ /* was RTE_LOGTYPE_TIMER */ -#define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. */ + /* was RTE_LOGTYPE_PMD */ /* was RTE_LOGTYPE_HASH */ /* was RTE_LOGTYPE_LPM */ /* was RTE_LOGTYPE_KNI */