Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136059/?format=api
{ "id": 136059, "url": "http://patches.dpdk.org/api/patches/136059/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240123114053.172189-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240123114053.172189-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240123114053.172189-3-bruce.richardson@intel.com", "date": "2024-01-23T11:40:49", "name": "[2/6] net/i40e: reduce code indentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "27a8757d60af730e4af27e1a233a9d2048b68665", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240123114053.172189-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30884, "url": "http://patches.dpdk.org/api/series/30884/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30884", "date": "2024-01-23T11:40:47", "name": "remove incorrect code for loading 16B descriptors", "version": 1, "mbox": "http://patches.dpdk.org/series/30884/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136059/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/136059/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89754439A7;\n\tTue, 23 Jan 2024 12:41:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD8F9410FB;\n\tTue, 23 Jan 2024 12:41:19 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by mails.dpdk.org (Postfix) with ESMTP id 88ECC410F1\n for <dev@dpdk.org>; Tue, 23 Jan 2024 12:41:16 +0100 (CET)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jan 2024 03:41:16 -0800", "from silpixa00400957.ir.intel.com (HELO\n silpixa00401385.ir.intel.com) ([10.237.214.26])\n by orviesa002.jf.intel.com with ESMTP; 23 Jan 2024 03:41:15 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1706010077; x=1737546077;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=GOOrFpcPtArETrpFtX6CcH467KUXneg+n2Qe4vgNksw=;\n b=LdQNhFmenlLpRlig09cyeYAtv8q8LED2rHVEI/iYWTNHQe3TmQMmU/Yd\n AqEp0Ldz74R/B7+f3dxPZ44YIn+n2oY9WXukwxXuoC8S2lv6omYl5BU75\n UsAcPayZhy8gc6ttyjZhTTlZA8IjlrW9Il4Sl0PIgFRvP1OBMrK+17Nzt\n UMlybgnp+qdT7BafOza8bvYD3Zz/niNuZ5NRF6tCAJRQ93pLg/yeL/rU3\n H8Es0mxe+P1jlpxycH62mdnIdUYuyrgjZjMzQfqWmrL7RngLv1mE6yjiy\n zyJSyehhugQaHnRxOCnVIIx77sCqC6wCvi1oNBtatzOFl8GojE5FTq3hD g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10961\"; a=\"22965764\"", "E=Sophos;i=\"6.05,214,1701158400\"; d=\"scan'208\";a=\"22965764\"", "E=Sophos;i=\"6.05,214,1701158400\"; d=\"scan'208\";a=\"27722321\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 2/6] net/i40e: reduce code indentation", "Date": "Tue, 23 Jan 2024 11:40:49 +0000", "Message-Id": "<20240123114053.172189-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240123114053.172189-1-bruce.richardson@intel.com>", "References": "<20240123114053.172189-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "With the removal of the #ifdef block for 16-byte descriptor loads, the\ndo { } while(0) around the descriptor load block becomes unnecessary.\nRemoving that do-while allows us to reduce indentation level of the code\nby one tab, and makes the function that little cleaner and clearer to\nread.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_avx2.c | 51 +++++++++++++--------------\n 1 file changed, 24 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\nindex ce87e185f0..19cf0ac718 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n@@ -276,33 +276,30 @@ _recv_raw_pkts_vec_avx2(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t\t\t\t_mm256_loadu_si256((void *)&sw_ring[i + 4]));\n #endif\n \n-\t\t__m256i raw_desc0_1, raw_desc2_3, raw_desc4_5, raw_desc6_7;\n-\t\tdo {\n-\t\t\tconst __m128i raw_desc7 = _mm_load_si128((void *)(rxdp + 7));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc6 = _mm_load_si128((void *)(rxdp + 6));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc5 = _mm_load_si128((void *)(rxdp + 5));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc4 = _mm_load_si128((void *)(rxdp + 4));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc3 = _mm_load_si128((void *)(rxdp + 3));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc2 = _mm_load_si128((void *)(rxdp + 2));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc1 = _mm_load_si128((void *)(rxdp + 1));\n-\t\t\trte_compiler_barrier();\n-\t\t\tconst __m128i raw_desc0 = _mm_load_si128((void *)(rxdp + 0));\n-\n-\t\t\traw_desc6_7 = _mm256_inserti128_si256(\n-\t\t\t\t\t_mm256_castsi128_si256(raw_desc6), raw_desc7, 1);\n-\t\t\traw_desc4_5 = _mm256_inserti128_si256(\n-\t\t\t\t\t_mm256_castsi128_si256(raw_desc4), raw_desc5, 1);\n-\t\t\traw_desc2_3 = _mm256_inserti128_si256(\n-\t\t\t\t\t_mm256_castsi128_si256(raw_desc2), raw_desc3, 1);\n-\t\t\traw_desc0_1 = _mm256_inserti128_si256(\n-\t\t\t\t\t_mm256_castsi128_si256(raw_desc0), raw_desc1, 1);\n-\t\t} while (0);\n+\t\tconst __m128i raw_desc7 = _mm_load_si128((void *)(rxdp + 7));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc6 = _mm_load_si128((void *)(rxdp + 6));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc5 = _mm_load_si128((void *)(rxdp + 5));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc4 = _mm_load_si128((void *)(rxdp + 4));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc3 = _mm_load_si128((void *)(rxdp + 3));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc2 = _mm_load_si128((void *)(rxdp + 2));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc1 = _mm_load_si128((void *)(rxdp + 1));\n+\t\trte_compiler_barrier();\n+\t\tconst __m128i raw_desc0 = _mm_load_si128((void *)(rxdp + 0));\n+\n+\t\tconst __m256i raw_desc6_7 = _mm256_inserti128_si256(\n+\t\t\t\t_mm256_castsi128_si256(raw_desc6), raw_desc7, 1);\n+\t\tconst __m256i raw_desc4_5 = _mm256_inserti128_si256(\n+\t\t\t\t_mm256_castsi128_si256(raw_desc4), raw_desc5, 1);\n+\t\tconst __m256i raw_desc2_3 = _mm256_inserti128_si256(\n+\t\t\t\t_mm256_castsi128_si256(raw_desc2), raw_desc3, 1);\n+\t\tconst __m256i raw_desc0_1 = _mm256_inserti128_si256(\n+\t\t\t\t_mm256_castsi128_si256(raw_desc0), raw_desc1, 1);\n \n \t\tif (split_packet) {\n \t\t\tint j;\n", "prefixes": [ "2/6" ] }