Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135326/?format=api
{ "id": 135326, "url": "http://patches.dpdk.org/api/patches/135326/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231219032826.4814-3-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231219032826.4814-3-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231219032826.4814-3-sivaprasad.tummala@amd.com", "date": "2023-12-19T03:28:21", "name": "[v2,2/6] examples/l3fwd-power: fix lcore ID restriction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ace23df749045070bf72997d09990162f311c01c", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231219032826.4814-3-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 30610, "url": "http://patches.dpdk.org/api/series/30610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30610", "date": "2023-12-19T03:28:19", "name": "fix lcore ID restriction", "version": 2, "mbox": "http://patches.dpdk.org/series/30610/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135326/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135326/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8CB1F4373B;\n\tTue, 19 Dec 2023 04:29:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A3B942E06;\n\tTue, 19 Dec 2023 04:29:04 +0100 (CET)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam04on2067.outbound.protection.outlook.com [40.107.100.67])\n by mails.dpdk.org (Postfix) with ESMTP id 6365A42DE1;\n Tue, 19 Dec 2023 04:29:02 +0100 (CET)", "from CYZPR12CA0008.namprd12.prod.outlook.com (2603:10b6:930:8b::9)\n by LV2PR12MB5774.namprd12.prod.outlook.com (2603:10b6:408:17a::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec\n 2023 03:28:57 +0000", "from CY4PEPF0000EE32.namprd05.prod.outlook.com\n (2603:10b6:930:8b:cafe::94) by CYZPR12CA0008.outlook.office365.com\n (2603:10b6:930:8b::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.39 via Frontend\n Transport; Tue, 19 Dec 2023 03:28:56 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:28:56 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.34; Mon, 18 Dec 2023 21:28:52 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=X658vr9L2efTHCyVqrcg5n5yf8WgtHzGVGMdp/vyXFW+KpK2EWvfaK1PglzrX73+BdxGgnlfK8FSGxDv/OyXaAuPIOkfb7oTpFPDzVLrIkrZqV6BLP6XHJ+YIBgMF7M9gbHgcgk4tvZtovl+PsCU0y086ymzG8zwKiozmYwhgnq57C/XxvQYSg/5pwdNOLZ9xR9iRT4u38Uoohev6qiT61g7wTHSIp6STrrutVahNUkHiyeaGRZ+IdBcGCIlEMerXXj1XFQjgcOrzLcEyaPZsBJVxUaiSjGXmYD00WJUo/8UJicliQ0l+8bx0F8bF7go3U1vr/rP8ZWP9qTmTcOg0g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=WTX/dfAUWtPnrTeKM7XgkKOI+3C0YiQsao9l/nyLGXE=;\n b=j7DSnGHEtWylTJLR0CTNafMx9oRgfCkibud2fjCzw/aLItURXMmJ5bLSRKCDpAmhR9mo0PKyOLxGD4BX6JRXWC+OiDQBRDsDKnCx/Y9B52Kc4eo7e/oGg/N/e5BFN0gbf3nD9KX6CA7CCrzCsfJByjxfAquUwQZkFHyGcIFAHRuPnn9MDy0NXmqIaOdW/I6nJXiRFAYsNycbCy/8yeqZg2HKLdp7GaXdbtPRFDhW5Qmjh+NjoxwltJcs5CmNCcnI+KmsFoXnavuoDgbyG0+YxG+omxsxgDVZRCR358NvjrGIIASMABzJDEdV4qxGR8HVSZbFMWF63SA59IqtEZB5bg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WTX/dfAUWtPnrTeKM7XgkKOI+3C0YiQsao9l/nyLGXE=;\n b=qy09cXNTnUED5JEpH1stKy9ruWQvTqrDoNK4aK2SQvEhR0CZChf1UUrsyPvEJpd3k3rvjdV6vH+OeTSp8ae/6zci/3KhH8xof3BH5507UF98hSTbnBCm8KdoNLB7rtYuRYGQ7aP+dTnd/zJ4WK6jO7wNp2CcawMNnsIqKJ/5l9g=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH v2 2/6] examples/l3fwd-power: fix lcore ID restriction", "Date": "Tue, 19 Dec 2023 04:28:21 +0100", "Message-ID": "<20231219032826.4814-3-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231219032826.4814-1-sivaprasad.tummala@amd.com>", "References": "<20231218074905.42749-1-sivaprasad.tummala@amd.com>\n <20231219032826.4814-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000EE32:EE_|LV2PR12MB5774:EE_", "X-MS-Office365-Filtering-Correlation-Id": "91f461e3-7ce1-45f3-bd75-08dc0042a237", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n VpveME/uVpd3Ed3kJFaWphT/9HuDzBXkwy7NQ8tXqLPrW8DD5t0v38mW5TUXxRIQuUtp9eD67gklPD5Bmpa8DXgCB4dUpky1XDA9gUlb/7MD28kdAu1oJDhQOtzzCnDU/OEedQdBKrsw84uwvilXd/a423osq3v5w14Q2c4emAPvVEUiGXPkoTUC7MFELnNrXBygUK+SZY1V7ElH+LU3WS1lZhMevQugh1QfIAtgKObpalMicURgc+NThGwA5p5TskmddoVntpSCU5FFwmI2RYjE4JMGulyfbje6r3+T2vEGKe0fCvBK4Cl2xtcO/Vsze3IyHtRITY6hUsRbZ81EypjMRe+Lf53q10I+34oZjJnkzTCbaA1CM6MPv8PTih1VTdd6/i2KxWVZzGnMLXU9fzMP179UZBOtxw5O/4TjO2D2dM68d2q1Rz10gF/cozKKSS0UfH6LmmKa9VRVCF3JhDOALZMGdTxC1gHIPaGkP3el7/Yu56Bvr0MmNiQH4zSb2oWVpplfTP65uUzUKLAry86CTMi6U+Ny/Uze46fynty/wEN5VbLBPhBU8pnbzFPhu045UtKvpej8kQb7qQfAE0scVXGyP/7C3r54cf2LaJdTGAO2zerKH3w7dmWD+8ZP3ukXW0m4+zcvHb05oL7YJuhYlunPryyUCrILFKdSmJuqjfK0jH29USVg6s+B8P7o3byeX3fpI9pL2nAML9PF1IriAAoW/uoHnMRJDt5Ro6gjIldslMDGU0oBhsABkmOLsTmmjsxRzoiG2iy5xK0P+g2KXPF+8/OCOReiL6x5bkEujNRTwP+LoJlrbYHzrvs/", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(376002)(396003)(136003)(39860400002)(346002)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(40470700004)(36840700001)(46966006)(40460700003)(1076003)(2616005)(426003)(26005)(336012)(16526019)(36860700001)(4326008)(8936002)(83380400001)(47076005)(5660300002)(44832011)(8676002)(41300700001)(2906002)(6666004)(478600001)(316002)(70586007)(70206006)(54906003)(110136005)(81166007)(356005)(82740400003)(86362001)(36756003)(40480700001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Dec 2023 03:28:56.8077 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 91f461e3-7ce1-45f3-bd75-08dc0042a237", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000EE32.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "LV2PR12MB5774", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently the config option allows lcore IDs up to 255,\nirrespective of RTE_MAX_LCORES and needs to be fixed.\n\nThe patch allows config options based on DPDK config.\n\nFixes: f88e7c175a68 (\"examples/l3fwd-power: add high/regular perf cores options\")\nCc: radu.nicolau@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\n---\n examples/l3fwd-power/main.c | 16 +++++++++-------\n examples/l3fwd-power/main.h | 2 +-\n 2 files changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex f4adcf41b5..bb9da36455 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -1399,8 +1399,8 @@ main_legacy_loop(__rte_unused void *dummy)\n static int\n check_lcore_params(void)\n {\n-\tuint8_t queue, lcore;\n-\tuint16_t i;\n+\tuint8_t queue;\n+\tuint16_t lcore, i;\n \tint socketid;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n@@ -1411,13 +1411,13 @@ check_lcore_params(void)\n \t\t}\n \t\tlcore = lcore_params[i].lcore_id;\n \t\tif (!rte_lcore_is_enabled(lcore)) {\n-\t\t\tprintf(\"error: lcore %hhu is not enabled in lcore \"\n+\t\t\tprintf(\"error: lcore %hu is not enabled in lcore \"\n \t\t\t\t\t\t\t\"mask\\n\", lcore);\n \t\t\treturn -1;\n \t\t}\n \t\tif ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&\n \t\t\t\t\t\t\t(numa_on == 0)) {\n-\t\t\tprintf(\"warning: lcore %hhu is on socket %d with numa \"\n+\t\t\tprintf(\"warning: lcore %hu is on socket %d with numa \"\n \t\t\t\t\t\t\"off\\n\", lcore, socketid);\n \t\t}\n \t\tif (app_mode == APP_MODE_TELEMETRY && lcore == rte_lcore_id()) {\n@@ -1469,7 +1469,7 @@ static int\n init_lcore_rx_queues(void)\n {\n \tuint16_t i, nb_rx_queue;\n-\tuint8_t lcore;\n+\tuint16_t lcore;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n@@ -1661,6 +1661,8 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint i;\n \tunsigned size;\n+\tunsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS,\n+\t\t\t\t\t255, RTE_MAX_LCORE};\n \n \tnb_lcore_params = 0;\n \n@@ -1681,7 +1683,7 @@ parse_config(const char *q_arg)\n \t\t\terrno = 0;\n \t\t\tint_fld[i] = strtoul(str_fld[i], &end, 0);\n \t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] >\n-\t\t\t\t\t\t\t\t\t255)\n+\t\t\t\t\t\t\t\t\tmax_fld[i])\n \t\t\t\treturn -1;\n \t\t}\n \t\tif (nb_lcore_params >= MAX_LCORE_PARAMS) {\n@@ -1694,7 +1696,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n \t\t\t\t(uint8_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n-\t\t\t\t(uint8_t)int_fld[FLD_LCORE];\n+\t\t\t\t(uint16_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\n \t}\n \tlcore_params = lcore_params_array;\ndiff --git a/examples/l3fwd-power/main.h b/examples/l3fwd-power/main.h\nindex 258de98f5b..4e5fd3b6d6 100644\n--- a/examples/l3fwd-power/main.h\n+++ b/examples/l3fwd-power/main.h\n@@ -10,7 +10,7 @@\n struct lcore_params {\n \tuint16_t port_id;\n \tuint8_t queue_id;\n-\tuint8_t lcore_id;\n+\tuint16_t lcore_id;\n } __rte_cache_aligned;\n \n extern struct lcore_params *lcore_params;\n", "prefixes": [ "v2", "2/6" ] }