From patchwork Tue Dec 19 03:28:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135325 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA8EA4373B; Tue, 19 Dec 2023 04:29:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C23E142DF4; Tue, 19 Dec 2023 04:29:02 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by mails.dpdk.org (Postfix) with ESMTP id F0A0D402BC; Tue, 19 Dec 2023 04:29:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UpfQe3f9pe0vQhNTG80yEr34lcCitnHugtUM6LaMTQUUEvHsi4iJRg1uqPZsQT1erv6xuwQRPS2mVAPUcA5t1VuOwp3Oxi/DL9RJf0tOzFSdWVbNtMMd844XW9r/j4n06+d+4igeLsUsQ65DEXMEcIgQjjMePinkNqOM/rDJgsAnOyEhDF4fdMSRPOAc67vEqIgV2uH2fmF3QTyWlKQo0YJOLZmNpvFNcQ0AywUHH3lyLBrsyoJ6AF7oLg4sv7J57ZncRv2g0HhW3wmm0cO2RpcK5nBC9TyeAQkvBe2JVEAtaNGcQHRrODDM3l3GEl67VrtsbvRw2rFCjAgye611yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2gkc8e+pIo+/5kSziAJvg2TEsTkQfP2xYb3lkoRtbjA=; b=YwNH1M5aums33dl9EJ7WC93Dt5ueFHcGM65oJRbykKvoAlN1C5e/WcRroN7g74G93qxmpKRdC0V9M1lEWRsLap6LojqkAo80pTRDtUGCvq0c27X6rtwnrvfnLrG2cP95rkq4I+02qgi6FUsiQwVhyTOslNsknskI5arDg9F3KqJogJdRwmfgaKdjvVyBZEHeyXvJm/snod5uNsTn3v0AWzv6PgZQtjyCk7KgwfSLjbNu3VdHjGysp0VYhbBDanE5c0yue9MlnDJBCoS+7iWvjyx/PQwtv2Q1aIJLKRQolc+Ib0wGvlzehatfnVtGPlbxoS3qV8HYE3ATq1Rmeaz8dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gkc8e+pIo+/5kSziAJvg2TEsTkQfP2xYb3lkoRtbjA=; b=MGv8obfO31+6fCVLi7Gyv3o+petf37RFWVEtwsmk8Vxp9GAEAGSZddFrBBibXmI6hJ178iCQEn9BmmV4ebF5rgXogQ4+IGOnJVh+9SRWRY0S5TaY19o+Uty4N/bUXkCLrN5wFJcQGLUiIOABSlIt6k89F6UReH7lWNMz/YE5TxI= Received: from CYZPR12CA0012.namprd12.prod.outlook.com (2603:10b6:930:8b::21) by MW4PR12MB6976.namprd12.prod.outlook.com (2603:10b6:303:20a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:28:56 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:930:8b:cafe::ce) by CYZPR12CA0012.outlook.office365.com (2603:10b6:930:8b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:28:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:28:56 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:28:48 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:20 +0100 Message-ID: <20231219032826.4814-2-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|MW4PR12MB6976:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d36e727-aa89-4fef-382b-08dc0042a1d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RoYduZsd3AqfKdm3qKQMcHtIDYRwmgxib/9GSJ7cLKgif62k1YzEfPND+ZCEtMEug82E+Uzv1YizoH5D7rNIkFS4teMZOdVRsa9YWH4t2iqoLiauGJikKHlRVGhvDXCCwlKmiInxA4F4vT3PBmgQCyWaDgfW20fHN6aIeE6pj8SYbEzRiSMWjJS4voEq3+BPIhHF0d3AeahwrXFcNYxsc4dlYw3AGSEBB6rBjs7q7A/7nNAOWnjQqMl1hYNAQuw5m8XtJ5i6Uwqs2/tzyRdLVYYDUsaEqb2Run3wsLQZ/PiWhSAlivehXrE/exy6UDWsitYhQv/luJDnVYxr/DJE/JOcB0RYVw/Rc757p07wvJvHxKQHXxKnS9HSq3tBpYThlGWALmft5DDlhvBqo2dxWgixd9ZifnCiirFq3HaycfpunVu5eHzferlaacu5AlUlDjerVyXoPRrW+hJTOLNNMxQphLTxrpHvxo28TpGcu7Ih+GzXut4jvNhz7aGzqaQbUyrdXrmaUAJj5cD71ZXGXk7irD9DXZnwRni7MOwWqxCB6bCJP/j4E1uf/ujeTBVw7fhPdT4kEc6E+sla3wgkV3PZh/g2XsbyN3FwO0+R2UdU3fY+yOLXktiIRhpfXAFGfOXdkFptPT9JHaMmgKozpqwfMW+8BVbq/QlR3wnK6q4e9s/E2WZ3jQ4zlrpA8zTZOK8QnKRSej3tpOBs7U7XwwXUlMhk9X3MKHyySyVO7Njal1SBhdJW9tiR6qhEYq6Ztunht+6KU6ONAbtiLI5GuLrPx8SihkggiDrbbqoOCEBROgdEee5fMeloGpyTOYmr X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(136003)(39860400002)(346002)(230173577357003)(230273577357003)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(40470700004)(36840700001)(46966006)(40460700003)(6666004)(1076003)(2616005)(26005)(426003)(336012)(16526019)(4326008)(36860700001)(83380400001)(47076005)(5660300002)(44832011)(41300700001)(478600001)(2906002)(54906003)(70586007)(70206006)(8676002)(8936002)(316002)(110136005)(36756003)(82740400003)(356005)(81166007)(86362001)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:28:56.1358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d36e727-aa89-4fef-382b-08dc0042a1d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6976 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala Acked-by: Konstantin Ananyev --- examples/l3fwd/main.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 3bf28aec0c..ed116da09c 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -99,7 +99,7 @@ struct parm_cfg parm_config; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -292,8 +292,8 @@ setup_l3fwd_lookup_tables(void) static int check_lcore_params(void) { - uint8_t queue, lcore; - uint16_t i; + uint8_t queue; + uint16_t i, lcore; int socketid; for (i = 0; i < nb_lcore_params; ++i) { @@ -304,12 +304,12 @@ check_lcore_params(void) } lcore = lcore_params[i].lcore_id; if (!rte_lcore_is_enabled(lcore)) { - printf("error: lcore %hhu is not enabled in lcore mask\n", lcore); + printf("error: lcore %hu is not enabled in lcore mask\n", lcore); return -1; } if ((socketid = rte_lcore_to_socket_id(lcore) != 0) && (numa_on == 0)) { - printf("warning: lcore %hhu is on socket %d with numa off \n", + printf("warning: lcore %hu is on socket %d with numa off\n", lcore, socketid); } } @@ -359,7 +359,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -500,6 +500,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int i; unsigned size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -518,7 +520,8 @@ parse_config(const char *q_arg) for (i = 0; i < _NUM_FLD; i++){ errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); - if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) + if (errno != 0 || end == str_fld[i] || int_fld[i] > + max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -531,7 +534,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; From patchwork Tue Dec 19 03:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135326 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CB1F4373B; Tue, 19 Dec 2023 04:29:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A3B942E06; Tue, 19 Dec 2023 04:29:04 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2067.outbound.protection.outlook.com [40.107.100.67]) by mails.dpdk.org (Postfix) with ESMTP id 6365A42DE1; Tue, 19 Dec 2023 04:29:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X658vr9L2efTHCyVqrcg5n5yf8WgtHzGVGMdp/vyXFW+KpK2EWvfaK1PglzrX73+BdxGgnlfK8FSGxDv/OyXaAuPIOkfb7oTpFPDzVLrIkrZqV6BLP6XHJ+YIBgMF7M9gbHgcgk4tvZtovl+PsCU0y086ymzG8zwKiozmYwhgnq57C/XxvQYSg/5pwdNOLZ9xR9iRT4u38Uoohev6qiT61g7wTHSIp6STrrutVahNUkHiyeaGRZ+IdBcGCIlEMerXXj1XFQjgcOrzLcEyaPZsBJVxUaiSjGXmYD00WJUo/8UJicliQ0l+8bx0F8bF7go3U1vr/rP8ZWP9qTmTcOg0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WTX/dfAUWtPnrTeKM7XgkKOI+3C0YiQsao9l/nyLGXE=; b=j7DSnGHEtWylTJLR0CTNafMx9oRgfCkibud2fjCzw/aLItURXMmJ5bLSRKCDpAmhR9mo0PKyOLxGD4BX6JRXWC+OiDQBRDsDKnCx/Y9B52Kc4eo7e/oGg/N/e5BFN0gbf3nD9KX6CA7CCrzCsfJByjxfAquUwQZkFHyGcIFAHRuPnn9MDy0NXmqIaOdW/I6nJXiRFAYsNycbCy/8yeqZg2HKLdp7GaXdbtPRFDhW5Qmjh+NjoxwltJcs5CmNCcnI+KmsFoXnavuoDgbyG0+YxG+omxsxgDVZRCR358NvjrGIIASMABzJDEdV4qxGR8HVSZbFMWF63SA59IqtEZB5bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WTX/dfAUWtPnrTeKM7XgkKOI+3C0YiQsao9l/nyLGXE=; b=qy09cXNTnUED5JEpH1stKy9ruWQvTqrDoNK4aK2SQvEhR0CZChf1UUrsyPvEJpd3k3rvjdV6vH+OeTSp8ae/6zci/3KhH8xof3BH5507UF98hSTbnBCm8KdoNLB7rtYuRYGQ7aP+dTnd/zJ4WK6jO7wNp2CcawMNnsIqKJ/5l9g= Received: from CYZPR12CA0008.namprd12.prod.outlook.com (2603:10b6:930:8b::9) by LV2PR12MB5774.namprd12.prod.outlook.com (2603:10b6:408:17a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:28:57 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:930:8b:cafe::94) by CYZPR12CA0008.outlook.office365.com (2603:10b6:930:8b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.39 via Frontend Transport; Tue, 19 Dec 2023 03:28:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:28:56 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:28:52 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH v2 2/6] examples/l3fwd-power: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:21 +0100 Message-ID: <20231219032826.4814-3-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|LV2PR12MB5774:EE_ X-MS-Office365-Filtering-Correlation-Id: 91f461e3-7ce1-45f3-bd75-08dc0042a237 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VpveME/uVpd3Ed3kJFaWphT/9HuDzBXkwy7NQ8tXqLPrW8DD5t0v38mW5TUXxRIQuUtp9eD67gklPD5Bmpa8DXgCB4dUpky1XDA9gUlb/7MD28kdAu1oJDhQOtzzCnDU/OEedQdBKrsw84uwvilXd/a423osq3v5w14Q2c4emAPvVEUiGXPkoTUC7MFELnNrXBygUK+SZY1V7ElH+LU3WS1lZhMevQugh1QfIAtgKObpalMicURgc+NThGwA5p5TskmddoVntpSCU5FFwmI2RYjE4JMGulyfbje6r3+T2vEGKe0fCvBK4Cl2xtcO/Vsze3IyHtRITY6hUsRbZ81EypjMRe+Lf53q10I+34oZjJnkzTCbaA1CM6MPv8PTih1VTdd6/i2KxWVZzGnMLXU9fzMP179UZBOtxw5O/4TjO2D2dM68d2q1Rz10gF/cozKKSS0UfH6LmmKa9VRVCF3JhDOALZMGdTxC1gHIPaGkP3el7/Yu56Bvr0MmNiQH4zSb2oWVpplfTP65uUzUKLAry86CTMi6U+Ny/Uze46fynty/wEN5VbLBPhBU8pnbzFPhu045UtKvpej8kQb7qQfAE0scVXGyP/7C3r54cf2LaJdTGAO2zerKH3w7dmWD+8ZP3ukXW0m4+zcvHb05oL7YJuhYlunPryyUCrILFKdSmJuqjfK0jH29USVg6s+B8P7o3byeX3fpI9pL2nAML9PF1IriAAoW/uoHnMRJDt5Ro6gjIldslMDGU0oBhsABkmOLsTmmjsxRzoiG2iy5xK0P+g2KXPF+8/OCOReiL6x5bkEujNRTwP+LoJlrbYHzrvs/ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(136003)(39860400002)(346002)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(40470700004)(36840700001)(46966006)(40460700003)(1076003)(2616005)(426003)(26005)(336012)(16526019)(36860700001)(4326008)(8936002)(83380400001)(47076005)(5660300002)(44832011)(8676002)(41300700001)(2906002)(6666004)(478600001)(316002)(70586007)(70206006)(54906003)(110136005)(81166007)(356005)(82740400003)(86362001)(36756003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:28:56.8077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91f461e3-7ce1-45f3-bd75-08dc0042a237 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5774 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Cc: radu.nicolau@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd-power/main.c | 16 +++++++++------- examples/l3fwd-power/main.h | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f4adcf41b5..bb9da36455 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1399,8 +1399,8 @@ main_legacy_loop(__rte_unused void *dummy) static int check_lcore_params(void) { - uint8_t queue, lcore; - uint16_t i; + uint8_t queue; + uint16_t lcore, i; int socketid; for (i = 0; i < nb_lcore_params; ++i) { @@ -1411,13 +1411,13 @@ check_lcore_params(void) } lcore = lcore_params[i].lcore_id; if (!rte_lcore_is_enabled(lcore)) { - printf("error: lcore %hhu is not enabled in lcore " + printf("error: lcore %hu is not enabled in lcore " "mask\n", lcore); return -1; } if ((socketid = rte_lcore_to_socket_id(lcore) != 0) && (numa_on == 0)) { - printf("warning: lcore %hhu is on socket %d with numa " + printf("warning: lcore %hu is on socket %d with numa " "off\n", lcore, socketid); } if (app_mode == APP_MODE_TELEMETRY && lcore == rte_lcore_id()) { @@ -1469,7 +1469,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -1661,6 +1661,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int i; unsigned size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -1681,7 +1683,7 @@ parse_config(const char *q_arg) errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); if (errno != 0 || end == str_fld[i] || int_fld[i] > - 255) + max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -1694,7 +1696,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; diff --git a/examples/l3fwd-power/main.h b/examples/l3fwd-power/main.h index 258de98f5b..4e5fd3b6d6 100644 --- a/examples/l3fwd-power/main.h +++ b/examples/l3fwd-power/main.h @@ -10,7 +10,7 @@ struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; extern struct lcore_params *lcore_params; From patchwork Tue Dec 19 03:28:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135327 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91B6A4373B; Tue, 19 Dec 2023 04:29:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C2FC42DDA; Tue, 19 Dec 2023 04:29:41 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2080.outbound.protection.outlook.com [40.107.93.80]) by mails.dpdk.org (Postfix) with ESMTP id A2C554027B; Tue, 19 Dec 2023 04:29:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mL9quaSFLgHULnRIPYS2u65MYNf+QyU4u1jRIQ50Oi0OfjhNSlt3duzauPdj9zo/JjQnf5bZB1OwcBNjPWUzj/sD4hN6FTxECdCnO3sBJQyk6Q4GQU6TcwUOIjK3sEReGk3VSku/q1gtZJ/WL1dMa3Vm/Z/YJSJ2br1POfTLD30tlzUwJwJAN9iTriOEQi5i6vqMty3mfwksNaHwjzTvnn1cOom8uwxkeUXOSzCINmGFP3aQzlhjQ5qW5PxBt5VU1mM5HGGl3mYt98qYu5hMM6DRJtejYjIejKFeqIHDz1w7bx7gCacCIUP0L6dJNLgLPHiq0fhGZCjXE9rAP6MUSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJWgffbR/bEGt2fQMMzRmJ+PUWyvjUkiagXkshOyG8M=; b=Ptr7nLhIySR/4ZmxmDNd0KXQG51Yf6SI3mp2e/7bLMdO2taAifYXa0JIcp/ro8JQBVRQznm6LvOW60BkjWVc3SA5NK2XqBsbqRadVL7Ni5ivxkCgREmtdPzU6HkWZznAHU0GlzZGOsgh4g0dzu0g4YpakGlPAtquJvZj6gxDaqJqt0Haxten7keyq5h0bzVLlEtlEprajyk1rA5vS0z7Isq1BiDNlzXHuOuGCifgkIzllvjMTC7UVnInwy5Jx/nY1r8Ax3dx9FSOXreJ0HkwJxQbtpsQYV5nhbVABb1scp03zaoLRzFouuuEjF5ADVDKoPLLHgN5G5uXx70s9wf1UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJWgffbR/bEGt2fQMMzRmJ+PUWyvjUkiagXkshOyG8M=; b=vH4y1TW9UczU6lino2K2IoYYdEVR2TMhUsXOXdiJBB+x0lBrHyDr83ws/80ULvYwIe3uZ6qAcHyi11sOxVRMvRr3JY3nPq5tTfgtKDNOi/A+YNiivc430hRhelESfsAExNnNTcL9Xkvpvy6SqdqzmF+ReYHk2dm8P37rjGoDIVI= Received: from SN4PR0501CA0057.namprd05.prod.outlook.com (2603:10b6:803:41::34) by IA0PR12MB7577.namprd12.prod.outlook.com (2603:10b6:208:43e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 03:29:34 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:803:41:cafe::2a) by SN4PR0501CA0057.outlook.office365.com (2603:10b6:803:41::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.17 via Frontend Transport; Tue, 19 Dec 2023 03:29:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:29:34 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:28:56 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH v2 3/6] examples/l3fwd-graph: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:22 +0100 Message-ID: <20231219032826.4814-4-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|IA0PR12MB7577:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a824c0f-955d-41bb-bed5-08dc0042b8b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jdZ8oDX5RcBwD2j7s7WItT7/aM1bfBa0nrWAiOKa4cxhXBWbEQuydV9u7TboOEyevb1P3+5+dmWzOP8SUsdqnHnVBloUw8KDSvptkgvaxYULQeTnVzcvaKy8bf8J9wq4i5E3owNZqVEoSGOIiNWmQ8+L3oqPjHIpwXz5nakfP0R1c4ZamjUOVdFUUpd2gIWx+F000l9ECVn397NPeO6bRZHaEhkjlmaaudZG4wxlSII17KjxQB1N4y+KmkLOTMBzQmNbYFV/32hItPDlqomHY+kVgMDW63up+3b3rIdZ2OlNkmpKBKixUTSXkzYKYVn2yJXgfA2eUq3sRcZds9Lwr+Az9bqlW1MVk9kj7IXo1Tn74psnH77ZPowgIWS+sudZpiqEre3TdoTn2trBsysJr7v8yGvH4phl160oVZjhE2TVOQo1Wc3QUmXi5VM61329zjbGOyyF5eIzXluUzZhZoV0DiVvmt3KWQZywpUJJHLM8Pi42ZUb0v/HfVNxzeizRihl3btH4c/0rTuyTuKtRiBXZxCFvQgcZsp/J80vy3NZPQhapsHMwyzXpi0v2aKqwcwNqcco5SgYi5u9GnK3dLJfByA8MaGrPp/aFVxpUd3sOspQa2EHb6BLvbL+H26F4Ul6E1MkLosubYER4Fthi8SYSdcA1fA1DmPADRcdLSAEcXHcWpQqcLuLFMU7TD2F++3LasvOcckSzbra931ESHHlwwcIMdYo0WYIbJexp3Hv0DMsdIXx4EHxYSzz0L7/rClEcFcPckpKKKcVsxDp11Mj5napOPVf80WDZKrpghtj/j5ubs+d2dCor97kiHY9UIxVPYRu3W5kiRB1RGnPjDy0GLLhdCBTJXko8HeJpndI= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(136003)(396003)(39860400002)(376002)(230173577357003)(230922051799003)(230273577357003)(82310400011)(64100799003)(1800799012)(186009)(451199024)(46966006)(36840700001)(40470700004)(40480700001)(5660300002)(7416002)(4326008)(47076005)(8936002)(8676002)(6666004)(316002)(54906003)(70586007)(83380400001)(70206006)(44832011)(36860700001)(336012)(2906002)(110136005)(426003)(26005)(81166007)(356005)(82740400003)(1076003)(2616005)(16526019)(478600001)(41300700001)(36756003)(86362001)(40460700003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:29:34.6034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a824c0f-955d-41bb-bed5-08dc0042b8b7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7577 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Cc: ndabilpuram@marvell.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/l3fwd-graph/main.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index 96cb1c81ff..6d3116aa7b 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -111,7 +111,7 @@ static struct lcore_conf lcore_conf[RTE_MAX_LCORE]; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -205,9 +205,9 @@ check_worker_model_params(void) static int check_lcore_params(void) { - uint8_t queue, lcore; + uint8_t queue; int socketid; - uint16_t i; + uint16_t i, lcore; for (i = 0; i < nb_lcore_params; ++i) { queue = lcore_params[i].queue_id; @@ -217,7 +217,7 @@ check_lcore_params(void) } lcore = lcore_params[i].lcore_id; if (!rte_lcore_is_enabled(lcore)) { - printf("Error: lcore %hhu is not enabled in lcore mask\n", + printf("Error: lcore %hu is not enabled in lcore mask\n", lcore); return -1; } @@ -228,7 +228,7 @@ check_lcore_params(void) } socketid = rte_lcore_to_socket_id(lcore); if ((socketid != 0) && (numa_on == 0)) { - printf("Warning: lcore %hhu is on socket %d with numa off\n", + printf("Warning: lcore %hu is on socket %d with numa off\n", lcore, socketid); } } @@ -282,7 +282,7 @@ static int init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -452,7 +452,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; From patchwork Tue Dec 19 03:28:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135329 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB794373B; Tue, 19 Dec 2023 04:29:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EA3E42E15; Tue, 19 Dec 2023 04:29:44 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by mails.dpdk.org (Postfix) with ESMTP id EFF764027B; Tue, 19 Dec 2023 04:29:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fq6oJLNw7ZUa2QTOzgGfTFLiVjhwYarqka91Lsy6g79iNIGGXuiS8cHxFQny74a1Y3nObeNehYw+xQ/muOzsMWFE8Eoc/jJdoWxd8la/KivtupSaAS8NI4/ncwdSR5xq8XGsTgUMSZPfVzQtXTqMF/GDfgqMtJ1EHWZ70WG2n5JgxXJbBihjRB8l8nRRbKcObHIN0TCUFS3Tcabt8xLvnXUMW203rzbURYFJ8kJWK2Uh4dY9cHcn5nLy7a4R5JDqzqRzK55Utt+X00SgM5+hxx9d6mrDz9pdBabkbovrIZ1juCMhoqD3Yt/NwHzTAkfgQ3JL1PtKyelVOVIri/DmLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7SlHXDPxt2WYHbhj7Rgx+Bub8Fy3GSxeEUL5rVh7qCI=; b=M82bqAS6gh5++LxP2t+hQrjNlj2UvTxiV62agB5XASETTRbQSDL9j0+slpPuNJMVTIR0qFTLaxhqWT5eqpmxC/mMcOyzKCwNsIiqGw9k69tPA5tDNSNuNE5c3EbpyLprKUrRGgUP3P8i73gK43RbE5vRKx5fsxUUK8mQN3oT/1PZpd5GmhjP4Ber8pitxlyQhqWrRkZjBFxqB2hrpy+vl2T5CTcW4JUHb48UpvF6w2WYFylHpUA7ibTR7lQ2eXtRyEKh0xsXr8T9Sm1mUy7d2EuEZu1sv+uM6MiSySaGEbkUsBBl06NbA9H3hlED1ev67IO0IHfcN9/ABYTbT1aiAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7SlHXDPxt2WYHbhj7Rgx+Bub8Fy3GSxeEUL5rVh7qCI=; b=XoXP1TO308lfxwTjvR3aVV2kQMpa63iiVmWk694GHN/E4/uCAdgw4fI1IxcqG/BJuNNchWrE46IB7edTaM1WmEkVY7DpURQloeVLVLGJvNV1D6aKgA78Qai4hy35y139VeGnsfuP4kEu3wDrAPqViBwPSSiXvjdiZW/DKvXSVLk= Received: from CY5P221CA0125.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:1f::31) by DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 03:29:35 +0000 Received: from CY4PEPF0000EE34.namprd05.prod.outlook.com (2603:10b6:930:1f:cafe::93) by CY5P221CA0125.outlook.office365.com (2603:10b6:930:1f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:29:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE34.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:29:35 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:29:01 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH v2 4/6] examples/ipsec-secgw: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:23 +0100 Message-ID: <20231219032826.4814-5-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE34:EE_|DS7PR12MB5744:EE_ X-MS-Office365-Filtering-Correlation-Id: 055f760d-63de-4e5b-7c1e-08dc0042b91d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ueHgoEeiCv4+dk/fvI5vO7Z2fuf3BvXQDqMq8QOYyTfNocnvxhz+AzBOlLNJiVWQDJVn40pJX2ZxuoY21jpqxmq+zFF4wplaLVH/Xs2UI/M3MKIsJd/RplN7R030MxyXwf/G2tokU5J16rYSdk7MkILZE3/18Dxf1lMSxgZ6wi1J+DZQ29PX87nagoBP2l2NSPpcl6EMP1Jj2TNh0YIPdRt38nUTsbViUTqAE6fVkyjEErrbMgr94fl9ajBJ0TBcTGqNljwbGrjGLm0lfx33JmnVe1K1glji+x9dyKYj6t7o6JvbrVOAtMIJ+brjHIKdDYVcJDZambVpF5nhe10njuestdkgNWiL1yyRotG0yIxxfdMRd5vhQQKsdnIQjqg6zrCNGFHWszO0jeO8GecA0knkOVOlqQHQtvUq4WtC3y9bWQsUQfR9aI3kUBmG8EC/Zs3B98/6Ju2zbsKSrE4yHOCst1VgyohbRA9eYdV5148GHz+e2MKp8Uw0psl8+foq+I3YTIBWGGicVse/V/T7xA6IqLEPZtzxRfigZWMND+XFnGoQbTiHSUqixvjBSy3ALwPV+CL6NQWJ0mup5N7h4liyNvv82Ql0RHHQ3TXnVwa7y6mEbnlIkVnMFkkQ9kOxJDQL/DvEWv3tZSo5o/UCGe+WmVXM86xME7640danjlw6gd8fcXOGIHeVwGBCV9hds5mv/UDtyJAVYrT4587qsN7fMrpD1ZB6sfT4cgNnq+jCocpCCAwK7FyivvMmRXAiA+ZjQo6srpAcKxY1ki8c+gqfNqYO//nKmX/2n+3cvAoqy/4axQ2Z2fHlKbARrKWA X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(39860400002)(136003)(376002)(230273577357003)(230922051799003)(230173577357003)(1800799012)(451199024)(186009)(82310400011)(64100799003)(36840700001)(46966006)(40470700004)(40460700003)(6666004)(2616005)(16526019)(426003)(26005)(1076003)(336012)(36860700001)(8676002)(70586007)(4326008)(5660300002)(44832011)(83380400001)(41300700001)(7416002)(2906002)(478600001)(316002)(70206006)(81166007)(8936002)(54906003)(110136005)(356005)(47076005)(82740400003)(86362001)(36756003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:29:35.2389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 055f760d-63de-4e5b-7c1e-08dc0042b91d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE34.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5744 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sergio.gonzalez.monroy@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/event_helper.h | 2 +- examples/ipsec-secgw/ipsec-secgw.c | 16 +++++++++------- examples/ipsec-secgw/ipsec.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.h b/examples/ipsec-secgw/event_helper.h index dfb81bfcf1..9923700f03 100644 --- a/examples/ipsec-secgw/event_helper.h +++ b/examples/ipsec-secgw/event_helper.h @@ -102,7 +102,7 @@ struct eh_event_link_info { /**< Event port ID */ uint8_t eventq_id; /**< Event queue to be linked to the port */ - uint8_t lcore_id; + uint16_t lcore_id; /**< Lcore to be polling on this port */ }; diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index bf98d2618b..6f550db05c 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -221,7 +221,7 @@ static const char *cfgfile; struct lcore_params { uint16_t port_id; uint8_t queue_id; - uint8_t lcore_id; + uint16_t lcore_id; } __rte_cache_aligned; static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS]; @@ -810,7 +810,7 @@ check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid) static int32_t check_poll_mode_params(struct eh_conf *eh_conf) { - uint8_t lcore; + uint16_t lcore; uint16_t portid; uint16_t i; int32_t socket_id; @@ -829,13 +829,13 @@ check_poll_mode_params(struct eh_conf *eh_conf) for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; if (!rte_lcore_is_enabled(lcore)) { - printf("error: lcore %hhu is not enabled in " + printf("error: lcore %hu is not enabled in " "lcore mask\n", lcore); return -1; } socket_id = rte_lcore_to_socket_id(lcore); if (socket_id != 0 && numa_on == 0) { - printf("warning: lcore %hhu is on socket %d " + printf("warning: lcore %hu is on socket %d " "with numa off\n", lcore, socket_id); } @@ -870,7 +870,7 @@ static int32_t init_lcore_rx_queues(void) { uint16_t i, nb_rx_queue; - uint8_t lcore; + uint16_t lcore; for (i = 0; i < nb_lcore_params; ++i) { lcore = lcore_params[i].lcore_id; @@ -1051,6 +1051,8 @@ parse_config(const char *q_arg) char *str_fld[_NUM_FLD]; int32_t i; uint32_t size; + unsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS, + 255, RTE_MAX_LCORE}; nb_lcore_params = 0; @@ -1071,7 +1073,7 @@ parse_config(const char *q_arg) for (i = 0; i < _NUM_FLD; i++) { errno = 0; int_fld[i] = strtoul(str_fld[i], &end, 0); - if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) + if (errno != 0 || end == str_fld[i] || int_fld[i] > max_fld[i]) return -1; } if (nb_lcore_params >= MAX_LCORE_PARAMS) { @@ -1084,7 +1086,7 @@ parse_config(const char *q_arg) lcore_params_array[nb_lcore_params].queue_id = (uint8_t)int_fld[FLD_QUEUE]; lcore_params_array[nb_lcore_params].lcore_id = - (uint8_t)int_fld[FLD_LCORE]; + (uint16_t)int_fld[FLD_LCORE]; ++nb_lcore_params; } lcore_params = lcore_params_array; diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index f5cec4a928..5ebb71bb9a 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -259,7 +259,7 @@ create_lookaside_session(struct ipsec_ctx *ipsec_ctx_lcore[], continue; /* Looking for cryptodev, which can handle this SA */ - key.lcore_id = (uint8_t)lcore_id; + key.lcore_id = (uint16_t)lcore_id; key.cipher_algo = (uint8_t)sa->cipher_algo; key.auth_algo = (uint8_t)sa->auth_algo; key.aead_algo = (uint8_t)sa->aead_algo; From patchwork Tue Dec 19 03:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135328 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2356E4373B; Tue, 19 Dec 2023 04:29:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D9D42E00; Tue, 19 Dec 2023 04:29:42 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57]) by mails.dpdk.org (Postfix) with ESMTP id 6E1924027B; Tue, 19 Dec 2023 04:29:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grDHX9zRQAeplov/6slfp7gIbaCwUVopSYI0rmk08NryANUHvUMscc3VGWO7XiYeE8uI+Yaj/VWnH6qYJcD/Gf+VtiRz/iz9EX7xRqe6wOxzEndTnCsYenGTsTA5jxlPy4pmcHtfEs1K/Rm5dXIgZr/MUHwnanDcYbX9JdyVBe0LSjAuAjaeouE9QIqdA/oJIr5AwED3/HAIixbqZZsUgMfip8ae1JvtQM7B0OCzcSAErC94uD+ma5hUYRBq+2yRYLLBnCiWs5dRoz07tVfvd4IsMU+np6OsQwsm8liGSx0DR+dmEnTvc0OGY+l5BImeV3kZq4ifCX5PwOi/mfwItw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=Sz0kEKw77nDF+r71NTcnKhxdvi+8NNWjIbU1jUYxl5LbxjDCHc0xyDs/DsNDm3zswZprKdLmnvt6VXxTe/LoD3ihlZ1B8pWPS4WQnCEoecIDD30zi7a/O1jT5mdCHPhoy/A2iGMtB0ci6BCgqI4tJoSAfVK6cBhZXxYgNrR8PturJd8JRPfmyR2d2g9jnKcWWtVQkBMVji+TOHbcb3sNlBTtIainQ4NB1pdu4Nl5ortUGo9GQpBmHz4N3ux5nP6/1dH2p0uobN1lOQeDwKQ8MCB7vn1F7iTnJmhQFt/ysjQgE4WC9eq29ZIbUptXr9tT6dWByvw/Gi9f7/dTCT0aAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jD6y2+mVBnTppD6Uln3qKfA7bxRgibnJHITerqEztrQ=; b=0ucjXY4Z3zFRkrYg9JGXbEVGRZCKkx23fPoYZ+/EwR5eYWx9HO5ljBKBA2BH+6TJ1xIXYCcOoQihIC0U0yCljfn3hRCot882YJetoFNNz3bXnoFLeEJKrrMzR1JCV4FNjWRI1uREhfJhpBRA6VZflY1qWnCj2O4sj6mcpbnAIac= Received: from SN4PR0501CA0070.namprd05.prod.outlook.com (2603:10b6:803:41::47) by MN0PR12MB5884.namprd12.prod.outlook.com (2603:10b6:208:37c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 03:29:35 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:803:41:cafe::48) by SN4PR0501CA0070.outlook.office365.com (2603:10b6:803:41::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.16 via Frontend Transport; Tue, 19 Dec 2023 03:29:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:29:35 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:29:05 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , Subject: [PATCH v2 5/6] examples/qos_sched: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:24 +0100 Message-ID: <20231219032826.4814-6-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|MN0PR12MB5884:EE_ X-MS-Office365-Filtering-Correlation-Id: 0814d968-e783-4e22-1d89-08dc0042b917 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5vdwyjoiaNj8UAyEpgDk99c3aQ8eOWUJlm8/heqaIt5a70NBIuQIn0hHhGj86X0TvEG1t8bnYkycp7ErYneX+8+J5P8vzrS9QWsXMbCJ3yI5LWi7eKmX/dmNcFEhLZZMIGnQ+52wCVhudtFxI37q+nfMBgOrXAClCc4sFxKGE76upYFLERzKl6+MOSartNNzqKP208ckVTaiLqUA3H9mM3PmK7TJ/7GWPt4Q9HBYt9xdfvbN45bnCuKuevXllTrF7d/nNHFeFIXaZNc1c7wqRteQYi3VLBDfxghGo0yPt351O70K6EjJJ45WB0hdjZl9eBWaUSdY56LpmpCmNTJbXLSAq8UA/9QIIRFWODSzX8mLvSdlOH/En10oDkH93RZlH5ccGMCAD4ZODMgHDlihJQZqE1l2OlviDuFHreLO2D5V3KTa6o3VbgHcQ+cIqfmi0lS89o/I1v62BWUT/FUouGVB0JU3BFS4I63mInw44EwXkkyaTlvZnDFXdvBcPm3mGRzJwsbexkc75M4dublNTa/AdsfLNav+g2P4IOZMA7V9hFAo6a+i9KVG/HdjLT47WG01W5Mrw8weCFfwHaPAhQyRxz6ubLmaG4KGvGvLBVPEdtdjEfrtVNicRjTdzL8ZLT83K6PkAwOoISPDE7HrRNDr/KhVig39GHIIPOJnmsWEgy+sVeR1lWjo/HejXShYX/Xf558ps+UFUh2cLVqrMcfxRhs4JUVuz/OxRnrstd+KL9phbwXhYWo6og+cM560Ze6HIZDMEsaNi4DvPFuLHw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(396003)(39860400002)(346002)(230922051799003)(451199024)(64100799003)(82310400011)(186009)(1800799012)(36840700001)(40470700004)(46966006)(4744005)(2906002)(5660300002)(41300700001)(36756003)(86362001)(356005)(81166007)(82740400003)(316002)(16526019)(336012)(426003)(1076003)(26005)(40480700001)(2616005)(36860700001)(83380400001)(70206006)(110136005)(54906003)(478600001)(70586007)(6666004)(40460700003)(4326008)(8676002)(8936002)(44832011)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:29:35.2284 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0814d968-e783-4e22-1d89-08dc0042b917 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5884 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: de3cfa2c9823 ("sched: initial import") Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/qos_sched/args.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index e97273152a..22fe76eeb5 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_str) pconf->rx_port = vals[0]; pconf->tx_port = vals[1]; - pconf->rx_core = (uint8_t)vals[2]; - pconf->wt_core = (uint8_t)vals[3]; + pconf->rx_core = (uint16_t)vals[2]; + pconf->wt_core = (uint16_t)vals[3]; if (ret == 5) - pconf->tx_core = (uint8_t)vals[4]; + pconf->tx_core = (uint16_t)vals[4]; else pconf->tx_core = pconf->wt_core; From patchwork Tue Dec 19 03:28:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 135330 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B04F4373B; Tue, 19 Dec 2023 04:30:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 038B142DFE; Tue, 19 Dec 2023 04:29:51 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2081.outbound.protection.outlook.com [40.107.102.81]) by mails.dpdk.org (Postfix) with ESMTP id DF86A42DFE; Tue, 19 Dec 2023 04:29:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eT5RokdTucjReF3/98P2soL7mM7CCe+bFEY0N0xoCFCPWcIblJ7RXO+Lk0Q//+WRxAWwyXVls0zZlP9vo/lHb/D3SHASIqCgmmXLkSns6xPaYSieuTGb1A3rkOhxYkHZN3jWxQliUIfOM1nYM3iuMcHhUzX0UhrlO1/BUO8vCqsPjAwoa54Qx5oaskXkAb0XCxc8PODWqdBF+5oJd3uNmWlun9RZasMN5zMP2ZP3Qx6GpVVLhbhB+uHJPnEou4HcC05s7khmWGF8cBHm6Pm64GGyj0HLEEoJ5Uvkyawk5YN0sTeLNLNbxIXMnLYcblzrLtuJMXnf78K/Af8o41remA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pelULDo/Wpz4C81J43QCyteewJdU1439J7sWe81Jjj8=; b=d+Fogp4k+PobZ4KcbH3jesmAvv8A6w9kDnCajWuc7FUkFYK4d7oNiOj0R9bX4TPftYFbA3CiR4ei63U59oinMfoJdLNL34ZK4A6TkODdGpo7LmEcNAyUFzMFbRzdI3H+KSP01HByGfaSNRz5TscixpX3oGHRSHETq+hqR8w+8y8molirvX8x+2O9r2Sr7310kgyOsIi8hFbYmp7E7aRLl5zoriI9xEG0qTWboRmWjTDvx3rin9m6S8EB35bauLCRduJC/UL+vElinM0LVEUobfYZXg7GHmDYwbhuQJAHq3wwI0FcEatg8jXW3bUGD0D1HrhiKae4co12r2Zh9TnOJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pelULDo/Wpz4C81J43QCyteewJdU1439J7sWe81Jjj8=; b=UuilL7YohiHMAEo8J2ufZSYE3jpmgSbqy2yrBe9CNqQzkJaDE7WXRXiGkOyIYAm8DSLyPAYxcy+EQoLkBfeCkgASmoDH+8PmwY/AZBNgqMPJUOWwK5vLot9EM6BZlhQFJmLW75DMUfbJnY5zCuh7PNksh+OeNqGSInmxNXtYv6A= Received: from CYXPR02CA0063.namprd02.prod.outlook.com (2603:10b6:930:cd::8) by DS0PR12MB7849.namprd12.prod.outlook.com (2603:10b6:8:141::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:29:44 +0000 Received: from CY4PEPF0000EE35.namprd05.prod.outlook.com (2603:10b6:930:cd:cafe::a4) by CYXPR02CA0063.outlook.office365.com (2603:10b6:930:cd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:29:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE35.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:29:43 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:29:09 -0600 From: Sivaprasad Tummala To: , , , , , , , CC: , , Subject: [PATCH v2 6/6] examples/vm_power_manager: fix lcore ID restriction Date: Tue, 19 Dec 2023 04:28:25 +0100 Message-ID: <20231219032826.4814-7-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231219032826.4814-1-sivaprasad.tummala@amd.com> References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <20231219032826.4814-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE35:EE_|DS0PR12MB7849:EE_ X-MS-Office365-Filtering-Correlation-Id: 5670d748-41eb-4f82-4db2-08dc0042be48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gtoah0l/viL5MPO3CleYeuSfto/Ccnvj1uDZV9dcLd0ps2GPMv8R8Cpi3jX33PW+9fp91PfmZW949qWZhBYBvxWbCWP1Y2sjOF9e8lm9mkyjZzV7YWiKbNQ07HKjvI8RXi0ePfrl/yuc0v4BYkpupobZ7rKD6ZhanCU4dp0sl7VG1wdXFNvuSxB8opwH5GVidog1Eq7eOmpRiZ2yOx2NpokwoDY3sphBdoY6YMWuqILE6YpCOO4z6W3pPPStJ6ayIQB0EgsquQs6JHWxlDiowRAZ0tPj8gUIffsDLrc4wuzLU8mxgWYa9bzS7R4X/PjNhxRMJvjsEHYmZRtjnbhtsfli1yGegYd0r8m7clwR0fzrh9QtuPt2suJwSsrgjv2JE7ENEHRvKQ+0t7HJ4X96907F19Z0wtd8xeBYQJSECIreolh3PbwplkTWM4easojTDBuF0InukUvFd+nSaL/76SuQheVoDhPwpzfFclZRtqi2mAaY1pfeltH7PAPVc4kQtZZENJH6yw7clALG6x1Qw387jTNg8G4dzq50ff8G8hprNbPJH//XCuhEh/mwOcInGC5KRtsCabYr0VySGQvCeOzFTnbVUWIy4f+WGTwuHfDQ5j2r4BfNtni6N7UP6u151sxqyf5vpMg7otjY4AWL8Jpvivob6ZtQRgtv1qnjmP1rstUrs9/U8LUbQtpmf2e9HST5EibC0nmzYSGw+8l82/8+TWgawOWtpXwkVfzKDxGHTZHq5l86YC2NXjPPkjIQJbDkT2B10NW3Pref0K9Q/g== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(346002)(136003)(396003)(230922051799003)(82310400011)(186009)(1800799012)(451199024)(64100799003)(36840700001)(46966006)(40470700004)(83380400001)(2616005)(70586007)(478600001)(70206006)(54906003)(110136005)(316002)(40480700001)(426003)(26005)(1076003)(336012)(16526019)(44832011)(40460700003)(47076005)(8936002)(4326008)(8676002)(6666004)(36860700001)(7416002)(5660300002)(2906002)(86362001)(81166007)(82740400003)(356005)(36756003)(41300700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:29:43.9081 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5670d748-41eb-4f82-4db2-08dc0042be48 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE35.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7849 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch allows config options based on DPDK config. Fixes: 0e8f47491f09 ("examples/vm_power: add command to query CPU frequency") Cc: marcinx.hajkowski@intel.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c index 94bfbbaf78..a586853a76 100644 --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c @@ -401,7 +401,7 @@ check_response_cmd(unsigned int lcore_id, int *result) struct cmd_set_cpu_freq_result { cmdline_fixed_string_t set_cpu_freq; - uint8_t lcore_id; + uint16_t lcore_id; cmdline_fixed_string_t cmd; }; @@ -444,7 +444,7 @@ cmdline_parse_token_string_t cmd_set_cpu_freq = set_cpu_freq, "set_cpu_freq"); cmdline_parse_token_num_t cmd_set_cpu_freq_core_num = TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result, - lcore_id, RTE_UINT8); + lcore_id, RTE_UINT16); cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd = TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result, cmd, "up#down#min#max#enable_turbo#disable_turbo");