Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133472/?format=api
{ "id": 133472, "url": "http://patches.dpdk.org/api/patches/133472/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231027060947.3183983-3-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231027060947.3183983-3-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231027060947.3183983-3-haijie1@huawei.com", "date": "2023-10-27T06:09:40", "name": "[2/8] net/hns3: fix unchecked Rx free threshold", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b49a107cbd6ecac1d26feb9ddc331f87e9cb4ba9", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231027060947.3183983-3-haijie1@huawei.com/mbox/", "series": [ { "id": 30018, "url": "http://patches.dpdk.org/api/series/30018/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30018", "date": "2023-10-27T06:09:41", "name": "net/hns3: add some bugfix for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/30018/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133472/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3D8543212;\n\tFri, 27 Oct 2023 08:13:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A186B40A6C;\n\tFri, 27 Oct 2023 08:13:54 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 8303C4029A\n for <dev@dpdk.org>; Fri, 27 Oct 2023 08:13:51 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SGsjV12bBzrTXj;\n Fri, 27 Oct 2023 14:10:54 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 27 Oct 2023 14:13:48 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, \"Wei Hu (Xavier)\"\n <xavier.huwei@huawei.com>, Hao Chen <chenh@yusur.tech>, Chunsong Feng\n <fengchunsong@huawei.com>, Ferruh Yigit <ferruh.yigit@intel.com>, \"Min Hu\n (Connor)\" <humin29@huawei.com>", "CC": "<fengchengwen@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>, <huangdengdui@huawei.com>", "Subject": "[PATCH 2/8] net/hns3: fix unchecked Rx free threshold", "Date": "Fri, 27 Oct 2023 14:09:40 +0800", "Message-ID": "<20231027060947.3183983-3-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231027060947.3183983-1-haijie1@huawei.com>", "References": "<20231027060947.3183983-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Dengdui Huang <huangdengdui@huawei.com>\n\nTo reduce the frequency of updating the head pointer of Rx queue,\ndriver just updates this pointer when the number of processed\ndescriptors is greater than the Rx free threshold. If the Rx free\nthreshold is set to a value greater than or equal to the number of\ndescriptors in Rx queue, the driver does not update this pointer.\nAs a result, the hardware cannot receive more packets.\n\nThis patch fix it by adding Rx free threshold check.\n\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex f3c3b38c55d1..13214d02d536 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1785,6 +1785,12 @@ hns3_rx_queue_conf_check(struct hns3_hw *hw, const struct rte_eth_rxconf *conf,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (conf->rx_free_thresh >= nb_desc) {\n+\t\thns3_err(hw, \"rx_free_thresh (%u) must be less than %u\",\n+\t\t\t conf->rx_free_thresh, nb_desc);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (conf->rx_drop_en == 0)\n \t\thns3_warn(hw, \"if no descriptors available, packets are always \"\n \t\t\t \"dropped and rx_drop_en (1) is fixed on\");\n", "prefixes": [ "2/8" ] }