Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108152/?format=api
{ "id": 108152, "url": "http://patches.dpdk.org/api/patches/108152/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220223121944.24156-9-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220223121944.24156-9-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220223121944.24156-9-mk@semihalf.com", "date": "2022-02-23T12:19:31", "name": "[v3,08/21] net/ena: perform Tx cleanup before sending pkts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "00d79a3330b1a5baed7212f5fcfd82acc1d2bc62", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220223121944.24156-9-mk@semihalf.com/mbox/", "series": [ { "id": 21824, "url": "http://patches.dpdk.org/api/series/21824/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21824", "date": "2022-02-23T12:19:23", "name": "net/ena: v2.6.0 driver update", "version": 3, "mbox": "http://patches.dpdk.org/series/21824/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108152/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/108152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CEDAA034C;\n\tWed, 23 Feb 2022 13:21:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BBD1442703;\n\tWed, 23 Feb 2022 13:20:43 +0100 (CET)", "from mail-ej1-f45.google.com (mail-ej1-f45.google.com\n [209.85.218.45]) by mails.dpdk.org (Postfix) with ESMTP id 1B5B5426EE\n for <dev@dpdk.org>; Wed, 23 Feb 2022 13:20:40 +0100 (CET)", "by mail-ej1-f45.google.com with SMTP id lw4so52030830ejb.12\n for <dev@dpdk.org>; Wed, 23 Feb 2022 04:20:40 -0800 (PST)", "from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl.\n [89.79.181.52])\n by smtp.gmail.com with ESMTPSA id v12sm11629224edr.8.2022.02.23.04.20.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 23 Feb 2022 04:20:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=kJsrYm2uvyrl1AjemrWrKMybiEz+usep4Zai6FZc+2s=;\n b=LmTPfjuC6FXcUW/8PMEUaugXkEMxa1vK6Moy+ePq3zq9wERN8nDTLOHraossNiaDrS\n pDD8e1izKqZ0gEcj6seL6Vi7aN/pM9SnidfP4rEr43uDIL+hpDCs9Fe7WigiJyhH95Gh\n yf5o3VOD84ncRbhHmLqxzGahWaOUGb3tsZ7mNqOu4WfxyMeNlMdxYhmMvYA6uhLvaiUN\n 75tNzqXFR5fo2BLqsfnc+DE6AX4OrF1q1144ijAuAfqvuVAOGDvScCkFQ780+peRY3IF\n NhRTA/eWzsS6NCXpz97clvTJnNq4I6NZH87n+CGeAyOWCIfj3GnHHOCbzMNr6CyoyDq0\n aMNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=kJsrYm2uvyrl1AjemrWrKMybiEz+usep4Zai6FZc+2s=;\n b=ShZFW4WGD2LhD+WYV3UqJ1RqLbvQdUD71kB8ACHEiJCXmmUWGTcsTcJPRF4uPkkYhO\n LothdS0U85HXAimGfW12MjDDbOAcAx6q0nBWGEtpcn+6VwymlBZW+M8Z5z99tvW6GvRN\n d2bt5G4QdiCcmvP0AQbKMVpdw2RtIsgMwdItNq1eDRGXSdr7xrWUmeIBO6+UrYgHT8Aj\n tBsjkwVvbmxTO6WrRC1PKbUsAu31TN+F/ADw2BUuuGdayVNL9HaKJCAiNLD5fCkb+Isg\n yWHfb5aqDQ48IFkGwTb4IJ5zi0ruT6bqm1AQke0KcWe1JcyJCdPLMP37chEtD6Pgt6Dt\n vrYg==", "X-Gm-Message-State": "AOAM530KMuJPotjuHsFhPSTNucXpaUqNDs2ogQ62POlMazkvNtH8bRw+\n FnXqbUmK9HZRcS3Rvj0xnM5kH+p+wSlhsQ==", "X-Google-Smtp-Source": "\n ABdhPJwSdYWkmf10AtRQEewOOOwB9uZtShZf/PXuYxSgvbLqXLehgBAKEBxMsdqYTgfmEHKP10S0yw==", "X-Received": "by 2002:a17:907:2bc4:b0:6ce:88ec:3acd with SMTP id\n gv4-20020a1709072bc400b006ce88ec3acdmr22550016ejc.300.1645618839573;\n Wed, 23 Feb 2022 04:20:39 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, Dawid Gorecki <dgr@semihalf.com>", "Subject": "[PATCH v3 08/21] net/ena: perform Tx cleanup before sending pkts", "Date": "Wed, 23 Feb 2022 13:19:31 +0100", "Message-Id": "<20220223121944.24156-9-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220223121944.24156-1-mk@semihalf.com>", "References": "<20220222181146.28882-1-mk@semihalf.com>\n <20220223121944.24156-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To increase likehood that current burst will fit in the HW rings,\nperform Tx cleanup before pushing packets to the HW. It may increase\nlatency a bit for sparse bursts, but the Tx flow now should be more\nsmooth.\n\nIt's also common order in the Tx burst function for other PMDs.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Dawid Gorecki <dgr@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 4b82372155..ed3dd162ba 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2776,6 +2776,10 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n #endif\n \n+\tavailable_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq);\n+\tif (available_desc < tx_ring->tx_free_thresh)\n+\t\tena_tx_cleanup(tx_ring);\n+\n \tfor (sent_idx = 0; sent_idx < nb_pkts; sent_idx++) {\n \t\tif (ena_xmit_mbuf(tx_ring, tx_pkts[sent_idx]))\n \t\t\tbreak;\n@@ -2784,9 +2788,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\ttx_ring->size_mask)]);\n \t}\n \n-\tavailable_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq);\n-\ttx_ring->tx_stats.available_desc = available_desc;\n-\n \t/* If there are ready packets to be xmitted... */\n \tif (likely(tx_ring->pkts_without_db)) {\n \t\t/* ...let HW do its best :-) */\n@@ -2795,9 +2796,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\ttx_ring->pkts_without_db = false;\n \t}\n \n-\tif (available_desc < tx_ring->tx_free_thresh)\n-\t\tena_tx_cleanup(tx_ring);\n-\n \ttx_ring->tx_stats.available_desc =\n \t\tena_com_free_q_entries(tx_ring->ena_com_io_sq);\n \ttx_ring->tx_stats.tx_poll++;\n", "prefixes": [ "v3", "08/21" ] }