From patchwork Wed Feb 23 12:19:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108152 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CEDAA034C; Wed, 23 Feb 2022 13:21:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBD1442703; Wed, 23 Feb 2022 13:20:43 +0100 (CET) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mails.dpdk.org (Postfix) with ESMTP id 1B5B5426EE for ; Wed, 23 Feb 2022 13:20:40 +0100 (CET) Received: by mail-ej1-f45.google.com with SMTP id lw4so52030830ejb.12 for ; Wed, 23 Feb 2022 04:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kJsrYm2uvyrl1AjemrWrKMybiEz+usep4Zai6FZc+2s=; b=LmTPfjuC6FXcUW/8PMEUaugXkEMxa1vK6Moy+ePq3zq9wERN8nDTLOHraossNiaDrS pDD8e1izKqZ0gEcj6seL6Vi7aN/pM9SnidfP4rEr43uDIL+hpDCs9Fe7WigiJyhH95Gh yf5o3VOD84ncRbhHmLqxzGahWaOUGb3tsZ7mNqOu4WfxyMeNlMdxYhmMvYA6uhLvaiUN 75tNzqXFR5fo2BLqsfnc+DE6AX4OrF1q1144ijAuAfqvuVAOGDvScCkFQ780+peRY3IF NhRTA/eWzsS6NCXpz97clvTJnNq4I6NZH87n+CGeAyOWCIfj3GnHHOCbzMNr6CyoyDq0 aMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kJsrYm2uvyrl1AjemrWrKMybiEz+usep4Zai6FZc+2s=; b=ShZFW4WGD2LhD+WYV3UqJ1RqLbvQdUD71kB8ACHEiJCXmmUWGTcsTcJPRF4uPkkYhO LothdS0U85HXAimGfW12MjDDbOAcAx6q0nBWGEtpcn+6VwymlBZW+M8Z5z99tvW6GvRN d2bt5G4QdiCcmvP0AQbKMVpdw2RtIsgMwdItNq1eDRGXSdr7xrWUmeIBO6+UrYgHT8Aj tBsjkwVvbmxTO6WrRC1PKbUsAu31TN+F/ADw2BUuuGdayVNL9HaKJCAiNLD5fCkb+Isg yWHfb5aqDQ48IFkGwTb4IJ5zi0ruT6bqm1AQke0KcWe1JcyJCdPLMP37chEtD6Pgt6Dt vrYg== X-Gm-Message-State: AOAM530KMuJPotjuHsFhPSTNucXpaUqNDs2ogQ62POlMazkvNtH8bRw+ FnXqbUmK9HZRcS3Rvj0xnM5kH+p+wSlhsQ== X-Google-Smtp-Source: ABdhPJwSdYWkmf10AtRQEewOOOwB9uZtShZf/PXuYxSgvbLqXLehgBAKEBxMsdqYTgfmEHKP10S0yw== X-Received: by 2002:a17:907:2bc4:b0:6ce:88ec:3acd with SMTP id gv4-20020a1709072bc400b006ce88ec3acdmr22550016ejc.300.1645618839573; Wed, 23 Feb 2022 04:20:39 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id v12sm11629224edr.8.2022.02.23.04.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 04:20:39 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: ferruh.yigit@intel.com, shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Dawid Gorecki Subject: [PATCH v3 08/21] net/ena: perform Tx cleanup before sending pkts Date: Wed, 23 Feb 2022 13:19:31 +0100 Message-Id: <20220223121944.24156-9-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223121944.24156-1-mk@semihalf.com> References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To increase likehood that current burst will fit in the HW rings, perform Tx cleanup before pushing packets to the HW. It may increase latency a bit for sparse bursts, but the Tx flow now should be more smooth. It's also common order in the Tx burst function for other PMDs. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 4b82372155..ed3dd162ba 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2776,6 +2776,10 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, } #endif + available_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq); + if (available_desc < tx_ring->tx_free_thresh) + ena_tx_cleanup(tx_ring); + for (sent_idx = 0; sent_idx < nb_pkts; sent_idx++) { if (ena_xmit_mbuf(tx_ring, tx_pkts[sent_idx])) break; @@ -2784,9 +2788,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, tx_ring->size_mask)]); } - available_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq); - tx_ring->tx_stats.available_desc = available_desc; - /* If there are ready packets to be xmitted... */ if (likely(tx_ring->pkts_without_db)) { /* ...let HW do its best :-) */ @@ -2795,9 +2796,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, tx_ring->pkts_without_db = false; } - if (available_desc < tx_ring->tx_free_thresh) - ena_tx_cleanup(tx_ring); - tx_ring->tx_stats.available_desc = ena_com_free_q_entries(tx_ring->ena_com_io_sq); tx_ring->tx_stats.tx_poll++;