Cover Detail
Show a cover letter.
GET /api/covers/729/?format=api
{ "id": 729, "url": "http://patches.dpdk.org/api/covers/729/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20240229225936.483472-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-1-stephen@networkplumber.org", "date": "2024-02-29T22:57:47", "name": "[00/71] replace use of fixed size rte_memcpy", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20240229225936.483472-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patches.dpdk.org/api/series/31314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patches.dpdk.org/series/31314/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/729/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BC2C43BB1;\n\tFri, 1 Mar 2024 00:00:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8EE6043001;\n\tFri, 1 Mar 2024 00:00:02 +0100 (CET)", "from mail-pj1-f41.google.com (mail-pj1-f41.google.com\n [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id CE22A427D9\n for <dev@dpdk.org>; Thu, 29 Feb 2024 23:59:59 +0100 (CET)", "by mail-pj1-f41.google.com with SMTP id\n 98e67ed59e1d1-29b10d73630so866026a91.0\n for <dev@dpdk.org>; Thu, 29 Feb 2024 14:59:59 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.14.59.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 14:59:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247599;\n x=1709852399; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=bWGlIdzDHtV7KD7QTH444L7/37WdQhmep/uLl8FC910=;\n b=kX74HUel2VBAMEaOqbS3G+cxScmiV++dm3F2IIy0Ta7+zlwQv7NUPyrYDNV5CHkQ97\n PGkpCqgg4zqO+w6TAPNojd2CKSWvolxm7xEFN2a4w0CXGx9LwCX3KVjmcJ+v22QmzVRS\n GidXDliIuyLbwQJ4+MoDj+LndrJf2zFNl8Xaejk2mSmpysca57nD+7+iWG25Rjmo3x1Z\n JKXKbDXJjtfkwHcXCPGgQj/owgyMzTEQTGdzvDUPUzWk1whO/GvH8YDhmFl29bx96cjW\n z/UWgegOr5LvyOd3ZhaUxTqGxUKqe3Wj2RO1pjT0CO5/WlYbuWJf74oDiKL/X/OhnxCy\n Rcig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247599; x=1709852399;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=bWGlIdzDHtV7KD7QTH444L7/37WdQhmep/uLl8FC910=;\n b=WiblzgQ79Cj4N+s6QZ8rp2zWxz5fG6CK3TFfVbUjQ1jTcSc3U4AxYmWUmhTH/honsz\n QXaAqHuaP7Gr8Qd0eYTeNkcjxdDWtx+KJIr/5HEQPm3NE/x0lhjiCqRBdtS1hy2kVVAo\n 9XZ4JoGtqsRe0yKvXq8pDy0mw4ubBhd7wIziMHQL0OH5XGoHi3aq6EQm4tzsitrFs0Ta\n cJjdV0A5uQSYYF8QOv1oFRKKS3snv9YeAHqNmz4gDQ75tTDkNav2gaS4VG/L/DEG0DMv\n Z0zM9C9bXVxMqG4FLzC2lo7v0ZvWhYsiXPl2zlNzt1n0JcDaWqhROnf1cDm4Ki94Slod\n 8lxA==", "X-Gm-Message-State": "AOJu0YzBS3r0D0PExjv246Xfj/IX5MDtWJ1fdUPiNTeX6iVfNr3/tBTl\n 1eRxsBjpEReQatceR0ZX3dDepCpq0uhfU1/pcipSNI8hIfahFzahzXWjyl1YOPDmoW1CX0t0LXO\n l", "X-Google-Smtp-Source": "\n AGHT+IH1IAdSWdADKGl1HFtUcONDFVHWBM5VnC2qKI9QjIXB/Ios0JYgXLMGoX3ukGeIZyq3xnL0Zg==", "X-Received": "by 2002:a17:90b:238d:b0:299:2990:f6f1 with SMTP id\n mr13-20020a17090b238d00b002992990f6f1mr30677pjb.17.1709247597426;\n Thu, 29 Feb 2024 14:59:57 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 00/71] replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:57:47 -0800", "Message-ID": "<20240229225936.483472-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The DPDK has a lot of \"cargo cult\" usage of rte_memcpy.\nThis patch set replaces cases where rte_memcpy is used with a fixed\nsize constant size.\n\nTypical example is:\n\trte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN);\nwhich can be replaced with:\n\tmemcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN);\n\nThis has two benefits. Gcc (and clang) are smart enough that for\nall small fixed size values, they just generate the necessary instructions\nto do it inline. It also means that fortify, Coverity, and ASAN\nanalyzers can check these memcpy's.\n\nSo faster, better, safer.\n\nThe first patch is a simple coccinelle script to do the replacement\nand the rest are the results broken out by module.\n\nThe coccinelle script can be used again to make sure more bad\nusage doesn't creep in with new drivers.\n\nStephen Hemminger (71):\n cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy\n eal: replace use of fixed size rte_memcpy\n ethdev: replace use of fixed size rte_memcpy\n eventdev: replace use of fixed size rte_memcpy\n cryptodev: replace use of fixed size rte_memcpy\n ip_frag: replace use of fixed size rte_memcpy\n net: replace use of fixed size rte_memcpy\n lpm: replace use of fixed size rte_memcpy\n node: replace use of fixed size rte_memcpy\n pdcp: replace use of fixed size rte_memcpy\n pipeline: replace use of fixed size rte_memcpy\n rib: replace use of fixed size rte_memcpy\n security: replace use of fixed size rte_memcpy\n net/mlx5: replace use of fixed size rte_memcpy\n net/nfp: replace use of fixed size rte_memcpy\n net/ngbe: replace use of fixed size rte_memcpy\n net/null: replace use of fixed size rte_memcpy\n net/pcap: replace use of fixed size rte_memcpy\n net/sfc: replace use of fixed size rte_memcpy\n net/tap: replace use of fixed size rte_memcpy\n net/txgbe: replace use of fixed size rte_memcpy\n raw/ifpga: replace use of fixed size rte_memcpy\n raw/skeleton: replace use of fixed size rte_memcpy\n net/hns3: replace use of fixed size rte_memcpy\n net/i40e: replace use of fixed size rte_memcpy\n net/iavf: replace use of fixed size rte_memcpy\n net/ice: replace use of fixed size rte_memcpy\n net/idpf: replace use of fixed size rte_memcpy\n net/ipn3ke: replace use of fixed size rte_memcpy\n net/ixgbe: replace use of fixed size rte_memcpy\n net/memif: replace use of fixed size rte_memcpy\n net/qede: replace use of fixed size rte_memcpy\n baseband/acc: replace use of fixed size rte_memcpy\n baseband/la12xx: replace use of fixed size rte_memcpy\n common/idpf: replace use of fixed size rte_memcpy\n common/qat: replace use of fixed size rte_memcpy\n compress/qat: replace use of fixed size rte_memcpy\n crypto/ccp: replace use of fixed size rte_memcpy\n crypto/cnxk: replace use of fixed size rte_memcpy\n crypto/dpaa_sec: replace use of fixed size rte_memcpy\n crypto/ipsec_mb: replace use of fixed size rte_memcpy\n crypto/qat: replace use of fixed size rte_memcpy\n crypto/scheduler: replace use of fixed size rte_memcpy\n event/cnxk: replace use of fixed size rte_memcpy\n event/dlb2: replace use of fixed size rte_memcpy\n event/dpaa2: replace use of fixed size rte_memcpy\n event/octeontx: replace use of fixed size rte_memcpy\n mempool/dpaa: replace use of fixed size rte_memcpy\n mempool/dpaa2: replace use of fixed size rte_memcpy\n ml/cnxk: replace use of fixed size rte_memcpy\n net/af_xdp: replace use of fixed size rte_memcpy\n net/avp: replace use of fixed size rte_memcpy\n net/axgbe: replace use of fixed size rte_memcpy\n net/bnx2x: replace use of fixed size rte_memcpy\n net/bnxt: replace use of fixed size rte_memcpy\n net/bonding: replace use of fixed size rte_memcpy\n net/cnxk: replace use of fixed size rte_memcpy\n net/cpfl: replace use of fixed size rte_memcpy\n net/cxgbe: replace use of fixed size rte_memcpy\n net/dpaa2: replace use of fixed size rte_memcpy\n net/e1000: replace use of fixed size rte_memcpy\n net/enic: replace use of fixed size rte_memcpy\n net/failsafe: replace use of fixed size rte_memcpy\n net/gve/base: replace use of fixed size rte_memcpy\n net/hinic: replace use of fixed size rte_memcpy\n net/mvpp2: replace use of fixed size rte_memcpy\n app/test-pmd: replace use of fixed size rte_memcpy\n app/graph: replace use of fixed size rte_memcpy\n app/test-eventdev: replace use of fixed size rte_memcpy\n app/test: replace use of fixed size rte_memcpy\n examples: replace use of fixed size rte_memcpy\n\n app/graph/neigh.c | 8 +-\n app/test-eventdev/test_pipeline_common.c | 19 ++-\n app/test-pmd/cmdline.c | 48 ++++----\n app/test-pmd/cmdline_flow.c | 24 ++--\n app/test-pmd/config.c | 8 +-\n app/test/packet_burst_generator.c | 4 +-\n app/test/test_crc.c | 4 +-\n app/test/test_cryptodev.c | 18 ++-\n app/test/test_event_crypto_adapter.c | 12 +-\n app/test/test_event_dma_adapter.c | 4 +-\n app/test/test_ipsec.c | 6 +-\n app/test/test_link_bonding_mode4.c | 8 +-\n app/test/test_security_inline_proto.c | 36 +++---\n app/test/virtual_pmd.c | 2 +-\n devtools/cocci/rte_memcpy.cocci | 11 ++\n drivers/baseband/acc/rte_acc100_pmd.c | 19 ++-\n drivers/baseband/acc/rte_vrb_pmd.c | 21 ++--\n drivers/baseband/la12xx/bbdev_la12xx.c | 4 +-\n drivers/common/idpf/idpf_common_device.c | 4 +-\n drivers/common/idpf/idpf_common_virtchnl.c | 8 +-\n drivers/common/qat/qat_qp.c | 10 +-\n drivers/compress/qat/qat_comp.c | 8 +-\n drivers/crypto/ccp/ccp_crypto.c | 14 +--\n drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +-\n drivers/crypto/cnxk/cnxk_se.h | 2 +-\n drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-\n drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 +-\n drivers/crypto/qat/qat_sym_session.c | 52 ++++-----\n .../scheduler/rte_cryptodev_scheduler.c | 6 +-\n drivers/crypto/scheduler/scheduler_failover.c | 12 +-\n drivers/event/cnxk/cnxk_tim_evdev.c | 4 +-\n drivers/event/dlb2/dlb2.c | 6 +-\n drivers/event/dpaa2/dpaa2_eventdev.c | 6 +-\n drivers/event/octeontx/timvf_evdev.c | 4 +-\n drivers/mempool/dpaa/dpaa_mempool.c | 4 +-\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 +-\n drivers/ml/cnxk/cn10k_ml_model.c | 8 +-\n drivers/ml/cnxk/cn10k_ml_ops.c | 11 +-\n drivers/ml/cnxk/cnxk_ml_ops.c | 2 +-\n drivers/ml/cnxk/mvtvm_ml_model.c | 8 +-\n drivers/ml/cnxk/mvtvm_ml_ops.c | 8 +-\n drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-\n drivers/net/avp/avp_ethdev.c | 4 +-\n drivers/net/axgbe/axgbe_ethdev.c | 4 +-\n drivers/net/bnx2x/bnx2x.c | 32 +++---\n drivers/net/bnx2x/bnx2x_stats.c | 10 +-\n drivers/net/bnx2x/bnx2x_vfpf.c | 19 +--\n drivers/net/bnxt/bnxt_flow.c | 34 +++---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 4 +-\n drivers/net/bonding/rte_eth_bond_flow.c | 2 +-\n drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +-\n drivers/net/cnxk/cnxk_tm.c | 5 +-\n drivers/net/cpfl/cpfl_ethdev.c | 3 +-\n drivers/net/cpfl/cpfl_vchnl.c | 4 +-\n drivers/net/cxgbe/clip_tbl.c | 2 +-\n drivers/net/cxgbe/cxgbe_filter.c | 8 +-\n drivers/net/cxgbe/l2t.c | 4 +-\n drivers/net/cxgbe/smt.c | 20 ++--\n drivers/net/dpaa2/dpaa2_tm.c | 2 +-\n drivers/net/e1000/igb_flow.c | 22 ++--\n drivers/net/e1000/igb_pf.c | 6 +-\n drivers/net/enic/enic_main.c | 8 +-\n drivers/net/failsafe/failsafe_ops.c | 6 +-\n drivers/net/gve/base/gve_adminq.c | 2 +-\n drivers/net/hinic/hinic_pmd_flow.c | 40 +++----\n drivers/net/hns3/hns3_fdir.c | 2 +-\n drivers/net/hns3/hns3_flow.c | 4 +-\n drivers/net/i40e/i40e_ethdev.c | 108 ++++++++----------\n drivers/net/i40e/i40e_fdir.c | 28 +++--\n drivers/net/i40e/i40e_flow.c | 56 +++++----\n drivers/net/i40e/i40e_pf.c | 2 +-\n drivers/net/i40e/i40e_tm.c | 11 +-\n drivers/net/i40e/rte_pmd_i40e.c | 34 +++---\n drivers/net/iavf/iavf_fdir.c | 93 +++++++--------\n drivers/net/iavf/iavf_fsub.c | 50 ++++----\n drivers/net/iavf/iavf_generic_flow.c | 2 +-\n drivers/net/iavf/iavf_tm.c | 11 +-\n drivers/net/iavf/iavf_vchnl.c | 9 +-\n drivers/net/ice/ice_dcf.c | 5 +-\n drivers/net/ice/ice_dcf_parent.c | 2 +-\n drivers/net/ice/ice_dcf_sched.c | 11 +-\n drivers/net/ice/ice_diagnose.c | 4 +-\n drivers/net/ice/ice_ethdev.c | 14 +--\n drivers/net/ice/ice_fdir_filter.c | 37 +++---\n drivers/net/ice/ice_generic_flow.c | 2 +-\n drivers/net/ice/ice_hash.c | 2 +-\n drivers/net/ice/ice_tm.c | 11 +-\n drivers/net/idpf/idpf_ethdev.c | 7 +-\n drivers/net/idpf/idpf_rxtx.c | 10 +-\n drivers/net/ipn3ke/ipn3ke_flow.c | 32 +++---\n drivers/net/ipn3ke/ipn3ke_representor.c | 16 +--\n drivers/net/ipn3ke/ipn3ke_tm.c | 6 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 9 +-\n drivers/net/ixgbe/ixgbe_fdir.c | 7 +-\n drivers/net/ixgbe/ixgbe_flow.c | 65 +++++------\n drivers/net/ixgbe/ixgbe_ipsec.c | 8 +-\n drivers/net/ixgbe/ixgbe_pf.c | 4 +-\n drivers/net/ixgbe/ixgbe_tm.c | 11 +-\n drivers/net/ixgbe/rte_pmd_ixgbe.c | 4 +-\n drivers/net/memif/memif_socket.c | 4 +-\n drivers/net/mlx5/mlx5_devx.c | 4 +-\n drivers/net/mlx5/mlx5_flow.c | 38 +++---\n drivers/net/mlx5/mlx5_flow_aso.c | 6 +-\n drivers/net/mlx5/mlx5_flow_hw.c | 16 +--\n drivers/net/mlx5/mlx5_rx.c | 6 +-\n drivers/net/mlx5/mlx5_rxtx_vec.c | 8 +-\n drivers/net/mvpp2/mrvl_tm.c | 2 +-\n drivers/net/nfp/flower/nfp_conntrack.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_flow.c | 16 +--\n .../net/nfp/flower/nfp_flower_representor.c | 2 +-\n drivers/net/nfp/nfp_mtr.c | 10 +-\n drivers/net/ngbe/ngbe_pf.c | 4 +-\n drivers/net/null/rte_eth_null.c | 6 +-\n drivers/net/pcap/pcap_ethdev.c | 2 +-\n drivers/net/pcap/pcap_osdep_freebsd.c | 2 +-\n drivers/net/pcap/pcap_osdep_linux.c | 2 +-\n drivers/net/qede/qede_main.c | 2 +-\n drivers/net/sfc/sfc.c | 2 +-\n drivers/net/sfc/sfc_ef10_tx.c | 2 +-\n drivers/net/sfc/sfc_ethdev.c | 11 +-\n drivers/net/sfc/sfc_flow.c | 20 ++--\n drivers/net/sfc/sfc_flow_rss.c | 2 +-\n drivers/net/sfc/sfc_mae.c | 2 +-\n drivers/net/sfc/sfc_rx.c | 2 +-\n drivers/net/sfc/sfc_tso.c | 2 +-\n drivers/net/sfc/sfc_tso.h | 9 +-\n drivers/net/tap/rte_eth_tap.c | 14 +--\n drivers/net/txgbe/txgbe_ethdev.c | 9 +-\n drivers/net/txgbe/txgbe_fdir.c | 6 +-\n drivers/net/txgbe/txgbe_flow.c | 65 +++++------\n drivers/net/txgbe/txgbe_ipsec.c | 8 +-\n drivers/net/txgbe/txgbe_pf.c | 4 +-\n drivers/net/txgbe/txgbe_tm.c | 11 +-\n drivers/raw/ifpga/afu_pmd_he_hssi.c | 2 +-\n drivers/raw/ifpga/afu_pmd_he_lpbk.c | 2 +-\n drivers/raw/ifpga/afu_pmd_he_mem.c | 2 +-\n drivers/raw/ifpga/afu_pmd_n3000.c | 8 +-\n drivers/raw/ifpga/ifpga_rawdev.c | 10 +-\n drivers/raw/skeleton/skeleton_rawdev.c | 7 +-\n examples/bbdev_app/main.c | 2 +-\n examples/l2fwd-cat/cat.c | 3 +-\n examples/ptpclient/ptpclient.c | 11 +-\n examples/vhost/main.c | 5 +-\n examples/vmdq/main.c | 5 +-\n examples/vmdq_dcb/main.c | 14 +--\n lib/cryptodev/rte_cryptodev.c | 2 +-\n lib/eal/common/eal_common_options.c | 7 +-\n lib/ethdev/rte_ethdev.c | 3 +-\n lib/ethdev/rte_flow.c | 5 +-\n lib/eventdev/rte_event_crypto_adapter.c | 2 +-\n lib/eventdev/rte_event_dma_adapter.c | 4 +-\n lib/eventdev/rte_event_timer_adapter.c | 2 +-\n lib/fib/trie.c | 2 +-\n lib/ip_frag/rte_ipv6_fragmentation.c | 4 +-\n lib/ip_frag/rte_ipv6_reassembly.c | 6 +-\n lib/lpm/rte_lpm6.c | 3 +-\n lib/net/rte_ether.c | 2 +-\n lib/node/ip6_lookup.c | 8 +-\n lib/pdcp/pdcp_process.c | 36 +++---\n lib/pipeline/rte_table_action.c | 8 +-\n lib/rib/rte_rib6.h | 3 +-\n lib/security/rte_security.c | 4 +-\n 162 files changed, 880 insertions(+), 960 deletions(-)\n create mode 100644 devtools/cocci/rte_memcpy.cocci" }