Cover Comment List
List cover comments
GET /api/covers/54623/comments/?format=api
[ { "id": 97052, "web_url": "http://patches.dpdk.org/comment/97052/", "msgid": "<20190611135416.01f6dffc@hermes.lan>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611135416.01f6dffc@hermes.lan", "date": "2019-06-11T20:54:16", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Mon, 10 Jun 2019 10:51:48 -0700\nStephen Hemminger <stephen@networkplumber.org> wrote:\n\n> While testing KNI with netvsc, saw lots of places more code\n> could be safely removed from KNI kernel driver.\n> \n> This is still mostly \"putting lipstick on a pig\" all users\n> would be better off using virtio_user rather than KNI.\n> \n> v2 - get rid of unnecessary padding, combine the unused field patches\n> \n> Stephen Hemminger (7):\n> kni: don't need stubs for rx_mode or ioctl\n> kni: use netdev_alloc_skb\n> kni: don't keep stats in kni_net\n> kni: drop unused fields\n> kni: use proper type for kni fifo's\n> kni: return -EFAULT if copy_from_user fails\n> doc: update KNI documentation\n> \n> .../sample_app_ug/kernel_nic_interface.rst | 18 ++---\n> kernel/linux/kni/kni_dev.h | 21 ++---\n> kernel/linux/kni/kni_misc.c | 17 ++--\n> kernel/linux/kni/kni_net.c | 79 +++++--------------\n> 4 files changed, 38 insertions(+), 97 deletions(-)\n> \n\nDon't believe patchwork the patch is fine, it is getting falsely blamed\nfor failures caused by other changes in ice, bnxt which fail\nFreeBSD build.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ADB7E1D065;\n\tTue, 11 Jun 2019 22:54:25 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 55A4D1D05D\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 22:54:24 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id d126so8188756pfd.2\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 13:54:24 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tz14sm18288917pgs.79.2019.06.11.13.54.22\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 11 Jun 2019 13:54:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RBaniFssqv7LNTym+L1LEV7wyH5qAxw8bEPLxJxmV8A=;\n\tb=llD8PJsIfFBOeH1xc0pezQ73tgXabPg3t7GBvhDsY90ecgL4BTrDUXHhiL/9ecpMAv\n\t3ZAW4T3BsB7Cz/g9put1O9dz7MOy/QR+y00x9bpTdFrfUCdqNHACcVCjx2CD8JxSCFHg\n\tKA55/wGzWgRm3rX6Wh0Rx3T2TU7nWpVqntIqGJOLwYdBAxA/uSyPkl16lO4RFcZiMoK5\n\tmPeTBX26+nJhSICBFVG/8ap40KUNvJI8nW2Kpaouq+1XvxuRJHBcYbIc5235BLyT5rDY\n\tI7UjzMrIgcEfpz1tIIoOaljKrWx7PGWblEWlEk5vICxZQwGgCCbZaMe1zlzLefHGGSee\n\t+eMQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RBaniFssqv7LNTym+L1LEV7wyH5qAxw8bEPLxJxmV8A=;\n\tb=AHDol7e8UIStVW6RNW8gRWUodDTMfCi221gJ4NZfIoskNqVIullb1iWASSgnHOJ/VR\n\t/sl07VvBhRNiDRCy5SeajbJ3qfMox23CNgD+UPXZmQx2Y3XR9pPM87ib6cDqBch8c4ZA\n\thzbwo7pJ18ftKBml5GHUS03sAh8DX93n1uCMPSEPmL1Us+yWtCOzCVULhwr3vFnvzjqN\n\tDahpshXrIQ6RYAmCHzAGFCz6yr32PKc013BP59ECdYkRaDUzw9DCnyHcjuQGkjV37o3K\n\tOaZKyVfCNKj1xV5sznTrcSajrlzBO/8aBHkXhXqeICnjhU9nZcf59uyn8o3At3Q4cE9U\n\torgg==", "X-Gm-Message-State": "APjAAAUHohB2hW+HSPC4ZXnqEvldGiPd/rccRncMqIwRzyT80wcuqOsz\n\tuAQ8jvWv7sjzds4K8D/408zDcw==", "X-Google-Smtp-Source": "APXvYqyicOIV/rsO9eRJMK490s8hFPndcoR+r34uco9dPUawGmH76fpaaNxAVaP+RpnhodRcWfzTlQ==", "X-Received": "by 2002:a65:4544:: with SMTP id\n\tx4mr22342436pgr.323.1560286463150; \n\tTue, 11 Jun 2019 13:54:23 -0700 (PDT)", "Date": "Tue, 11 Jun 2019 13:54:16 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org", "Message-ID": "<20190611135416.01f6dffc@hermes.lan>", "In-Reply-To": "<20190610175155.21374-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97053, "web_url": "http://patches.dpdk.org/comment/97053/", "msgid": "<CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com", "date": "2019-06-11T21:18:42", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "content": "On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger\n<stephen@networkplumber.org> wrote:\n>\n> On Mon, 10 Jun 2019 10:51:48 -0700\n> Stephen Hemminger <stephen@networkplumber.org> wrote:\n>\n> > While testing KNI with netvsc, saw lots of places more code\n> > could be safely removed from KNI kernel driver.\n> >\n> > This is still mostly \"putting lipstick on a pig\" all users\n> > would be better off using virtio_user rather than KNI.\n> >\n> > v2 - get rid of unnecessary padding, combine the unused field patches\n> >\n> > Stephen Hemminger (7):\n> > kni: don't need stubs for rx_mode or ioctl\n> > kni: use netdev_alloc_skb\n> > kni: don't keep stats in kni_net\n> > kni: drop unused fields\n> > kni: use proper type for kni fifo's\n> > kni: return -EFAULT if copy_from_user fails\n> > doc: update KNI documentation\n> >\n> > .../sample_app_ug/kernel_nic_interface.rst | 18 ++---\n> > kernel/linux/kni/kni_dev.h | 21 ++---\n> > kernel/linux/kni/kni_misc.c | 17 ++--\n> > kernel/linux/kni/kni_net.c | 79 +++++--------------\n> > 4 files changed, 38 insertions(+), 97 deletions(-)\n> >\n>\n> Don't believe patchwork the patch is fine, it is getting falsely blamed\n> for failures caused by other changes in ice, bnxt which fail\n> FreeBSD build.\n\nDo you mean failures like the ones below? If so, I think think they\nmight be an unintended\nconsequence of commit a385972c3 \"mk: disable warning for packed member pointer\".\n\n Lance\n\nOS: FreeBSD12-64\nTarget: x86_64-native-bsdapp-gcc\n CC ice_rxtx.o\n CC ice_ethdev.o\ncc1: error: unrecognized command line option\n'-Wno-address-of-packed-member' [-Werror]\ncc1: all warnings being treated as errors\ngmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114:\nbnxt_ethdev.o] Error 1\ngmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37:\nbnxt] Error 2\ngmake[5]: *** Waiting for unfinished jobs....", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B94C11D05D;\n\tTue, 11 Jun 2019 23:18:55 +0200 (CEST)", "from mail-ot1-f68.google.com (mail-ot1-f68.google.com\n\t[209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 8D73A1D01D\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 23:18:54 +0200 (CEST)", "by mail-ot1-f68.google.com with SMTP id i8so13350375oth.10\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 14:18:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Yax8ECyuVBMR7hlIJMn8bZ05x99Yxn+wXgSTN5lSKVA=;\n\tb=C8IcSsHy4696tXKpji7wawWjenSSir9ttQWPgX5LSLcHnn6H+w7eWsTI/3rjVqs3jr\n\ttmVpfUD/24GYA93A1GqFwssb0dQMYrVURdcwGx3beEI9Ihy/zFMzad7TKk1n60fuVPju\n\tJPcvaueFszFdNI1OFlEt45kJggR1XfqiHWqng=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Yax8ECyuVBMR7hlIJMn8bZ05x99Yxn+wXgSTN5lSKVA=;\n\tb=doEChDILoJ1oA3f+FVlA6bwLV+5fC0oIp9F8kiOzhgkCY8mmp9+VFAXsL9gPCWFJhn\n\t6U4+CPePEOKp1lpTjqtoWM7ch+JFBGPKlo//Lwen1UvtY093DL/z/XY36P8TuiHBAfjy\n\tTGGa/WzI0HjyJbqHkFv1hyNxsy+IIsK90DsGgpyoJE/Wxpjte7Q0u7G/ebWeV1Cyv8iZ\n\tIoErMxkM3LXGcS9T4ol/1waLrSWBlJEWrBd9Xdj/XmvjMhiWCmgC/k9th20TWmQ22LzC\n\t59zRj9vwVxdhcoZ0lNEp1AgYpyv/BjdioRQUaco/VoCnYWgcTCxAbuGykqcXZgt9t7OC\n\t53yw==", "X-Gm-Message-State": "APjAAAXGN02FJ1SkfbNXa6dM+zvwkOH+8hRE6Z5wmEc8nZCEhKAjX6R+\n\tdYjvw6kkIlz+Bg1P7Ukiwr7TlMdi1CBRghdbnQHGID8uh98=", "X-Google-Smtp-Source": "APXvYqwKg+FubksnooCfKkes8daT9N6JRtN2N5G2FVzAIw4+DjOzfalt2H1F8NKVvUkDz8X3QKTAD7rzqnJwzWqKQU8=", "X-Received": "by 2002:a9d:6416:: with SMTP id h22mr4650135otl.44.1560287933836;\n\tTue, 11 Jun 2019 14:18:53 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190611135416.01f6dffc@hermes.lan>", "In-Reply-To": "<20190611135416.01f6dffc@hermes.lan>", "From": "Lance Richardson <lance.richardson@broadcom.com>", "Date": "Tue, 11 Jun 2019 17:18:42 -0400", "Message-ID": "<CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>", "To": "Stephen Hemminger <stephen@networkplumber.org>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97054, "web_url": "http://patches.dpdk.org/comment/97054/", "msgid": "<20190611143009.23a34b98@hermes.lan>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611143009.23a34b98@hermes.lan", "date": "2019-06-11T21:30:09", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Tue, 11 Jun 2019 17:18:42 -0400\nLance Richardson <lance.richardson@broadcom.com> wrote:\n\n> On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger\n> <stephen@networkplumber.org> wrote:\n> >\n> > On Mon, 10 Jun 2019 10:51:48 -0700\n> > Stephen Hemminger <stephen@networkplumber.org> wrote:\n> > \n> > > While testing KNI with netvsc, saw lots of places more code\n> > > could be safely removed from KNI kernel driver.\n> > >\n> > > This is still mostly \"putting lipstick on a pig\" all users\n> > > would be better off using virtio_user rather than KNI.\n> > >\n> > > v2 - get rid of unnecessary padding, combine the unused field patches\n> > >\n> > > Stephen Hemminger (7):\n> > > kni: don't need stubs for rx_mode or ioctl\n> > > kni: use netdev_alloc_skb\n> > > kni: don't keep stats in kni_net\n> > > kni: drop unused fields\n> > > kni: use proper type for kni fifo's\n> > > kni: return -EFAULT if copy_from_user fails\n> > > doc: update KNI documentation\n> > >\n> > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++---\n> > > kernel/linux/kni/kni_dev.h | 21 ++---\n> > > kernel/linux/kni/kni_misc.c | 17 ++--\n> > > kernel/linux/kni/kni_net.c | 79 +++++--------------\n> > > 4 files changed, 38 insertions(+), 97 deletions(-)\n> > > \n> >\n> > Don't believe patchwork the patch is fine, it is getting falsely blamed\n> > for failures caused by other changes in ice, bnxt which fail\n> > FreeBSD build. \n> \n> Do you mean failures like the ones below? If so, I think think they\n> might be an unintended\n> consequence of commit a385972c3 \"mk: disable warning for packed member pointer\".\n> \n> Lance\n> \n> OS: FreeBSD12-64\n> Target: x86_64-native-bsdapp-gcc\n> CC ice_rxtx.o\n> CC ice_ethdev.o\n> cc1: error: unrecognized command line option\n> '-Wno-address-of-packed-member' [-Werror]\n> cc1: all warnings being treated as errors\n> gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114:\n> bnxt_ethdev.o] Error 1\n> gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37:\n> bnxt] Error 2\n> gmake[5]: *** Waiting for unfinished jobs....\n\n\nMore than just that\n\n*Build Failed Build #1:\nOS: FreeBSD12-64\nTarget: x86_64-native-bsdapp-gcc+debug\n CC ipn3ke_flow.o\n CC lio_23xx_vf.o\ncc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror]\ncc1: all warnings being treated as errors\ngmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:116: bnxt_ethdev.o] Error 1\ngmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2\ngmake[5]: *** Waiting for unfinished jobs....\n CC i40e_flow.o\n CC rte_eth_null.o\n--\n LD ixgbe_ethdev.o\n AR librte_pmd_ixgbe.a\n INSTALL-LIB librte_pmd_ixgbe.a\ngmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2\ngmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2\ngmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2\ngmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2\ngmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2\n\n*Build Failed Build #2:\nOS: FreeBSD12-64\nTarget: x86_64-native-bsdapp-gcc+shared\n CC rte_eth_null.o.pmd.o\n LD rte_eth_null.o\ncc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror]\ncc1: all warnings being treated as errors\ngmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:116: bnxt_ethdev.o] Error 1\ngmake[6]: *** Waiting for unfinished jobs....\n CC ice_rxtx.o\n== Build drivers/net/ring\n--\n LD ice_ethdev.o\n CC ice_rxtx_vec_sse.o\n CC octeontx_pkovf.o\ngmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Error 2\ngmake[5]: *** Waiting for unfinished jobs....\n CC i40e_tm.o\n CC ice_rxtx_vec_avx2.o\n--\n INSTALL-LIB librte_pmd_ixgbe.so.2.1\n LD librte_pmd_qede.so.1.1\n INSTALL-LIB librte_pmd_qede.so.1.1\ngmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2\ngmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2\ngmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2\ngmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2\ngmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2\n\n*Build Failed Build #3:\nOS: FreeBSD12-64\nTarget: x86_64-native-bsdapp-gcc\n CC ice_dcb.o\n LD rte_eth_null.o\ncc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror]\ncc1: all warnings being treated as errors\ngmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1\ngmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2\ngmake[5]: *** Waiting for unfinished jobs....\n CC ixgbe_phy.o\n CC octeontx_rxtx.o\n--\n LD qede_ethdev.o\n AR librte_pmd_qede.a\n INSTALL-LIB librte_pmd_qede.a\ngmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2\ngmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2\ngmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2\ngmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2\ngmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2\n\n*Build Failed Build #4:\nOS: FreeBSD12-64\nTarget: x86_64-native-bsdapp-clang\n#define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */\n ^\n1 error generated.\ngmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1\n CC ice_flex_pipe.o\ngmake[5]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Error 2\ngmake[5]: *** Waiting for unfinished jobs....\n CC lio_mbox.o\n AR librte_pmd_null.a\n--\n LD ixgbe_ethdev.o\n AR librte_pmd_ixgbe.a\n INSTALL-LIB librte_pmd_ixgbe.a\ngmake[4]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2\ngmake[3]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2\ngmake[2]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2\ngmake[1]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2\ngmake: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2\n*Meson Failed Build #1:\nOS: UB1604-32\nTarget:build-gcc-static\nFAILED: examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o \ngcc -Iexamples/c590b3c@@dpdk-rxtx_callbacks at exe -Iexamples -I../examples -Iexamples/rxtx_callbacks -I../examples/rxtx_callbacks -I. -I../ -Iconfig -I../config -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_cmdline -I../lib/librte_cmdline -Ilib/librte_meter -I../lib/librte_meter -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wunused-parameter -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o' -MF 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o.d' -o 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o' -c ../examples/rxtx_callbacks/main.c\n../examples/rxtx_callbacks/main.c: In function ‘port_init’:\n../examples/rxtx_callbacks/main.c:172:10: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=]\n printf(\"TSC Freq ~= %lu\\nHW Freq ~= %lu\\nRatio : %f\\n\",\n ^\n../examples/rxtx_callbacks/main.c:172:10: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=]\ncc1: all warnings being treated as errors\n[1531/1549] Linking target examples/dpdk-vdpa.\n[1532/1549] Linking target examples/dpdk-timer.\n[1533/1549] Linking target examples/dpdk-tep_termination.\n[1534/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost_crypto at exe/vhost_crypto_main.c.o'.\n[1535/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost at exe/vhost_main.c.o'.\nninja: build stopped: subcommand failed", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B7E291D073;\n\tTue, 11 Jun 2019 23:30:14 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id C1D531D070\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 23:30:12 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id 20so7677570pgr.4\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 14:30:12 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\td6sm13143992pgv.4.2019.06.11.14.30.11\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 11 Jun 2019 14:30:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=spQSv03uzUOOUFd5byW7Teh81GXe7URMPeSGe4rdfN8=;\n\tb=Iym5dsXkrVp9sdRQej27rCmTWlKWJPmfUv4u8iM8Sr9SmRjjh/7nNofdbBMb0aKEwe\n\tJowGRdstFU+3g3a8jvITNEdG54bvaUSDKvFuC+Vv1cO2V9TJ7rKHpQijcMxXS+X8rCPp\n\t15Crrow284ZadwVgnbCIEUjTPC9Atv44/dGKeX8hzkGmmdpuQJEuN5azmvqv7PD27T95\n\tu+V2Mt+UZhBSe8zW2K0Ix5Zz9/6bZGk7L78s3kPs4U6kYHN80xJaX9baIKij00cozn5M\n\tOesxsSPPaG/OXd56EqPTPkpjDu4b/AAYkpvZHawNScRiX4g7QDLeQxiWkQN/lo6Ne8dQ\n\tlXEg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=spQSv03uzUOOUFd5byW7Teh81GXe7URMPeSGe4rdfN8=;\n\tb=lJjfo2W71K8PBE1JF+/dB+QNKlIhNarLltBu2iadhmKbGAnjdpzT/Rb7A7rSQy035H\n\teI6PIcbX/DW3Lh4fX9fOLMem5SfTHcUVtbQN4iE+/y4LGJEuVgBFCYW8JjI9XLsW8g7A\n\tmQsnQj+3DmzU7kUwIrIuhj4Py7Rvqt21N093p2qkc6TZytDTK92mVZ9+qNR8L0aZyLLZ\n\tAa6xwrJw3T9pwCejS5PLkFzGian6SV4qpryxbmdQNxsuoST4MDffAHmkq163dKGc7ZAs\n\tTBkmiZcuoJtyEBxbo7usFgd7OsLWWygXS0J3GxWnxsam8ZAwfAb0Ak174AU6YsXWjTK9\n\taDMA==", "X-Gm-Message-State": "APjAAAWh/vIp525S62lnuzIDJE1/SnjFgKnOWeq8CROtY76YCdCu2FBN\n\tHiR2WYvqDt0sRemFiGb42v6J9A==", "X-Google-Smtp-Source": "APXvYqwOPNC+E9Vh/RBHNwj1zd0xMtIQnm5t/DK+BYWUjoT71VKb4f4OXlsKCxqkREvO0N2Cwu7bow==", "X-Received": "by 2002:aa7:956d:: with SMTP id\n\tx13mr43216621pfq.132.1560288611684; \n\tTue, 11 Jun 2019 14:30:11 -0700 (PDT)", "Date": "Tue, 11 Jun 2019 14:30:09 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Lance Richardson <lance.richardson@broadcom.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org", "Message-ID": "<20190611143009.23a34b98@hermes.lan>", "In-Reply-To": "<CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190611135416.01f6dffc@hermes.lan>\n\t<CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "quoted-printable", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97055, "web_url": "http://patches.dpdk.org/comment/97055/", "msgid": "<CADyeNECyZQYD7Sz9fCzvTkzx-M17xLCNqeq7qyEx5X4W40pHzQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CADyeNECyZQYD7Sz9fCzvTkzx-M17xLCNqeq7qyEx5X4W40pHzQ@mail.gmail.com", "date": "2019-06-11T21:49:47", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "content": "On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger\n<stephen@networkplumber.org> wrote:\n>\n> On Tue, 11 Jun 2019 17:18:42 -0400\n> Lance Richardson <lance.richardson@broadcom.com> wrote:\n>\n> > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger\n> > <stephen@networkplumber.org> wrote:\n> > >\n> > > On Mon, 10 Jun 2019 10:51:48 -0700\n> > > Stephen Hemminger <stephen@networkplumber.org> wrote:\n> > >\n> > > > While testing KNI with netvsc, saw lots of places more code\n> > > > could be safely removed from KNI kernel driver.\n> > > >\n> > > > This is still mostly \"putting lipstick on a pig\" all users\n> > > > would be better off using virtio_user rather than KNI.\n> > > >\n> > > > v2 - get rid of unnecessary padding, combine the unused field patches\n> > > >\n> > > > Stephen Hemminger (7):\n> > > > kni: don't need stubs for rx_mode or ioctl\n> > > > kni: use netdev_alloc_skb\n> > > > kni: don't keep stats in kni_net\n> > > > kni: drop unused fields\n> > > > kni: use proper type for kni fifo's\n> > > > kni: return -EFAULT if copy_from_user fails\n> > > > doc: update KNI documentation\n> > > >\n> > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++---\n> > > > kernel/linux/kni/kni_dev.h | 21 ++---\n> > > > kernel/linux/kni/kni_misc.c | 17 ++--\n> > > > kernel/linux/kni/kni_net.c | 79 +++++--------------\n> > > > 4 files changed, 38 insertions(+), 97 deletions(-)\n> > > >\n> > >\n> > > Don't believe patchwork the patch is fine, it is getting falsely blamed\n> > > for failures caused by other changes in ice, bnxt which fail\n> > > FreeBSD build.\n> >\n> > Do you mean failures like the ones below? If so, I think think they\n> > might be an unintended\n> > consequence of commit a385972c3 \"mk: disable warning for packed member pointer\".\n> >\n> > Lance\n> >\n> > OS: FreeBSD12-64\n> > Target: x86_64-native-bsdapp-gcc\n> > CC ice_rxtx.o\n> > CC ice_ethdev.o\n> > cc1: error: unrecognized command line option\n> > '-Wno-address-of-packed-member' [-Werror]\n> > cc1: all warnings being treated as errors\n> > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114:\n> > bnxt_ethdev.o] Error 1\n> > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37:\n> > bnxt] Error 2\n> > gmake[5]: *** Waiting for unfinished jobs....\n>\n>\n> More than just that\n\nOK, I see now... I'll spin a fix for this one:\n\n> OS: FreeBSD12-64\n> Target: x86_64-native-bsdapp-clang\n> #define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */\n> ^\n> 1 error generated.\n> gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1\n\nThanks,\n\n Lance", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 492191D07F;\n\tTue, 11 Jun 2019 23:50:01 +0200 (CEST)", "from mail-ot1-f68.google.com (mail-ot1-f68.google.com\n\t[209.85.210.68]) by dpdk.org (Postfix) with ESMTP id DF1BC1D078\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 23:49:59 +0200 (CEST)", "by mail-ot1-f68.google.com with SMTP id j19so13446615otq.2\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 14:49:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=pZ/EvkXKFp6tcQdkOktXhOypt9dKVZjmwkzc6NEmFgE=;\n\tb=h8dCE1nTJrN3q6/vPgVO19H8DPfPeb8Je1QNRXHcvPCyBSmbhPF84ShG2IzwP183BZ\n\tjvOZXz4ZROoMuj6z02sxfgMrP5oc3nR5wrF+w4Y6yfdAa46jgRt2JhOgKKFYkg8v36Q1\n\tyXSVvv6MFgHezz8zP13g/6ueG78yfGouuDyvI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=pZ/EvkXKFp6tcQdkOktXhOypt9dKVZjmwkzc6NEmFgE=;\n\tb=Mmj7MvadxJYbY6zuzUQ5dUtdKc1OGH+1gQHc/fFWCUQq6M1IV7KK2I4yA/ElVK2YD9\n\toBkxFpotrXzcVhc4voeqcLj7p62IpqiQn3eir5RTRmb/piO5pZH8AdCBJqqi86Phwcex\n\tWWGE5CWz1EeFAhIhlAaxQ3mnWP8nOIAntyCARA+IRxZS3VmCDprnvz9bIHZ3nHbfABzz\n\tskAssqK+v9zq9LzAyw8sIAVnrkZeAxgCk590MNq6RtumBBFZKL+lAlVqEAKmV9EfKNli\n\taxY8QNWktRhaKkfwwFIi5nZYHGGQ83xyE+vRrDksLnBDfFJjm1HCXwwPESzIs87BYDN6\n\twiuA==", "X-Gm-Message-State": "APjAAAWJUKTP5yw/8E3i6FjNeKggtd6IftAFYq5MKZxvlWc1dVhyrmJR\n\tBBEMp0ZIz8KNpP1kYt/5qbYNTl1/IIoc5tg/40S7+ztN3EY=", "X-Google-Smtp-Source": "APXvYqzSj9f2QMeVUedXWf2p6F0jNWuv+3F/crhj/tLWKDJki0cwvy7eQC6HY/zc6Jr1St6FxokZ59Ol4MzIF7dJXO0=", "X-Received": "by 2002:a9d:6416:: with SMTP id h22mr4745436otl.44.1560289799197;\n\tTue, 11 Jun 2019 14:49:59 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190611135416.01f6dffc@hermes.lan>\n\t<CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>\n\t<20190611143009.23a34b98@hermes.lan>", "In-Reply-To": "<20190611143009.23a34b98@hermes.lan>", "From": "Lance Richardson <lance.richardson@broadcom.com>", "Date": "Tue, 11 Jun 2019 17:49:47 -0400", "Message-ID": "<CADyeNECyZQYD7Sz9fCzvTkzx-M17xLCNqeq7qyEx5X4W40pHzQ@mail.gmail.com>", "To": "Stephen Hemminger <stephen@networkplumber.org>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]