Message ID | 20190610175155.21374-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2DB01C11D; Mon, 10 Jun 2019 19:52:00 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 3C09B1C0C5 for <dev@dpdk.org>; Mon, 10 Jun 2019 19:51:59 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id x15so5756651pfq.0 for <dev@dpdk.org>; Mon, 10 Jun 2019 10:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UKfnJLu6tDJNe4Caqy5YGyFfjbirc5iC3m0DFYHEVDc=; b=OyPT+aNQpYQhBUJv7rF1JB/Br3ntu+a7uyPQjGyfg4CeSll56ExwFrG6R9UdKNlHjr kLk6Q6Y9mkNZyYRDFCFGTK14Ot6G+pR11wRI3fj0QS7cJPC9yzVhu/S2SE9EviYnkk/w VpzlyD0vx2KghN/F8RyntbiPs8egm6wqfHwxNwXnil8joHxXACp4xYsxyfkfeGmYKjJR a8c32bWwRR/FHdf02yTQrQuvCvvZ3v9Js0xCg0SF87lzGw9fvGNzIRobYyh7DwMqNUBz 3VFkxJj73NbwQJQz+flRBh89nyig1noykYwRcPMG9aA7oYs+L2bvwkExeI3Ovr2bUF89 GGTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UKfnJLu6tDJNe4Caqy5YGyFfjbirc5iC3m0DFYHEVDc=; b=sY+cT4dT9r+d+K78c4WoGMaZWDrJ+gtAxu3CxTLB02BpAOoe2rgpnG0FvcvHOGTZBZ O4Upw68lQDeGSLHrWPa3d+u3jwL1+nDtvEHnvvDvDeM80I6pkmw6EiHvaNeXS4n9epF1 oo5r23oqJbWFjZOdjR0kDXGD1pSd36RwVfmAN5OGWkyXFDvaP0uUJLNuAE7y748/PjPq XoNfDC1/0hHvBudW4Nj4kob3iBSmOBkg3FIDIyg5it/RwIYnwb6CP8hU8GABfGoGp7+1 HGCNiPuWw18BlWud2kAEOA5bKsMIRVX9EO7DJjn/C+i42OtkrX28Ado0XNCJ1TufRM1v rvAA== X-Gm-Message-State: APjAAAVm3fBOw944OYFElhvhxjiToLO6+MXP8u13trhSVuE5Uhvyl2gb yLDXrK0J/vNpgzN2ONn8DQY8NQ== X-Google-Smtp-Source: APXvYqxhs79PzgjGrt33P+La+a+1vG9YL2xKTS9qoxYBs7grA+ibuD4EEsgIvvXluVYJVXm0Y7iAxg== X-Received: by 2002:a17:90a:4814:: with SMTP id a20mr22949860pjh.62.1560189118348; Mon, 10 Jun 2019 10:51:58 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l38sm131656pje.12.2019.06.10.10.51.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 10:51:56 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 10 Jun 2019 10:51:48 -0700 Message-Id: <20190610175155.21374-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
kni: cleanups and improvements
|
|
Message
Stephen Hemminger
June 10, 2019, 5:51 p.m. UTC
While testing KNI with netvsc, saw lots of places more code could be safely removed from KNI kernel driver. This is still mostly "putting lipstick on a pig" all users would be better off using virtio_user rather than KNI. v2 - get rid of unnecessary padding, combine the unused field patches Stephen Hemminger (7): kni: don't need stubs for rx_mode or ioctl kni: use netdev_alloc_skb kni: don't keep stats in kni_net kni: drop unused fields kni: use proper type for kni fifo's kni: return -EFAULT if copy_from_user fails doc: update KNI documentation .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- kernel/linux/kni/kni_dev.h | 21 ++--- kernel/linux/kni/kni_misc.c | 17 ++-- kernel/linux/kni/kni_net.c | 79 +++++-------------- 4 files changed, 38 insertions(+), 97 deletions(-)
Comments
On Mon, 10 Jun 2019 10:51:48 -0700 Stephen Hemminger <stephen@networkplumber.org> wrote: > While testing KNI with netvsc, saw lots of places more code > could be safely removed from KNI kernel driver. > > This is still mostly "putting lipstick on a pig" all users > would be better off using virtio_user rather than KNI. > > v2 - get rid of unnecessary padding, combine the unused field patches > > Stephen Hemminger (7): > kni: don't need stubs for rx_mode or ioctl > kni: use netdev_alloc_skb > kni: don't keep stats in kni_net > kni: drop unused fields > kni: use proper type for kni fifo's > kni: return -EFAULT if copy_from_user fails > doc: update KNI documentation > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > kernel/linux/kni/kni_dev.h | 21 ++--- > kernel/linux/kni/kni_misc.c | 17 ++-- > kernel/linux/kni/kni_net.c | 79 +++++-------------- > 4 files changed, 38 insertions(+), 97 deletions(-) > Don't believe patchwork the patch is fine, it is getting falsely blamed for failures caused by other changes in ice, bnxt which fail FreeBSD build.
On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Mon, 10 Jun 2019 10:51:48 -0700 > Stephen Hemminger <stephen@networkplumber.org> wrote: > > > While testing KNI with netvsc, saw lots of places more code > > could be safely removed from KNI kernel driver. > > > > This is still mostly "putting lipstick on a pig" all users > > would be better off using virtio_user rather than KNI. > > > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > Stephen Hemminger (7): > > kni: don't need stubs for rx_mode or ioctl > > kni: use netdev_alloc_skb > > kni: don't keep stats in kni_net > > kni: drop unused fields > > kni: use proper type for kni fifo's > > kni: return -EFAULT if copy_from_user fails > > doc: update KNI documentation > > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > > kernel/linux/kni/kni_dev.h | 21 ++--- > > kernel/linux/kni/kni_misc.c | 17 ++-- > > kernel/linux/kni/kni_net.c | 79 +++++-------------- > > 4 files changed, 38 insertions(+), 97 deletions(-) > > > > Don't believe patchwork the patch is fine, it is getting falsely blamed > for failures caused by other changes in ice, bnxt which fail > FreeBSD build. Do you mean failures like the ones below? If so, I think think they might be an unintended consequence of commit a385972c3 "mk: disable warning for packed member pointer". Lance OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc CC ice_rxtx.o CC ice_ethdev.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1 gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs....
On Tue, 11 Jun 2019 17:18:42 -0400 Lance Richardson <lance.richardson@broadcom.com> wrote: > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > Stephen Hemminger <stephen@networkplumber.org> wrote: > > > > > While testing KNI with netvsc, saw lots of places more code > > > could be safely removed from KNI kernel driver. > > > > > > This is still mostly "putting lipstick on a pig" all users > > > would be better off using virtio_user rather than KNI. > > > > > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > > > Stephen Hemminger (7): > > > kni: don't need stubs for rx_mode or ioctl > > > kni: use netdev_alloc_skb > > > kni: don't keep stats in kni_net > > > kni: drop unused fields > > > kni: use proper type for kni fifo's > > > kni: return -EFAULT if copy_from_user fails > > > doc: update KNI documentation > > > > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > > > kernel/linux/kni/kni_dev.h | 21 ++--- > > > kernel/linux/kni/kni_misc.c | 17 ++-- > > > kernel/linux/kni/kni_net.c | 79 +++++-------------- > > > 4 files changed, 38 insertions(+), 97 deletions(-) > > > > > > > Don't believe patchwork the patch is fine, it is getting falsely blamed > > for failures caused by other changes in ice, bnxt which fail > > FreeBSD build. > > Do you mean failures like the ones below? If so, I think think they > might be an unintended > consequence of commit a385972c3 "mk: disable warning for packed member pointer". > > Lance > > OS: FreeBSD12-64 > Target: x86_64-native-bsdapp-gcc > CC ice_rxtx.o > CC ice_ethdev.o > cc1: error: unrecognized command line option > '-Wno-address-of-packed-member' [-Werror] > cc1: all warnings being treated as errors > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114: > bnxt_ethdev.o] Error 1 > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37: > bnxt] Error 2 > gmake[5]: *** Waiting for unfinished jobs.... More than just that *Build Failed Build #1: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc+debug CC ipn3ke_flow.o CC lio_23xx_vf.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:116: bnxt_ethdev.o] Error 1 gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC i40e_flow.o CC rte_eth_null.o -- LD ixgbe_ethdev.o AR librte_pmd_ixgbe.a INSTALL-LIB librte_pmd_ixgbe.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Build Failed Build #2: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc+shared CC rte_eth_null.o.pmd.o LD rte_eth_null.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:116: bnxt_ethdev.o] Error 1 gmake[6]: *** Waiting for unfinished jobs.... CC ice_rxtx.o == Build drivers/net/ring -- LD ice_ethdev.o CC ice_rxtx_vec_sse.o CC octeontx_pkovf.o gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC i40e_tm.o CC ice_rxtx_vec_avx2.o -- INSTALL-LIB librte_pmd_ixgbe.so.2.1 LD librte_pmd_qede.so.1.1 INSTALL-LIB librte_pmd_qede.so.1.1 gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Build Failed Build #3: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc CC ice_dcb.o LD rte_eth_null.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1 gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC ixgbe_phy.o CC octeontx_rxtx.o -- LD qede_ethdev.o AR librte_pmd_qede.a INSTALL-LIB librte_pmd_qede.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Build Failed Build #4: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-clang #define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */ ^ 1 error generated. gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1 CC ice_flex_pipe.o gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC lio_mbox.o AR librte_pmd_null.a -- LD ixgbe_ethdev.o AR librte_pmd_ixgbe.a INSTALL-LIB librte_pmd_ixgbe.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Meson Failed Build #1: OS: UB1604-32 Target:build-gcc-static FAILED: examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o gcc -Iexamples/c590b3c@@dpdk-rxtx_callbacks at exe -Iexamples -I../examples -Iexamples/rxtx_callbacks -I../examples/rxtx_callbacks -I. -I../ -Iconfig -I../config -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_cmdline -I../lib/librte_cmdline -Ilib/librte_meter -I../lib/librte_meter -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wunused-parameter -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -march=native -D_GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o' -MF 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o.d' -o 'examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.o' -c ../examples/rxtx_callbacks/main.c ../examples/rxtx_callbacks/main.c: In function ‘port_init’: ../examples/rxtx_callbacks/main.c:172:10: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=] printf("TSC Freq ~= %lu\nHW Freq ~= %lu\nRatio : %f\n", ^ ../examples/rxtx_callbacks/main.c:172:10: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=] cc1: all warnings being treated as errors [1531/1549] Linking target examples/dpdk-vdpa. [1532/1549] Linking target examples/dpdk-timer. [1533/1549] Linking target examples/dpdk-tep_termination. [1534/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost_crypto at exe/vhost_crypto_main.c.o'. [1535/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost at exe/vhost_main.c.o'. ninja: build stopped: subcommand failed
On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Tue, 11 Jun 2019 17:18:42 -0400 > Lance Richardson <lance.richardson@broadcom.com> wrote: > > > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > > <stephen@networkplumber.org> wrote: > > > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > > Stephen Hemminger <stephen@networkplumber.org> wrote: > > > > > > > While testing KNI with netvsc, saw lots of places more code > > > > could be safely removed from KNI kernel driver. > > > > > > > > This is still mostly "putting lipstick on a pig" all users > > > > would be better off using virtio_user rather than KNI. > > > > > > > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > > > > > Stephen Hemminger (7): > > > > kni: don't need stubs for rx_mode or ioctl > > > > kni: use netdev_alloc_skb > > > > kni: don't keep stats in kni_net > > > > kni: drop unused fields > > > > kni: use proper type for kni fifo's > > > > kni: return -EFAULT if copy_from_user fails > > > > doc: update KNI documentation > > > > > > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > > > > kernel/linux/kni/kni_dev.h | 21 ++--- > > > > kernel/linux/kni/kni_misc.c | 17 ++-- > > > > kernel/linux/kni/kni_net.c | 79 +++++-------------- > > > > 4 files changed, 38 insertions(+), 97 deletions(-) > > > > > > > > > > Don't believe patchwork the patch is fine, it is getting falsely blamed > > > for failures caused by other changes in ice, bnxt which fail > > > FreeBSD build. > > > > Do you mean failures like the ones below? If so, I think think they > > might be an unintended > > consequence of commit a385972c3 "mk: disable warning for packed member pointer". > > > > Lance > > > > OS: FreeBSD12-64 > > Target: x86_64-native-bsdapp-gcc > > CC ice_rxtx.o > > CC ice_ethdev.o > > cc1: error: unrecognized command line option > > '-Wno-address-of-packed-member' [-Werror] > > cc1: all warnings being treated as errors > > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114: > > bnxt_ethdev.o] Error 1 > > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37: > > bnxt] Error 2 > > gmake[5]: *** Waiting for unfinished jobs.... > > > More than just that OK, I see now... I'll spin a fix for this one: > OS: FreeBSD12-64 > Target: x86_64-native-bsdapp-clang > #define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */ > ^ > 1 error generated. > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1 Thanks, Lance