Cover Comment List
List cover comments
GET /api/covers/53726/comments/?format=api
[ { "id": 96625, "web_url": "http://patches.dpdk.org/comment/96625/", "msgid": "<25162763.l0t2GT9dXN@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/25162763.l0t2GT9dXN@xps", "date": "2019-06-03T22:00:27", "subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "28/05/2019 13:07, Bruce Richardson:\n> This set fixes some issues seen on the automated CI system with building\n> on 32-bit Linux distro's using meson and ninja. The fixes are to disable\n> unsupported parts of the build, and switch the 32-bit builds to always\n> having large file support, so that make and meson are consistent in that\n> regard.\n> \n> V2: add two additional patches to fix clang builds. This allows the\n> test-meson-builds.sh script to run successfully on 32-bit Ubuntu\n> 16.04 systems.\n> \n> Bruce Richardson (5):\n> net/nfp: disable nfp for 32-bit meson builds\n> build: enable large file support on 32-bit\n> build: remove unnecessary large file support defines\n> eal: mark unused function in 32-bit builds\n> build: add libatomic dependency for 32-bit clang compile\n\nApplied, thanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2E1E1B9AD;\n\tTue, 4 Jun 2019 00:00:32 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 840F11B9AC;\n\tTue, 4 Jun 2019 00:00:31 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id EBCAB201E3;\n\tMon, 3 Jun 2019 18:00:30 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Mon, 03 Jun 2019 18:00:30 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 68EA980060;\n\tMon, 3 Jun 2019 18:00:28 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=y6F8+8RqXi1Ju21a3oU767xRdFjEpaNd6k6BpXxQldU=; b=H7ZQMhj58eE8\n\t8wgTnVSOftnMLkYriuovcgLQrTFYgUgpxJWNK9askQ4f8mfkBCJAnYVbvZfd0ez1\n\tqdt1XL1lU9RMI+OICsrdFYtUbq8goD4zvIlH8w84XEhjtUoFCWdQpEGe8TqtSIIR\n\tE+oQlhHD6hcJ3b4GO700Ozx950CPUW8=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=y6F8+8RqXi1Ju21a3oU767xRdFjEpaNd6k6BpXxQl\n\tdU=; b=wGHM0ctKhIMCiXKgoD55iXkUBajlLYagQSkK7qfw8CytMlx5vSWowfRx5\n\t3N9ri1wmAd8wTj3YxQG1TQnQAg7URQGol6pVx1KAbbubm/i2hhTLrBEAgwKhK2+p\n\tkw8PRef28rmMWS9ntHbAo4X/Oof2kESOzTYs/ClS5+GI9upqXr+SajIC1LKv9/HD\n\tfrGvb/k/sfGn9pTcY2yLRAwHDQO6ehUZkRbbP+bHH8uebtI/44mvSj2nvCBVoQvz\n\ty/jFog9Jvu1s+hc9S+6Ff0vMAFromc6IiaxTj7oxt3TKXjHaSsczu/8LiuGNL8CP\n\tyQC5QJpPO0AY2MCApKjOdl2WI12hw==" ], "X-ME-Sender": "<xms:fZj1XG-h3ZR7GQVr-ZhZdqix6wPl4gSkRlKOHyIaiKNfFLujNIQNBQ>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrudefkedgtdehucetufdoteggodetrfdotf\n\tfvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n\tuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n\tcujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n\tshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf\n\thppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh\n\tohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:fZj1XKZpgTPMrkbxlpY5iEMtbl7eC2dxjlCSrwEJ4Xp1OnU08gbUPw>\n\t<xmx:fZj1XEpthFP1WorouSv_zse_IlK98JtzcTW7Wgb-VOEcBGT_mv4SfA>\n\t<xmx:fZj1XP1LS6Y0snRjN7B1oEB5G8R2Hi7dyluilwZgqsFaR5l8tKlkmw>\n\t<xmx:fpj1XATIK6nVUp8OvYPhnMlOgcM4tUyoVLftwby6WMAv4wzk9Q8RGQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>", "Date": "Tue, 04 Jun 2019 00:00:27 +0200", "Message-ID": "<25162763.l0t2GT9dXN@xps>", "In-Reply-To": "<20190528110748.10772-1-bruce.richardson@intel.com>", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>\n\t<20190528110748.10772-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 101922, "web_url": "http://patches.dpdk.org/comment/101922/", "msgid": "<e72b3377-e5f3-56a1-8dcb-1c1e2d5b11d8@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e72b3377-e5f3-56a1-8dcb-1c1e2d5b11d8@redhat.com", "date": "2019-10-02T15:11:56", "subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "submitter": { "id": 598, "url": "http://patches.dpdk.org/api/people/598/?format=api", "name": "Kevin Traynor", "email": "ktraynor@redhat.com" }, "content": "On 28/05/2019 12:07, Bruce Richardson wrote:\n> This set fixes some issues seen on the automated CI system with building\n> on 32-bit Linux distro's using meson and ninja. The fixes are to disable\n> unsupported parts of the build, and switch the 32-bit builds to always\n> having large file support, so that make and meson are consistent in that\n> regard.\n> \n> V2: add two additional patches to fix clang builds. This allows the\n> test-meson-builds.sh script to run successfully on 32-bit Ubuntu\n> 16.04 systems.\n> \n> Bruce Richardson (5):\n> net/nfp: disable nfp for 32-bit meson builds\n> build: enable large file support on 32-bit\n> build: remove unnecessary large file support defines\n> eal: mark unused function in 32-bit builds\n> build: add libatomic dependency for 32-bit clang compile\n> \n\nHi Bruce, Intel validation team reported failures with some 32-bit\nbuilds with meson on 18.11.3-rc1. I've tested with these patches and it\nfixes the problems.\n\nI also took d23e141ffa52 (\"build: set RTE_ARCH_64 based on pointer\nsize\"), to avoid rebasing the other patches to check 'void *' size\nmultiple times.\n\nAny objection to applying for 18.11 branch?\n\nKevin.\n\n> drivers/common/dpaax/dpaax_iova_table.c | 4 ++--\n> drivers/event/octeontx/meson.build | 5 +++++\n> drivers/event/opdl/meson.build | 5 +++++\n> drivers/net/nfp/meson.build | 2 +-\n> examples/vhost_crypto/meson.build | 1 -\n> examples/vhost_scsi/meson.build | 1 -\n> lib/librte_eal/linux/eal/eal_memalloc.c | 1 -\n> lib/librte_eal/linux/eal/eal_memory.c | 2 +-\n> lib/librte_rcu/meson.build | 5 +++++\n> lib/librte_vhost/Makefile | 2 +-\n> mk/arch/arm/rte.vars.mk | 2 +-\n> mk/arch/i686/rte.vars.mk | 2 +-\n> 12 files changed, 22 insertions(+), 10 deletions(-)\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C2761BF13;\n\tWed, 2 Oct 2019 17:12:05 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id EB0B71BF0A;\n\tWed, 2 Oct 2019 17:12:02 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4853618C4283;\n\tWed, 2 Oct 2019 15:12:02 +0000 (UTC)", "from [10.36.118.72] (unknown [10.36.118.72])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7339A5D9D6;\n\tWed, 2 Oct 2019 15:11:57 +0000 (UTC)" ], "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org", "Cc": "Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>, stable@dpdk.org", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>\n\t<20190528110748.10772-1-bruce.richardson@intel.com>", "From": "Kevin Traynor <ktraynor@redhat.com>", "Message-ID": "<e72b3377-e5f3-56a1-8dcb-1c1e2d5b11d8@redhat.com>", "Date": "Wed, 2 Oct 2019 16:11:56 +0100", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.1.0", "MIME-Version": "1.0", "In-Reply-To": "<20190528110748.10772-1-bruce.richardson@intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.6.2\n\t(mx1.redhat.com [10.5.110.62]); Wed, 02 Oct 2019 15:12:02 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 101961, "web_url": "http://patches.dpdk.org/comment/101961/", "msgid": "<20191003082852.GA1797@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191003082852.GA1797@bricha3-MOBL.ger.corp.intel.com", "date": "2019-10-03T08:28:52", "subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Wed, Oct 02, 2019 at 04:11:56PM +0100, Kevin Traynor wrote:\n> On 28/05/2019 12:07, Bruce Richardson wrote:\n> > This set fixes some issues seen on the automated CI system with building\n> > on 32-bit Linux distro's using meson and ninja. The fixes are to disable\n> > unsupported parts of the build, and switch the 32-bit builds to always\n> > having large file support, so that make and meson are consistent in that\n> > regard.\n> > \n> > V2: add two additional patches to fix clang builds. This allows the\n> > test-meson-builds.sh script to run successfully on 32-bit Ubuntu\n> > 16.04 systems.\n> > \n> > Bruce Richardson (5):\n> > net/nfp: disable nfp for 32-bit meson builds\n> > build: enable large file support on 32-bit\n> > build: remove unnecessary large file support defines\n> > eal: mark unused function in 32-bit builds\n> > build: add libatomic dependency for 32-bit clang compile\n> > \n> \n> Hi Bruce, Intel validation team reported failures with some 32-bit\n> builds with meson on 18.11.3-rc1. I've tested with these patches and it\n> fixes the problems.\n> \n> I also took d23e141ffa52 (\"build: set RTE_ARCH_64 based on pointer\n> size\"), to avoid rebasing the other patches to check 'void *' size\n> multiple times.\n> \n> Any objection to applying for 18.11 branch?\n> \n> Kevin.\n> \nNope, no objections.\n\nThanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A6251C013;\n\tThu, 3 Oct 2019 10:29:01 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 021341C00E;\n\tThu, 3 Oct 2019 10:28:59 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Oct 2019 01:28:58 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.237.221.95])\n\tby orsmga006-auth.jf.intel.com with\n\tESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 01:28:55 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-IronPort-AV": "E=Sophos;i=\"5.67,251,1566889200\"; d=\"scan'208\";a=\"196277929\"", "Date": "Thu, 3 Oct 2019 09:28:52 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Kevin Traynor <ktraynor@redhat.com>", "Cc": "dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,\n\tAlejandro Lucero <alejandro.lucero@netronome.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tZhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, \n\tZhang XuemingX <xuemingx.zhang@intel.com>", "Message-ID": "<20191003082852.GA1797@bricha3-MOBL.ger.corp.intel.com>", "References": "<20190527161509.50252-1-bruce.richardson@intel.com>\n\t<20190528110748.10772-1-bruce.richardson@intel.com>\n\t<e72b3377-e5f3-56a1-8dcb-1c1e2d5b11d8@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<e72b3377-e5f3-56a1-8dcb-1c1e2d5b11d8@redhat.com>", "User-Agent": "Mutt/1.11.4 (2019-03-13)", "Subject": "Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]